[3/3] testsuite: Require vectors of doubles for pr97428.c

Message ID alpine.DEB.2.20.2307062204180.28892@tpp.orcam.me.uk
State Accepted
Headers
Series testsuite: Exclude vector tests for unsupported targets |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Maciej W. Rozycki July 6, 2023, 9:36 p.m. UTC
  The pr97428.c test assumes support for vectors of doubles, but some 
targets only support vectors of floats, causing this test to fail with 
such targets.  Limit this test to targets that support vectors of 
doubles then.

	gcc/testsuite/
	* gcc.dg/vect/pr97428.c: Limit to `vect_double' targets.
---
 gcc/testsuite/gcc.dg/vect/pr97428.c |    1 +
 1 file changed, 1 insertion(+)

gcc-test-pr97428-vect-double.diff
  

Comments

Richard Biener July 7, 2023, 6:33 a.m. UTC | #1
On Thu, Jul 6, 2023 at 11:37 PM Maciej W. Rozycki <macro@embecosm.com> wrote:
>
> The pr97428.c test assumes support for vectors of doubles, but some
> targets only support vectors of floats, causing this test to fail with
> such targets.  Limit this test to targets that support vectors of
> doubles then.

OK.

>         gcc/testsuite/
>         * gcc.dg/vect/pr97428.c: Limit to `vect_double' targets.
> ---
>  gcc/testsuite/gcc.dg/vect/pr97428.c |    1 +
>  1 file changed, 1 insertion(+)
>
> gcc-test-pr97428-vect-double.diff
> Index: gcc/gcc/testsuite/gcc.dg/vect/pr97428.c
> ===================================================================
> --- gcc.orig/gcc/testsuite/gcc.dg/vect/pr97428.c
> +++ gcc/gcc/testsuite/gcc.dg/vect/pr97428.c
> @@ -1,4 +1,5 @@
>  /* { dg-do compile } */
> +/* { dg-require-effective-target vect_double } */
>
>  typedef struct { double re, im; } dcmlx_t;
>  typedef struct { double re[4], im[4]; } dcmlx4_t;
  
Maciej W. Rozycki July 11, 2023, 3:01 p.m. UTC | #2
On Fri, 7 Jul 2023, Richard Biener wrote:

> > The pr97428.c test assumes support for vectors of doubles, but some
> > targets only support vectors of floats, causing this test to fail with
> > such targets.  Limit this test to targets that support vectors of
> > doubles then.
> 
> OK.

 Applied, thanks.  OK to backport to the active branches?

  Maciej
  
Richard Biener July 12, 2023, 7:15 a.m. UTC | #3
On Tue, Jul 11, 2023 at 5:01 PM Maciej W. Rozycki <macro@embecosm.com> wrote:
>
> On Fri, 7 Jul 2023, Richard Biener wrote:
>
> > > The pr97428.c test assumes support for vectors of doubles, but some
> > > targets only support vectors of floats, causing this test to fail with
> > > such targets.  Limit this test to targets that support vectors of
> > > doubles then.
> >
> > OK.
>
>  Applied, thanks.  OK to backport to the active branches?

Yes.

>   Maciej
  
Maciej W. Rozycki July 19, 2023, 10:29 a.m. UTC | #4
On Wed, 12 Jul 2023, Richard Biener wrote:

> >  Applied, thanks.  OK to backport to the active branches?
> 
> Yes.

 Now backported, thanks.

  Maciej
  

Patch

Index: gcc/gcc/testsuite/gcc.dg/vect/pr97428.c
===================================================================
--- gcc.orig/gcc/testsuite/gcc.dg/vect/pr97428.c
+++ gcc/gcc/testsuite/gcc.dg/vect/pr97428.c
@@ -1,4 +1,5 @@ 
 /* { dg-do compile } */
+/* { dg-require-effective-target vect_double } */
 
 typedef struct { double re, im; } dcmlx_t;
 typedef struct { double re[4], im[4]; } dcmlx4_t;