diff mbox series

[v2,2/9] aarch64: Align SFrame terminology in comments to specs and x86

Message ID 20240223170800.3993092-3-jremus@linux.ibm.com
State Accepted
Headers
Series s390: Initial support to generate SFrame info from CFI directives in assembler |

Checks

Context Check Description
snail/binutils-gdb-check success Github commit url

Commit Message

Jens Remus Feb. 23, 2024, 5:07 p.m. UTC 
  Use the term "frame pointer" (FP) instead of "base pointer". This aligns
with the terminology used in the SFrame specification. Additionally it
helps not to confuse "base-pointer register" with the term "BASE_REG"
used in the specification to denote either the SP or FP register.

While at it align the frame-pointer and return address register comments
to the x86 AMD64 ones.

gas/
	* config/tc-aarch64.h: Align SFrame terminology in comments to
	  specs and x86 AMD64.

Reviewed-by: Andreas Krebbel <krebbel@linux.ibm.com>
Signed-off-by: Jens Remus <jremus@linux.ibm.com>
---

Notes (jremus):
    This patch can be dropped, if subsequent patch "sframe: Enhance comments
    for SFRAME_CFA_*_REG macros" gets accepted.

 gas/config/tc-aarch64.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Indu Bhagat Feb. 24, 2024, 7:44 a.m. UTC | #1 
On 2/23/24 09:07, Jens Remus wrote:
> Use the term "frame pointer" (FP) instead of "base pointer". This aligns
> with the terminology used in the SFrame specification. Additionally it
> helps not to confuse "base-pointer register" with the term "BASE_REG"
> used in the specification to denote either the SP or FP register.
> 

Thanks for noticing and fixing these.

> While at it align the frame-pointer and return address register comments
> to the x86 AMD64 ones.
> 
> gas/
> 	* config/tc-aarch64.h: Align SFrame terminology in comments to
> 	  specs and x86 AMD64.
> 

Subsequent lines in the ChangeLog need re-indentation as pointed out in 
review of [Patch 1/9].  I will skip mentioning this for the rest of the 
patches in this series from here.

> Reviewed-by: Andreas Krebbel <krebbel@linux.ibm.com>
> Signed-off-by: Jens Remus <jremus@linux.ibm.com>
> ---
> 
> Notes (jremus):
>      This patch can be dropped, if subsequent patch "sframe: Enhance comments
>      for SFRAME_CFA_*_REG macros" gets accepted.
> 

Yes, makes sense. Lets drop this patch and keep the next one.

Thanks

>   gas/config/tc-aarch64.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gas/config/tc-aarch64.h b/gas/config/tc-aarch64.h
> index 1b8badad9fdc..599d78db7908 100644
> --- a/gas/config/tc-aarch64.h
> +++ b/gas/config/tc-aarch64.h
> @@ -271,11 +271,11 @@ extern bool aarch64_support_sframe_p (void);
>   extern unsigned int aarch64_sframe_cfa_sp_reg;
>   #define SFRAME_CFA_SP_REG aarch64_sframe_cfa_sp_reg
>   
> -/* The base-pointer register number for CFA stack trace info.  */
> +/* The frame-pointer register number for SFrame stack trace info.  */
>   extern unsigned int aarch64_sframe_cfa_fp_reg;
>   #define SFRAME_CFA_FP_REG aarch64_sframe_cfa_fp_reg
>   
> -/* The return address register number for CFA stack trace info.  */
> +/* The return address register number for SFrame stack trace info.  */
>   extern unsigned int aarch64_sframe_cfa_ra_reg;
>   #define SFRAME_CFA_RA_REG aarch64_sframe_cfa_ra_reg
>
diff mbox series

Patch

diff --git a/gas/config/tc-aarch64.h b/gas/config/tc-aarch64.h
index 1b8badad9fdc..599d78db7908 100644
--- a/gas/config/tc-aarch64.h
+++ b/gas/config/tc-aarch64.h
@@ -271,11 +271,11 @@  extern bool aarch64_support_sframe_p (void);
 extern unsigned int aarch64_sframe_cfa_sp_reg;
 #define SFRAME_CFA_SP_REG aarch64_sframe_cfa_sp_reg
 
-/* The base-pointer register number for CFA stack trace info.  */
+/* The frame-pointer register number for SFrame stack trace info.  */
 extern unsigned int aarch64_sframe_cfa_fp_reg;
 #define SFRAME_CFA_FP_REG aarch64_sframe_cfa_fp_reg
 
-/* The return address register number for CFA stack trace info.  */
+/* The return address register number for SFrame stack trace info.  */
 extern unsigned int aarch64_sframe_cfa_ra_reg;
 #define SFRAME_CFA_RA_REG aarch64_sframe_cfa_ra_reg