Message ID | 20240223170800.3993092-8-jremus@linux.ibm.com |
---|---|
State | Unresolved |
Headers |
Return-Path: <binutils-bounces+ouuuleilei=gmail.com@sourceware.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp720995dyb; Fri, 23 Feb 2024 09:11:11 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWRjcEPWMMJzRFcAVRq70+4YimKECDTtB/vs42LgAFSQJaPoDfKj5P5JNZLG3fyH74YZ27HmFCaA2iHBi3TSUdLZw0KRw== X-Google-Smtp-Source: AGHT+IHltmYG2nkoiSm1NfKJNriPEYuHttqcdmvYZqHFgS21Gg5Nzn7kPGrPqEtumewiU80PavSU X-Received: by 2002:ac8:7f0d:0:b0:42e:6787:c911 with SMTP id f13-20020ac87f0d000000b0042e6787c911mr368102qtk.51.1708708271703; Fri, 23 Feb 2024 09:11:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708708271; cv=pass; d=google.com; s=arc-20160816; b=eFcF1Z6NgPtt38ux4CQuMLOzngps6OkeKJUJil6tyFAcWW7hw86LLGx441s6zd9C2Y Ax47jlCOp8NZE2lzSXnMALpifQPzHKOypbdWguAXLvZ/0fKQIBaRA8zlIoqtL5TohhzZ ZiTOofHmyMr9ELBFee9zjkXJsZhrtirpWe9nMIwIUfsfYlLNqmbLZsIsE7+eOBIzkU90 jeT6Ns/nP65uitpwpHmqBw3QkzI1fT8OVaFfZGeS2NIHyJIHWxeOg/zxyaMuoAYRyJj7 AclR/zAJluX1z8ClCzDm6awjD/XGUUQcIRKg9xjWUKY/rM7x0dsffd1o997TNpcBkgh+ Dx4A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=xc0ac9H02FAYFCeJ/bKpc3sW7Bi4+/xiIRQP/uN96/Y=; fh=vTbGg4wY0rLaolKO+EtTu7rlJzNAP3iHbUH+MVoijcQ=; b=atUD4Hd4p9+7jf0YFY4SMdzoKItOmwuMVtGSjWTNXzjIM4vTy3+/1xles2UStkoiUb o84qPizdLOgVpQk1EsaPYKbvrkpklVjFWF1NXJZ12NqotXb5WmUH0PtlEbNaeidGfqbk qFvBAsuVHCiaEjFpvukNDHSubOtEB8MwRvCTDlTN06wSD4vAQjNUPygp3ufE6XpV/0Kl k7AHLgSzweKkAaKSeP/hNcjD+gmILBs6y84A73hS1U8wGLTwrvuxU4vs1SNLwrIkPdZY zIBU/Co3AlZlJXQIj3XU9nPqHj8KUK2gqih8UpNFCHZ1HCmiSD6zZQ+Zmj/AyzH0V4b9 2ptQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=KDpWkJLE; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id u12-20020a05622a010c00b0042e42a02531si5370900qtw.192.2024.02.23.09.11.11 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 09:11:11 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=KDpWkJLE; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4FF5A3858282 for <ouuuleilei@gmail.com>; Fri, 23 Feb 2024 17:11:11 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 7A7FD385841A for <binutils@sourceware.org>; Fri, 23 Feb 2024 17:08:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7A7FD385841A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7A7FD385841A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708708099; cv=none; b=QkiuZikOWijHdeUB+CQbEmeg2cMY1a6lrDpOAibes9yfhwwhbnj8gkBC3riT6hLV3S3elr/kXnk+GRYP602suMwIn7c9dshRd/ue41menF9APnMadK66PdhFdjVQecysvtUFySiZ/ZFsPN9/ftHWDEzUdx2l241NXtdkmJTJqSE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708708099; c=relaxed/simple; bh=8wXT1CTqqwfOVlzLDmsKJiYjkWRNBXZlnhJUrQQWVFg=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=MzjeH5TgOJypyAEZbOnPOknpVvJeF+QZtYGK4S9iPXHVHWY3iMpqv/P0RHihGZ/uQeJGK/Hlhbaa8NGcfQT4M8cClqAV6a2P1oHwTGc32MTe6U33KT9/8jqvxkV+9MptQFmyCKuTi5RV0vx9CF1JFnIyncWhFb0awjtYI3r4sIk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41NGvS9i012065; Fri, 23 Feb 2024 17:08:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=xc0ac9H02FAYFCeJ/bKpc3sW7Bi4+/xiIRQP/uN96/Y=; b=KDpWkJLEKmLZ+7m7zLb4Y+Sd7oP56Wzso4IZm2pStPOEiHVIolbDXBKiLxolkR903N6d VZMQyDjSAu/DDxUCj2cdqd+bXPq2RZcUaqeyw8bWnhYKDWEDE+S5KN6Cd+fHaiB1jj+H KgoVGP43e/JsQMEzKqSPdp30ScHOZ00fNmnnVg9LiHqxMkye/5YdShlve1QwLH//x272 NCaYmJ+n9bXugGndQV9u32PSQz7/0rD84dpwZS3mN+r5qvJnybDKY7NefVor+BnBrYq0 JiWg39BCIv4rXtcpxzsJnkGYG5rjcBHR/xABwpXz7w6cf45qlTL/6we49z92kcuzdqmA Ww== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3weyb60awt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Feb 2024 17:08:11 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 41NGaeeP013492; Fri, 23 Feb 2024 17:08:10 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3wb7h0y0kr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Feb 2024 17:08:09 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 41NH845b62849322 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 23 Feb 2024 17:08:06 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 13F192005A; Fri, 23 Feb 2024 17:08:04 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E190C2006A; Fri, 23 Feb 2024 17:08:03 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 23 Feb 2024 17:08:03 +0000 (GMT) From: Jens Remus <jremus@linux.ibm.com> To: binutils@sourceware.org, Indu Bhagat <indu.bhagat@oracle.com> Cc: Jens Remus <jremus@linux.ibm.com>, Andreas Krebbel <krebbel@linux.ibm.com> Subject: [PATCH v2 7/9] gas: Warn if SFrame FDE is skipped due to non-default return column Date: Fri, 23 Feb 2024 18:07:58 +0100 Message-Id: <20240223170800.3993092-8-jremus@linux.ibm.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240223170800.3993092-1-jremus@linux.ibm.com> References: <20240223170800.3993092-1-jremus@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 6IAbCfbz3aCdkn0Hwca35uNXC2bzuzOe X-Proofpoint-ORIG-GUID: 6IAbCfbz3aCdkn0Hwca35uNXC2bzuzOe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-23_03,2024-02-23_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 malwarescore=0 spamscore=0 phishscore=0 bulkscore=0 mlxlogscore=999 lowpriorityscore=0 impostorscore=0 adultscore=0 clxscore=1015 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402230125 X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list <binutils.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>, <mailto:binutils-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/binutils/> List-Post: <mailto:binutils@sourceware.org> List-Help: <mailto:binutils-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>, <mailto:binutils-request@sourceware.org?subject=subscribe> Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791710484929639496 X-GMAIL-MSGID: 1791710484929639496 |
Series |
s390: Initial support to generate SFrame info from CFI directives in assembler
|
|
Checks
Context | Check | Description |
---|---|---|
snail/binutils-gdb-check | warning | Git am fail log |
Commit Message
Jens Remus
Feb. 23, 2024, 5:07 p.m. UTC
Print a warning message if SFrame FDE is skipped due to a non-default DWARF return column (i.e. return address (RA) register number). This may be caused by the use of CFI directive .cfi_return_column with a non-default return address (RA) register number in the processed assembler source code. Warning: skipping SFrame FDE due to non-default DWARF return column gas/ * gen-sframe.c: Warn if SFrame FDE is skipped due to non-default DWARF return column. gas/testsuite/ * gas/cfi-sframe/common-empty-3.d: Update test case to expect for new warning message when SFrame FDE is skipped due to a non-default DWARF return column. Reviewed-by: Andreas Krebbel <krebbel@linux.ibm.com> Signed-off-by: Jens Remus <jremus@linux.ibm.com> --- Notes (jremus): Without this patch the assembler would erroneously generate bad SFrame information for the s390-specific SFrame error test case 4, that gets introduced by patch "s390: Initial support to generate .sframe from CFI directives in assembler". gas/gen-sframe.c | 8 ++++++-- gas/testsuite/gas/cfi-sframe/common-empty-3.d | 1 + 2 files changed, 7 insertions(+), 2 deletions(-)
Comments
On 2/23/24 09:07, Jens Remus wrote: > Print a warning message if SFrame FDE is skipped due to a non-default > DWARF return column (i.e. return address (RA) register number). This > may be caused by the use of CFI directive .cfi_return_column with a > non-default return address (RA) register number in the processed > assembler source code. > > Warning: skipping SFrame FDE due to non-default DWARF return column > > gas/ > * gen-sframe.c: Warn if SFrame FDE is skipped due to non-default > DWARF return column. > > gas/testsuite/ > * gas/cfi-sframe/common-empty-3.d: Update test case to expect > for new warning message when SFrame FDE is skipped due to > a non-default DWARF return column. > One request in my comments below. LGTM, Thanks! PS: I will take a look at the next 2 patches (Patch 8/9 and Patch 9/9) in the series soon. > Reviewed-by: Andreas Krebbel <krebbel@linux.ibm.com> > Signed-off-by: Jens Remus <jremus@linux.ibm.com> > --- > > Notes (jremus): > Without this patch the assembler would erroneously generate bad SFrame > information for the s390-specific SFrame error test case 4, that gets > introduced by patch "s390: Initial support to generate .sframe from CFI > directives in assembler". > This patch is only adding a warning. The absence of it shouldn't have caused any bad SFrame info. > gas/gen-sframe.c | 8 ++++++-- > gas/testsuite/gas/cfi-sframe/common-empty-3.d | 1 + > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/gas/gen-sframe.c b/gas/gen-sframe.c > index 1269b2b77c54..28b49a2a8425 100644 > --- a/gas/gen-sframe.c > +++ b/gas/gen-sframe.c > @@ -1345,7 +1345,10 @@ sframe_do_fde (struct sframe_xlate_ctx *xlate_ctx, > > /* If the return column is not RIP, SFrame format cannot represent it. */ May I ask you to also include an update to this incorrect comment in your patch to something like: /* SFrame format cannot represent a non-default DWARF return column reg. */ > if (xlate_ctx->dw_fde->return_column != DWARF2_DEFAULT_RETURN_COLUMN) > - return SFRAME_XLATE_ERR_NOTREPRESENTED; > + { > + as_warn (_("skipping SFrame FDE due to non-default DWARF return column")); > + return SFRAME_XLATE_ERR_NOTREPRESENTED; > + } > > /* Iterate over the CFIs and create SFrame FREs. */ > for (cfi_insn = dw_fde->data; cfi_insn; cfi_insn = cfi_insn->next) > @@ -1355,7 +1358,8 @@ sframe_do_fde (struct sframe_xlate_ctx *xlate_ctx, > if (err != SFRAME_XLATE_OK) > { > /* Skip generating SFrame stack trace info for the function if any > - offending CFI is encountered by sframe_do_cfi_insn (). */ > + offending CFI is encountered by sframe_do_cfi_insn (). Warning > + message already printed by sframe_do_cfi_insn (). */ > return err; /* Return the error code. */ > } > } > diff --git a/gas/testsuite/gas/cfi-sframe/common-empty-3.d b/gas/testsuite/gas/cfi-sframe/common-empty-3.d > index 5914c620760d..d17521dd88ea 100644 > --- a/gas/testsuite/gas/cfi-sframe/common-empty-3.d > +++ b/gas/testsuite/gas/cfi-sframe/common-empty-3.d > @@ -1,4 +1,5 @@ > #as: --gsframe > +#warning: skipping SFrame FDE due to non-default DWARF return column > #objdump: --sframe=.sframe > #name: SFrame supports only default return column > #...
Am 24.02.2024 um 09:43 schrieb Indu Bhagat: > On 2/23/24 09:07, Jens Remus wrote: >> Print a warning message if SFrame FDE is skipped due to a non-default >> DWARF return column (i.e. return address (RA) register number). This >> may be caused by the use of CFI directive .cfi_return_column with a >> non-default return address (RA) register number in the processed >> assembler source code. >> >> Warning: skipping SFrame FDE due to non-default DWARF return column >> >> gas/ >> * gen-sframe.c: Warn if SFrame FDE is skipped due to non-default >> DWARF return column. >> >> gas/testsuite/ >> * gas/cfi-sframe/common-empty-3.d: Update test case to expect >> for new warning message when SFrame FDE is skipped due to >> a non-default DWARF return column. >> > > One request in my comments below. > > LGTM, Thanks! Thank you for the review! > PS: I will take a look at the next 2 patches (Patch 8/9 and Patch 9/9) > in the series soon. > >> Reviewed-by: Andreas Krebbel <krebbel@linux.ibm.com> >> Signed-off-by: Jens Remus <jremus@linux.ibm.com> >> --- >> >> Notes (jremus): >> Without this patch the assembler would erroneously generate bad >> SFrame >> information for the s390-specific SFrame error test case 4, that >> gets >> introduced by patch "s390: Initial support to generate .sframe >> from CFI >> directives in assembler". >> > > This patch is only adding a warning. The absence of it shouldn't have > caused any bad SFrame info. You are correct! It is not bad SFrame info, but unexpected absent SFrame info. Without the warning the user does not know that the SFrame info is incomplete, which may be an issue during unwinding. >> gas/gen-sframe.c | 8 ++++++-- >> gas/testsuite/gas/cfi-sframe/common-empty-3.d | 1 + >> 2 files changed, 7 insertions(+), 2 deletions(-) >> >> diff --git a/gas/gen-sframe.c b/gas/gen-sframe.c >> index 1269b2b77c54..28b49a2a8425 100644 >> --- a/gas/gen-sframe.c >> +++ b/gas/gen-sframe.c >> @@ -1345,7 +1345,10 @@ sframe_do_fde (struct sframe_xlate_ctx *xlate_ctx, >> /* If the return column is not RIP, SFrame format cannot represent >> it. */ > > May I ask you to also include an update to this incorrect comment in > your patch to something like: > > /* SFrame format cannot represent a non-default DWARF return column > reg. */ Sure. >> if (xlate_ctx->dw_fde->return_column != DWARF2_DEFAULT_RETURN_COLUMN) >> - return SFRAME_XLATE_ERR_NOTREPRESENTED; >> + { >> + as_warn (_("skipping SFrame FDE due to non-default DWARF return >> column")); >> + return SFRAME_XLATE_ERR_NOTREPRESENTED; >> + } Actually I wonder whether the test should better use SFRAME_CFA_RA_REG instead of DWARF2_DEFAULT_RETURN_COLUMN? Of course that would require SFRAME_CFA_RA_REG and x86_sframe_cfa_ra_reg to be defined and assigned for x86 AMD64, instead of removing the currently unused variable in patch 1 of this series. Thinking more about this I wonder why doesn't SFrame by default #define SFRAME_CFA_RA_REG to be DWARF2_DEFAULT_RETURN_COLUMN? >> /* Iterate over the CFIs and create SFrame FREs. */ >> for (cfi_insn = dw_fde->data; cfi_insn; cfi_insn = cfi_insn->next) >> @@ -1355,7 +1358,8 @@ sframe_do_fde (struct sframe_xlate_ctx *xlate_ctx, >> if (err != SFRAME_XLATE_OK) >> { >> /* Skip generating SFrame stack trace info for the function if >> any >> - offending CFI is encountered by sframe_do_cfi_insn (). */ >> + offending CFI is encountered by sframe_do_cfi_insn (). Warning >> + message already printed by sframe_do_cfi_insn (). */ >> return err; /* Return the error code. */ >> } >> } >> diff --git a/gas/testsuite/gas/cfi-sframe/common-empty-3.d >> b/gas/testsuite/gas/cfi-sframe/common-empty-3.d >> index 5914c620760d..d17521dd88ea 100644 >> --- a/gas/testsuite/gas/cfi-sframe/common-empty-3.d >> +++ b/gas/testsuite/gas/cfi-sframe/common-empty-3.d >> @@ -1,4 +1,5 @@ >> #as: --gsframe >> +#warning: skipping SFrame FDE due to non-default DWARF return column >> #objdump: --sframe=.sframe >> #name: SFrame supports only default return column >> #... Thanks and regards, Jens
diff --git a/gas/gen-sframe.c b/gas/gen-sframe.c index 1269b2b77c54..28b49a2a8425 100644 --- a/gas/gen-sframe.c +++ b/gas/gen-sframe.c @@ -1345,7 +1345,10 @@ sframe_do_fde (struct sframe_xlate_ctx *xlate_ctx, /* If the return column is not RIP, SFrame format cannot represent it. */ if (xlate_ctx->dw_fde->return_column != DWARF2_DEFAULT_RETURN_COLUMN) - return SFRAME_XLATE_ERR_NOTREPRESENTED; + { + as_warn (_("skipping SFrame FDE due to non-default DWARF return column")); + return SFRAME_XLATE_ERR_NOTREPRESENTED; + } /* Iterate over the CFIs and create SFrame FREs. */ for (cfi_insn = dw_fde->data; cfi_insn; cfi_insn = cfi_insn->next) @@ -1355,7 +1358,8 @@ sframe_do_fde (struct sframe_xlate_ctx *xlate_ctx, if (err != SFRAME_XLATE_OK) { /* Skip generating SFrame stack trace info for the function if any - offending CFI is encountered by sframe_do_cfi_insn (). */ + offending CFI is encountered by sframe_do_cfi_insn (). Warning + message already printed by sframe_do_cfi_insn (). */ return err; /* Return the error code. */ } } diff --git a/gas/testsuite/gas/cfi-sframe/common-empty-3.d b/gas/testsuite/gas/cfi-sframe/common-empty-3.d index 5914c620760d..d17521dd88ea 100644 --- a/gas/testsuite/gas/cfi-sframe/common-empty-3.d +++ b/gas/testsuite/gas/cfi-sframe/common-empty-3.d @@ -1,4 +1,5 @@ #as: --gsframe +#warning: skipping SFrame FDE due to non-default DWARF return column #objdump: --sframe=.sframe #name: SFrame supports only default return column #...