From patchwork Wed Nov 23 19:44:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yasushi SHOJI X-Patchwork-Id: 25153 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2993979wrr; Wed, 23 Nov 2022 11:52:17 -0800 (PST) X-Google-Smtp-Source: AA0mqf4c9+MBSvnCWtmU41D4UmbBtfW5NFS8hMRG5lnRqkLQE5BlfmuA70kY+6c1UB5nB2AGu+oc X-Received: by 2002:a63:4a0c:0:b0:477:a63e:bdad with SMTP id x12-20020a634a0c000000b00477a63ebdadmr7278144pga.254.1669233137591; Wed, 23 Nov 2022 11:52:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669233137; cv=none; d=google.com; s=arc-20160816; b=LOo8wx7w0RKvOYxuahBgco0Mt5BuloSBuUNvVmY1nqu/FObruKqHuOsSbc5hSiAgKV 0ku7aPk//Ln2gHlsMYeWZhQxSzo46kLnY32wlVKaFZrQLJDeyyGX082m2FxLZgl2KncW Z2AVWGR4gVMcghKtUrGgXXurnk1O9CijqP73c8eqNUeuEHl60sjJCBCUQFDJdhs58uWx 526K6VBna5CPmAyUhiBoigdbSHPI1c9/r0vzGitNqp/Z2SjqgWgjofsF6FfHBo/SBASr oF4qZm1DbuRANtdfHTeY7RINp/founa3Tpt+By1Bzg03RAqD9OtGHtVsmhuO/DVsFmOI Vtgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=iq+S8pJ19eLCshsu6zUlPlVA+hDzpK61Zpqontnfdxc=; b=cLOKnTXhcR2ia6W6xlfx1EoV9w5cocr7g/tGtfjydD8Ne9MP1fxS+Tj+Mzs7Gd04ot eh9SXEt6f0G4wzlBsp8Up0hO/FWaz3F1GaigC27BuqjMb2QorNRATPy3XlmG2lb/qugb L+Ktk0ZlAt5+M3wDx28d4EqUfUIPU0tSbn/mxGJ7/pjjdR8Xrls3VqcFsFvGg1NaIuUf 44wCU+aEdzFVitLq37HnbaNjamk86E8Y9jfEO03QK9YQDuTddupAKow8YN+oCc/KEjMO cvT+SpZbgrQsOATJn+sgdFi1NraJq7UdPdTD0Yv3OjxIC5PGbMK/KjoVYr5Tp/uVBwfS pxvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Dm3D+mqV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ix12-20020a170902f80c00b00174665bbc29si7338744plb.161.2022.11.23.11.52.04; Wed, 23 Nov 2022 11:52:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Dm3D+mqV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239170AbiKWTof (ORCPT + 99 others); Wed, 23 Nov 2022 14:44:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238997AbiKWTob (ORCPT ); Wed, 23 Nov 2022 14:44:31 -0500 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3541970A7; Wed, 23 Nov 2022 11:44:29 -0800 (PST) Received: by mail-pl1-x62e.google.com with SMTP id k7so17550346pll.6; Wed, 23 Nov 2022 11:44:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=iq+S8pJ19eLCshsu6zUlPlVA+hDzpK61Zpqontnfdxc=; b=Dm3D+mqV77F9C7k/l2vNMGPcVRDxMjooR0mQRAyxRRzmPWscbW1/2i1odpXbhpeRtY P3pzvJJBuS5S6DpvDSAM29Kb6D2R4UU5MbTrgxZQxKsX1uZh7VWa78UdZtK1E8SRa+/K /J3QaiKVGVsFYtfyT4JPlP43OCJMpQEuHZNFb5DZOBslo4lGCvTNAAVvbalZu+6ob478 6cn9H8U8CBK7DCT5ZPNNmyQlvg/Ncp1VMJ9dBhLI+2sw+BR2X/0f6SyQWRTzadz17cYi rA2ZSGaIPL1zb970UrUzKAaSqLmZbwwh7lW0mPhiJYwEpHE96kJ1sY3yDICfiVEqrYjC sVsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iq+S8pJ19eLCshsu6zUlPlVA+hDzpK61Zpqontnfdxc=; b=o/Q7CVe0KtAsb5Ot2mE9wfx/IDmGBKpKv/Tt0lC1CJaiG1T2rQmBcrCtgWMWRrLj3C iYOTR5pD02lHozwK2nZnKJOF+zPBmE2MzJCrMPepYQWbTqqOwnMCNno80aMl8nhTyizq r1eWXPxfZkUPzKN9V+sdml8sSf8wTgEduKhgUYvA9HLx2BcAfIsj4YfeXG73CWgF2ALU tXUwqg4LXXK17z+GwExL2rzKR8TSZ0qO6PvuXd4rmmyUNuK5FRsY/fMDZvqf0weMFr59 v0zhHflaThiUAEJVZGN5fjE8HXL13PEpwE4IEhfeE/a+dKY0s35BvF3mGy4fIkUOuToO ag5g== X-Gm-Message-State: ANoB5pk4xJGOHDJ5D8uRSv0eVmH1mzMV36HXCsxegV1R/ndLvv520Rxn QsO4aqUOzoDfP4BULr+89eo= X-Received: by 2002:a17:902:7fc3:b0:189:4d89:a442 with SMTP id t3-20020a1709027fc300b001894d89a442mr2964656plb.151.1669232669273; Wed, 23 Nov 2022 11:44:29 -0800 (PST) Received: from x570.spacecubics.com (221x245x252x90.ap221.ftth.ucom.ne.jp. [221.245.252.90]) by smtp.gmail.com with ESMTPSA id t8-20020a170902e84800b0017a0f40fa19sm14795066plg.191.2022.11.23.11.44.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 11:44:28 -0800 (PST) From: Yasushi SHOJI X-Google-Original-From: Yasushi SHOJI To: Yasushi SHOJI , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] can: mcba_usb: Fix termination command argument Date: Thu, 24 Nov 2022 04:44:06 +0900 Message-Id: <20221123194406.80575-1-yashi@spacecubics.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750317806203677052?= X-GMAIL-MSGID: =?utf-8?q?1750317806203677052?= Microchip USB Analyzer can be set with termination setting ON or OFF. As I've observed, both with my oscilloscope and USB packet capture below, you must send "0" to turn it ON, and "1" to turn it OFF. Reverse the argument value to fix this. These are the two commands sequence, ON then OFF. > No. Time Source Destination Protocol Length Info > 1 0.000000 host 1.3.1 USB 46 URB_BULK out > > Frame 1: 46 bytes on wire (368 bits), 46 bytes captured (368 bits) > USB URB > Leftover Capture Data: a80000000000000000000000000000000000a8 > > No. Time Source Destination Protocol Length Info > 2 4.372547 host 1.3.1 USB 46 URB_BULK out > > Frame 2: 46 bytes on wire (368 bits), 46 bytes captured (368 bits) > USB URB > Leftover Capture Data: a80100000000000000000000000000000000a9 Signed-off-by: Yasushi SHOJI --- drivers/net/can/usb/mcba_usb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/usb/mcba_usb.c b/drivers/net/can/usb/mcba_usb.c index 218b098b261d..67beff1a3876 100644 --- a/drivers/net/can/usb/mcba_usb.c +++ b/drivers/net/can/usb/mcba_usb.c @@ -785,9 +785,9 @@ static int mcba_set_termination(struct net_device *netdev, u16 term) }; if (term == MCBA_TERMINATION_ENABLED) - usb_msg.termination = 1; - else usb_msg.termination = 0; + else + usb_msg.termination = 1; mcba_usb_xmit_cmd(priv, (struct mcba_usb_msg *)&usb_msg);