From patchwork Wed Nov 23 12:28:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 24939 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2755800wrr; Wed, 23 Nov 2022 04:28:36 -0800 (PST) X-Google-Smtp-Source: AA0mqf5XhgYxFdXeWblvDm1b/RYUhrYrHaZdnXuzK4x0WsH1aJHWJLUJFAAosWgsaOngjf89W8Uy X-Received: by 2002:aa7:c84d:0:b0:468:354b:280d with SMTP id g13-20020aa7c84d000000b00468354b280dmr25803796edt.178.1669206516079; Wed, 23 Nov 2022 04:28:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669206516; cv=none; d=google.com; s=arc-20160816; b=GJjXkQMG+U6HGxD6DmbgqHvAuT+rJ3Z9jwN6wBQ9R+1XYYfXcThRb8LVSKxmr6dhg5 63XppQ1TkgeQNFJ2Z0QhcfUcGPIYw8hcamLQ7TosNwZ5DAHxoKHYlbdDxuQn6qbUOpc4 ROKZA5qwnUDFnhrWh5qnsksjqSz5st+n6YCDYsLIVjT+9M9+DDV6zzoLsshmoBkE8Lua EP8ihkvEQLShzqd2e/kKItlOcVE0oG4LBA09ExXkX2nn2vrFl9MX7lxFqyE8IrR+Ngbz SfoXzlatHf1/J/qilUPbYM6rofFnPZ2wOA+dlM6N2sH6Avn/ckMAvs1Rx5B93NVm8bcv Kwjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-disposition:mime-version:message-id:subject:to:date :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=RQ9rQuvXiAikKTSBDH8zN8LaBw2tEGTN9y2K1bGkkrI=; b=0Bu6VqMzR/YTr1jMieGJHCBmZNR1KVFn9zSn9dUnXoBJ/iKcoP9Tuojc0blfrg8Pyp C6ATx94vjKQIbsaQXuwRNH8O101ZBhD225b9iFm6m7ttzjXB3Ovx44D28GjhpXJbGcFa 2KbmsNsCjaengzJvR5B8pEn4zejd5o/tOsjl6kBAa+r7m114fKmJiprFYhhtyZTiew03 d3dDAIfBH6l2ekH1MXCDDuJS1YXGRFvtV+ZTQaiBnzO3SINKfW7JVuKC2EMlPdEIU/71 zmgdf/NapZK9yVlQ73nwiRAKYb17rO+tv+5PJD5MmaHKzC2g9Ph3jcd5QBxp6m4lUodV oH4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=PWqqEQL5; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id p24-20020a056402501800b00461dc830100si994296eda.452.2022.11.23.04.28.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 04:28:36 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=PWqqEQL5; spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DA193385AC29 for ; Wed, 23 Nov 2022 12:28:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DA193385AC29 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669206514; bh=RQ9rQuvXiAikKTSBDH8zN8LaBw2tEGTN9y2K1bGkkrI=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=PWqqEQL5VQAwLCLmqVOlV+3QvSBrjtsS2HgnDU4BO+WFyYEFECh+DdmE8M7rX1sFg RR5v3LzaUtGQYgqpI0DeNBjYpeg0X+djfdAyrcWIBeB84S8XRUHT0HX9ZnO5hbJciM 0cUA3RC65kmAaqW+uyneFbG9qD2TncYbXGPDQ/pI= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id 1D57B3858D20 for ; Wed, 23 Nov 2022 12:28:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1D57B3858D20 Received: by mail-pf1-x42e.google.com with SMTP id g62so17169252pfb.10 for ; Wed, 23 Nov 2022 04:28:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RQ9rQuvXiAikKTSBDH8zN8LaBw2tEGTN9y2K1bGkkrI=; b=EjNz2zcei6+22nmZxza9BUdsOKE9waLin5f1zJ991t7gcJzIRX9hpmJJvDkEvsCFKB 05XGuWHxA/BJhG/9bPeYXm5fbJcaANtubI2zYyUhAq1tDxHFmXowXEnlWdiSq8Evi/xZ KXzcdNbnwGxNjDCIKY50c/LZ6hHg3+4Ro3qK3FtPqNhk3rm3g/GMz/wU57uBO0nW+6fd L7JYvUlmOjdCgM+lGLmVz66axEwslh/djPWD64FE6Y5v/HIJ8j3rhRSg9432wMkoT9SH 9zQ4SpLgXkkkFP4mSDc/0yBg0xdwByrS025Xd5j3dr+Gji/X7/AcuGIxbbs3l2pNqFgL cTiQ== X-Gm-Message-State: ANoB5pnfZ6BkxN5/HwgcqsJorJgRNJFMjcjSYSH5bxtbDMmnzdppnQdV MzciMpE/4jYMLF2xl3JL+hO7VkHGoOk= X-Received: by 2002:aa7:9149:0:b0:574:5637:8172 with SMTP id 9-20020aa79149000000b0057456378172mr2780267pfi.2.1669206502613; Wed, 23 Nov 2022 04:28:22 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id j11-20020a170902da8b00b001894881842dsm1351343plx.151.2022.11.23.04.28.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 04:28:22 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id CDCEC11424B1; Wed, 23 Nov 2022 22:58:19 +1030 (ACDT) Date: Wed, 23 Nov 2022 22:58:19 +1030 To: binutils@sourceware.org Subject: asan: NULL deref in filter_symbols Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3036.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alan Modra via Binutils From: Alan Modra Reply-To: Alan Modra Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org Sender: "Binutils" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750289891821788669?= X-GMAIL-MSGID: =?utf-8?q?1750289891821788669?= If tdata->symbols is NULL, make tdata->symcount zero too. This makes wasm_get_symtab_upper_bound return the proper result and stops cascading errors. * wasm-module.c (wasm_scan_name_function_section): Clear tdata->symcount on error. diff --git a/bfd/wasm-module.c b/bfd/wasm-module.c index 2c2c6c72863..c96665b6e91 100644 --- a/bfd/wasm-module.c +++ b/bfd/wasm-module.c @@ -359,6 +359,7 @@ wasm_scan_name_function_section (bfd *abfd, sec_ptr asect) error_return: if (symbols) bfd_release (abfd, symbols); + tdata->symcount = 0; return false; }