From patchwork Tue Nov 22 22:45:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 24611 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2475764wrr; Tue, 22 Nov 2022 14:47:41 -0800 (PST) X-Google-Smtp-Source: AA0mqf6KdHJKhcy/VDKVg7Glb808VlAgQbVCfVeiDHHSBebyHbABXlcZgK37MJSMsZXpJiUaCEPq X-Received: by 2002:a05:6402:1d87:b0:459:41fa:8e07 with SMTP id dk7-20020a0564021d8700b0045941fa8e07mr5848037edb.140.1669157261337; Tue, 22 Nov 2022 14:47:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669157261; cv=none; d=google.com; s=arc-20160816; b=bmguBBiQQYrPE61+GYTyyEJ+jtxr0GEiGdPrQ5Zny7YO0mSre5PTsmNeXKlg2hgk0b fseo4pfp4wg6ono7NdVuKIkcwJ6RJCKhhcl7L1e4nCYN8lwv5Rzn0U/GIX83oElKcohr gOF+vLtaKAB/QS6Xi0UKDrA0BfSVk14NN7wqJxsXWlja3J0ujLhOWw98eyCUcjneyKT3 fRFGNG849IttuY483Th6hfKLfOajcDXkDa/o53kKbjH+rVca/SSd4WXqdQEevDgHNobe goyR44T5EBIMSEp1Z6KQZxe3P+Fcyppg/caqqrsc0TUF13+k0fkzVYcmDxex+Ac4Ierq O60Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=LaM4uBFPK4LMbdxsIb7pxDSXVMQTFFMHLlfL2JcjVUM=; b=VHoo5cuYhvLFZInJCRGDzTTwpegi3IGbHmcWYIAgbDoK8bzMq+oaebC5cg4pS7o1Zc yXtQt80dPHA9kUkZJRs77lTfb3dGQbGJnGE3B+fx7xoqg5LzJPDbELeuTMOnuPgNNlRV WYi3mjiXMmycoWYm9Mf8P20GyuExraPTXSkU8OrL1eORTeWYqzWI9XjnXwU+7X40hOeu PQZ8hzjpbUMLWHvJU2YSNyIdGhh0Ixo1z6Filx/lKR0/tBkT62obfimanachnHMcAz1i hY6b5wUWLmbgyCnAEzGjENlfdMI1dir+wwX4cdbewcZCbXzHb1t+7mfVjExpDdFclNke J6CQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=bWZjjnUk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qa44-20020a17090786ac00b0078d930212c0si12996964ejc.347.2022.11.22.14.47.17; Tue, 22 Nov 2022 14:47:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=bWZjjnUk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233459AbiKVWqG (ORCPT + 99 others); Tue, 22 Nov 2022 17:46:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235043AbiKVWqC (ORCPT ); Tue, 22 Nov 2022 17:46:02 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EAB1BEB71 for ; Tue, 22 Nov 2022 14:46:01 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id p16so11908283wmc.3 for ; Tue, 22 Nov 2022 14:46:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LaM4uBFPK4LMbdxsIb7pxDSXVMQTFFMHLlfL2JcjVUM=; b=bWZjjnUkUXYQxbQ42tbjZksddrd+wvEx1I46C6UKITkM/8kfuyE3hogrMMlwh2IjKw rHsxbr7rxGwJQdOuptveRWF5qtSx/KQRNEA4O9k1EWu5UztaoRoDhMsIdVGRbFUqsBWp GbTEhkvaPbOpvRQ5cVsx2NLYzyCXZfpl4neqUN1mvwS1egOkWxIGCnENmDAYonbRjiTH B5h5konFG5/TSCSjrDJKp/W4Xx9jtmX4HqwRBVUxw4XEb/IrHhJQSYhjKfxbtlL4j3uZ HfbwzAK0p0ES8y3FY7EFo3FFtimky4pJB1SWinkCpHw2hkKh9/EDP4vL9VzsX6xFjMKF JS0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LaM4uBFPK4LMbdxsIb7pxDSXVMQTFFMHLlfL2JcjVUM=; b=PVu3j7oBKxRe1aapP6WXptr92E2KlU/5fzPQEVCiJue+EgqHumNor8/PQLBlt+ruRP nrufHow4gYmTQQ6OaNsYLoHFN9WzsfFMxTzpqsZy8iS1qLqecVeeZgGZE0uwrgYFnqgS Vg6ecpJKmfrgYNK8ZQzZq7s6ykplE9aphtQl837kJt70d3//YfrOMZSoH3qirJ8LFj0O t9sXcNpHgRW/+fC7JgNZAsF9FyAQNVRAlmUJ7JqbcqEmLz+ACbob7uWynZ3lfIPPsIjq ImnbAh8Xrm/Zrg+18Y0Uz3ZiTC4PP4hB8WzPzkTn4wAhnzf2UGIHL5mLqXSAvku3VWoW 1CPQ== X-Gm-Message-State: ANoB5pmMKDG6OwqrvY3KSyptgvTmVFFurPOKBg3AL2Rl1RaOB/ouYiyn LXeqfRB+tDvQfqdq3S/WYju0xLEYk0w= X-Received: by 2002:a05:600c:1ca4:b0:3cf:7125:fc1d with SMTP id k36-20020a05600c1ca400b003cf7125fc1dmr4421820wms.70.1669157159967; Tue, 22 Nov 2022 14:45:59 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p54a07888.dip0.t-ipconnect.de. [84.160.120.136]) by smtp.gmail.com with ESMTPSA id s2-20020adff802000000b00241c712916fsm13824559wrp.0.2022.11.22.14.45.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 14:45:59 -0800 (PST) Date: Tue, 22 Nov 2022 23:45:57 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] staging: rtl8192e: Remove unchanged variable AcmMethod Message-ID: <7d73a66184e13d5f8d4af7d21564032247a7e923.1669156825.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750238244963727038?= X-GMAIL-MSGID: =?utf-8?q?1750238244963727038?= AcmMethod is initialized and never changed. The evaluation will always have the same result. Remove resulting dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 -- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 1 - drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 2 -- drivers/staging/rtl8192e/rtl819x_Qos.h | 7 ------- 4 files changed, 12 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c index b9c846015d28..80eba5d5ab37 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -224,8 +224,6 @@ void rtl92e_set_reg(struct net_device *dev, u8 variable, u8 *val) u8 acm = pAciAifsn->f.acm; u8 AcmCtrl = rtl92e_readb(dev, AcmHwCtrl); - AcmCtrl = AcmCtrl | ((priv->AcmMethod == 2) ? 0x0 : 0x1); - if (acm) { switch (eACI) { case AC0_BE: diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 399ee9783f99..a8cbeb9545da 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -830,7 +830,6 @@ static void _rtl92e_init_priv_variable(struct net_device *dev) struct r8192_priv *priv = rtllib_priv(dev); u8 i; - priv->AcmMethod = eAcmWay2_SW; priv->dot11_current_preamble_mode = PREAMBLE_AUTO; priv->rtllib->status = 0; priv->polling_timer_on = 0; diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h index b1656d4ecbad..54c7a2128053 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -340,8 +340,6 @@ struct r8192_priv { struct bb_reg_definition PHYRegDef[4]; struct rate_adaptive rate_adaptive; - enum acm_method AcmMethod; - struct rt_firmware *pFirmware; enum rtl819x_loopback LoopbackMode; diff --git a/drivers/staging/rtl8192e/rtl819x_Qos.h b/drivers/staging/rtl8192e/rtl819x_Qos.h index 5073f9f40fdc..c010eb0d6036 100644 --- a/drivers/staging/rtl8192e/rtl819x_Qos.h +++ b/drivers/staging/rtl8192e/rtl819x_Qos.h @@ -97,13 +97,6 @@ enum direction_value { DIR_BI_DIR = 3, }; -enum acm_method { - eAcmWay0_SwAndHw = 0, - eAcmWay1_HW = 1, - eAcmWay2_SW = 2, -}; - - struct acm { u64 UsedTime; u64 MediumTime; From patchwork Tue Nov 22 22:46:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 24612 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2475887wrr; Tue, 22 Nov 2022 14:48:05 -0800 (PST) X-Google-Smtp-Source: AA0mqf6i/CUE8cnIEwLWwn1280MIiSKPMPjX8NRnm86qt/2JzGFCmQCqG9H9y/24Kw2UG8yEGI8l X-Received: by 2002:aa7:c788:0:b0:458:b9f9:9fba with SMTP id n8-20020aa7c788000000b00458b9f99fbamr6289389eds.305.1669157284936; Tue, 22 Nov 2022 14:48:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669157284; cv=none; d=google.com; s=arc-20160816; b=uPnNVS4hFaUQLf78L1qtGtAk7UeB3LUiP36kaSwb74sXon567vbqf3KFiHTD2vkKsM OZ+60axGeJ7Eito5wI3KkzwBMuQKj5RFnmxtg0QiECaJ98B1AIs0K/Cm9l5pzhekZLM9 +rlOPrdc5X84+bmoXB5+DPKjokH1qKvSwy/1PvfHrth4XhETj5w7MNZ8QOSqH1mdySUy oHU+gZKyw4XI+oIxKM3Twpwfcu4aE951yMx8cmF5VT/v5zOYy9Trdz3g4AounlhiVgJo JzyKPKfH9nazDgYAT7Gk4kTcaS1gykqE3XhGvVlN1t6mMgw2YujKcnHAXjVp2xH1hxWC nX2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=4kX4/EANOvk92+tIojhRVqHRQq3FkLftzIvzrby6dVc=; b=hwSHCdC3HyEz8RHBY5BNiCAdSqZwd6Q77JJEAJ1944JBuaauvQ1OdkTJg0v47NXp2q amF4qn1Zgy+WOzhUdSXo4LcCxiC+AccMc2sgYHbvlUbJ12Fn9/1ZZ1L+tAG66cYtU5f4 8iZq3/v9R3A58lqe1X7M20NIFRrO27A1Tu3SDM2H7ahajV/Lnp1m2j9ev3nlZbSPLElI IabFy7bmH4dsQlyo0IEFSH+FSQyl3d9uXCnBi5iLManWN4WGlk7c7iTYYO/iPxmVgDrO aYLMzoTIWDPNaBercXOF6k4Fs31eg7/jmMRlhg6LiTqpKz1/8UjA0JF4f+1+WdAIAJhk HjTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=O+zXr+8O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y18-20020a056402441200b00458ac23f0b8si1847120eda.399.2022.11.22.14.47.41; Tue, 22 Nov 2022 14:48:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=O+zXr+8O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235008AbiKVWqa (ORCPT + 99 others); Tue, 22 Nov 2022 17:46:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235123AbiKVWqR (ORCPT ); Tue, 22 Nov 2022 17:46:17 -0500 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEA15C902B for ; Tue, 22 Nov 2022 14:46:11 -0800 (PST) Received: by mail-wr1-x42c.google.com with SMTP id v1so26945396wrt.11 for ; Tue, 22 Nov 2022 14:46:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4kX4/EANOvk92+tIojhRVqHRQq3FkLftzIvzrby6dVc=; b=O+zXr+8OCFBH3GxbvFTezKFVJ1vV6pp7rEsO9XTqBKuUBAcPD9j+YRjL0x8q2kLrwA 4HW809wY/kZRcV0JxQYe4OCHg4xztFfFuVCJtvIN7fSrFs96wovcZj5fzvx/GjQ2ijgY yz25SMG9Rr8C7MzNvPAQpvG9r5xDBJrcXt0+AGjtgZzDbBVqtsirDHBNuZpa2fXSDrJb SEfDmDajMlZgkTumExqpDrCCtPu69E50ouWOy734MnDQ+u6D2Usvm6NAetu+mSDqmIH1 VZkL/5Qjhr6wb0gHDxkz4ivqIT9iGO8uRzGHjiKYiDYaZXPqh2d7IGCl52OCEOt/tFQ6 NAug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4kX4/EANOvk92+tIojhRVqHRQq3FkLftzIvzrby6dVc=; b=sJqOis0QBDihA2BAN+yxEeomdwmXkRpqTn7jHr1K0dbbcotMsjiXuHo908PRJvZkc8 eG6TlR12bHlA5q13Xpyqd+JyA5KWGF5T8CWacfKxomUXLgMh2AZaa3wRqAvC3PWd8qrc Q2klLpjyUitX0C75GtonbvC/XEMHlT9NisfvjZ/ZgLLxbgxMto6N02AXyaH30eHpDnVh GjR1F91hbNDq2c/oNvHvsLBVEjcuB05aA7tfo0ePHGUn3WSfktEmQyIhyMoaHXYfNt4C 2p/JaXaGARnK7FmcisuQTqqS7zOPXyVsj0je7hizsRvwsioHR2qj9cq1wP2ARKf50/Or UL/w== X-Gm-Message-State: ANoB5pkhh7CzojV/FbB9XVYmhK27F99qHV6IJpPlcHU11p25gP5e7wBZ /OjRSsbnNQX3Jlfj4G+GkYE= X-Received: by 2002:a5d:4533:0:b0:241:d13a:1d52 with SMTP id j19-20020a5d4533000000b00241d13a1d52mr8711702wra.270.1669157170445; Tue, 22 Nov 2022 14:46:10 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p54a07888.dip0.t-ipconnect.de. [84.160.120.136]) by smtp.gmail.com with ESMTPSA id m35-20020a05600c3b2300b003cfd0bd8c0asm133961wms.30.2022.11.22.14.46.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 14:46:10 -0800 (PST) Date: Tue, 22 Nov 2022 23:46:08 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 2/5] staging: rtl8192e: Remove unused variable skb_aggQ Message-ID: <3197be3cb412eea1c662a5bec1b1afda2cee675d.1669156825.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750238269439738723?= X-GMAIL-MSGID: =?utf-8?q?1750238269439738723?= skb_aggQ is initialized, never used and purged. Remove resulting dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 -- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 2 -- drivers/staging/rtl8192e/rtllib.h | 1 - 3 files changed, 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c index 80eba5d5ab37..f02e67f68e23 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -1946,8 +1946,6 @@ void rtl92e_stop_adapter(struct net_device *dev, bool reset) for (i = 0; i < MAX_QUEUE_SIZE; i++) skb_queue_purge(&priv->rtllib->skb_waitQ[i]); - for (i = 0; i < MAX_QUEUE_SIZE; i++) - skb_queue_purge(&priv->rtllib->skb_aggQ[i]); skb_queue_purge(&priv->skb_queue); } diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index a8cbeb9545da..369a59a753fe 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -903,8 +903,6 @@ static void _rtl92e_init_priv_variable(struct net_device *dev) for (i = 0; i < MAX_QUEUE_SIZE; i++) skb_queue_head_init(&priv->rtllib->skb_waitQ[i]); - for (i = 0; i < MAX_QUEUE_SIZE; i++) - skb_queue_head_init(&priv->rtllib->skb_aggQ[i]); } static void _rtl92e_init_priv_lock(struct r8192_priv *priv) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h index 7119c9c5e1fe..1152fbf43383 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1624,7 +1624,6 @@ struct rtllib_device { int mgmt_queue_tail; u8 AsocRetryCount; struct sk_buff_head skb_waitQ[MAX_QUEUE_SIZE]; - struct sk_buff_head skb_aggQ[MAX_QUEUE_SIZE]; bool bdynamic_txpower_enable; From patchwork Tue Nov 22 22:46:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 24613 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2476461wrr; Tue, 22 Nov 2022 14:49:52 -0800 (PST) X-Google-Smtp-Source: AA0mqf6/g5K5atAS1dCxHMrcgA9z+O92ICVtqGMftVjZ+x51Ya94YXqBWBEpfUbvPQdzYjBHXCBv X-Received: by 2002:a17:902:9a43:b0:186:5a0c:85a2 with SMTP id x3-20020a1709029a4300b001865a0c85a2mr15899969plv.79.1669157391906; Tue, 22 Nov 2022 14:49:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669157391; cv=none; d=google.com; s=arc-20160816; b=GcJWjyV8UFFBJQ5o0Cpoglcl9oyU+GlRNkfU8RRB28UpIzGEyrS6ff7RRgLtTadMm4 pAi7gwdUx9Zl6tJ53WsSTfCNpFu3DMiq80dCTJ16pj3Z+gxw8Bztt3K4gCfYbLztvMsx RmjELEOZ4nhUeE5zWN7koUYxLwxsRaaTizstUG5QG4SkT8JLh7b1g8HLRtQeDSy64EJ0 A9xC7QUim+U0NUqeRTEtZE0zrcP5gjM5qbv6UxiSdVOYAKXlO2fSxIEX3H1f8xr1ULwo RIUXnune/QrZntQFLXljzjeDS2MNijymrF5w/1FDR8dZcTihz6ZOe4mvmcnUWSQSsAfr tWyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=loIlTu8AgTjjJ6bJKu7RkzWKYzkXqArC4i+/pF5KBwc=; b=dtvjnAM/qpess/7NNnOsYT5dm9Jy+NKh4hvGGobcLAhxTrdZCejFiWEFKigXMWyFsW MXEuZQco5O/xbkZZQ/+dU/B8FLZQsAgwFsRy/MoHGlTriPyVTni3cBd1Ic2EfDL+nlNP KI6ZNC+iPOOT3rQ8/Kd6YdjlA+aYf9B49DUaurSHC9eowBWNiH9yi0A6KyXnWb8QY8El 6QIGmBYDLd+VCxW6X2WJ4lsO/5kaMN+IVIAqJAgogYU6VYmxW7CfLBlUBlmok53UAMcY uDgu4G42lpjt100YFb1ZH0fATz8zGBb3RPYy2lZ0G75RWP7qWxufIl5bM7p16UQNONkm jvnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="oMkaIW/0"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x22-20020a170902821600b00186658e50desi13109260pln.465.2022.11.22.14.49.38; Tue, 22 Nov 2022 14:49:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="oMkaIW/0"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235171AbiKVWqi (ORCPT + 99 others); Tue, 22 Nov 2022 17:46:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235176AbiKVWqT (ORCPT ); Tue, 22 Nov 2022 17:46:19 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5EDBC9A81 for ; Tue, 22 Nov 2022 14:46:18 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id b12so13191211wrn.2 for ; Tue, 22 Nov 2022 14:46:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=loIlTu8AgTjjJ6bJKu7RkzWKYzkXqArC4i+/pF5KBwc=; b=oMkaIW/0mTFAA+i4rUf7b+aSV01mbdvY80WjaKdbE1lKG6728xGMJDvIHEJWKg8Unj 0PpdDTQlSoXrkEL9Qc9gdm5BQft4jWf4YBsEcjZ7i+rE9nME86Wj0Va32womP+1zVUJ0 8MZQ0n6zRjv4QuV2yX7LwKipH4ajoAJad0o+WVOQCvMIQeyMR0gELhclStesHLnG/FIh qGZhfLz8Yf8PHpMt0W/ieN5GeG/Pg1h/feOSt/Jgd25L/THlGzXYrRRggcPXmiNvQbxB RKgUlhuYK8xq2qS15sWFlF4fDkI4+Lrt7kezfBtxK1q0ZodaDODHvTQL5LLFiQOWFUvY NLYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=loIlTu8AgTjjJ6bJKu7RkzWKYzkXqArC4i+/pF5KBwc=; b=d13qKqfUwDSgBf0ix0Gklm5K557BQVJYKW7OybzE4fpb97h6fCprfO5ZDvz07goK0m 4mfvwjNztXvhMyXH4nTMEKiDJ2u1ohwLeQtZ/R5WYZBpw8MyUv1qY8sLj1iKJf2GcLAl RY1ARa0CD7riMPeW12AgK3galrMUtp9T2haDKsLYZ0/pT9PgWpsjbS3sru3t2D6n5XWd kSONS/+MaqxUKxlbVOxF0OtEQN6DBg9tA/+4T3Gfw1vrSHzIVEa4pTmYJ/3g06qqfOYG K+ijMvkqcli4GFljZ4Z6MwW/KfM3BU3ScVNDTGfjQ2SRr/765DFrLOkLkbl+wWDtG2Js XB7A== X-Gm-Message-State: ANoB5plgmSx7V+MDLX5yd3IEHLc+DZO1ObuhLFa6zR7tVDumuTqVZbSt EzZfZSC368Hwy5BrKx/94IM= X-Received: by 2002:a5d:4bd2:0:b0:241:ec17:6cd8 with SMTP id l18-20020a5d4bd2000000b00241ec176cd8mr191941wrt.108.1669157177281; Tue, 22 Nov 2022 14:46:17 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p54a07888.dip0.t-ipconnect.de. [84.160.120.136]) by smtp.gmail.com with ESMTPSA id j15-20020adfe50f000000b002366d1cc198sm14886700wrm.41.2022.11.22.14.46.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 14:46:16 -0800 (PST) Date: Tue, 22 Nov 2022 23:46:15 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 3/5] staging: rtl8192e: Remove unused variable initialized_at_probe Message-ID: <4855b2dd5b7296b0eb10e697f605fb820e1dfc7b.1669156825.git.philipp.g.hortmann@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750238381841322915?= X-GMAIL-MSGID: =?utf-8?q?1750238381841322915?= initialized_at_probe is initialized and never used. Remove resulting dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 1 - drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 369a59a753fe..7b78bdfadc8d 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -836,7 +836,6 @@ static void _rtl92e_init_priv_variable(struct net_device *dev) priv->up_first_time = 1; priv->blinked_ingpio = false; priv->being_init_adapter = false; - priv->initialized_at_probe = false; priv->bdisable_nic = false; priv->bfirst_init = false; priv->txringcount = 64; diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h index 54c7a2128053..1c00ad709a3c 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -309,7 +309,6 @@ struct r8192_priv { bool bfirst_init; bool bfirst_after_down; - bool initialized_at_probe; bool being_init_adapter; int irq; From patchwork Tue Nov 22 22:46:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 24615 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2476720wrr; Tue, 22 Nov 2022 14:50:44 -0800 (PST) X-Google-Smtp-Source: AA0mqf5G3/3QefQtrfV4c/HKBj+VMF9AG5JXSjHAvMo0GE2pw9WK8S/322hteXXa0My/5atKxB92 X-Received: by 2002:a05:6a00:99b:b0:56d:3de3:c401 with SMTP id u27-20020a056a00099b00b0056d3de3c401mr6123082pfg.6.1669157443829; Tue, 22 Nov 2022 14:50:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669157443; cv=none; d=google.com; s=arc-20160816; b=a7i6cy4u6lKNI7+Tv/IJGa5LtxujqSnqvhH/X2hKDrkDgHPTERv+/K2qdatkvRcjr1 UiQXztTXzQdRWBKfgVgLBJBc1Plce9xrMfGCEzs2Cy6FosQB7L090lw8QQ++mc1+7EB6 DYSeqs+Y3D0gji78k6wBKG/ruuhhNF5kQj6QEsxTnt24j3igKB+ET+mk2BWJCleR6uXh QDIIZwsm1wAS8sumV6teK8ZTaoK4Fo1A2UWHdcElu1bFt1O9yhGkAZetqGdSXTeaEJlY +qMVJ6KAEY8hEkEtlzK8cgwJgC+mOHG1aSxmNAP7dF0MNthEmIqdeQiFyZ2Fy5PCzDSD qShQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=HLjjlcGTaW2VPVbDaaDB7cRE9v4ZMit0fR2VgDn30QM=; b=Eyj1OBEFlccLFb9vitji51xCVl9kfuem00HzEDu1LvwoKK4jeQ9vjWd9DQhzQHD6k6 vaiwYFf0jIbSTQSvZvQbX77WA1fBm4vRZpmx/FJyM1Xr+GI7S5l1JmBugCqdUNy9yAP9 fSIo8LnV+iHISuZfkDUXEjUQbhpmuYPdC5qgB+di5DHk6WErGgyU4wIYaR/Yfxug5WzG n/T5iIcq4wK9r2xJZRR38q7Mw6hodHAGeRqqrH9aW7wj4nuoUffMPOV1mmdcsXFx9Hiy wjLMCiWS+adcmy0TeJMv9966sagMDNBxx6HseyVW9AbfCli3o4yJTe1auJF3h1r/B5nx CcqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=HTTkiYlI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t24-20020a634618000000b0041aaa841692si15617090pga.108.2022.11.22.14.50.29; Tue, 22 Nov 2022 14:50:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=HTTkiYlI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235239AbiKVWqm (ORCPT + 99 others); Tue, 22 Nov 2022 17:46:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235195AbiKVWq0 (ORCPT ); Tue, 22 Nov 2022 17:46:26 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E19B4CB9F1 for ; Tue, 22 Nov 2022 14:46:24 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id x5so22932239wrt.7 for ; Tue, 22 Nov 2022 14:46:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HLjjlcGTaW2VPVbDaaDB7cRE9v4ZMit0fR2VgDn30QM=; b=HTTkiYlIc9Ku+jNrHublAdad+nJaZNuUMCLWS0dq7OdKjZjk8DQKouCO+fBmIJXUr1 6Gj+FOHaPiWkfl2lUWAM0X5349dLz0y6ZkgASzs3o8LKGrcVIcRwK4o/scaGira1Jbn5 G2HZx9wQ2AU3FpjfYm33eUHPqhlQY0QfjMYrV7jfTLWgTkNWvTFwScR3b+cXfXXaX+JX cPKke3t2xd/1eg2v3Aj2lPFEOqzt1PpEQOuAFtrU/ZG6205y4XYsQG8tUKAwuwVPMHKa b17lcPfd6pnV6vbPWrda9dPDYfx8xHx/my+i13j16wQkMD3Nj28y515hKjQywLUqFYsl viHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HLjjlcGTaW2VPVbDaaDB7cRE9v4ZMit0fR2VgDn30QM=; b=Fc5o+/gZWKeKFGZqhvOBvOGBlN5vE0Qozh0Tasi9Ll8JRouGlq9XCu9YOBvDztKK+1 dqS9JFgwbLYtbxwYfUqt2hfc/VupEaJai8l91BLTcvXBdoe/knmorXvLd8QblWsYjymp Sek6RwzkwI5FqDJyCXLq9IUOsVr2Yhp22VL038TBNbcdhC8X4njvOAJql5RsXWSTLlKn R/U7Dn7dGFOSUeme+6tb5VuHKYwa170pyrawcHKzNVEW0aS7hcn5YAefauzUz8X/5bmc 2KhCzTza3D+GwkstkrXkARKBoc02yOuGuI2NgSqeXJUmFSPm5K/Jl5tXbq2h8uZk7HQ2 M4KQ== X-Gm-Message-State: ANoB5pnR4zXax5ZH4CM3n0FKcnTxUro2XKItuSomdGpiCixeBwpU36Gq HI4Pf3lZxHQloFdCGwAoKj8= X-Received: by 2002:adf:ea52:0:b0:241:b999:9e8f with SMTP id j18-20020adfea52000000b00241b9999e8fmr14552580wrn.151.1669157183435; Tue, 22 Nov 2022 14:46:23 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p54a07888.dip0.t-ipconnect.de. [84.160.120.136]) by smtp.gmail.com with ESMTPSA id t5-20020a1c7705000000b003cfd4e6400csm154351wmi.19.2022.11.22.14.46.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 14:46:22 -0800 (PST) Date: Tue, 22 Nov 2022 23:46:21 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 4/5] staging: rtl8192e: Remove unused variable ChannelAccessSetting Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750238435904160453?= X-GMAIL-MSGID: =?utf-8?q?1750238435904160453?= ChannelAccessSetting is never used. Remove resulting dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h index 1c00ad709a3c..ca2e685148d4 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -234,15 +234,6 @@ struct rt_stats { u32 CurrentShowTxate; }; -struct channel_access_setting { - u16 SIFS_Timer; - u16 DIFS_Timer; - u16 SlotTimeTimer; - u16 EIFS_Timer; - u16 CWminIndex; - u16 CWmaxIndex; -}; - struct init_gain { u8 xaagccore1; u8 xbagccore1; @@ -321,9 +312,6 @@ struct r8192_priv { struct delayed_work txpower_tracking_wq; struct delayed_work rfpath_check_wq; struct delayed_work gpio_change_rf_wq; - - struct channel_access_setting ChannelAccessSetting; - struct rtl819x_ops *ops; struct rtllib_device *rtllib; From patchwork Tue Nov 22 22:46:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 24614 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2476717wrr; Tue, 22 Nov 2022 14:50:43 -0800 (PST) X-Google-Smtp-Source: AA0mqf6l2gxbqsBFdjd/eERAm3VfaANpzLvuH+yKENrGk3qZzCezmPVCJWJqbPCHJBSfqrdpCkLn X-Received: by 2002:a17:906:2599:b0:78d:474c:2a59 with SMTP id m25-20020a170906259900b0078d474c2a59mr21647475ejb.759.1669157442964; Tue, 22 Nov 2022 14:50:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669157442; cv=none; d=google.com; s=arc-20160816; b=GhjprILmjMNjnMAH2lqXCZ0XjGiDS9VCtlVbKFtRYY/5st29u5/8/L5xT4eH5J8am/ 7dQN0v76084eTA5FLhfTdJiJL9P0qusBDmDoEq2P6vBNJzRILActu2A5txD1f9l4fDDF VbujMPOZXquuS/VdgOJQ5WD9c53k3TXDAW1uVGG/XzA1Y3JShKjoaXptaqr2gUO7arez 28iy5Ypjz90wup0+qlLnkPUye0oL82hQL5L19YiNK6wX0E4CXj6EB92sdPuiuDcoi+Fs QQd5keRdw/RTfS7zD6OLEVgW6v/vfgMFzW33aimwERR3V+9+UXPK7ZJlHhEZ/XB5hyVU w+SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:to:from:date:dkim-signature; bh=QEaJLedtxp4Hd4OqGYxt+eo5FX2zcD+DeLqh0BnkZRE=; b=T3i5iPQfhvR2otM5DrrW+c5TUjrVU1KSRmolCmvGsmp8yRBTMEhnG2BRVBRRhUDZSm PphEq2zA2jAG3lDd0YoWUUuSDsntbPFVe93vPlCTE+FfKZgSJ97OvkquojYcb3IcmPZC 6eRLuU8/7DrNmR+Irtng/pQ6SR2f/nsbPvtlpcZkv6IE6gylGw1xQ3DY1ogX9fX7/F3y VXJnbOjMcCIsPrhrj5SnC3mpn8Imr15pAt++/7wxJvEDOqTg1gsv5f8H+Kiq4lziUYb+ E8sFcA5Q4hUdTKvgPs+ZLvNxFu5bjsLo89WrXG+ifm2F21APPBB4SA4lhQneHgldI7k4 DYOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=htH6hiIz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q24-20020aa7d458000000b00461d97e5287si10985834edr.344.2022.11.22.14.50.19; Tue, 22 Nov 2022 14:50:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=htH6hiIz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235265AbiKVWqz (ORCPT + 99 others); Tue, 22 Nov 2022 17:46:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234874AbiKVWqd (ORCPT ); Tue, 22 Nov 2022 17:46:33 -0500 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1939CEB97 for ; Tue, 22 Nov 2022 14:46:32 -0800 (PST) Received: by mail-wr1-x433.google.com with SMTP id x17so13531235wrn.6 for ; Tue, 22 Nov 2022 14:46:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QEaJLedtxp4Hd4OqGYxt+eo5FX2zcD+DeLqh0BnkZRE=; b=htH6hiIze2cA8azBJCi1YaJk/VDgg84GAWotqblQ09VK/wBHIlp4u3VqNiJ8ufYlIZ yQV6VjC42gjeBOTKRlWYofvHJubGgUOHGnHFmAKufSrIStW3Df8tnKQNQ5i3xVh3jTMs S6S3x5gxJn9jNSOqO7lvraQpf44qwGKunVEVOF08Flwc9u1/I6QvaYrtpluz/BP5QjHt Za+Mn4P+WDNEFwQS01ihYWoC5l8zpPj7/TFC1OHRmyaSWdX/JlnKRboef72xCBl4rfPj Xtiu1eNh2Rh2w+fXn0pDoN6FlIj9WP+EcGUHsbv6Ib2u9LEqD0gx0D/qD6B5zcz2omiF rcsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QEaJLedtxp4Hd4OqGYxt+eo5FX2zcD+DeLqh0BnkZRE=; b=sMdKHIbNaGt3oFDBD/wLUMhxgRI9gAuKltJzHbT7MLoDh/bWQGR74okR06iasYQ6EW IfZoMhPjpToLjx7ONH1wc4iVjw++5EqBDYvJUsPCFFpx3JFiDDLtq/hBGZOdl9s1IERM SoJkkgM+on/2LXz0DDYA/oJLf6UnXfniIT166UjIfzXyQ5VpUJcjdiZgKxKrgBQAk7Dx +k7g0xIG4cnU6JVJVp4Envg1mCL5sPl7TgzbGlsncS6k7mDQMbnhpZAeRxxW3cD1U0KI fVw2Bm6rOByKr0gtLxcsavjcUsPWLnsuHnYwC4UOrmdTjSxRRHXnRrshmoRHoEIRmkC4 PZCA== X-Gm-Message-State: ANoB5pmoH/lCRVOIWQCugD9nLy0KgTu1aKUCK9X6nHEQ6MrwLjUSFvwv Rywp+6FsdHexW8xMrSWwWnMIJi7jVHE= X-Received: by 2002:adf:c64e:0:b0:236:78cd:f3d2 with SMTP id u14-20020adfc64e000000b0023678cdf3d2mr16049108wrg.719.1669157191563; Tue, 22 Nov 2022 14:46:31 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p54a07888.dip0.t-ipconnect.de. [84.160.120.136]) by smtp.gmail.com with ESMTPSA id u17-20020a05600c19d100b003c6f8d30e40sm153935wmq.31.2022.11.22.14.46.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 14:46:31 -0800 (PST) Date: Tue, 22 Nov 2022 23:46:29 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 5/5] staging: rtl8192e: Remove unused variable int_log Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750238434548870257?= X-GMAIL-MSGID: =?utf-8?q?1750238434548870257?= int_log is initialized and incremented but never evaluated. Remove resulting dead code. Signed-off-by: Philipp Hortmann --- drivers/staging/rtl8192e/rtl8192e/r8190P_def.h | 15 --------------- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 3 --- drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 2 -- 3 files changed, 20 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h b/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h index 53fd79a28189..ac192254a4bb 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h +++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_def.h @@ -154,21 +154,6 @@ struct tx_fwinfo_8190pci { }; -struct log_int_8190 { - u32 nIMR_COMDOK; - u32 nIMR_MGNTDOK; - u32 nIMR_HIGH; - u32 nIMR_VODOK; - u32 nIMR_VIDOK; - u32 nIMR_BEDOK; - u32 nIMR_BKDOK; - u32 nIMR_ROK; - u32 nIMR_RCOK; - u32 nIMR_TBDOK; - u32 nIMR_BDOK; - u32 nIMR_RXFOVW; -}; - struct phy_ofdm_rx_status_rxsc_sgien_exintfflag { u8 reserved:4; u8 rxsc:2; diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index 7b78bdfadc8d..f8fbe78ccad9 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -866,8 +866,6 @@ static void _rtl92e_init_priv_variable(struct net_device *dev) priv->rst_progress = RESET_TYPE_NORESET; priv->force_reset = false; memset(priv->rtllib->swcamtable, 0, sizeof(struct sw_cam_table) * 32); - - memset(&priv->int_log, 0, sizeof(struct log_int_8190)); priv->rx_ctr = 0; priv->rtllib->wx_set_enc = 0; priv->hw_radio_off = false; @@ -2185,7 +2183,6 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev) if (inta & IMR_ROK) { priv->stats.rxint++; - priv->int_log.nIMR_ROK++; tasklet_schedule(&priv->irq_rx_tasklet); } diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h index ca2e685148d4..cceb77492363 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h @@ -317,8 +317,6 @@ struct r8192_priv { struct work_struct reset_wq; - struct log_int_8190 int_log; - enum rt_customer_id CustomerID;