From patchwork Tue Nov 22 08:12:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frieder Schrempf X-Patchwork-Id: 24185 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2075669wrr; Tue, 22 Nov 2022 00:27:35 -0800 (PST) X-Google-Smtp-Source: AA0mqf7+PIp6eiSwr7cqb3YnDPvf9xmqiVXC5eIPb+ovAQOz6WzBqik8KkN2ilKD9C9qIbXSnGmH X-Received: by 2002:a05:6402:3807:b0:45c:a651:87f1 with SMTP id es7-20020a056402380700b0045ca65187f1mr3556164edb.359.1669105655367; Tue, 22 Nov 2022 00:27:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669105655; cv=none; d=google.com; s=arc-20160816; b=P/LVyXwafqH7nka3wqHsVosSa9OtKNOlaOiIhbc++sm1DSFJWrpMqdH45eNXXBH5tx 5UuSON1XU79O3j//vdmpV/h7nc8nLbmiM8b9vNURLFtJGJET1wWL1DDmiWaxAMhkzq+V pa10xyS8qDUI+1/8+dceCl3lyKfhGqmauzSPNPo8kTHlHjFJ2amFxxFG9B7WNjWvILou Rf2nFkaa1kERsEe9G5hzh8BQVPFYxqgtrYTLEw6Ac/T4KhqhmpZXPkWdBt/KHjBD/8X8 s6sE7XeKOSQGfMDuO86VJfTMSch8lu5XMJD628dOX56muJJ8YG/7skb0eyaKirCxSAU5 +Sng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=HF/dQ7k7L9EVK7uPaLgIE5BOxzPXAihnaMZPR/UT1nM=; b=UnZdB67wvpHYWeXj6wrHHdW6VmxoGnbbocxTC5Hls2QeingGXb5IS8+KeGueN4aa2P lcsJ24eH4XTXvjId/1diy3uK5Z5Inys4bjCe5aLK15r1IX7u1gCwxqHlakhqr1RmL4Ci +LBu4vMyy8E0CxgBZR/0NXbnDtZW6DiKXcuH49vzjc8CwDTp30a1MeWsw0yy2vHB9HvZ nhNlyjw2bD5ofKpOaQJ/RYweC1deUM4jneBCXAtTpcwwy6R5dZOdu+HSPwe5zb9fPUN3 JYR3tHbAcgo3TTXCrU5CFPfhef75JM2RyatUBMeAEstb3Badf4XCtwLwTHYItRiF7RgH T0gQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fris.de header.s=dkim header.b=C7hrUPVl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=fris.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f19-20020a0564021e9300b00461c852af19si11618863edf.633.2022.11.22.00.27.11; Tue, 22 Nov 2022 00:27:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@fris.de header.s=dkim header.b=C7hrUPVl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=fris.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232715AbiKVIXs (ORCPT + 99 others); Tue, 22 Nov 2022 03:23:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232132AbiKVIXr (ORCPT ); Tue, 22 Nov 2022 03:23:47 -0500 Received: from mail.fris.de (mail.fris.de [116.203.77.234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CB3D29351 for ; Tue, 22 Nov 2022 00:23:45 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 5C2D4BFCC8; Tue, 22 Nov 2022 09:23:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fris.de; s=dkim; t=1669105422; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding; bh=HF/dQ7k7L9EVK7uPaLgIE5BOxzPXAihnaMZPR/UT1nM=; b=C7hrUPVl5EI4C4/6K7jCUsTQ4eKq9V2kKy+XeTx1e/lWQQdMGQErEC+cP3zm1LhiM5vu82 Ij6+ujbbTpSGVgKedvZYIToLbyCH2cK9CRi/uDRhnpsqhALmVNwKE35GmyOVW35oxMfPu5 2cDOprgQy7jTqapK+aTZ8scjkYhA7SZOgHOsLewhOmkF+xxc8j0RhpG1K6M6AAqHzlsUYS 1WUet/2/i9ftPmd2Z7suQuZyEdJcu4x34ps++NvTPg0ADASSxR6cMmmCYyhIMewPEMTe1u okf0LOem1UHOCsInXIx6xyUQKrsd30wrUcSyI9djo19I61vVNe5c1B9mZ5h5zQ== From: Frieder Schrempf To: Andrzej Hajda , Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, Frieder Schrempf , Linus Walleij , linux-kernel@vger.kernel.org, Marek Vasut , Neil Armstrong , Robert Foss Cc: Alexander Stein , Christophe JAILLET , Jernej Skrabec , Jonas Karlman , =?utf-8?b?Sm9zw6kgRXhww7NzaXRv?= , Laurent Pinchart , Sam Ravnborg , =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= Subject: [PATCH] drm/bridge: ti-sn65dsi83: Fix delay after reset deassert to match spec Date: Tue, 22 Nov 2022 09:12:18 +0100 Message-Id: <20221122081219.20143-1-frieder@fris.de> MIME-Version: 1.0 X-Last-TLS-Session-Version: TLSv1.3 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750184132118801199?= X-GMAIL-MSGID: =?utf-8?q?1750184132118801199?= From: Frieder Schrempf The datasheet specifies a delay of 10 milliseconds, but the current driver only waits for 1 ms. Fix this to make sure the initialization sequence meets the spec. Fixes: ceb515ba29ba ("drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver") Signed-off-by: Frieder Schrempf Reviewed-by: Alexander Stein --- drivers/gpu/drm/bridge/ti-sn65dsi83.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c index 7ba9467fff12..047c14ddbbf1 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c @@ -346,7 +346,7 @@ static void sn65dsi83_atomic_enable(struct drm_bridge *bridge, /* Deassert reset */ gpiod_set_value_cansleep(ctx->enable_gpio, 1); - usleep_range(1000, 1100); + usleep_range(10000, 11000); /* Get the LVDS format from the bridge state. */ bridge_state = drm_atomic_get_new_bridge_state(state, bridge);