From patchwork Tue Nov 22 07:37:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hanjun Guo X-Patchwork-Id: 24181 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2067444wrr; Tue, 22 Nov 2022 00:05:28 -0800 (PST) X-Google-Smtp-Source: AA0mqf5WZsSC8nQoUiER2dWc3NeIEYIqgkXv52NrLwKgnnUyM+I67yn9QX3/ouG1nKa2nDWTxxrC X-Received: by 2002:aa7:80d0:0:b0:565:c4e2:2634 with SMTP id a16-20020aa780d0000000b00565c4e22634mr6239382pfn.0.1669104328340; Tue, 22 Nov 2022 00:05:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669104328; cv=none; d=google.com; s=arc-20160816; b=Nd3hioOwscmfRBquGcWhTH8axWpufM5u4gJKq9TiCKTgz1dxQ7aHypOuZp/Qet++6g lq/CEgz5iSLahaFguyYPT3n26oUA/I/8A9ZTnfxcGvR8Q008By/4Sr3bvFbh+/Ag7vJX 2oq5yUfUO/sa4NWBHpbeAdp0yyr9kfPF/06P+XCU7Ph9aXOZPNPad1WihmB6R8tWaNsL L52Vu8n0pXDxGHFZL0nTD0D1rLLyAU0P/sl0gez9Ojyk7puDcSuvygLV/Q5L9+whSnsY gB32MALnnY9nfG3iq/e1hNDZuliUMH5kLQt2DuWQh6Ui5sGV1sY9LA1n6dlKITgfAz3p ahlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=5d+kKkyBbvh0lSiLrbEx4r/u/3rRY70CHFhqTqOJf74=; b=HpuGHP7p0HUYuGcG2q8nF/R8phuw5jot5INIRtox1FoRxmam8VEXvZWJt4civ45OJ0 A30ntMPOmf2gxlBjt66A1xkVawEau8XX1k047TTtWDlVy+tN6mn5gzGOEzqHov++GvJa nF+VIhR15BZncDUtS6CrWUfYoOuzsZVqwnwVmh8x50Uqhztu/oB1M0D5m+1uD5jibYs2 f+6LUGEPyufNsF6q5qcmBV+An1N4IvO5qwSYy04Uuiy+FzU4mYWo3lxH4ppTPM969r0D E6497fdjXC4as4AlXShpw+9Fgg60G/586LC/jXhnCgy6Re9LJmRxNAtbbTT5G465KIhJ /8uA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ce11-20020a056a002a0b00b0056e4c95266bsi12972819pfb.77.2022.11.22.00.05.14; Tue, 22 Nov 2022 00:05:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232597AbiKVHxk (ORCPT + 99 others); Tue, 22 Nov 2022 02:53:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232563AbiKVHxg (ORCPT ); Tue, 22 Nov 2022 02:53:36 -0500 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F72C32070 for ; Mon, 21 Nov 2022 23:53:35 -0800 (PST) Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NGbxv3lTXzqSYG; Tue, 22 Nov 2022 15:49:39 +0800 (CST) Received: from dggpemm500002.china.huawei.com (7.185.36.229) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 22 Nov 2022 15:53:33 +0800 Received: from linux-ibm.site (10.175.102.37) by dggpemm500002.china.huawei.com (7.185.36.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 22 Nov 2022 15:53:33 +0800 From: Hanjun Guo To: Greg Kroah-Hartman , "Rafael J. Wysocki" CC: , Won Chung , "Hanjun Guo" Subject: [PATCH] driver core: location: Free struct acpi_pld_info *pld before return false Date: Tue, 22 Nov 2022 15:37:28 +0800 Message-ID: <1669102648-11517-1-git-send-email-guohanjun@huawei.com> X-Mailer: git-send-email 1.7.12.4 MIME-Version: 1.0 X-Originating-IP: [10.175.102.37] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500002.china.huawei.com (7.185.36.229) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750182740255659114?= X-GMAIL-MSGID: =?utf-8?q?1750182740255659114?= struct acpi_pld_info *pld should be freed before the return of allocation failure, to prevent memory leak, add the ACPI_FREE() to fix it. Fixes: bc443c31def5 ("driver core: location: Check for allocations failure") Signed-off-by: Hanjun Guo --- drivers/base/physical_location.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/base/physical_location.c b/drivers/base/physical_location.c index 87af641..951819e 100644 --- a/drivers/base/physical_location.c +++ b/drivers/base/physical_location.c @@ -24,8 +24,11 @@ bool dev_add_physical_location(struct device *dev) dev->physical_location = kzalloc(sizeof(*dev->physical_location), GFP_KERNEL); - if (!dev->physical_location) + if (!dev->physical_location) { + ACPI_FREE(pld); return false; + } + dev->physical_location->panel = pld->panel; dev->physical_location->vertical_position = pld->vertical_position; dev->physical_location->horizontal_position = pld->horizontal_position;