From patchwork Tue Nov 22 06:47:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: wangyufen X-Patchwork-Id: 24165 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2035821wrr; Mon, 21 Nov 2022 22:29:36 -0800 (PST) X-Google-Smtp-Source: AA0mqf6TEXMEQu8zeElipguqJZkRyWUSdBFh1HFKC/CBHFKqhjlNPU5DZyei23vhx3HH9Z5C5sNj X-Received: by 2002:a63:2745:0:b0:475:2f42:7638 with SMTP id n66-20020a632745000000b004752f427638mr2823385pgn.439.1669098575743; Mon, 21 Nov 2022 22:29:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669098575; cv=none; d=google.com; s=arc-20160816; b=n1NiB0JHFrKtLmEo5qx3yeoxV+rl/LRcqp17BctXUtAT7iF/vr66GN2Vo+xKtNtgDT AuCR5m1PcNemqyvP3WziSpfjWZAXdQDXmy9H4BDSh20nRQqq5RSBTDGCmvLHmBbPWCHb 2zrBjGAWFAqe5jemBjptCJsU5V2ZJ8jhppywL3xy5TuzDKCZkd6K3HHT2ByJV/1dnzC4 eyih1paPvmpliuVp9cRMJyaoWmzF6Mh4HB1MMCH5suIfEVI3Dm8rf1wJwDpu70lWzI2h +Gh1QxSYjzdWKTfyCg8FDck4RLV/ObHNPt8lX5sZpBdJYfyT5q8Zw2x9ZowWmOl32A2b 3wYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=T9q9YjiDTYHXTQxXz97G0825eEdgpNUgq5pNvugOEtA=; b=Mfk0flxDJnPUlgHM+xfvXI2/4hqmZi6Bnc7AXNbvogOaw5nWygnPiJ5+SyA5KhOoaG 5oNV+Mg/6zUteU2+vtDhnz0Y7OvOPJKqXu4Jmc9v0RgL2C21tvsdQut6RpSEyohBjJGt 1GWWXMQzDo7VGfXda3oSdFVzAKE8PNuIw3hEtbPPbG49PEY37HmgtYdnlrxtgrnla7K3 YrQwEh3L7iOP7h47FYxonCLV1YC7AUjU+KbmYAC/zQ5Yy9POK8c3jTs0HKQJOUf/MGo5 oTSTXIld0EHGkYDEhe1DirUzjVX0K/DBq7qqYXAfAwRRN2nEmpLh2j9dpPYPuf+VVPil BsZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mq8-20020a17090b380800b0021872dc4be1si14375902pjb.138.2022.11.21.22.29.20; Mon, 21 Nov 2022 22:29:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231956AbiKVG22 (ORCPT + 99 others); Tue, 22 Nov 2022 01:28:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231318AbiKVG2W (ORCPT ); Tue, 22 Nov 2022 01:28:22 -0500 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 398ECB7CE; Mon, 21 Nov 2022 22:27:52 -0800 (PST) Received: from canpemm500010.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4NGZ6x1d9wz15Mps; Tue, 22 Nov 2022 14:27:21 +0800 (CST) Received: from localhost.localdomain (10.175.112.70) by canpemm500010.china.huawei.com (7.192.105.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 22 Nov 2022 14:27:49 +0800 From: Wang Yufen To: , , , , CC: , , , , Wang Yufen Subject: [PATCH] infiniband: cma: fix the dev refcnt leak Date: Tue, 22 Nov 2022 14:47:53 +0800 Message-ID: <1669099673-12213-1-git-send-email-wangyufen@huawei.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Originating-IP: [10.175.112.70] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500010.china.huawei.com (7.192.105.118) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750176708132759022?= X-GMAIL-MSGID: =?utf-8?q?1750176708132759022?= Syzbot report the following issue: infiniband syj1: RDMA CMA: cma_listen_on_dev, error -98 unregister_netdevice: waiting for vlan0 to become free. Usage count = 2 The causes are as follows: rdma_listen() rdma_bind_addr() cma_acquire_dev_by_src_ip() cma_attach_to_dev() _cma_attach_to_dev() cma_dev_get() cma_check_port() <--The return value is -98， goto err err: <-- The error handling here is missing the operation of cma_release_dev. To fix, add cma_release_dev to error handing. Fixes: e51060f08a61 ("IB: IP address based RDMA connection manager") Reported-by: syzbot+5e70d01ee8985ae62a3b@syzkaller.appspotmail.com Signed-off-by: Wang Yufen --- drivers/infiniband/core/cma.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c index 26d1772..3a50a8e 100644 --- a/drivers/infiniband/core/cma.c +++ b/drivers/infiniband/core/cma.c @@ -4049,6 +4049,9 @@ int rdma_listen(struct rdma_cm_id *id, int backlog) return 0; err: id_priv->backlog = 0; + if (id_priv->cma_dev) + cma_release_dev(id_priv); + /* * All the failure paths that lead here will not allow the req_handler's * to have run.