From patchwork Mon Nov 21 17:34:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 23968 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1733739wrr; Mon, 21 Nov 2022 09:42:14 -0800 (PST) X-Google-Smtp-Source: AA0mqf60HRZJuLKeA1ftTpSVvjSz+iYvs+BfRBe8ltwtQmBO3lQPzTM9u4PKjC74XvcA8WdHhPLC X-Received: by 2002:a63:4f4c:0:b0:45c:562f:b2b9 with SMTP id p12-20020a634f4c000000b0045c562fb2b9mr1909288pgl.245.1669052534171; Mon, 21 Nov 2022 09:42:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669052534; cv=none; d=google.com; s=arc-20160816; b=ccODjMPoXPCTSAJ0tEQ6XUCRBWp5cLYYduXTPU27rlTfioFgYD/INX0eozqFyVH4nH S3/dXNZAHpRKRcV//w/DbcND1LoiXPrjQWbb95DD5yTNEPVYM3h3ST8KTPp6CGWlgsQh uV7M7PYyOfHrSWPOGwuendZ8if3sxl40+CIV/MuDdMLdNgtGDD7MYVMOfHZo2cGhJXtC 9Q8AQGHU2fscZf3cU+sUvZ8CtyPeoSkhbpt0zdrprvmVhmYlOPBQtGiY3bgL3WyaKwoq CnASpXjvj365pnZbunmeXW3A4t0JCSxax1M6UXkcr/SfAk5KHI98ktSfqOecfV2TWj3g JQtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=9jLBF7suBUQGEgB0u05osfY1dGyhJ1vm765TjTTSS80=; b=eokN5eHo8FkiB1uV4WOHIY5O3+79iNeGlASsQJVMLwaXGhVJEK0qf3m0mjNm0mqEKu 1TwagV7S4Y2+2VDIqUyPaPLrEzpQ9BvbbeS/XA8H6gmMt460rsmH1WAQF3BQinKp8SdR yZdPlYLNwKOrLCLNakEXucZJzvDbuBzs7BsWW3GGw2MiyD2IdyuYU8ud9On6Jahjrw+I 7xmYM7OeurtlBEuGK3oPLofPPWlx5lsjWifkeDvzincsB3zXXgMj7zzK0pZoYxTYQTdA GaTBiCDpmSJnR6ezAFpsbNnBrUhEktjm3BdUOAlymWUJtTv79Xw1rjc/Jt1nOJ+5wqY2 MP9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=NpvoazUQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w11-20020a170902d70b00b001837ff673d3si10467177ply.262.2022.11.21.09.42.00; Mon, 21 Nov 2022 09:42:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=NpvoazUQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230204AbiKURfD (ORCPT + 99 others); Mon, 21 Nov 2022 12:35:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229527AbiKURfB (ORCPT ); Mon, 21 Nov 2022 12:35:01 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFE8CCDFC7; Mon, 21 Nov 2022 09:34:59 -0800 (PST) Received: from Monstersaurus.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3B36E74C; Mon, 21 Nov 2022 18:34:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1669052097; bh=3wyOgjAlepB4I1xB99aLI2ewGundLQKtX3vaYZdcmJU=; h=From:To:Cc:Subject:Date:From; b=NpvoazUQE7AuSvxBN+HHs3jZop66wud55sBuIuEyc54SIYSlPJeM/nq01IWJpamw0 q0wx4lViXiOdndaBE1BK/NRQxh/yOYxVPozZDQP7KZ38eesEbPYin/+ALLbDY1XUMS NR8/l3IOYxuGYciAHPu/Ri3gVKhBOeAvsAr5LCIM= From: Kieran Bingham To: linux-media@vger.kernel.org Cc: Lukas Bulwahn , Kieran Bingham , Jason Chen , Mauro Carvalho Chehab , Srinivas Pandruvada , Ajay Gupta , =?utf-8?q?Marek_Beh=C3=BAn?= , Peter Rosin , Petr Machata , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] media: i2c: ov08x40: Make remove callback return void Date: Mon, 21 Nov 2022 17:34:47 +0000 Message-Id: <20221121173447.387248-1-kieran.bingham+renesas@ideasonboard.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750128429899942561?= X-GMAIL-MSGID: =?utf-8?q?1750128429899942561?= In commit ed5c2f5fd10d ("i2c: Make remove callback return void") drivers were updated to remove the return value of the remove callback, and return void. The OV08x40 was not able to be compile tested at the time due to a KConfig issue, and was missed. Now that the OV08x40 is able to be selected, update the driver accordingly. Fixes: ed5c2f5fd10d ("i2c: Make remove callback return void") Signed-off-by: Kieran Bingham --- drivers/media/i2c/ov08x40.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/i2c/ov08x40.c b/drivers/media/i2c/ov08x40.c index b4ade17a83f5..72ae7fba94eb 100644 --- a/drivers/media/i2c/ov08x40.c +++ b/drivers/media/i2c/ov08x40.c @@ -3281,7 +3281,7 @@ static int ov08x40_probe(struct i2c_client *client) return ret; } -static int ov08x40_remove(struct i2c_client *client) +static void ov08x40_remove(struct i2c_client *client) { struct v4l2_subdev *sd = i2c_get_clientdata(client); struct ov08x40 *ov08x = to_ov08x40(sd); @@ -3292,8 +3292,6 @@ static int ov08x40_remove(struct i2c_client *client) pm_runtime_disable(&client->dev); pm_runtime_set_suspended(&client->dev); - - return 0; } static const struct dev_pm_ops ov08x40_pm_ops = {