From patchwork Mon Nov 21 13:50:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Feng Tang X-Patchwork-Id: 23752 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1600768wrr; Mon, 21 Nov 2022 05:57:00 -0800 (PST) X-Google-Smtp-Source: AA0mqf449ltKEKsyWXl3mVrbllnyTJotdWMyMwNo87Oqf+/EUqcUy+Pg1Ao5MD8EAK7/fye2NKXG X-Received: by 2002:a63:ef55:0:b0:45f:efc9:5935 with SMTP id c21-20020a63ef55000000b0045fefc95935mr17493494pgk.28.1669039020007; Mon, 21 Nov 2022 05:57:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669039020; cv=none; d=google.com; s=arc-20160816; b=fl9ln1pai4z7FkCEDIWo32ylEw4KwYAu294hA02P45WXtYBYduWlx12MJjBCbsYGTJ YOyjC0U97HSt+qbr0VNoKD6VDmU5VPEfYsRDAi23WMmYlYKW0ouzm/Dnk6yIPVYbnA2Z TgbSpvocDZRDeQr4ni8sYCTfhS8/1yisIemuNit5oVeh4mnxP7Dx99dPMWq4Qo6aihDm 5NcYNLiUsdXJczopOhh0CYQYjXC7HsIPx1dAKpDQzA6Hz5nWvlqeO23wDd7+UfJiDGiI uqDAqcq4BhO+1yxLENWiVIiNmz5qVaGsOlMEbcdzplk7bLPEgNBKgPdWOv1KV1Sj3ix7 z31g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=UICwHwUy/rM4e5XTjGUHW4OK+5ASBUwTNuClQeGn99A=; b=b6H+bjNcPRlR7xSpjf1f4lbXCjkq1DiUx5yDQt5c8/OeU/bQ8ep9v1syft2sT5Cjaj aIt9CbyNIb/1z9+OOzmDjf9PzwG/X/nUwhRhj06I9PSHVlP4Rkl8zUYO+0ElepYnUg2I MWze19p4RbOXxCcVT/10/r7KbX7qfC1S0M41P6GS8Vrt1xXGa5/Peqj5+7lJujJmT+FT JZGpV9LNnHfAuiTZa1ki8lX/xitfYtmkoZCS8dFZDFtCfMJXJMZ7OLhX1ptgWHRsy7Xg x8LeNPRBFWBmfTC7tXW00Y5hxqDDmQrRe830Sb+RqdupvBPrceYmfAIBH9jQ83gTdi8/ 7sfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="oE/lX1Co"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k4-20020a63d104000000b0046fb2a57348si10919521pgg.84.2022.11.21.05.56.40; Mon, 21 Nov 2022 05:56:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="oE/lX1Co"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229984AbiKUNx3 (ORCPT + 99 others); Mon, 21 Nov 2022 08:53:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229640AbiKUNx1 (ORCPT ); Mon, 21 Nov 2022 08:53:27 -0500 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 855F61EECB for ; Mon, 21 Nov 2022 05:53:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669038806; x=1700574806; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=VxqTtM17BmtYe97UGlIkeXzguZmoQW3WI6yuaWgDYSE=; b=oE/lX1CojWbEkBQaUY5u/UQtNZcrQZse7JrviaSBsAwjQfvVwcCbuk8b 2CRhFfo6r4G6pNloOiJ0sfi4SipGEMeaX1taQpO0L10UxbKoia7UWeWXd AFbwATVGpODMJQr15WZC39OUDxtjU/X7zxoQq53EpxIYKPaLt5/uYMgp1 AiUQ9r/O0bq5TPckSVZfV3mzEtsWH//LuvpXpDUQnWPyjZQgHR7Zqr0MT r0HzxZf2Cb4Q6/w+cXPF1sO1UFNLkjNgP41TSAzOOAcfQgqkbopfvzdQz T5Nz3mEp8AA6WRlKiDdY7HSuE0Mx2M5ThMFY1sIKh9+U5lWJisC+m2fg4 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10538"; a="312261154" X-IronPort-AV: E=Sophos;i="5.96,181,1665471600"; d="scan'208";a="312261154" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2022 05:53:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10537"; a="886125081" X-IronPort-AV: E=Sophos;i="5.96,181,1665471600"; d="scan'208";a="886125081" Received: from feng-clx.sh.intel.com ([10.238.200.228]) by fmsmga006.fm.intel.com with ESMTP; 21 Nov 2022 05:53:22 -0800 From: Feng Tang To: Andrew Morton , Vlastimil Babka , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Vincenzo Frascino Cc: linux-mm@kvack.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, Feng Tang Subject: [PATCH -next 1/2] mm/slab: add is_kmalloc_cache() helper macro Date: Mon, 21 Nov 2022 21:50:23 +0800 Message-Id: <20221121135024.1655240-1-feng.tang@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750114259239115797?= X-GMAIL-MSGID: =?utf-8?q?1750114259239115797?= commit 6edf2576a6cc ("mm/slub: enable debugging memory wasting of kmalloc") introduces 'SLAB_KMALLOC' bit specifying whether a kmem_cache is a kmalloc cache for slab/slub (slob doesn't have dedicated kmalloc caches). Add a helper macro for other components like kasan to simplify code. Signed-off-by: Feng Tang --- include/linux/slab.h | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/include/linux/slab.h b/include/linux/slab.h index 1c670c16c737..ee6499088ad3 100644 --- a/include/linux/slab.h +++ b/include/linux/slab.h @@ -758,6 +758,12 @@ extern void kvfree_sensitive(const void *addr, size_t len); unsigned int kmem_cache_size(struct kmem_cache *s); +#ifndef CONFIG_SLOB +#define is_kmalloc_cache(s) ((s)->flags & SLAB_KMALLOC) +#else +#define is_kmalloc_cache(s) (false) +#endif + /** * kmalloc_size_roundup - Report allocation bucket size for the given size * From patchwork Mon Nov 21 13:50:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Feng Tang X-Patchwork-Id: 23754 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1600896wrr; Mon, 21 Nov 2022 05:57:18 -0800 (PST) X-Google-Smtp-Source: AA0mqf45br0dTMuVl9nPQiDdJxc58/2QCHVrjZNmEfaW8yESbTsrVkBO4zO/rCZXzlF2/NHGQINZ X-Received: by 2002:aa7:cc93:0:b0:462:6b8e:1ddb with SMTP id p19-20020aa7cc93000000b004626b8e1ddbmr16124471edt.276.1669039038206; Mon, 21 Nov 2022 05:57:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669039038; cv=none; d=google.com; s=arc-20160816; b=ti5sqxOSrBHTr6S+5jLTGl2YTay0/eYguYdH/7AsWkSsmw6aYKwKZzaz/KCfVaxIB+ LubpKkjLZNaiY+BPsbCcGP2/m1hFGf3QW2SofSjccujRuGPM+//Qg8JCKaZ9cVnr9tLI zdjxuIrKGNaxGCJ6Xw71oC7Taxu4V99ERuiLjeChlfskJ9H6eVM5RThvlGxrgRwoyQQ9 Xyak0XDg3qiFf+OJXNSjCAf+T6CTNmRwxPJ2O6r5rulfvHw7wlKm/yJ+OCZ51KbZQq49 7HlaNRoYXq9leXHIpNbtJW0hj38Uw3WFzgUqELcJAgaFzJAscxzzT3vw/Aj9h9Zj/dWE zv9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=qGPUeE4ITf2p+O2BZkcAmNpuuPsa1nAB6HxRM2M3MtI=; b=uhWCMosFhwbsJwwiYv+emwg68t1Tl0BKkPeCvwhthBNzn38zYxPxvExkN1X0Zc2sB5 WU2o2w49RxYooxG3k3WE0s9kk9zRQu1n++YKnUHOkVcqdkE5TkB+HVzDzs2szDcK7kZB vVFEISRzs6bfLEpIRAWnKI5ipbh+odnvOf1jawF2MWr9YmJrII/wEeSL1EqVS+/5FEeb z7LjqGCcwOtXeRv0VG3D4f46/HXp08VvJ4KzPIns5Wf14MmS+UGDiX4hq6PDV50eAuVB bzNx3VmOg0q4/Jwjs+EcUSG6rz7KTIzACqoqUL9UMLhEyFDCYGc5vIiylX+2JIfZHO11 qy/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=BBXMjNn1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xb14-20020a170907070e00b007b28c6790edsi10006791ejb.205.2022.11.21.05.56.49; Mon, 21 Nov 2022 05:57:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=BBXMjNn1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231335AbiKUNxf (ORCPT + 99 others); Mon, 21 Nov 2022 08:53:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229640AbiKUNxb (ORCPT ); Mon, 21 Nov 2022 08:53:31 -0500 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F101B94AE for ; Mon, 21 Nov 2022 05:53:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669038810; x=1700574810; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xAgBqOEUMmWoQfbkuo6RneBuqFILZ8nL3SYVkdsI98s=; b=BBXMjNn1G6DZ7lRQKRZAUM6N+9CBmlwTI5MkcZu1sHgxL7wpYd6wkpKA QoBR3DzvnHMtYaIISy6rYqK5fSxAISFVW3N4ByEs5iObMXmKit3iP5cJI C9tfbMSZOfIVc3xOk1YrTILOZ+CIDDjUz8Q/T7SNEO//+yoyxLvoKsgsn USY09+bweTQjQgvkADb7O+wVlIaJ+FSTCoIpZWLcTPc9GNZWBDLUYdbCn pbkQCYp8uLE+zu/fTyA+hrLqAZfxKjfbpf/cq+LV9rS9C5AjXFxcuzp3E jcbKaKHYFf6udyxj+LdZXnq+iYX039HEh9hpbMcH2Dv0i7chTme5QdVgL g==; X-IronPort-AV: E=McAfee;i="6500,9779,10538"; a="312261165" X-IronPort-AV: E=Sophos;i="5.96,181,1665471600"; d="scan'208";a="312261165" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2022 05:53:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10537"; a="886125108" X-IronPort-AV: E=Sophos;i="5.96,181,1665471600"; d="scan'208";a="886125108" Received: from feng-clx.sh.intel.com ([10.238.200.228]) by fmsmga006.fm.intel.com with ESMTP; 21 Nov 2022 05:53:26 -0800 From: Feng Tang To: Andrew Morton , Vlastimil Babka , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Vincenzo Frascino Cc: linux-mm@kvack.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, Feng Tang Subject: [PATCH -next 2/2] mm/kasan: simplify is_kmalloc check Date: Mon, 21 Nov 2022 21:50:24 +0800 Message-Id: <20221121135024.1655240-2-feng.tang@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221121135024.1655240-1-feng.tang@intel.com> References: <20221121135024.1655240-1-feng.tang@intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750114278647681113?= X-GMAIL-MSGID: =?utf-8?q?1750114278647681113?= Use new is_kmalloc_cache() to simplify the code of checking whether a kmem_cache is a kmalloc cache. Signed-off-by: Feng Tang --- include/linux/kasan.h | 9 --------- mm/kasan/common.c | 9 ++------- mm/slab_common.c | 1 - 3 files changed, 2 insertions(+), 17 deletions(-) diff --git a/include/linux/kasan.h b/include/linux/kasan.h index dff604912687..fc46f5d6f404 100644 --- a/include/linux/kasan.h +++ b/include/linux/kasan.h @@ -102,7 +102,6 @@ struct kasan_cache { int alloc_meta_offset; int free_meta_offset; #endif - bool is_kmalloc; }; void __kasan_unpoison_range(const void *addr, size_t size); @@ -129,13 +128,6 @@ static __always_inline bool kasan_unpoison_pages(struct page *page, return false; } -void __kasan_cache_create_kmalloc(struct kmem_cache *cache); -static __always_inline void kasan_cache_create_kmalloc(struct kmem_cache *cache) -{ - if (kasan_enabled()) - __kasan_cache_create_kmalloc(cache); -} - void __kasan_poison_slab(struct slab *slab); static __always_inline void kasan_poison_slab(struct slab *slab) { @@ -252,7 +244,6 @@ static inline void kasan_poison_pages(struct page *page, unsigned int order, bool init) {} static inline bool kasan_unpoison_pages(struct page *page, unsigned int order, bool init) { return false; } -static inline void kasan_cache_create_kmalloc(struct kmem_cache *cache) {} static inline void kasan_poison_slab(struct slab *slab) {} static inline void kasan_unpoison_object_data(struct kmem_cache *cache, void *object) {} diff --git a/mm/kasan/common.c b/mm/kasan/common.c index 1f30080a7a4c..f7e0e5067e7a 100644 --- a/mm/kasan/common.c +++ b/mm/kasan/common.c @@ -122,11 +122,6 @@ void __kasan_poison_pages(struct page *page, unsigned int order, bool init) KASAN_PAGE_FREE, init); } -void __kasan_cache_create_kmalloc(struct kmem_cache *cache) -{ - cache->kasan_info.is_kmalloc = true; -} - void __kasan_poison_slab(struct slab *slab) { struct page *page = slab_page(slab); @@ -326,7 +321,7 @@ void * __must_check __kasan_slab_alloc(struct kmem_cache *cache, kasan_unpoison(tagged_object, cache->object_size, init); /* Save alloc info (if possible) for non-kmalloc() allocations. */ - if (kasan_stack_collection_enabled() && !cache->kasan_info.is_kmalloc) + if (kasan_stack_collection_enabled() && is_kmalloc_cache(cache)) kasan_save_alloc_info(cache, tagged_object, flags); return tagged_object; @@ -372,7 +367,7 @@ static inline void *____kasan_kmalloc(struct kmem_cache *cache, * Save alloc info (if possible) for kmalloc() allocations. * This also rewrites the alloc info when called from kasan_krealloc(). */ - if (kasan_stack_collection_enabled() && cache->kasan_info.is_kmalloc) + if (kasan_stack_collection_enabled() && is_kmalloc_cache(cache)) kasan_save_alloc_info(cache, (void *)object, flags); /* Keep the tag that was set by kasan_slab_alloc(). */ diff --git a/mm/slab_common.c b/mm/slab_common.c index 8276022f0da4..a5480d67f391 100644 --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -663,7 +663,6 @@ struct kmem_cache *__init create_kmalloc_cache(const char *name, create_boot_cache(s, name, size, flags | SLAB_KMALLOC, useroffset, usersize); - kasan_cache_create_kmalloc(s); list_add(&s->list, &slab_caches); s->refcount = 1; return s;