From patchwork Tue Sep 6 07:29:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 1032 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5044:0:0:0:0:0 with SMTP id h4csp508261wrt; Tue, 6 Sep 2022 00:34:21 -0700 (PDT) X-Google-Smtp-Source: AA6agR6f3Tr2TPf9sF+d0BPLNq4fcWIqMELtyh3o9GNkJZ+z7Sj5D41AgkfknuaRAZFYN8CDARlW X-Received: by 2002:a17:907:3d8b:b0:741:9f51:ac16 with SMTP id he11-20020a1709073d8b00b007419f51ac16mr27247431ejc.39.1662449661433; Tue, 06 Sep 2022 00:34:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662449661; cv=none; d=google.com; s=arc-20160816; b=wL/xSUwN/MUywQvuU5aTC4af4jU39/74E7W+MdCyv6+wMXie3KmhCVvEyPElKPq5fW aOPedur/9jIGX7v9PKF6h7zZL81vvDhuOuSQXE8W7B5krS19o5RbraVxoE6+tca9EcvK FaEHs+2U/fcPyXpKmNkJq4wPctB7qmTkn8NDM114m6qd63VXjBA0Urz0kcOnbSgQx/wd OYtaQQ85k23wIyRAR36ey9DonSVgGisNI5KsoJ+HNQgmJHFyH4JPKQJLOUY2lJ10/3sc uhiH1ZOkPWv5jelXME13t8wigXYBX3yr+lXUC0p61+zAzS/3xXskdDJ/gshPMHY/d5Mm le7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:to :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=bWD0quz3Hrx2YQ7y4QUAwOReCy5myqk3JFogInQl13I=; b=vqrGAC8qHYfLq/7q7vZGjQpiW3TtQpkZAAv34Y4oe9MIpmKFXoeNb69TjwBNA8vUbQ +3BJdmKhj2j9uEp+VALbdee9EC0yuo3sMkRabaVSRgga03C1StHXumwNbzxZ11VeSzNz /ca6TSqZd9ACzHr/LCrI6ZO13BvB6jiaJR4YIcgay7wpNZkwK0zBhjupEwR6xOSobyiW rXq+yHKUfkNfVG1/P5b9sZuZhR2pc5Haba1G6wnx0fobVTun0p3fYW8mGhWvmhvT4iEZ LB7XXDAmLGDsrYsVg5D1LgW6ryGQfdbYVhsGAn8r+t+cMzVzT14gOxHor9mjOOEBo1zq GDcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=bqcfSUtM; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id o21-20020a170906975500b0073d6e0416f9si10193449ejy.671.2022.09.06.00.34.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 00:34:21 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=bqcfSUtM; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BA2B1388451B for ; Tue, 6 Sep 2022 07:29:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BA2B1388451B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1662449398; bh=bWD0quz3Hrx2YQ7y4QUAwOReCy5myqk3JFogInQl13I=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=bqcfSUtMVJAeYNSXGOC1IHKiZG7PEq1fEds6FJoAVsymN4aOHWdSa67JIyJVbcYAl FeczzrKELDp2X+FWVmbyomY/Q48HRplCryei3UcO2XXL1wynRbG8ylukY7yqAqPRA+ AY02EAO3NEdhZrUhcdMQexpLDSgnnrqM1xp8Q9Z8= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3F1A33851400 for ; Tue, 6 Sep 2022 07:29:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3F1A33851400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-502-Y6_gqk-bMnC5xlyUYyVndw-1; Tue, 06 Sep 2022 03:29:11 -0400 X-MC-Unique: Y6_gqk-bMnC5xlyUYyVndw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 73A4980A0AE; Tue, 6 Sep 2022 07:29:11 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.194.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D8D741415137; Tue, 6 Sep 2022 07:29:10 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.17.1/8.17.1) with ESMTPS id 2867T6P83472849 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 6 Sep 2022 09:29:06 +0200 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.17.1/8.17.1/Submit) id 2867T6193472848; Tue, 6 Sep 2022 09:29:06 +0200 To: GCC patches Subject: [PATCH] Handle > INF and < INF correctly in range-op-float.cc Date: Tue, 6 Sep 2022 09:29:01 +0200 Message-Id: <20220906072901.3472801-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Aldy Hernandez via Gcc-patches From: Aldy Hernandez Reply-To: Aldy Hernandez Cc: Jakub Jelinek Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1743204815921888326?= X-GMAIL-MSGID: =?utf-8?q?1743204815921888326?= The gfortran.dg/minlocval*.f90 tests are generating conditionals past the infinities. For example: if (x <= +Inf) foo (x); else bar (x); It seems to me that the only possible value for x on the false side is either NAN or undefined (for !HONOR_NANS). Is this correct, or is there some other FP nuance I'm unaware of? gcc/ChangeLog: * range-op-float.cc (build_lt): Handle < -INF. (build_gt): Handle > +INF. gcc/testsuite/ChangeLog: * gcc.dg/tree-ssa/vrp-float-inf-1.c: New test. --- gcc/range-op-float.cc | 18 ++++++++++++++++++ .../gcc.dg/tree-ssa/vrp-float-inf-1.c | 15 +++++++++++++++ 2 files changed, 33 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/vrp-float-inf-1.c diff --git a/gcc/range-op-float.cc b/gcc/range-op-float.cc index 050f07a9867..4515bbf0b7e 100644 --- a/gcc/range-op-float.cc +++ b/gcc/range-op-float.cc @@ -235,6 +235,15 @@ build_le (frange &r, tree type, const REAL_VALUE_TYPE &val) static void build_lt (frange &r, tree type, const REAL_VALUE_TYPE &val) { + if (real_isinf (&val, 1)) + { + if (HONOR_NANS (type)) + frange_set_nan (r, type); + else + r.set_undefined (); + return; + } + // Hijack LE because we only support closed intervals. build_le (r, type, val); } @@ -252,6 +261,15 @@ build_ge (frange &r, tree type, const REAL_VALUE_TYPE &val) static void build_gt (frange &r, tree type, const REAL_VALUE_TYPE &val) { + if (real_isinf (&val, 0)) + { + if (HONOR_NANS (type)) + frange_set_nan (r, type); + else + r.set_undefined (); + return; + } + // Hijack GE because we only support closed intervals. build_ge (r, type, val); } diff --git a/gcc/testsuite/gcc.dg/tree-ssa/vrp-float-inf-1.c b/gcc/testsuite/gcc.dg/tree-ssa/vrp-float-inf-1.c new file mode 100644 index 00000000000..1d21cce41e6 --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/vrp-float-inf-1.c @@ -0,0 +1,15 @@ +// { dg-do compile } +// { dg-options "-O2 -fdump-tree-evrp-details" } + +void foo (); +void bar (double); + +void funky(double f, double g) +{ + if (f <= __builtin_inf ()) + foo (); + else + bar (f); +} + +// { dg-final { scan-tree-dump-not " Inf, Inf" "evrp" } }