From patchwork Fri Nov 18 13:10:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 22320 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp186827wrr; Fri, 18 Nov 2022 05:12:32 -0800 (PST) X-Google-Smtp-Source: AA0mqf6JYvphsQLetHT12xCGu6cEkZ2Jph1dZv5XhKPb5zkqcF0/2VwnUikVDppg2gMXq+oVqc/9 X-Received: by 2002:a17:90a:9bcb:b0:206:f02a:cb4b with SMTP id b11-20020a17090a9bcb00b00206f02acb4bmr7764726pjw.159.1668777151706; Fri, 18 Nov 2022 05:12:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668777151; cv=none; d=google.com; s=arc-20160816; b=ewZBY9PDE8U7JamDOQbB+2W4flI/kHS2+hn5a0oOqUntAtw8YSuoSC5YmaUwK7S1lS W0YCeHaUtHRYi8uuQ0wQ4USsuXM/7X6uv9RzUdmtrivlX/t/iM0Q+lgev+aCR3wioULh mx95viq63gfmFRvbld4+jqk7kTiGkBLNfzXDpax9HZr3Si01gb3eu9HFuzR1ygKUh8VL GYaBEP4ranOzuacUgYzjXi+bqA+ZYr7vcIMMA9b+NoNIPd40U5f/CsdtWVX/lgfBcfsF 1XCAf/+sXaQyeeXGmlUeQfaC8S1y2Qso1qQO7FOcVMH975vyWXc3bvVqvPZnM3tXwJVR MJRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=nIM9IJHvjSzw+04HWZDmFjpgziYaBBenK0g63oaaMjk=; b=HMJAtsZwEd2yTI/HFBW0cvmWAx1cO0Jp7diauPErkBlkjoXnqdW35mwFzWofJZkOYP dMRwmzquEqwZdVvGgxL+wSRhp+6oaBHQp+itAgXCDPXKxOohzFRfoXeixeI8WcsPfd0k cBsbnK+91nLnPCTJwsabAAgbB94F++kNpF66VCQplcfvRVSfMI+R6StIaQdgTUjjc2tg yi0Av+QenqQwj4H/k9R8gtDn5X/WZHih11Kjv3Qn+l1fgtkG92cMcw5wkIPT0W/McC7/ O8Rs0LT/dEjgD/Fk9zQtZhetE059kY/9vb9Ky6Uwe9hlIEinW+OZH8OdovFhvammdx1a UM3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Yz5TWVMd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l10-20020a63ea4a000000b0046f63d17422si3727715pgk.359.2022.11.18.05.12.18; Fri, 18 Nov 2022 05:12:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Yz5TWVMd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240766AbiKRNL2 (ORCPT + 99 others); Fri, 18 Nov 2022 08:11:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235233AbiKRNL0 (ORCPT ); Fri, 18 Nov 2022 08:11:26 -0500 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48CBF13CE1 for ; Fri, 18 Nov 2022 05:11:25 -0800 (PST) Received: by mail-lj1-x22a.google.com with SMTP id d20so6669400ljc.12 for ; Fri, 18 Nov 2022 05:11:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nIM9IJHvjSzw+04HWZDmFjpgziYaBBenK0g63oaaMjk=; b=Yz5TWVMdPelgFeIJEe0H3DNPz7fP46OEIDsAPBnhpv3CDel+1moOrQxzgD9JDtVTSB /Wh39v2++pMS+pwgjQXHh2d2HNlgp9eHPIoXQnoq/KIJhqDesDRX2gaYnYH5IQcAELBH lYYzxUIgiXYP4kHQfwd97qfEHSyrKljvBx+93BUxLhCfrZ03Oua4FFUb+Y9jqtT6+j6w 27mZYsS3Z+3HQOvmeQa8gEE3Eq70MrtwxptaIyrTfGhMQnkjr2xDV73qY7qG1R753xy9 iu/PRPIGrHGh9ArW3aBkXRU2v+fv5R8+1nS2swJnCk3GgeYk0gUyYUUcCEXh3jYWwVQ3 m5mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nIM9IJHvjSzw+04HWZDmFjpgziYaBBenK0g63oaaMjk=; b=vAh914DPXOe/QJakRxctcFbtZJkc+2uRHWLRo3+XMUBWu6oTg0G+JhLZeztXZTOVWw t13Vk9LXKUMmP2L5BYbzIrm5RvxdDFfF3mrxXAFLkzbhJta/MSYo0mbBz3RJ2cJjRypU Obn2UYTIgjmURXXh7qOoypZGgSldeoFIN1eZibJPjytkEf+kwK8RUtsxahhyvbNOUFs4 iiiapaZZSSIge5mY3CMmQDyAzV1P1EqJfUEhTbEJ+SberDYBWSVKKD+VO6J2wHQ1aDaB tWv2v0G59Ia+wP78ykD6PRzDxKuyuE13SeZBmqAUgaA2S5dBVBU2kLWHgq0sZYrkREaZ MWAQ== X-Gm-Message-State: ANoB5pk2zecP4ET+VarnWGBVfEVXOQx+vctRTtl0Yq2mwH5T9W08kuz/ jta4jiUBbIKyf+d+MUiJmR+ogw== X-Received: by 2002:a05:651c:1074:b0:279:d60:ee7c with SMTP id y20-20020a05651c107400b002790d60ee7cmr2288379ljm.305.1668777083597; Fri, 18 Nov 2022 05:11:23 -0800 (PST) Received: from localhost.localdomain ([194.29.137.22]) by smtp.gmail.com with ESMTPSA id f13-20020a056512360d00b0049a4862966fsm653425lfs.146.2022.11.18.05.11.22 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 18 Nov 2022 05:11:22 -0800 (PST) From: Konrad Dybcio To: Mark Brown , Liam Girdwood , linux-kernel@vger.kernel.org Cc: patches@linaro.org, Konrad Dybcio , Support Opensource Subject: [PATCH] regulator: slg51000: Wait after asserting CS pin Date: Fri, 18 Nov 2022 14:10:35 +0100 Message-Id: <20221118131035.54874-1-konrad.dybcio@linaro.org> X-Mailer: git-send-email 2.37.1 (Apple Git-137.1) MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749839670855579820?= X-GMAIL-MSGID: =?utf-8?q?1749839670855579820?= Sony's downstream driver [1], among some other changes, adds a seemingly random 10ms usleep_range, which turned out to be necessary for the hardware to function properly on at least Sony Xperia 1 IV. Without this, I2C transactions with the SLG51000 straight up fail. Relax (10-10ms -> 10-11ms) and add the aforementioned sleep to make sure the hardware has some time to wake up. (nagara-2.0.0-mlc/vendor/semc/hardware/camera-kernel-module/) [1] https://developer.sony.com/file/download/open-source-archive-for-64-0-m-4-29/ Signed-off-by: Konrad Dybcio --- drivers/regulator/slg51000-regulator.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/regulator/slg51000-regulator.c b/drivers/regulator/slg51000-regulator.c index 75a941fb3c2b..1b2eee95ad3f 100644 --- a/drivers/regulator/slg51000-regulator.c +++ b/drivers/regulator/slg51000-regulator.c @@ -457,6 +457,8 @@ static int slg51000_i2c_probe(struct i2c_client *client) chip->cs_gpiod = cs_gpiod; } + usleep_range(10000, 11000); + i2c_set_clientdata(client, chip); chip->chip_irq = client->irq; chip->dev = dev;