From patchwork Fri Nov 18 10:54:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benjamin Tissoires X-Patchwork-Id: 22262 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp125910wrr; Fri, 18 Nov 2022 03:06:34 -0800 (PST) X-Google-Smtp-Source: AA0mqf4aCFI9lrLEsNNfRNucPcbGrCexlXkAbg7lCFbpOx9/HD93oN79WvaP7jk5DMypoAnyWa11 X-Received: by 2002:a17:902:8544:b0:188:bc8e:9569 with SMTP id d4-20020a170902854400b00188bc8e9569mr7299763plo.43.1668769593740; Fri, 18 Nov 2022 03:06:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668769593; cv=none; d=google.com; s=arc-20160816; b=aP9Cl49LgcqaVfJZXtRKCshjiEQUajF5rPVNetTYg1TX4p7Nxw9DX2I0kcuUHMpEv6 KWhw25qOxmOoE5mRmUsOFsAAOx1aU7SWZPXWSZ4YC39ujZ2d+7qI4o8NntJwrXh+uLvj wo5pQSAPygQ4hlinPYjQfyx59wSvkWUVhH5p8t0E9ENE4neBbsOO1FNGRiFR8PvOOhfE EOG8+Uz16AUI8fJYGvIUtU5LqA+sRwMjfeRy7bQ75qUZbDhe5VG2VCQjZxakWcfEgcCU av+QiDyBDLxn/2ujhqXxTEMcIobs9QRTHf0LpcaTOUerd9JxAMpFKHyMQeoAZ+T0jEGi 3WXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Wu17TcJ/U0Y0VZBclAW0Sq9CIDRhj4hveCM90UJ+Snk=; b=RiDwBpCqU8JCt2j1Kfw3DYjsxQxjtaKz7HwQ1uM/21lPZQE5Eu0qbcO0WOWMuE8beE lhLufnD1Ywa1jXSS4qFv43n5JkoJfcbSWd6gKxAqo3O+9//rnspV6uuTP7aLP8W3VWgH pvnk5Li76yy/j40BQ5zDxUIIy1Xn2lK4EZyWlYJShRBp316G+Mto6HypDvcgBF2V/frg D6jkiGc19lfIJekwU2PB1lTvs7yBIgFsrsFLKkzc5cjirgtgxTbv5pFatE/Mr9QQtBS+ SWjeHUCpIMH3m6WN4KxR3bj6CPllzTjruP+4/Gv0hvSe25HN5KKVOVINkr8hvZhMP70N +zEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iDww2ko+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b12-20020a631b0c000000b0046ff400d209si3558934pgb.724.2022.11.18.03.06.09; Fri, 18 Nov 2022 03:06:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iDww2ko+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241812AbiKRK4D (ORCPT + 99 others); Fri, 18 Nov 2022 05:56:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233999AbiKRK4A (ORCPT ); Fri, 18 Nov 2022 05:56:00 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5C9D97AB4 for ; Fri, 18 Nov 2022 02:55:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668768900; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Wu17TcJ/U0Y0VZBclAW0Sq9CIDRhj4hveCM90UJ+Snk=; b=iDww2ko+8S2P3Xi+wUaASitMbrNAd4xDIR4Dd/x0ZeBSUpe/3DD3OOFutbKkoxD2j2k9LX WqAMG7eaKZKJg8aaMFg/22AV/kz6HH3rKTuiqjr6cg+3xR9goyhZmKXFe82JlX7GhDAtxd b1BfYe/aHC0pRP6sU1ghVWj88l3xODY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-610-mhLQDY96P9q4bNonwfwG2Q-1; Fri, 18 Nov 2022 05:54:54 -0500 X-MC-Unique: mhLQDY96P9q4bNonwfwG2Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 75B4E1C05AAE; Fri, 18 Nov 2022 10:54:54 +0000 (UTC) Received: from plouf.redhat.com (unknown [10.39.194.179]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8DB152027063; Fri, 18 Nov 2022 10:54:53 +0000 (UTC) From: Benjamin Tissoires To: Jiri Kosina Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Benjamin Tissoires , kernel test robot Subject: [PATCH for-6.2/hid-bpf] HID: force HID depending on INPUT Date: Fri, 18 Nov 2022 11:54:48 +0100 Message-Id: <20221118105448.1888750-1-benjamin.tissoires@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749831745292193721?= X-GMAIL-MSGID: =?utf-8?q?1749831745292193721?= In most configurations, INPUT is actually a boolean: either y or disabled, but when it's disabled, you can't do much on your average laptop. But it turns out that there is a possibility to have INPUT as a module: you have to disable VT and TTY (of course), but also enable EXPERT. I'll leave how to disable VT and TTY as an exercise for the bravest. Anyway, if INPUT is m, we can still configure HID as y, which is not correct because hid-input.c depends on the input API, meaning that vmlinuz can not link. So: add depends on INPUT too at the HID level, to ensure that if INPUT=m, HID can only be m or disabled. Fixes: 25621bcc8976 ("HID: Kconfig: split HID support and hid-core compilation") Reported-by: kernel test robot Link: https://lore.kernel.org/r/202211181742.QYJY6Gug-lkp@intel.com Signed-off-by: Benjamin Tissoires --- drivers/hid/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index ff40c18f4a2b..b345bbfb57bf 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -15,6 +15,7 @@ if HID_SUPPORT config HID tristate "HID bus core support" default y + depends on INPUT help A human interface device (HID) is a type of computer device that interacts directly with and takes input from humans. The term "HID"