From patchwork Thu Nov 17 23:23:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kirill A. Shutemov" X-Patchwork-Id: 21983 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp676674wrr; Thu, 17 Nov 2022 15:30:42 -0800 (PST) X-Google-Smtp-Source: AA0mqf5rzbcNGQw6LyR/RYG2tuPTu3xJeqro97M4IOwde2XlZoZ0tWRWryJQUS8nxUNtEFNDog+c X-Received: by 2002:a17:90b:3d04:b0:200:43c8:175a with SMTP id pt4-20020a17090b3d0400b0020043c8175amr10926200pjb.88.1668727842272; Thu, 17 Nov 2022 15:30:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668727842; cv=none; d=google.com; s=arc-20160816; b=oYrDC5JK8m3gRofyQ80cJQKF8rXt3GEK1vxdlHDS7V3DP1ulp2DWiGdwwxO++cJ1C3 QAXfItJ3EQuObF+V7Bd6WmnGVLs2aAvhQQfRrw6btX/PRDlL7NXQiDQVq6WtNaHbTowa BueFpYNI3hpWcec838vtmkn5/MzDbcQONyuMRdGr8IV8H+kGcqwYBNrETIXZJ+ymphHz 9nHuAv+WpyH1F6X62ikQl5MZyFE6TYdb4diO+PeRKZIWmIk4AWqtXUnFb9D2pOhRQV4O t2YCljl1qWsMMuwDNdtQYLPZxN4bTJYfUqcwkBoIa14MqcN0BcUeItnvXtWBV9caWjMW a6kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=gcTIS+31JUOVRom7YlP+fLVbXgVJ60dkTvIabV7wbS8=; b=RyGlHGREnswfwvraJNiH+jLHbtQju/wQ384Q1BdzUG4n09dnWbzmqTLNnbFM9a+gKA /8C1Wq5KfbBRnQK9Ua2Vt9hKx3u8kZl6n9Rp8qVpwXm/MYMcRpi1+SdfktjiIL8Z0naa nZINrsi2FQBbV0C4U8tU+D8TfpSUzZ0irVeS6i2qJeL2qbGl9vrPblc5jvc1a+6ttNkH trD4WAzXsHKJKkOd9HFoq38Nh/8y3qvh6YHZ4NT9FeZMR11vMQ1BgsJFfVXAL56iK/OT yMozO8ag6i1ZVGSfN6lKNmFQTBpjIPKIE9hPnVwyDd+5T2DZvcNUiXH07q2WMhssWZ9w ICgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="Ow/Fa2lQ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m66-20020a632645000000b00470274bbc14si2036645pgm.676.2022.11.17.15.30.28; Thu, 17 Nov 2022 15:30:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="Ow/Fa2lQ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235086AbiKQXX3 (ORCPT + 99 others); Thu, 17 Nov 2022 18:23:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233865AbiKQXXP (ORCPT ); Thu, 17 Nov 2022 18:23:15 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D36274A91; Thu, 17 Nov 2022 15:23:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668727394; x=1700263394; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=1vf+nxtKsojFCFBBwNt1MycZfyiXZfZyH/YixPFSLlM=; b=Ow/Fa2lQiysdU6TqdjWVzqTc/bhhB1C0ddbuOzZdto9UkNvNL/MEyhz/ HNF9mP2SoiWObyxy6HqUgwCKR5oj+6D51T3z30OqQTk/jt++0GBEZoJnL aWV1I+/VdXGbs3vaggNibWN4vm/0R5OAmonPzKm2Fr/EXgahO5rOGZ5m0 UUkbD5rOmzZWuPkHlaa7nSEryg/Gb+uF/mC4yHtpADYTcDrFInEQwVHAM KgrcJWum+5MOsJPYCOL1OwbGbbR0DO6u8N9scK7fDwu/RcpWhHEfG7EY/ Ko2WcTm67eV8UD4AhsYnsLrzHB2SauFnmpCm6eZbWHJzTmQ9fCG3OE/Jy A==; X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="292704100" X-IronPort-AV: E=Sophos;i="5.96,172,1665471600"; d="scan'208";a="292704100" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2022 15:23:13 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="969064618" X-IronPort-AV: E=Sophos;i="5.96,172,1665471600"; d="scan'208";a="969064618" Received: from cvadim-mobl1.ger.corp.intel.com (HELO box.shutemov.name) ([10.252.60.21]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2022 15:23:11 -0800 Received: by box.shutemov.name (Postfix, from userid 1000) id 5FA7D109763; Fri, 18 Nov 2022 02:23:09 +0300 (+03) From: "Kirill A. Shutemov" To: jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org Cc: dave.hansen@linux.intel.com, David.Laight@ACULAB.COM, linux-kernel@vger.kernel.org, x86@kernel.org, "Kirill A. Shutemov" Subject: [PATCHv2] scsi: Fix get_user() in call sg_scsi_ioctl() Date: Fri, 18 Nov 2022 02:23:04 +0300 Message-Id: <20221117232304.1544-1-kirill.shutemov@linux.intel.com> X-Mailer: git-send-email 2.38.0 MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749787965710822096?= X-GMAIL-MSGID: =?utf-8?q?1749787965710822096?= get_user() expects the pointer to be pointer-to-simple-variable type, but sic->data is array of 'unsigned char'. It violates get_user() contracts. Explicitly take pointer to the first element of the array. It matches current behaviour. This is preparation for fixing sparse warnings caused by Linear Address Masking patchset. Signed-off-by: Kirill A. Shutemov Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" --- drivers/scsi/scsi_ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_ioctl.c b/drivers/scsi/scsi_ioctl.c index 2d20da55fb64..fdd47565a311 100644 --- a/drivers/scsi/scsi_ioctl.c +++ b/drivers/scsi/scsi_ioctl.c @@ -519,7 +519,7 @@ static int sg_scsi_ioctl(struct request_queue *q, fmode_t mode, return -EFAULT; if (in_len > PAGE_SIZE || out_len > PAGE_SIZE) return -EINVAL; - if (get_user(opcode, sic->data)) + if (get_user(opcode, &sic->data[0])) return -EFAULT; bytes = max(in_len, out_len);