From patchwork Thu Nov 17 15:07:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 21703 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp451932wrr; Thu, 17 Nov 2022 07:09:47 -0800 (PST) X-Google-Smtp-Source: AA0mqf5MISwFTAv/yJbVLWnAOGK9YLRFCB5eMApj01kFB7ZSvlMvMBNfWp8uvpljkeMUv97rUepB X-Received: by 2002:a05:6402:5290:b0:461:af68:9bcd with SMTP id en16-20020a056402529000b00461af689bcdmr2636535edb.67.1668697787017; Thu, 17 Nov 2022 07:09:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668697787; cv=none; d=google.com; s=arc-20160816; b=eHNVHymX5hTl0WCZ24OEu8tvfRQselJDGiAwGDhvGq8aaTEGAqJoydzDYaMwUSVUJ7 zSyB3C6HkICqrNHnkym9R+U5csWKSyM37PlAUtZnZKnQ3igvbrpUzUSO5l9Bvw009BQG bEu0dvEpOqhkdg0zuAFlFAY2/XzAQ6gymSHSuUKVqsk2dKUkx4XgpCn0xmwWaEe1It4f GSDlrQw2SvRR2l53l8JSXDlG9vkAwQo8Fji8Ci58i8e9nO76aYesH7C0IZQ08kx7IzBy C/6rfdqbZ6bDvi+7pmdWGveGxUc3kxtsUSfLMdak7vFT6kniYIN4urh1pqfLwKyBAe/2 KvUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=aKFoUwAiMO5fsxBWJlAcCHc5lmCkjHrwDLhNDwM8/yk=; b=GL+1wSpvnB6pOdR9yHaJcs2BEER8iU+xEg+ZOCYh6GARfLs5gwpAEa/0xII2GxgZjf agW6AOfvs5YYK7FkX1vnWsIiUbI28tetzFCMSB4t0FNPeQY8xhEyCVhlobAOfW7IS9eA ONZNhDqnUK+Iup5rpYv/+95pCdJfkv4PIIv2GtX4vzqfPOCbZtftEM9rbcESULPpUY0B 3xDop6ngfkDWVbJB7mdEh+5fMCv7tFXWyxMcurkGfmuru3k5aqefz1DEmEyf7o99f7YD KCwfYrOSa1r95CPvHw6An6poBgoK93cPrzbDSpBW2kLThIIj4Yq8yhi3u5Ipkj0r/qbb Sjbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=YtMeYNuy; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x10-20020a056402414a00b004687eebac58si1045555eda.458.2022.11.17.07.09.13; Thu, 17 Nov 2022 07:09:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=YtMeYNuy; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240072AbiKQPH7 (ORCPT + 99 others); Thu, 17 Nov 2022 10:07:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231240AbiKQPHz (ORCPT ); Thu, 17 Nov 2022 10:07:55 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76D4F59876; Thu, 17 Nov 2022 07:07:54 -0800 (PST) Date: Thu, 17 Nov 2022 15:07:51 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1668697673; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aKFoUwAiMO5fsxBWJlAcCHc5lmCkjHrwDLhNDwM8/yk=; b=YtMeYNuyNGuDR4+/fvtzxchyYP3UMdy7cKZyLAIXRAZxor4GryFrC/zwVjObEXo1eSx6n9 coEf3UWH3iDAz/66+xlD/2Fja1axufLTHodxhiHkQdO47R1uVPBIgZgJjT92KWOIqTDXRu my28q8/AQYMyR0f1f8qMo599JaCYqkSkFE5YeVZuq1JT3FZQPhZLobfha8kxb4xxlSBikI SLRDEXSmmWNC+vpex4qPpQ/oLXHE5rwDHA0R7x/9txLA9cFfHt/AfQYE32kbA2pm0lorGt kSzdCNQQtDfq9iAweROIxRRPR9ldfj2wGrRm1Zt3KFQXMyK9pHVDmco5Fv+rrg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1668697673; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aKFoUwAiMO5fsxBWJlAcCHc5lmCkjHrwDLhNDwM8/yk=; b=yYDmm0aflvLr2CkYVLAw14Zyg+SpwxJQpcTzONStfYriorgDJpIUYsNBRaOcziNMxqgLT+ sb+8iPmNBOB8K6Bg== From: "tip-bot2 for Thomas Gleixner" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: irq/core] genirq/msi: Remove msi_domain_ops:: Msi_check() Cc: Thomas Gleixner , Jason Gunthorpe , x86@kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org In-Reply-To: <20221111122015.807616900@linutronix.de> References: <20221111122015.807616900@linutronix.de> MIME-Version: 1.0 Message-ID: <166869767181.4906.10080889603936468444.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749756450881294488?= X-GMAIL-MSGID: =?utf-8?q?1749756450881294488?= The following commit has been merged into the irq/core branch of tip: Commit-ID: 2569f62ca473584a8ba389f455fc00805389f7da Gitweb: https://git.kernel.org/tip/2569f62ca473584a8ba389f455fc00805389f7da Author: Thomas Gleixner AuthorDate: Fri, 11 Nov 2022 14:55:15 +01:00 Committer: Thomas Gleixner CommitterDate: Thu, 17 Nov 2022 15:15:22 +01:00 genirq/msi: Remove msi_domain_ops:: Msi_check() No more users. Signed-off-by: Thomas Gleixner Reviewed-by: Jason Gunthorpe Link: https://lore.kernel.org/r/20221111122015.807616900@linutronix.de --- include/linux/msi.h | 4 ---- kernel/irq/msi.c | 17 +---------------- 2 files changed, 1 insertion(+), 20 deletions(-) diff --git a/include/linux/msi.h b/include/linux/msi.h index 8b28714..1ce9d5e 100644 --- a/include/linux/msi.h +++ b/include/linux/msi.h @@ -292,7 +292,6 @@ struct msi_domain_info; * @get_hwirq: Retrieve the resulting hw irq number * @msi_init: Domain specific init function for MSI interrupts * @msi_free: Domain specific function to free a MSI interrupts - * @msi_check: Callback for verification of the domain/info/dev data * @msi_prepare: Prepare the allocation of the interrupts in the domain * @set_desc: Set the msi descriptor for an interrupt * @domain_alloc_irqs: Optional function to override the default allocation @@ -330,9 +329,6 @@ struct msi_domain_ops { void (*msi_free)(struct irq_domain *domain, struct msi_domain_info *info, unsigned int virq); - int (*msi_check)(struct irq_domain *domain, - struct msi_domain_info *info, - struct device *dev); int (*msi_prepare)(struct irq_domain *domain, struct device *dev, int nvec, msi_alloc_info_t *arg); diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c index 4fde917..4b99f37 100644 --- a/kernel/irq/msi.c +++ b/kernel/irq/msi.c @@ -617,17 +617,9 @@ static int msi_domain_ops_init(struct irq_domain *domain, return 0; } -static int msi_domain_ops_check(struct irq_domain *domain, - struct msi_domain_info *info, - struct device *dev) -{ - return 0; -} - static struct msi_domain_ops msi_domain_ops_default = { .get_hwirq = msi_domain_ops_get_hwirq, .msi_init = msi_domain_ops_init, - .msi_check = msi_domain_ops_check, .msi_prepare = msi_domain_ops_prepare, .set_desc = msi_domain_ops_set_desc, .domain_alloc_irqs = __msi_domain_alloc_irqs, @@ -655,8 +647,6 @@ static void msi_domain_update_dom_ops(struct msi_domain_info *info) ops->get_hwirq = msi_domain_ops_default.get_hwirq; if (ops->msi_init == NULL) ops->msi_init = msi_domain_ops_default.msi_init; - if (ops->msi_check == NULL) - ops->msi_check = msi_domain_ops_default.msi_check; if (ops->msi_prepare == NULL) ops->msi_prepare = msi_domain_ops_default.msi_prepare; if (ops->set_desc == NULL) @@ -707,13 +697,8 @@ int msi_domain_prepare_irqs(struct irq_domain *domain, struct device *dev, { struct msi_domain_info *info = domain->host_data; struct msi_domain_ops *ops = info->ops; - int ret; - - ret = ops->msi_check(domain, info, dev); - if (ret == 0) - ret = ops->msi_prepare(domain, dev, nvec, arg); - return ret; + return ops->msi_prepare(domain, dev, nvec, arg); } int msi_domain_populate_irqs(struct irq_domain *domain, struct device *dev,