From patchwork Thu Nov 17 12:59:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 21655 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp387292wrr; Thu, 17 Nov 2022 05:05:40 -0800 (PST) X-Google-Smtp-Source: AA0mqf4RJZqERYRqvRO96+T11FPOfR/EhGsezJ+JVC8VhZYdqdGfOBfiP7lHr4s0cY8Mshd9JYbd X-Received: by 2002:a17:906:6153:b0:7ad:b51d:39d0 with SMTP id p19-20020a170906615300b007adb51d39d0mr1949588ejl.571.1668690340663; Thu, 17 Nov 2022 05:05:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668690340; cv=none; d=google.com; s=arc-20160816; b=ThwIlL3fAG+DGoPCALsYBqTQKpIVNyPcDSXLzbzVPN6MK+UgyiD5p0GYfvs5EwAVei Cz8Ly7Ave9KXxANwbmgdwdeYWw9p3Eb0a7oUMTrE2Q8YUNvFg6+9mJTzN4a487N5Ly1+ VbfI4QCxNvWuDqFram1KVoqyetoOgJq3cfcKZeYkSXcsmDQnrcOAPOzjm4KtoVpKC6rh 53qvHwyDf5sVwTmKTEWkFIKe6F67kjImALzM1AExl44wxgnYflQUpa2s4ykedaFQazXW 38TYrcy5vQyduitNA3y7XNHdRBDQZ19KVtAaOxucs1cTfHEIHjwBUlzfUW/FOVNsoWh5 1vEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Eb+B8frGuobVTp2uKAV2WvAIWS83WPR5wFN84Wnz+54=; b=lxWhXG5SwD59D+Xt+b97OySe2a+zVn8OmxH0QhcETTi6dyWKD640dpS+EyzSKf3qW3 rB9n7wus30EP3uBCeoOzr7Bf5YGmxZIC8V3zoMU6n/VOeiZFyXu9w7DgSB0LD/E6mv9m dZlNv12Bv3TiH0hB9kSB3sv2NOxU/wRzFLe3jSpRGhHW4m5ujCKICTZSA1zvb/Xpvf8M sEE0zEcr/Et0OZ6YXnIA+yFUh9LPqSZO+v8Mk5VdseOuiQEeNzDdyf/CXe8F3LAaB/vj iBrG+iebNeU9O08J/G8Mrl34mHdTiOQ9zOhzzOzFGOcRpe8WI24bDV10deV/pdC/pjgz 8rlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=gVaArLR5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h12-20020a0564020e0c00b0046805e6392csi779274edh.474.2022.11.17.05.05.17; Thu, 17 Nov 2022 05:05:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=gVaArLR5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239456AbiKQNAP (ORCPT + 99 others); Thu, 17 Nov 2022 08:00:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239310AbiKQNAL (ORCPT ); Thu, 17 Nov 2022 08:00:11 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CF3D5916D for ; Thu, 17 Nov 2022 05:00:10 -0800 (PST) Received: from ideasonboard.com (unknown [103.251.226.79]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 40ED01056; Thu, 17 Nov 2022 14:00:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668690008; bh=L3iuePaXU3I9Th2qNYgsdcfyya4frF4sh5w4xXhH/fY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gVaArLR5O9TBGGuWPC3CfM1iuFvXyUKFVxxhv+yzpg3QVEQzWVwMpGl70m0102nK1 LdEaQNAkhfeFlHjsoe9Orw56peP3CKcNLFBuoqnBLNBpTM6HiAr+ie/sFR4ewIN7oK qvJsHRQ/ptgyN6FK0dJMrDUDw6nBJqsPslpJNsWI= From: Umang Jain To: Florian Fainelli , Broadcom internal kernel review list , Greg Kroah-Hartman , Stefan Wahren , Hans Verkuil , Dave Stevenson , Mauro Carvalho Chehab , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: kieran.bingham@ideasonboard.com, Umang Jain Subject: [PATCH 1/2] staging: vc04_services: mmal-vchiq: Do not assign bool to u32 Date: Thu, 17 Nov 2022 18:29:52 +0530 Message-Id: <20221117125953.88441-2-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221117125953.88441-1-umang.jain@ideasonboard.com> References: <20221117125953.88441-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749748642859497624?= X-GMAIL-MSGID: =?utf-8?q?1749748642859497624?= From: Dave Stevenson struct vchiq_mmal_component.enabled is a u32 type. Do not assign it a bool. Fixes: 640e77466e69 ("staging: mmal-vchiq: Avoid use of bool in structures") Signed-off-by: Dave Stevenson Signed-off-by: Umang Jain --- drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c index cb921c94996a..17f8ceda87ca 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c @@ -1773,7 +1773,7 @@ int vchiq_mmal_component_enable(struct vchiq_mmal_instance *instance, ret = enable_component(instance, component); if (ret == 0) - component->enabled = true; + component->enabled = 1; mutex_unlock(&instance->vchiq_mutex); From patchwork Thu Nov 17 12:59:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 21654 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp387029wrr; Thu, 17 Nov 2022 05:05:15 -0800 (PST) X-Google-Smtp-Source: AA0mqf4KLlAKfxzEcd+UqTIWHStvtk0bNV+gaE5lgikSzsLDu9ekdkNmdTEb1gxB3W9euT0n76x3 X-Received: by 2002:a17:906:3a85:b0:7ab:afd4:d7ed with SMTP id y5-20020a1709063a8500b007abafd4d7edmr2032086ejd.228.1668690314873; Thu, 17 Nov 2022 05:05:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668690314; cv=none; d=google.com; s=arc-20160816; b=QYRhcfuiyc/5o6Jo1IsO67syedQ2SBjmrDHSo13Url/6fa46kh64RfYQCXLaFo2KR/ uFd1prJZinUavXaZO+RXOPwmDfHHRqowpS3Za7nA78dp9n87z0SHFJnmGDt9akaIN8fI dQWlCC8Hy9jrQorqNk3ng5FZhcabwJ+djZUWn8b+DPXtDVO9D0GouiZ83TzlgHhlqKLG Dc80dXAVBa/gf8OsbmT65b12yN5A2kw9oRpdwnrcsQFsmkJHGR0LnaVKqoXL0bMLware iZzUlTkVMNGtUoSCwSjwHlc1Fr/2om2Y/1M1gKd7SSZdEHjZwz4Y4sgc6DT1io8xocy+ n/sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cBTJd/asrMqglNZhkyOkAFFH8Uxx5JWi142mqrSHyDk=; b=rEeDhg9lwvC3c/r1vEIFd3NAy0B2b2PHqe5mdIa0kQLdUs4iHDMXxjqn6vh7uztDdr Gi4yGojcSgIxS3ARQvktbq+SlEV0KIAAmmPewOyCbaaYaLr3LrfL1oZmZ5Wxbc6Jy3Tk ka/vgnWRvxluapPFDx9AxXLlzfGUaX8Gy6DfuPnq1oRpqsYt9+igq/IGLDZqx3BRBrp0 TL9kym/drnZKtEnDfcOVp/ph6GTxFEOZeDdFC0IaJEwYn4RP9RsMBTRsoha/lXCejq7A 4TAIeMNGoR7ul0SCm7ehpEnwqcTzbDOiamz9BfJ9HFesx3CJs2Vsyc+xnOa3XvvSG2jL Ku3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=gOVzyTbY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c6-20020a0564021f8600b00461ebc19dcesi792321edc.56.2022.11.17.05.04.49; Thu, 17 Nov 2022 05:05:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=gOVzyTbY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239583AbiKQNAU (ORCPT + 99 others); Thu, 17 Nov 2022 08:00:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239475AbiKQNAP (ORCPT ); Thu, 17 Nov 2022 08:00:15 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BF3E6456D for ; Thu, 17 Nov 2022 05:00:15 -0800 (PST) Received: from ideasonboard.com (unknown [103.251.226.79]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7A522105A; Thu, 17 Nov 2022 14:00:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1668690013; bh=7I4XZur3XWHa7tenurKlkHinu6BspwE8Zh84rEdNBW0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gOVzyTbYqueSEsWntTvaBO27iXxe2XQdULeguVvImsXSsUJAoDKgYtDJzaxC7m+0p 7JSC//J7tMX+ZBhtW5uBcyU13nByQQ/W/6J2OCImq91vJb3ax7RtE3Ym5MYDYZLTfH z9lHV0fUeg16Sd1FL0SghuUZDsRviYYLuGlJnzxY= From: Umang Jain To: Florian Fainelli , Broadcom internal kernel review list , Greg Kroah-Hartman , Stefan Wahren , Hans Verkuil , Dave Stevenson , Mauro Carvalho Chehab , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: kieran.bingham@ideasonboard.com, Umang Jain Subject: [PATCH 2/2] staging: vc04_services: mmal-common: Do not use bool in structures Date: Thu, 17 Nov 2022 18:29:53 +0530 Message-Id: <20221117125953.88441-3-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221117125953.88441-1-umang.jain@ideasonboard.com> References: <20221117125953.88441-1-umang.jain@ideasonboard.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749748615750915433?= X-GMAIL-MSGID: =?utf-8?q?1749748615750915433?= Do not use bool in structures, it already gets flagged by checkpatch: "Avoid using bool structure members because of possible alignment issues" Hence, modify struct mmal_fmt.remove_padding to use u32. No change in assignments as 0/1 are already being used with mmal_fmt.remove_padding. Signed-off-by: Umang Jain --- drivers/staging/vc04_services/vchiq-mmal/mmal-common.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-common.h b/drivers/staging/vc04_services/vchiq-mmal/mmal-common.h index b33129403a30..fd02440f41b2 100644 --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-common.h +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-common.h @@ -32,9 +32,9 @@ struct mmal_fmt { int depth; u32 mmal_component; /* MMAL component index to be used to encode */ u32 ybbp; /* depth of first Y plane for planar formats */ - bool remove_padding; /* Does the GPU have to remove padding, - * or can we do hide padding via bytesperline. - */ + u32 remove_padding; /* Does the GPU have to remove padding, + * or can we do hide padding via bytesperline. + */ }; /* buffer for one video frame */