From patchwork Mon Mar 4 10:11:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 209484 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:10a:f01:a869 with SMTP id ju23csp1327419dyc; Mon, 4 Mar 2024 02:16:56 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVS7jR9yD5wtGfw68mQwyh4JJvSWk8yrRWtqgd4WuHwOu8NkSF9LO+TkwSo3d7ih4+pDiAf6P0VYts4ADLlN6tk8ElaGA== X-Google-Smtp-Source: AGHT+IG0Dw4D2jYuCFr827exHbb9k8cuX/QeevxlCmKjKQ/UGPrWri8C1RD44WZc9Mz/VerQhYwV X-Received: by 2002:a05:6e02:1c8b:b0:365:c9f8:5d30 with SMTP id w11-20020a056e021c8b00b00365c9f85d30mr9565540ill.30.1709547415800; Mon, 04 Mar 2024 02:16:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709547415; cv=pass; d=google.com; s=arc-20160816; b=Nz0zauqQHKSmz+KDchzj+s5xPZlDfT1m1nzBHrrYnfDNNjLVDMy8AZyRdG2SQBfGCl IpjlT6xggHo+u7oKvb64A/uts/KPdA10uldCMVVbcLBNc6a9r5z5GU8YvyWY7HidI5a+ CHbNhzvGaWtgMTAdrYun68R0ji2TdXun2EIs6As0zrGv1ZCeEnCoBK08L3vHEwMxh3d+ GoA0BhVrR5hjOEI+lVZqER2bU3VSptWapRht5YpKmJWHbf0KvnBDkETyeJ5v+TP/5Idu tQ2tv5dPyhrbwtzsY0GsFMgs0F8ZxxN1O1XD1zstOVXkRcl8SwTr0Jv05af/2nQZOQnN nHrQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=2l7UpgtGLmRWEg57s509hO79ijY7GD7vXKq1B5m81jQ=; fh=HTpa6F5InDKG2T/ZZwuEOcEndje5cn7wQFmU8PPtnI0=; b=iGvWfgSfoNBd4vJLNUYcmFXnkltUG4dSRozjhNTCcbm3/YAOJgSEb2SiToozgGvBDR mCDqkqEVFPk2ONTbxgSVKEqhMmhO5jqRECFQaYCc/ZxTkFfhqIR8ytu2iayO/w3YvS+h MMopcz5HRpJNqRKOLIP638xohlA5NixpBIk0jn1VS6GhEj5s5SGkPsZNBQBEa0c9SRek h3cw3KqkBzwLWJRgtqHpj+xwyiqhD5TU1bEPbveSuD+dcPyruTovylY1V9nPkngGHJeT EzDP8GChvmdF3mQ+CBmM8NGVYeJW9zTNDhopYp9v0MTWZCQW7Ts0XLZ28ejhvLifxMG2 miDQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FaixYMHg; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-90382-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90382-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id n9-20020a6543c9000000b005dc1bb540cesi8017710pgp.76.2024.03.04.02.16.55 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 02:16:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90382-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FaixYMHg; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-90382-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90382-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A667DB23068 for ; Mon, 4 Mar 2024 10:12:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5A05F2562F; Mon, 4 Mar 2024 10:12:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FaixYMHg" Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D397C224DE for ; Mon, 4 Mar 2024 10:11:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709547117; cv=none; b=dsh/E/URjOvmACLTOj3gleV9t+A96uUltO0SxErGBpArIDJLsmursqfzvcir9NHU3/5UebhsJZZokGlKD2MtaGlhjzvdEIuofelmhpEI5HghTxETcpLPYngSGDI7hvP4hDtdyk9G2DblP0dmiKoFBm6mibYb8f0dLr+COTk6/TA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709547117; c=relaxed/simple; bh=L1gsWac4GlPBRR3BJYIkKHgN/RCN5L6+vXyGAdt7/+A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OPVyT0ZhYwRXyIJVDBDRqGh6WLDVqJIoxdcn12PZvmctWu73VrhGcoXdlwHPG40uZgb0XpdggP/nhDPE8N60ehqOiONpY8TMXHV1scPUcJSYq7jS3dJHgybz6ct+I/eO7UIwyYTIgoowPaX3jnTlOxlroSTO1OZwJMO8goLo16Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=FaixYMHg; arc=none smtp.client-ip=209.85.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-565ef8af2f5so5532710a12.3 for ; Mon, 04 Mar 2024 02:11:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709547114; x=1710151914; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2l7UpgtGLmRWEg57s509hO79ijY7GD7vXKq1B5m81jQ=; b=FaixYMHgXS2yUzge5gKjfWneC0/ZlCBYgnmPsea8XRPIMJ5trYiJ/P/tC9hbbFsrxZ OBH2SxhPmDKbmaxy4ZlU30UmuUiMzRFnUtpn3NyOvWQvHzgpFXG3GG6Xr0lHhoovKfU2 Lc2WPeDw1ZHPLlFgWugPHtgZ/jDUMcdEAOPZwzzyRrbi7crrS9iXDYyKjW5ieFlEWfmt HayzcHVnCeCIgrsBfXQN8eE1ZV+qDiPL3JC1c4QKdRxrx0cPQsfUap7ofPIdpvoBd57/ mb038C3mlOG0nNxFVt+lg6jybNzdq+G4qVMwnoUxDebocUGe5+siXDlo+XX1JV0UZ+wj dtdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709547114; x=1710151914; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2l7UpgtGLmRWEg57s509hO79ijY7GD7vXKq1B5m81jQ=; b=g7cB/L72BNMZQqjATm5sMKMU8BIFu9s6U/n3scnTd0+Ma6MvMp1hyF1lE2FbBcZOL0 TXtAWulpyX41IIYtfkd5iqAIiNdvPjzu0KODAUbtNrtKnLXvsmjuTRAac8tc5Fx0Tjbu oofcqSXCTrJGhzm337WmgFk/zmWGcriUl83R3J5bIXKGcIkOSwKFDZL9xETIiwNX2qvY S2X0QtQaaE1IdooHyEfJlW/1nUDorh6p0YvFbFy7bQQxMXljthoWgjjtEHWPJ+cjF4gI IICgKRgCmHfcB0feMdUyGuZWjdRiytBvRvx4TVOYE7m4Lr0imlo3gJ+XhZp4wkm1c0cY DnrA== X-Forwarded-Encrypted: i=1; AJvYcCW4rQOa/8ORAztP0yyilb3ZYKFcFFho3+KfBs0hy9uH4B1jZ+VixErssQfVUm8Iw7AW0uNoXR+kol5zd8F8UzPSFmjcdcPNPE7nuKdf X-Gm-Message-State: AOJu0YzQqAL3jlxz/9YE933BF/jbjDmaCOpU9R8IPbuk2sBLBtA9jKwm 12kX+TeuFtZj0oXbR+cxPeY2ykrkpqLlH1KBLhmyrTMFR1TiRth3dukvx7/m7NM= X-Received: by 2002:a17:906:f8d6:b0:a45:2e21:c78c with SMTP id lh22-20020a170906f8d600b00a452e21c78cmr2053919ejb.13.1709547114198; Mon, 04 Mar 2024 02:11:54 -0800 (PST) Received: from [127.0.1.1] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id ef11-20020a17090697cb00b00a44bc99cd89sm2938481ejb.42.2024.03.04.02.11.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 02:11:53 -0800 (PST) From: Krzysztof Kozlowski Date: Mon, 04 Mar 2024 11:11:38 +0100 Subject: [PATCH 1/7] backlight: gpio: Simplify with dev_err_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240304-backlight-probe-v1-1-e5f57d0df6e6@linaro.org> References: <20240304-backlight-probe-v1-0-e5f57d0df6e6@linaro.org> In-Reply-To: <20240304-backlight-probe-v1-0-e5f57d0df6e6@linaro.org> To: Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1176; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=L1gsWac4GlPBRR3BJYIkKHgN/RCN5L6+vXyGAdt7/+A=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBl5Z5hj0XQi7kaF+7e81MFcwlKfdVr65vaHpPDi MjsbG2Is3OJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZeWeYQAKCRDBN2bmhouD 1ygRD/938KcTcARGYikW/nyTzAfcX6ZC3q6UvmWTsLjqnFXltYckmIM/zt+gzWek4+bhQ9S1KS7 Qmd2iAiCs6EU8ne7ebg+KIqQO44shqs+JFKqcyukBmdZ5f3P9ijrQk45S6KhhX0Z6PPohIoi98W GvTvFNX35xb/bjClwx8vtCuk8hJo6PolwiWsStWd2eenHGpk3qbOIiLVSV/NeF4TOsyVWpkNpET 9BaDnLv0gBXAePVN6cy9mRLzD5JmzucY8gGBktV+zPhsbpNrTBDOJ/TNiydgwTxSVnJ+q24kWkl saS6lwMG7z2+0bfaiYCq/Aw+MicguWKUDtkyBTa2qqvmhYpP1URYMiOmjk2+aq1t/fpHJuvqrP5 BhpZUHSlr+ck2ZbOJ2ckKXJ5SN3E1gVNVBYieebwzJ8G5m3mXZBKqOOvfQNMeSNfclN94ICR2QL nQIXGnO9EV/OwjRtKLapX9M5FYXsGLYvjXSpP+Af3WU6JHlkhnjGTOSnFBEWujD5yINuJJEF5/a qqopAv0qk5pujRsYiT85L6ZtryQOrZjznB6t3TdaO4dWZPnx8TcRSDulZLen4+WD7vcwUlw3yQl L+GrxwPMuZbqP03xEch1aBS3qvs+KFKTbyngpjIdSk7pFs8yUL+CTQ8q4+egzW+n9eEhvoBjZiB UtT5J0qdAwvwdTA== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792590391294343178 X-GMAIL-MSGID: 1792590391294343178 Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Krzysztof Kozlowski --- drivers/video/backlight/gpio_backlight.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c index d28c30b2a35d..9f960f853b6e 100644 --- a/drivers/video/backlight/gpio_backlight.c +++ b/drivers/video/backlight/gpio_backlight.c @@ -64,13 +64,9 @@ static int gpio_backlight_probe(struct platform_device *pdev) def_value = device_property_read_bool(dev, "default-on"); gbl->gpiod = devm_gpiod_get(dev, NULL, GPIOD_ASIS); - if (IS_ERR(gbl->gpiod)) { - ret = PTR_ERR(gbl->gpiod); - if (ret != -EPROBE_DEFER) - dev_err(dev, - "Error: The gpios parameter is missing or invalid.\n"); - return ret; - } + if (IS_ERR(gbl->gpiod)) + return dev_err_probe(dev, PTR_ERR(gbl->gpiod), + "Error: The gpios parameter is missing or invalid.\n"); memset(&props, 0, sizeof(props)); props.type = BACKLIGHT_RAW; From patchwork Mon Mar 4 10:11:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 209485 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:10a:f01:a869 with SMTP id ju23csp1327557dyc; Mon, 4 Mar 2024 02:17:15 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUeL0Yspk2GuSx98BZD6+KPJ1v1DSF8U0YW5bcZNGRqd+oQJFssxL7wtdUi2UG8m8Gjd820G4bXj9sNLwGjlCR+jgbTeQ== X-Google-Smtp-Source: AGHT+IFN3/DR/4CzBPgPPZix6cLOvBYgoKE3/U9P0bcG6LbYLfaVP75CPM/EpwDk+pwI276Mc+ml X-Received: by 2002:a05:6e02:20c7:b0:365:13a8:4090 with SMTP id 7-20020a056e0220c700b0036513a84090mr11667859ilq.27.1709547435749; Mon, 04 Mar 2024 02:17:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709547435; cv=pass; d=google.com; s=arc-20160816; b=HggvEuH0qv/b7lZbFCf7Pe1h8D0Wvl9/DG9frokVtIGLOW0Ey/7oXfrYpfRpi0oh/p FwTvEukyaRDv/rZbdnUOCPeul02Je8/xt22PkVIFS5XA+/4tivzX+4FaOw6F7IfRWF13 aND9Pp7FF35MxeSIrMC0lfiFZ2vNPfsu6LIewSUfX4U0BvHkU056n94jsBa9aLRCUU8P EJbXgcg1UtqsvPPAtr+a9kza7qDIwUwSBaNuEbf7NaRGNKS72Vom0VrddSUDidWVQM1A AZInyGL4bbC2wyUMDZcA17be2mcumtN7nfabrnYcIXOML3wSvvB6zBrYin6ipcbB6Oca TCcg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=N1FwEFy+Dl2uRsNArjy2my0aFqui23Xcgx08mwBp3cc=; fh=YbVIEBk8INDkyhrGnDvrBmdSsmthpEmgm5QXFrWnQVA=; b=Swj3ubmC4PCPM+eLnNrl2dDO9Rd0tYtF5cMlfPjiztAmcvO+82J1FZ+GZNC8qnn5AO jlupIMxb7imx78NO/+/DOjzAauKLCAzfvCr8+XpomCvAiTaL+JztreQVtXTHDU+b6+Ti tC79zcsliIO4wlhCxh2ddoL67iQiH/DapRaVvFxQg2pK777/bEk0yptjy202RqYUqcPU PS4nHfQgTplG6gJvUo0QhuXeIlYPoVBArcgvmg3AwFdDUAs0I9xeL+Qgph09bYjhIMad L4vYDTrvkAZbHdYVwxJPBCPZ3s0SfGSGdGhgpg2HJSRPCIg3dMtT+VQN26WbZsRoe16Q E8yQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oBvOxM9w; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-90383-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90383-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id q13-20020a65624d000000b005cdc5c9d6a2si8165745pgv.576.2024.03.04.02.17.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 02:17:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90383-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=oBvOxM9w; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-90383-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90383-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 9D7ACB2321C for ; Mon, 4 Mar 2024 10:12:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 39966364C5; Mon, 4 Mar 2024 10:12:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oBvOxM9w" Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E1D1225D2 for ; Mon, 4 Mar 2024 10:11:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709547119; cv=none; b=B1K58HNHJ4G/gIfkYKpu+q8yoc6VnNg1UY71Qe1+aM4TCl9HzdISu35DLuoo7arCNBkiJ7P1abCLgiDX5yZgbZm484bWSp9F49Dq4lfP39VJZTC5ZtUko0ebqTDdMslJb13kV7CN7/H9XW81fQiQzk1D4GKBuG8/u1RQizaqwqU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709547119; c=relaxed/simple; bh=NY6ffh05b3e06y7LUri3yhspGUFjPVtoTn9TDh5HN+Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TvvG+k28fpJHK5vcegcilJqpYF6rHiaDqwqm1IcOrrh3skrs3mA9JDqiYE6YfzMXEubN9Tvxc/0Zcr9OVMsOhF0j7w4laKVqbDGKrt81fDg8zvSqVCgHWLioUp8xlyCcizTmUW6+n+wfKVwIaJyUWGy2mwCSydE3j4VO+eYMQ28= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oBvOxM9w; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-565ef8af2f5so5532742a12.3 for ; Mon, 04 Mar 2024 02:11:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709547115; x=1710151915; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=N1FwEFy+Dl2uRsNArjy2my0aFqui23Xcgx08mwBp3cc=; b=oBvOxM9wdb31Ou0VnNu6RL+nOzpvA9DbpCeSc0Gmwd7biSohKwNCmBEw6q42tSZ/i4 SBK0mEM7+vxwlcfGfGppDNdbrlR0VEQ0vQ948sr9Nhnuop05GwEg0naORcXuw3Jphn4B jWnL0+YToffKwQiEkZ6o1T3jtylmaWNFAoVfvLlEScObcUUPv6tcjAjmkMwf/Z9O8c/v 7lCkjdaFNmIv8p0kWWj8iEYkpgVqFXETiFFFNB8Mj7qDV1L59RjAMNxUBErG88n5iINQ hVlMYLOFVynYOeaOSLq0iqi8GyU+6CmE3COMa7rNhxIzmi67mmLjHk8nP7JJRIseuWxf 7QWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709547115; x=1710151915; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N1FwEFy+Dl2uRsNArjy2my0aFqui23Xcgx08mwBp3cc=; b=M5cFjDnm+7rxIEqxH/x7Pbx2+1RMfx9rK6dAD5ZOS7/rKXoJuA2c237EMPYfmGX9Y3 8XydBfrlU0fkps+WJJieLb7kSRDM1tpc3NvzvgnDlRBfeWPwDI1HcRNKoZJtF/r6o1fn syCnZTZbjdtJqkpeRCCOQdyclaL1Acm+xgT1PUXovxeXdz0b8EJV//WMWpfAc3BfFx3a nl3q12dAAag7l9Vgpl76QYOFi8xDRKSEhug6BizIJsf8M6yO9pK5pX8xls2Owd2Vuin2 UcroJaJtmrBqX1XqMi01+HdqveJ4dyTBxn6gH8OEL0Q2Hfq9AeQvUwoh6wrKDwPERcRR De7Q== X-Forwarded-Encrypted: i=1; AJvYcCXIrVw4u7TPdZQVzSeSKzR4bP33Ki7MS51gkhFMyuKbHIhaNQ3bPLwHhHPU4BLbaVUX1Wz0e+F06e+M6rHAvY33pGsiSbhRuU2PAJLa X-Gm-Message-State: AOJu0YxxohpbqxjM8fzE20L6TnMJaiqVPLsF5vtFm1G5w9Ab6jT1mmPM BG1ZiSSMXsrNKCU6O6shBlNj+s+kvsDy8dhxh5WNF54qcWXfhO5fCMN3j82x634fS4pFWSb9rWP a X-Received: by 2002:a17:906:f0d0:b0:a44:6b6b:bae3 with SMTP id dk16-20020a170906f0d000b00a446b6bbae3mr6905807ejb.59.1709547115593; Mon, 04 Mar 2024 02:11:55 -0800 (PST) Received: from [127.0.1.1] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id ef11-20020a17090697cb00b00a44bc99cd89sm2938481ejb.42.2024.03.04.02.11.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 02:11:55 -0800 (PST) From: Krzysztof Kozlowski Date: Mon, 04 Mar 2024 11:11:39 +0100 Subject: [PATCH 2/7] backlight: l4f00242t03: Simplify with dev_err_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240304-backlight-probe-v1-2-e5f57d0df6e6@linaro.org> References: <20240304-backlight-probe-v1-0-e5f57d0df6e6@linaro.org> In-Reply-To: <20240304-backlight-probe-v1-0-e5f57d0df6e6@linaro.org> To: Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=2430; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=NY6ffh05b3e06y7LUri3yhspGUFjPVtoTn9TDh5HN+Q=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBl5Z5iGhsKCRV6SnmJLcxk3l63l/2wXkWX0mqPw FqUYp3+MCCJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZeWeYgAKCRDBN2bmhouD 1384D/94qBZqd0L96f/YTCIfX+UGorHT6vsSGWZKBQDglVcQtd+W2q9z5FyqxQRpgTRGNrrJaJr 4XwBT0yhzuONJj8YysOc6z01URhYjs+1rTh0qxQ+1RO8iepYCX2CIcmi5mDsnwLLmcarlNY+Bzs P4DnCKWECInNTkU8k5gOHSfMEwr1ZI1pF8F927yg/9LQ6cpdwhkQhj89oCzr4riJg6w32dyIMZw IdJzS9rHxaGQNPW22klHxPxlE5L3gz3/xpkA3wlGUrD9EtRIoyzdbKUJDuSmIlcED8A0C/ZRXpF gjKj29XREHEOEdWkN4TQER0kkfBpvx+FjPWrfSm+bOs48jgR4JQiB2UMZprxaUUhk8zikuRByC5 u4lL0xzLBoqLmRqQIlybVuN8VESMlgeaw4ipEn0M7QVbvZi09KPsmeXi1RtyfgUF5nmPYDePky+ L3vXzDlQduxOf5bn9F9oRxVOsmGCiHppov0WVudC857+DAkprPcZmFOeoSnnfmkVWJNF3VMWLAX cAeWwpIIonnOJyiRXcOQlAIcsbfa1qZ/0SRkdg+abAPfGLwQ/crRlY2TKxXUBLCuUAkTNyB8mvX 0AdT2K9K8Rzu13mZQdmZ9w+xQ1EFIvkyxf/kgNnILFMpr+BC9TYRP4OF3XpkdfAr5K2b9Bkvkfp LP0YnjvPJA4aPdg== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792590412264432212 X-GMAIL-MSGID: 1792590412264432212 Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson --- drivers/video/backlight/l4f00242t03.c | 34 ++++++++++++++-------------------- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c index cc763cf15f53..bd5137ee203b 100644 --- a/drivers/video/backlight/l4f00242t03.c +++ b/drivers/video/backlight/l4f00242t03.c @@ -179,34 +179,28 @@ static int l4f00242t03_probe(struct spi_device *spi) priv->spi = spi; priv->reset = devm_gpiod_get(&spi->dev, "reset", GPIOD_OUT_HIGH); - if (IS_ERR(priv->reset)) { - dev_err(&spi->dev, - "Unable to get the lcd l4f00242t03 reset gpio.\n"); - return PTR_ERR(priv->reset); - } + if (IS_ERR(priv->reset)) + return dev_err_probe(&spi->dev, PTR_ERR(priv->reset), + "Unable to get the lcd l4f00242t03 reset gpio.\n"); gpiod_set_consumer_name(priv->reset, "lcd l4f00242t03 reset"); priv->enable = devm_gpiod_get(&spi->dev, "enable", GPIOD_OUT_LOW); - if (IS_ERR(priv->enable)) { - dev_err(&spi->dev, - "Unable to get the lcd l4f00242t03 data en gpio.\n"); - return PTR_ERR(priv->enable); - } + if (IS_ERR(priv->enable)) + return dev_err_probe(&spi->dev, PTR_ERR(priv->enable), + "Unable to get the lcd l4f00242t03 data en gpio.\n"); gpiod_set_consumer_name(priv->enable, "lcd l4f00242t03 data enable"); priv->io_reg = devm_regulator_get(&spi->dev, "vdd"); - if (IS_ERR(priv->io_reg)) { - dev_err(&spi->dev, "%s: Unable to get the IO regulator\n", - __func__); - return PTR_ERR(priv->io_reg); - } + if (IS_ERR(priv->io_reg)) + return dev_err_probe(&spi->dev, PTR_ERR(priv->io_reg), + "%s: Unable to get the IO regulator\n", + __func__); priv->core_reg = devm_regulator_get(&spi->dev, "vcore"); - if (IS_ERR(priv->core_reg)) { - dev_err(&spi->dev, "%s: Unable to get the core regulator\n", - __func__); - return PTR_ERR(priv->core_reg); - } + if (IS_ERR(priv->core_reg)) + return dev_err_probe(&spi->dev, PTR_ERR(priv->core_reg), + "%s: Unable to get the core regulator\n", + __func__); priv->ld = devm_lcd_device_register(&spi->dev, "l4f00242t03", &spi->dev, priv, &l4f_ops); From patchwork Mon Mar 4 10:11:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 209486 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:10a:f01:a869 with SMTP id ju23csp1327664dyc; Mon, 4 Mar 2024 02:17:35 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVpZNjCK4t/Mev/taitQhcmTdMb5mSUDpQCePsjdCY8tNV1p/jN9Ak02NlvJ8VQ9bgccAbyQlRFHUWJuMJJO3GeGscnfQ== X-Google-Smtp-Source: AGHT+IEUZb2EVQlUPzzc0Nqz+uYaF0QQFux7lDjeFOH1GSAIKKo3hvHSfEV3i/AbEWNzi4Uk0+mF X-Received: by 2002:a05:6a20:8f0c:b0:1a1:4e6b:185f with SMTP id b12-20020a056a208f0c00b001a14e6b185fmr2133324pzk.25.1709547454960; Mon, 04 Mar 2024 02:17:34 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709547454; cv=pass; d=google.com; s=arc-20160816; b=YTg7wL+17WZyEWXuQbDHFq2CoIDpBod3DaXQqWaKFXw+23NpvMWa2dQft5yVY+pbGG dWDmt8yeDLO7Df6vdlO7gc7kZZqDaPTYXzEwECxXT6d+7ckEfwjQtgd4h+N/+7Rn1c/w tHTsBjVNHLT0ryUFF17umKYN8b0/WDuFNnlGET6ykPKkf7fPrkRypODsOfAeDGsqkF03 Zvf4X6b/g7wH6gHI5m/xZs1AaxGq28zJJNDBfxsTpbtIRIV7EbS52EwHk/UNFxvNeGVI Eh6DlmWt9+7iXhnCj9Ld2JzVSo3bs8Bz2YapOC6Hp+71yie/hg1r69yD81xVfhDJ7K9F HXmA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=Ne2X+cO3epNXe9ln4awOX17bBGBk21696xx6GBwAIpM=; fh=iZIFuP/mc7yLV3nMKsIps3ED7IEWfIe0XRlzOlRsgNU=; b=ZC93AV7OWioF7hHc4qDjdl6wKXshx56ySsAyixgkmMwdnGI11uW9If8sRbs/Yoy9zS psZhlkppElGyLJbT0mBlb0i4ls31iFRR2aJxZsdoF3nnqsLHQo1RiuO6wOW36HSVgTzL kF2vN6tmF5gTxgSh5Ce7e/CoY++uzvfL7Zeszc9C/AOFviuGacdKPBlbutu38wDQXSgT E/bG8G8sAXdgKbrYjHzlTnzM8oA7vvz3OpanOHBAySvKPrBZyiQjZin9sSiBaWzdHJ2Z S0RirhIwQAmhT1Bq/4b3Yi2ZIKKkHO/rb8mt3d7KnSrgy8GdQWKv2UH2M1bgDdSQpYMP akpQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MGKlp4T+; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-90384-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90384-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id c17-20020a17090a8d1100b0029af479aac9si9982877pjo.2.2024.03.04.02.17.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 02:17:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90384-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=MGKlp4T+; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-90384-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90384-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 1396FB20F08 for ; Mon, 4 Mar 2024 10:13:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8627737168; Mon, 4 Mar 2024 10:12:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MGKlp4T+" Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC8B5249FC for ; Mon, 4 Mar 2024 10:11:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709547120; cv=none; b=FGGzbT1h8kuEyrmWT+IhFATYvMFGOl2dfbtnJIJm9bilKqR5CpdOjY3Sj5aOCUIhCFNwUVB07Hy+QzdnS2B4i2r3L7JpVww1MYJBjpFUJQOZ+FFmTknrXNzFg+veEm+IJQSSEgCncmcGH9X03pBnF4SrsUHcsn2DXwitPU3buzg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709547120; c=relaxed/simple; bh=oBEkNwxibRPgfDk3iSeQlCR1ZXaxiSrVLWAc+9a0T0g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nK+1PZ9WpVQaNjbUH+uXfNvyt3z2GYE3GWdU54+Iq+wAq0W8lfeZcTrv0vacuqXScoEpzyQXxhOCZfDjn2HdtMTc3PYq086oYLwxqj2Zzcp72DRXIAHXbYyUiWUlk/UyAEI77HynW3XZIy8g+2/zobZ+S0VfDVU0RkeWx4uH9Ro= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=MGKlp4T+; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-a3ed9cae56fso985897266b.1 for ; Mon, 04 Mar 2024 02:11:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709547117; x=1710151917; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ne2X+cO3epNXe9ln4awOX17bBGBk21696xx6GBwAIpM=; b=MGKlp4T+rbc1DCnqZx6QpHL9zm2bziiHgQd+WkO/1y8knm3GLNLpdY3zOXzQw3f+nW 36An9kwh8NemT8OEml8ZFK3j9IfhN9mG2k3o4gmG4eCGzGzJXCPsAna35W5ptJQREDyG qHqc50nQARL7t7RSgYDeCx6Wm58fAOcF1QG5AEyFwoBw4rTMEvFOA8H/VGNTmKZDj7iZ hm/RVxobpgH9Sa8dIKvi0D0wI4syM/E+chppnDhHjBQ1EzRvfYHnwz0HeL4WmAm2uOPW cR5Co3rIKU6cQxBHg9hBLEbGUeQJZOrt+8vzLe315lhxvWKHIVVIFq8dUBZVNpsGq1Em fUeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709547117; x=1710151917; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ne2X+cO3epNXe9ln4awOX17bBGBk21696xx6GBwAIpM=; b=WcSrXt7Sgf/MYcBTmfaUaFtg9O2jHy+lDVygI0IuAYT+Woab7f8W/VYYEZ/oIxCHzS pQGMGDmxVdFEYJopxaH+XsNE4YLIdg5YaJ3SmEXwcFyeP2sJAPEyHT3BE/qzGoTv/gX7 ysbMB4jkGWn9IWDnyr13BMfKS2KHSO8VL1zP3oJDjx8elUmSmk/OGiVHjwUqniz+rH3n 65mcoBMnA4JU3qiAGwfUigwznf8VhzZh5JOlMDt8vw2eClApXLBK5n/OTqAjYtqpbLts Enhrv8Tq9VgPHkAxZjbj+ofYqsDCaqNxxDXPly4H8c6Z609ZaRArgYpMR+txl0m4sqtr iXVw== X-Forwarded-Encrypted: i=1; AJvYcCVPNfzJWdRObQDoPlIKd61foxkt1B4hjFz6UEGXwAA3vVEiOAqjD9yvPoM6L0+/1akscfaQkAI4xV1yveL6O7HB7vZ+wlJ8ApTTnniy X-Gm-Message-State: AOJu0YxNpU1n95Sjqw5spwoZPgeY0W9flKnwpt1RhDCaokhWep6z6Jz3 rc1fpBr3gkDuVZz/p2Ctnly/687D+LmK2LIrc9xcluq4VxlclQpzGhwJQa9+RGA= X-Received: by 2002:a17:906:6c97:b0:a45:2cf3:6c65 with SMTP id s23-20020a1709066c9700b00a452cf36c65mr2316877ejr.25.1709547117400; Mon, 04 Mar 2024 02:11:57 -0800 (PST) Received: from [127.0.1.1] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id ef11-20020a17090697cb00b00a44bc99cd89sm2938481ejb.42.2024.03.04.02.11.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 02:11:56 -0800 (PST) From: Krzysztof Kozlowski Date: Mon, 04 Mar 2024 11:11:40 +0100 Subject: [PATCH 3/7] backlight: bd6107: Handle deferred probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240304-backlight-probe-v1-3-e5f57d0df6e6@linaro.org> References: <20240304-backlight-probe-v1-0-e5f57d0df6e6@linaro.org> In-Reply-To: <20240304-backlight-probe-v1-0-e5f57d0df6e6@linaro.org> To: Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1247; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=oBEkNwxibRPgfDk3iSeQlCR1ZXaxiSrVLWAc+9a0T0g=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBl5Z5j77gB1Wx0xWhb8EDQs62oL63I8/c7sddDs CC6aYwM7c2JAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZeWeYwAKCRDBN2bmhouD 1yAHD/oD63Jj+FaduY3m25CAoOSOqZrt+/dbgU985Nod7ZV2XRRMJEItdueEuA3748jPE6o2Crw iKIWC5h+bsPxgR4zl9V2j19cGWY/+UdpElaCU3a5y6IeK6Gibi1CCSovo+wY3sUvFhe/JPp3Ehu XABYIK8t+C0udLjNPoTi51pdBqNmWcTHa6zZH8B4i+mbImB+4h4wWt7zbKgAd5RBGCeSLDon4y5 UdXbUUQ/M1VobGvTvha2KDdxmCQ0ZuItOTjzQ9eCh7aa071V1uHbF8IHTvLiCdCrQGd099Xc00D A6JyiyJIiOiid0BRh7EC1/kIHHbcXfogpZpcpaSGr8IxAj7bytITyUtMAIetq9D/c5t9Rlp5PAf WHm67lyeJxjyMXrW8BWbN4FeukFR6Qf3WlwEKxTBd8ItB3pvZ9+/LpVhRv7mAI+TST4qKnvoJ+3 8WQlYy571QWu0kYwQfVXIz3gCS1G+lbBlT7pkydCU9TeAlxtjcUUt3W8yehDnRr3lzDlTTsH9wV 7TgX7eMnoNQ+kReZ21Auu/HX88NDWYCNQ7rPs/VT2RckfKP7vn8JdWnc6P4N7yC4kx+mHKuizue mcvUhlAxB57g96zl7F0RVZ7gq5r1WhuKnIogHxHi/ZaCWVJJTSJ2o8AdIvgg9PVbHlvnM769UnO 8X9j3780xbqzNcw== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792590431863578180 X-GMAIL-MSGID: 1792590431863578180 Don't pollute dmesg on deferred probe and simplify the code with dev_err_probe(). Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson --- drivers/video/backlight/bd6107.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/video/backlight/bd6107.c b/drivers/video/backlight/bd6107.c index c95a12bf0ce2..b1e7126380ef 100644 --- a/drivers/video/backlight/bd6107.c +++ b/drivers/video/backlight/bd6107.c @@ -119,7 +119,6 @@ static int bd6107_probe(struct i2c_client *client) struct backlight_device *backlight; struct backlight_properties props; struct bd6107 *bd; - int ret; if (pdata == NULL) { dev_err(&client->dev, "No platform data\n"); @@ -147,11 +146,9 @@ static int bd6107_probe(struct i2c_client *client) * the reset. */ bd->reset = devm_gpiod_get(&client->dev, "reset", GPIOD_OUT_HIGH); - if (IS_ERR(bd->reset)) { - dev_err(&client->dev, "unable to request reset GPIO\n"); - ret = PTR_ERR(bd->reset); - return ret; - } + if (IS_ERR(bd->reset)) + return dev_err_probe(&client->dev, PTR_ERR(bd->reset), + "unable to request reset GPIO\n"); memset(&props, 0, sizeof(props)); props.type = BACKLIGHT_RAW; From patchwork Mon Mar 4 10:11:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 209475 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:10a:f01:a869 with SMTP id ju23csp1325755dyc; Mon, 4 Mar 2024 02:13:19 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWJMRKiF1ag/0w5AoxKIHHnWBbCvGDoEFLQCIYmT575auhNjvVOfZZurkP91wqmC7Fio+1IgKKFgKZO3TFHeNK/uJQByw== X-Google-Smtp-Source: AGHT+IHCpuwAy6Tkfvd6Vc8kCkjormTMxRXcifQiMsjbdUwTq7pazPaC95ZU6FcG8NIGz5bqLpnk X-Received: by 2002:a81:9483:0:b0:604:92e1:14fd with SMTP id l125-20020a819483000000b0060492e114fdmr8760730ywg.45.1709547198870; Mon, 04 Mar 2024 02:13:18 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709547198; cv=pass; d=google.com; s=arc-20160816; b=dqivhq3KNclABPMJqiOk2tlwtsuUtfZJWCst2tPrp5UOwA33TavSoHU5uC9AlSMuHe bUnNXOWgKsPdOKyKzCGgk07r/PPdW2ALqZ1TGUZvheuOsL+mKUaNMKQlq07snWK8jHBd F9/4k09AiBnwlyMKYdLRIBM32giGV7SZYu3M8ul1B5rEq9QLrcVjvRToGVOt720IHiCx cbG8Nrx+tXIBtN98HAD1DGYs2U7DXFtnmK/slOZNMMN8xxbGeYntlxxDtohVfEeztrTQ lfgAID3vIGBgrZKLK65wkblEZA6rpwrvGodfN4UMr1EgifL6gBbOyCEudH+12+BQgEl/ mpyw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=C7jNpD8JVN2zPECncF/JczEVQcdrOC4+lvPqKzDW3Nk=; fh=HXChsXd89QzBUGK6LIqe63oXYqWBUx21Fikh2TidN4I=; b=wMiMYIOwX2rFOlUkQBhok2vpCTcF4wsk0lqJJmkRR7Ucpv7eug1fSWJla14L3B6Gte sMIGaRBxuX+N6JC0ut49hRIOH1aHXjmbH5xpSaXF6+30pFb8sfHwjaoi2JyPOnL9hkOL ZDgfFLaQloBLkaLC6HN3l1lhMSvbnQ9vRvMTza4ROmAvAhaE2JPCmvCRNxTSocdBcq7V GsY2KCSY+pY0OMfPwxA2o3GkDew1RJl4hiLZD1kVFDshAFDHyatAvQWvM56Tykq+/PJY 98gw16iNA31KeJOVVWuI981RXNDu+HyXKrhKe49X1dFZifiUNnO7tJuMSZByDchuiMsA BG1A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="W9/S/NyS"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-90385-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90385-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id u13-20020a05622a010d00b0042e8d634e5csi9901483qtw.83.2024.03.04.02.13.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 02:13:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90385-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="W9/S/NyS"; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-90385-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90385-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A78F61C21F1C for ; Mon, 4 Mar 2024 10:13:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E78E1376FB; Mon, 4 Mar 2024 10:12:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="W9/S/NyS" Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4702125613 for ; Mon, 4 Mar 2024 10:12:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709547122; cv=none; b=a7Ces04+iSaoNIezRiHC7KM5BZRxmL26wVzp9g3rMFkiUWKO3nyx6YeCpBtYDpzcx3ZIk7nVRN7VbZklLEDFs58g7Fur5n2H2Q1lXtT94ny34XTcW8+v1YO4jJjPVwVrjOZnPDlL7ylxlBr4iLgzJ0fWKfWwDwHC1VXS/cIR4PI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709547122; c=relaxed/simple; bh=tYiRyc4GCWh0OQZcegdBJotlKUvQmMppy24vmgOYX4U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oDo9Aken05Ujo699Egaol/oCrlUnLo53e0do5DPt0nbhaHY1zwYQ8eVDE3Io2HVGpg18VUGUpmL0Qvfv4pFNHyUjeVXqu0p4vEsSNYEHEiOMY1/bMcSWiaVoO8337u57LLrZgjU2ecYS4Ou3cU+jnJhc2gFTlpJiPbr/G04rTrc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=W9/S/NyS; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a2f22bfb4e6so701943066b.0 for ; Mon, 04 Mar 2024 02:11:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709547118; x=1710151918; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=C7jNpD8JVN2zPECncF/JczEVQcdrOC4+lvPqKzDW3Nk=; b=W9/S/NySWL4cFC3wUi4hMnYsusgzmAgly4dN0BY6/j8w6yyZj6HPozJfCYqVFihtWl Q3uzqncKkJsxqcZCKQbkFCeetXjz4nEJApFYLz56wm9+vtV0ZXH+FwJytY3HCBtFP8eJ j8Ac3ZwjTqPh6Djey3tSzwN4oudRYGpn0cQSQWWLIxZiy4b+yzJ/JzbL5cbk+fzVsKJ8 sfBpNT93PiUwQGeeozWSxty+2I6gg/4Eo0FObjxBX23BqLw3Vw2LoJFVJwX0wDGy0B2P aCgFjC2lJ+gfIOK6ZUFSn8GnajIkCXlHli0YldFWc9qqI6VlkOA+fTf+UamJwTiSgq5l MIfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709547118; x=1710151918; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C7jNpD8JVN2zPECncF/JczEVQcdrOC4+lvPqKzDW3Nk=; b=rQFq+oU7nnb8D1xafPJMA5rEKm+XukmxKNzr3bSi+g4O5ryIpEITZLlmMaUPIZvbOd qDnqdLPdR4IBEsmCe6yeFrRB/q7eP9uo9KNbJ+ZSSpK5/Tne772lAj3qEXE5I69lHQ3y EA9M8chi83VqKe6gfdyYqtEyCQcj3BtahB/jqNLYUQg+XiT0egJqLpPuJ9iANBgO7MsR pRAJ1y42jK2ldnvvrjMVd2PjQ1toeqwzBlQnYUg10SEz+NZeBU6/Wc+s/eUYuKuZBBo1 U391a4tG2uEXZ2chnIKEdBmLiODl8A03SW3CrFykzcOzcqTDpnhn5+E1n1WAxLa7VUdc aUgA== X-Forwarded-Encrypted: i=1; AJvYcCWhlvOfU0KeAiHPywnkDeily/nXLLiMHfcW6etw1XW15lqZ0cNqKtVoW2+LkK0R2jZhQoJpRS007KPOzdQs/dgi0Wk1jtoMb9Nwdjbq X-Gm-Message-State: AOJu0Yy1Kp4AdeMv1Kr5CnPTCxSSMcf6T12wHjyu2grHUUfWog2Wh3Ej TRcpJgpLYge/NMcKzdcdpswZ30+2V5iYWV/WXCtT3XhorOGglEtLKwbWrrBAnIo= X-Received: by 2002:a17:906:f759:b0:a45:6251:f8e2 with SMTP id jp25-20020a170906f75900b00a456251f8e2mr895177ejb.7.1709547118705; Mon, 04 Mar 2024 02:11:58 -0800 (PST) Received: from [127.0.1.1] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id ef11-20020a17090697cb00b00a44bc99cd89sm2938481ejb.42.2024.03.04.02.11.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 02:11:58 -0800 (PST) From: Krzysztof Kozlowski Date: Mon, 04 Mar 2024 11:11:41 +0100 Subject: [PATCH 4/7] backlight: as3711_bl: Handle deferred probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240304-backlight-probe-v1-4-e5f57d0df6e6@linaro.org> References: <20240304-backlight-probe-v1-0-e5f57d0df6e6@linaro.org> In-Reply-To: <20240304-backlight-probe-v1-0-e5f57d0df6e6@linaro.org> To: Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=900; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=tYiRyc4GCWh0OQZcegdBJotlKUvQmMppy24vmgOYX4U=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBl5Z5kf3pCwb8HgUK+ziA6YZsz55ShzwCbPlrjj dMl2yuN1lWJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZeWeZAAKCRDBN2bmhouD 1/DiD/9EClVTNg83B4aoTpYk6q3ArcCWKbx42PizR2X6dccHjBKLN0SzFYUPp8ZRWNevidleHfh hupUfnR2wyDAYPVPWV8dJtdgoXjqCxq1y/1koCVZDMh7rajI7WnOkS6+g9z8POlL19KGLVYdi// Namj816X6p+XoGcwG7ns1mStAJdsc/RkT0gkuAN42tg/vREKdLIesdNxqO6PHytr8lr0oL5Qlf2 O8Spa4QNgRt9FIlVFBvPv/UGY2ZlDjhUaPDn+xoIlqoCUN843JiGiAncg6CY+xPxs4XxbyKLFGp k2CSN4qRLf/sdfX4PagBz5wRrLKEkHDITyx0lJZ8K9NiSCWBD5XuJAApZJF81Fdam+7DIoyxPLd MxNndDTpFtHki2BkCFnq4kcOzKukGbR2jN0qBgi8y3H2JKsAdqQO3kgFS7Bec5ltmWT/4Qjtu2k cgw3rNW0c8rrFL/RpfV7mfgnnkB1HTcrv03TWerMJVvtTZlnp2udLIqpvjLsLiFj1Rl6Uy5ugtS aZ7OQgZkXseN2eOnZy3iB6URxjsuYEjwfWQ2pW8y8Y/1L4Sr/qJHZSTPRXKfNNsV19TI7msionx gDk54z5VALicMkbhcQGfaMiLD1bzd2ms0GRYNQ9KOFTFKsIu+56uI6bAXtAnbN2p5NypV/7lJ4w O9o+19pX4CAdJ5Q== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792590163426005895 X-GMAIL-MSGID: 1792590163426005895 Don't pollute dmesg on deferred probe and simplify the code with dev_err_probe(). Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson --- drivers/video/backlight/as3711_bl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/backlight/as3711_bl.c b/drivers/video/backlight/as3711_bl.c index 28437c2da0f5..e6f66bb35ef5 100644 --- a/drivers/video/backlight/as3711_bl.c +++ b/drivers/video/backlight/as3711_bl.c @@ -383,10 +383,8 @@ static int as3711_backlight_probe(struct platform_device *pdev) if (pdev->dev.parent->of_node) { ret = as3711_backlight_parse_dt(&pdev->dev); - if (ret < 0) { - dev_err(&pdev->dev, "DT parsing failed: %d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, "DT parsing failed\n"); } if (!pdata->su1_fb && !pdata->su2_fb) { From patchwork Mon Mar 4 10:11:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 209487 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:10a:f01:a869 with SMTP id ju23csp1327898dyc; Mon, 4 Mar 2024 02:18:14 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXEZ502GDMf8tgx/RXBcjYhjvcBcbb9g/eVw/ExVlWF/tP2994p+d7iNPK7XIoJpty/xR0A8wTUwlggeVAsMdu5UBb0Uw== X-Google-Smtp-Source: AGHT+IGmJX7Jgp01ozs3cGr0DRZr8qVdjP8wXpIEvx1kCA81xafAN4TQwtIiRdAW7W5rLBazg7sQ X-Received: by 2002:a05:6e02:2147:b0:364:2406:992e with SMTP id d7-20020a056e02214700b003642406992emr12677447ilv.23.1709547493915; Mon, 04 Mar 2024 02:18:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709547493; cv=pass; d=google.com; s=arc-20160816; b=uJ6HtnsPL1tMy3r+UTD2Wbmbwt60xURyzs/OJdDb2Fmlkx/WX9mdXn34iP++SfD4MN uiUItBnBKjo367P/6f+aDa7Mh8Ex+BnfuUKgVn/7zErepBMfOfFOUCNsSLtOlHRybfIh T2j0xbcxKAU0tKtvGzkHAxtOn6SUZSFgiLgFMxvkwzZj5dwSjbD7QGf+8YHMcACpK2mF LIy98ZX/XxhEuzv4AeZpi3fKygQHLYLLF6AoFBZ4y8h55pBpG6//YHeT0fP35NpONJkW Hj4tw6cANzQz1jqvhtYnME9dFlacCwmpA/FbK7VX/bHgAMsZsqF7w1RHn2POoOOXEf2l Kuwg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=LCgoEF8+45p8Lp99q3OTs1MMW8tsgAmVbVFGKP9cQEM=; fh=5wTgU8gbits0wRysmXRbpOeYyZ5WDgLH2XzzMshhyV8=; b=vgReVoG7Xn3KyoiWeSPUpfRaIakax4rHmyOuh4qowk3kNB1NA0Qyq4Co6IPpaiQoBX kYIVLOC1hoMrh5ApjyHzK/HsmzS9JkAIf2uzZu6+7Whvrpiy3j9owpFuFvOf+Yx9khYX 7Iu1g3CFbPMFC4zspmLItgDq9stvuIAj4Gg6JThKyGSFCbL7bxyURUlpQf8zHVFq5z6u kF8WI2XqrxQlg/y/mBNddB8wzHf9iMwbIsQ/Mm5TZuMKSYXbxKfxd05k5AkqRg33AtWL HAqT6Qjle+63OMgiAjC/k2d2w3D5z+EuUsiB97YpCqFsuP4SSCzq0anVB1xftkAGtJ+1 7cug==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=o5czkjK4; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-90386-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90386-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id bz41-20020a056a02062900b005dca1e01c0asi8931223pgb.880.2024.03.04.02.18.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 02:18:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90386-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=o5czkjK4; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-90386-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90386-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 01A12B236D6 for ; Mon, 4 Mar 2024 10:13:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1E3BC3838C; Mon, 4 Mar 2024 10:12:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="o5czkjK4" Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8196436118 for ; Mon, 4 Mar 2024 10:12:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709547123; cv=none; b=Qr93hkyNiqUHeI3GxYrABs/+v+EWWxrg2e4ihZKnwjwbxb3+ONfDmrmnQzl3e5SiKfi1j/jZyDkCrBHCSehkeRZpSWvaAqCLFvA4WFd2qfLEK5YAM6T2JMwk7Y5x1NxUukv4XWIKDTEJWEbhXQ5edIecRWKGtVIAiwQDklRc1aA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709547123; c=relaxed/simple; bh=l2zBfccz8Tq6SqYayq64DiM3PIARxZs9iJsKbpWBrMU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=U81UecHk43XZNzCipa0JzooYCbo7QIR85bP1dzWNFtY15q7rJbBcbYXXQ3KrrEZelrXhgyxaRLgvmd3sOci+r5/GIKQCd/WJgrG7Dqc46dFefWdaBqpd0bEz6qIPUjWRgntxmfyVtUbo7NdXqeXEvfWrici4/zEQR34km8b9DR8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=o5czkjK4; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a36126ee41eso651990566b.2 for ; Mon, 04 Mar 2024 02:12:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709547120; x=1710151920; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LCgoEF8+45p8Lp99q3OTs1MMW8tsgAmVbVFGKP9cQEM=; b=o5czkjK4RSpVBgK674czx0Y0UZmX5kVaW/jTxUXaCAyczOZkZ2SaORIty/SCURHMFV YW55PyysoOeMKdydrffXIL27VtIuyJr3qppTt4O6rbGJr89hNaL9TBCbkWCxZwrVf0Ta 3erACEIhteBJCzb/Ky9xUCk+IEN9fxbLyFpn+4jjF+f59nKXvMRN5SYRg7Ki/kTbF5wr M/Bc2sFk5rdV8NaU2x0HZcf3vSj5sFoUWGu0Wl7ZzbYk8EnNCgPkLrv7I4kNywzYXzsa lwA+77MQcpZ1Zz6WZAeWW87oUVQl8iM7DZMd/WnK2hqBelWa4ouorRFRDAqdReSxn4l2 Xgkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709547120; x=1710151920; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LCgoEF8+45p8Lp99q3OTs1MMW8tsgAmVbVFGKP9cQEM=; b=HqAmnVkNpVLayyGE5l9BdPkWKuH9cMKAsqCjshVxzxDVGUizmHVzHZF9lvjqDiF4ah l1JNge4VaGEEkOZuGHFIlJZL0qzUsf+TjFEMLSeuybz2+uHaCAoFsDy08hcK0eV97vuF kzWdwLotBlxfqzgPFhhnYT6fWIFSdJDuDwEj+Y7fdL6H5hNkzZbkPxv+5NsxTaDC6oXA wx9bBpF8UNfpiufHrQYhVZjW9XhsWq3QLDReF9Ni3xo2Qx20neA48UganAT/eUzG5nET 0esVM107MzyDCl3Q0oj7csoH9kNs0qW0DIjQqoEMNZOzsAMGtJT2RaqHUhOcb+Aymg6F lrUg== X-Forwarded-Encrypted: i=1; AJvYcCXlX+df7MJ4xtIzKPZIA4LGbQc+3DNOtOHEu3EmxWY8u17dDM8oxIJMt6VWst740mC5Le7on7JzRoejyeKOKFtNnjDV7XzpD8Px7cGX X-Gm-Message-State: AOJu0YwZHwFHGxbjNcErLmOabqBIQ3Y1/dnlPp6SIU/qEvhakizutoDH Zh/q5G/kVuuqs9ry3fw1JX2nFMk2EYakHAbT+uSyP5iKdB4bbcarXqIlYp557JQ= X-Received: by 2002:a17:906:c318:b0:a45:2b2c:8968 with SMTP id s24-20020a170906c31800b00a452b2c8968mr1743474ejz.20.1709547120032; Mon, 04 Mar 2024 02:12:00 -0800 (PST) Received: from [127.0.1.1] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id ef11-20020a17090697cb00b00a44bc99cd89sm2938481ejb.42.2024.03.04.02.11.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 02:11:59 -0800 (PST) From: Krzysztof Kozlowski Date: Mon, 04 Mar 2024 11:11:42 +0100 Subject: [PATCH 5/7] backlight: lm3630a_bl: Handle deferred probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240304-backlight-probe-v1-5-e5f57d0df6e6@linaro.org> References: <20240304-backlight-probe-v1-0-e5f57d0df6e6@linaro.org> In-Reply-To: <20240304-backlight-probe-v1-0-e5f57d0df6e6@linaro.org> To: Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=1010; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=l2zBfccz8Tq6SqYayq64DiM3PIARxZs9iJsKbpWBrMU=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBl5Z5k1b8EW68f6XfirNTSL7SEI9ygTM0istLZw TdhuvuJzgCJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZeWeZAAKCRDBN2bmhouD 13BKEACHkxYLvnrmNqz2S2EAVq1squYd3iDN3nmrgGmHzpunYRmnlsYHaCQP1Ne+LT3Rzk/0DT5 2kPItHRavwLGtfzXlkwLcdWIJ4O1tCilY9lQb6KQJG1N9EjK6+Vipl/8WV+iF6plMs25+pTlU/b 0nf9uT/r5IL5cC3Rf+Sg3s7hDFKjeEh0aH78KMaIeMolZlM+QX36Ud6sxRYH4lQcrewimowQ37F BIWqy+6khodGvB7Q+qGPFYLcXGHewXmq2xJjqhlop6PNPMNCwi00HZEodZCENGKrOnSTKLKyd7j kr1Y0UwfHgcnT8G4v+VJum0+eWAnptHxA/FwqhO4AQZTofuq66Y4gDPQTF+OqXheDd2ZFwDJ7JU 78vL843x5VMZVe7AEfJSkfOKhHTOXFr6HyP1klsJ5lY29G454mNYhNyMDN/erwKwx3w7/On3XMQ 5c1r0t7sXFMBBdRJpi+0/JjnEttDlF7acH7BflLiltf6atwGJWjBHKQf55RFYLRofb4Pq2WB24U Wymjysgg61HAlduM+RW7/OFURHUF0JWU81CR/GKmWfT21lmhjUsYGtbkS/qVftIpVhVpBW+xuCy FrdNSxjgUhfOPA9/yU645iXlG+RRMoc4CYG/aWlJyTaAo7Wu0meTzCE7rM+06ZSRWJY/FevD3M/ XJeQstxrm5vdEtA== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792590472614765997 X-GMAIL-MSGID: 1792590472614765997 Don't pollute dmesg on deferred probe and simplify the code with dev_err_probe(). Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson --- drivers/video/backlight/lm3630a_bl.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c index a3412c936ca2..93fd6dbccc28 100644 --- a/drivers/video/backlight/lm3630a_bl.c +++ b/drivers/video/backlight/lm3630a_bl.c @@ -563,10 +563,9 @@ static int lm3630a_probe(struct i2c_client *client) /* pwm */ if (pdata->pwm_ctrl != LM3630A_PWM_DISABLE) { pchip->pwmd = devm_pwm_get(pchip->dev, "lm3630a-pwm"); - if (IS_ERR(pchip->pwmd)) { - dev_err(&client->dev, "fail : get pwm device\n"); - return PTR_ERR(pchip->pwmd); - } + if (IS_ERR(pchip->pwmd)) + return dev_err_probe(&client->dev, PTR_ERR(pchip->pwmd), + "fail : get pwm device\n"); pwm_init_state(pchip->pwmd, &pchip->pwmd_state); } From patchwork Mon Mar 4 10:11:43 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 209476 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:10a:f01:a869 with SMTP id ju23csp1325884dyc; Mon, 4 Mar 2024 02:13:44 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUHJNQhzZGp5LrYnT09Y4eGHOERv7qaRdAk6x9fWnBGc5KR/otSFhom/YV4n1zdN4R2TvGZD+ofAp2k7MxO9V7CHin8xA== X-Google-Smtp-Source: AGHT+IFqxPtayZOFzNuVXwHEmroJ71lfQHFkhGkP88g8dUUHgXTgRbLFefXxkl3RI8WG3fLcGC5e X-Received: by 2002:a05:6402:1e86:b0:565:3aa7:565f with SMTP id f6-20020a0564021e8600b005653aa7565fmr5355798edf.8.1709547223748; Mon, 04 Mar 2024 02:13:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709547223; cv=pass; d=google.com; s=arc-20160816; b=resxtM6cTGB3CZLwGl24TZdB69umHNxiBNcKWh/SJf72nVE0kOtxhjYjuY/4WZrbBq G4aGNktrOJAKKQ6DvvvcEBUIaAPtIYy+7gH5wbFcvUPkqFyC+8C249XPZsYfXfgZpOVE 9IYY8ZB2NX/7Y7xJpIWZIxlUmPQ+uFTrbKD2XmOU7ax7r4q4HwWTWLxKf3cItEjC+87q XILyjJS3QttCZrbATvA023+HowaKr0oWdDyg7bOcTKO/FJlDobZ1/sUB/1wyWu8bN+TV uQ3Si/yCZ4aFOiw7IM+lM9L6woteF06shJp7d1crZIJdVYoNODqUWvL839ashxMuaB6q JVoA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=LwjyvFJUk04Z9SLWkJyPD6nPLgMovuAGzXog2OSB5eE=; fh=mIylPapMGoARrZJy5aCeITHtwzo2fG8WS6Nqz+jJy6g=; b=Fb41KnpBSR8vK9D83PUWFMet6+kMpQpf4m3KdkmHLXJC4EolM4BMnV9g4DSf0aCpS8 EkBm6OZuJaexNhTQ7Wh2pk0/eG1zhVmlkUcy6emjTF3lcs9N+5mADfNDqRWF0u5yb+RS jRIsP9gQEzhjEdf/EWsS/Vas/Qb58gC8dqgKi4vDzjzEADWZ4NZIBdiTDY3jnR6X6VyL NwnCZx2V+Z07juQyIGfv94BoOCt1mbyYp0uHroOQmMLrrm6VE1IAbUZi+Zuqzc42u7MQ PQZkX3PyJsg/wm2Eg+zgYKcpu9RTlWE0CpjecemDJddSxVsU0umyRtk0+PbhFfVzxQ6H V5Rg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kHQQu6xX; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-90387-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90387-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id dy21-20020a05640231f500b005660aa17d6asi3766137edb.492.2024.03.04.02.13.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 02:13:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90387-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kHQQu6xX; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-90387-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90387-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 530021F22023 for ; Mon, 4 Mar 2024 10:13:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 36AF438DE6; Mon, 4 Mar 2024 10:12:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kHQQu6xX" Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9BB936AFF for ; Mon, 4 Mar 2024 10:12:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709547124; cv=none; b=ICny50AHuNEIlA3qKSKX2cqtx/qca6vQgHRizSVawRu9X+O30FRSWjsUj38Q50DyuXC1OLloEFKKG5i6HtCh8dqAleaFHl1fzHNB5F/aEzcBUdRMKN5AlsSolB7BUSKi24NI/JpcQq7AXvy+gXIb6EVnu1qbwzbcr6JgKR9aGB8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709547124; c=relaxed/simple; bh=pd2WBlK2PnnolkSqpfShUm10rFxXfMK9JJcdv/+/o+8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pMvahHEzwKvOfGJ3s1lDNupdvQZ3aKkVnsb0xxiSTV8dS3pzJiXSJdkuYSFE3jStQ9DrGIDwlrtn/pgwtNxeTaVd7wTOlUXLRM147YQLfjBBCsJQXd8mrnCGR7Dhdw9+j7rOEMIELwVrtr1ELm90tcQincEGkskyryz1DToKOw8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=kHQQu6xX; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-a26ed1e05c7so741176066b.2 for ; Mon, 04 Mar 2024 02:12:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709547121; x=1710151921; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LwjyvFJUk04Z9SLWkJyPD6nPLgMovuAGzXog2OSB5eE=; b=kHQQu6xXN+Nc0WKREsnVp1V76abhhxtyB+2zPwvEpxtjGB0h9kT4bs5U93cF2NqSXD KSWXj2QonFcmtaVOUtLz4YsjyDsD5CWi4/gndEXSg0ofD40dGxitrhU2fEZVfjT39h/v IccSqrl9cBorY4edq66KJIdQyffk8UMGmfDeKZj1A8hvnfYfkIH1hAD84igZldS4fme/ krGClU7pnE4ou7D72j4fdhTnJrnSAYmunC8ErXAfgSd+pKxrHzBXYBKJDv6tX+q1NM38 lSRi2Cf7SaUEyLyZP1AISIElsv8CpSfow4o+UJIiHL+4i3TCDrq67nI/o7NFT4qmQj3/ Wlbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709547121; x=1710151921; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LwjyvFJUk04Z9SLWkJyPD6nPLgMovuAGzXog2OSB5eE=; b=McemjgZSlQt/EoFLAsUz58Yk8xokMBAqcsQ2yUjxuL6jRDZPlzIfbBjTK0qI6vLxIH G/4+2kkXiU79Zy1ZUDitLJEpCOhhtmmEWqZn6DSLW0Hb4Ih36OdTGarPifO937QqIRor y4dKAV0VimZJjsWeaSHAVuIWfwcsGtNE0poJQRKO0kJMdM3OvNsBzl8Z7p5KsxDElerC 5qXod1FfzXKQNF+D8apzvslzb8bFS8I5DBCD3GOy62IxFjArtebhJyD8Z4S5ieiEOkfx 5huk4Kbjot6HI6uapqcR453W9Le0KzDBZ0lg52ylVkaXxBjGXgmk7nwJfvW3gw3au28H gvlA== X-Forwarded-Encrypted: i=1; AJvYcCUVIqlwCxoxIjuKSLZuuicQrlErs7r7PNkVFYMsbLUhAnijOL9tb+xstNQVVXn5mOvmtluv0YmK8mUVpg1WAzUfchXFt8zd7zq8sCHB X-Gm-Message-State: AOJu0YwSbwoG4gz4Ifa3e5hTCMN8f4I0nxUTNxZTBKxA0GlH3W2UZlPd LeB+setgys4Ncn4Oa/pvzq9iGP5+rj8Xpmx0+QNb4QyIerQ9DJOXDCX1i68W2M4= X-Received: by 2002:a17:906:d20a:b0:a3f:c006:f141 with SMTP id w10-20020a170906d20a00b00a3fc006f141mr5347674ejz.62.1709547121499; Mon, 04 Mar 2024 02:12:01 -0800 (PST) Received: from [127.0.1.1] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id ef11-20020a17090697cb00b00a44bc99cd89sm2938481ejb.42.2024.03.04.02.12.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 02:12:01 -0800 (PST) From: Krzysztof Kozlowski Date: Mon, 04 Mar 2024 11:11:43 +0100 Subject: [PATCH 6/7] backlight: lm3630a_bl: Simplify probe return on gpio request error Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240304-backlight-probe-v1-6-e5f57d0df6e6@linaro.org> References: <20240304-backlight-probe-v1-0-e5f57d0df6e6@linaro.org> In-Reply-To: <20240304-backlight-probe-v1-0-e5f57d0df6e6@linaro.org> To: Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=902; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=pd2WBlK2PnnolkSqpfShUm10rFxXfMK9JJcdv/+/o+8=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBl5Z5lXJ/VFjg/mpbVkfSabBfIk9lZsDYAkyfe/ D+nlFwxH7iJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZeWeZQAKCRDBN2bmhouD 11j9D/40TMnoJeYnOPMbLd5xVtL3dXUyBwE62gtbjuZcDCQVRF6H312FNVRBLVT7r2af2vQUh1f 17GF0ogLebzfS7zgk8oEakUcVhkyq75oe02QLqCD6dNLu3sqeDVVW3e9Fqj0sb0UeaSHmaoWJ7+ bP36HaSjz6gKYGqCuRQDiXSAed5uhxEW+B2cx7tyuE1j9IbyXs3WPZiyimbEYPiGXMrcg2byaOM Z+lNdioUPzs/fdMNLFlGD2DLdBHf4MlasTvQK4MCkk1CtF4KqnyqDMkKDJtOxTrzfz4FIJ8KLVR oLFviGSGKBbwMWywSjHw5aYh0guqG7i+RpAsh0fCQzShk8jZEiJAFJuvvyIGiz/XwGD2zyIyduy BIvF9Oaco7OeswzIqZ6Wb9+xBUahYeESyrNthUD+xFaynrVx9KxONqkL9l94IyFNqUWMp2+SREO aMG5K4viwKrtcjepKKRHZMdds0uNiE4HC0qqocxELok9nQ9lpjifoeVULxwx5HTE3hw0ub41Q4Y um9RLtNuSP4cn9IWYcrVJ78ZEP9LAcef2DwfCpR/lEdtqDV2dDiFni1Yt/b6VgacmVbyvBaUld7 Po0f1M2DCrEH7UPbHXYgXCfhZ+B1Bp/XKFsDmz1UgsRVFJ54UfUCo8RJnzySYQOPTSmGT5HOudB o90wSGxwVpTTALQ== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792590189577132986 X-GMAIL-MSGID: 1792590189577132986 Code can be simpler: return directly when devm_gpiod_get_optional() failed. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson --- drivers/video/backlight/lm3630a_bl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c index 93fd6dbccc28..ac0a60e39e39 100644 --- a/drivers/video/backlight/lm3630a_bl.c +++ b/drivers/video/backlight/lm3630a_bl.c @@ -543,10 +543,8 @@ static int lm3630a_probe(struct i2c_client *client) pchip->enable_gpio = devm_gpiod_get_optional(&client->dev, "enable", GPIOD_OUT_HIGH); - if (IS_ERR(pchip->enable_gpio)) { - rval = PTR_ERR(pchip->enable_gpio); - return rval; - } + if (IS_ERR(pchip->enable_gpio)) + return PTR_ERR(pchip->enable_gpio); /* chip initialize */ rval = lm3630a_chip_init(pchip); From patchwork Mon Mar 4 10:11:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 209477 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:10a:f01:a869 with SMTP id ju23csp1325943dyc; Mon, 4 Mar 2024 02:13:53 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVmcgaecGyOMcb1FfKQcYqtnPQ2N2NHx1zR33RyTxmqn7QK9QnFXSmhZIGhDGCsDNHihkC9wsM39H/BlVGqRFd3KzzQEw== X-Google-Smtp-Source: AGHT+IHij2n6cg9ywipoAvBeDMwOLWeNCUJvesnKID/BzgPFTuc5+LMJODCafhcaA5KGyix/x+eG X-Received: by 2002:a05:6402:323:b0:566:a822:990e with SMTP id q3-20020a056402032300b00566a822990emr5696682edw.38.1709547233183; Mon, 04 Mar 2024 02:13:53 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709547233; cv=pass; d=google.com; s=arc-20160816; b=oOuY68L9uG9ro320qEu3Cjc/eqZ8Un42kjiHbi25fdoglX/xzwlNmy+gJxoUybYvdd AxfO+rxmU/AInycT2xl42LO8kO3yWnOr70lyk2TisctekHUQEmi/V0Gh5q6SD6StV60B TMK4UzInexj7vtyABidjfbvPcsrRDxq2V9/yrtmdJ3ZI+Yg49512ebzwlFpMZ4vFhH4b gllA8wS1XVQx0Tv0Ntd1NtO4RP4nI1TEiSpAqD6JCiSLvW/c8aJMs764MKRz39jj4V1U NnwZl7myT2C5NGwzRMAScYIWPU/EEkRQSLaT67vkCGm8CC4waC2Any5QKKZ2nIORoSQJ BPIw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=qkscxkyuLKmNGJ13PCRB5gPU2riBC6Uyvc9FkqhiTrI=; fh=G4kuFvxClRH4eCFR7/UZBysTE7sfSdZ2VrekZF1GJ4s=; b=ucQbnG0MhfZJutRc3Hc5yLlex2ZbwO3y3GnyGjOLMFJHjy2wjCytt6inqGSyp4ugSb t5M4ik1KuYQaEtBhrCOsdZ7YnHMQlZQfhj9t4o6d9gHRn26FokPXsQiYMOH8volYKEri dSq0L7UeXsdbl7QjmtAbfdTzr7p8QuLUbUphN2yCzFmv4hLXgbzXvHAsZy6u3AM5L2V6 KMrOPRsYyXOjx3G35IHV0lNOcyz69LevU8DhVys0S7iAmaujR+gMVWgBnU0aJ07ytx8J MRoxNbYw5oWGdB5OKBGfeuDGDz+zy43Jj9w4vzEjz20/DN0Wy0Fu3eEO/s8X/dAf2q8p A0Dg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZF++zhKW; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-90388-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90388-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id c69-20020a509fcb000000b00567346b2e3esi1100011edf.334.2024.03.04.02.13.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 02:13:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-90388-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZF++zhKW; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-90388-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-90388-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C8FF51F22E2C for ; Mon, 4 Mar 2024 10:13:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CF05638FA8; Mon, 4 Mar 2024 10:12:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZF++zhKW" Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EE2736AEB for ; Mon, 4 Mar 2024 10:12:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709547126; cv=none; b=KP4bnhy08gJFOFF/1UwaIRz91ItTEffwsVsiazp938EQ9D5b5L6daWDdWLxh/ll0d9dWLunSlDq0+2AJSYm9m4ME1mAsjPaYBByEEP0eoEKYaCewzZbh97rwAscjbG8aOtktcaXkF77CtoPn/mciUfzAXh8sn5mz6FQqAtEnYvM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709547126; c=relaxed/simple; bh=IQiBIX1ptsqUCh17mmsk9JR1+iQzH5+7RhWBq7Lbzeo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hLuwvOThUcImCevVMEOrR4hvzN4zR6DCV8xWAzPnEKrjuJZKal6dAwxnIr/h9f32w/nhJJaS827vTXalI0/KqA1DeEwZrHVV/MzQKMTp5KHeKE+hIOTj8PzD1L9vTzQotmvv0Tpi1YItV6jbxRJUDkv1ZS3OP8xyUE7Gum0nrNc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ZF++zhKW; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-56657bcd555so5419435a12.3 for ; Mon, 04 Mar 2024 02:12:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709547123; x=1710151923; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=qkscxkyuLKmNGJ13PCRB5gPU2riBC6Uyvc9FkqhiTrI=; b=ZF++zhKWxiOJzapXn9HafgVxReE2bOHURe9BcEtLuTJMDVzCO+XDbAy/Mkk7r+ZUIE dKoXXDOmB5l9TXaH7NFc6UfZI1JUDs5J296h44Kdq0hOQNvKsI4BFZrHGdhgO03reRAM tmPwk+VMx7VlRTVqNhC6hT/SxkV/1jeb1y9PTe06vqj68XdMdfUPwQWwdLGgkbxKV+G9 8FFLwdlwAB04XD0veNVAV4ImwinpIVZAsuvn5n/XMz4GQT0xtmBxlNOvsaVLal0g6diR z7gImo05oSVUvCOcfdOF5jN3EIbWuMovZlSJ5WAIzPGNUNxHbFpf+vg1ZVS/FuiS8Udo LOXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709547123; x=1710151923; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qkscxkyuLKmNGJ13PCRB5gPU2riBC6Uyvc9FkqhiTrI=; b=lw3ygBKhlTufG7HduiYFasEsP9diQk4qqil/x4l02a4o7ui5GcHNsDTJ1IM36kYDwA zewJBvbgDuft8YilS6c8RF//RDl2EU86ytRp6otrhYZ/OyfEJQjw2WdsZaPWfsEonC4X Graj3L+4xRq4WMIihkP8thhv0W4wrTQsaA5wZgh7vzMUvrwXtbT0LpeNneaH1L26vsQz jPrNpDMM24fI397SUhrn/yNNqPwPO1hHkxNcKKL/hKMkHHaoFk3tXTZmZPLwzo1dzvwv rDKjc+oz/t44ZBOryqSFTueZ+kArGnNPUi8fRKGbyOxHZHuD9NteZYVjY4d07HCHUyYm mnrw== X-Forwarded-Encrypted: i=1; AJvYcCUpPLE8x2HpQ7NRIoepbqdIjJUcxxVCgxj8bxcqOOwu7JopH6U33Bz2x5dBdcS0CM7cyo/x3uohmWxqRrWlFy3NhdgOtY1kfAXwHQJA X-Gm-Message-State: AOJu0YwftgQJJwEpaSN2LOTLDDV8pSpgBnPAeO81GfttQeiCqyCjyaEo mon+x/WZn8mWDuEPgA/0GIxUbJayvSwT0NRAvMhd+/DyovDzt4Svmy83YpArsUE= X-Received: by 2002:a17:906:1c90:b0:a44:86d4:70a1 with SMTP id g16-20020a1709061c9000b00a4486d470a1mr5679948ejh.59.1709547123118; Mon, 04 Mar 2024 02:12:03 -0800 (PST) Received: from [127.0.1.1] ([178.197.222.97]) by smtp.gmail.com with ESMTPSA id ef11-20020a17090697cb00b00a44bc99cd89sm2938481ejb.42.2024.03.04.02.12.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 02:12:02 -0800 (PST) From: Krzysztof Kozlowski Date: Mon, 04 Mar 2024 11:11:44 +0100 Subject: [PATCH 7/7] backlight: pandora_bl: Drop unneeded ENOMEM error message Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240304-backlight-probe-v1-7-e5f57d0df6e6@linaro.org> References: <20240304-backlight-probe-v1-0-e5f57d0df6e6@linaro.org> In-Reply-To: <20240304-backlight-probe-v1-0-e5f57d0df6e6@linaro.org> To: Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=861; i=krzysztof.kozlowski@linaro.org; h=from:subject:message-id; bh=IQiBIX1ptsqUCh17mmsk9JR1+iQzH5+7RhWBq7Lbzeo=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBl5Z5mnfBQ5T6LEu6wSHreyeIddxcFaUtThG5hR a7P7xtBFQOJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCZeWeZgAKCRDBN2bmhouD 1+bBEACC1mknggxkpb8buuVG+0wI2sOUPaDlTNanVp8VneZ1l/BNkKBQ16feuUhfuQwjRbtWsUf ZuSeoXHhpFP4r86SdVkbEVDk2lHP0KnDRoyq62CN2cvKV/jH1gOV+dRRjQwaQ/+1O2GMx0mPbDu iaqhbqb5oqrns4Ycj+pUyBUD0pjID8r0TnOsriFXB2OKlIj30CaBhcaq8P6ChS8t7bP6qgDjSqs jUOVa9GFE0IiX7CJhIBtOO7Uk6GaQ12WeQxZuikLzwrGgiv9PCvohPt6a9xgmqEyDchFF/V+IwX SXAHRzQdkez8EzzNYFlwKbaRtTOzF9uPqZvzLJowH+HXPrBowr7kCJ0XlBosRMxlNkeGPjGC8zF klwHa4J6M4rQnL27yx8qzkeaTjuHw2OCKdyrBEFikRSKRNWw0tVjgKWdmMJ5uP7LXnLGxiK330C UbwI0ZPdFqScbrPDf83rLA0+DP+abdH2Wr9o0vbFTuEW8NxPwqys23rwj29dj7O3Hdw5okM306X kMaeqS5zhQ0Oq8XJrf6wUIGnGJkLS9anoWh5FJTS+xQWg0V4kfM1v3bc7klOT2G67xTXllFT3gG TAkA+gLn74eZZxkaYbAwdLovsbQnn1Ey7Zoui+W7wRwR8NgCwbgKmETXcsNMbdkRGvXyAstq/Sh X7Mj1VxLbKE+uxg== X-Developer-Key: i=krzysztof.kozlowski@linaro.org; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792590199175151483 X-GMAIL-MSGID: 1792590199175151483 Core code already prints detailed information about failure of memory allocation. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Daniel Thompson --- drivers/video/backlight/pandora_bl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/backlight/pandora_bl.c b/drivers/video/backlight/pandora_bl.c index f946470ce9f6..51faa889e01f 100644 --- a/drivers/video/backlight/pandora_bl.c +++ b/drivers/video/backlight/pandora_bl.c @@ -114,10 +114,8 @@ static int pandora_backlight_probe(struct platform_device *pdev) u8 r; priv = devm_kmalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); - if (!priv) { - dev_err(&pdev->dev, "failed to allocate driver private data\n"); + if (!priv) return -ENOMEM; - } memset(&props, 0, sizeof(props)); props.max_brightness = MAX_USER_VALUE;