From patchwork Sun Mar 3 10:04:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karel Balej X-Patchwork-Id: 209293 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:10a:f01:a869 with SMTP id ju23csp851896dyc; Sun, 3 Mar 2024 02:16:43 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVqn+v7cVhoYAnY3xnrOsboq3kXMJjL1KBnlWJBoB/SkVr5lWBR1oZhOuqagG4ee2ucArisliSEY6lrbCabKBKhkn8vDA== X-Google-Smtp-Source: AGHT+IHFJTDFY/k6VYodN/3PDUgWFRW6wGhNXxGaDGw/YTG7Fqjj/jHAkKAtN2g6KYeJdBxApAPw X-Received: by 2002:a17:903:246:b0:1dc:6e6f:5a33 with SMTP id j6-20020a170903024600b001dc6e6f5a33mr7597785plh.43.1709461003367; Sun, 03 Mar 2024 02:16:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709461003; cv=pass; d=google.com; s=arc-20160816; b=h/CcihGZEVSMhgxx51joZSiiQDVlS6wslmE8ycInn7SI3bthc1vdhSmvwuItDYJvmO cYSEiMn+RDpjcKWd94DLI5wWlWRuWoT5qJ/CLj993A7K1ZAXIFhNKkcC+oEhwbCnhPeJ fLyRqcUqnysxArei7OdDXDwSGLyhZuRNxRmcbN++pIfrxiC0VOU4yz1koBe0baLcqaU3 lledrWjPUiA3X1BUDkuGR5PYyBBaYQPSZ/iLTL5Bq3lqSlyXlRY5W24P4+nXtprYm4uu s1ijwpQIwyOs3txakRktnrdjpjJNO//iQBQNbSbjDzq6dEBVfXfGKmqlrSNSiFY1WaGr iGBg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=LqM2m/EgTSqkL6d+GqfITU+aAhAGH+pq/fWiHyN8krk=; fh=XPznAPHjywHhKJCA3zzSjmtYugAvBjl32NkRZBKKmSM=; b=sxG5fv8rt0kEMXCKdUmO2DD3rbezX9Qi1wUfFpWPV82PfB70qqPme4YG2BmsKzaoRp YQEB7vN6qyg32W9os58aAqNVu0UdvsnZTJT1/Oi0rg5S7jXiMo99k+OlzIKTHh3NWfzp YYhrWRZA03/veT3icIf26YUkqXnyYjQVWyXtypf/1n7hNeLUQL8A9oapdIN00nOwTkoh QtQuiPJawB02olPjOmSOHC8eZV3MOy+o/KoKXbwCigufA/CfuxhKjJUGhF2/uRIv+5LM xsv2RBPCmHFzlvZYI232fDDmU2cDQBHl/JIyorJFfzHfaZxbbHx4wfsCvD6iCPbFThKc QM4A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gimli.ms.mff.cuni.cz header.s=gen1 header.b="OtimUvm/"; arc=pass (i=1 spf=pass spfdomain=gimli.ms.mff.cuni.cz dkim=pass dkdomain=gimli.ms.mff.cuni.cz dmarc=pass fromdomain=gimli.ms.mff.cuni.cz); spf=pass (google.com: domain of linux-kernel+bounces-89699-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89699-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gimli.ms.mff.cuni.cz Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id si17-20020a17090b529100b0029a9952d7f8si7023727pjb.83.2024.03.03.02.16.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Mar 2024 02:16:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-89699-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@gimli.ms.mff.cuni.cz header.s=gen1 header.b="OtimUvm/"; arc=pass (i=1 spf=pass spfdomain=gimli.ms.mff.cuni.cz dkim=pass dkdomain=gimli.ms.mff.cuni.cz dmarc=pass fromdomain=gimli.ms.mff.cuni.cz); spf=pass (google.com: domain of linux-kernel+bounces-89699-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89699-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gimli.ms.mff.cuni.cz Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 336E728229A for ; Sun, 3 Mar 2024 10:16:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CBE3011709; Sun, 3 Mar 2024 10:15:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=gimli.ms.mff.cuni.cz header.i=@gimli.ms.mff.cuni.cz header.b="OtimUvm/" Received: from nikam.ms.mff.cuni.cz (nikam.ms.mff.cuni.cz [195.113.20.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBA2CBA30; Sun, 3 Mar 2024 10:15:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.113.20.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709460938; cv=none; b=hlx0S7RswA2EocWNWK/b2PqoWpq2TEiIV4YIGfZGnmC1mkPxDMV6OWPaI5EuX5eApSrQFlARGtJjyg6ASUfFqG1DQaspMEXviIl/wf3JpxnFw4pBThrg7CAT8FKSuEplYK4C1xUneZOGyQidKQgOMVOMhFJja+rSnm3L6fhgd5A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709460938; c=relaxed/simple; bh=R6YYY+vpVbo5nxzzB1tqlhfbOWzLEQy5/+Ton+dIJjs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IAqBk5qHgB3ROyF7SH3O4oYdDSIFtTA3SthxtrcvXLSclW16YRzyU0LUaMqNTDjKRd1gVLFSbAEYQ/LHxx9y+Gx3ykSP15GTDrlSMuuDpsCgBCik5sy5PzinaWZH3Qc/ICoqR1f83wYGQuji3rE3xTA8klV83Jh4YNwNAHTNoHs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gimli.ms.mff.cuni.cz; spf=pass smtp.mailfrom=gimli.ms.mff.cuni.cz; dkim=pass (1024-bit key) header.d=gimli.ms.mff.cuni.cz header.i=@gimli.ms.mff.cuni.cz header.b=OtimUvm/; arc=none smtp.client-ip=195.113.20.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gimli.ms.mff.cuni.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gimli.ms.mff.cuni.cz Received: from gimli.ms.mff.cuni.cz (gimli.ms.mff.cuni.cz [195.113.20.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by nikam.ms.mff.cuni.cz (Postfix) with ESMTPS id C8871284290; Sun, 3 Mar 2024 11:15:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gimli.ms.mff.cuni.cz; s=gen1; t=1709460926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LqM2m/EgTSqkL6d+GqfITU+aAhAGH+pq/fWiHyN8krk=; b=OtimUvm//Dfjq0LJBwnqOgR6G72hoD4ofA3tWDhNWe3YjAyjSF6CUXtUc20TjvtvOiz2Kc ek9fz0LANXioGElR5tsAIeLB+hZzIPKp8QaA6OssrbeVy4CBXDHVG32sFGEcMEnJV32Dzy 4ZNnngtBhnrI+YrWAS1P8IRFGFapmAE= Received: from localhost (internet5.mraknet.com [185.200.108.250]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: karelb) by gimli.ms.mff.cuni.cz (Postfix) with ESMTPSA id A7154456F3E; Sun, 3 Mar 2024 11:15:26 +0100 (CET) From: Karel Balej To: Karel Balej , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Liam Girdwood , Mark Brown , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Cc: =?utf-8?q?Duje_Mihanovi=C4=87?= , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org Subject: [RFC PATCH v3 1/5] dt-bindings: mfd: add entry for Marvell 88PM886 PMIC Date: Sun, 3 Mar 2024 11:04:22 +0100 Message-ID: <20240303101506.4187-2-karelb@gimli.ms.mff.cuni.cz> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240303101506.4187-1-karelb@gimli.ms.mff.cuni.cz> References: <20240303101506.4187-1-karelb@gimli.ms.mff.cuni.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792499781424020819 X-GMAIL-MSGID: 1792499781424020819 From: Karel Balej Marvell 88PM886 is a PMIC with several subdevices such as onkey, regulators or battery and charger. It comes in at least two revisions, A0 and A1 -- only A1 is described here at the moment. Signed-off-by: Karel Balej Reviewed-by: Krzysztof Kozlowski --- Notes: RFC v3: - Add wakeup-source property. - Address Rob's feedback: - Move regulators into the MFD file. - Remove interrupt-controller and #interrupt-cells properties. RFC v2: - Address Rob's feedback: - Drop mention of 88PM880. - Make sure the file passes bindings check (add the necessary header and fix `interrupt-cells`). - Other small changes. - Add regulators. Changes with respect to the regulator RFC series: - Address Krzysztof's comments: - Drop unused compatible. - Fix sub-node pattern. .../bindings/mfd/marvell,88pm886-a1.yaml | 76 +++++++++++++++++++ 1 file changed, 76 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/marvell,88pm886-a1.yaml diff --git a/Documentation/devicetree/bindings/mfd/marvell,88pm886-a1.yaml b/Documentation/devicetree/bindings/mfd/marvell,88pm886-a1.yaml new file mode 100644 index 000000000000..61ffbf669e90 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/marvell,88pm886-a1.yaml @@ -0,0 +1,76 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/marvell,88pm886-a1.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Marvell 88PM886 PMIC core + +maintainers: + - Karel Balej + +description: + Marvell 88PM886 is a PMIC providing several functions such as onkey, + regulators or battery and charger. + +properties: + compatible: + const: marvell,88pm886-a1 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + wakeup-source: true + + regulators: + type: object + additionalProperties: false + patternProperties: + "^(ldo(1[0-6]|[1-9])|buck[1-5])$": + type: object + $ref: /schemas/regulator/regulator.yaml# + description: LDO or buck regulator. + unevaluatedProperties: false + +required: + - compatible + - reg + - interrupts + +additionalProperties: false + +examples: + - | + #include + i2c { + #address-cells = <1>; + #size-cells = <0>; + pmic@30 { + compatible = "marvell,88pm886-a1"; + reg = <0x30>; + interrupts = <0 4 IRQ_TYPE_LEVEL_HIGH>; + interrupt-parent = <&gic>; + wakeup-source; + + regulators { + ldo2: ldo2 { + regulator-min-microvolt = <3100000>; + regulator-max-microvolt = <3300000>; + }; + + ldo15: ldo15 { + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + }; + + buck2: buck2 { + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + }; + }; + }; + }; +... From patchwork Sun Mar 3 10:04:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karel Balej X-Patchwork-Id: 209292 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:10a:f01:a869 with SMTP id ju23csp851833dyc; Sun, 3 Mar 2024 02:16:28 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXLqxgdvUbVLm2xA3y9ikPBPOokJaIkFTGu+GeOBhq6EP7KI8rqz25ysR/RBUyk1VwS8ymo53TXddBM+m9S2YRMolJlXA== X-Google-Smtp-Source: AGHT+IHOpihxoAQsHcuP+Zk59brDUT2hXut98NigkYIZSmqAHOme6rZoDBq83aX573bwdmjHh2FA X-Received: by 2002:a17:906:3505:b0:a45:200e:171a with SMTP id r5-20020a170906350500b00a45200e171amr704249eja.33.1709460988030; Sun, 03 Mar 2024 02:16:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709460988; cv=pass; d=google.com; s=arc-20160816; b=NR8/NeZUa4W8sqgDKbT5/wWCvdTY52OGUG8BVDxIba8Jty+FB1U0rUaUAmS+kaydA0 5jE/8j+/8uC9y8kZihcTVwSxAV5Tnhj6lQHB4OOLhO/SgGrM7r8LgQEk57J2Mr1OTA/a 0gSa0MTscZ6LHSklHPyRQ8l7ZvrgxS4cCM5GS4UHvG75o0WJh/JJpPxl3DzHEW41UGKa tjXy3UxTBw98Lw/sOFLEDv3J1pqLZb/C3IcFGRR91OaJWifDAj+u7x1qWGcPVFI7qsLb MmmZuYw2vgV8fH7TmIrv7AWS7b5+VicR0Uw/TIYcSsm9UhiLVAxvEm+jGgileIcjgjin Jc4Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=9U2dAMCkXRiskMUmdbbGYCvHSLFwoJhVBt80xaRbL80=; fh=XPznAPHjywHhKJCA3zzSjmtYugAvBjl32NkRZBKKmSM=; b=SEfoW2evwB7W52qEz97Lx8ATMcUuhaDKRJiVLvawX3uxYxuQXrmu8RFOT/g6ZRrBPC utQihjsdI188hbFSI0lMYTA2KTj72rLtgyZI+bGmOjSP9se02E7X1C9hkceuDY/MQSQ1 v9QLxjA2GLH4zO8VcdF5W4NDT1kOwSRvYqV2iY/SlkLAMCsPyTw+Ckqv6zHLHvKJLAnh 3lXgRHlu5VMMUxr5s45hf8XwySh5o5vX2NMQ7fCebI2Pk/BTOr9U++yZRSZUBjRZqpNf X4XgaoWsomwMg2wFpYrwP4IxaNeSpZnc33hyjx3pcSbVQP+MHQPOVNt2P3xNbzDRWCrt eYlw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gimli.ms.mff.cuni.cz header.s=gen1 header.b=po16+Jx8; arc=pass (i=1 spf=pass spfdomain=gimli.ms.mff.cuni.cz dkim=pass dkdomain=gimli.ms.mff.cuni.cz dmarc=pass fromdomain=gimli.ms.mff.cuni.cz); spf=pass (google.com: domain of linux-kernel+bounces-89696-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89696-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gimli.ms.mff.cuni.cz Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id va25-20020a17090711d900b00a443b6d9972si3068356ejb.685.2024.03.03.02.16.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Mar 2024 02:16:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-89696-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@gimli.ms.mff.cuni.cz header.s=gen1 header.b=po16+Jx8; arc=pass (i=1 spf=pass spfdomain=gimli.ms.mff.cuni.cz dkim=pass dkdomain=gimli.ms.mff.cuni.cz dmarc=pass fromdomain=gimli.ms.mff.cuni.cz); spf=pass (google.com: domain of linux-kernel+bounces-89696-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89696-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gimli.ms.mff.cuni.cz Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 7DD2B1F2168E for ; Sun, 3 Mar 2024 10:16:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7171D10A17; Sun, 3 Mar 2024 10:15:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=gimli.ms.mff.cuni.cz header.i=@gimli.ms.mff.cuni.cz header.b="po16+Jx8" Received: from nikam.ms.mff.cuni.cz (nikam.ms.mff.cuni.cz [195.113.20.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C588EB657; Sun, 3 Mar 2024 10:15:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.113.20.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709460935; cv=none; b=nHY0/59oK/wKUeRLUWIhY+jrB1Kkst7ejQ3pt0JlQ7mP5Kp8boX2tyyl8QG18LDIXTQF6FKxpfHt99tVLUAyYvb5Jkfcqko1bcEuiWirLDpdSMfjSCQdQi+UqGde4UUfhvJ6cVOOXI0sjQ8q9vaTlLv04+FKuY+grYs7sC4JAd0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709460935; c=relaxed/simple; bh=Ch2E7gNOECXJ9bCkUmp3zCVDkVJp8aC6si+oXHJMb80=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sNa+fHPSeK8Cy/7qY6gY/OFwysbaWJilJcOH2TqbnNj2a8Tdg/4UQl+hN3+bbr1sS5HuFbfic2vYQ0gvdTq9FmVQkO0AkMFZ1CC3Vkrpr7l0FDmkNogTp7RmDVIm6oL2j435z4FLliAbhi8r3l231nbsTdBhFSjoPe0VuiMGcp4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gimli.ms.mff.cuni.cz; spf=pass smtp.mailfrom=gimli.ms.mff.cuni.cz; dkim=pass (1024-bit key) header.d=gimli.ms.mff.cuni.cz header.i=@gimli.ms.mff.cuni.cz header.b=po16+Jx8; arc=none smtp.client-ip=195.113.20.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gimli.ms.mff.cuni.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gimli.ms.mff.cuni.cz Received: from gimli.ms.mff.cuni.cz (gimli.ms.mff.cuni.cz [195.113.20.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by nikam.ms.mff.cuni.cz (Postfix) with ESMTPS id B1215284291; Sun, 3 Mar 2024 11:15:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gimli.ms.mff.cuni.cz; s=gen1; t=1709460929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9U2dAMCkXRiskMUmdbbGYCvHSLFwoJhVBt80xaRbL80=; b=po16+Jx8SGaCfLHrVmnz3BfcYJ9cfm50mFduIYmFXSL34VZ3fnVv81NDSQegZjGSQLEuNk fWRq8MFNJmp+KccNu2K4nSIR9UIhFNEFhVq1dWDIrCHojEmwUsMz4PzKtRI3dOznyMqydE SWgq2OAOsK71lJvtn3h1+9JE12f+MEk= Received: from localhost (internet5.mraknet.com [185.200.108.250]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: karelb) by gimli.ms.mff.cuni.cz (Postfix) with ESMTPSA id 8B79D456F3E; Sun, 3 Mar 2024 11:15:29 +0100 (CET) From: Karel Balej To: Karel Balej , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Liam Girdwood , Mark Brown , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Cc: =?utf-8?q?Duje_Mihanovi=C4=87?= , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org Subject: [RFC PATCH v3 2/5] mfd: add driver for Marvell 88PM886 PMIC Date: Sun, 3 Mar 2024 11:04:23 +0100 Message-ID: <20240303101506.4187-3-karelb@gimli.ms.mff.cuni.cz> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240303101506.4187-1-karelb@gimli.ms.mff.cuni.cz> References: <20240303101506.4187-1-karelb@gimli.ms.mff.cuni.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792499765219761033 X-GMAIL-MSGID: 1792499765219761033 From: Karel Balej Marvell 88PM886 is a PMIC which provides various functions such as onkey, battery, charger and regulators. It is found for instance in the samsung,coreprimevelte smartphone with which this was tested. Only implement basic support to allow for the use of regulators and onkey omitting the currently unused register definitions and I2C subclients which should thus be added with the subdevice drivers which need them. Signed-off-by: Karel Balej --- Notes: RFC v3: - Drop onkey cell .of_compatible. - Rename LDO page offset and regmap to REGULATORS. RFC v2: - Remove some abstraction. - Sort includes alphabetically and add linux/of.h. - Depend on OF, remove of_match_ptr and add MODULE_DEVICE_TABLE. - Use more temporaries and break long lines. - Do not initialize ret in probe. - Use the wakeup-source DT property. - Rename ret to err. - Address Lee's comments: - Drop patched in presets for base regmap and related defines. - Use full sentences in comments. - Remove IRQ comment. - Define regmap_config member values. - Rename data to sys_off_data. - Add _PMIC suffix to Kconfig. - Use dev_err_probe. - Do not store irq_data. - s/WHOAMI/CHIP_ID - Drop LINUX part of include guard name. - Merge in the regulator series modifications in order to have more devices and modify the commit message accordingly. Changes with respect to the original regulator series patches: - ret -> err - Add temporary for dev in pm88x_initialize_subregmaps. - Drop of_compatible for the regulators. - Do not duplicate LDO regmap for bucks. - Rewrite commit message. drivers/mfd/88pm886.c | 210 ++++++++++++++++++++++++++++++++++++ drivers/mfd/Kconfig | 12 +++ drivers/mfd/Makefile | 1 + include/linux/mfd/88pm886.h | 46 ++++++++ 4 files changed, 269 insertions(+) create mode 100644 drivers/mfd/88pm886.c create mode 100644 include/linux/mfd/88pm886.h diff --git a/drivers/mfd/88pm886.c b/drivers/mfd/88pm886.c new file mode 100644 index 000000000000..c17220e1b7e2 --- /dev/null +++ b/drivers/mfd/88pm886.c @@ -0,0 +1,210 @@ +// SPDX-License-Identifier: GPL-2.0-only +#include +#include +#include +#include +#include +#include +#include + +#include + +#define PM886_REG_INT_STATUS1 0x05 + +#define PM886_REG_INT_ENA_1 0x0a +#define PM886_INT_ENA1_ONKEY BIT(0) + +#define PM886_REGMAP_CONF_REG_BITS 8 +#define PM886_REGMAP_CONF_VAL_BITS 8 +#define PM886_REGMAP_CONF_MAX_REG 0xfe + +enum pm886_irq_number { + PM886_IRQ_ONKEY, + + PM886_MAX_IRQ +}; + +static struct regmap_irq pm886_regmap_irqs[] = { + REGMAP_IRQ_REG(PM886_IRQ_ONKEY, 0, PM886_INT_ENA1_ONKEY), +}; + +static struct regmap_irq_chip pm886_regmap_irq_chip = { + .name = "88pm886", + .irqs = pm886_regmap_irqs, + .num_irqs = ARRAY_SIZE(pm886_regmap_irqs), + .num_regs = 4, + .status_base = PM886_REG_INT_STATUS1, + .ack_base = PM886_REG_INT_STATUS1, + .unmask_base = PM886_REG_INT_ENA_1, +}; + +static struct resource pm886_onkey_resources[] = { + DEFINE_RES_IRQ_NAMED(PM886_IRQ_ONKEY, "88pm886-onkey"), +}; + +static struct mfd_cell pm886_devs[] = { + { + .name = "88pm886-onkey", + .num_resources = ARRAY_SIZE(pm886_onkey_resources), + .resources = pm886_onkey_resources, + }, + { + .name = "88pm886-regulator", + .id = PM886_REGULATOR_ID_LDO2, + }, + { + .name = "88pm886-regulator", + .id = PM886_REGULATOR_ID_LDO15, + }, + { + .name = "88pm886-regulator", + .id = PM886_REGULATOR_ID_BUCK2, + }, +}; + +static const struct regmap_config pm886_i2c_regmap = { + .reg_bits = PM886_REGMAP_CONF_REG_BITS, + .val_bits = PM886_REGMAP_CONF_VAL_BITS, + .max_register = PM886_REGMAP_CONF_MAX_REG, +}; + +static int pm886_power_off_handler(struct sys_off_data *sys_off_data) +{ + struct pm886_chip *chip = sys_off_data->cb_data; + struct regmap *regmap = chip->regmaps[PM886_REGMAP_BASE]; + struct device *dev = &chip->client->dev; + int err; + + err = regmap_update_bits(regmap, PM886_REG_MISC_CONFIG1, PM886_SW_PDOWN, + PM886_SW_PDOWN); + if (err) { + dev_err(dev, "Failed to power off the device: %d\n", err); + return NOTIFY_BAD; + } + return NOTIFY_DONE; +} + +static int pm886_initialize_subregmaps(struct pm886_chip *chip) +{ + struct device *dev = &chip->client->dev; + struct i2c_client *page; + struct regmap *regmap; + int err; + + /* regulators page */ + page = devm_i2c_new_dummy_device(dev, chip->client->adapter, + chip->client->addr + PM886_PAGE_OFFSET_REGULATORS); + if (IS_ERR(page)) { + err = PTR_ERR(page); + dev_err(dev, "Failed to initialize regulators client: %d\n", err); + return err; + } + regmap = devm_regmap_init_i2c(page, &pm886_i2c_regmap); + if (IS_ERR(regmap)) { + err = PTR_ERR(regmap); + dev_err(dev, "Failed to initialize regulators regmap: %d\n", err); + return err; + } + chip->regmaps[PM886_REGMAP_REGULATORS] = regmap; + + return 0; +} + +static int pm886_setup_irq(struct pm886_chip *chip, + struct regmap_irq_chip_data **irq_data) +{ + struct regmap *regmap = chip->regmaps[PM886_REGMAP_BASE]; + struct device *dev = &chip->client->dev; + int err; + + /* Set interrupt clearing mode to clear on write. */ + err = regmap_update_bits(regmap, PM886_REG_MISC_CONFIG2, + PM886_INT_INV | PM886_INT_CLEAR | PM886_INT_MASK_MODE, + PM886_INT_WC); + if (err) { + dev_err(dev, "Failed to set interrupt clearing mode: %d\n", err); + return err; + } + + err = devm_regmap_add_irq_chip(dev, regmap, chip->client->irq, + IRQF_ONESHOT, -1, &pm886_regmap_irq_chip, + irq_data); + if (err) { + dev_err(dev, "Failed to request IRQ: %d\n", err); + return err; + } + + return 0; +} + +static int pm886_probe(struct i2c_client *client) +{ + struct regmap_irq_chip_data *irq_data; + struct device *dev = &client->dev; + struct pm886_chip *chip; + struct regmap *regmap; + unsigned int chip_id; + int err; + + chip = devm_kzalloc(dev, sizeof(*chip), GFP_KERNEL); + if (!chip) + return -ENOMEM; + + chip->client = client; + chip->whoami = (uintptr_t)device_get_match_data(dev); + i2c_set_clientdata(client, chip); + + regmap = devm_regmap_init_i2c(client, &pm886_i2c_regmap); + if (IS_ERR(regmap)) { + err = PTR_ERR(regmap); + return dev_err_probe(dev, err, "Failed to initialize regmap\n"); + } + chip->regmaps[PM886_REGMAP_BASE] = regmap; + + err = regmap_read(regmap, PM886_REG_ID, &chip_id); + if (err) + return dev_err_probe(dev, err, "Failed to read chip ID\n"); + if (chip->whoami != chip_id) + return dev_err_probe(dev, -EINVAL, "Device reported wrong chip ID: %u\n", + chip_id); + + err = pm886_initialize_subregmaps(chip); + if (err) + return err; + + err = pm886_setup_irq(chip, &irq_data); + if (err) + return err; + + err = devm_mfd_add_devices(dev, 0, pm886_devs, ARRAY_SIZE(pm886_devs), + NULL, 0, regmap_irq_get_domain(irq_data)); + if (err) + return dev_err_probe(dev, err, "Failed to add devices\n"); + + err = devm_register_power_off_handler(dev, pm886_power_off_handler, chip); + if (err) + return dev_err_probe(dev, err, "Failed to register power off handler\n"); + + device_init_wakeup(dev, device_property_read_bool(dev, "wakeup-source")); + + return 0; +} + +const struct of_device_id pm886_of_match[] = { + { .compatible = "marvell,88pm886-a1", .data = (void *)PM886_A1_CHIP_ID }, + { }, +}; +MODULE_DEVICE_TABLE(of, pm886_of_match); + +static struct i2c_driver pm886_i2c_driver = { + .driver = { + .name = "88pm886", + .of_match_table = pm886_of_match, + }, + .probe = pm886_probe, +}; +module_i2c_driver(pm886_i2c_driver); + +MODULE_DESCRIPTION("Marvell 88PM886 PMIC driver"); +MODULE_AUTHOR("Karel Balej "); +MODULE_LICENSE("GPL"); diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index e7a6e45b9fac..9ef921c59f30 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -794,6 +794,18 @@ config MFD_88PM860X select individual components like voltage regulators, RTC and battery-charger under the corresponding menus. +config MFD_88PM886_PMIC + bool "Marvell 88PM886 PMIC" + depends on I2C=y + depends on OF + select REGMAP_I2C + select REGMAP_IRQ + select MFD_CORE + help + This enables support for Marvell 88PM886 Power Management IC. + This includes the I2C driver and the core APIs _only_, you have to + select individual components like onkey under the corresponding menus. + config MFD_MAX14577 tristate "Maxim Semiconductor MAX14577/77836 MUIC + Charger Support" depends on I2C diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index c66f07edcd0e..d016b7fed354 100644 --- a/drivers/mfd/Makefile +++ b/drivers/mfd/Makefile @@ -7,6 +7,7 @@ obj-$(CONFIG_MFD_88PM860X) += 88pm860x.o obj-$(CONFIG_MFD_88PM800) += 88pm800.o 88pm80x.o obj-$(CONFIG_MFD_88PM805) += 88pm805.o 88pm80x.o +obj-$(CONFIG_MFD_88PM886_PMIC) += 88pm886.o obj-$(CONFIG_MFD_ACT8945A) += act8945a.o obj-$(CONFIG_MFD_SM501) += sm501.o obj-$(CONFIG_ARCH_BCM2835) += bcm2835-pm.o diff --git a/include/linux/mfd/88pm886.h b/include/linux/mfd/88pm886.h new file mode 100644 index 000000000000..c7527bab0fba --- /dev/null +++ b/include/linux/mfd/88pm886.h @@ -0,0 +1,46 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __MFD_88PM886_H +#define __MFD_88PM886_H + +#include + +#define PM886_A1_CHIP_ID 0xa1 + +#define PM886_REG_ID 0x00 + +#define PM886_REG_STATUS1 0x01 +#define PM886_ONKEY_STS1 BIT(0) + +#define PM886_REG_MISC_CONFIG1 0x14 +#define PM886_SW_PDOWN BIT(5) + +#define PM886_REG_MISC_CONFIG2 0x15 +#define PM886_INT_INV BIT(0) +#define PM886_INT_CLEAR BIT(1) +#define PM886_INT_RC 0x00 +#define PM886_INT_WC BIT(1) +#define PM886_INT_MASK_MODE BIT(2) + +#define PM886_PAGE_OFFSET_REGULATORS 1 + +enum pm886_regulator_id { + PM886_REGULATOR_ID_LDO2, + PM886_REGULATOR_ID_LDO15, + PM886_REGULATOR_ID_BUCK2, + + PM886_REGULATOR_ID_SENTINEL +}; + +enum pm886_regmap_index { + PM886_REGMAP_BASE, + PM886_REGMAP_REGULATORS, + + PM886_REGMAP_NR +}; + +struct pm886_chip { + struct i2c_client *client; + unsigned int whoami; + struct regmap *regmaps[PM886_REGMAP_NR]; +}; +#endif /* __MFD_88PM886_H */ From patchwork Sun Mar 3 10:04:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karel Balej X-Patchwork-Id: 209294 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:10a:f01:a869 with SMTP id ju23csp852109dyc; Sun, 3 Mar 2024 02:17:31 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXATGfpD1IfHEEtuFL4gTwxZp6MefZwYvcUeUa64nnvDJ2NfOuQFz2nmE7keopRRiXzaaGADnc2sNamsWc1FeIOExi3cw== X-Google-Smtp-Source: AGHT+IGYiFH1JF4wbAFJ5tBGOXOUC0E4qPwjzKJUPoRjVS0IEWqCNmDae1aDOp0zX2T+6LNC2NnV X-Received: by 2002:aa7:c592:0:b0:565:1780:9398 with SMTP id g18-20020aa7c592000000b0056517809398mr4588405edq.39.1709461051688; Sun, 03 Mar 2024 02:17:31 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709461051; cv=pass; d=google.com; s=arc-20160816; b=UPpVGDV0SFcBdodzM7Perv1foJ4j5sWro9WEK+PI3LIr+0iussAU2RWcz2X9w7gO0u WPNllp2h1e4vDgyYoIa9wjaWb4zaQ9I5ocWJW6PUrGw4OTv3jcICMD63BYDsnK78qfeA H6Z4a7KrDD59romXCEG+17CGDWyVskxhau7755tnzCXp7SMhbNvWDtgIems55RdgcvRE 62Iw6ajOx2voTgkhhS2TH/T03zMA0BLwlN9L9DsOtMKb9Hkw02LQrroDwgHfApsOwmMF pKCBrV0lw5/Nr0NFzRtvXjLGKI9+G6fLBzbnmnKA3RUP+WkFE5sEchH8Q7qRTCstnDHe c+xQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=93xzp7dCdOCuDWUdid6AjEgFhifckMgQYOe+L6wZQhI=; fh=XPznAPHjywHhKJCA3zzSjmtYugAvBjl32NkRZBKKmSM=; b=G1t1lkPOWBSOsXmfuin1D7x4Ef/qQ/DqEaODC5dB2Eif+ExA6aHaeT00m2+tPRoK2l Bvou8cIK1pJ4sbBKPpw3IcNfKRN7Y/wPZZinkfsAULtLQYYvHu39UB3+U7Z8Vl91fnSd GWaxYG0V+TEd+yYpdNeE5Y+THdKDD4xTKYdKaMdoTKWWsrlB1PAIwWbfqUtydsOGQ6x6 hSHlvVDDsTc79I5QkLUaSgjkVUcXkjWNIHkXzdvJNi/9favkHEoDJAN7DwL9VXmtcMCd fC3snq15uMyrRW40mTJWJYYHRwlVxc5f/xj89r84uHFjX7ParWcCes32ypIP9UJQDIYb Jt4A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gimli.ms.mff.cuni.cz header.s=gen1 header.b=X9NhVwE2; arc=pass (i=1 spf=pass spfdomain=gimli.ms.mff.cuni.cz dkim=pass dkdomain=gimli.ms.mff.cuni.cz dmarc=pass fromdomain=gimli.ms.mff.cuni.cz); spf=pass (google.com: domain of linux-kernel+bounces-89698-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89698-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gimli.ms.mff.cuni.cz Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id z15-20020a05640240cf00b00566c1d0e2aesi2309840edb.68.2024.03.03.02.17.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Mar 2024 02:17:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-89698-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@gimli.ms.mff.cuni.cz header.s=gen1 header.b=X9NhVwE2; arc=pass (i=1 spf=pass spfdomain=gimli.ms.mff.cuni.cz dkim=pass dkdomain=gimli.ms.mff.cuni.cz dmarc=pass fromdomain=gimli.ms.mff.cuni.cz); spf=pass (google.com: domain of linux-kernel+bounces-89698-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89698-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gimli.ms.mff.cuni.cz Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E4A561F218CB for ; Sun, 3 Mar 2024 10:16:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1D4A11171E; Sun, 3 Mar 2024 10:15:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=gimli.ms.mff.cuni.cz header.i=@gimli.ms.mff.cuni.cz header.b="X9NhVwE2" Received: from nikam.ms.mff.cuni.cz (nikam.ms.mff.cuni.cz [195.113.20.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B166CB658; Sun, 3 Mar 2024 10:15:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.113.20.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709460937; cv=none; b=L14D5+otp7rodbPdH9gy4+BSHrZ5Z9nsiS3T/iqhcyczS4imWo2rK3W5S35gzrwuDZ2SyTxaLXJ7NTGupk07FQ/8keqtNZdpjaTuKJcNsYm+Ua1i95Y+FkX1CII5geSMT73y+gezKnMCkUaBPgHLaO4tujq+4F3lACVr0zb2tvo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709460937; c=relaxed/simple; bh=qYGefpcXl3f4Pfc/Kw83lzaWyUs9N5xpxIFTZgylE64=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xgi1eCftcdFNvEt9eMQR0Uk8mzI7H1Vz+tZ1NwSL7JrsXmZJnabwUEJF3ST3jW4hSSf030tV6PsDoXcRRT+UNZCrdsQJxKi3qrNI8BYfbzuYo95WRFW21tOnEYmWgH46yeSM3UGPCyzQ0kCpsGsyD65u0nmFcuX8xaWsqT7FD3U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gimli.ms.mff.cuni.cz; spf=pass smtp.mailfrom=gimli.ms.mff.cuni.cz; dkim=pass (1024-bit key) header.d=gimli.ms.mff.cuni.cz header.i=@gimli.ms.mff.cuni.cz header.b=X9NhVwE2; arc=none smtp.client-ip=195.113.20.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gimli.ms.mff.cuni.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gimli.ms.mff.cuni.cz Received: from gimli.ms.mff.cuni.cz (gimli.ms.mff.cuni.cz [195.113.20.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by nikam.ms.mff.cuni.cz (Postfix) with ESMTPS id 96C0A284292; Sun, 3 Mar 2024 11:15:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gimli.ms.mff.cuni.cz; s=gen1; t=1709460932; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=93xzp7dCdOCuDWUdid6AjEgFhifckMgQYOe+L6wZQhI=; b=X9NhVwE2osg6fHk4aLd3Bkvh4e3JicqyXc2zLlbYdGAupqSw9dDosvvnCYbRGbcAndC1Cn C+GFjvMQ85HQlIFtkPXiZraIntbQW9HHADsovdPwKeolXIlEleYSC1wf8RO6h7VCdSXd+E UmH4AqX9zyLjxVeVkGAnHFK+LLSEswo= Received: from localhost (internet5.mraknet.com [185.200.108.250]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: karelb) by gimli.ms.mff.cuni.cz (Postfix) with ESMTPSA id 711DA456F3E; Sun, 3 Mar 2024 11:15:32 +0100 (CET) From: Karel Balej To: Karel Balej , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Liam Girdwood , Mark Brown , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Cc: =?utf-8?q?Duje_Mihanovi=C4=87?= , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org Subject: [RFC PATCH v3 3/5] regulator: add regulators driver for Marvell 88PM886 PMIC Date: Sun, 3 Mar 2024 11:04:24 +0100 Message-ID: <20240303101506.4187-4-karelb@gimli.ms.mff.cuni.cz> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240303101506.4187-1-karelb@gimli.ms.mff.cuni.cz> References: <20240303101506.4187-1-karelb@gimli.ms.mff.cuni.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792499831443757106 X-GMAIL-MSGID: 1792499831443757106 From: Karel Balej Support the LDO and buck regulators of the Marvell 88PM886 PMIC. Signed-off-by: Karel Balej --- Notes: RFC v3: - Do not have a variable for each regulator -- define them all in the pm886_regulators array. - Use new regulators regmap index name. - Use dev_err_probe. RFC v2: - Drop of_compatible and related code. - Drop unused include. - Remove some abstraction: use only one regmap for all regulators and only mention 88PM886 in Kconfig description. - Reword commit message. drivers/regulator/88pm886-regulator.c | 195 ++++++++++++++++++++++++++ drivers/regulator/Kconfig | 6 + drivers/regulator/Makefile | 1 + 3 files changed, 202 insertions(+) create mode 100644 drivers/regulator/88pm886-regulator.c diff --git a/drivers/regulator/88pm886-regulator.c b/drivers/regulator/88pm886-regulator.c new file mode 100644 index 000000000000..73f6ce413dc3 --- /dev/null +++ b/drivers/regulator/88pm886-regulator.c @@ -0,0 +1,195 @@ +// SPDX-License-Identifier: GPL-2.0-only +#include +#include +#include +#include +#include +#include +#include + +#include + +#define PM886_REG_LDO_EN1 0x09 +#define PM886_REG_LDO_EN2 0x0a + +#define PM886_REG_BUCK_EN 0x08 + +#define PM886_REG_LDO1_VOUT 0x20 +#define PM886_REG_LDO2_VOUT 0x26 +#define PM886_REG_LDO3_VOUT 0x2c +#define PM886_REG_LDO4_VOUT 0x32 +#define PM886_REG_LDO5_VOUT 0x38 +#define PM886_REG_LDO6_VOUT 0x3e +#define PM886_REG_LDO7_VOUT 0x44 +#define PM886_REG_LDO8_VOUT 0x4a +#define PM886_REG_LDO9_VOUT 0x50 +#define PM886_REG_LDO10_VOUT 0x56 +#define PM886_REG_LDO11_VOUT 0x5c +#define PM886_REG_LDO12_VOUT 0x62 +#define PM886_REG_LDO13_VOUT 0x68 +#define PM886_REG_LDO14_VOUT 0x6e +#define PM886_REG_LDO15_VOUT 0x74 +#define PM886_REG_LDO16_VOUT 0x7a + +#define PM886_REG_BUCK1_VOUT 0xa5 +#define PM886_REG_BUCK2_VOUT 0xb3 +#define PM886_REG_BUCK3_VOUT 0xc1 +#define PM886_REG_BUCK4_VOUT 0xcf +#define PM886_REG_BUCK5_VOUT 0xdd + +#define PM886_LDO_VSEL_MASK 0x0f +#define PM886_BUCK_VSEL_MASK 0x7f + +struct pm886_regulator { + struct regulator_desc desc; + int max_uA; +}; + +static int pm886_regulator_get_ilim(struct regulator_dev *rdev) +{ + struct pm886_regulator *data = rdev_get_drvdata(rdev); + + if (!data) { + dev_err(&rdev->dev, "Failed to get regulator data\n"); + return -EINVAL; + } + return data->max_uA; +} + +static const struct regulator_ops pm886_ldo_ops = { + .list_voltage = regulator_list_voltage_table, + .map_voltage = regulator_map_voltage_iterate, + .set_voltage_sel = regulator_set_voltage_sel_regmap, + .get_voltage_sel = regulator_get_voltage_sel_regmap, + .enable = regulator_enable_regmap, + .disable = regulator_disable_regmap, + .is_enabled = regulator_is_enabled_regmap, + .get_current_limit = pm886_regulator_get_ilim, +}; + +static const struct regulator_ops pm886_buck_ops = { + .list_voltage = regulator_list_voltage_linear_range, + .map_voltage = regulator_map_voltage_linear_range, + .set_voltage_sel = regulator_set_voltage_sel_regmap, + .get_voltage_sel = regulator_get_voltage_sel_regmap, + .enable = regulator_enable_regmap, + .disable = regulator_disable_regmap, + .is_enabled = regulator_is_enabled_regmap, + .get_current_limit = pm886_regulator_get_ilim, +}; + +static const unsigned int pm886_ldo_volt_table1[] = { + 1700000, 1800000, 1900000, 2500000, 2800000, 2900000, 3100000, 3300000, +}; + +static const unsigned int pm886_ldo_volt_table2[] = { + 1200000, 1250000, 1700000, 1800000, 1850000, 1900000, 2500000, 2600000, + 2700000, 2750000, 2800000, 2850000, 2900000, 3000000, 3100000, 3300000, +}; + +static const unsigned int pm886_ldo_volt_table3[] = { + 1700000, 1800000, 1900000, 2000000, 2100000, 2500000, 2700000, 2800000, +}; + +static const struct linear_range pm886_buck_volt_ranges1[] = { + REGULATOR_LINEAR_RANGE(600000, 0, 79, 12500), + REGULATOR_LINEAR_RANGE(1600000, 80, 84, 50000), +}; + +static const struct linear_range pm886_buck_volt_ranges2[] = { + REGULATOR_LINEAR_RANGE(600000, 0, 79, 12500), + REGULATOR_LINEAR_RANGE(1600000, 80, 114, 50000), +}; + +static struct pm886_regulator pm886_regulators[] = { + [PM886_REGULATOR_ID_LDO2] = { + .desc = { + .name = "LDO2", + .id = PM886_REGULATOR_ID_LDO2, + .regulators_node = "regulators", + .of_match = "ldo2", + .ops = &pm886_ldo_ops, + .type = REGULATOR_VOLTAGE, + .enable_reg = PM886_REG_LDO_EN1, + .enable_mask = BIT(1), + .volt_table = pm886_ldo_volt_table1, + .n_voltages = ARRAY_SIZE(pm886_ldo_volt_table1), + .vsel_reg = PM886_REG_LDO2_VOUT, + .vsel_mask = PM886_LDO_VSEL_MASK, + }, + .max_uA = 100000, + }, + [PM886_REGULATOR_ID_LDO15] = { + .desc = { + .name = "LDO15", + .id = PM886_REGULATOR_ID_LDO15, + .regulators_node = "regulators", + .of_match = "ldo15", + .ops = &pm886_ldo_ops, + .type = REGULATOR_VOLTAGE, + .enable_reg = PM886_REG_LDO_EN2, + .enable_mask = BIT(6), + .volt_table = pm886_ldo_volt_table2, + .n_voltages = ARRAY_SIZE(pm886_ldo_volt_table2), + .vsel_reg = PM886_REG_LDO15_VOUT, + .vsel_mask = PM886_LDO_VSEL_MASK, + }, + .max_uA = 200000, + }, + [PM886_REGULATOR_ID_BUCK2] = { + .desc = { + .name = "buck2", + .id = PM886_REGULATOR_ID_BUCK2, + .regulators_node = "regulators", + .of_match = "buck2", + .ops = &pm886_buck_ops, + .type = REGULATOR_VOLTAGE, + .n_voltages = 115, + .linear_ranges = pm886_buck_volt_ranges2, + .n_linear_ranges = ARRAY_SIZE(pm886_buck_volt_ranges2), + .vsel_reg = PM886_REG_BUCK2_VOUT, + .vsel_mask = PM886_BUCK_VSEL_MASK, + .enable_reg = PM886_REG_BUCK_EN, + .enable_mask = BIT(1), + }, + .max_uA = 1200000, + }, +}; + +static int pm886_regulator_probe(struct platform_device *pdev) +{ + struct pm886_chip *chip = dev_get_drvdata(pdev->dev.parent); + struct regulator_config rcfg = { }; + struct pm886_regulator *regulator; + struct device *dev = &pdev->dev; + struct regulator_desc *rdesc; + struct regulator_dev *rdev; + + if (pdev->id < 0 || pdev->id >= PM886_REGULATOR_ID_SENTINEL) + return dev_err_probe(dev, -EINVAL, "Invalid regulator ID: %d\n", + pdev->id); + + rcfg.dev = dev->parent; + regulator = &pm886_regulators[pdev->id]; + rdesc = ®ulator->desc; + rcfg.driver_data = regulator; + rcfg.regmap = chip->regmaps[PM886_REGMAP_REGULATORS]; + rdev = devm_regulator_register(dev, rdesc, &rcfg); + if (IS_ERR(rdev)) + return dev_err_probe(dev, PTR_ERR(rdev), "Failed to register %s", + rdesc->name); + + return 0; +} + +static struct platform_driver pm886_regulator_driver = { + .driver = { + .name = "88pm886-regulator", + }, + .probe = pm886_regulator_probe, +}; +module_platform_driver(pm886_regulator_driver); + +MODULE_DESCRIPTION("Marvell 88PM886 PMIC regulator driver"); +MODULE_AUTHOR("Karel Balej "); +MODULE_LICENSE("GPL"); diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig index 550145f82726..e8f504d4b9f6 100644 --- a/drivers/regulator/Kconfig +++ b/drivers/regulator/Kconfig @@ -91,6 +91,12 @@ config REGULATOR_88PM8607 help This driver supports 88PM8607 voltage regulator chips. +config REGULATOR_88PM886 + tristate "Marvell 88PM886 voltage regulators" + depends on MFD_88PM886_PMIC + help + This driver implements support for Marvell 88PM886 voltage regulators. + config REGULATOR_ACT8865 tristate "Active-semi act8865 voltage regulator" depends on I2C diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile index 46fb569e6be8..f30089b74b2e 100644 --- a/drivers/regulator/Makefile +++ b/drivers/regulator/Makefile @@ -14,6 +14,7 @@ obj-$(CONFIG_REGULATOR_USERSPACE_CONSUMER) += userspace-consumer.o obj-$(CONFIG_REGULATOR_88PG86X) += 88pg86x.o obj-$(CONFIG_REGULATOR_88PM800) += 88pm800-regulator.o obj-$(CONFIG_REGULATOR_88PM8607) += 88pm8607.o +obj-$(CONFIG_REGULATOR_88PM886) += 88pm886-regulator.o obj-$(CONFIG_REGULATOR_CROS_EC) += cros-ec-regulator.o obj-$(CONFIG_REGULATOR_CPCAP) += cpcap-regulator.o obj-$(CONFIG_REGULATOR_AAT2870) += aat2870-regulator.o From patchwork Sun Mar 3 10:04:25 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karel Balej X-Patchwork-Id: 209295 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:10a:f01:a869 with SMTP id ju23csp852135dyc; Sun, 3 Mar 2024 02:17:38 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU7NG8g6+MacAah3qy/MKd8wUS/3aek4/VP005KwZsLgQ8zx1+vtyB+4E5vCl3ELykLEysO1ZZWc+F7AU7GkGojcCZQ7A== X-Google-Smtp-Source: AGHT+IGw1XaxALIibnI2qxOy8pxE4WIQL/NiypStcZ5VUa/QtU/BJYj1RpbQcDPZLXJRSRSbTpNI X-Received: by 2002:a17:906:4818:b0:a45:2fc4:f25d with SMTP id w24-20020a170906481800b00a452fc4f25dmr303773ejq.12.1709461058404; Sun, 03 Mar 2024 02:17:38 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709461058; cv=pass; d=google.com; s=arc-20160816; b=iy8Nmmp8R9X6Zp1Q7bNO/8DMMy+X1cDGlbu044dnzK9g0Ly6+Mq2C+lXX8yR6YOVVF 1qNEa51+Csy8u3Pbu86w6KswE5VBHE4DGo8PwWE4kn9jLrQwRzZ2ugqwsJUNdfq/QKbz iX3XSUuifwxOZBCWFRan2RHa6WsbUjAYz/YyCQX5SIB/9jCzX5QDR1BqIxCgWsd5xjZ2 Sa0D9G2FNwQ9K3FbmbkWmWQPI8F+N+2ot77tUNTUgcZou8Jpxd5KiwNdZQOXOdQte9wg pdI9KtgIfotzlZMdYum6w7JIa5m3Je0u7xv41jic/gq1J0BHArZ8/aMoAp7DJne9x1Nz 5wxA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=XQfPEk+YaTiJuYOg0PFgBeaAHtq/GQWV1cVMTq9Ae8U=; fh=XPznAPHjywHhKJCA3zzSjmtYugAvBjl32NkRZBKKmSM=; b=MKmLKdLVztgu9EEwZ5Rimeh5X5JAT9SJYrpZtijnM6Te4Gyhoey1hlGWUPoP6gR9H/ 8oW/Xgb+85BZ67iGSIx3zJqiHsvKhc92buUv+oNQ6miLPU1VJge1bAxAsoN1tejxDyrK LxzeRbLfyCsE04c86ziwCV30i9MzOaVVmgcVH+SpPfY7eCrf5UB3z5O+ByAhoLbZltLr 2cOvIGymtn0YWwPl+TXfwam8xrwN4QHKhBSPquxvjqrqrGklj8pxEVFDL3DarggBx1Ty MrEEX5qUzI8k+m/2wclW5jR66QxTRTaUr92rouP/+KiHER80rANAae3sIdvi7NCfIhHe GztA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gimli.ms.mff.cuni.cz header.s=gen1 header.b=OsQvXuCQ; arc=pass (i=1 spf=pass spfdomain=gimli.ms.mff.cuni.cz dkim=pass dkdomain=gimli.ms.mff.cuni.cz dmarc=pass fromdomain=gimli.ms.mff.cuni.cz); spf=pass (google.com: domain of linux-kernel+bounces-89700-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89700-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gimli.ms.mff.cuni.cz Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id t5-20020a170906608500b00a44fb3c804csi739219ejj.416.2024.03.03.02.17.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Mar 2024 02:17:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-89700-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@gimli.ms.mff.cuni.cz header.s=gen1 header.b=OsQvXuCQ; arc=pass (i=1 spf=pass spfdomain=gimli.ms.mff.cuni.cz dkim=pass dkdomain=gimli.ms.mff.cuni.cz dmarc=pass fromdomain=gimli.ms.mff.cuni.cz); spf=pass (google.com: domain of linux-kernel+bounces-89700-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89700-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gimli.ms.mff.cuni.cz Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 418091F21E64 for ; Sun, 3 Mar 2024 10:17:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 47862125A4; Sun, 3 Mar 2024 10:15:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=gimli.ms.mff.cuni.cz header.i=@gimli.ms.mff.cuni.cz header.b="OsQvXuCQ" Received: from nikam.ms.mff.cuni.cz (nikam.ms.mff.cuni.cz [195.113.20.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C38ABE6F; Sun, 3 Mar 2024 10:15:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.113.20.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709460939; cv=none; b=iJo0LRUy6a3trvemfM5R2T2QRoJNfTg9lzqTn8F8t96COwpQEplzvpEPaCZ619vA/8f1ecjs+LK8ihgXyXmNSdv0ukMu3AKut5KXbP65bZUQDRXlFz4Ws6V7u2Ifkbrv8dHGkQl1bZFsTn6w/cc473vCOJFltEZrp5mKSQkNaUs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709460939; c=relaxed/simple; bh=6bfIYuZJxXhbwIjqddIRiO/HE5MXRN1Wdqdl2bUC7ac=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Jm1vY+r6rKM9qNz5OcjA6gqL5P/2ExydOsmks03lZ3YjW2q+W+Mh4DC+ynsz+9D83rM9ufV47aHBFM1IQ3cPzqFPAupOdaMB2/E9E9F1OZyU7hH1jH3HyEqJMx46kDm1ZmNPjFTrob9FUFBehrMu3+RLaVvbhGgEvC7I4IWqP2o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gimli.ms.mff.cuni.cz; spf=pass smtp.mailfrom=gimli.ms.mff.cuni.cz; dkim=pass (1024-bit key) header.d=gimli.ms.mff.cuni.cz header.i=@gimli.ms.mff.cuni.cz header.b=OsQvXuCQ; arc=none smtp.client-ip=195.113.20.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gimli.ms.mff.cuni.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gimli.ms.mff.cuni.cz Received: from gimli.ms.mff.cuni.cz (gimli.ms.mff.cuni.cz [195.113.20.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by nikam.ms.mff.cuni.cz (Postfix) with ESMTPS id 65EDE284294; Sun, 3 Mar 2024 11:15:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gimli.ms.mff.cuni.cz; s=gen1; t=1709460935; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XQfPEk+YaTiJuYOg0PFgBeaAHtq/GQWV1cVMTq9Ae8U=; b=OsQvXuCQvo0e3HSCu4WiExRgqfitRz3YJfAlS41hgCGr9AmPDpswbGPKZLTx6aLRk8tOh7 bP00O+Ps47w8TApT5NWxhMtlF4Z3FdfTOC5ry4eOxv1SKPze/tFdTWYXQYmEV3rR+w9fml 2Zk5kYF+PIya0kv6kDgApIixRdfcDfk= Received: from localhost (internet5.mraknet.com [185.200.108.250]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: karelb) by gimli.ms.mff.cuni.cz (Postfix) with ESMTPSA id 4426C456F3E; Sun, 3 Mar 2024 11:15:35 +0100 (CET) From: Karel Balej To: Karel Balej , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Liam Girdwood , Mark Brown , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Cc: =?utf-8?q?Duje_Mihanovi=C4=87?= , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org Subject: [RFC PATCH v3 4/5] input: add onkey driver for Marvell 88PM886 PMIC Date: Sun, 3 Mar 2024 11:04:25 +0100 Message-ID: <20240303101506.4187-5-karelb@gimli.ms.mff.cuni.cz> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240303101506.4187-1-karelb@gimli.ms.mff.cuni.cz> References: <20240303101506.4187-1-karelb@gimli.ms.mff.cuni.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792499838762450608 X-GMAIL-MSGID: 1792499838762450608 From: Karel Balej Marvell 88PM886 PMIC provides onkey among other things. Add client driver to handle it. The driver currently only provides a basic support omitting additional functions found in the vendor version, such as long onkey and GPIO integration. Signed-off-by: Karel Balej Acked-by: Dmitry Torokhov --- Notes: RFC v3: - Drop wakeup-source. RFC v2: - Address Dmitry's feedback: - Sort includes alphabetically. - Drop onkey->irq. - ret -> err in irq_handler and no initialization. - Break long lines and other formatting. - Do not clobber platform_get_irq error. - Do not set device parent manually. - Use input_set_capability. - Use the wakeup-source DT property. - Drop of_match_table. - Use more temporaries. - Use dev_err_probe. - Modify Kconfig description. drivers/input/misc/88pm886-onkey.c | 92 ++++++++++++++++++++++++++++++ drivers/input/misc/Kconfig | 7 +++ drivers/input/misc/Makefile | 1 + 3 files changed, 100 insertions(+) create mode 100644 drivers/input/misc/88pm886-onkey.c diff --git a/drivers/input/misc/88pm886-onkey.c b/drivers/input/misc/88pm886-onkey.c new file mode 100644 index 000000000000..2e5df21cd11b --- /dev/null +++ b/drivers/input/misc/88pm886-onkey.c @@ -0,0 +1,92 @@ +// SPDX-License-Identifier: GPL-2.0-only +#include +#include +#include +#include +#include +#include + +#include + +struct pm886_onkey { + struct input_dev *idev; + struct pm886_chip *chip; +}; + +static irqreturn_t pm886_onkey_irq_handler(int irq, void *data) +{ + struct pm886_onkey *onkey = data; + struct regmap *regmap = onkey->chip->regmaps[PM886_REGMAP_BASE]; + struct input_dev *idev = onkey->idev; + struct device *parent = idev->dev.parent; + unsigned int val; + int err; + + err = regmap_read(regmap, PM886_REG_STATUS1, &val); + if (err) { + dev_err(parent, "Failed to read status: %d\n", err); + return IRQ_NONE; + } + val &= PM886_ONKEY_STS1; + + input_report_key(idev, KEY_POWER, val); + input_sync(idev); + + return IRQ_HANDLED; +} + +static int pm886_onkey_probe(struct platform_device *pdev) +{ + struct pm886_chip *chip = dev_get_drvdata(pdev->dev.parent); + struct device *dev = &pdev->dev; + struct pm886_onkey *onkey; + struct input_dev *idev; + int irq, err; + + onkey = devm_kzalloc(dev, sizeof(*onkey), GFP_KERNEL); + if (!onkey) + return -ENOMEM; + + onkey->chip = chip; + + irq = platform_get_irq(pdev, 0); + if (irq < 0) + return dev_err_probe(dev, irq, "Failed to get IRQ\n"); + + idev = devm_input_allocate_device(dev); + if (!idev) { + dev_err(dev, "Failed to allocate input device\n"); + return -ENOMEM; + } + onkey->idev = idev; + + idev->name = "88pm886-onkey"; + idev->phys = "88pm886-onkey/input0"; + idev->id.bustype = BUS_I2C; + + input_set_capability(idev, EV_KEY, KEY_POWER); + + err = devm_request_threaded_irq(dev, irq, NULL, pm886_onkey_irq_handler, + IRQF_ONESHOT | IRQF_NO_SUSPEND, "onkey", + onkey); + if (err) + return dev_err_probe(dev, err, "Failed to request IRQ\n"); + + err = input_register_device(idev); + if (err) + return dev_err_probe(dev, err, "Failed to register input device\n"); + + return 0; +} + +static struct platform_driver pm886_onkey_driver = { + .driver = { + .name = "88pm886-onkey", + }, + .probe = pm886_onkey_probe, +}; +module_platform_driver(pm886_onkey_driver); + +MODULE_DESCRIPTION("Marvell 88PM886 onkey driver"); +MODULE_AUTHOR("Karel Balej "); +MODULE_LICENSE("GPL"); diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig index 6ba984d7f0b1..16a079d9f0f2 100644 --- a/drivers/input/misc/Kconfig +++ b/drivers/input/misc/Kconfig @@ -33,6 +33,13 @@ config INPUT_88PM80X_ONKEY To compile this driver as a module, choose M here: the module will be called 88pm80x_onkey. +config INPUT_88PM886_ONKEY + tristate "Marvell 88PM886 onkey support" + depends on MFD_88PM886_PMIC + help + Support the onkey of Marvell 88PM886 PMIC as an input device + reporting power button status. + config INPUT_AB8500_PONKEY tristate "AB8500 Pon (PowerOn) Key" depends on AB8500_CORE diff --git a/drivers/input/misc/Makefile b/drivers/input/misc/Makefile index 04296a4abe8e..054a6dc1ac27 100644 --- a/drivers/input/misc/Makefile +++ b/drivers/input/misc/Makefile @@ -7,6 +7,7 @@ obj-$(CONFIG_INPUT_88PM860X_ONKEY) += 88pm860x_onkey.o obj-$(CONFIG_INPUT_88PM80X_ONKEY) += 88pm80x_onkey.o +obj-$(CONFIG_INPUT_88PM886_ONKEY) += 88pm886-onkey.o obj-$(CONFIG_INPUT_AB8500_PONKEY) += ab8500-ponkey.o obj-$(CONFIG_INPUT_AD714X) += ad714x.o obj-$(CONFIG_INPUT_AD714X_I2C) += ad714x-i2c.o From patchwork Sun Mar 3 10:04:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karel Balej X-Patchwork-Id: 209296 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:10a:f01:a869 with SMTP id ju23csp852165dyc; Sun, 3 Mar 2024 02:17:43 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXm5bnu9RR/xF65+7SLPr1ZtwZCNffJiXPeOM9MtfcwtUVRGos9RRlVSsgnf7DT7MjtPUmEcEKg7tIz8vLpUJoRXoHarA== X-Google-Smtp-Source: AGHT+IHoGMEWeSAI0ujgx5sV1NmMVzilK0OBc7HBRHDx7EeCXpCe3J3Q2zGr6fwJ72jOyMBMcUFC X-Received: by 2002:a50:c8cb:0:b0:561:3b53:d0af with SMTP id k11-20020a50c8cb000000b005613b53d0afmr4719362edh.12.1709461063337; Sun, 03 Mar 2024 02:17:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709461063; cv=pass; d=google.com; s=arc-20160816; b=FXYM4LH46aF7FurKkM5kYvRQwgk791DgR2b+T4NFBjs4Z4qqclr7IqDT1AQPMiZO0C g0obIvxCX6Hq7knrO0cUCyy5Dyte/5yx+JgyBTzhvNbV5ssExOZuAmzSgAT2jwFRK8Ch IEWJ31iRJPE4aNhTTCDPxLvmsZBEvDYU+x4Ajm0lM+8ftp6B2+vL9EL6oSr4bQWXvKx2 mZHFKohWk2mGbzP+zsozZY4jDytVsnTRYPQkw1LLC4XD/ScVKHpdoq5GMKHNAB/07Yo5 XRgxa1C04Q3RtRi7h7QXS91lqXrqRXVbAi7QI6FRpvnede3+Z/gO+8zdptaIyEXJ3DwT nYlw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=L8AQ4xgfMvMsXIMfpwAjFqhheRmmqGTQDMpqDvceVgs=; fh=XPznAPHjywHhKJCA3zzSjmtYugAvBjl32NkRZBKKmSM=; b=Ps66ZTUmJ/PoeAC+M/dRpNgz/bMB0egztgPymJNXGTt08zoBOEpJpM4j/Qu1Yd25uK 3crqTOOTZHHL4B3JjkvC0hAuIFH9hvuG824ABWOQwIHnh9InkQaP7OzJEK4kmWMXsOak OEETX7OT06kzbLuykBOz5V3C/v9xB88MXBLOPfmfylHkhPA41iPG38cPnpp7wF9k2woS X0rGDXsuCqj9UXHg4cEyV95L8IFr9vW6r/z06qKzlyZ2y1I5+302DXsT5eCFrAUzOJPi 0PzBySMqDgH6bzBE7cnL1TxLS4i4TxSsgdhHD/jMq9Z8Roiq15RY+eJe+XZn5gOf2Ryz /03Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gimli.ms.mff.cuni.cz header.s=gen1 header.b=CvoH8IKr; arc=pass (i=1 spf=pass spfdomain=gimli.ms.mff.cuni.cz dkim=pass dkdomain=gimli.ms.mff.cuni.cz dmarc=pass fromdomain=gimli.ms.mff.cuni.cz); spf=pass (google.com: domain of linux-kernel+bounces-89701-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89701-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gimli.ms.mff.cuni.cz Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id n23-20020a05640206d700b00563f6984904si3095015edy.237.2024.03.03.02.17.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Mar 2024 02:17:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-89701-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@gimli.ms.mff.cuni.cz header.s=gen1 header.b=CvoH8IKr; arc=pass (i=1 spf=pass spfdomain=gimli.ms.mff.cuni.cz dkim=pass dkdomain=gimli.ms.mff.cuni.cz dmarc=pass fromdomain=gimli.ms.mff.cuni.cz); spf=pass (google.com: domain of linux-kernel+bounces-89701-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-89701-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gimli.ms.mff.cuni.cz Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 6301B1F221EB for ; Sun, 3 Mar 2024 10:17:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 14EE312B61; Sun, 3 Mar 2024 10:15:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=gimli.ms.mff.cuni.cz header.i=@gimli.ms.mff.cuni.cz header.b="CvoH8IKr" Received: from nikam.ms.mff.cuni.cz (nikam.ms.mff.cuni.cz [195.113.20.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC73511188; Sun, 3 Mar 2024 10:15:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.113.20.16 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709460941; cv=none; b=QIaDjvOKVg5gkwj0EXvNTEuioe6mQYppH/7DtfYtzoUKS5RujIQjzECBh3U2SFw+JmeD58SJCpgxE+NHNidjsemMebi2g1LAc5IQVYCKMd8M8c4qhT3I+Id23u7sHUcwVkI1ZJoVWDRsKMphm5ryrJ0OiE5h5KGRQN7lUUzfFfg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709460941; c=relaxed/simple; bh=X8u1uSp8PSGBxfTjwO9Jh3/p2urwTYeubgK79OdVU/E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=esWy7olqSSVjb9wv2H5e53O5amnH28Vm1YMgwmW8KvY5RYaz8sdBxN9QNGxUsj1HRynMaF+Ahf9n1wQ2B6jpmM0Psll/0gvLQKVpinr6mn5pzI62ofE4UqkvbiLD3tAdj3d9dgIfucp4CVPVx2eG2IqLLeCvo5hfdUJ0zCZNupU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gimli.ms.mff.cuni.cz; spf=pass smtp.mailfrom=gimli.ms.mff.cuni.cz; dkim=pass (1024-bit key) header.d=gimli.ms.mff.cuni.cz header.i=@gimli.ms.mff.cuni.cz header.b=CvoH8IKr; arc=none smtp.client-ip=195.113.20.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gimli.ms.mff.cuni.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gimli.ms.mff.cuni.cz Received: from gimli.ms.mff.cuni.cz (gimli.ms.mff.cuni.cz [195.113.20.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by nikam.ms.mff.cuni.cz (Postfix) with ESMTPS id 2578628428C; Sun, 3 Mar 2024 11:15:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gimli.ms.mff.cuni.cz; s=gen1; t=1709460938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L8AQ4xgfMvMsXIMfpwAjFqhheRmmqGTQDMpqDvceVgs=; b=CvoH8IKrHNt16qFEKIgD+LeIQF2An8FpTMMtyevmadTwAcgVHFlayLzjnwmKNTGwIDOqVV q6W6AVjSLvMO1IH/9BJcyg4V1juL2En5eI3btM/oTsHWGMabRlNoEW50yCZKi7IdybkZCv e0GfCAhxoKH084aTM0/g+khnMOdOU5k= Received: from localhost (internet5.mraknet.com [185.200.108.250]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: karelb) by gimli.ms.mff.cuni.cz (Postfix) with ESMTPSA id 01C8F456F3E; Sun, 3 Mar 2024 11:15:37 +0100 (CET) From: Karel Balej To: Karel Balej , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Liam Girdwood , Mark Brown , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Cc: =?utf-8?q?Duje_Mihanovi=C4=87?= , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org Subject: [RFC PATCH v3 5/5] MAINTAINERS: add myself for Marvell 88PM886 PMIC Date: Sun, 3 Mar 2024 11:04:26 +0100 Message-ID: <20240303101506.4187-6-karelb@gimli.ms.mff.cuni.cz> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240303101506.4187-1-karelb@gimli.ms.mff.cuni.cz> References: <20240303101506.4187-1-karelb@gimli.ms.mff.cuni.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792499844121806106 X-GMAIL-MSGID: 1792499844121806106 From: Karel Balej Add an entry to MAINTAINERS for the Marvell 88PM886 PMIC MFD, onkey and regulator drivers. Signed-off-by: Karel Balej --- Notes: RFC v3: - Remove onkey bindings file. RFC v2: - Only mention 88PM886 in the commit message. - Add regulator driver. - Rename the entry. MAINTAINERS | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 960512bec428..944f88c92df6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12949,6 +12949,15 @@ F: drivers/net/dsa/mv88e6xxx/ F: include/linux/dsa/mv88e6xxx.h F: include/linux/platform_data/mv88e6xxx.h +MARVELL 88PM886 PMIC DRIVER +M: Karel Balej +S: Maintained +F: Documentation/devicetree/bindings/mfd/marvell,88pm886-a1.yaml +F: drivers/input/misc/88pm886-onkey.c +F: drivers/mfd/88pm886.c +F: drivers/regulators/88pm886-regulator.c +F: include/linux/mfd/88pm886.h + MARVELL ARMADA 3700 PHY DRIVERS M: Miquel Raynal S: Maintained