From patchwork Thu Jul 21 07:01:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Li, Pan2 via Gcc-patches" X-Patchwork-Id: 96 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:e252:0:0:0:0:0 with SMTP id bl18csp1306668wrb; Thu, 21 Jul 2022 00:02:00 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tgLTAKt4SYxUXovUYtcxpTsxYevknFtOuX2pfpCY95ShLLy4M5ujMrL/hTF6lMZ85rpTf0 X-Received: by 2002:a05:6402:424c:b0:43b:c303:2891 with SMTP id g12-20020a056402424c00b0043bc3032891mr3599610edb.374.1658386920529; Thu, 21 Jul 2022 00:02:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658386920; cv=none; d=google.com; s=arc-20160816; b=Y5Zy+cKJyIKT68jiW/Vu7sz1ucIl3J8KhpOCiAv5lg20jRwTT7j3SFIwbtRpgmFIjj LaqeejxJEiTnHvFXfqghRVaU7HAmvWaFs4zjG8zP6TqcqAk7caG7zL1euzrWZ+yhkxL4 VSiee3/PTgBvALBjjN8GL5ADvoUrsW3ryAdrpB1vvsbeuMw9Hht8JvEAzs0f7tDkufgD yV6I/w9PhTuw9Si6XoRvuueHYZJUErHAPKgUIjBL30vJhslCh3hgs5tLwd2nPBUTGjHQ 7w9c6zyGjTUi4Gyr3oGfPnDD7iSrErFL71HiIqk+glAebvZCj1ZUTSnuJwVoTNz/zFY5 5LOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:message-id :mime-version:subject:to:date:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=f+yrePizEKVHexbbBXIwJNkxA5n5HYjYo8Wsgnman0g=; b=mCs9HNOpQMLx+I0xpTesCF0l8z3jjVEHPj31+nT9LBfJ+t8Nxe1Gacr1DwXvNrqm6S oFIvYOAJCysmmXDl3hPkDQG1UUbXH8HyRA17lO97aURsYjP5U2wHEKvwZyKbKbGsQvoE mjeT5S6zN3BYb9xBaW4kI63UNR75IR+9JEfb7VhlCC41KLo/WXWNFMchH4B/8sn9it25 QSTegso+LfKphQzRsiWIrjtSKMrim7qPV8pS3fXo8LiwW3iz6iPmoEz3GSWXK2LFf40Y 6Ta388Rru1XC7FN7m+J+Uu5UWPZU5HzBLemK86ytXgupxM5fTVMTdxFB7LsSh+NezfWp c1NQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=kt7fGbLc; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id gs42-20020a1709072d2a00b0072a47b13d67si1993246ejc.582.2022.07.21.00.02.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Jul 2022 00:02:00 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=kt7fGbLc; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 95A063856DF5 for ; Thu, 21 Jul 2022 07:01:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 95A063856DF5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1658386914; bh=f+yrePizEKVHexbbBXIwJNkxA5n5HYjYo8Wsgnman0g=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=kt7fGbLctk8oOPgkXWHCL1l0dEgK66H2fpwcsBXjOfxr3nn3Y48/DJZwXCgC1Vocp w20uDC6aLjLUuNKmrkYFQBqmhe7Fap4xO0ymfYY9vQYnev+WCqePF4hDG1wL3hyTOm dBiMF17JyO9WOVwdmkmJ9iwyrz9ecO9xzwCEYqCQ= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 7D85A3856DEC for ; Thu, 21 Jul 2022 07:01:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7D85A3856DEC Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AAFD720F49 for ; Thu, 21 Jul 2022 07:01:07 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 95AEC139FC for ; Thu, 21 Jul 2022 07:01:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id jX5DI7P52GLKBQAAMHmgww (envelope-from ) for ; Thu, 21 Jul 2022 07:01:07 +0000 Date: Thu, 21 Jul 2022 09:01:07 +0200 (CEST) To: gcc-patches@gcc.gnu.org Subject: [PATCH] Add alias disambiguation for vectorizer load/store IFNs MIME-Version: 1.0 Message-Id: <20220721070107.95AEC139FC@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: "Li, Pan2 via Gcc-patches" Reply-To: Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1738944723643730759?= X-GMAIL-MSGID: =?utf-8?q?1738944723643730759?= The following adds support for MASK_STORE, MASK_LOAD and friends to call_may_clobber_ref_p and ref_maybe_used_by_call_p. Since they all use a special argument to specify TBAA they are not really suited for fnspec handling thus the manual support. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR106365 shows this can be important though in many cases seen there we miss PTA info. * tree-ssa-alias.cc (ref_maybe_used_by_call_p_1): Special-case store internal functions and IFN_MASK_LOAD, IFN_LEN_LOAD and IFN_MASK_LOAD_LANES. (call_may_clobber_ref_p_1): Special-case IFN_MASK_STORE, IFN_LEN_STORE and IFN_MASK_STORE_LANES. --- gcc/tree-ssa-alias.cc | 49 +++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 47 insertions(+), 2 deletions(-) diff --git a/gcc/tree-ssa-alias.cc b/gcc/tree-ssa-alias.cc index 782266bdad8..390cd875074 100644 --- a/gcc/tree-ssa-alias.cc +++ b/gcc/tree-ssa-alias.cc @@ -47,6 +47,7 @@ along with GCC; see the file COPYING3. If not see #include "print-tree.h" #include "tree-ssa-alias-compare.h" #include "builtins.h" +#include "internal-fn.h" /* Broad overview of how alias analysis on gimple works: @@ -2793,8 +2794,38 @@ ref_maybe_used_by_call_p_1 (gcall *call, ao_ref *ref, bool tbaa_p) if (ref->volatile_p) return true; - callee = gimple_call_fndecl (call); + if (gimple_call_internal_p (call)) + switch (gimple_call_internal_fn (call)) + { + case IFN_MASK_STORE: + case IFN_SCATTER_STORE: + case IFN_MASK_SCATTER_STORE: + case IFN_LEN_STORE: + return false; + case IFN_MASK_STORE_LANES: + goto process_args; + case IFN_MASK_LOAD: + case IFN_LEN_LOAD: + case IFN_MASK_LOAD_LANES: + { + ao_ref rhs_ref; + tree lhs = gimple_call_lhs (call); + if (lhs) + { + ao_ref_init_from_ptr_and_size (&rhs_ref, + gimple_call_arg (call, 0), + TYPE_SIZE_UNIT (TREE_TYPE (lhs))); + rhs_ref.ref_alias_set = rhs_ref.base_alias_set + = tbaa_p ? get_deref_alias_set (TREE_TYPE + (gimple_call_arg (call, 1))) : 0; + return refs_may_alias_p_1 (ref, &rhs_ref, tbaa_p); + } + break; + } + default:; + } + callee = gimple_call_fndecl (call); if (callee != NULL_TREE) { struct cgraph_node *node = cgraph_node::get (callee); @@ -3005,7 +3036,7 @@ call_may_clobber_ref_p_1 (gcall *call, ao_ref *ref, bool tbaa_p) & (ECF_PURE|ECF_CONST|ECF_LOOPING_CONST_OR_PURE|ECF_NOVOPS)) return false; if (gimple_call_internal_p (call)) - switch (gimple_call_internal_fn (call)) + switch (auto fn = gimple_call_internal_fn (call)) { /* Treat these internal calls like ECF_PURE for aliasing, they don't write to any memory the program should care about. @@ -3018,6 +3049,20 @@ call_may_clobber_ref_p_1 (gcall *call, ao_ref *ref, bool tbaa_p) case IFN_UBSAN_PTR: case IFN_ASAN_CHECK: return false; + case IFN_MASK_STORE: + case IFN_LEN_STORE: + case IFN_MASK_STORE_LANES: + { + tree rhs = gimple_call_arg (call, + internal_fn_stored_value_index (fn)); + ao_ref lhs_ref; + ao_ref_init_from_ptr_and_size (&lhs_ref, gimple_call_arg (call, 0), + TYPE_SIZE_UNIT (TREE_TYPE (rhs))); + lhs_ref.ref_alias_set = lhs_ref.base_alias_set + = tbaa_p ? get_deref_alias_set + (TREE_TYPE (gimple_call_arg (call, 1))) : 0; + return refs_may_alias_p_1 (ref, &lhs_ref, tbaa_p); + } default: break; }