From patchwork Fri Mar 1 17:51:47 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ricardo B. Marliere" X-Patchwork-Id: 208991 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:10a:f01:a869 with SMTP id ju23csp46942dyc; Fri, 1 Mar 2024 09:59:28 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWhB9r3vhWDQyC/3mkxSVP4+imwhKe0BxHuNZrlstQBA+z2fKpXewhl4exCZsEFtbx5Hp7zUsd9g6XaVrmKntb2io3/4Q== X-Google-Smtp-Source: AGHT+IGwOP33vk+iSr/r91AAENI5KLB8zl1AerlPjMZJ9vdrZ++GCtLcvbutECAWpxQG5ilHcaRs X-Received: by 2002:ac8:5d91:0:b0:42e:8a12:f8c6 with SMTP id d17-20020ac85d91000000b0042e8a12f8c6mr2662417qtx.19.1709315968165; Fri, 01 Mar 2024 09:59:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709315968; cv=pass; d=google.com; s=arc-20160816; b=oQU2l1oxJKo5gMgTdHTsV8GQpUUVzzBpLcm+kwXoiGdeU0VW5ixfc795Hr1A1BxEAV EgRcCVepocMUlj6gHkkAH7QzWYUCGZov+WOjqpYnU5bSfJGLkh3o6QQeae9M3qmmcmpt 2sYtV/LtrDb0KO8rNjQB+32BHx7AiR7iA9UiezIILr9qMhjc/4ycJyyYcWDMHa8T8MZs TAWfeNw5vWfIl488OPiRTLWaXwSOC/wybuSmsnUrCiSx2/xjhI8iXmbBXyCQABJ/cvHX 8HRe1ZSNzTS+Xy+N2kjF4s+S4zWVyGIcCXWjBPgBG3TsqD/h1M9+XihEvx6I3G+XaOjp flVg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:dkim-signature:from; bh=t0JCjBgen9T+Z4oCW+oTSaQk4Wa0Xdp8KU026VvxSh8=; fh=INXzFuQB2VNR5wUO6i1uPSfOySzGcP4XnxC6abHPBps=; b=y49nLHsjYK4Yq6PzLfU7syC7DCE6f9qLRQugmCAs4xQDh94fXDnvW0nrhyFEIP3cOG GiLQaS0QL7MIpYpS4y9xTWxUDbWyitSkYN28PFem6/knmX8af7wjhBmF+AMZe2AHR/oj 6KymAdmGm5ABs9nMSq6CWKoxZ8eBR9Ea0Dx7/DmbRdBWuh94divmWfff/I5px0WFDZe9 0Vd8HXd24Lokylve2/VBz0dEQdGB5VJLKgsWnKzA2J0rLJM70oKQCPF/E7bMNEqfD2AJ RFK2DoOWQ5BjcoZ/15hBnJX8gQrVqUc5Zv6Z6nBS3VjUetI2aFlhOYC6CW9bEniufjLo ityQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@marliere.net header.s=2024 header.b=rcrxDTzG; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=marliere.net dmarc=pass fromdomain=marliere.net); spf=pass (google.com: domain of linux-kernel+bounces-88879-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88879-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=marliere.net Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id w1-20020ac87181000000b0042dd20db0c4si3758404qto.386.2024.03.01.09.59.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:59:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-88879-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@marliere.net header.s=2024 header.b=rcrxDTzG; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=marliere.net dmarc=pass fromdomain=marliere.net); spf=pass (google.com: domain of linux-kernel+bounces-88879-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88879-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=marliere.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id DDB991C256DF for ; Fri, 1 Mar 2024 17:59:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 70F1D2574F; Fri, 1 Mar 2024 17:59:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marliere.net header.i=@marliere.net header.b="rcrxDTzG" Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED59F8832; Fri, 1 Mar 2024 17:59:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709315944; cv=none; b=nGX1hmGhwKW3jil1HfNfs+RC+Uh9JXgownBwHUIGPb33xqfh8Y7rZeBFfgUMkH8IPZ3QMoEHl0Tv/vvpQYNn6p4cl2AMT40jdpHFudwIA6wwqXH3VY/d1F97vyi+TsHP/lM28l5ZcUMapf5tvY3r+Zxhgd6AtgZwDjCJdWDpK8w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709315944; c=relaxed/simple; bh=QOTGaSpwhyzVgUsvkZDcc1FNEbwACrnC2LiBzwfA9CE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EwEHW/SOaNUyZ3+623yaW5IFFIXKZdzEV2uzzqKomgZ/3vrOY+l2UgT/DNAThJzXq3XXfs9/6xit5t7T1gOm3NrhIir6Y+L7d+sNV+r+2D/d8P7gIi3szwyyOOhV2TjSB2zLWRqv1JBUKIZrdW8mEUzAYZKbIDwmuOgAkj2zygE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=marliere.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=marliere.net header.i=@marliere.net header.b=rcrxDTzG; arc=none smtp.client-ip=209.85.160.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=marliere.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-22007fe465bso1259976fac.1; Fri, 01 Mar 2024 09:59:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709315942; x=1709920742; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:dkim-signature:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=t0JCjBgen9T+Z4oCW+oTSaQk4Wa0Xdp8KU026VvxSh8=; b=T+pgwlJfwLWZ7H53bqV94mr3vZ0wBq51cytsp2q6aLNjolBd3bNHC8Ox1MZ5PNO1sW E8V5QMVuAX73NKE6Czb9+m2620R4bhUxnaBWwfa+aosFUfcnZHMItX0WeqKrBrqMDwmp BBA386lUXATiHsQAv2Pd/jCl08MUuhehD/hf6VUfIKWqckREB77n2E9unWQ1BWXssVDi 6DdWcG4kCuBlXCRW/wbDS+m8Iuas+XNtMCA1C/jRImr9nl29QayYm6qMSjdzsMaQpO3y qQRG/8K+y7DqDo7si/ydOXjeE6mV3gPTBrM0P8ubxmb7F8Vii6gPgCoH7nRjTh+u0zVT Em8Q== X-Forwarded-Encrypted: i=1; AJvYcCWLMZNpdbKyTw7168zzMOMYmD7Riy9W8UKtafPbTHsFOdMYslhvyQeYyPS+KmWkP6VaV9z4cAdshg+qnweI7rMB3L0V6wXHK61+EVyL X-Gm-Message-State: AOJu0YyLGhueZTP14ilKkczoo62gALGPDFOq6LhUvfIwDRnxp6Ej+lWt RUS1PjLtCTuDLFc+Fo16XRrawV3Ld/7NcDDqbhx7JLnEuiz07Do9HOqyBiU21NE= X-Received: by 2002:a17:90b:3a8a:b0:29a:e095:25ca with SMTP id om10-20020a17090b3a8a00b0029ae09525camr2351111pjb.6.1709315528037; Fri, 01 Mar 2024 09:52:08 -0800 (PST) Received: from mail.marliere.net ([24.199.118.162]) by smtp.gmail.com with ESMTPSA id o8-20020a17090a744800b00299d061656csm3470300pjk.41.2024.03.01.09.52.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:52:07 -0800 (PST) From: "Ricardo B. Marliere" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marliere.net; s=2024; t=1709315526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=t0JCjBgen9T+Z4oCW+oTSaQk4Wa0Xdp8KU026VvxSh8=; b=rcrxDTzGQRg50a9vKqyasLgGJUcG4unMAWjzYGC2uIoiH+94ZvEltXXZwH2hJX5/0Hja92 1/ibu6o/DCZrkWVdTpFNjOCuCqWjAMxqGeNpuHUhZt5s1qQKNsW+L0d8bDW+qJfJJ7UZvK e5Nk46UF1OyUFE8PWHdka+6firuu2U6b9Tm5XFQ7FTi3UTTBjYXFKivO96f7jf4UahtfkK fYWdkTZ8Q8HzUPxi3QAOtDif8Mwt6rwT8pesHqpfy52R/BSiRz/JcToJa/i13eQVJMsriy y0XX8XS+e5ixy+uTjT1TOIk2n8FenHEWlShFKk9nEC0nZIB38X4rH9Ni0TawHA== Authentication-Results: ORIGINATING; auth=pass smtp.auth=ricardo@marliere.net smtp.mailfrom=ricardo@marliere.net Date: Fri, 01 Mar 2024 14:51:47 -0300 Subject: [PATCH 1/2] vfio/mdpy: make mdpy_class constant Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240301-class_cleanup-vfio-v1-1-9236d69083f5@marliere.net> References: <20240301-class_cleanup-vfio-v1-0-9236d69083f5@marliere.net> In-Reply-To: <20240301-class_cleanup-vfio-v1-0-9236d69083f5@marliere.net> To: Kirti Wankhede Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , "Ricardo B. Marliere" X-Developer-Signature: v=1; a=openpgp-sha256; l=2192; i=ricardo@marliere.net; h=from:subject:message-id; bh=QOTGaSpwhyzVgUsvkZDcc1FNEbwACrnC2LiBzwfA9CE=; b=owEBbQKS/ZANAwAKAckLinxjhlimAcsmYgBl4hXBYeVot8eVXHzLqykBejOqmsm9QFOv/s67Y Xu62kjEvEOJAjMEAAEKAB0WIQQDCo6eQk7jwGVXh+HJC4p8Y4ZYpgUCZeIVwQAKCRDJC4p8Y4ZY poyvD/950Ln4ZfxTSOEvm1tD+XpYlekFPUKNK2xXudVHiiZcgvGVYgiEAM8wC9GQ77ruJFVpFQT JTBXKEP3Briko11JT8KRWajB302V+vGxDLR1iK5DzEJWKLV2YaTnjgK5Aa+ZS6bdAMULKAfcre3 2r95CYrLwil5dUwLl65uCazc2f/3xXXzGqWtZ8ROijOPgEfwuS08AnFc3qGmzgzh0xbXGrbd9Fp JcyoGQWNGkoSwvR1TcdMKgUJevb4LzANofYuPjJjxa/Md58O2332QOhK99F6kAdg7W78UMUE9Gn GJDF1Hh3E61KaWok52Qt5/1ABpf1/uucuAux+hxLwZA+oFIfj5zO3mYIZUxtlOWyf3tGLCFrmRp J/H+fN2L0mR43O940QyKUh49ineyg1MvDAQkY4qZM85M5IYSLVklh9JOax7UlrkB1kwlIRJdvfX lnSr1yHUD6HdXC1IvZRLfT3xJRMpBzIFHrhx/G9ktn73XSoR61yUKN2BoEiLV4oZqBSMHPqT0// ocjB1G6DbfXPgmWgqPPiRXQG5urDIdg8NlSsq7hK2x1K58TxOAz+pYrrx5huTPYM3KmRtUK7gEU vMv8ZC6Q+FP5PBpHDOST8E4FBCB/UuoJCGfC+THO+36GNz1u+e6LATNjAQ72mpJ8k39EdchZmTD q++9edw1DOLpEDQ== X-Developer-Key: i=ricardo@marliere.net; a=openpgp; fpr=030A8E9E424EE3C0655787E1C90B8A7C638658A6 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792347700810707282 X-GMAIL-MSGID: 1792347700810707282 Since commit 43a7206b0963 ("driver core: class: make class_register() take a const *"), the driver core allows for struct class to be in read-only memory, so move the mdpy_class structure to be declared at build time placing it into read-only memory, instead of having to be dynamically allocated at boot time. Cc: Greg Kroah-Hartman Suggested-by: Greg Kroah-Hartman Signed-off-by: Ricardo B. Marliere --- samples/vfio-mdev/mdpy.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/samples/vfio-mdev/mdpy.c b/samples/vfio-mdev/mdpy.c index 72ea5832c927..27795501de6e 100644 --- a/samples/vfio-mdev/mdpy.c +++ b/samples/vfio-mdev/mdpy.c @@ -84,7 +84,9 @@ static struct mdev_type *mdpy_mdev_types[] = { }; static dev_t mdpy_devt; -static struct class *mdpy_class; +static const struct class mdpy_class = { + .name = MDPY_CLASS_NAME, +}; static struct cdev mdpy_cdev; static struct device mdpy_dev; static struct mdev_parent mdpy_parent; @@ -709,13 +711,10 @@ static int __init mdpy_dev_init(void) if (ret) goto err_cdev; - mdpy_class = class_create(MDPY_CLASS_NAME); - if (IS_ERR(mdpy_class)) { - pr_err("Error: failed to register mdpy_dev class\n"); - ret = PTR_ERR(mdpy_class); + ret = class_register(&mdpy_class); + if (ret) goto err_driver; - } - mdpy_dev.class = mdpy_class; + mdpy_dev.class = &mdpy_class; mdpy_dev.release = mdpy_device_release; dev_set_name(&mdpy_dev, "%s", MDPY_NAME); @@ -735,7 +734,7 @@ static int __init mdpy_dev_init(void) device_del(&mdpy_dev); err_put: put_device(&mdpy_dev); - class_destroy(mdpy_class); + class_unregister(&mdpy_class); err_driver: mdev_unregister_driver(&mdpy_driver); err_cdev: @@ -753,8 +752,7 @@ static void __exit mdpy_dev_exit(void) mdev_unregister_driver(&mdpy_driver); cdev_del(&mdpy_cdev); unregister_chrdev_region(mdpy_devt, MINORMASK + 1); - class_destroy(mdpy_class); - mdpy_class = NULL; + class_unregister(&mdpy_class); } module_param_named(count, mdpy_driver.max_instances, int, 0444); From patchwork Fri Mar 1 17:51:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Ricardo B. Marliere" X-Patchwork-Id: 209005 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:fa17:b0:10a:f01:a869 with SMTP id ju23csp66191dyc; Fri, 1 Mar 2024 10:23:03 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUOG+7sDdIWaYKd6/pH0ohrIlvQ1aK0sBGbsacqBVfR1fjqe8E3zArRNfylHWY4OiyM3oA0gXgklTMH9CgLzi9CqDn7YQ== X-Google-Smtp-Source: AGHT+IEO2cC/80nXMrRrPRrlH24Tj2X+EGSQixRrVNL9d94jBFM8F8fRVzn7fyQ2uhFz1L/IiXCi X-Received: by 2002:a05:6830:22c2:b0:6e4:8291:c167 with SMTP id q2-20020a05683022c200b006e48291c167mr2540269otc.9.1709317383153; Fri, 01 Mar 2024 10:23:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709317383; cv=pass; d=google.com; s=arc-20160816; b=zcEizCNDcZgAMEhs8WoPLTQSAwUdh4H8IUseOm/2O7u39KDVOmsaQP/3hMDDCsfyve hfu52bfLTM8PyhHKc3HsRKBZgYR7/kRjwMVzIV6+E5Er/CaBxNvz0zXfsqMxJhg3cihV RmM0/4t1BQnxoJ5tIgDviNK6FBed1b33pic1bBQRomdT0Fh98DqtaXEzVXstX9V8uo1P SYvmztqvBTlz+ZfT3+BfppXdtc3auoOlYCw2G+MvA2HkoqH+IXjtYG6uxVwsYPuQDkXg RH1moGZvJUjxfXo38k8pl3+6bIjBc+Km00O0QpCav1Xvl8N5w5sS67iHvACAu6qtGW2x pDiQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:dkim-signature:from; bh=3fSwou6xt3dExdHJRnwmg3us69187dtr8XYCTXv/VKA=; fh=0q19SYKWkB2aV04+H2ukfQ/2EyQLajV8Vm+i1U+28Qc=; b=TE7aRaejqt+zAkuZ6r+QH3SkjieOSv4qR8hmXJ1t8sUxAcux3Pf0n3scjN8k3GIV8B /CHNJWKV0HT2cSiK6xzSIW8zwnX/36fc9wZ5xbeVn0kavlRSqwHAsrszA5l6MwZTu+nP WA9uRVKQnHu1Wn88jKtmWxn4+XeeRB4EPgkvpWsX5CFA22GOLkeq+ycTVab1EvmuWrXA ahg2gnqFG8KJgGl6COWwUnu7/yHcwPvCTR2XdKB3gI2yztJ0wERdAl5yqrZdZuIqySeF vxNTcZyUf4wcTrfRDS8oMaM+OHdSHjUhTuCtgCEyif0KTMXBebfJgY3P6bdHIA03NDCv 74pw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@marliere.net header.s=2024 header.b=Am71fGyX; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=marliere.net dmarc=pass fromdomain=marliere.net); spf=pass (google.com: domain of linux-kernel+bounces-88869-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88869-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=marliere.net Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id c21-20020a634e15000000b005dc82a6d761si4053724pgb.123.2024.03.01.10.23.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 10:23:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-88869-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@marliere.net header.s=2024 header.b=Am71fGyX; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=marliere.net dmarc=pass fromdomain=marliere.net); spf=pass (google.com: domain of linux-kernel+bounces-88869-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88869-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=marliere.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 20A3EB2A446 for ; Fri, 1 Mar 2024 17:53:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8E3CF39AFE; Fri, 1 Mar 2024 17:52:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marliere.net header.i=@marliere.net header.b="Am71fGyX" Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 070F539AD3; Fri, 1 Mar 2024 17:52:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709315533; cv=none; b=l1BFHIhqvLH7HGZLFOYdqs8WpVE39kkw/Fcc4vW5CA86cByP4fP/2825aKQp5GWUIRuPExQMsVmU4krNZckExVW7H9P2tcSokVUpEo6QuNYL2OA82Qe85auK+cuHvUd3YrUL+Va6YO5GJd3QFvq978DliuHO4TI06ILNNmAnwdA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709315533; c=relaxed/simple; bh=kfcUvj9kAZj/9cAeKt7pZM4JsSAycxcMC3/xnor5M2w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qJ1e+gbyf6n/o6SNZbx11hg6qDzZBHgudrl2Dx4btizRFlHVINIQt76FTMILiNN2npCmLgGlDnEDuW6c2EuIy581Ln/Ot0dHwUNfpzeFfPNSd1VmekmjITdjEFFRocuwsFxHrC3kmRotE+fzIm2RknEu7dfNl3gFd50f2QYidcA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=marliere.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=marliere.net header.i=@marliere.net header.b=Am71fGyX; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=marliere.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-299c11b250fso1668369a91.2; Fri, 01 Mar 2024 09:52:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709315531; x=1709920331; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:dkim-signature:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=3fSwou6xt3dExdHJRnwmg3us69187dtr8XYCTXv/VKA=; b=qK6BlrVYZamEPoWRxJkYqFBVcOJn8TBFGBNb3q/7LnZCL9u+roSsyEHMPKS39vEJSp i3010HK6T/4Ft1AED2Gb1cLEkti2eNrUqatV5pjM6aurJ+KYmAnnvIu5JyCurvmHqI1G c/4XljN7ZCRnq4nW3ww6qzGSmkKHGYlvfcei5Mfy9CPzMmFXawJrm/8t88UpitOZTbOy Y6yWUIPQugrisATeT4uj2omBwB1pEkoiXawTzyxODqOL/isOjvuVywDfRE1LybXKC2JJ IUIRHKqAIlhjb9+RdUdZg+NlfyLpaCfditgXWJd6sNZMBc+lIXyHwNw/W68Gxp16VfE/ xkRg== X-Forwarded-Encrypted: i=1; AJvYcCX4F6YMIix+C5eqPIdBPIMwbjKwu1mEnfx8merGejbWk2k3JT/DhQ9dOefN39sdT8z23WnvS3BgNKejQ/Clg5Apd7ee67PLMY9NKSa1 X-Gm-Message-State: AOJu0Yz02CdL/4xBkOglALm3IS0d+aqdQzSH4zjjQWlTDxqsjBP5kfUN V/yJExUFwrnmG9kU0xXUawt4+UeDuq4nfykEG5hrQETAxMOuiu5LybK1EuiNRfI= X-Received: by 2002:a17:90a:a205:b0:298:c136:2ffc with SMTP id u5-20020a17090aa20500b00298c1362ffcmr1972257pjp.45.1709315531163; Fri, 01 Mar 2024 09:52:11 -0800 (PST) Received: from mail.marliere.net ([24.199.118.162]) by smtp.gmail.com with ESMTPSA id fv11-20020a17090b0e8b00b0029937256b91sm3544186pjb.7.2024.03.01.09.52.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 09:52:10 -0800 (PST) From: "Ricardo B. Marliere" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marliere.net; s=2024; t=1709315529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3fSwou6xt3dExdHJRnwmg3us69187dtr8XYCTXv/VKA=; b=Am71fGyXhnBVQkUwxLbL61KrwCmM4prTobqvybq9KuBXIX/XBHlBHsLMfcRj6QcQa5DW4O /qajksRy4GozMB9llf/BzoKJK/oSwUWE2niVob8nbxAgSfITFaKAqwm8jevYeig4JCO78v YXMJk/8+ziyS74ycAfB+SgrYyS8HK1C2J7E1wP2ji2ieuOyNMFepRFy1CCFjPjSbrpKnKW f1ljp5DtfHmQFAP8aXqZ1y2ACDrzAyRaq2OglI9Hu+mJCjW5X67PfY4bfBNLL8nDDuGEdZ zwNUke0mpm2IGKRQk11rW9Y6tMsZwj2bgmaDia11qjfS6zRXwkFd2psrx3sjmw== Authentication-Results: ORIGINATING; auth=pass smtp.auth=ricardo@marliere.net smtp.mailfrom=ricardo@marliere.net Date: Fri, 01 Mar 2024 14:51:48 -0300 Subject: [PATCH 2/2] vfio/mbochs: make mbochs_class constant Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240301-class_cleanup-vfio-v1-2-9236d69083f5@marliere.net> References: <20240301-class_cleanup-vfio-v1-0-9236d69083f5@marliere.net> In-Reply-To: <20240301-class_cleanup-vfio-v1-0-9236d69083f5@marliere.net> To: Kirti Wankhede Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , "Ricardo B. Marliere" X-Developer-Signature: v=1; a=openpgp-sha256; l=2246; i=ricardo@marliere.net; h=from:subject:message-id; bh=kfcUvj9kAZj/9cAeKt7pZM4JsSAycxcMC3/xnor5M2w=; b=owEBbQKS/ZANAwAKAckLinxjhlimAcsmYgBl4hXCwCK01v+8S0gdV4sM3YMc1mAF8GxnrRFE4 mI8WpIdMZuJAjMEAAEKAB0WIQQDCo6eQk7jwGVXh+HJC4p8Y4ZYpgUCZeIVwgAKCRDJC4p8Y4ZY pmzPD/9CSgY5d37IQI+Rat+I8KYGGdVslYoE90SWUu3GVsRK/ErLjgIlczVazViuFIRTODOv5Xp n78cl1qqUCsJ0Wcppmq4w+Abn+0SXukCqgzT6ljfpAadtb7hGm8wTLi08eagyDSJYQZ3kgej0vF 4v4G+dsV6AI7WBY1Bwf3GiphBoIPou5nCukJES9hyK8Ds6tpbcOuHa3yK98756h1XVM/roT3lnj WYBhho0t2/eEO7JZkZLcs7uyC/Yfsn593jt5XZI/lSi8ft9DBNB2NBjXO0k4vSX6W3NLsJO6PR+ XrnrnIMb2lkoU+bt6u+L6SwwPP+KUQGu0hrbrdR50Zz96T+Zzsm1sj8tyXDEXJZUmQ0L8o3vZBu pKI96xrHqpyl3RkjmnK6Gw5AT1leeBPxyZHH5dSQG5l1FYGrZR83B9W3Vo4wSXl9UKiLSgG6S+9 UviebAUUeANS7/RnqLAe/nzeiF4FMfQCQhDO76rfh8gRzJGOWqLkXRlo7eMnQ7xlAnT6Wh5Lzfe zETorVj6l9DbOKIB3WaJ/RtciRWxhBa/ZvJJxmbxBGnVWGyU1K2JSZBQAo+I+JXxXPm2+1rG+zH ntpi7NGAjTCMyPX4G/uNRtYcpBKnPVoySuQdq2GZjGRKKUPYvVLFx37YEUCxWiUk1sdCmYyVBJk t6AA6cMNz6914iw== X-Developer-Key: i=ricardo@marliere.net; a=openpgp; fpr=030A8E9E424EE3C0655787E1C90B8A7C638658A6 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792349184128603051 X-GMAIL-MSGID: 1792349184128603051 Since commit 43a7206b0963 ("driver core: class: make class_register() take a const *"), the driver core allows for struct class to be in read-only memory, so move the mbochs_class structure to be declared at build time placing it into read-only memory, instead of having to be dynamically allocated at boot time. Cc: Greg Kroah-Hartman Suggested-by: Greg Kroah-Hartman Signed-off-by: Ricardo B. Marliere --- samples/vfio-mdev/mbochs.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/samples/vfio-mdev/mbochs.c b/samples/vfio-mdev/mbochs.c index 93405264ff23..9062598ea03d 100644 --- a/samples/vfio-mdev/mbochs.c +++ b/samples/vfio-mdev/mbochs.c @@ -133,7 +133,9 @@ static struct mdev_type *mbochs_mdev_types[] = { }; static dev_t mbochs_devt; -static struct class *mbochs_class; +static const struct class mbochs_class = { + .name = MBOCHS_CLASS_NAME, +}; static struct cdev mbochs_cdev; static struct device mbochs_dev; static struct mdev_parent mbochs_parent; @@ -1422,13 +1424,10 @@ static int __init mbochs_dev_init(void) if (ret) goto err_cdev; - mbochs_class = class_create(MBOCHS_CLASS_NAME); - if (IS_ERR(mbochs_class)) { - pr_err("Error: failed to register mbochs_dev class\n"); - ret = PTR_ERR(mbochs_class); + ret = class_register(&mbochs_class); + if (ret) goto err_driver; - } - mbochs_dev.class = mbochs_class; + mbochs_dev.class = &mbochs_class; mbochs_dev.release = mbochs_device_release; dev_set_name(&mbochs_dev, "%s", MBOCHS_NAME); @@ -1448,7 +1447,7 @@ static int __init mbochs_dev_init(void) device_del(&mbochs_dev); err_put: put_device(&mbochs_dev); - class_destroy(mbochs_class); + class_unregister(&mbochs_class); err_driver: mdev_unregister_driver(&mbochs_driver); err_cdev: @@ -1466,8 +1465,7 @@ static void __exit mbochs_dev_exit(void) mdev_unregister_driver(&mbochs_driver); cdev_del(&mbochs_cdev); unregister_chrdev_region(mbochs_devt, MINORMASK + 1); - class_destroy(mbochs_class); - mbochs_class = NULL; + class_unregister(&mbochs_class); } MODULE_IMPORT_NS(DMA_BUF);