From patchwork Thu Nov 17 07:35:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 21488 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp264406wrr; Wed, 16 Nov 2022 23:44:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf5SCU0QmuRo1d5AoZyJfR/nVCdxfZ8V1OCLKB4Rx08oZLEYzfk4XU6oT/PsbT4Kqgj347Sb X-Received: by 2002:a05:6402:1744:b0:459:2d37:dfbd with SMTP id v4-20020a056402174400b004592d37dfbdmr1113345edx.336.1668671059048; Wed, 16 Nov 2022 23:44:19 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1668671059; cv=pass; d=google.com; s=arc-20160816; b=ToWDigOdkBevaFU+LThK9LXAZzzMsj7Z4DYrizfkkZHvOLWcW6JwRx/UDow/uFMyYj t+9JZSJuL2+7rHOaeSUGnbFHBAFOhRXTTpgqD+mmuq8fe1CsacldddaQwjF5nNmQBjNa t+pVi9Z5LLpwHhIEASuGoZGCv3rT3Xd4P+xWcoRVtjZrwj9+O6JIGUSjem4RlE8Menpc BgF51beWCNiWhHQ+0A8IQR46UtyFIV3ah+OiXtSOt85Uw4GshQRvGYjg5wKsU2Ps7Trv NmpltWHULXTEv4NFShqiI5r0iOvTtqWmg2G/F8fCh8qGKFrcyvz5NAFciOvbjTs85sFW 6LRw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=uH2vHdND+rpaickxtwrYN7XcES8PAQW96yRrcD1vcN4=; b=JTKsVMVg6bSLj7uz/bLGoQ/4gmz0KFkIiOaH4Iv8ttZ6h+vU1ib2Cm82994uSEhh0C /IBl+jrPo1pEs1LGh6khS0SmLbWbrwcRE0/YyTWkampNlW7ajhMd99Kn4/2KYsKYEYtL oQvr20iHglR/nEHfBTNzJNpH4UOnRKXHgZNo05LfKDfYUsItWyteiIlpSMEaZUmOl8g+ +THGzc9FRpq8zrsX/HDv9EBNmE8mrt/FT9MvIIZRDyNlSY6I/pHSJRy2fK2lpF2SvTPW CBNQFN/mdjvz8dyAVZ2qOi+QKG5FI8QgMMH7FBuHHuCprTzcTyGs7sm7bsJum4feh4zo MOjQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=pIKrYPEa; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ht20-20020a170907609400b00782035a06b4si35054ejc.200.2022.11.16.23.43.56; Wed, 16 Nov 2022 23:44:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=pIKrYPEa; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232281AbiKQHg1 (ORCPT + 99 others); Thu, 17 Nov 2022 02:36:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239382AbiKQHgQ (ORCPT ); Thu, 17 Nov 2022 02:36:16 -0500 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2050.outbound.protection.outlook.com [40.107.94.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86050701A2; Wed, 16 Nov 2022 23:36:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lqcETzXaxQ7e4M3WdNVVUhOaY0VnoqKIansmLrS2RJwTj0wYplkvl+HQ6JfPv5EVq947eVaCmfffVcIakoWwdKFw5HtZWRnyx9cZeRAxmidZH7o+WQfF5TgVOcdmryem0utzExQpyYRcze+NCSwTazbh6vEP+GM+qpsprBQkqA7cUp1kAK07n+6FaMikiwdxny7qMnoOzZnwlfNISXfP3KBqMR8jzeWJuAoPYf+GUuWFYCTb/MKbMZE3ornWBNXYNLaIyoorOt+NJOja7dIiVEgdWu6koB/vSaG6ZCWRvZbklG7B/jwni/MiIzfVs32HX5u2Uzcuef9vKQ6TnrNMGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uH2vHdND+rpaickxtwrYN7XcES8PAQW96yRrcD1vcN4=; b=dUKFp5qupR6Y7B9SiTcqgmDMmcYZjcGvHqr1k0GNGnnkFhg5LZ0YwYlwklhkWr4zjdYqx8ZjsYrQmbky7ruTkvclh0QE35oTl7PpshGvoYvDcbRqbntvOcF0cUG6HQXBQJgIioFMFWgfx3zZnH56a3nCDWYwjc4lJpzj7ZjISGls/bh1BcGtnkRR5Xoc+Q1eSu7+kK8G7laS93xK5mYpyEZp/kRfFXV88vuB7HZePxNovt01nShMYmSMvxSw0Kx/ezPUeSizyKXT3mmxSMZunbkQxHA/ii3VA7Wyq7V4RtCnQrO5civWDTTNR4YnoBwsusS3sXncocLH4XVs+MDVbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uH2vHdND+rpaickxtwrYN7XcES8PAQW96yRrcD1vcN4=; b=pIKrYPEaUyXRRjNHWR6nAAkqCtkcW9b72aARGZ5w6gPysQ8e0wK6R5Red4wiYJWsuz6PSDBnTTvMkTYuPoF1lxDLA2FvFohcJkXVQRc65bFa5mtCA3KHqkCgJKJwb20AKrdukIc9mKV/Ymxs/xg5OibD9W8wRka+QTVVS/8P120= Received: from MW4PR04CA0160.namprd04.prod.outlook.com (2603:10b6:303:85::15) by SA0PR12MB4573.namprd12.prod.outlook.com (2603:10b6:806:9c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20; Thu, 17 Nov 2022 07:36:14 +0000 Received: from CO1NAM11FT055.eop-nam11.prod.protection.outlook.com (2603:10b6:303:85:cafe::69) by MW4PR04CA0160.outlook.office365.com (2603:10b6:303:85::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Thu, 17 Nov 2022 07:36:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT055.mail.protection.outlook.com (10.13.175.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 07:36:13 +0000 Received: from pyuan-Cloudripper.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 01:36:08 -0600 From: Perry Yuan To: , , , CC: , , , , , , , , , , , , Perry Yuan Subject: [PATCH v3 1/5] cpufreq: amd-pstate: cpufreq: amd-pstate: reset MSR_AMD_PERF_CTL register at init Date: Thu, 17 Nov 2022 15:35:37 +0800 Message-ID: <20221117073541.3350600-2-Perry.Yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117073541.3350600-1-Perry.Yuan@amd.com> References: <20221117073541.3350600-1-Perry.Yuan@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT055:EE_|SA0PR12MB4573:EE_ X-MS-Office365-Filtering-Correlation-Id: d1046258-238a-4416-57aa-08dac86e67cb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YwneT5QstTR9I3uj1JlRLqzf6RY3wZKKBA2TP7U3a6BwLxJxXHQerkJz9JAclmVR3JF22eb2U/JWG5ziBvpFRZAf/iz+bhXQasucPGFhQHBzxoAxB/cqhD18cz9xb1CzFyz34LkVJ/F0jh7I66bLV3bV8gNpTymRNzVgFusojEIB3/lFIoGbhrPkbNB5y4f4ZSTzoIOk0bkdJspmDOe01k0/c0m8/mJ4lqVdaH85JbQbBljp+dpPoxjDKCeVCmNl5pHRvvKSrJ3OeWO744E0r6wMwTzr/6uLp8MD6FtQG5GvMw/aUxMMvc/Y1z1vX8gkhmOB+tOfQ6rIAY0MzLZIyz8mOZBFPHRhiscVbPhQt0RYFzMHOZGY3Ki8/cH0hfgAhRoRgfur22dxMUFSI5WiCJFH6zHBlhbeD6J/+LGi6B/KQ7HdkXXFmR+ST0qQPT4XMf8i578N3MVuz7NYk8h6YXScIFOLAT6cX4aM38oi6hhr53o9nmqA3a+8R0axExKfWyLf7Gg25ivahPSNRuQezgabipIrBOIWmEfENPLKNXMuW2n/TVaC/B2jgMKqTk3mGMgLYhYDjYfJ2lTS+pDuWFh44MEa3gvba2cHUEFzl07URYgqhDnyoWROXVwP1ukf+nLaCZuJ3y+uJEtpG7/DYmtn/v3mdvG7wRbl9Hd4C3/+Ne05hNpGKJ6sqr67doB/wyhuzEECDiuLbYY+9O9GUq5A1VeqDEk4rF5Z4TrwE34Twt8xt9qnXbXPgeWUe05y X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(39860400002)(396003)(346002)(376002)(451199015)(36840700001)(40470700004)(46966006)(5660300002)(16526019)(1076003)(186003)(40460700003)(336012)(7696005)(110136005)(54906003)(316002)(6636002)(41300700001)(2616005)(8936002)(70586007)(26005)(70206006)(36756003)(8676002)(4326008)(82310400005)(36860700001)(81166007)(356005)(82740400003)(2906002)(40480700001)(83380400001)(47076005)(426003)(86362001)(6666004)(478600001)(66899015)(36900700001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 07:36:13.8121 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d1046258-238a-4416-57aa-08dac86e67cb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT055.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4573 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749728424737713236?= X-GMAIL-MSGID: =?utf-8?q?1749728424737713236?= From: Wyes Karny MSR_AMD_PERF_CTL is guaranteed to be 0 on a cold boot. However, on a kexec boot, for instance, it may have a non-zero value (if the cpu was in a non-P0 Pstate). In such cases, the cores with non-P0 Pstates at boot will never be pushed to P0, let alone boost frequencies. Kexec is a common workflow for reboot on Linux and this creates a regression in performance. Fix it by explicitly setting the MSR_AMD_PERF_CTL to 0 during amd_pstate driver init. Cc: stable@vger.kernel.org Acked-by: Huang Rui Reviewed-by: Gautham R. Shenoy Tested-by: Wyes Karny Signed-off-by: Wyes Karny Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index ace7d50cf2ac..d844c6f97caf 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -424,12 +424,22 @@ static void amd_pstate_boost_init(struct amd_cpudata *cpudata) amd_pstate_driver.boost_enabled = true; } +static void amd_perf_ctl_reset(unsigned int cpu) +{ + wrmsrl_on_cpu(cpu, MSR_AMD_PERF_CTL, 0); +} + static int amd_pstate_cpu_init(struct cpufreq_policy *policy) { int min_freq, max_freq, nominal_freq, lowest_nonlinear_freq, ret; struct device *dev; struct amd_cpudata *cpudata; + /* + * Resetting PERF_CTL_MSR will put the CPU in P0 frequency, + * which is ideal for initialization process. + */ + amd_perf_ctl_reset(policy->cpu); dev = get_cpu_device(policy->cpu); if (!dev) return -ENODEV; From patchwork Thu Nov 17 07:35:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 21489 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp264550wrr; Wed, 16 Nov 2022 23:44:51 -0800 (PST) X-Google-Smtp-Source: AA0mqf4OJnpVB763FSTXOZfuBttu3PopwaHf9l8u/NTFwxXNMpWy0+UwoBGiSwIrtLJvcAr8u7TH X-Received: by 2002:a05:6a00:216e:b0:56e:7b62:bba with SMTP id r14-20020a056a00216e00b0056e7b620bbamr1780840pff.55.1668671091242; Wed, 16 Nov 2022 23:44:51 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1668671091; cv=pass; d=google.com; s=arc-20160816; b=M/FWeG40xXmTawCGqd0WvmnU9oI5n0nJ8HJ6PurpVaVa6Q1ZnPVyrvbCbV5tBkThag BlvUUZygYB33R9DainB6JEqwzPIBeaz+wnjXr1rTz/xzSMvd6LxuePRJBI0kf9lg5aOF fYVFhiMwUJc4oOwqN1KrtGUTW+5O+MXY4/zAwGsbbpge6QyZO3tF4ysUy8xyOJgsH4gj RCeXa7U9/DkHZJ7ehZHW3qsUe/EIVStDYeTQ1YDNXmwjr34pF2flvHtP73Uj+Ok7xGOC NwnGDhoR9+2s6rPw5q/w71Sz1Nz4MsheEbxNGxIrJ6Kmo31RmTbN5TEd1iZpXJ60uw1u 3efA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ORp+8ilCI2XEPpqvjSOMPFxkMyHIu+gSn9A/OobDhBA=; b=xqOZ3z7GjDrj+AIL4Sr/KNAg2sh9iY6SBMgxs62swMsGC310xE60gMv2V1Z30Z5Fr1 DR5yTN2j+P3xPnPak3KlOPBG1SUzgFcKaSw7tO0QtlbtHeSH/GchPZTc+OWzkHj0WzTf uyD3unFOtl/wEXRbZzgfQh/JQRhIdbcmwQ63yRvfYyGECwkcZicKCuzKbdTHHmE8Z/jl LUMw5h21+MZ+T0GUZIlmdCUSeUut6LO8Jlpg5HRK76YgTd0FwUuY1KH9OgvPbU4RKryJ dJt/vmCFwHvp9Vb6EAFBz7pObEU80kuWj94JBqM3LFhQ94952ySS8LJuhs+VQig65HXb G2Aw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=DZJPTX9Y; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a15-20020a17090a740f00b0020a1c6bb23csi3615403pjg.74.2022.11.16.23.44.38; Wed, 16 Nov 2022 23:44:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=DZJPTX9Y; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239382AbiKQHgo (ORCPT + 99 others); Thu, 17 Nov 2022 02:36:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239393AbiKQHgY (ORCPT ); Thu, 17 Nov 2022 02:36:24 -0500 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2078.outbound.protection.outlook.com [40.107.244.78]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F35B56A69B; Wed, 16 Nov 2022 23:36:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gF6JHRoWfKDpJt6s7IbHWENiZPUOsdbH2iKxsVZvjUcCkAGwsDpnqmbzXepi5u7XE9sybL42iEOXAUBjqo9tObyQ9vQ53LJmPj+Z7iIfFpZqO8j362iC8xTa2ErWwmi/MpUH+spSX73EqoWoBuDPkp7ZkpFfVMEghn3o/cDrDi6EZuqBelol/9hb/jIIX2xYR6ntJEYRdNw6ya8yH9R8wd4rYzqxvOPBKl/DlRvLFv06pS0tbTTLV4fOaCHH9uqzrtstsShVtZfJ3sHZE3jTRmVaCe3451Dm18mbM5+mFcScm57tJDkrDcVditxZ3VrN0Cq0xOQE22M1tLQI8pm6Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ORp+8ilCI2XEPpqvjSOMPFxkMyHIu+gSn9A/OobDhBA=; b=WQyKsGuSOnNeZ7eohQY1Hp8zt3l59+WCsoF6WJqjJdfxDMPmgh2fg707gukiY9aGPnyVoZivyaGzRhA4WSqRjZf+9rtR5DsgJvDvorqgXt9V0+IIzcAoRz+0YxaoEVo9Mu+Y+xBbm2NNhDIzQh400qJKwLCuDc7Zl/Rn/aM6R9H8DIwZwqIYdusVlPf5LN8rEbLe6D8OLrP+Xlzfb0fIbQ57NElze9sAbNJZbETXt1oVGh+TYzWdFSNHwlChuYxy+1uueIiESKEzt5oUAPY0A8srbbQkSeIPuKa7AQ/BxaOYISw7Yw9dU/I44ekxWM9Od9LCq4qFu/PH7zt0KbGiSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ORp+8ilCI2XEPpqvjSOMPFxkMyHIu+gSn9A/OobDhBA=; b=DZJPTX9YW9bPRM8S9EVP4HqJVBskdrhQ7oSzLFjCSOesxCgmzCw588d/xJz6vk0rubXmYM2YYqbinY4ddeVImcfM6BdpxvqW7/x1M9HKHO3RUnoO5nzuIGKHD5UwDe8LbK+LVjj9SuvffKTxohbjvhHaJTRp95kkabZkcO+B9gg= Received: from MW4PR04CA0141.namprd04.prod.outlook.com (2603:10b6:303:84::26) by BL1PR12MB5825.namprd12.prod.outlook.com (2603:10b6:208:394::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18; Thu, 17 Nov 2022 07:36:18 +0000 Received: from CO1NAM11FT089.eop-nam11.prod.protection.outlook.com (2603:10b6:303:84:cafe::61) by MW4PR04CA0141.outlook.office365.com (2603:10b6:303:84::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19 via Frontend Transport; Thu, 17 Nov 2022 07:36:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT089.mail.protection.outlook.com (10.13.175.179) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 07:36:17 +0000 Received: from pyuan-Cloudripper.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 01:36:13 -0600 From: Perry Yuan To: , , , CC: , , , , , , , , , , , Perry Yuan Subject: [PATCH v3 2/5] cpufreq: amd-pstate: change amd-pstate driver to be built-in type Date: Thu, 17 Nov 2022 15:35:38 +0800 Message-ID: <20221117073541.3350600-3-Perry.Yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117073541.3350600-1-Perry.Yuan@amd.com> References: <20221117073541.3350600-1-Perry.Yuan@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT089:EE_|BL1PR12MB5825:EE_ X-MS-Office365-Filtering-Correlation-Id: c829a3e7-47ee-4318-4c6f-08dac86e6a16 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aL9ul1yZn4VMJi/kdf/VR4aawDhxtLCX75veG4Rc2qVaMS/BkvMRFdTe9lpZuFMpNvW74S6ELN2RE03MAiVxGUEWW7989yy6WWZqWBgKQtqLi5ZRUTSq3aMyJEwc1aJjY99qFXzuvJFYn/yoek6q2LVU28b0a3V7i+4coiiACY2qWa5vaQHLNx5jywwKDDLUNzjppPFZFoS/CBF3L8PRv1fn+yWJmjcI22WoXJY4kiUXVvxzMZ2d4x+YwDGiHfC9ugShbtFJV68SjMrfqwmJ4ifWlkmEnrTEwCB6b6ngCoDvSRVQnTJRreSdTtqXaccoguKplxBl10TvKFHxqwK0qoAzwLXhyWnlf2+3q6KDPuE0ZmfQWXDeQYINrcJ9JClb1YxQNz0SeFGFLp/p4cY/Xz82T2i7F2HvWkejAtXgya0bT18k/tq4aMCRb0nc9CR+8zevnQL0XjKcJvAHD76j0To/LT2aVQl8+TuuqBxXjQBINU3OWr2JfmGjHXSTOmR6Kst0hn/Us3Z1pLr9Lnd0ewjbQO14KC6HsFwl8tFdTQrZNajrdK+VZo645XRT3WSNYVctWCCAWIz4bIYbI7A3+Go3N/L0DPJNmN0FvB04VC5DjnpwhzA9Axpz1AKwC9beMfshHLznaK3JrvD9he2hKaCGfFERWBHQci2LeOlMDFJD66MMUWQwj3L76YnuzqA5f1f6wLka7eL2LIn7wBHTgq8P5Za3I2WO4b+llv9uVpuSEaXeUpDp1HYHT0SZnLW9 X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(346002)(396003)(451199015)(40470700004)(36840700001)(46966006)(36756003)(26005)(86362001)(81166007)(82740400003)(82310400005)(36860700001)(356005)(83380400001)(336012)(426003)(47076005)(2906002)(40460700003)(186003)(1076003)(16526019)(2616005)(5660300002)(478600001)(7696005)(110136005)(40480700001)(8936002)(6636002)(70206006)(6666004)(54906003)(70586007)(41300700001)(8676002)(316002)(4326008)(36900700001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 07:36:17.6744 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c829a3e7-47ee-4318-4c6f-08dac86e6a16 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT089.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5825 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749728458460648643?= X-GMAIL-MSGID: =?utf-8?q?1749728458460648643?= Currently when the amd-pstate and acpi_cpufreq are both built into kernel as module driver, amd-pstate will not be loaded by default in this case. Change amd-pstate driver as built-in type, it will resolve the loading sequence problem to allow user to make amd-pstate driver as the default cpufreq scaling driver. Acked-by: Huang Rui Reviewed-by: Gautham R. Shenoy Tested-by: Wyes Karny Signed-off-by: Perry Yuan Fixes: ec437d71db77 ("cpufreq: amd-pstate: Introduce a new AMD P-State driver to support future processors") --- drivers/cpufreq/Kconfig.x86 | 2 +- drivers/cpufreq/amd-pstate.c | 11 +---------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/cpufreq/Kconfig.x86 b/drivers/cpufreq/Kconfig.x86 index 310779b07daf..00476e94db90 100644 --- a/drivers/cpufreq/Kconfig.x86 +++ b/drivers/cpufreq/Kconfig.x86 @@ -35,7 +35,7 @@ config X86_PCC_CPUFREQ If in doubt, say N. config X86_AMD_PSTATE - tristate "AMD Processor P-State driver" + bool "AMD Processor P-State driver" depends on X86 && ACPI select ACPI_PROCESSOR select ACPI_CPPC_LIB if X86_64 diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index d844c6f97caf..701f49d6d240 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -663,16 +663,7 @@ static int __init amd_pstate_init(void) return ret; } - -static void __exit amd_pstate_exit(void) -{ - cpufreq_unregister_driver(&amd_pstate_driver); - - amd_pstate_enable(false); -} - -module_init(amd_pstate_init); -module_exit(amd_pstate_exit); +device_initcall(amd_pstate_init); MODULE_AUTHOR("Huang Rui "); MODULE_DESCRIPTION("AMD Processor P-state Frequency Driver"); From patchwork Thu Nov 17 07:35:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 21490 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp264823wrr; Wed, 16 Nov 2022 23:45:52 -0800 (PST) X-Google-Smtp-Source: AA0mqf7kROCfgetWLjbU3Q9VT3CgpwPAMwAAD3HOERgXIScpOgzWDrCT4ZzBUE56+vV8bpY688Vo X-Received: by 2002:a17:903:12d3:b0:186:a394:aef7 with SMTP id io19-20020a17090312d300b00186a394aef7mr1650501plb.79.1668671152396; Wed, 16 Nov 2022 23:45:52 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1668671152; cv=pass; d=google.com; s=arc-20160816; b=D22A90xvTJyTkJKCUdyC57m32EB1zU1uaqUAwSZLjJc4Q+z9YLPBKC8n9t3t4EkLux oGBC1/RUG6bU4RLAnANZ/fIojLNxIY1s8PVwQkoqd7eoPdeosH8RA2U2HhRAQLzNsj8W Z7ZmpN6oPdShwX3kHVWZDhwj+tyrCTUYi8Fb2KXBzTeA4ohWkmvj7ux6BH8iTE+K7QbD Lr0Pn4adu0bKPDs8O7VasnqRNpEMuYhLI2TBDzZS+kxIuz1ONSHxaHXEcxu5xschLl5o 9WV4uNDXspx1E31DTPy3xaTE0M7DuFNE1SIQ6/ebCQ0kfpBV4lOUFIJ3Ss1OJWdmBh9P NvPg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=aWoabDqgACvi+G0NzdgD0eqnnjqxtqiaKGCwnYaNA3U=; b=YwXPkBgns0jz4B0ILNj8tKTL7JgZ7N3vv2oepSxh+WSeryf9740Qrc1sL2meuy+Rnm Kb7ieZn4HrsDHgntmFVAKiW/U2XDvdonzNSHiCrYGx4Zx75b+fRJu5Y3SnP1RUqCregU i3TYkVOeeiV3UWtQ8ESi9RkacrrwanqTzzGFJPVRySNmkxCwQAID0eahGPfwFud4WYKb N3XEEg6oVHg63OcuzODaOYt1gIeBYL4RYfjUJ7jzZKWEoMCrNe26E9PXxbuWAFqUKwQ8 RcKUC5OBbBp8YonUhBk0TOkg999CYvkc8lvK7+U3IVIdrXSWc9Ul+4pW9D00UUMvN/Y4 7fOA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=NoBFqgLl; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c192-20020a624ec9000000b0056ec4a6babasi209379pfb.381.2022.11.16.23.45.39; Wed, 16 Nov 2022 23:45:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=NoBFqgLl; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239391AbiKQHgr (ORCPT + 99 others); Thu, 17 Nov 2022 02:36:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239403AbiKQHgc (ORCPT ); Thu, 17 Nov 2022 02:36:32 -0500 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on2058.outbound.protection.outlook.com [40.107.96.58]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6F2A701BC; Wed, 16 Nov 2022 23:36:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V+Glq64u3s+C+PwJk9nw1y3YgLEb7n8FQCNAjD8RO8sEX4cONIF4Ujoz1tzMZLO6xmseDzeEKuf9KXHkCE35+MuOtsuXRrSRD8OqkscygJMv+HVKcDnav4dMpN5d/qMhaXbK7xrEHgMwST/32Q6IJ+aAcuNALswW3p9Ypt3ntKDPwJJK5i0pQjPF693Qt7slBwrG/WVgPnS/pnghmhflJRM3UcLd+ujL3xE4d7Nye76DBao3UnU6osllk8RkYpjB5Bb/WsmdIMI5OhehbrFPDe7h7wUBN0vflea8nMC0RgfL3ie3dmLbIfBf72ISJp2VC9bJYMwM/6aetX41n6oSHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aWoabDqgACvi+G0NzdgD0eqnnjqxtqiaKGCwnYaNA3U=; b=JCCt0sGLMnQ51d037TBxLhyuPNv3Csew/MzAFvaXWCeRNRkzeqXL2J1YsFOUBVWjC5ifEPTFAaZ0nCL43qp4FCCTAGkG8l4z47wYgpsuoXzcUzcepIbkCUThfdD3GwnfiZkXjthX3A/hsQZrJtMdxFDo+SWDjMaqjNx8OaPQ1o+iuQaySbBd/edmRHliVJ67xDuWOesK6aRO1zXxaTqqEvIjJDv4rGhIXsz5yfI4Y4NKTZYy8Zjwa7Kkce5agTYSipWjPi2c71why4bC6qoPg/Kgr0LlmII+GHDgv1V0AJZYCzFLete+bl7h6jOMgzqCwrCgk4ZPkhMp8nSxbNthqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aWoabDqgACvi+G0NzdgD0eqnnjqxtqiaKGCwnYaNA3U=; b=NoBFqgLlIy1QfppzqCYe63/70odYiS5yJ4BiWMQUaJyRc1wn9aaBgzqmM/dHt0ihuxx8pK6jHKtrrfVqp/ve6tbC2QB5N14mBw92KOkeaWnEnSKOMNlKI20tWynde6o0sCB9IL7ZmpVrp8HkIE0elYwi3cMK9SnubZs453V0ZIs= Received: from MW4PR04CA0231.namprd04.prod.outlook.com (2603:10b6:303:87::26) by BN9PR12MB5228.namprd12.prod.outlook.com (2603:10b6:408:101::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Thu, 17 Nov 2022 07:36:22 +0000 Received: from CO1NAM11FT024.eop-nam11.prod.protection.outlook.com (2603:10b6:303:87:cafe::6a) by MW4PR04CA0231.outlook.office365.com (2603:10b6:303:87::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Thu, 17 Nov 2022 07:36:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT024.mail.protection.outlook.com (10.13.174.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 07:36:21 +0000 Received: from pyuan-Cloudripper.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 01:36:17 -0600 From: Perry Yuan To: , , , CC: , , , , , , , , , , , Perry Yuan Subject: [PATCH v3 3/5] cpufreq: amd-pstate: add amd-pstate driver parameter for mode selection Date: Thu, 17 Nov 2022 15:35:39 +0800 Message-ID: <20221117073541.3350600-4-Perry.Yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117073541.3350600-1-Perry.Yuan@amd.com> References: <20221117073541.3350600-1-Perry.Yuan@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT024:EE_|BN9PR12MB5228:EE_ X-MS-Office365-Filtering-Correlation-Id: 15b9e77c-ade1-428b-9bbc-08dac86e6c86 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SqKqwaKQjtbb7WNqYbvy15IDAQm/wiWyBsd/r2kStzK6nfON6Fr/ENeMe3EHXofLICt+CyxH7b9wa1EAlGlhrmqlbH7zns5rPK5EsNOr/kUJzQbJXCP0WN+lCJVHKihBt+gHhDYpkESFf/rPHr6TDsorPuaD06vUixzFdHb/8b80p+I+UxgtiBNS+jUwcHWgISmI6lI13Ur53n2pxxKPx9+Xu9h1PY6mmfJwRibZGI4Z63PXsxR/HmDHDE310KmP3/0yTdy5iiQCchkhtyVwrdbwGdab3Ry+DlaHFK4Ap8AlSurWiovWqKuabgipP2LY4pkoQ2O1l6Nc9lTuEFbYJV/ObXGfnoz1F3UHQAbAOKUWT+5dCz97hbD93zOMvD2N0SwWqAxgMsNIQfrPcsNbQjfjioFW7wJUOwR90Jpd41AkhsSyDvqxIAgp9BarLQw51T2Q5BXZSG61nsYkjESngfzwmsukb93gHbsGmGjLl3ilxoVuW2ECxpCA8cQcIBGh0NBdN/rsT4Xgyk26nshDDnRpJtLos4Le6JNShk9EK2pFdcq2rKe+NFUSx3/Evx0T969tO7cX0xcTsFQfn1WUC09VL2MawFB4m2c4vT1wUDRr99WJKDotcBMyhkxN1EW0bZPbav4YNWS2ezq6QXAbsjEs/iCTE19oslq/DeXCOhQmWcNWp1qj8/BWbTuv+ZvWJCdzgdRX+CVPE4PQ1DpjmuSuMksZqASZAFlLzXe3EvF5FBB84WG7fYOt+v7l7AV5 X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(396003)(136003)(451199015)(40470700004)(36840700001)(46966006)(82310400005)(82740400003)(36756003)(40460700003)(86362001)(316002)(4326008)(70586007)(8676002)(110136005)(70206006)(54906003)(41300700001)(5660300002)(2616005)(6636002)(8936002)(40480700001)(2906002)(356005)(7696005)(6666004)(83380400001)(26005)(36860700001)(81166007)(478600001)(426003)(336012)(1076003)(16526019)(186003)(47076005)(36900700001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 07:36:21.7190 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 15b9e77c-ade1-428b-9bbc-08dac86e6c86 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT024.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5228 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749728522081993870?= X-GMAIL-MSGID: =?utf-8?q?1749728522081993870?= When the amd_pstate driver is built-in users still need a method to be able enable or disable it depending upon their circumstance. Add support for an early parameter to do this. There is some performance degradation on a number of ASICs in the passive mode. This performance issue was originally discovered in shared memory systems but it has been proven that certain workloads on MSR systems also suffer performance issues. Set the amd-pstate driver as disabled by default to temporarily mitigate the performance problem. 1) with `amd_pstate=disable`, pstate driver will be disabled to load at kernel booting. 2) with `amd_pstate=passive`, pstate driver will be enabled and loaded as non-autonomous working mode supported in the low-level power management firmware. 3) If neither parameter is specified, the driver will be disabled by default to avoid triggering performance regressions in certain ASICs Acked-by: Huang Rui Reviewed-by: Gautham R. Shenoy Tested-by: Wyes Karny Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 36 +++++++++++++++++++++++++++--------- 1 file changed, 27 insertions(+), 9 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 701f49d6d240..204e39006dda 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -59,12 +59,8 @@ * we disable it by default to go acpi-cpufreq on these processors and add a * module parameter to be able to enable it manually for debugging. */ -static bool shared_mem = false; -module_param(shared_mem, bool, 0444); -MODULE_PARM_DESC(shared_mem, - "enable amd-pstate on processors with shared memory solution (false = disabled (default), true = enabled)"); - static struct cpufreq_driver amd_pstate_driver; +static int cppc_load __initdata; static inline int pstate_enable(bool enable) { @@ -626,6 +622,15 @@ static int __init amd_pstate_init(void) if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD) return -ENODEV; + /* + * by default the pstate driver is disabled to load + * enable the amd_pstate passive mode driver explicitly + * with amd_pstate=passive in kernel command line + */ + if (!cppc_load) { + pr_debug("driver load is disabled, boot with amd_pstate=passive to enable this\n"); + return -ENODEV; + } if (!acpi_cpc_valid()) { pr_warn_once("the _CPC object is not present in SBIOS or ACPI disabled\n"); @@ -640,13 +645,11 @@ static int __init amd_pstate_init(void) if (boot_cpu_has(X86_FEATURE_CPPC)) { pr_debug("AMD CPPC MSR based functionality is supported\n"); amd_pstate_driver.adjust_perf = amd_pstate_adjust_perf; - } else if (shared_mem) { + } else { + pr_debug("AMD CPPC shared memory based functionality is supported\n"); static_call_update(amd_pstate_enable, cppc_enable); static_call_update(amd_pstate_init_perf, cppc_init_perf); static_call_update(amd_pstate_update_perf, cppc_update_perf); - } else { - pr_info("This processor supports shared memory solution, you can enable it with amd_pstate.shared_mem=1\n"); - return -ENODEV; } /* enable amd pstate feature */ @@ -665,6 +668,21 @@ static int __init amd_pstate_init(void) } device_initcall(amd_pstate_init); +static int __init amd_pstate_param(char *str) +{ + if (!str) + return -EINVAL; + + if (!strcmp(str, "disable")) { + cppc_load = 0; + pr_info("driver is explicitly disabled\n"); + } else if (!strcmp(str, "passive")) + cppc_load = 1; + + return 0; +} +early_param("amd_pstate", amd_pstate_param); + MODULE_AUTHOR("Huang Rui "); MODULE_DESCRIPTION("AMD Processor P-state Frequency Driver"); MODULE_LICENSE("GPL"); From patchwork Thu Nov 17 07:35:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 21491 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp264855wrr; Wed, 16 Nov 2022 23:46:03 -0800 (PST) X-Google-Smtp-Source: AA0mqf488jbEe5SdJE5hVMJxJQ0z7Xe/YmOLP9zfsrBbxIG45U0Oa1mNxQ1dausLGqhC3lOP+a5X X-Received: by 2002:a17:907:382:b0:78d:a30f:3f46 with SMTP id ss2-20020a170907038200b0078da30f3f46mr1072620ejb.681.1668671163352; Wed, 16 Nov 2022 23:46:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1668671163; cv=pass; d=google.com; s=arc-20160816; b=SeKQoJ7zqtRsfoY5VoXAz06BRZWGxDBRkxMqCJnP/fRbpQQKbrU9WIZlwyqUio4LTm b9ielEKxcf5TFkHp2g4Pp/0GkHuM3Fs5hxZ4RS6JdolWPweOHipYbGBHJgks7TBxtNge FWQ+U5mCVTzz/N8ulXn9sFD3U7llGt+5yzx+BbGpTabP1Nt1XIrVcASFYxQHPUYLl5qK TSczfB9g4bLI2yGtPHClXjDPE0KKyguFkSqckD487NRD5QOxUREa0mf64B+XUu4CsSgQ WbCRrFu1BgDOnOF5PM21Tr5uS0Wyib2TYJt/ED4+qeL5YghodM3OspAyGMwglBcRCzHG j73Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VO4m3TjiJFvcONan9IEiN7O/JtpSbNDasZ8yYiMl4VI=; b=kWtSqY557RH2scbvASdN+9X/6A6yVXkUSnuI8s87KoJG+YFVZtQb4LKFYQZia28n80 o4pWfJfTt/m4PQ6BxJSLcMt5AJGD+Xg+LUGOk0EPqLSKYDGm/3F/15SyozU1rlegzylh C46BB2XjDfX9FFSI5gwZgDlMyR7N/T2QXAcv1QZLIelb70VOkCsYqUTC2Sc+wcvkF/Az M70KU2MxhFYgUSNkkvzCO1mS2z9pybvKv5Y3ZGrl1o/73DuXSG+yjjkSgZaspbdc5rha SDv7ebfntsaACftb2LlZ07KnLsSuu+at10+BnnhiB52rLvvCMPAr2ZZQ210sU6StcYdj 9laQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=vq5fvNXz; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y8-20020a056402270800b00461f44d7bfcsi280605edd.573.2022.11.16.23.45.40; Wed, 16 Nov 2022 23:46:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=vq5fvNXz; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239449AbiKQHgz (ORCPT + 99 others); Thu, 17 Nov 2022 02:36:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239418AbiKQHge (ORCPT ); Thu, 17 Nov 2022 02:36:34 -0500 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2073.outbound.protection.outlook.com [40.107.243.73]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B560716E5; Wed, 16 Nov 2022 23:36:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XWJEvMUi7yyzn4ghS0elKbQdUglpKPvk3oBqz0Cd/jJn/bWQB0f5JhPEAIMEDqiQajZIJRiR58XSv0Lxp5aszz0UvgL9gcUx1f6IxVQgqPy/K5hiinN5Livn0bGM20eIvR/13ZsfJJOAWn+jDq3zXv5LCNXQ8zSQpLqAOoPVijpNfJ89SNPT1OXcCnaqrS5YLoPMHNLwH6ZI1UyTSw5mkRZxC+ly0YSAoVmJhlp0Vv5O1SHAksRJcMNhDvH47nd2lQfoMnlzBNAY/zX+pE6Q/WOhPMQeP9t52KwH7HbuMloyIlMSwicDfokwAiEypPeZe/z1R791vQMwEro/SmjBdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VO4m3TjiJFvcONan9IEiN7O/JtpSbNDasZ8yYiMl4VI=; b=gjfIgIJ+hH/561kL1LK4daElcjr/iV/ubi74ve9gonDvNiEre306S+s9g9LEYihgXx1f1e4lnjfjnId4dvlD0CtfIqmN4TAVxm1a9T1gFm8/14xCBogvxn5KcoLmLBv5nihOR1yClZBzGK0xaw7KuQhDJU2XOdea4+EZXCyRcnKzzYtXQMijL+BCUSyA2KmMoORONeHedIZaipYat8lCdD3cQmg53XvPb5toxdHPVyVFg8rSZaS61r225nAG5/W1iMhbiWxZGfhsvA7XlBkENozJQ8/gvBPYTDqriJ/mVC76XA91KUVwWfpcZpBX5xTCM0C9gOlF/YPzmeo1xWkzvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VO4m3TjiJFvcONan9IEiN7O/JtpSbNDasZ8yYiMl4VI=; b=vq5fvNXzhZA8i3ITRD+d9IrjbOBvIBpCcmDuzwoq92ISPn+XvhM3qyMgkt5r4sWi/XTpDlgLaU/IkiTvEpsWWkT7P0R2wFD2YUrHlpwL2/gzCt17BK7efg8bHhHrVrGIjBzxpvh+AY1uGaWe0zc/m+I7Zr3nNhe+pEXCjUfOrsE= Received: from MW4PR03CA0349.namprd03.prod.outlook.com (2603:10b6:303:dc::24) by DM6PR12MB4155.namprd12.prod.outlook.com (2603:10b6:5:221::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Thu, 17 Nov 2022 07:36:26 +0000 Received: from CO1NAM11FT007.eop-nam11.prod.protection.outlook.com (2603:10b6:303:dc:cafe::b) by MW4PR03CA0349.outlook.office365.com (2603:10b6:303:dc::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Thu, 17 Nov 2022 07:36:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT007.mail.protection.outlook.com (10.13.174.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 07:36:25 +0000 Received: from pyuan-Cloudripper.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 01:36:21 -0600 From: Perry Yuan To: , , , CC: , , , , , , , , , , , Perry Yuan Subject: [PATCH v3 4/5] Documentation: amd-pstate: add driver working mode introduction Date: Thu, 17 Nov 2022 15:35:40 +0800 Message-ID: <20221117073541.3350600-5-Perry.Yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117073541.3350600-1-Perry.Yuan@amd.com> References: <20221117073541.3350600-1-Perry.Yuan@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT007:EE_|DM6PR12MB4155:EE_ X-MS-Office365-Filtering-Correlation-Id: 545c60a9-9e39-4ff7-ba37-08dac86e6f02 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /fYBWSZV3dfCuhN7l/o4Ko/cgr09XlTsV9iEXpdXURE5eQne623BqJp8L+PAm2EY+h1OMVK4R0keiTPJkxLOkZLtEnAZWNigum2LkkM2zl100aKWVF1JaXanFhX5b8LNap+KF6M23EyS78qBdP/tqOJuy6PMrx4VkXG3GSeD9M6C+b4h0xGwXAHgE769+Bb5QHpXa9GP1SnBfLw3HH/yik8IuAmccBRHVB+KoHVXpt+KLOVrY2f4pu6FMLzjn7l4Zy/RmfuS9J46IqYRCH0xEW49UGet/HgtdIyrvZqVGHjGj0hGn3tIaqru6x/Mg6ZzPU0Zn+tNwbfQ4JzIMYG8Ceeitxw/S5f0WBAWsYvB+7BGRvXNqU/r5cVFp0XVMTCrKXs7poKq3WJFt7FhugcPp3qLyyKqo/gO4XVwV4xHkHasLWHEwQLLiWnMC1f2qsBmU4vll3YmgAMJC3IrlItYIVKvi0jyzy76UbL/pN3DjO6sYjpLjZkDUVDuowVQYxT3XT2n5w/lezMvKvOMvsiSwCDktRLbiG9xfq4+jtkeGWnu/LurMCzvbkS3Ih2zjVjf/WG9Coe+D89LokebTXjbaLf6Y+w3gUKfZHiCyCbNjO1UT9aj8k4a4nVT+XLl1N9g3J2Y4siP1XrBL7fmWbNmrzZU/aE2EeZEhMbvdpMGMHE/s8SbOKrJ3yoSU9DUXEwvkOFHbjYxII4um2Hzabv7UM/Y8szDrX/lgxNZkZ4a4MDhRdmttBDsMZtvr93UkoyQF8xYqqc5I7hGTjvBK3unctFPuwkWX/VDuNJM/GZl65o= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(39860400002)(346002)(396003)(451199015)(40470700004)(36840700001)(46966006)(36756003)(26005)(86362001)(81166007)(82740400003)(82310400005)(36860700001)(356005)(83380400001)(336012)(426003)(47076005)(2906002)(40460700003)(186003)(1076003)(16526019)(2616005)(5660300002)(478600001)(7696005)(110136005)(40480700001)(8936002)(6636002)(70206006)(6666004)(54906003)(70586007)(41300700001)(8676002)(4326008)(316002)(36900700001)(2101003)(473944003);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 07:36:25.9035 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 545c60a9-9e39-4ff7-ba37-08dac86e6f02 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT007.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4155 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749728533721597177?= X-GMAIL-MSGID: =?utf-8?q?1749728533721597177?= Introduce the `amd_pstate` driver new working mode with `amd_pstate=passive` added to kernel command line. If there is no passive mode enabled by user, amd_pstate driver will be disabled by default for now. Acked-by: Huang Rui Reviewed-by: Gautham R. Shenoy Tested-by: Wyes Karny Signed-off-by: Perry Yuan --- Documentation/admin-guide/pm/amd-pstate.rst | 30 +++++++++------------ 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst index 8f3d30c5a0d8..06e23538f79c 100644 --- a/Documentation/admin-guide/pm/amd-pstate.rst +++ b/Documentation/admin-guide/pm/amd-pstate.rst @@ -283,23 +283,19 @@ efficiency frequency management method on AMD processors. Kernel Module Options for ``amd-pstate`` ========================================= -.. _shared_mem: - -``shared_mem`` -Use a module param (shared_mem) to enable related processors manually with -**amd_pstate.shared_mem=1**. -Due to the performance issue on the processors with `Shared Memory Support -`_, we disable it presently and will re-enable this by default -once we address performance issue with this solution. - -To check whether the current processor is using `Full MSR Support `_ -or `Shared Memory Support `_ : :: - - ray@hr-test1:~$ lscpu | grep cppc - Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc cpuid extd_apicid aperfmperf rapl pni pclmulqdq monitor ssse3 fma cx16 sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw ibs skinit wdt tce topoext perfctr_core perfctr_nb bpext perfctr_llc mwaitx cpb cat_l3 cdp_l3 hw_pstate ssbd mba ibrs ibpb stibp vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid cqm rdt_a rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local clzero irperf xsaveerptr rdpru wbnoinvd cppc arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic v_vmsave_vmload vgif v_spec_ctrl umip pku ospke vaes vpclmulqdq rdpid overflow_recov succor smca fsrm - -If the CPU flags have ``cppc``, then this processor supports `Full MSR Support -`_. Otherwise, it supports `Shared Memory Support `_. +Passive Mode +------------ + +``amd_pstate=passive`` + +It will be enabled if the ``amd_pstate=passive`` is passed to the kernel in the command line. +In this mode, ``amd_pstate`` driver software specifies a desired QoS target in the CPPC +performance scale as a relative number. This can be expressed as percentage of nominal +performance (infrastructure max). Below the nominal sustained performance level, +desired performance expresses the average performance level of the processor subject +to the Performance Reduction Tolerance register. Above the nominal performance level, +processor must provide at least nominal performance requested and go higher if current +operating conditions allow. ``cpupower`` tool support for ``amd-pstate`` From patchwork Thu Nov 17 07:35:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 21492 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp265307wrr; Wed, 16 Nov 2022 23:48:02 -0800 (PST) X-Google-Smtp-Source: AA0mqf60Mo27PTzinsqU9K6k5OnsYKbEV9w51uheJ1c1mQiQolF5hdCOnCkdW2j5yMqBHLW7PGQh X-Received: by 2002:a63:ea15:0:b0:457:7285:fd2d with SMTP id c21-20020a63ea15000000b004577285fd2dmr949939pgi.580.1668671282242; Wed, 16 Nov 2022 23:48:02 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1668671282; cv=pass; d=google.com; s=arc-20160816; b=mkAsSaG6AaJaRlI422QD56c41tLcqhVwsDHJOmUl1iJ87fANkutedNQ5Jt7rR4YXQF 0sIrpVJvTu4w1TYZl0fBMtZ6LlI16YSISBD/pxCE3LCzb3jVs0OFMk0mjsJmN6NkdrRB acDN4lH30bF2ceVuHyEwaaEW/xmM2Pcbm8X0jkCfypfrxlTwFJrtR/Z+d+F2lBS8TCX5 Uc2uJW0yAKBzkM4NVg2OYRZH6V4KkV2GgvlO/YYcJVCVRM034OgKldaM3YWD69BFjCWK fwgWq5bN12t5Adhfq2jzi+Au+ETsxEe8lqu3h4CM6DgGr+PrbP4tCqNCJWJU36GVBUX3 Zinw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Hbjg3aQ2dI0luwPEC4G9zdF0aZJZYP5hXY1mKmBBlVY=; b=isl09+qNuXe+3cfFmEywrWH3HS63ZGXE6iWKwmAwam00LBnD22v8fclGs7W3pGX+DM YWv39YFpIBrpxiEBrAl7vN45LSyJbT68FvzG/ztf0JBBap28QRHLo6oTrUJy7rKgIzVj XwLSauJq21YH23yfMMAnjqGPqN5llnfKVm8C+pn9HJn8x53ICuGbGLZlX6+EGsgMUjZo kxGwbRWpO6T864z8KArrqdMeaLhZXq+kJzEDNxlgWBrYGkJgI42MOIxZ7ire1GhtZOcm j8CULvcgGxDWygzrDaAT4hr6Tn+MI5gH9ImUCaqB/UV5v9pZjJfRvgubm/5EOcZqiLJd 1+Rg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=e12X1Amz; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g12-20020a63520c000000b00476a48051edsi344568pgb.476.2022.11.16.23.47.49; Wed, 16 Nov 2022 23:48:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=e12X1Amz; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238603AbiKQHhQ (ORCPT + 99 others); Thu, 17 Nov 2022 02:37:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239434AbiKQHgg (ORCPT ); Thu, 17 Nov 2022 02:36:36 -0500 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2048.outbound.protection.outlook.com [40.107.243.48]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37C016A69B; Wed, 16 Nov 2022 23:36:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bCv0xFpzEYc9FUNDGV+AyWdy0y2/SDwyL+R2kPvLbPkGkAi1nHI+GLtpc53E57PgttjJa7XJf/EfDcF252Vzz0lcWXR5gFBQTySpWHkdd//ZGZji0251ZPpKNzJKtJFNlmTjaCCYs+qylkAyH2nUM+bnAA5WLmvWqYpyD0wyJQAjwvefgVelj05Ct5mc2KX2zVkiLxir8Hq91g3d3jVii37C0kH17ZixzAsSIIGPJNAuZQim+M61LV72dqnnnXJBzM4z5faiyoYTHgy1uacoHzf+TDX/VtmoMnLGYUII/Z0JuSx+DpNJ3ygTT18LqMrC3bjklbL133LO7a0rndofWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hbjg3aQ2dI0luwPEC4G9zdF0aZJZYP5hXY1mKmBBlVY=; b=a5M1OkFotfKNTYb6PQ3ssimnfEdMTmL7rPyfUY4rfuvegs1VyEjHK9pY4KijIt/nJBPHHnYtuX/WHdYhoXCnIN84qCwBlmS+fAG4KCP/3HisWNEx7hkqce6VgO3NobOlDPVyx9ZzgmKhChnVDLZ4+IVXFfBrIPfXKprPyGq2VeOSmQmTKRuUefsF5gd6utM6rkOkNhGP73DvI38iEXY+i3pNMpE6hmMNft34GqkWsiL8x0Rn3jzJGGTmskuZrmSJrb4ADWFOlkuOS+nXfWqWRge9ncoWu5OrZRYhmusD/PqKMi9AU3/uJADhmEI/0ZfP/vLytBSoS1qYknCBsdVbLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hbjg3aQ2dI0luwPEC4G9zdF0aZJZYP5hXY1mKmBBlVY=; b=e12X1AmzWPAz8o4w33e2mAyKMzx4oKv0W9NBxt06H42qeCKezxzxvdtLQM/JKjrrdKJf4cCbAj4qRxgpHotI0EuFwX/VTgSB4oxAKNXOUqViep+kfgfd2E225cMLp22D7mOGskYnpSZnUz8SmePgIxoI7PhP/DDX6pHdfxWa6uU= Received: from MW4P223CA0018.NAMP223.PROD.OUTLOOK.COM (2603:10b6:303:80::23) by CH0PR12MB5266.namprd12.prod.outlook.com (2603:10b6:610:d1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20; Thu, 17 Nov 2022 07:36:30 +0000 Received: from CO1NAM11FT106.eop-nam11.prod.protection.outlook.com (2603:10b6:303:80:cafe::5b) by MW4P223CA0018.outlook.office365.com (2603:10b6:303:80::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18 via Frontend Transport; Thu, 17 Nov 2022 07:36:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT106.mail.protection.outlook.com (10.13.175.44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 07:36:30 +0000 Received: from pyuan-Cloudripper.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 01:36:25 -0600 From: Perry Yuan To: , , , CC: , , , , , , , , , , , Perry Yuan Subject: [PATCH v3 5/5] Documentation: add amd-pstate kernel command line options Date: Thu, 17 Nov 2022 15:35:41 +0800 Message-ID: <20221117073541.3350600-6-Perry.Yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117073541.3350600-1-Perry.Yuan@amd.com> References: <20221117073541.3350600-1-Perry.Yuan@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT106:EE_|CH0PR12MB5266:EE_ X-MS-Office365-Filtering-Correlation-Id: aed96e96-c5fc-470d-e0d5-08dac86e718d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fHhj/hXRnoMDi/7l36FQZNShyBSeTSmLv/0u4Hx8jg3aRb6YrZ6bq1GCMkynPAIhsOMwWr3dFzjTGieh2/TtACBI5NL0cLpF87WFJeCsH5CrJqcaZgTTpF4y5eY/r4F+ywImew7p08YegaiZ8ziCkNajs1rZ3fMd+g72i3gQLWUcmnO3YzeosMpCg2zKQx+24n9nUHxnq6VmFbQ2da31I8ND5Yw7x6tzRjDD+yxtROGoTCNFi0Z/cmZDeZcfLucUhiaukdNSHtF2bUF5kUkUcK9eYJtVCULx24rsd6bmDCqZowbH+7c02BED+bAe7BhzS//ZPRhv5/taAo/rXgDZS/dQJb1vwAkhRs4Fk6IuZAhpKvvK88C5fZiqhv3NS+e4TFCyad3xYoe4+aBmK0t3DDiXifkBJ349c3N2IMaPFe6dIo50AxzVaUk8yJQKUEb9zryeYKnsrbF/DJfA6GKDdT8QKdR0Y4L5uISOyub5jen86o4C2vgGqcgLwqJ4lUwF66zNnEhPW5MIahoEG+5wQi82a722aFZNwtnsMZNBBN6aA30FppXLG7OGqtEHYEYsVTf6h4IBlf7GWiyh8a93gjwc749wGypGaaH9PeZyAGrYdVR5p4fcnPkBDTY0PKLsm/2VMuY7pr2FvrSYDD+kumg6noUvaKHAC0XezT+67qqvoWp0aQCygcG5du/QVlF/LoSthoPXp40lqS7YRfEfFFbH/G42g3yd0fhIiA361grYcvx2cfpcFgl5kyFnxEE2 X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(396003)(376002)(346002)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(1076003)(186003)(16526019)(40460700003)(336012)(5660300002)(316002)(7696005)(110136005)(54906003)(6636002)(41300700001)(2616005)(8936002)(26005)(4326008)(8676002)(70586007)(70206006)(36756003)(82310400005)(36860700001)(81166007)(356005)(82740400003)(2906002)(40480700001)(83380400001)(47076005)(426003)(86362001)(478600001)(6666004)(36900700001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 07:36:30.1709 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: aed96e96-c5fc-470d-e0d5-08dac86e718d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT106.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5266 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749728658534500564?= X-GMAIL-MSGID: =?utf-8?q?1749728658534500564?= Add a new amd pstate driver command line option to enable driver passive working mode via MSR and shared memory interface to request desired performance within abstract scale and the power management firmware (SMU) convert the perf requests into actual hardware pstates. Also the `disable` parameter can disable the pstate driver loading by adding `amd_pstate=disable` to kernel command line. Acked-by: Huang Rui Reviewed-by: Gautham R. Shenoy Tested-by: Wyes Karny Signed-off-by: Perry Yuan --- Documentation/admin-guide/kernel-parameters.txt | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index a465d5242774..42af9ca0127e 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -6959,3 +6959,14 @@ memory, and other data can't be written using xmon commands. off xmon is disabled. + + amd_pstate= [X86] + disable + Do not enable amd_pstate as the default + scaling driver for the supported processors + passive + Use amd_pstate as a scaling driver, driver requests a + desired performance on this abstract scale and the power + management firmware translates the requests into actual + hardware states (core frequency, data fabric and memory + clocks etc.)