From patchwork Thu Nov 17 07:19:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 21477 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp258803wrr; Wed, 16 Nov 2022 23:25:55 -0800 (PST) X-Google-Smtp-Source: AA0mqf4Ell2IK4r3go3PEzJ8igo9744nixfFIfipyGwP2I8xsbYNiGFlROs794vVMAScdVk5iD1g X-Received: by 2002:a17:902:a503:b0:186:e8bd:9c14 with SMTP id s3-20020a170902a50300b00186e8bd9c14mr1458156plq.174.1668669955610; Wed, 16 Nov 2022 23:25:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1668669955; cv=pass; d=google.com; s=arc-20160816; b=HIiUiLJC8BGBladvjdljL3kV4lfKFa3i07/uWZbiTD2dZX8rkpQwjyJ7Y2pSebb4Ow eoZAOdWHwlAL6T3V5lTq9oLzAO5iWTnIPyEyEecN/lLMV10edaDUudve7PIHX1id3Cic dUnHWgzxlxC6/r6BEN5IZJkmA71/+d6vFPfF53dqyomG1ymSmC0FPyuwPTnvfS67zEFQ W+2wPr80QPVOhdfZM7Ap9r+42y9oz5NzPOwsHwUKbAwN7WtR2g2P17VwJtXdQc8JC1uu /OkFLSAG6wSTWZti9yOlF1ld152hf9XnBaZHUKLyibJZmZa2QuKwqmjFb9GW1J/evZ+7 hRSw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9AW+a566QQSG+KQj7q3b6S9EwyMXzi1qKHIFQPV9ACo=; b=p1Aa5gRV/ttd7YftgeLyK0tieaO89c1LL+opyFxafEt7mWcWK78VqffdboJzjEt5op dG3xEpqAjigkMtXTfhRcmqUVhCDv/4xe6d7D0QZvgnIgkqWQIW9zPrelKtDGsXpuftVa ZhCA1IblJ8o2lrF95RwSsm1DI3gUuoL2aDs9sWgjrMKTCYsmmq5QznxkrOjpKMPHEMPf JaGjjaAffrNKq6tWwi5k+BxcYr4hh+urnW7oqnBdU2yhFxKnRLBqwQxBbpTNc1orQqTO GEmnCmtBexIdWuvQZPHnO/goizqruJUn95SK9Q3e+a3JIK1geGN5d5UeTjkIlm4Nj3F1 Fy3A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=zNidgquC; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y186-20020a638ac3000000b0046feca13e25si337449pgd.68.2022.11.16.23.25.42; Wed, 16 Nov 2022 23:25:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=zNidgquC; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234761AbiKQHTq (ORCPT + 99 others); Thu, 17 Nov 2022 02:19:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239221AbiKQHTl (ORCPT ); Thu, 17 Nov 2022 02:19:41 -0500 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2048.outbound.protection.outlook.com [40.107.94.48]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39C096F34F; Wed, 16 Nov 2022 23:19:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CYfGB3KwU/qGJEZxj+k5h5eFOJo28bRnoBh8u0uXOfE+Wf1FdriBFsgBhuIJPSGZF19NZNcA0HLdxH7NnTdxyHKS/iNlVPzVf9OFFbNPHs5tpqBdY4CPcB3RVtrgmDQTRz78KFjurbRIDR9svtmRzXoeH17aIyN3n6xi10kSPCzN57d8/K3wou7lYCwkH+0d1m7PYuklhNDZL+6cWtqnqHSOAduXw5p/Mkk1tNS3pV2shtWqe/IrM6XysSVs5cijOBafE+caotJTIG5EqxJbduKj3MumadhOc07aN8IAxxlg1xbjYoYJo7DkV/3u5XuEHFZoOzO2fk9/aem1wbuPDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9AW+a566QQSG+KQj7q3b6S9EwyMXzi1qKHIFQPV9ACo=; b=FS/GQxIyPPf0aQALeUPriAhiRpR5SYgKmHmyEfUC187ADfVo4OF4TbLwbpdYzQWpu4yyN1n4N+CAuKxnceKHSvB2vfQv/Z4XKfB4CMFmi4dAUuY551JNZfgve4072cxD5CmnEAJysnFx9psvCQHBLx3bF9E+I6Y2AlPB1STMLRtscUqNqA7iCc6icfAe8bvG4UgQK2I7nPpKk5hwC3FZlVrkbFJ5+WZvhQaR41uK9Yt9OEVeLFvvx7c2CYnRwTDxGb2vtI72q5VgWQPYgX+iYyfctNRYOiaI5AWjkojEL59X8QcW9a7Zj2uUe6B0QZFxzMG3O7Cj1go7Oh54aIl7EQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9AW+a566QQSG+KQj7q3b6S9EwyMXzi1qKHIFQPV9ACo=; b=zNidgquCyCAjurpXSUivvllhQEq9RblEl0v2d4a910tlrliSxW0aHWQzjvlLYKYY3TqECzfg0tQSkDdwCcFYEN0c7K+Cu9AKkAzCp8t6vFb49L8D9cWuxdoFtP6tskl0EM+1twmvjsc1FX7CEtmFOUr4DMzAoQfQYdxupM2ou5I= Received: from MW4PR04CA0200.namprd04.prod.outlook.com (2603:10b6:303:86::25) by DS0PR12MB6558.namprd12.prod.outlook.com (2603:10b6:8:d2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Thu, 17 Nov 2022 07:19:37 +0000 Received: from CO1NAM11FT007.eop-nam11.prod.protection.outlook.com (2603:10b6:303:86:cafe::e) by MW4PR04CA0200.outlook.office365.com (2603:10b6:303:86::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Thu, 17 Nov 2022 07:19:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT007.mail.protection.outlook.com (10.13.174.131) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 07:19:37 +0000 Received: from pyuan-Cloudripper.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 01:19:32 -0600 From: Perry Yuan To: , , , CC: , , , , , , , , , , , , Perry Yuan Subject: [PATCH v2 1/5] cpufreq: amd-pstate: cpufreq: amd-pstate: reset MSR_AMD_PERF_CTL register at init Date: Thu, 17 Nov 2022 15:19:06 +0800 Message-ID: <20221117071910.3347052-2-Perry.Yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117071910.3347052-1-Perry.Yuan@amd.com> References: <20221117071910.3347052-1-Perry.Yuan@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT007:EE_|DS0PR12MB6558:EE_ X-MS-Office365-Filtering-Correlation-Id: 04716dbe-8c12-4ede-f014-08dac86c1604 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EmttMXeHUGL+A1BM7o7fFqr6Ngn3FZPVoDPY8QVYcySf8aOPk3kGFyaCmId2k7PlDkQ1m7nijT/CHpUNPgsqPnFwdgFi5cOxjXOHwavXj0f3BCuHSQg87wHV81ABb2LkslUIC6Vb/MZ3cz7SOk+vkavHD6FHj5Vpwv8kPTGixJD36bZvSVmQ78MSIUW72V37RIBk192hWLbqTcgOrDhkTPUzzv+bRpADteDWyY8Ks0kB9TDNaNK+2QlcTRBMRbAPCaPO+Srparv87hNu+3/R3d50f9UXyJg5OaBB6ReLTtTRO5L5hij7xrI0Rqndk9CTvL/ByuLtq6ZiHlyuzJF6GE64qzbXEwvcWlHySKZM/gW5F05XxNsk7ZXPa/9yGE3OUGYu0CIkaJ5/9eI2k46+KozyWJOG6HePbDl08954uzBqXgNReLgloRgp7VN2PJ4fhtED/uvRD3eAjSyREI4Otu81JaFp7FhyVcUn9U9Tbnk6XpGZ6PdxFJuK1SW/pzWWXTm1momvsN6hk4k7eFYNqrC0RSrrdCO+zR9QxcMSF3JKBp66hCCG7PtKaWKk+EG/tHXuZF7qxbITuBmIE0gx3WvO/MJ5Z/856UwMYr9sKP0tqe25yowD8q9eA6TXMCjEWsz+NpSvcknsjmUjLYFCOOa+8fFJzCl3jXnzBkEu398KPuAXzrFQr6k1TFOeIDAg9sn0e8zmj9m6YUpQmsi3iwQXKNIEx+T+9OhLHm/xrnPRtARj/XqXB1qT/Hqpufy3 X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(396003)(39860400002)(451199015)(46966006)(36840700001)(40470700004)(47076005)(8936002)(336012)(82310400005)(426003)(186003)(41300700001)(1076003)(16526019)(2616005)(66899015)(83380400001)(5660300002)(7696005)(70586007)(26005)(4326008)(8676002)(70206006)(36756003)(6666004)(2906002)(478600001)(6636002)(40480700001)(316002)(110136005)(36860700001)(82740400003)(86362001)(81166007)(356005)(54906003)(40460700003)(2101003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 07:19:37.6073 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 04716dbe-8c12-4ede-f014-08dac86c1604 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT007.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB6558 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749727267586143333?= X-GMAIL-MSGID: =?utf-8?q?1749727267586143333?= From: Wyes Karny MSR_AMD_PERF_CTL is guaranteed to be 0 on a cold boot. However, on a kexec boot, for instance, it may have a non-zero value (if the cpu was in a non-P0 Pstate). In such cases, the cores with non-P0 Pstates at boot will never be pushed to P0, let alone boost frequencies. Kexec is a common workflow for reboot on Linux and this creates a regression in performance. Fix it by explicitly setting the MSR_AMD_PERF_CTL to 0 during amd_pstate driver init. Cc: stable@vger.kernel.org Reviewed-by: Gautham R. Shenoy Tested-by: Wyes Karny Signed-off-by: Wyes Karny Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index ace7d50cf2ac..d844c6f97caf 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -424,12 +424,22 @@ static void amd_pstate_boost_init(struct amd_cpudata *cpudata) amd_pstate_driver.boost_enabled = true; } +static void amd_perf_ctl_reset(unsigned int cpu) +{ + wrmsrl_on_cpu(cpu, MSR_AMD_PERF_CTL, 0); +} + static int amd_pstate_cpu_init(struct cpufreq_policy *policy) { int min_freq, max_freq, nominal_freq, lowest_nonlinear_freq, ret; struct device *dev; struct amd_cpudata *cpudata; + /* + * Resetting PERF_CTL_MSR will put the CPU in P0 frequency, + * which is ideal for initialization process. + */ + amd_perf_ctl_reset(policy->cpu); dev = get_cpu_device(policy->cpu); if (!dev) return -ENODEV; From patchwork Thu Nov 17 07:19:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 21478 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp259031wrr; Wed, 16 Nov 2022 23:26:39 -0800 (PST) X-Google-Smtp-Source: AA0mqf5Vv6JUjx255b2dYtFJE9WLcwFFTKG51o5TMe6m0JXukLLdaF02asvw44qJEC+xM727fWST X-Received: by 2002:a17:90a:2882:b0:214:28d5:b2e0 with SMTP id f2-20020a17090a288200b0021428d5b2e0mr1461354pjd.218.1668669999394; Wed, 16 Nov 2022 23:26:39 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1668669999; cv=pass; d=google.com; s=arc-20160816; b=vsCZtKjMpreSLtSr0Ab22blbBYjQIiN2QOfRknooOauf9u74W+i6iBdQNaubJi/Lg9 k3ntK8dDTpjbaoa0wXJzUPKRFAfmSEK8DHQLmWNTCMMNge3TiAZ1QMczxQROTLfRKwTl 7tIiIxGvzSvhquXISn8p5yxdIY7NZf6IkSZGb/PL7UKx6/fWrmJi0MafNpHspkjUOsd7 2p5Yr6E1cavIJ3kV8SNWzwALjmhAtf75Tek4ESc6OTYg+GGRimPz1Ke0RwdQVXdKIU0U kEqj/GyNn1EO8FhQgxUbv18tpxlae94RGBZXm54EcYiUJFB/ybKx0Px+6bn+0ztMtV+4 LNww== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+VcxHfZHgy05iclJ+ckW+zPVRv/XZiM1SzYHvI6AHQM=; b=TF5luMcjCNJBNxyw37xGTe2qKia5iQnrVJRmyjnBweNK2+KACc2e/iqeBvEl6TXH5x xJxcQTqJVDOJQLSCL4lvtkG1wRhqmNNxZL6m+juFtba7j8xKJdy/Q5vqB9IMZTqFYRWI QAJpqsxnDVjWLj6asaSmsojqcOnxOyFIZev3StUgXlItdFHb/U80iakfW82RbwkYOiPs 8aprkuNIdtKx1NCcdjpm9QdHEumYUosue5imGh7b2v6e/EJeSyYbD8HYDOWyiaO0nhuI Xc26UrD6YV89t5nGIXfBTe7P0FWdfDq+NvHWLThZe7Mf5y/xtlMFG5LqoqpqYwMLyxR1 Kg6A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b="YhyZWKA/"; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u13-20020a170903124d00b00188f3bd383csi352791plh.266.2022.11.16.23.26.26; Wed, 16 Nov 2022 23:26:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b="YhyZWKA/"; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239285AbiKQHTx (ORCPT + 99 others); Thu, 17 Nov 2022 02:19:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239241AbiKQHTp (ORCPT ); Thu, 17 Nov 2022 02:19:45 -0500 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2042.outbound.protection.outlook.com [40.107.243.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3FE468C52; Wed, 16 Nov 2022 23:19:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UTDN1Yhm6A2SR90nXI7tM/ouE1qv6YpPgjC8R9nKBloW/tXA2J5MeN2H6MPMOHtNiY8QUU5duWA70xB3OBAGZZxNMkw+bSSAA6iGoPbnLZM0vi66EVR+7UoyOmPGH3KfFUWUBFM/np5vzBtaOfUByNIcmwB4aqGR8bx2kpoP+B+zzBLC3ImGNnWagHRy5VaDi0oQx/0AA3jSU0magVhRTdfPeIng28t6AVORdZ3lMzuC/6dN+vM4B4rus8aR/uwPe01RVxdpWVEyYwYfjXsdxC9/sNCzPsaHD6T0+fhAIWIwXGKe0kFAFgDpnro7Y9Sr3QoGxx1v94Enbv7zHBN2fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+VcxHfZHgy05iclJ+ckW+zPVRv/XZiM1SzYHvI6AHQM=; b=derrIocjw2huByQRDmLkVICReHWWUuF1NnABIHof3zdMnWmo/ym0DqWHbjM6BE+H5pOek33kKM6KBnos8iJ/GBekkWiKUfIZwUfDwFzgKPRkhn3tLXhcMPdgtmAmMY0QznjjnDYnv9uVTHpXuFsYjVr3+EpnjJi64sJWvKULa/82HsYjG30rdw6+/sQw/Vh6Hy4a4q4e7esmKq6Ez8E5XfWTSGHnwfn5HV/RMv/lFq7UA9zB7UU3ivakr2x3cXTM8jxuOia584ASJxpR7zyk4UgGS/bdXwzu87Lsqfu1b5B2bMYnm3JQn51awirUg3KXixeYqvR0amKSsJ2c+OuRJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+VcxHfZHgy05iclJ+ckW+zPVRv/XZiM1SzYHvI6AHQM=; b=YhyZWKA/u4QPn/cXNNJ3CtE1V8JjGWWk1+QSn9Lvr8gxDRSv3wgFZY8RLfHEcshKvjMZfMXCwaB9miq18y91GKvrYZ2BzH27cB/FUMb5IMCUQMfJ780rIzayGyvGTR4PYNEudmT+sg0BTlLkjSpnbaIpZ2UFdtihFCCC5Y46y60= Received: from MW4PR04CA0298.namprd04.prod.outlook.com (2603:10b6:303:89::33) by DS7PR12MB6312.namprd12.prod.outlook.com (2603:10b6:8:93::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.17; Thu, 17 Nov 2022 07:19:41 +0000 Received: from CO1NAM11FT082.eop-nam11.prod.protection.outlook.com (2603:10b6:303:89:cafe::ac) by MW4PR04CA0298.outlook.office365.com (2603:10b6:303:89::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18 via Frontend Transport; Thu, 17 Nov 2022 07:19:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT082.mail.protection.outlook.com (10.13.175.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 07:19:41 +0000 Received: from pyuan-Cloudripper.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 01:19:36 -0600 From: Perry Yuan To: , , , CC: , , , , , , , , , , , Perry Yuan Subject: [PATCH v2 2/5] cpufreq: amd-pstate: change amd-pstate driver to be built-in type Date: Thu, 17 Nov 2022 15:19:07 +0800 Message-ID: <20221117071910.3347052-3-Perry.Yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117071910.3347052-1-Perry.Yuan@amd.com> References: <20221117071910.3347052-1-Perry.Yuan@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT082:EE_|DS7PR12MB6312:EE_ X-MS-Office365-Filtering-Correlation-Id: 8c1c4c90-5988-4516-ba97-08dac86c185d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GRuWTCgBS3nXYKL8ven5p1qlEIuK0tAm2kMmlJAnleZrH77zYaVuU/l3NOZ1eAV+WuC6gGvmp8gSPbGTxDJB86RbxYJmwjMXuxKMGTg+zJu/P1zkXOCy+HaOEu8Y9ostz6cwAD4dIsX6EBGzztZHBr3m6d/2i5uWCLkz7D0j3an9t3zqaVSS+B28Il1wXMePoihs3oE5hqzNAWRz1w+mpKN2mQMfUahfY4bmXUhhgOzb++zEMljFqaCZNnfV50PJTRLfNMFhEZK+EJAb25VztgSv/7jxmkz5GbYQ8YHAq3MoAMW4byZAe6MWhiPSsvEe6vCRK8Vfmiv2GYyRkxd4XsweQC6bDcY9prDwtlR62OjPfcbSDDJlCWU3ZBZc0hsILOr+fl4blVVPTAOJ3CmpBueDJVQXSDcOLiewliw1MUPz+Vbgby4a4t5MiVRRc80R3wR0mKDY2O+WCItsnmJzW4uCFVeHmSMlL3Q+8sr5Hbj7xPPfpLxmhpXSnPNmgdirQRkKTK8KW53HPVhxgzZPT0wHiw3s7nwMIlqVxPYAr8sotGXhHjnAh93gd+pf5SrmttahiYdHdtASbKpbAK3JYIwdTdzaCVXb7xFVpmapA+4nreNgSg8LQq+i8XPhZFaRE5mq/lnhhFAMXMQznpb8lMPazVtubWzvsgtHnVAwNXhWmYxTz0PTw1LyE30UJLBA2o9x46kmU2GhDyIpmz0l48FdZD3/ByID02lJ5rQdEEZ7oSuQ9AXkpZYtTb3WTMUw X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(136003)(396003)(346002)(451199015)(46966006)(36840700001)(40470700004)(47076005)(2616005)(6636002)(54906003)(7696005)(83380400001)(41300700001)(316002)(36860700001)(40460700003)(2906002)(26005)(8936002)(16526019)(5660300002)(40480700001)(426003)(70586007)(336012)(186003)(36756003)(1076003)(8676002)(70206006)(4326008)(478600001)(82310400005)(82740400003)(86362001)(110136005)(6666004)(81166007)(356005)(36900700001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 07:19:41.5603 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8c1c4c90-5988-4516-ba97-08dac86c185d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT082.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6312 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749727313443651040?= X-GMAIL-MSGID: =?utf-8?q?1749727313443651040?= Currently when the amd-pstate and acpi_cpufreq are both built into kernel as module driver, amd-pstate will not be loaded by default in this case. Change amd-pstate driver as built-in type, it will resolve the loading sequence problem to allow user to make amd-pstate driver as the default cpufreq scaling driver. Fixes: ec437d71db77 ("cpufreq: amd-pstate: Introduce a new AMD P-State driver to support future processors") Reviewed-by: Gautham R. Shenoy Tested-by: Wyes Karny Signed-off-by: Perry Yuan --- drivers/cpufreq/Kconfig.x86 | 2 +- drivers/cpufreq/amd-pstate.c | 11 +---------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/cpufreq/Kconfig.x86 b/drivers/cpufreq/Kconfig.x86 index 310779b07daf..00476e94db90 100644 --- a/drivers/cpufreq/Kconfig.x86 +++ b/drivers/cpufreq/Kconfig.x86 @@ -35,7 +35,7 @@ config X86_PCC_CPUFREQ If in doubt, say N. config X86_AMD_PSTATE - tristate "AMD Processor P-State driver" + bool "AMD Processor P-State driver" depends on X86 && ACPI select ACPI_PROCESSOR select ACPI_CPPC_LIB if X86_64 diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index d844c6f97caf..701f49d6d240 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -663,16 +663,7 @@ static int __init amd_pstate_init(void) return ret; } - -static void __exit amd_pstate_exit(void) -{ - cpufreq_unregister_driver(&amd_pstate_driver); - - amd_pstate_enable(false); -} - -module_init(amd_pstate_init); -module_exit(amd_pstate_exit); +device_initcall(amd_pstate_init); MODULE_AUTHOR("Huang Rui "); MODULE_DESCRIPTION("AMD Processor P-state Frequency Driver"); From patchwork Thu Nov 17 07:19:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 21479 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp259156wrr; Wed, 16 Nov 2022 23:27:04 -0800 (PST) X-Google-Smtp-Source: AA0mqf5SR/cJimkedAYDoNasb0wzIAC3C4JLWamrPh+qmz4tapjvqumJrHkl+7IjNmkgx68oDmKf X-Received: by 2002:aa7:9245:0:b0:571:3fb3:9b5f with SMTP id 5-20020aa79245000000b005713fb39b5fmr1671780pfp.86.1668670023892; Wed, 16 Nov 2022 23:27:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1668670023; cv=pass; d=google.com; s=arc-20160816; b=WLysV7AUuszg84ad5GhiDHDfXohYK2GODjM0O5NRVu9x6TpLGgicxNAqyytpNxPwYn zjvLwv3i+0lFtVDLDwaeG236qRfj+o1Z5pH4PvN9HV01eqBgShKSTu6Dv6aoB56ZXljf qCkLun82HHa+dL0AZQtpyyTWM/lj2LIxMCgkrMkaSqTsaSs1tU4e91NgbXWWINHR1rCm rtb+Vu6sKEtsX+/GAfSfEkUQp5hlJs+cgmTiC6V78wx1kOSc5rlob3qI+tzP2vSXpCLf kwn+B7xQJT+t3gOgufxstwzs5cyR3powgW1GXREiq21NfiAfdKzsjWyVBEeSQ3LJwHCO pI2Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Mzj+G/NDUgm12qniFY4iwEXGr4N39aX24gxB9mTyF2k=; b=usIB0vmg8KInCWTD1TwbT+2yRmNvs7Tjb9fikR7EsbR3NHGM8lPfCKPI8PdOgi3Ad2 HIcTJH6ETrIkrcdkGIpSHjpLtHvXEUscK7wRqjGHpPhCxV8+6SbKORosN5V0fg3gOv3D +AkikZw5lgOQk/XyYMnkele6Zl2OyYBsK5OUFkZo/D1QE211rD4fKefJlHqlI0LFnUSu dBHMImB8L8stGYDJDWJJXkmuwIlJDyHaXdJEfX1REqdB3TN2yOeZ6gOf8xsLwhSMw9yJ 5/GVYhxCSNKHboojGP+nj0UWYZT1xh/9fwndQnYbQt31UfzBA94hP7mfTfY8yYns0PTF BmQw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=1AS3IcZR; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f10-20020a63f74a000000b0046f4d39c588si286139pgk.580.2022.11.16.23.26.48; Wed, 16 Nov 2022 23:27:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=1AS3IcZR; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239306AbiKQHUG (ORCPT + 99 others); Thu, 17 Nov 2022 02:20:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239241AbiKQHTy (ORCPT ); Thu, 17 Nov 2022 02:19:54 -0500 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0334570190; Wed, 16 Nov 2022 23:19:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZOJqiQIpvDZpCpmPX314C9v6EQ7lYIuwayh9v/9p1LFkmlxACa4Q3xpc3Q2McPUGVxTvEFzjHEouOlQBF/LZBxsNFyhmElO4Gu0RZCgmu4XTLJ3I+8opOxM9YSIKKEuNYpV+GbeYxObQodmc38+G/kkZJ287X24muxRccZwjAv5qB2QXLuJhG7vfXFaWbFIYmV2Nu88+0XN/GzDTf0DZESrqeu6jUk+BZuxtPQRQPFZSj+nSIgbUec5NGh78M4TbUJkywJaMbxu5BO9X6i16zANp7OINV5nP/ZkBmi6Sx7RAJH6oX6l4mXwP+uOtskb6713t7lucVZrM6ZbSCrStLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mzj+G/NDUgm12qniFY4iwEXGr4N39aX24gxB9mTyF2k=; b=W3Wdbncu/pVLTDp4MV3ODJ6TfGcE/9H8F1zLzwjTZ44fiV4s4t/m1hKhI67PyRiuDXShgYQ4dW+x0Ffojt1mpyYDSiCGR3ShDe6WGyn46jdq4a6fHbJziUw7EvAS2nUqQpStnPB8o+p/H1vdRmfynF0v5T0WQoFH6GLJ4GJ0dPwgJMQrPh9JQTJmtOJA2Z4qYJXUk/D9AB8EVI5DvLA2L7T8NqOSjN4hO+0aqjuFNniqgeXzg493/OwlI2YqzEWFnNZ+QnLLfPNDKwzWzYhQcVXev7Yv4FHWpjVARiMjt0TxPJig6h13ZrOds4/xcvCOAjKeMEyO7TAqgHcwvdSrDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mzj+G/NDUgm12qniFY4iwEXGr4N39aX24gxB9mTyF2k=; b=1AS3IcZRkiOS2yMax/Xxxd6lkULZcJZ9204b1LK2ktQ9ra22+18MsVp89TWnjul+H/kS0ek9cleOrTC4sIG77Ac0MAvlrE8YXUpVoykYWnsjssp2GbWxkYTkxo5JozRLDXRN5ZuAUFUWWOv4Ef55sruUuVqwdHYwM7ZIlZY8R4k= Received: from MW4PR04CA0302.namprd04.prod.outlook.com (2603:10b6:303:82::7) by CH3PR12MB7617.namprd12.prod.outlook.com (2603:10b6:610:140::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Thu, 17 Nov 2022 07:19:46 +0000 Received: from CO1NAM11FT040.eop-nam11.prod.protection.outlook.com (2603:10b6:303:82:cafe::18) by MW4PR04CA0302.outlook.office365.com (2603:10b6:303:82::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20 via Frontend Transport; Thu, 17 Nov 2022 07:19:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT040.mail.protection.outlook.com (10.13.174.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 07:19:45 +0000 Received: from pyuan-Cloudripper.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 01:19:40 -0600 From: Perry Yuan To: , , , CC: , , , , , , , , , , , Perry Yuan Subject: [PATCH v2 3/5] cpufreq: amd-pstate: add amd-pstate driver parameter for mode selection Date: Thu, 17 Nov 2022 15:19:08 +0800 Message-ID: <20221117071910.3347052-4-Perry.Yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117071910.3347052-1-Perry.Yuan@amd.com> References: <20221117071910.3347052-1-Perry.Yuan@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT040:EE_|CH3PR12MB7617:EE_ X-MS-Office365-Filtering-Correlation-Id: 84a04cd5-b4cf-4dc0-18cd-08dac86c1ab7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sLV7zbbGYcw1s/Ldq3kgQBtpPSOlZzo8DgMug0rB+h//5psmzRQNzqITn2ql2BNK59G+7/lYKROJPzvONPQb7d3ZNY+uwuKJq9zO5Opnn35U17lixRT//u4mE6Oh0NbP9UvSD+u2Nf6rqtS9gH8yKekGjAnhD4Q8AkbyvrTASpHs2xSRENgLYmwRGkETXySpwP7ARpEfA4JKkh8clfFgQ9gIcB7Y8CG19m6+BGZM1x2Hmilh1ouCwf7vsT1W4c1wU4IpqpiDDJvbl7yLHOZYxY/lp6PICCUXphmnajG6NbpJe/okrwvYaU5XWjZ8fco2QRXS9gkhLzL+LbLOb8VOZZnSjNwCgN7TZ/QX85glsD0cRC0OYvr3a5i2zMvTvo7xMCqyU5qg7VEEm5XNRNQwwlQ5Uai4SVt11eEeSJavxZ6gA2cmqhTNNt4lFiPvU+JO65tAleKpEF4DhSu4Yk49WfkYA3g3QX+z+5mQIb+/onWRLGFewDK3GtgqUp9vnEFVzcALdLAaPeFIqLGCXal9/tN2DI27Wznf2muXepteK0pW/DXpkP1+e0YI8/z9qqwpbSzR4m5ljWGrvL3+oHAVkoqpOu5hdBM951Qn08ODT70yMva2y3C2coI3HxX23nAM+3MiTi6cO+kqKeW5+7iszU8vvoSCMW6ftej5BppYmr60qPKgiLmNi8iNBQCshus7VDN1V9nyHpjbOuUcMER3Ycivts7JZGpnGPg7xzjrL8mttC/kllrW2LAmgxsq0v1Z X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(136003)(346002)(376002)(396003)(39860400002)(451199015)(36840700001)(40470700004)(46966006)(36756003)(26005)(186003)(86362001)(81166007)(36860700001)(356005)(82740400003)(82310400005)(83380400001)(2616005)(40460700003)(336012)(16526019)(1076003)(426003)(47076005)(110136005)(2906002)(5660300002)(7696005)(6666004)(8936002)(478600001)(41300700001)(40480700001)(6636002)(54906003)(70586007)(316002)(70206006)(4326008)(8676002)(36900700001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 07:19:45.4858 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 84a04cd5-b4cf-4dc0-18cd-08dac86c1ab7 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT040.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7617 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749727339048811604?= X-GMAIL-MSGID: =?utf-8?q?1749727339048811604?= When the amd_pstate driver is built-in users still need a method to be able enable or disable it depending upon their circumstance. Add support for an early parameter to do this. There is some performance degradation on a number of ASICs in the passive mode. This performance issue was originally discovered in shared memory systems but it has been proven that certain workloads on MSR systems also suffer performance issues. Set the amd-pstate driver as disabled by default to temporarily mitigate the performance problem. 1) with `amd_pstate=disable`, pstate driver will be disabled to load at kernel booting. 2) with `amd_pstate=passive`, pstate driver will be enabled and loaded as non-autonomous working mode supported in the low-level power management firmware. 3) If neither parameter is specified, the driver will be disabled by default to avoid triggering performance regressions in certain ASICs Reviewed-by: Gautham R. Shenoy Tested-by: Wyes Karny Signed-off-by: Perry Yuan --- drivers/cpufreq/amd-pstate.c | 36 +++++++++++++++++++++++++++--------- 1 file changed, 27 insertions(+), 9 deletions(-) diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 701f49d6d240..204e39006dda 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -59,12 +59,8 @@ * we disable it by default to go acpi-cpufreq on these processors and add a * module parameter to be able to enable it manually for debugging. */ -static bool shared_mem = false; -module_param(shared_mem, bool, 0444); -MODULE_PARM_DESC(shared_mem, - "enable amd-pstate on processors with shared memory solution (false = disabled (default), true = enabled)"); - static struct cpufreq_driver amd_pstate_driver; +static int cppc_load __initdata; static inline int pstate_enable(bool enable) { @@ -626,6 +622,15 @@ static int __init amd_pstate_init(void) if (boot_cpu_data.x86_vendor != X86_VENDOR_AMD) return -ENODEV; + /* + * by default the pstate driver is disabled to load + * enable the amd_pstate passive mode driver explicitly + * with amd_pstate=passive in kernel command line + */ + if (!cppc_load) { + pr_debug("driver load is disabled, boot with amd_pstate=passive to enable this\n"); + return -ENODEV; + } if (!acpi_cpc_valid()) { pr_warn_once("the _CPC object is not present in SBIOS or ACPI disabled\n"); @@ -640,13 +645,11 @@ static int __init amd_pstate_init(void) if (boot_cpu_has(X86_FEATURE_CPPC)) { pr_debug("AMD CPPC MSR based functionality is supported\n"); amd_pstate_driver.adjust_perf = amd_pstate_adjust_perf; - } else if (shared_mem) { + } else { + pr_debug("AMD CPPC shared memory based functionality is supported\n"); static_call_update(amd_pstate_enable, cppc_enable); static_call_update(amd_pstate_init_perf, cppc_init_perf); static_call_update(amd_pstate_update_perf, cppc_update_perf); - } else { - pr_info("This processor supports shared memory solution, you can enable it with amd_pstate.shared_mem=1\n"); - return -ENODEV; } /* enable amd pstate feature */ @@ -665,6 +668,21 @@ static int __init amd_pstate_init(void) } device_initcall(amd_pstate_init); +static int __init amd_pstate_param(char *str) +{ + if (!str) + return -EINVAL; + + if (!strcmp(str, "disable")) { + cppc_load = 0; + pr_info("driver is explicitly disabled\n"); + } else if (!strcmp(str, "passive")) + cppc_load = 1; + + return 0; +} +early_param("amd_pstate", amd_pstate_param); + MODULE_AUTHOR("Huang Rui "); MODULE_DESCRIPTION("AMD Processor P-state Frequency Driver"); MODULE_LICENSE("GPL"); From patchwork Thu Nov 17 07:19:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 21480 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp259469wrr; Wed, 16 Nov 2022 23:28:03 -0800 (PST) X-Google-Smtp-Source: AA0mqf5BECbcOtnitaZXl9b9hzOEwYuTihIs+NYqLfYaoWyPrj7IKFaLEcguo7OhC8W3c+jmWfTA X-Received: by 2002:a05:6402:915:b0:467:d741:f359 with SMTP id g21-20020a056402091500b00467d741f359mr1111875edz.100.1668670083511; Wed, 16 Nov 2022 23:28:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1668670083; cv=pass; d=google.com; s=arc-20160816; b=ISyGPBU+EsEz8bPk1FVm108a/f4u6/u+nDwc0wWLKrOIdJyxNRoGTSQF3QfCtXE7Fp qMCQ1TrNlT6Lb1afo+Xf6NNN0eU0BM4PIcMCjoYLUPaUHKUWdjY6PxmyJUjSsZs5nqsz qzUzPJPFyTvEiaosJLbGq80b7XM0DS+YMZg8hz0VrqB5MEFiPhZhEYFSckjU/yIxhLt4 il0Ev+LSA+jqrMjYx+fZe/jXseqMVPpMEWCc5SJ2MxJ6SVIy6e0v3GBIThkpLYdWKyv6 /OAWPvNE1kmWjNhj3cyF34FXt5WVKQY2mvCNOS9kw0YsKftuQSIUflBN+Rrt5fnC73KU K8mg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1lLwQ1RXi32JXc6ZkMW7tZFU84/CRCpBUME7bsJbU0w=; b=l1BIHdxsM8kDODOCfSUhLvENi0Xi7NBfkxmZbefVNLwJU14/MUr25aTx4MabByGu0H 7njXsWNWtV8IP6yVj2lWvncTBbEwRzRyBlDN0lkMg5+Nl+Ktc0pNnGMv+WmEc7TN7l52 +eJkCXiaP83+jeXwob85KPkaMtnafbw9qeSK2KsXPjFPuLTWhbecWRrJ8TiyTkN5duVU 7MCjUVte9HHAOKdqYb0mg7NqTT20Tawt3elsNLN1fjIfBuwwHEMBtOZZoDk2IdsrZI33 uyvX0Yhu7KP2SdtA8zdPB3DM8zvU5ogGcUZwoEHIS1ywe7KnEiIjMjgy+A+v9hIxYqkV tsUQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=SAPjlJ9l; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id go10-20020a1709070d8a00b007ae4ed41508si15856590ejc.738.2022.11.16.23.27.40; Wed, 16 Nov 2022 23:28:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=SAPjlJ9l; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239241AbiKQHUs (ORCPT + 99 others); Thu, 17 Nov 2022 02:20:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239321AbiKQHU0 (ORCPT ); Thu, 17 Nov 2022 02:20:26 -0500 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2046.outbound.protection.outlook.com [40.107.212.46]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6191770181; Wed, 16 Nov 2022 23:20:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bUJqmVedWM63jr+SJd9mkycpXqS2UNKswo3ny8l6fpDYZN0OMu5TpLxSUWyeOmQ7XCZWBk0ZRqGY5/S4lwRBrzDuRf85r+flVK3oyIiPOqKg902Gajv+TR0SxmRDVIgh7mPO8bT5pFS0Q+DpHhhQvPuGD7UbWG9ApNpzwi0BWJpsvOqXY0du3teV4Jf6kRj1dvx/UqKPNP56rteWTtVTCHlXyRfXAzLC7dydrGIs/cQZ1I3uaB/ozSbCuh6r3O91aNNilQ+7KTbCzp6ZyKgCXcB1cSeE8ZVwPJxi9/fYDBnYTdtK6tfHEWDxQ4yO767XMjBaQkfnQKxHVZd1kCM3Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1lLwQ1RXi32JXc6ZkMW7tZFU84/CRCpBUME7bsJbU0w=; b=inwhDZ6u78xpP0eKKWbbQnKbB199RIyTVJg9K1X+qsOu9MexNMJlsGqaTNg4sLnNF/ZkzkwXQEazSN2xs54VwVxm2jFiZYFbHQyGYUnfYaWmBFGaTjfTHeGVC7mrDLzaIxVqkUrryL3PBAA/2MpD7rxDAWW+31ag8NMQjQp/Pjqs13nNjZU3hPQYg6LfHN2XdiJYSpTqvkrKG4I1EkmaU0/sMgvGl/Bw2fKQgBQCDyWFKBr7xHo9cdt3pFeSWakLkE78xVSuOpHMuOLjSdhga0VOkpkAIx6dFumUy7z8CKzLTGVeGxe3RJOMvn9oPfbudKPs4A35V4Cp0wOtiFLzAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1lLwQ1RXi32JXc6ZkMW7tZFU84/CRCpBUME7bsJbU0w=; b=SAPjlJ9lBgRs8bIdwJa+BgK1zUWlKDZ9TRNWVQvlS2HfJ3PUt1Bp1jL3gmKO1nbFQhftD6AiC75kKREPJGKPjDIUMZUlITU0iayE1xROwQ6I/V0Fm8KroLz2UVkssK40mHzvcQAXq78m8a/NybE88+aEEgN81KHHjGFuT8ujD44= Received: from MW3PR05CA0017.namprd05.prod.outlook.com (2603:10b6:303:2b::22) by LV2PR12MB5751.namprd12.prod.outlook.com (2603:10b6:408:17d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.19; Thu, 17 Nov 2022 07:20:17 +0000 Received: from CO1NAM11FT103.eop-nam11.prod.protection.outlook.com (2603:10b6:303:2b:cafe::21) by MW3PR05CA0017.outlook.office365.com (2603:10b6:303:2b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.8 via Frontend Transport; Thu, 17 Nov 2022 07:20:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT103.mail.protection.outlook.com (10.13.174.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 07:20:16 +0000 Received: from pyuan-Cloudripper.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 01:19:44 -0600 From: Perry Yuan To: , , , CC: , , , , , , , , , , , Perry Yuan Subject: [PATCH v2 4/5] Documentation: amd-pstate: add driver working mode introduction Date: Thu, 17 Nov 2022 15:19:09 +0800 Message-ID: <20221117071910.3347052-5-Perry.Yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117071910.3347052-1-Perry.Yuan@amd.com> References: <20221117071910.3347052-1-Perry.Yuan@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT103:EE_|LV2PR12MB5751:EE_ X-MS-Office365-Filtering-Correlation-Id: e9390d85-c059-4cf3-231b-08dac86c2d53 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yBk6g8PE+PbsXfU9pjZujnd95O86MFDaSOHAxmjAFmWJUUbWO9dkMxMlDN71FQO1GA+1fAX3CPwwI2MmHXFxZJRZQdr9DpEh6pJCQqmx78RHT1fdTt8DXyhEhz7USPo8UT1UJqr/ObGwnPKq4GOsDWvS5sqlMcx9QREGHLHo7yTM5cYsM29ZWY7VVQYKcvQL05Cj6aCxbkzT4mtXU+X2w/uQV61FINzbWiR154Ap+XOw5JG+iP7k1hiyanAgOMrl578yiWP3haEcWNTsgLaertc94xaN67e5b91/6XmuqS+MuCVZHBKgx9z3oHE7cwOsGV6uMZ5xXU6NwWTAjhtfvwDuntiuLTbgYPkssq3ucCDQCfQ7D956sAzWQt2X+e8PQEAyRMkw4XlzGQu5wEthB2h5I9jHKJ7FbGOyKk3qx6C/j2zO96gIzVEtJVBRu7F+KO7A4VKzRaV4VGrr0NsV4QF94UF1ycE/zmdHWsHOjHJd8G/qDeVLhY41L6q5s3dA0EIw8H7f/aZfN5aimoQ2aGrHsM1wQ2kCS/Y9AvMbQzSzfJetwB9L7nDR57gnNagZcfv9Ckz9E+ww4gXkOpE6V6rHEcFR3qj45vSJ+63jNHF7WJYpqNk5hoeee0O1mcqNkbsQZGev25S9JSj9u8K/FkVluX2B1/E0h0+qHwAaVrdNlxRnk+IHx38kP/gFN2zkombWJtLiwFRiym7gTpp0IyxGlwUOua4Dd+vIVWp/tCqRLky3XIqZDFu5XUAjNqh2AFGkbCAIT7850rgZhyIbMm2pivtPsbYpKoAZiSHdAv4= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(376002)(136003)(396003)(39860400002)(346002)(451199015)(46966006)(40470700004)(36840700001)(86362001)(8936002)(70586007)(8676002)(4326008)(36756003)(70206006)(5660300002)(40460700003)(47076005)(83380400001)(16526019)(478600001)(26005)(7696005)(6666004)(186003)(2616005)(426003)(336012)(1076003)(81166007)(54906003)(316002)(6636002)(356005)(82740400003)(40480700001)(2906002)(36860700001)(82310400005)(110136005)(41300700001)(2101003)(36900700001)(473944003);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 07:20:16.7074 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e9390d85-c059-4cf3-231b-08dac86c2d53 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT103.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5751 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749727401557155098?= X-GMAIL-MSGID: =?utf-8?q?1749727401557155098?= Introduce the `amd_pstate` driver new working mode with `amd_pstate=passive` added to kernel command line. If there is no passive mode enabled by user, amd_pstate driver will be disabled by default for now. Reviewed-by: Gautham R. Shenoy Tested-by: Wyes Karny Signed-off-by: Perry Yuan --- Documentation/admin-guide/pm/amd-pstate.rst | 30 +++++++++------------ 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst index 8f3d30c5a0d8..06e23538f79c 100644 --- a/Documentation/admin-guide/pm/amd-pstate.rst +++ b/Documentation/admin-guide/pm/amd-pstate.rst @@ -283,23 +283,19 @@ efficiency frequency management method on AMD processors. Kernel Module Options for ``amd-pstate`` ========================================= -.. _shared_mem: - -``shared_mem`` -Use a module param (shared_mem) to enable related processors manually with -**amd_pstate.shared_mem=1**. -Due to the performance issue on the processors with `Shared Memory Support -`_, we disable it presently and will re-enable this by default -once we address performance issue with this solution. - -To check whether the current processor is using `Full MSR Support `_ -or `Shared Memory Support `_ : :: - - ray@hr-test1:~$ lscpu | grep cppc - Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc cpuid extd_apicid aperfmperf rapl pni pclmulqdq monitor ssse3 fma cx16 sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw ibs skinit wdt tce topoext perfctr_core perfctr_nb bpext perfctr_llc mwaitx cpb cat_l3 cdp_l3 hw_pstate ssbd mba ibrs ibpb stibp vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid cqm rdt_a rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local clzero irperf xsaveerptr rdpru wbnoinvd cppc arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic v_vmsave_vmload vgif v_spec_ctrl umip pku ospke vaes vpclmulqdq rdpid overflow_recov succor smca fsrm - -If the CPU flags have ``cppc``, then this processor supports `Full MSR Support -`_. Otherwise, it supports `Shared Memory Support `_. +Passive Mode +------------ + +``amd_pstate=passive`` + +It will be enabled if the ``amd_pstate=passive`` is passed to the kernel in the command line. +In this mode, ``amd_pstate`` driver software specifies a desired QoS target in the CPPC +performance scale as a relative number. This can be expressed as percentage of nominal +performance (infrastructure max). Below the nominal sustained performance level, +desired performance expresses the average performance level of the processor subject +to the Performance Reduction Tolerance register. Above the nominal performance level, +processor must provide at least nominal performance requested and go higher if current +operating conditions allow. ``cpupower`` tool support for ``amd-pstate`` From patchwork Thu Nov 17 07:19:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Yuan, Perry" X-Patchwork-Id: 21481 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp259627wrr; Wed, 16 Nov 2022 23:28:39 -0800 (PST) X-Google-Smtp-Source: AA0mqf61zYqgdxJ6dZD0re5028Z8v4Efy/bSMiOc6LDfGi6hFAkdUza7QWh9ntMW2Ot51q0JDP7a X-Received: by 2002:a62:f24e:0:b0:572:149c:e278 with SMTP id y14-20020a62f24e000000b00572149ce278mr1847794pfl.8.1668670119073; Wed, 16 Nov 2022 23:28:39 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1668670119; cv=pass; d=google.com; s=arc-20160816; b=xtrAgUlHyvAc/GmqpBClrfXPZlRai85Or39jmRdn9R13AwSdifhdX6EgXWa/MBAfeH ddLUf+edTSuh6eecmYrq2QaD8JZqlgvza5iAfC1MTsGZyEcaXNoEQAKOGpa4ecglugOA bT/rkFybkTcG9e8QYrU7I+7JhaseAM+KWGAUitji+DeeeKgKm5YVUFO/1qZ33ECfupH4 FJcL0ON0ngmS0lP/lnevgRO9zepwbaDb+NRgxtPJ9bakWJfD0QTDqJ+bZF8jC1Yy0NNy KPrlb4V+6OhljM9CT95bWxTe6BWfTeGH5V54w/2saQoVfFL7+OF+u4FD441+6c5aXLla lOeQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=twNCEF+3Cm30wI7GPDmqmf+pT9ExxrwwuLBiy4lneVs=; b=Faw/W0pL0cnDrFqIWiAjvUtwouU2xtcLcYJk0jbPsJ5lkHciis988tRCdLDzNJiZEC yFpOlboAfzrqMRXYgqNgdxqOaHO/rsxL9kgkRDisDdCTa+Uxxb19k8ReXU/XlI2cgc4D sfSqKe1BX2liw+D2dnSEDjF1kFGfXNbsJ5ArqfrJUR1OYeC4yyzhESyZlCr2x2NlzPnb c78Fk4wvUHdZn0nBlrxjBOxyArzI5h8rxse5TW+DdhlN2orDXlvHg1+DX6gl0OfwXe+n zxmBrbeR3cyOR3KtkHWykYo12UeFbrxiv5w7nosgUJwjWqMf9LzxMOvKNfC9tLdJE1KG rChw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=sLyNlWpr; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t19-20020a63f353000000b0043c3f90f7c8si262363pgj.655.2022.11.16.23.28.25; Wed, 16 Nov 2022 23:28:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=sLyNlWpr; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239274AbiKQHVG (ORCPT + 99 others); Thu, 17 Nov 2022 02:21:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239263AbiKQHVC (ORCPT ); Thu, 17 Nov 2022 02:21:02 -0500 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50B4F6EB6C; Wed, 16 Nov 2022 23:21:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IHdiTMqwLnlrb5Fck6H5/7F+Fz65fQRTK2tahlqd8tq+kjGP4yxHl6vh6fQEtauUhMpA7xyug4Y1o+uVrWPvprVPFWNERCflemcVDEYpcLv1uWsvHVC7m9pngH1/4/+dBwg2k8/Z33KDVt0ag1ci76UWukXXWYLFwUTNoyeb4q/OnLbvn0BW1KbFtzRem+I2mknzQTNFXpfdWQan+yygP6ExTrBTm/pJ38UudkNYzvXTQ51mslxZUQ6W/c2sAFwQxOhV68BdtqMdQjZDX5E94dzrujA1/B9nMPwN1szHcrBCsuG8B6XBu/oPHARugAnTFHPTc5veEAb1NcfA0k19zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=twNCEF+3Cm30wI7GPDmqmf+pT9ExxrwwuLBiy4lneVs=; b=N7WD6PQf9mT1Mwk0s66PkEeZV/i6JbuKqWckbZUMZGkqIdO2wuymXZmBifquhjCROdu1XGbfol6CVQXHom47jG4t2h7cMj80EpsrGtQkyBfkyuDlr9wZ0VuouZMADJjzwgB1+UgpISp/d8yq7ncDwCc1KmWbMOasLOF80NllmnYuty8d6J4hkLbVlVEBkV4ORff5Qif2M5rgXvcnzRpDQN0GWNULaA5XCiowLgoVfIGhyzNMFXeMiHdY2/ATc+D04a3Am0Wcj4Dac4DWIPVoF5PioFEO6yspgV52G9nDbhYX58EjRv/rhWeWyLQiL0375KzNWLWBZVvn5PLqwZyTiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=twNCEF+3Cm30wI7GPDmqmf+pT9ExxrwwuLBiy4lneVs=; b=sLyNlWprdIywhQ0d7lzf9hY/BRUh+a6ptcspjea7ydq0AMFQZBF9tdZSYdx9OMctLIip7tH0GtwXIiIHH9YKEopQBDIt0J47vTtfF8p2/8oQpwbut+rUU+zg6IBiuoydW8/eWkAPFSo6XJszI0FFkMQQ4/pN4fUEGc7CSERpzNQ= Received: from MW4PR04CA0332.namprd04.prod.outlook.com (2603:10b6:303:8a::7) by DM4PR12MB5232.namprd12.prod.outlook.com (2603:10b6:5:39c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.20; Thu, 17 Nov 2022 07:20:59 +0000 Received: from CO1NAM11FT098.eop-nam11.prod.protection.outlook.com (2603:10b6:303:8a:cafe::8f) by MW4PR04CA0332.outlook.office365.com (2603:10b6:303:8a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.18 via Frontend Transport; Thu, 17 Nov 2022 07:20:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1NAM11FT098.mail.protection.outlook.com (10.13.174.207) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5834.8 via Frontend Transport; Thu, 17 Nov 2022 07:20:24 +0000 Received: from pyuan-Cloudripper.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 17 Nov 2022 01:19:55 -0600 From: Perry Yuan To: , , , CC: , , , , , , , , , , , Perry Yuan Subject: [PATCH v2 5/5] Documentation: add amd-pstate kernel command line options Date: Thu, 17 Nov 2022 15:19:10 +0800 Message-ID: <20221117071910.3347052-6-Perry.Yuan@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221117071910.3347052-1-Perry.Yuan@amd.com> References: <20221117071910.3347052-1-Perry.Yuan@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT098:EE_|DM4PR12MB5232:EE_ X-MS-Office365-Filtering-Correlation-Id: 4dd7b304-7656-4a04-1289-08dac86c4658 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o+vurTr6sfEERVlJ1u0aNR3Oaay3DHtH1VkHaSey08ajszMT7UW6tEJG0HfkXgMLnfAkmjV1HjWAq8OnghK8eef4+52/qrYeAQ4GPeAMm7W1wuXUmIm7/B9JhNNw3whEm+5YzkwkUGyhB6kyFueKSFJqZqXpiGMd1UTNvOV/DLQMhO7UUhITVlGchv8KD7Ii0m06ZpxWtxKdNFLBMTyLAfk53EJC7LXwlyuQ2bi1lJqwMck8BfMCQaQ2LGoVHfdThFbYO9lQTCalUkBCVTypiLPvNUi2/FBnGYBBjlSiInHwl9cSQxCaHVycXU5rTGMJceQS1ec14+nvAqYfpAOmS5MKDmVimoNfSO+mGKraqUXf/lA4mXymmzl4JUTt3UaZC5Xuqq7VBcxZC7rSfxLzxlxOf2JyD4NAhGFGqM02GTE/Grur6iWef84y8iag9FyllLqKWdnP8FDFBsC/ZXQTgk7sZXTbX6FhPUWASt5meEojRsLe35kuRM8l6S8TYUa6h9Q7MApGOOPO/pvFBzfZQ6GJ4XIQw+GH82xvZGrvhQl7s6TGGUYh6LKsBG6tZFTS0B6tvI6semqnw2SydnIy7tIe6fY7V8LdYaip0+I1c1jRQepqlTtUdou5K5ONTJjkEV5UGqdaaIpp3jht5tEdrHIBKa5ad5BJJ0wAeWjfpbsGDbFXJb1/MK1ouvB96lbYuJ4fRHj2Hmd/UxSjJTPf8dAQLIedwFPEAzcuCYNRv+4os8mHV1rmWVv1n9WHTBCL X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(396003)(136003)(376002)(451199015)(40470700004)(46966006)(36840700001)(186003)(1076003)(16526019)(40460700003)(5660300002)(336012)(7696005)(110136005)(316002)(54906003)(6636002)(41300700001)(2616005)(8936002)(26005)(70586007)(70206006)(36756003)(8676002)(4326008)(82310400005)(36860700001)(81166007)(356005)(82740400003)(2906002)(40480700001)(83380400001)(47076005)(426003)(86362001)(478600001)(6666004)(36900700001)(2101003);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2022 07:20:24.7634 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4dd7b304-7656-4a04-1289-08dac86c4658 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT098.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5232 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749727438935407223?= X-GMAIL-MSGID: =?utf-8?q?1749727438935407223?= Add a new amd pstate driver command line option to enable driver passive working mode via MSR and shared memory interface to request desired performance within abstract scale and the power management firmware (SMU) convert the perf requests into actual hardware pstates. Also the `disable` parameter can disable the pstate driver loading by adding `amd_pstate=disable` to kernel command line. Reviewed-by: Gautham R. Shenoy Tested-by: Wyes Karny Signed-off-by: Perry Yuan --- Documentation/admin-guide/kernel-parameters.txt | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index a465d5242774..42af9ca0127e 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -6959,3 +6959,14 @@ memory, and other data can't be written using xmon commands. off xmon is disabled. + + amd_pstate= [X86] + disable + Do not enable amd_pstate as the default + scaling driver for the supported processors + passive + Use amd_pstate as a scaling driver, driver requests a + desired performance on this abstract scale and the power + management firmware translates the requests into actual + hardware states (core frequency, data fabric and memory + clocks etc.)