From patchwork Fri Mar 1 07:48:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roman Smirnov X-Patchwork-Id: 208679 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp920718dyb; Thu, 29 Feb 2024 23:49:30 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX6zlgzJIEyM2d3BAE9rRvvclVXaIKvdoSmsxhFW4cdISxXlIRjWnCl9eXMfjew5PxpD0OMFvRLCu26HRkTcT5pdy7ZbQ== X-Google-Smtp-Source: AGHT+IF5WYEzbd8YVwet0QWRIInLgu+GYyWFsszzB0NRUkVLsf79oBF86X/Enjw9iAK6y/mAr0Ec X-Received: by 2002:a05:622a:48f:b0:42e:cef5:2af6 with SMTP id p15-20020a05622a048f00b0042ecef52af6mr127223qtx.49.1709279370584; Thu, 29 Feb 2024 23:49:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709279370; cv=pass; d=google.com; s=arc-20160816; b=mFRxgc+FG9nl4FtDwG4YJcxvaKp8NWjhUea432Y93AD1a2Mt5Odv75Zos4KDSDN3iS 9Jsg0nqdBMklRMjvIz4CmfkrIfaBcMpYNmiSQJ/bkwmgmKcwfDlQHfokmy5kYCAVmIxA b371wGSZRzYeLuuZPipa58ZOvvVjfGulr8Ul4SXiEoMDaJjVRtmks495xQy92mWd1uiC pGbmsDnxgy3uPXiS9rbo8pjsKpkQi/ZbDeS//8EDApXDVJwR3r4za381sf8KOG/xMXTy U/XUR+Y5NStEcmReXKMkxxJLoknIK3b7e51wIkNYTbUiJWfuLv4MbSnClbGnpV+1Lz5z annA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=dqM/7Huxurjj326o312CY70Gh/3WcV1rHKV4Be0fCEk=; fh=vS2DIshGwiXnQOBX+JfohZLp+LIEjgFwWtpde/H2ycQ=; b=zwa5MUSXwDY7/GZUXuuz5R+ANjLGTLNiLHOOCrnJiRYQ+1FVema6QnG8sHmWms+71q HhRDC0JRR2mxGLfj/0M4DY4mY5/bPTzHaKzR/1XiKD+aSgS0JlCq2o+AG+a9stLJoQDP 67hwoz/zuNgHsKn6RB6ONZ+m+2RG7Ujvgjdsk4PAWKZcgVcZtFXrBKwWFq+plELzC5mp PCoQF6gXzrejYItVhKIn+YybfNjLfJfFpQtq2ficRZ8W8LTUm2f+mIfw60g38s4uhZJY 8OljJouOo1CqEihlCRw+rM+c7KemauNp21lWobWb6Km2Pap+Mi9KASu9mxEqic0Bq4aH SeeA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-88028-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88028-ouuuleilei=gmail.com@vger.kernel.org" Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id j5-20020a05620a0a4500b00787184953bcsi2958934qka.720.2024.02.29.23.49.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 23:49:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-88028-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-88028-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88028-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 5D97D1C20D6A for ; Fri, 1 Mar 2024 07:49:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0C8F769D28; Fri, 1 Mar 2024 07:49:05 +0000 (UTC) Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA3C76996E; Fri, 1 Mar 2024 07:48:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709279343; cv=none; b=RT8zM/tOfiz5P9FPd7P0GhSEDuMT7an85ZkUm8t/fRkRdyU8Z8CAdDimtNnvD33VUSy444ziIuUru5wcVp8Ht6y7gT5sIQrI0EKR4LWQeZq412LAX3/vi+/YjuFXzusgJNc7co9Ld+gC81CCv/PidE6mdAH3XJmLpyH7ujN/Z1g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709279343; c=relaxed/simple; bh=Sh9E/gkk6zKcCqGFDs3nWgIrwzR1EwNjJIGq/iqvfnU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Zjz16RDav6HQ9/pg1xDK79NUdxs71ZMZ9xvT7VCyEkag7qCr/evK41eEyiv4iA9v3nGtvGLE7sKIHqGdP/vGAYMHPCW1lUDYSeV7iu3+1trBpN71M+XIXDlN3pT3QBJ4KrxmE6ylRGCuBDYuGTSk6TFj7ZFJHHcv6LB9O8OszbU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from r.smirnovsmtp.omp.ru (10.189.215.22) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Fri, 1 Mar 2024 10:48:47 +0300 From: Roman Smirnov To: Marcel Holtmann CC: Roman Smirnov , Johan Hedberg , Luiz Augusto von Dentz , Sergey Shtylyov , , , Subject: [PATCH 1/2] Bluetooth: mgmt: remove useless NULL check in mgmt_set_connectable_complete() Date: Fri, 1 Mar 2024 07:48:23 +0000 Message-ID: <20240301074824.1259409-2-r.smirnov@omp.ru> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240301074824.1259409-1-r.smirnov@omp.ru> References: <20240301074824.1259409-1-r.smirnov@omp.ru> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 03/01/2024 07:24:14 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 0 X-KSE-AntiSpam-Info: Lua profiles 183879 [Mar 01 2024] X-KSE-AntiSpam-Info: Version: 6.1.0.3 X-KSE-AntiSpam-Info: Envelope from: r.smirnov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 7 0.3.7 6d6bf5bd8eea7373134f756a2fd73e9456bb7d1a X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: omp.ru:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;r.smirnovsmtp.omp.ru:7.1.1;127.0.0.199:7.1.2 X-KSE-AntiSpam-Info: FromAlignment: s X-KSE-AntiSpam-Info: Rate: 0 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 03/01/2024 07:28:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 3/1/2024 3:59:00 AM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792309324945367831 X-GMAIL-MSGID: 1792309324945367831 Remove the cmd pointer NULL check in mgmt_set_connectable_complete() because it occurs earlier in set_connectable(). This check is also unnecessary because the pointer is dereferenced just before it. Found by Linux Verification Center (linuxtesting.org) with Svace. Signed-off-by: Roman Smirnov Reviewed-by: Sergey Shtylyov --- net/bluetooth/mgmt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c index bb72ff6eb22f..cd8c4e094c55 100644 --- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c @@ -1702,8 +1702,7 @@ static void mgmt_set_connectable_complete(struct hci_dev *hdev, void *data, new_settings(hdev, cmd->sk); done: - if (cmd) - mgmt_pending_remove(cmd); + mgmt_pending_remove(cmd); hci_dev_unlock(hdev); } From patchwork Fri Mar 1 07:48:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roman Smirnov X-Patchwork-Id: 208680 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp921778dyb; Thu, 29 Feb 2024 23:52:57 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXKla9uE14kl4lu6/KopBSbAeJhDHhSdLiPIzBLKHbc2S5zvVhzGUHEL1sNjdufxPAVKT+xWZUej983kPaPWKaOw9IacA== X-Google-Smtp-Source: AGHT+IFQNBmImcgc4IDP59qQT8QcZmge1TTkuO87hIvnKntePWbXPKXqM7XkqxbYZ7LdG3X8HI8j X-Received: by 2002:a05:6358:e48d:b0:17b:8830:628c with SMTP id by13-20020a056358e48d00b0017b8830628cmr975228rwb.2.1709279577584; Thu, 29 Feb 2024 23:52:57 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709279577; cv=pass; d=google.com; s=arc-20160816; b=q1ZOBvdaJUi1552JpWBBPvOJo5lLB6O8SAulvkfywETS7Cxu6ODDxvTBOkWxYB1FFa I1JkIXXSqSUL46DcN5662IEly3geR9i8jLwo22W/97qPHy79ZoSKMLLlFWYinka+IYC+ DRX9KkysX4M/jkxA71Ji+qEvq1h1jn3h+0bzjXGRGBc8qQR90IgsAr6ZYNEzoQxu6qru loN2FB1Le+c5zTURfuT0NFaGr82UxhJisRgk74apd966dsGdZWSyFvcsr7CApF7RlBIl MTQAttrO2C2nfdJHcP6DKgyi8JzmLjO79arGakSQHXjE7LeaCaM76nbHZToDHt9lNT3h sv+A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=iwipTwtXq6VWeU5qg/sqPbexiMh7ZCx3dRbjDr7P61U=; fh=vS2DIshGwiXnQOBX+JfohZLp+LIEjgFwWtpde/H2ycQ=; b=GVenu2MVtWvj14EN/Zisb5CFstAk9gkYEW+8AR3yxCjqFqPmjqh1ZZU2tX9A/Q+vph tPyFfs29Xvw4SWrDXv8/vfDr2nracGarfGguxWlV5cwuGkHN7WxptapT1c5Bdo1uqr3i otPOWs2jao7SkecQLv+1k7dusu46m1H7jp0c5U0eY99Xg4wl/lo8IpkGHMf8E6+30q+i hUGmkdwSbPSSnNrW/d5k9KH5DgD1M2mxXU3wBQhmMfEFpphDZOWjNz+xyLoQQ9C9y6T1 PQ0feqN16fNnuz7vysE0okYj7z1EQAVcW/wxumQWdRQ/GBjz2Won4jg/6rz5bXL52Zba uDjg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-88029-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88029-ouuuleilei=gmail.com@vger.kernel.org" Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id s23-20020a632c17000000b005dc4897a9b6si3108269pgs.413.2024.02.29.23.52.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 23:52:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-88029-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-88029-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-88029-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 33B2AB2213A for ; Fri, 1 Mar 2024 07:49:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ADDFA69DE5; Fri, 1 Mar 2024 07:49:08 +0000 (UTC) Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF78469D11; Fri, 1 Mar 2024 07:49:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709279347; cv=none; b=RNsD+YUYc1Dx/k/TS22GghMhkfKSrnjTJZ3NWREWb67B8Pq1PQ29vTbcqd5ykTsx6fFYA2ZB9b9so4W6uIWxhIBPLTtgK/aJLnmhthQ7D7dfSjkNvK2YTfOMVO1NzkYRgqeTCM+quJ1XhNM4WhhKWTRtGzKypk4OAB8vMdhF3FE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709279347; c=relaxed/simple; bh=V2rng/KDEPN7OaZoxlqZdAX9L9wicAGD3trWoJMgFDc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oOFtw8JY33TbOF/gyl8FpY2Hqjrwpoz1Pb2AhwtpOOZk5RB69fXIqZO/Mbg5QuoSbtILJ1ddh3A/QnAWg9dd5kNn8UgZbugl83FSG5pH7B+Nd9s/rKcm0NwTTJT+dQr+2NQzFWMKxns6q2KZHYzr/FFjYOeA2QIYadeRJkmEXt8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from r.smirnovsmtp.omp.ru (10.189.215.22) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Fri, 1 Mar 2024 10:48:48 +0300 From: Roman Smirnov To: Marcel Holtmann CC: Roman Smirnov , Johan Hedberg , Luiz Augusto von Dentz , Sergey Shtylyov , , , Subject: [PATCH 2/2] Bluetooth: mgmt: remove useless NULL check in add_ext_adv_params_complete() Date: Fri, 1 Mar 2024 07:48:24 +0000 Message-ID: <20240301074824.1259409-3-r.smirnov@omp.ru> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240301074824.1259409-1-r.smirnov@omp.ru> References: <20240301074824.1259409-1-r.smirnov@omp.ru> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 03/01/2024 07:24:14 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 0 X-KSE-AntiSpam-Info: Lua profiles 183879 [Mar 01 2024] X-KSE-AntiSpam-Info: Version: 6.1.0.3 X-KSE-AntiSpam-Info: Envelope from: r.smirnov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 7 0.3.7 6d6bf5bd8eea7373134f756a2fd73e9456bb7d1a X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: omp.ru:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;r.smirnovsmtp.omp.ru:7.1.1;127.0.0.199:7.1.2 X-KSE-AntiSpam-Info: FromAlignment: s X-KSE-AntiSpam-Info: Rate: 0 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 03/01/2024 07:28:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 3/1/2024 3:59:00 AM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792309542142270337 X-GMAIL-MSGID: 1792309542142270337 Remove the cmd pointer NULL check in add_ext_adv_params_complete() because it occurs earlier in add_ext_adv_params(). This check is also unnecessary because the pointer is dereferenced just before it. Found by Linux Verification Center (linuxtesting.org) with Svace. Signed-off-by: Roman Smirnov Reviewed-by: Sergey Shtylyov --- net/bluetooth/mgmt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c index cd8c4e094c55..b48d2d974263 100644 --- a/net/bluetooth/mgmt.c +++ b/net/bluetooth/mgmt.c @@ -8826,8 +8826,7 @@ static void add_ext_adv_params_complete(struct hci_dev *hdev, void *data, } unlock: - if (cmd) - mgmt_pending_free(cmd); + mgmt_pending_free(cmd); hci_dev_unlock(hdev); }