From patchwork Thu Nov 17 07:15:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kamalesh Babulal X-Patchwork-Id: 21472 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp256298wrr; Wed, 16 Nov 2022 23:17:57 -0800 (PST) X-Google-Smtp-Source: AA0mqf7YkofqJ6O5sL9d2B8UMRSSi6pwxV5FWuuFhwiLANeZ4XTfvHm5xiQgo4aNncVp7imqZk3q X-Received: by 2002:a05:6a00:1696:b0:571:2b7c:6693 with SMTP id k22-20020a056a00169600b005712b7c6693mr1707095pfc.48.1668669476582; Wed, 16 Nov 2022 23:17:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668669476; cv=none; d=google.com; s=arc-20160816; b=hF01iPmnDxDFit4i1avEUHdAWo14ABuKu2wpM4cKRcOV+Ci3kqurcMyoFrf0HkFxgj FL3/rWIKsnjba0XaobiRQdJITS8uHVmpiOLEXVMhXuNh9gO5/L6SELQ/K2SW2GympNh0 0IOV/Tp9t8d0CFAQw7AhchgmGD9vHkGEsIARQhjQt3iJU5UF5wFOD/3SX3vipX6pDjme xvFMAFuGzvxDINHLP4A1/duXQ+2wpGi79DNuAQc0qxqJmkJkJrQj9w3BwPRoInUwrw4M cNzLIZIGiOfpvGw5ErLqdHAEPKfFgW8U9WpzwJLoxD5J75tZobyLncVbvfatl+TbGXLt tovg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=9kopYNd6jIPcxgzNvcy2sDx186qQDHRpN+Dt2XgO6jk=; b=vlgcaKSeLYEHz4e+RNtbgVBLKzkHYVfiM2aYrx7odgT/jBzRmImyZfjUBuEHxg86AA rKV9sW+jRB7CzDMKyJoUEPzoyDK1b4A4TLKhsjrXNIyPwdStUcMAdnGoSZwPUdZYMxsr JT5LX16EKnJm19iDO6rtNesmeBPA3xlGj0u3VOw7THHUUy9FC67//NIqyOvxf/Yj4bJW dNvZsqYzwwxO2uUaBX/EWGqOQwQD7Vj+XvCpb+uerrswT+rVIYJ/y38gOV09WeknDG+S 60H9acLDmhTz0m1lNd9VxGYRJyrnHVr8ciR5Mgm3K4FBAkaXV9kCO/PsSiLnJUsErPir c9JA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2022-7-12 header.b=2fk7wvcg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cp17-20020a170902e79100b00188ef298718si269695plb.351.2022.11.16.23.17.44; Wed, 16 Nov 2022 23:17:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2022-7-12 header.b=2fk7wvcg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239162AbiKQHQY (ORCPT + 99 others); Thu, 17 Nov 2022 02:16:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239157AbiKQHQU (ORCPT ); Thu, 17 Nov 2022 02:16:20 -0500 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9909063B6; Wed, 16 Nov 2022 23:16:19 -0800 (PST) Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2AH5OLnK011670; Thu, 17 Nov 2022 07:16:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=corp-2022-7-12; bh=9kopYNd6jIPcxgzNvcy2sDx186qQDHRpN+Dt2XgO6jk=; b=2fk7wvcguQPJsQt27KH18YVDsK0dxAJgIAOiB6dNsvXhbUP5H+Q7DoJYRFD86oQrQ1YH li9rLPrZPwY3rQDOc9NAS0Fx+oMNi6FTRWHRKrT1v6HJrUILUBWnmwwbHgjeKDz4mlCf rafvqWqtZtDjrztrl1M4LzH7gn7Fo+Hw8gQ57pPAZo019GfsG9T+YWyj2lEy4sNlWSfA +GtMjI8iRnUfPECor7wkfk4QCRYm+htH/NwkVd1ANYU6r28CG4tzx0bCfnkIMuHQ21vD igwtMXWF4fLuec+Vev9OYMPG1WulctC8J4AAKk921IoiQVY2ltlXOUMDPvI5CRLrl+J8 bg== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3kv3jsr3jv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Nov 2022 07:16:11 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2AH6gRhO016820; Thu, 17 Nov 2022 07:16:11 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3kuk1yh83m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 17 Nov 2022 07:16:10 +0000 Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2AH7GAv9029452; Thu, 17 Nov 2022 07:16:10 GMT Received: from jarvis3.oracle.com (dhcp-10-76-54-85.vpn.oracle.com [10.76.54.85]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 3kuk1yh81d-1; Thu, 17 Nov 2022 07:16:10 +0000 From: Kamalesh Babulal To: Tejun Heo , Zefan Li , Waiman Long , Johannes Weiner Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Hromatka Subject: [PATCH v2] cgroup/cpuset: Improve cpuset_css_alloc() description Date: Thu, 17 Nov 2022 12:45:57 +0530 Message-Id: <20221117071557.165742-1-kamalesh.babulal@oracle.com> X-Mailer: git-send-email 2.34.3 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-17_04,2022-11-16_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 spamscore=0 mlxlogscore=999 phishscore=0 mlxscore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211170054 X-Proofpoint-ORIG-GUID: TJtROg19GrMyBSACY64Twub5WEpeNIDg X-Proofpoint-GUID: TJtROg19GrMyBSACY64Twub5WEpeNIDg X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749726764879581432?= X-GMAIL-MSGID: =?utf-8?q?1749726764879581432?= Change the function argument in the description of cpuset_css_alloc() from 'struct cgroup' -> 'struct cgroup_subsys_state'. The change to the argument type was introduced by commit eb95419b023a ("cgroup: pass around cgroup_subsys_state instead of cgroup in subsystem methods"). Also, add more information to its description. Signed-off-by: Kamalesh Babulal Acked-by: Waiman Long Acked-by: Joel Savitz --- v2: Reworded the description to be more accurate, as suggested by Waiman Long kernel/cgroup/cpuset.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index b474289c15b8..ce789e1b2a2f 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -3046,11 +3046,15 @@ static struct cftype dfl_files[] = { }; -/* - * cpuset_css_alloc - allocate a cpuset css - * cgrp: control group that the new cpuset will be part of +/** + * cpuset_css_alloc - Allocate a cpuset css + * @parent_css: Parent css of the control group that the new cpuset will be + * part of + * Return: cpuset css on success, -ENOMEM on failure. + * + * Allocate and initialize a new cpuset css, for non-NULL @parent_css, return + * top cpuset css otherwise. */ - static struct cgroup_subsys_state * cpuset_css_alloc(struct cgroup_subsys_state *parent_css) {