From patchwork Fri Mar 1 00:12:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 208567 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp762038dyb; Thu, 29 Feb 2024 16:12:57 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV9dlv1M0iipoQO96fTWwD6Z7KvQgV+eqi0/do7lO8O9bMQ6YV3tMo7QI9IGKwBHWhVao8vSqzZkZBbfl6D1NGAWgjabw== X-Google-Smtp-Source: AGHT+IHpm2T+hh8J8YV8+/HBm/b1wqIczt1QHqP8OLWLv0KNBkDLkVMe0u2IBKu71kezG80eww2k X-Received: by 2002:a05:6e02:2148:b0:365:1fa4:1b41 with SMTP id d8-20020a056e02214800b003651fa41b41mr314464ilv.15.1709251976840; Thu, 29 Feb 2024 16:12:56 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709251976; cv=pass; d=google.com; s=arc-20160816; b=T3S6rh0W/HhdPQMYMwKWr4Qn89hYfgQIVBEXndBtJ2EH+qCn5SZ6XpC2gwxoPKWAYE ueq5MYkeDWKhJz75hutBCfrJVCaDXdd/WmlV7s9MGjjbHdsdmKAQRhmuBY+LmlycuFB0 rKdHb03qlgcvuTfSE0QcH2FpnbFaPrdLs8NcClwfRKX4GwPTKpc+hMJtjaMMFL9f5u4H 8nRyMvlnfJ93xws7UcqBETC+/+3B4JsvZqaqWfP2FDIKVaWZppkmzcKv/9pYyXa1kLP7 wUgTwjQUZcmV2kcA1miy5JLAe8CTUE1x2IfcTIpwRx8jVgEuPgqfm24V8coj2CxSOZj1 SLeg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=pbSR6z7X7zwoXvEIFGqDTz5WDrvCCQcbPKp/I7kPm2Y=; fh=EPbsNJMLwlXYTg/MTuk9bwilsoK94uNp6NRacKCAfCI=; b=Ej/DjzZLNw4DrtTzF4VHk+GF1j2UhpeIYb4gzvjy5SIrgMp+f7BxfyDrhYaeODKoNX bRmKfJq6AXPfLPjLNBNoCwGqsSiWU1Vhmpx/uxpj+iN9GQMeRUQWtL15YFMF5gHqiNnB G3nP2rc71yXhYnopYL0ExdHqBlpC1DzWK37wPNCbpNv27IGqMn5GfooSLZ/jWVnbdeyN p9/K4Xxk4cIC+/K3UA5u/EWh8SNjwbZX2uqM1ePfy5rZe1x82c/snyRx8TqwWcZsnAqk LEgxx2VQbjS6lH+k93OM54YV55p5MSceQ05YJ+ZqyaSgTDPzeMwpIlCQ3AoC8x3x/Hya UC/w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=e8JXK2GO; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87718-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87718-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id c1-20020a63da01000000b005dbe2220330si2435111pgh.171.2024.02.29.16.12.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 16:12:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87718-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=e8JXK2GO; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87718-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87718-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 382ACB20ECE for ; Fri, 1 Mar 2024 00:12:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9F7C117D2; Fri, 1 Mar 2024 00:12:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="e8JXK2GO" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CFA417E for ; Fri, 1 Mar 2024 00:12:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251944; cv=none; b=m1G1d5fFmFha8LqwSq+0rnWqtqxMFbiCyXp+oCWxiZ2HAb22qjmX2jxVmZqSM6UzNfTzEh9y4i8E6e7+vswCG2HSjFNZvWWRVhYq0tEH04ZSHmzKojhLVV5UYDaM1+TLAVGAHQS4dkuDJkwrh67TjrYb5So9iO0ZLlZx1xvWLjw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251944; c=relaxed/simple; bh=iUKjpcxm8TFpwUzlmp7yRUbrK5h61wBPcr0xFrIbQOE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XuhXsH3Hv+9CuGTa0Qn0f+Cas05pQJEGjOUmcnGWuel3r2k7jHSwCc/agOeovKhQwVLP1Qyu4qhTn22rnpYzSfk6yHkZlxgVGS5TlOuW7cOn34YgVvc3shwfJtq6Ty+P/6ZVF8JkJR7C9gwz6UEe6cZ8yS5g2LYd31fXjdPp+hg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=e8JXK2GO; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709251941; bh=iUKjpcxm8TFpwUzlmp7yRUbrK5h61wBPcr0xFrIbQOE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=e8JXK2GOsswG8I8J52YRL7iPEzLNsC5XsWsDNXpEVTibaB1WMH1dL8YIf7J9QsSSk NnyQRDQ4DyPxjUTIYaKL8rFl++rl880Sz+WAj9FPgeNqG9K0HJudCCHcy3K6TaZe0G Djwp2AWiUZcXVMe0BSlk20atDAYYMsjFE78WNuExOBNqKnYsBgByOOMu1+eIIq8SRf qa982cgqHWfMo3Xp2Ng1DUZkrQtPjATv5/RLnzS5whCqUVXYzQluP4DEkgApLOBslS uON8t7ObVdJYg+AIe1+G1gc1/nASEr5j3d48YeHOM3l7opZx1tAcoMsGcgYdQB4jFR A82h3nhp8QT1g== Received: from [192.168.1.205] (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id B813E37820D8; Fri, 1 Mar 2024 00:12:15 +0000 (UTC) From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Date: Thu, 29 Feb 2024 19:12:07 -0500 Subject: [PATCH v2 1/9] drm/bridge: anx7625: Don't log an error when DSI host can't be found Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240229-anx7625-defer-log-no-dsi-host-v2-1-00506941049a@collabora.com> References: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> In-Reply-To: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , owen , Jagan Teki , Marek Vasut , Adrien Grassein , Srinivas Kandagatla , Sam Ravnborg , Bjorn Andersson , Vinod Koul , Dmitry Baryshkov , Vinay Simha BN , Christopher Vollo , Jessica Zhang , Marijn Suijten , AngeloGioacchino Del Regno Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Mailer: b4 0.13.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792280601140427510 X-GMAIL-MSGID: 1792280601140427510 Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Fixes: 269332997a16 ("drm/bridge: anx7625: Return -EPROBE_DEFER if the dsi host was not found") Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Neil Armstrong Signed-off-by: Nícolas F. R. A. Prado --- drivers/gpu/drm/bridge/analogix/anx7625.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index 29d91493b101..4ee5614a2623 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -2076,10 +2076,8 @@ static int anx7625_setup_dsi_device(struct anx7625_data *ctx) }; host = of_find_mipi_dsi_host_by_node(ctx->pdata.mipi_host_node); - if (!host) { - DRM_DEV_ERROR(dev, "fail to find dsi host.\n"); - return -EPROBE_DEFER; - } + if (!host) + return dev_err_probe(dev, -EPROBE_DEFER, "fail to find dsi host.\n"); dsi = devm_mipi_dsi_device_register_full(dev, host, &info); if (IS_ERR(dsi)) { From patchwork Fri Mar 1 00:12:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 208568 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp762134dyb; Thu, 29 Feb 2024 16:13:05 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCULNoNNzf41YTOsVIutJ4iQznOscP3V8foWeeZCsN+Kj5FtTpTqmKI7OpOPNoLZtaPNdsMOv/Hk7DxwlogR4Mk90L57Gg== X-Google-Smtp-Source: AGHT+IFxtQ/5BDyHqIQF8+B9wdqSHMHixLhQYfGWYoQggjIRpFq9P+9/eU9cZR5a/fZJ1AgDmaZi X-Received: by 2002:a05:6a21:3408:b0:1a1:864:65bc with SMTP id yn8-20020a056a21340800b001a1086465bcmr4943520pzb.23.1709251985122; Thu, 29 Feb 2024 16:13:05 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709251985; cv=pass; d=google.com; s=arc-20160816; b=b6FXlu+LLQ5ywKT2XA01370nxlqQz4QDxhOLkXg+giTHNMa2G+1OHl8V0ZiG/gEmzJ 9fLqZS1O0d0bVKrcOQZBiEMpquub04V88YjFLL4CrBiqWq6wUJ8uv7CJBd/EjFir9+Ex sL7TmWFJe3eIw1KUOLK+Fz9prRGcaLFBvTIKUxbMV73e3J4rhcr4A5lF0347OkHAlyU4 X8rszHzgmTyW76BJmQsZBmAbIFV82y2KLj2GmNioU22ucmWrqLLSR/fzNKVPDVrYoQua 4paAzIO6fhedKNxXlE2Dwp/lVFFpASaeVm1tEdvdTk4STEQpd1xRCGnKa+5syWbsPK5w P2iQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=zmfQvIHA4tHKGsRvlhQ4r1otCVltUoomSwpbJvllBj0=; fh=EPbsNJMLwlXYTg/MTuk9bwilsoK94uNp6NRacKCAfCI=; b=ZyvuwWVd3duKEffWlMazYV9HzHI0JXpqp5SG8W/Lvsj+WgsQaY/EMBgSQko3jwR74L mjfcWQM6dQLH1iPfoO4CVhXcLDfRYDbqtfK71SCwZhkwPrcdcU9ZI2ofg+UVITNtzTiM 7SgVe+jzX3+b6OiXr6EJzb50gYCZLIEa6Y3xwGSeq70HnHxFemU80aZSrvwhPTgSu+eM 9cTYJK/WdGXkQdOz3VN/UWA9usiJbm8DmDW2CuHOwcJw8WPzOEvxXaW+YAHKt7wG8SX1 rcp9RKmj841h+++YG1A/aJh/myl819ynCDx9h2xYC+zqMufrczf260bpcgGK0nIpt850 fwgw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=EJPD0bSu; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87720-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87720-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id h6-20020a655186000000b005dc4b84b38asi2356295pgq.72.2024.02.29.16.13.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 16:13:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87720-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=EJPD0bSu; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87720-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87720-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E691D282759 for ; Fri, 1 Mar 2024 00:13:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A3CB82566; Fri, 1 Mar 2024 00:12:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="EJPD0bSu" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 853B21FB9 for ; Fri, 1 Mar 2024 00:12:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251951; cv=none; b=DTH6Reln5l5TOU1aYojA9MaYxd/yyYwTT+ldnPaMLXnQSJDTgKjhr3HKuoNAW01Nu1N+kONO79xHIGIrvct/INPHv/OmoxPjsLVQ4oiDtFiBoEpqg11QKCOq+SBkzifixjpnKU7lNuq8B3MxHbCdNh2ODPMNR2o4LgPVbSYqsO0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251951; c=relaxed/simple; bh=gnT6fVbzwGxli2Y/mzqkTnDg8570zOrbc+nwHaRR3vk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=M91olaCSW+ApQ6ntMZZa0ayq56jEhzqYz/EawagjfjkyQPDoVYC8WffySPe0hf9Q5/BOwBNBZOmdBTZG1MrvUajpzkLPKi0SAmuZ3Yv6qVKaZYwo9Wl8EVieTr9Zmtuom6IaghQ1y/o8icx5rZy0O0hv+tAzoOxyKuNma3HA9QM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=EJPD0bSu; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709251947; bh=gnT6fVbzwGxli2Y/mzqkTnDg8570zOrbc+nwHaRR3vk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=EJPD0bSuCixJT6fY8/gLwi/Fr+UYpNod4uZfw2eAXxkQkbdiJ9XVQvnlzO0gTomxk IgF8iDGPhmZsvqLVaamRP9kf84r/VZtfn1qPnAL0v9GgB0HmH+9K1JVcAynmED7xMh ySOj2EmBuIuQcvBmCbti4lh1EAGne009cw+QwqORex2vndvoXh5l6UWYQ0tRNTK6ck j5PNRasF89dtlTJrOgE+L7h1A/y5i0U5D3dAOtwZ8d4dahWTp4NkGNxZCqNRV1juGc CUELRpn3PUqYiiuHClJxJgO1SdE2FOhUc8Xz3Ri5TZvFDeNPqH8RcjTFg3cQ17wF3a FFeExNDQ7bzfA== Received: from [192.168.1.205] (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 0007737820EC; Fri, 1 Mar 2024 00:12:21 +0000 (UTC) From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Date: Thu, 29 Feb 2024 19:12:08 -0500 Subject: [PATCH v2 2/9] drm/bridge: icn6211: Don't log an error when DSI host can't be found Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240229-anx7625-defer-log-no-dsi-host-v2-2-00506941049a@collabora.com> References: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> In-Reply-To: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , owen , Jagan Teki , Marek Vasut , Adrien Grassein , Srinivas Kandagatla , Sam Ravnborg , Bjorn Andersson , Vinod Koul , Dmitry Baryshkov , Vinay Simha BN , Christopher Vollo , Jessica Zhang , Marijn Suijten , AngeloGioacchino Del Regno Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Mailer: b4 0.13.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792280609774238790 X-GMAIL-MSGID: 1792280609774238790 Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Fixes: 8dde6f7452a1 ("drm: bridge: icn6211: Add I2C configuration support") Suggested-by: AngeloGioacchino Del Regno Signed-off-by: Nícolas F. R. A. Prado --- drivers/gpu/drm/bridge/chipone-icn6211.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c index 82d23e4df09e..ff3284b6b1a3 100644 --- a/drivers/gpu/drm/bridge/chipone-icn6211.c +++ b/drivers/gpu/drm/bridge/chipone-icn6211.c @@ -563,10 +563,8 @@ static int chipone_dsi_host_attach(struct chipone *icn) host = of_find_mipi_dsi_host_by_node(host_node); of_node_put(host_node); - if (!host) { - dev_err(dev, "failed to find dsi host\n"); - return -EPROBE_DEFER; - } + if (!host) + return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n"); dsi = mipi_dsi_device_register_full(host, &info); if (IS_ERR(dsi)) { From patchwork Fri Mar 1 00:12:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 208571 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp762375dyb; Thu, 29 Feb 2024 16:13:36 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX8rgPYe3BT4r5LM7NUdtBY/FWRsh8OtgXvfhKk6eEdnUTdP6+KlCWGTbT08fIlRHK0KtTZeyCW1r+5Da5Hcku2FWwCEw== X-Google-Smtp-Source: AGHT+IEz6PLmkI9noTzobZjRgN6pehmSU8WE7/K+kAncHURGUsYRsC7FDhwBD7GmqsfKT0BVng2/ X-Received: by 2002:a17:903:247:b0:1dc:c161:bcbc with SMTP id j7-20020a170903024700b001dcc161bcbcmr137654plh.5.1709252015798; Thu, 29 Feb 2024 16:13:35 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709252015; cv=pass; d=google.com; s=arc-20160816; b=Zl5gpX581/nuDrgEgEe1R/oeo7/3JCwrgwz7EI9nSB2M8cBGwlvLp1n5PzQ+y6478x dXjUHPAkrwgsnZkEWFhODZ9lvz7WrHczcIcbTcJUXqrePccpoVVYRLzImtX+o99fQZHd IknG9DCQ4H9C5O4B9KKd4ddTK9SNOBowiY4PMcT2mGaJh4ouGUPr/+4LXHIc1RcibgJY AAgLBz1gtlM4Jc7eIePZnXi7WaGWTrF07joI/w4NVZ4yz3I3RiLlhi+pjBntMZk3k+jY kOx3J/kkm7KVw65YLO3McNmUCCFnHewiGMvt5JMo4Oc/Mpiq1q9d0KWreBaEogXt2GL5 Dkmw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=c84h65NinOEbrRDe/T74+6ebbxz3Z98Wen4o7An62wM=; fh=EPbsNJMLwlXYTg/MTuk9bwilsoK94uNp6NRacKCAfCI=; b=0EtD9p+K/RTI9UfWrSohfzm7+EbB07PjcCskkfcTrfytNI3AfuVMeCVL5A0WVUal4I D9iAR+uaDBT0Z7EJnlvXuS+DK3CPK/+3p2RUyiklg1+O57Q0KiKMle/UIVDvIoIzxYae 4Oa38AtaB+dmAq/RJQfyCLIoiW9iuuLo9ad5MwIesdVUTKxQbRrz6l68PGBz9kI0Jieb k1H8T6g8t4/+7rD5IWga9yQjfFd1eCrLH67WdAtha3Kfv7TtLE27TLNrD82xJLcK1e2n +YnSXikeo/8bGUWDI2oS6BPM1ngbK+3h3M6uXUqMfC/78ysHiXddT6CxAfgjuRBMAYyw PoZg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=V7r6Wd2Z; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87721-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87721-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id h9-20020a170902748900b001dc91eecd64si2149584pll.146.2024.02.29.16.13.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 16:13:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87721-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=V7r6Wd2Z; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87721-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87721-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 278BAB21283 for ; Fri, 1 Mar 2024 00:13:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2FC493232; Fri, 1 Mar 2024 00:12:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="V7r6Wd2Z" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E2792582 for ; Fri, 1 Mar 2024 00:12:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251956; cv=none; b=CoSTBxyh306o2l0dw2iqvu9OXtLH8ddj1uE8wywpuyn9uVWT7/TSkQyGmlazH3xwT+LY9fNDIBgWjm/S5yIj8D2WpOqlY+iOYM+iAMf4ZNEJEZu0HcjhIhUa5HyHVBEglgSht5wMQsYRWG7qtjXg6eFG3iDIWPPD0Cym8ZJ83z0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251956; c=relaxed/simple; bh=WVysYAyr15mAm5m4P/SUrQDSA/7qQTGaNZ7Cnm3KAOg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CuiRfUAutzbcezu1NoLRzhQqWBk2LTNiHrLIS8VWitF/f+GYC0JEoKWE+52hctZ8frk9WGpwc2Gx8mEB7OiZ/zybGffXX2nc4y/Jzkk0/U6Op3jb1XFKd2dV1zLOmWwv2Psn8crqt9tDHXQuuFvV2KPlpO0k/JCoci4Y1ohCqxg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=V7r6Wd2Z; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709251953; bh=WVysYAyr15mAm5m4P/SUrQDSA/7qQTGaNZ7Cnm3KAOg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=V7r6Wd2Zq7IqIuAc7RYAeEuBl0zwwqCHFPKfaWlTO2uEW2vOT9jyvDiBZ6TFEb+Rs gt5QZzWWrRQfSCGcp8YRrVaxwmhhPz2/hh9JPtZex3VA7AwvOIiIFJAExoV3x/fmCi wZjd8m9VkO2VLjx38KFB2oRaBPbsKpmmB4H8jw81L+TJhwC5INjvPOPRPvwMkDWg8z WhPSGy/WLLe6fY806qHsH93O/e3zKEmb/qv6m7e70WOD83C1vRaaqT5xvFnwycVA5w irwu6+6iVgQoWiKfxKrOl3r8wN+Yd5sIqISzT6grUcL4p5ihJKYbNHmxtnV1RVBJD1 QwiJeZD5JMy2w== Received: from [192.168.1.205] (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 3CDB937820EE; Fri, 1 Mar 2024 00:12:28 +0000 (UTC) From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Date: Thu, 29 Feb 2024 19:12:09 -0500 Subject: [PATCH v2 3/9] drm/bridge: lt8912b: Don't log an error when DSI host can't be found Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240229-anx7625-defer-log-no-dsi-host-v2-3-00506941049a@collabora.com> References: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> In-Reply-To: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , owen , Jagan Teki , Marek Vasut , Adrien Grassein , Srinivas Kandagatla , Sam Ravnborg , Bjorn Andersson , Vinod Koul , Dmitry Baryshkov , Vinay Simha BN , Christopher Vollo , Jessica Zhang , Marijn Suijten , AngeloGioacchino Del Regno Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Mailer: b4 0.13.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792280641850826773 X-GMAIL-MSGID: 1792280641850826773 Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge") Suggested-by: AngeloGioacchino Del Regno Signed-off-by: Nícolas F. R. A. Prado --- drivers/gpu/drm/bridge/lontium-lt8912b.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c b/drivers/gpu/drm/bridge/lontium-lt8912b.c index 273157428c82..15aa890c3e6d 100644 --- a/drivers/gpu/drm/bridge/lontium-lt8912b.c +++ b/drivers/gpu/drm/bridge/lontium-lt8912b.c @@ -496,10 +496,8 @@ static int lt8912_attach_dsi(struct lt8912 *lt) }; host = of_find_mipi_dsi_host_by_node(lt->host_node); - if (!host) { - dev_err(dev, "failed to find dsi host\n"); - return -EPROBE_DEFER; - } + if (!host) + return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n"); dsi = devm_mipi_dsi_device_register_full(dev, host, &info); if (IS_ERR(dsi)) { From patchwork Fri Mar 1 00:12:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 208570 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp762354dyb; Thu, 29 Feb 2024 16:13:32 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXewLlIcc27uqGcEtFeioXBz4xgVL+2m4linTUucfmF+whNMSzSD7KcJBABkpusPKGVto3c/rmw49KzsbQqWIywy/GSew== X-Google-Smtp-Source: AGHT+IFoZyr9VGq4OuuP9uR3qwMsvtd08xHndghrCeib1NBdeO3AQ8gSKM441TOM8P5nhQb1vlBt X-Received: by 2002:a17:906:489b:b0:a44:52c3:9003 with SMTP id v27-20020a170906489b00b00a4452c39003mr111894ejq.72.1709252012516; Thu, 29 Feb 2024 16:13:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709252012; cv=pass; d=google.com; s=arc-20160816; b=JxNi5aKJpPywEUHUvAfjbM5UCIfbb0xh1prsQDrjAI4D7uAUG+/5RIdM5KP+8zG8qh KZAWywU7S4myc1kjA+WHVDZQr2JY/2vyWzhuNyvUtqvj0AkSRo/MLLS1agd2+Lrf0SPs 99hxK8zwKP9Ur9gETGYRYzWwz/lt4bXOKkPyGl0DxMZ+FSI0KBI2QzwNS453INXtZNf6 otXR9CbnHtHu1C49noDqzf6YJuDvnnI5nletFGW/QJWNwVph4yozzs+Tl9vlRbujFtAd shvoaAbpu3GJEkXSeUrPjeV71zAJr0/Wili1zNGgyBqoMS7dn9cAe0VcMHC8RqMaS/DO 3JyQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=UHAdgTtcYR8u/hbs0r/AN8yppNLahtPaKoia/pq0DzI=; fh=EPbsNJMLwlXYTg/MTuk9bwilsoK94uNp6NRacKCAfCI=; b=wZV2c2+Htx7BxLk2T2t0Q+zPzN/NKw3+utwXck1mMbiHCRa6JxzLgAGoP1mLogn04k PBAG/vxUfYa/n5F/Ai73qvVgP2FkTLr69wvGhSCLHnOpUvQ1I4ANM+xu2/6dEA6kbGgx TOotjUpj/RTIWdE32MMNw999DobFmmYFQO2Z0f+PDW7vmYjIqVw5g3H/FTH+P1E+fH4k iNXbXJ0VRZzVPOmmcmOQjK7xBxO1U6fua42nT6G3iK43MPpMzI1Z4MYzQxWJis0zwPTv EnAarmvqfWEx0vIitWRSCCXfqZXq/+yhSp5nQgsEZI46BpPEB+1ZPLe7nHfIiG547oZl RVKA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=QMCvJvfO; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87722-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87722-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id cw17-20020a170906c79100b00a440a8a71dcsi954472ejb.411.2024.02.29.16.13.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 16:13:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87722-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=QMCvJvfO; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87722-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87722-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 1CD5D1F229F4 for ; Fri, 1 Mar 2024 00:13:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BA6E53C07; Fri, 1 Mar 2024 00:12:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="QMCvJvfO" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E93F3C04 for ; Fri, 1 Mar 2024 00:12:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251962; cv=none; b=WUrqHuWxrKZYwGg779GEUhcdgoCLWePjIe8mUDFMcYtpp0fCcmECNHjmbml+x00QCHlkgc9YEx2Op4CXKaapnfG2hPqiN74VK2y9CDuAHDf5U3zh9yEFvgTfm+e4uoD95agSgyb6c/bF6Xex8hjCvHzEZIQZjnbuRINEPB72XBQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251962; c=relaxed/simple; bh=iH06xccM8Cux1F3BhJ2YYDHKnbi65kEA+R8Dz6nQIhU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qZnv7I9FBYyj0YdT2HUJbsNXBMEsd8emFznyFgRLykky1Vii1B5Da0P82vGxKW8bA7z8yvpqfXVvr91jZdVCYCyYxXSv8yY/r7d28KS2dYJgjceuPqsa0nidA+ALcJAYOk0kSzM0yKoNkzyDVXuk3kXys3fLSxfgM9TebFGTNsc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=QMCvJvfO; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709251958; bh=iH06xccM8Cux1F3BhJ2YYDHKnbi65kEA+R8Dz6nQIhU=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=QMCvJvfOb47s8BTrX0J8KLUOyCSWQFMsBlKURkN5Iw8iy2JCXUPnT1XgpLe5jYetj I7sbsjq8rs2nSsg2sCt1bsy1BfN4ACvsXxEDFAP8nIVgA0JZra/2MuIP/4H3Ats7Ea Nb4XKvZov0gHj3KHnIQO/pA1L7KoQooL8mpZSfzV4QyqpubiltMDDZ9zNuqQkuGGFe b2QjpJD+FN4NStVvM4H0/VFql14kh89WNclXaT8XNe/8z/xx0BNa3Jzz+Kw5IzqPxA xwj9O2qma7BGQ+NMGCLO5tMTd2DvzcNKr/jZ3REDPV+wfyjft3mG4R1fTGSWHNDy8s e21co4cIe/pGQ== Received: from [192.168.1.205] (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 8B471378000E; Fri, 1 Mar 2024 00:12:33 +0000 (UTC) From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Date: Thu, 29 Feb 2024 19:12:10 -0500 Subject: [PATCH v2 4/9] drm/bridge: lt9611: Don't log an error when DSI host can't be found Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240229-anx7625-defer-log-no-dsi-host-v2-4-00506941049a@collabora.com> References: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> In-Reply-To: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , owen , Jagan Teki , Marek Vasut , Adrien Grassein , Srinivas Kandagatla , Sam Ravnborg , Bjorn Andersson , Vinod Koul , Dmitry Baryshkov , Vinay Simha BN , Christopher Vollo , Jessica Zhang , Marijn Suijten , AngeloGioacchino Del Regno Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Mailer: b4 0.13.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792280638098903334 X-GMAIL-MSGID: 1792280638098903334 Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Fixes: 23278bf54afe ("drm/bridge: Introduce LT9611 DSI to HDMI bridge") Suggested-by: AngeloGioacchino Del Regno Signed-off-by: Nícolas F. R. A. Prado --- drivers/gpu/drm/bridge/lontium-lt9611.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c index 9663601ce098..89bdd938757e 100644 --- a/drivers/gpu/drm/bridge/lontium-lt9611.c +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c @@ -760,10 +760,8 @@ static struct mipi_dsi_device *lt9611_attach_dsi(struct lt9611 *lt9611, int ret; host = of_find_mipi_dsi_host_by_node(dsi_node); - if (!host) { - dev_err(lt9611->dev, "failed to find dsi host\n"); - return ERR_PTR(-EPROBE_DEFER); - } + if (!host) + return ERR_PTR(dev_err_probe(lt9611->dev, -EPROBE_DEFER, "failed to find dsi host\n")); dsi = devm_mipi_dsi_device_register_full(dev, host, &info); if (IS_ERR(dsi)) { From patchwork Fri Mar 1 00:12:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 208572 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp762433dyb; Thu, 29 Feb 2024 16:13:45 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUmlLAKRrZHjLhsBrBBl0i+bxQI242NGXURE4x5XzbkvU8PpR65dwRZ+seanC0vUhFSCi3fNZJSwkhobp5non3B60NO2Q== X-Google-Smtp-Source: AGHT+IE5qml8dOEIunRisHFs0LyGBE10FbY9FZBKl7uyn7M9nRtiertsQ4E40WjjO3Z/a4e8yErb X-Received: by 2002:ac8:5f0b:0:b0:42e:b2a6:ab66 with SMTP id x11-20020ac85f0b000000b0042eb2a6ab66mr111662qta.38.1709252024852; Thu, 29 Feb 2024 16:13:44 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709252024; cv=pass; d=google.com; s=arc-20160816; b=EQHvbprGn/YhR9/BfCRgNd1qBllLocY4o5W3WQ8S+qbqCeKv+RNmGg0ON4Shn/7Lj0 D9z3gt7jHbY3p2IQRwHukKzbsWUX7EEuOIVT1D/P933NELol9nvWz2pHsAO+bIMzrlyt xQivlPcveiGa8HEBkPRM42a84g5XhubEdFAxDPx1PQIrvC4CPkPwtZ1+hCraVBtEibas 4942Q7YAy8vZNGV3KoJ2GmeGrNi43PbWB6WV1FmgpkLnABmRW7mFWvGzKApZjynHpmc/ md72hCU0Xie5Z0bq2UmqE6x1zZV3YteK4nNFdm0U2/RR9OKqIxDnj1SInQwXmhTjMkNR z7Xw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=HAkgbionryHs6BGpBGx2TFA6XOGyDEyx9OwBzhqLNVY=; fh=EPbsNJMLwlXYTg/MTuk9bwilsoK94uNp6NRacKCAfCI=; b=txHhxCQnWgu/93gb1V/8RuH7XnidYv7qyqrbApUNU1c9hBHuMQzrU1U+4MNbqdj6xT uSKxvF2RrFIeGr3Xl3HbFK/NvzTFx6JPnf306MpwU5RrBI2980CUwrbmvX1ENohdqwnX CZFFe6GhFwfH2rSuqbJGvgaqPJwZyOptHRiPr5wKj932EeTI2gMtZGf4CtD8Ttt/OSUV gRd27EcrDgMF/XjCqXeUKOjCxNEYPM/7LMiSqyjgyhQttUB9yR83I+8YgayVGPtjKd74 1thVYUVh6HDZLFiEkg04tu239EGxfll/B1SgECJOVCUHNpFSLGV5Qa+YzvXGcDgUTjqS Ejnw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=Oe4pTP9H; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87723-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87723-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id f5-20020ac85d05000000b0042e626ae053si2670719qtx.213.2024.02.29.16.13.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 16:13:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87723-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=Oe4pTP9H; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87723-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87723-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A12481C20F9E for ; Fri, 1 Mar 2024 00:13:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 99E02468F; Fri, 1 Mar 2024 00:12:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="Oe4pTP9H" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69BD363C for ; Fri, 1 Mar 2024 00:12:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251967; cv=none; b=o3TzFVIOTYV7mHGYmT9NzVtdjrhR+BJM42lJcvNKNlQGW3QMhTA/ip69ucA56eFB/tmjjWqPiak6XjWhOWhmMgbq5xZbee10UCFccCyYScfj6SXlaGBCaf9vbxZTTduFEz8AlSUu1vCyIxKPv8ylghpjIGSjmP/aEFcP1JSN8g4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251967; c=relaxed/simple; bh=USSgCDP9hS4bs7tJCyGn4h6s80NL6hl+B96SysSOP2Q=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dTNF2AtYBqlIVAaKgjmyXC3Q3i54DSaQusIdKELHgoPoxyL/AbBbJsyo5omPT+naJS1Ep/XsyFc5MiPFkiJuA7GFM1r+8KrUhMxQEc5S+hPtVr0+9IQExrqmyqK+6ywB/V0KdXqng8MNIAyCyfB4RfBiUu4DzDDkhzrcBivPrYY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=Oe4pTP9H; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709251964; bh=USSgCDP9hS4bs7tJCyGn4h6s80NL6hl+B96SysSOP2Q=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Oe4pTP9HkQIUhqP7j+3FqMmZmdGnO2r3byoKDxh6zJe1fAoftVHZrxeVbPtsb9yrI sRAxGkyEfKav4ZWFDQ6FCq40DNstMDbt7ZYt9d1HxPcJjhhr+Vhsm43df5zMC+E1XU RfLxK8wIhCYLV1vQVFNUNTRHiLyEeu+uM70wOskQO+OPK55SWmxWqlqWs0EIaV2STL jeNSAT0O/IQk79pXb4Y01x78p8hs8WLpRwTFvImMOEMa8aekp/ssl4ond2ULq5ZhMH VoO7a6MDbi0ATB8uHe3fuP1xyTav7pzpPN4fNIU3q47i6O5oCxaUw2uxS1cj/eMcJ0 s7Us4BWoXqpjw== Received: from [192.168.1.205] (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 1CA4337820EC; Fri, 1 Mar 2024 00:12:38 +0000 (UTC) From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Date: Thu, 29 Feb 2024 19:12:11 -0500 Subject: [PATCH v2 5/9] drm/bridge: lt9611uxc: Don't log an error when DSI host can't be found Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240229-anx7625-defer-log-no-dsi-host-v2-5-00506941049a@collabora.com> References: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> In-Reply-To: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , owen , Jagan Teki , Marek Vasut , Adrien Grassein , Srinivas Kandagatla , Sam Ravnborg , Bjorn Andersson , Vinod Koul , Dmitry Baryshkov , Vinay Simha BN , Christopher Vollo , Jessica Zhang , Marijn Suijten , AngeloGioacchino Del Regno Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Mailer: b4 0.13.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792280651506194185 X-GMAIL-MSGID: 1792280651506194185 Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Fixes: 0cbbd5b1a012 ("drm: bridge: add support for lontium LT9611UXC bridge") Suggested-by: AngeloGioacchino Del Regno Signed-off-by: Nícolas F. R. A. Prado --- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c index e971b75e90ad..b803899126d5 100644 --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c @@ -265,10 +265,8 @@ static struct mipi_dsi_device *lt9611uxc_attach_dsi(struct lt9611uxc *lt9611uxc, int ret; host = of_find_mipi_dsi_host_by_node(dsi_node); - if (!host) { - dev_err(dev, "failed to find dsi host\n"); - return ERR_PTR(-EPROBE_DEFER); - } + if (!host) + return ERR_PTR(dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n")); dsi = devm_mipi_dsi_device_register_full(dev, host, &info); if (IS_ERR(dsi)) { From patchwork Fri Mar 1 00:12:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 208573 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp762527dyb; Thu, 29 Feb 2024 16:13:58 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXlVArxCSBeYcZYJoK5sJQonPJ558FQXKbatuGrqR6WYIROViQUSTvx5aJtRhIPa/sT5c+WOuYCHAvxkDkcLjS4U5PJHw== X-Google-Smtp-Source: AGHT+IECeebNlqTOTPaxKubyFd+/O+dGw69s31h20eKjLmJom46JNES+JMkenohC6ny8DBsaG0cp X-Received: by 2002:a05:6102:3907:b0:472:7448:e0d6 with SMTP id e7-20020a056102390700b004727448e0d6mr4705279vsu.5.1709252037934; Thu, 29 Feb 2024 16:13:57 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709252037; cv=pass; d=google.com; s=arc-20160816; b=iVT/5V67CqKoKSs0bo49GCDy2ZbJxcMC6k4i90S9DMs+qB9Dduc7Uo2D9scQFBEUGV RK0ptE+dlfkapEp1xHWMGTSlCBU4qa1q2G+pYGJDXEJ95M22NbURsxPOMoRvhhH9L+fN tSamVHjccuv6NP7kvVCsFa4SqGfFUmTcB3scaVd5KWrsnU9oxTZR1EiXm1xigBpHknjq k7TIuj622Kx54KGYY9ThqyGpIpfl1oGO+iWwkGO2cnSYzpPaHE//FB7rkWWhxDaXz0ek tdvj7R8xFwZHf/HTdRluVWJJmLZEWKs7+dirweBdBKmIZqqYnh+Yc8hI7Cpy203CaK7e Te3g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=+lH1Z9tr6pJoBJRmRqGieCtYKJd+EPWt2KYFlbc+blI=; fh=EPbsNJMLwlXYTg/MTuk9bwilsoK94uNp6NRacKCAfCI=; b=FdM5CzsDu8lCAdx02evrevXtbA8WR/MWaUP/5M9D/vX+J+1P8D5q4OBgBdsT1C3GZd 5/F1vEtP3XG8nC6/KYG6w0HHas+zpPTGBfO/7dZir3Ebr4MYB8D+ZPg7nH1vDjclXlAm moIMH+2+FJS3MUj/94ubz+eLJSjQmq/08QiUcHDEB893OFZj9Rv3a6+z3TnyCpD2dQVJ A8anierFlquDCyP1osDMmiQwH82Pcror9rTAXkNU35k2kOJlrsd1KOyvemaHSCjg7HyP jfzu9qVKmsSbR7XdVDHW5v+9dFc4TmvI1eALoWpUkC1p8u6E8rGP2sWzlTfhf4w4niF5 M59Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=U5WNUS2Y; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87724-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87724-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id w17-20020ac857d1000000b0042e5ea3ce75si2682110qta.378.2024.02.29.16.13.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 16:13:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87724-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=U5WNUS2Y; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87724-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87724-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 92DFA1C21151 for ; Fri, 1 Mar 2024 00:13:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 81CC54A2E; Fri, 1 Mar 2024 00:12:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="U5WNUS2Y" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 620254A20 for ; Fri, 1 Mar 2024 00:12:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251972; cv=none; b=IS6IAaxyizhB+9ZvTEQe531nDI7H3agOBIABoqBtu061iMBIjSWlTKKJqU+k5S1f6SntKaP75yoDyB1zB6rF+5xfBOInAM6hkpiMPREJ4NQza4jwrfyLVKFB9uAhZwEizzab1C1nWWiaw+0Wf3HfVraqnkgFSCSqu2v6rxRdihY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251972; c=relaxed/simple; bh=x6U7HBr2+APn5ZpeLNHOIRw/a7yOuDvPI1HGkDefAI0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JTySUHP/yviT1/sTxVsKIFhnOrhKnhID2z9m8H/g2udHE3e0X2yKcbdiGINoumSC2vO2fXPYcc/4ioxIyHomQb7H8N039ii9nDulXf1gKKRgPJv66FB5HlqAobFMzyKRnvGh8UktLyeY4Duw6BF0TCPSM7iM2IOoDN76qozMVQw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=U5WNUS2Y; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709251970; bh=x6U7HBr2+APn5ZpeLNHOIRw/a7yOuDvPI1HGkDefAI0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=U5WNUS2YRX2M9Wm9IoWrVZ9o3oKmM9fqRzZeP0ZusgHofuUBWc5bPR92cN0XGwmQa 4Q6qDeRML0MCbRFxg/De9Cqf14L73Un6+fokUNKcPQi5YZfQvziUHwyds+ZQSI1bpo WtPkOKmL4d4CU7WUXN9A1Buz7yG4SaVEAotkZgTBtCVUbNAK+w191RJpbZsiVM+9ca TyEhsr3xRMYGNWkbK+1yQk2EKjCtJqqHCzMbilHW9/HiEPBS0aq23OtuW4NN9J1q6E QbN/bzaOQv17U+DNmzWWOgnW74ciL1YZ6s/KMPHGQ2i3HIBORWIXqPZE0oGgUAUuJM twcOyHfO9wmuw== Received: from [192.168.1.205] (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 09E8D378000E; Fri, 1 Mar 2024 00:12:44 +0000 (UTC) From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Date: Thu, 29 Feb 2024 19:12:12 -0500 Subject: [PATCH v2 6/9] drm/bridge: tc358775: Don't log an error when DSI host can't be found Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240229-anx7625-defer-log-no-dsi-host-v2-6-00506941049a@collabora.com> References: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> In-Reply-To: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , owen , Jagan Teki , Marek Vasut , Adrien Grassein , Srinivas Kandagatla , Sam Ravnborg , Bjorn Andersson , Vinod Koul , Dmitry Baryshkov , Vinay Simha BN , Christopher Vollo , Jessica Zhang , Marijn Suijten , AngeloGioacchino Del Regno Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Mailer: b4 0.13.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792280664731810019 X-GMAIL-MSGID: 1792280664731810019 Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Fixes: b26975593b17 ("display/drm/bridge: TC358775 DSI/LVDS driver") Suggested-by: AngeloGioacchino Del Regno Signed-off-by: Nícolas F. R. A. Prado --- drivers/gpu/drm/bridge/tc358775.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c index 90a89d70d832..fea4f00a20f8 100644 --- a/drivers/gpu/drm/bridge/tc358775.c +++ b/drivers/gpu/drm/bridge/tc358775.c @@ -610,10 +610,8 @@ static int tc_attach_host(struct tc_data *tc) }; host = of_find_mipi_dsi_host_by_node(tc->host_node); - if (!host) { - dev_err(dev, "failed to find dsi host\n"); - return -EPROBE_DEFER; - } + if (!host) + return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n"); dsi = devm_mipi_dsi_device_register_full(dev, host, &info); if (IS_ERR(dsi)) { From patchwork Fri Mar 1 00:12:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 208574 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp762637dyb; Thu, 29 Feb 2024 16:14:11 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVGqicUr+GLt7L6/btbf5jpf2ZcaPHG9BbEL2nuHAt2ygZHN1Yv13trqDmqomfH8SOlWN8UTogNtbqo4vbs42yqMLPvNQ== X-Google-Smtp-Source: AGHT+IGVHEnYOfGj4kOV6/BaXBa1Pe3eZXbcSB0qbH29EHV0gzk831qSXuxkVdlypWmy5ni1+J45 X-Received: by 2002:a05:6358:7f05:b0:176:91bb:9600 with SMTP id p5-20020a0563587f0500b0017691bb9600mr41509rwn.3.1709252051060; Thu, 29 Feb 2024 16:14:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709252051; cv=pass; d=google.com; s=arc-20160816; b=hike6iHlblEmvDAVSEU+4MB+pYUTMXt9JnQmXskDxZEexodyCjLOkcxIcPCmhmVxuc k7dRirtAuOywrT592n5+z0fJIKVjTs5GX5IIZ4DzVsG70hvE0C9V10wdsb37p4UHY+d2 2O1rhNHUGe0Zq/r9zGUuSSqTuxy8wNTyLARojlEHRICIPG687SieoJ/gaunGIstV8vev doXI6gYVCaGlnL4dEFupUNeslrRjVaIrjliN5emlk42RpmzqtvKp2dSIE1tlfJZj5/6p 9MAYmqIz4qQkAqzt/NEmg2gBRz6tfmQ3T8BS6voS5iML/NsHkrfCqfdfNO3DoTOAKX39 S4xQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=OX+EPEkG7V3k8xRDhb2v1k9gcHtjNILHstzSKQIxrfg=; fh=EPbsNJMLwlXYTg/MTuk9bwilsoK94uNp6NRacKCAfCI=; b=b742SawnDetq8i+MXJG8y33beKByM0obMNo+bK6M/3kkppgMlQ/6aQz/l60+fgeJ6Z 2/W/K3Lej8yfTwUNvibkr5NZoivOIiyUflT9sV4YqJV/0hghIFYfxtRFykFIIch0Hwsk 2/hHR2KpMbygWFDSymrInXapklA6FXRLN6uoE9qvNqtzufE4Io2Zqu3LcOE1uhBpPjt7 Z/wj9BBeN94Ky3vlH3QbDANFPdTt6Eyatglw6fLDQcADEQGgqvG+Q+NP30OFX/r2Ef+u vxjTRfHAoP3gukAxJCAPGKdZG3tI0JD3z4rZDOMKHpwXw6Gn6fUJVCREp2PlG5ei7Z+G O7Ng==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=sqzDMqcq; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87725-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87725-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id fv6-20020a056214240600b00690197c48e2si2568772qvb.236.2024.02.29.16.14.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 16:14:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87725-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=sqzDMqcq; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87725-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87725-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id D15281C21236 for ; Fri, 1 Mar 2024 00:14:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 074EB63DD; Fri, 1 Mar 2024 00:13:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="sqzDMqcq" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A83D817E for ; Fri, 1 Mar 2024 00:12:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251979; cv=none; b=JHKYJvknHdLr5lZJpNufUygi+RzQ3jrxVzfA1j6HBHA3j/Kbkj0BR8kV+bg8RPbvS3woR67gjQMfK0yRk+ZTBqiJTlh328kQAHuNf/5zidZZohxxMX6SOSrU77sWtWtuXUT4Nc6LqZnun2Q8/Akzfx4o5/2e+CubHpcoFIK5Em8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251979; c=relaxed/simple; bh=+CKVPsOP7VaA2gwBWrP4ZLU4toVT2KatRN6rysdk1vs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rTpEv62EyJzl2oJIgKCvOVD0GWK36sEPRXMFjy/+N/bNM95Hj+ETTQg1omF/f/8oQq/y01s6ICKL17l2lniZ15blQ8Bgn39zR5WaB1OYcOUeOhhW5A6LUQi5m/B2R0b7aYfR5B3PoYH436nHN0pwTMzNNo8mQV2p2YrBV23MnDI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=sqzDMqcq; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709251975; bh=+CKVPsOP7VaA2gwBWrP4ZLU4toVT2KatRN6rysdk1vs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=sqzDMqcqvD5UoN64HHW3ZFjlCUvz3hvCdeFOV7qiY/TA6mxT6jFofmQOe+9wpnpC2 qSQmKmDrFaMnCq6HWcGMoKcZWWl+nZGmELERlI2jXHRBgMt0ZdsHVRYglcwhIqciV5 pIaHj/AMt9oBdFNsItzChDdshlRhwaUznS4xcx+xi2rO76sNGk6i8QBhWTryMyfckY /sF9/hRXyJmHNkxzyFcOL4HshTOenSegh/A5CrV40SiV0auGJRBtxq0oY/tY5zIOJL Se+bbt7fSzbcSJToyRyC7BXxbvCB/8V2wYaSPs+vGR2dDISGzAhi5xh+qPvM/Ku/LQ BrhfJcPqdEteQ== Received: from [192.168.1.205] (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 5987537820D8; Fri, 1 Mar 2024 00:12:50 +0000 (UTC) From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Date: Thu, 29 Feb 2024 19:12:13 -0500 Subject: [PATCH v2 7/9] drm/bridge: dpc3433: Don't log an error when DSI host can't be found Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240229-anx7625-defer-log-no-dsi-host-v2-7-00506941049a@collabora.com> References: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> In-Reply-To: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , owen , Jagan Teki , Marek Vasut , Adrien Grassein , Srinivas Kandagatla , Sam Ravnborg , Bjorn Andersson , Vinod Koul , Dmitry Baryshkov , Vinay Simha BN , Christopher Vollo , Jessica Zhang , Marijn Suijten , AngeloGioacchino Del Regno Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Mailer: b4 0.13.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792280679069752711 X-GMAIL-MSGID: 1792280679069752711 Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Also move the "failed to attach" error message so that it's only printed when the devm_mipi_dsi_attach() call fails. Fixes: 6352cd451ddb ("drm: bridge: Add TI DLPC3433 DSI to DMD bridge") Suggested-by: AngeloGioacchino Del Regno Signed-off-by: Nícolas F. R. A. Prado --- drivers/gpu/drm/bridge/ti-dlpc3433.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-dlpc3433.c b/drivers/gpu/drm/bridge/ti-dlpc3433.c index ca3348109bcd..6b559e071301 100644 --- a/drivers/gpu/drm/bridge/ti-dlpc3433.c +++ b/drivers/gpu/drm/bridge/ti-dlpc3433.c @@ -319,12 +319,11 @@ static int dlpc_host_attach(struct dlpc *dlpc) .channel = 0, .node = NULL, }; + int ret; host = of_find_mipi_dsi_host_by_node(dlpc->host_node); - if (!host) { - DRM_DEV_ERROR(dev, "failed to find dsi host\n"); - return -EPROBE_DEFER; - } + if (!host) + return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n"); dlpc->dsi = mipi_dsi_device_register_full(host, &info); if (IS_ERR(dlpc->dsi)) { @@ -336,7 +335,11 @@ static int dlpc_host_attach(struct dlpc *dlpc) dlpc->dsi->format = MIPI_DSI_FMT_RGB565; dlpc->dsi->lanes = dlpc->dsi_lanes; - return devm_mipi_dsi_attach(dev, dlpc->dsi); + ret = devm_mipi_dsi_attach(dev, dlpc->dsi); + if (ret) + DRM_DEV_ERROR(dev, "failed to attach dsi host\n"); + + return ret; } static int dlpc3433_probe(struct i2c_client *client) @@ -367,10 +370,8 @@ static int dlpc3433_probe(struct i2c_client *client) drm_bridge_add(&dlpc->bridge); ret = dlpc_host_attach(dlpc); - if (ret) { - DRM_DEV_ERROR(dev, "failed to attach dsi host\n"); + if (ret) goto err_remove_bridge; - } return 0; From patchwork Fri Mar 1 00:12:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 208575 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp762736dyb; Thu, 29 Feb 2024 16:14:24 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXUfqvl+NJf7/PwZiKkIRc/tFAbhH0PxVteRLnSPn2Ga92QsixUz9za//Wi5idF3kmo5bNr3HzCeJR9Tja9EANFSKsgJw== X-Google-Smtp-Source: AGHT+IGx4LNTIvn1mr9f8QD14kusHd7ILbHGVKH+7Z392najBwBF4XPi1GWqZFKjjfWsYjK0EeYk X-Received: by 2002:a05:6358:7f17:b0:17b:62ac:1ddb with SMTP id p23-20020a0563587f1700b0017b62ac1ddbmr27936rwn.23.1709252064412; Thu, 29 Feb 2024 16:14:24 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709252064; cv=pass; d=google.com; s=arc-20160816; b=n5D/ZT7kpYAaErfH+Zjlu/vnX6BuygU7fESgmkpZyPP+4zsoaLjbTCHv6RUJ6KjM/h uH6rTYkxUmRCt24wxoFtm1kIg35ZuH1KEZFCWxVkYylyV77hX0PVr0Au9pYRNkUhQivo kkfRSvVDVVdFQnZ23USnk8Ps1TTZhmt+9eQOIvUTxJgLukUZ6Dimb+i33K8yy2dPRu63 CTwDp++7MsWOcHg9pWB/aTknOl4bXkNKe8n/XjSBkTTaEMK2fsgR9S0ocM6cMAKWoFOU nJsbNB0MG8HQtDFh1QMNC1BE0yxPF1r9x3knjVe1UTPUCtmztVsuWwn26BroSmFJIwl1 64Ag== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=zz5kR7mG6e5NsdwpqHbvSi3t4GCs4tZxByx2jgHJBHo=; fh=EPbsNJMLwlXYTg/MTuk9bwilsoK94uNp6NRacKCAfCI=; b=KH0Sx3bXSUXu6lYOa7LVLVmB430nvAQxxa11Bdtjy5EbfNrB5ZYU8PNLJMImRL60BV h/lMrwh1AkssY/93kea6/Yy8sNYB1w+C/dL8bv9eOPPEMf/Is2ou+pVBjP/kvxCggm9R /03CkoNfmAcgc7EH0McVvTRY3fEg+N/rTisQvIAiizbPm6pjNMn0L/lUAGJBlgF8QY3/ DEedz6QBJPfnOxhbQ7+mrzT7/KE/u+kOakI9cxZHOu80jrCRv2FK7d4MdPAkrsxwrK6I M0t0T7sbBsXB+lTAMlkflMd88WC56zpf/6YVSL4G5KafebxkhP+hx4buOp3FuNSjXRdM BiwQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=M1YLZif1; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87726-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87726-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id gu4-20020a056214260400b0068cdb0ede35si2486620qvb.399.2024.02.29.16.14.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 16:14:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87726-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=M1YLZif1; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87726-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87726-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3485D1C2138A for ; Fri, 1 Mar 2024 00:14:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 58FDC8464; Fri, 1 Mar 2024 00:13:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="M1YLZif1" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EF2E6AA2 for ; Fri, 1 Mar 2024 00:13:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251983; cv=none; b=PjNoqHezDXdCJt5aEEWDnbZzu+bTcJxTAJrtcptndmq2HZZitKR3/Dcsw36zpPOkwBIpnoWcVypCPUnY3+3H39jM/F2SP92OFBb+L2zioasvsS+RFTMQAHlOWmC14ZciTyZXW5NQKpxX4UiZ1zoHNH8H/fPqeC89FYGPsJGc4EY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251983; c=relaxed/simple; bh=MYKBxuR+aJph7D9FYI37RGyFCJkN1zgdY0Ybz9nXzqY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ahWqfKuZiMbQWqWcdOqD3w5Eg3MDMiyD/gnjyBTD1Hl/tfNTea5hGIl4Xs/7VmtRlX2WM4v4tOR+Ea9kfP57NwdegbeI5fUAi/3MUsklLXKq2OSfQd4KhU+7U30dGaJQbjvzMikA0IlxmV6gX86BWxRwEhPzXTOeFuMO1XvLDxM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=M1YLZif1; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709251980; bh=MYKBxuR+aJph7D9FYI37RGyFCJkN1zgdY0Ybz9nXzqY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=M1YLZif1WED+vvuhoA+scIcRTPnw98+XmpYskhv7KfiRTZHliAuL/NFFZwRaikprw 5/kPyPgu+FNAttkzLubD2cCK2Y9EseyttFZrq32z3e+tH4VM4XT1a8lzAl+2JJTiY2 a3MYMdMeHRYcS+hzq0bi5oKBS832zjV9QIzM0svssSolLEF/cgs6mIzRhzPuPcgVXq 3/HWsNnvmiEj4DMlbMpsd7mbO5Cv9QFxBslrY99kO2YhDnq9/EhRKsxC8Cxo5qbeeK CRlZvaITDZW6gdhNvOyuXjmGggHb+LlsoZzZqLWGkPpyW8/lxG0s3JjW4kM+Vq37a/ mdGKQOqTVEt5A== Received: from [192.168.1.205] (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 31A22378000E; Fri, 1 Mar 2024 00:12:56 +0000 (UTC) From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Date: Thu, 29 Feb 2024 19:12:14 -0500 Subject: [PATCH v2 8/9] drm/panel: novatek-nt35950: Don't log an error when DSI host can't be found Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240229-anx7625-defer-log-no-dsi-host-v2-8-00506941049a@collabora.com> References: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> In-Reply-To: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , owen , Jagan Teki , Marek Vasut , Adrien Grassein , Srinivas Kandagatla , Sam Ravnborg , Bjorn Andersson , Vinod Koul , Dmitry Baryshkov , Vinay Simha BN , Christopher Vollo , Jessica Zhang , Marijn Suijten , AngeloGioacchino Del Regno Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Mailer: b4 0.13.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792280692551901375 X-GMAIL-MSGID: 1792280692551901375 Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Fixes: 623a3531e9cf ("drm/panel: Add driver for Novatek NT35950 DSI DriverIC panels") Suggested-by: AngeloGioacchino Del Regno Signed-off-by: Nícolas F. R. A. Prado Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/panel/panel-novatek-nt35950.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35950.c b/drivers/gpu/drm/panel/panel-novatek-nt35950.c index 648ce9201426..028fdac293f7 100644 --- a/drivers/gpu/drm/panel/panel-novatek-nt35950.c +++ b/drivers/gpu/drm/panel/panel-novatek-nt35950.c @@ -556,10 +556,8 @@ static int nt35950_probe(struct mipi_dsi_device *dsi) } dsi_r_host = of_find_mipi_dsi_host_by_node(dsi_r); of_node_put(dsi_r); - if (!dsi_r_host) { - dev_err(dev, "Cannot get secondary DSI host\n"); - return -EPROBE_DEFER; - } + if (!dsi_r_host) + return dev_err_probe(dev, -EPROBE_DEFER, "Cannot get secondary DSI host\n"); nt->dsi[1] = mipi_dsi_device_register_full(dsi_r_host, info); if (!nt->dsi[1]) { From patchwork Fri Mar 1 00:12:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Patchwork-Id: 208576 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp762841dyb; Thu, 29 Feb 2024 16:14:38 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWvRdp92ePoGFb3bIqAI/DVhi8tiY/Q/nbrDD1F67knux7HJJKDAHYSfgCzoIKkqLM5DSpLfIlN6BxHVXYWorPt8Bt36A== X-Google-Smtp-Source: AGHT+IHDFhgC8RhXwbcEXBOJ/B/oIM+NTKjSxHmVkPjI2+pClsEqFqIFPqq8SDR/+Efr9Ka139l6 X-Received: by 2002:a05:6402:3410:b0:566:ab94:5b83 with SMTP id k16-20020a056402341000b00566ab945b83mr147031edc.23.1709252078423; Thu, 29 Feb 2024 16:14:38 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709252078; cv=pass; d=google.com; s=arc-20160816; b=ME9R0cSy75TC1mg49VshxUJYTThzP5i3jKithqqYmIbdN/4PDHjzI7ixWFVlIMYUVk 6SE4+aMex//MaN2o3CNzAVzs80HUyKDE+e2a3bOqNG+ZUqZuLGj7dQFPd/qLklSSTk5b zaG6xthkfGJmU2ZnF8kCN0tyTGNUJIQPEFuvPL+qS5WsnZNJFusVNAZxHPjr5B2covcg r5RA39kg1lQlp4e5nEr6aaIfu3JK5+/eDNH/zamgeAkFCczk5cwhiVeHaaYUJFqDgBLG AQ8RdU0CSBVoTKwd7V37P6JttnyiXOvoVaZL/75yh4fInvWXGt9+ql5ierFbV5LUnpqo RgyA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=+nyFIACTroaWiL3ll8MpLSR1PaoGhCAVsYaEIJjfOg8=; fh=EPbsNJMLwlXYTg/MTuk9bwilsoK94uNp6NRacKCAfCI=; b=vHlg7Fc/GCbS2nftShxUuYwf5YDY8Bz1Mzi5bZYhbyv+q2baxnpF1lpMBPGdVLCgSp 0dNwBr1vyt0bPzcp+WBlVSJXg91/9Wd+EY1gKIfWL4+sMF7fs4RMLhOMlQ1afP1gjm33 B++4fj7rZAr3Wd4WufkYSvbo6zWyGU+hX9jYylaAMHC6oHArQeiVUYQCrLg4Qixk68WF Fd7x5Gsmee7owOmsNYLkIOsDrPvrKI3u1dkitGdD3cvE2OIEm8LombxWoTmFbVQgZmY3 dhGNAjUxp3IymTl/GUfN0eoCbNBuPuNxX8jtcEc6RA9czpvzCYAhZYq+vA2VuJRMaw89 BRiw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=bELh1cTn; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87727-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87727-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id c14-20020aa7c74e000000b0056635572f42si946590eds.588.2024.02.29.16.14.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 16:14:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87727-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=bELh1cTn; arc=pass (i=1 spf=pass spfdomain=collabora.com dkim=pass dkdomain=collabora.com dmarc=pass fromdomain=collabora.com); spf=pass (google.com: domain of linux-kernel+bounces-87727-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87727-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 115541F23354 for ; Fri, 1 Mar 2024 00:14:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8C1798830; Fri, 1 Mar 2024 00:13:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="bELh1cTn" Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B3721364 for ; Fri, 1 Mar 2024 00:13:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251988; cv=none; b=E+HazQQPaMN/SAzZ6isWvX2QdFpk1/CV/UeMtxsCCS+GIV1fW469jsrI3bGecvQa42aFrlnY+Uv/3L7FcrzGyH+v4KsI6uDpO6rp1ni8TBuhqb2P0pkkOXyV7345Bu2Q5lHfsUqtP5qkoIeQotByNONqCH+gCxqZzXk7X/jREvM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709251988; c=relaxed/simple; bh=plA+/Ds0xvFbb6U3u3M8ilxs/x7ZgpNx1PsraFtKLNM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pe9B5wD+WmvR1FWp/T9PQKtym8X5wqrcQaM1j+LtqikpxpDBYHCadWNolXTw83ZwXEoEgZql56ICxCU96DGTFh3R+DxJ2psWmvKz270UM6aZwvU5VwOcrKPV7wPtzZrQmJxy5noPP76ZrSgnHaEAN1YedT302oVQQD72fzZ4H84= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=bELh1cTn; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1709251985; bh=plA+/Ds0xvFbb6U3u3M8ilxs/x7ZgpNx1PsraFtKLNM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=bELh1cTnraZfxf8dHy6VCIwRcfxJwFIbKP+rfx9P36tSUl6jdNOa8bfxW+fFHoI4b AXNq+sfqg0CLcRG+1hGv5RyiLTZHEVHEazsZCCTKDuRpgY8mAKwnnFVaJzhdjEfQU7 9PQx302JO3t6shSX/7rjg9Y0noLFaMcqw9rFHg+/EU52m22oKJ2viqQMMTt5NrxTIF 7xForobxy/oTLhbLNT6/Aqb6wMU4kupeYJDyNl1sCc/BZqVv6uJVPV67C2fk+jsko0 itosv+yHr3qgdhs2GtRG1BCw39+AU390RBMuRZLP7EM/+r4gIqsAWRhlq1PGovcjnJ VMl6h2DznZkUQ== Received: from [192.168.1.205] (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id DEA4037820EE; Fri, 1 Mar 2024 00:13:00 +0000 (UTC) From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= Date: Thu, 29 Feb 2024 19:12:15 -0500 Subject: [PATCH v2 9/9] drm/panel: truly-nt35597: Don't log an error when DSI host can't be found Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240229-anx7625-defer-log-no-dsi-host-v2-9-00506941049a@collabora.com> References: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> In-Reply-To: <20240229-anx7625-defer-log-no-dsi-host-v2-0-00506941049a@collabora.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , owen , Jagan Teki , Marek Vasut , Adrien Grassein , Srinivas Kandagatla , Sam Ravnborg , Bjorn Andersson , Vinod Koul , Dmitry Baryshkov , Vinay Simha BN , Christopher Vollo , Jessica Zhang , Marijn Suijten , AngeloGioacchino Del Regno Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= X-Mailer: b4 0.13.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792280707034610860 X-GMAIL-MSGID: 1792280707034610860 Given that failing to find a DSI host causes the driver to defer probe, make use of dev_err_probe() to log the reason. This makes the defer probe reason available and avoids alerting userspace about something that is not necessarily an error. Suggested-by: AngeloGioacchino Del Regno Signed-off-by: Nícolas F. R. A. Prado Reviewed-by: Abhinav Kumar Reviewed-by: Laurent Pinchart Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Neil Armstrong --- drivers/gpu/drm/panel/panel-truly-nt35597.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-truly-nt35597.c b/drivers/gpu/drm/panel/panel-truly-nt35597.c index b73448cf349d..d447db912a61 100644 --- a/drivers/gpu/drm/panel/panel-truly-nt35597.c +++ b/drivers/gpu/drm/panel/panel-truly-nt35597.c @@ -550,10 +550,8 @@ static int truly_nt35597_probe(struct mipi_dsi_device *dsi) dsi1_host = of_find_mipi_dsi_host_by_node(dsi1); of_node_put(dsi1); - if (!dsi1_host) { - dev_err(dev, "failed to find dsi host\n"); - return -EPROBE_DEFER; - } + if (!dsi1_host) + return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n"); /* register the second DSI device */ dsi1_device = mipi_dsi_device_register_full(dsi1_host, &info);