From patchwork Thu Feb 29 15:56:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maciej Strozek X-Patchwork-Id: 208404 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2097:b0:108:e6aa:91d0 with SMTP id gs23csp509742dyb; Thu, 29 Feb 2024 08:16:19 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVppqaTtKt2aYzCA3ncRfPcxZxOCFLsSz6IK3X1XAFGOfE0eylGrzdZOHdck/IVARmX8a4E7Z7+pvezamYVnBff5qwc0A== X-Google-Smtp-Source: AGHT+IGIB2orjnnnwpeMHi4oaQstyk8nzJzrEE/vDYPer5/ZsA1AFQ6L8VwPz9AFFbnGPFnUPumf X-Received: by 2002:a05:620a:2230:b0:787:c57a:e41b with SMTP id n16-20020a05620a223000b00787c57ae41bmr2619225qkh.49.1709223379741; Thu, 29 Feb 2024 08:16:19 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709223379; cv=pass; d=google.com; s=arc-20160816; b=Lj2UNqYlNB205HIbsyu+A8ixhhQ5o0RpLFuXPu+O1AKU5vyajsteueTdFzWmo6nEpp z9N1jbqcy86qtQK6QgnulzVM3Xuha75LPx+La5mK+M509NCqhuJ2aTVn7N5Xg7r1RHsL nHTBaxuvQJSIc3tNkns5he2TXYFbLWbPqJzZVPC/csbK2uQiFV9dzIG7n8oIV1cxnEsg 6acZ70fcIDEdClVts/doNA+RRUjr/rWM/qoPMUWQQb8dsGEeaXiRHnGi0bvaYjVSYvtm LUNkRqRzIHfZVs7QF+eVr3eZuvLfzoymGaOw3wKnAd3t2DVjVByEmpcns5aeynT72eLb zt3Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=iZMbhk8sFajOWu5eQuTJqb2j6jAdfI9Sm0TUstq/FPc=; fh=lOUxn5AfYUn419uzu5t+C6KSq4Sh++gVFRxRk/g2Na4=; b=Fsf2L9wE0KU8SdZN+YqdX+qD6vCIfQQoKzjjnGJ9+quWnSxJzxH42J7kOhQqu7N6b9 TCJDStCUHQkSM4/pbO1UIXyh7Y3QIvGMC0BWurYZeTR7mPNHCBJCtPEoAIL6fyF67ygy 3P0XT+O2itIRETpgSIb+ZpBWVvHGQ0sQ12NiCDcIZpEp4i00KMfh+BWMLumRgsoQg6CJ xXd/AGusDtfqzDJNnEW1E/ShNh7Z4EUWWc8ScC9lKnDo1djaU3WNmwNpSwTlLT17oIZb fnIFaFVDFeYJc1zAFQz/Ni/DHmQAyWTbDT6tnL1ha9BYY5J7eUQhkfNekeDCkCWqBYaE VgCQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=eb8czAnm; arc=pass (i=1 spf=pass spfdomain=opensource.cirrus.com dkim=pass dkdomain=cirrus.com dmarc=pass fromdomain=opensource.cirrus.com); spf=pass (google.com: domain of linux-kernel+bounces-87038-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87038-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id g21-20020a05620a109500b007873204bc3esi1635060qkk.645.2024.02.29.08.16.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 08:16:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87038-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=eb8czAnm; arc=pass (i=1 spf=pass spfdomain=opensource.cirrus.com dkim=pass dkdomain=cirrus.com dmarc=pass fromdomain=opensource.cirrus.com); spf=pass (google.com: domain of linux-kernel+bounces-87038-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87038-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 778101C220C0 for ; Thu, 29 Feb 2024 16:16:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 89A7B6CC19; Thu, 29 Feb 2024 15:56:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="eb8czAnm" Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2CCE6CBE6; Thu, 29 Feb 2024 15:56:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.149.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709222202; cv=none; b=Cyu3YbUS847Pz1kwdDQ2LFd9Ptup2hCpcD4CSfcSAeSuAsAckER4YeTikl86cxF/E06uMTMNH/9+QcNVFihq8SySicjAp85FkIgfZk1N/4gsQzlNQl/eC43aR62HHCt907gHXPJtK51LS2cpKJ2awQw5dmTmYyafP5oE/wlPW2k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709222202; c=relaxed/simple; bh=iOmQTVDs9UpkKV8z9c2K0lKOA26i1Ri15LvtFNJTn8A=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=M+LQ5iORK+jk+4Yi5hvQe5AhwZP/Egi/liAGZtRpmdSazjBZciYWDDaBMra6DbSEQ3bbg4m+cejeyaLdloIiTIt9ZR07c2Y3afHD2exRO/19EUH0B9hbq7zb+HKSwDDXZ2Apr8ZZaVm1ZK9vJd4IBD3nH00SFMF4/R98XjqOn30= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=eb8czAnm; arc=none smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41TFednF032401; Thu, 29 Feb 2024 09:56:32 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:content-type; s=PODMain02222019; bh=i ZMbhk8sFajOWu5eQuTJqb2j6jAdfI9Sm0TUstq/FPc=; b=eb8czAnmLUIYEq3Mp itKwz2CGsCUniyiiZjmJr43zii6sIXHyx0pUN0Wd3WooIZySTNb3KtVSfixxW8GU 8luTD+olhfECHYXyeot2ZoaQxsacq+2/jgKBQ09TnFrhRGdKhwU5ajsRPf2I2s4w oZc4wsFKLGLSJk4A8n8tmKpGBC2K4xTrC5cxYlYi2X+Lgeb3doExlS82RxOVAbI3 193Pi8NW1A8PqWgLvpH6bffIMGtOOZMaDOVjtbeZgpEfcjSk5Es8tQ1U+ECySmW3 8N+Ip0sPds4ff3Do0iWZk4vBOIn1/7mrer45GnvmYT5UXKKEKhOPd/x6v5ZEbaZT LF+/g== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3wfer2xgnp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 29 Feb 2024 09:56:31 -0600 (CST) Received: from ediex01.ad.cirrus.com (198.61.84.80) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Thu, 29 Feb 2024 15:56:29 +0000 Received: from ediswmail9.ad.cirrus.com (198.61.86.93) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40 via Frontend Transport; Thu, 29 Feb 2024 15:56:29 +0000 Received: from fedora.ad.cirrus.com (unknown [198.90.251.53]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTP id A6A8C820241; Thu, 29 Feb 2024 15:56:29 +0000 (UTC) From: Maciej Strozek To: Lee Jones CC: , , , , Maciej Strozek Subject: [PATCH] mfd: cs42l43: Fix wrong register defaults Date: Thu, 29 Feb 2024 15:56:14 +0000 Message-ID: <20240229155616.118457-1-mstrozek@opensource.cirrus.com> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-GUID: CC-fgD8xa4r1UDu6RkNYlS7WZ_JrIDta X-Proofpoint-ORIG-GUID: CC-fgD8xa4r1UDu6RkNYlS7WZ_JrIDta X-Proofpoint-Spam-Reason: safe X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792250614407922018 X-GMAIL-MSGID: 1792250614407922018 A few regs have unnecessary values in defaults, change them to match the datasheet Fixes: ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver") Signed-off-by: Maciej Strozek --- drivers/mfd/cs42l43.c | 68 +++++++++++++++++++++---------------------- 1 file changed, 34 insertions(+), 34 deletions(-) -- 2.30.2 diff --git a/drivers/mfd/cs42l43.c b/drivers/mfd/cs42l43.c index 7b6d07cbe6fc..73c88ee6a866 100644 --- a/drivers/mfd/cs42l43.c +++ b/drivers/mfd/cs42l43.c @@ -131,38 +131,38 @@ const struct reg_default cs42l43_reg_default[CS42L43_N_DEFAULTS] = { { CS42L43_ASP_TX_CH4_CTRL, 0x00170091 }, { CS42L43_ASP_TX_CH5_CTRL, 0x001700C1 }, { CS42L43_ASP_TX_CH6_CTRL, 0x001700F1 }, - { CS42L43_ASPTX1_INPUT, 0x00800000 }, - { CS42L43_ASPTX2_INPUT, 0x00800000 }, - { CS42L43_ASPTX3_INPUT, 0x00800000 }, - { CS42L43_ASPTX4_INPUT, 0x00800000 }, - { CS42L43_ASPTX5_INPUT, 0x00800000 }, - { CS42L43_ASPTX6_INPUT, 0x00800000 }, - { CS42L43_SWIRE_DP1_CH1_INPUT, 0x00800000 }, - { CS42L43_SWIRE_DP1_CH2_INPUT, 0x00800000 }, - { CS42L43_SWIRE_DP1_CH3_INPUT, 0x00800000 }, - { CS42L43_SWIRE_DP1_CH4_INPUT, 0x00800000 }, - { CS42L43_SWIRE_DP2_CH1_INPUT, 0x00800000 }, - { CS42L43_SWIRE_DP2_CH2_INPUT, 0x00800000 }, - { CS42L43_SWIRE_DP3_CH1_INPUT, 0x00800000 }, - { CS42L43_SWIRE_DP3_CH2_INPUT, 0x00800000 }, - { CS42L43_SWIRE_DP4_CH1_INPUT, 0x00800000 }, - { CS42L43_SWIRE_DP4_CH2_INPUT, 0x00800000 }, - { CS42L43_ASRC_INT1_INPUT1, 0x00800000 }, - { CS42L43_ASRC_INT2_INPUT1, 0x00800000 }, - { CS42L43_ASRC_INT3_INPUT1, 0x00800000 }, - { CS42L43_ASRC_INT4_INPUT1, 0x00800000 }, - { CS42L43_ASRC_DEC1_INPUT1, 0x00800000 }, - { CS42L43_ASRC_DEC2_INPUT1, 0x00800000 }, - { CS42L43_ASRC_DEC3_INPUT1, 0x00800000 }, - { CS42L43_ASRC_DEC4_INPUT1, 0x00800000 }, - { CS42L43_ISRC1INT1_INPUT1, 0x00800000 }, - { CS42L43_ISRC1INT2_INPUT1, 0x00800000 }, - { CS42L43_ISRC1DEC1_INPUT1, 0x00800000 }, - { CS42L43_ISRC1DEC2_INPUT1, 0x00800000 }, - { CS42L43_ISRC2INT1_INPUT1, 0x00800000 }, - { CS42L43_ISRC2INT2_INPUT1, 0x00800000 }, - { CS42L43_ISRC2DEC1_INPUT1, 0x00800000 }, - { CS42L43_ISRC2DEC2_INPUT1, 0x00800000 }, + { CS42L43_ASPTX1_INPUT, 0x00000000 }, + { CS42L43_ASPTX2_INPUT, 0x00000000 }, + { CS42L43_ASPTX3_INPUT, 0x00000000 }, + { CS42L43_ASPTX4_INPUT, 0x00000000 }, + { CS42L43_ASPTX5_INPUT, 0x00000000 }, + { CS42L43_ASPTX6_INPUT, 0x00000000 }, + { CS42L43_SWIRE_DP1_CH1_INPUT, 0x00000000 }, + { CS42L43_SWIRE_DP1_CH2_INPUT, 0x00000000 }, + { CS42L43_SWIRE_DP1_CH3_INPUT, 0x00000000 }, + { CS42L43_SWIRE_DP1_CH4_INPUT, 0x00000000 }, + { CS42L43_SWIRE_DP2_CH1_INPUT, 0x00000000 }, + { CS42L43_SWIRE_DP2_CH2_INPUT, 0x00000000 }, + { CS42L43_SWIRE_DP3_CH1_INPUT, 0x00000000 }, + { CS42L43_SWIRE_DP3_CH2_INPUT, 0x00000000 }, + { CS42L43_SWIRE_DP4_CH1_INPUT, 0x00000000 }, + { CS42L43_SWIRE_DP4_CH2_INPUT, 0x00000000 }, + { CS42L43_ASRC_INT1_INPUT1, 0x00000000 }, + { CS42L43_ASRC_INT2_INPUT1, 0x00000000 }, + { CS42L43_ASRC_INT3_INPUT1, 0x00000000 }, + { CS42L43_ASRC_INT4_INPUT1, 0x00000000 }, + { CS42L43_ASRC_DEC1_INPUT1, 0x00000000 }, + { CS42L43_ASRC_DEC2_INPUT1, 0x00000000 }, + { CS42L43_ASRC_DEC3_INPUT1, 0x00000000 }, + { CS42L43_ASRC_DEC4_INPUT1, 0x00000000 }, + { CS42L43_ISRC1INT1_INPUT1, 0x00000000 }, + { CS42L43_ISRC1INT2_INPUT1, 0x00000000 }, + { CS42L43_ISRC1DEC1_INPUT1, 0x00000000 }, + { CS42L43_ISRC1DEC2_INPUT1, 0x00000000 }, + { CS42L43_ISRC2INT1_INPUT1, 0x00000000 }, + { CS42L43_ISRC2INT2_INPUT1, 0x00000000 }, + { CS42L43_ISRC2DEC1_INPUT1, 0x00000000 }, + { CS42L43_ISRC2DEC2_INPUT1, 0x00000000 }, { CS42L43_EQ1MIX_INPUT1, 0x00800000 }, { CS42L43_EQ1MIX_INPUT2, 0x00800000 }, { CS42L43_EQ1MIX_INPUT3, 0x00800000 }, @@ -171,8 +171,8 @@ const struct reg_default cs42l43_reg_default[CS42L43_N_DEFAULTS] = { { CS42L43_EQ2MIX_INPUT2, 0x00800000 }, { CS42L43_EQ2MIX_INPUT3, 0x00800000 }, { CS42L43_EQ2MIX_INPUT4, 0x00800000 }, - { CS42L43_SPDIF1_INPUT1, 0x00800000 }, - { CS42L43_SPDIF2_INPUT1, 0x00800000 }, + { CS42L43_SPDIF1_INPUT1, 0x00000000 }, + { CS42L43_SPDIF2_INPUT1, 0x00000000 }, { CS42L43_AMP1MIX_INPUT1, 0x00800000 }, { CS42L43_AMP1MIX_INPUT2, 0x00800000 }, { CS42L43_AMP1MIX_INPUT3, 0x00800000 },