From patchwork Wed Feb 28 19:47:29 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhinav Kumar X-Patchwork-Id: 208023 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp3572839dyb; Wed, 28 Feb 2024 11:48:41 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUXnnr57/a6thIlDAlweCRSbBDUTnhglbaXV3k5oIw3G0y+nIi2a7HO8fQdI/3mFQHucnvSix6ioB77+U86rfYaF9mR9A== X-Google-Smtp-Source: AGHT+IE2/KByWfJi/tkd2dClKas3CX9bQV/fwxPUIIt8XmTcrSJpafHWcWahj/6VLQfRALeL0NjM X-Received: by 2002:a17:902:d504:b0:1db:ab71:a4ae with SMTP id b4-20020a170902d50400b001dbab71a4aemr542829plg.42.1709149721760; Wed, 28 Feb 2024 11:48:41 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709149721; cv=pass; d=google.com; s=arc-20160816; b=U2sRasiVHWPt26ivGLH4Uu5EwQnkGPXsFgAEZRvwgTrQzcrd5UZSIKJ+2Zmij9mqjG yTfHaGHVUG7xSR5zF0/olkCrP6QZ3P85DPB2EvrSeN8B5VdfVf1GhNm9NmZHIGO4v+AI j5MYLo5vchRCRE+0DZRH95lUmirWWK4/jQgBrM0VattwTteunzBHiC4YDVuyxx54z1Xn COYarfvfc/ik6U5lPYgQOueSV4vpoCF2a50oSiwBJVz/kaYtjRBjMxo/n9GpD5U+V0Q1 bqIGPdySQNCaXF3xhUYJKxg237PoRf1TNV0KYdyEYXsz98sE4SptXIRttC10R3qezzL+ 3vnw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=whxourVMeBw3kwOIKUI1wmUPTkxnfJ/I0Aau54gzUIc=; fh=YVyZ52J11q3dJXPerqbUq6V4YBcPvT30IUa0ZagnGKQ=; b=aIpoZZKFlroBp2lMXfpchIt/I3qnf1LZ3/fvK3Y+iyGMMsSHfdn1fbxAgK1y6CbPep nl6lenatQvZ0mR8SV2YG8vBF0hCw7xLRNibJLUWnKJedyvRCJQwXjc62hewEYF2A0LUy ftFn8nmLNEjidEl6VcV56kYD5BnV0f8IkFvEw0zioXcflh+Ct8N5kkJDbCg5DjHjXzLZ zdtSHoa/a7E8AMbQxIw+RVi7gCkR/PrmLR84xMTo19JLHhsFX2IsyDm99Gcr2tYOXHRF EJ0GUY+ZLH2fgq8qYbsYcwMiXegH1RBe9s1zn/AaJXWa6tq3HrME6VsCHa71jReItY4U M98w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=RIvtqqoL; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-85638-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85638-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id m1-20020a170902db0100b001da195b41dfsi5078plx.390.2024.02.28.11.48.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 11:48:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-85638-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=RIvtqqoL; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-85638-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85638-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9546028A711 for ; Wed, 28 Feb 2024 19:48:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3FC4F15B10D; Wed, 28 Feb 2024 19:48:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="RIvtqqoL" Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7ECB75E079; Wed, 28 Feb 2024 19:47:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709149680; cv=none; b=G34hYqTSdI4cYpvOhBoLp9VDgf2HEtf30rSujZPsx7AYr2L+JNw1Uyej1TNgGrEXRVXVuXSb0SJu5xRrLdMfZhHq17Uq4jPDBwZUWXUX+QIPqDpxDzAVqVIH8CShaAZvw48rhZLaXbC75NO7Pzsqn6I8ibjhpR2NzX+tDGwUT9I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709149680; c=relaxed/simple; bh=zaT9na3scafxiRpoJGguXXYSrd/N3rHIXAnXIhPJxkQ=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=iDjpUqsoevgjDKnwW1FEpPMzRk0BzZ0WJxc06Hc16H8hd6kqXp/fMBupFKRvhgagJsx48TvjHFt7QfwfIMv+tOChpcxZSx8ngJCjYbCb7DeLE3yUA0E8rcwAmI8eOhug2m4VMUeq+iBCNkNQGAIr5RkpynLt+MLM8mv+MCUTONQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=RIvtqqoL; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41SId338018907; Wed, 28 Feb 2024 19:47:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:content-type; s=qcppdkim1; bh=whxourV MeBw3kwOIKUI1wmUPTkxnfJ/I0Aau54gzUIc=; b=RIvtqqoLpqeWQ4wWovKxKad OyKMqSudYScHDDXSuxLHL/FZ5fsCpljz2DW5ss68mN7M0H2qN/iUpe6obLF/yMyF RVIUQCfgED65tu3lifQmzi0R+9KI/f3h1fRK10EKOoU2z3M6HeHOqVxBXx4bMdMX GFdDGa7scfOp979GyEtEzmOafdO7PCIDS1HYCdyvlO7ZHzBhagQKzqJURdQi3d9p 3K6ulTJwGPCqlL5gPRWGjj5XJ2HMAxjQj7j/W8F9JnxjiYp458wTLEilyNFWv0uV JNmB0E8nG43n4LKiZ+peDUt4rKF/vXuShaFfecTfNcE77PEo0D6h01VxIdcqgYw= = Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wja0eg66j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Feb 2024 19:47:48 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 41SJlkRa022143 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Feb 2024 19:47:46 GMT Received: from abhinavk-linux1.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 28 Feb 2024 11:47:46 -0800 From: Abhinav Kumar To: , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , "Daniel Vetter" CC: , , , , Subject: [PATCH 1/2] drm/msm/dpu: drop unused dpu_kms from interface initialization Date: Wed, 28 Feb 2024 11:47:29 -0800 Message-ID: <20240228194730.619204-1-quic_abhinavk@quicinc.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: u1ew2RsuXItpJHf9_6JmdetIjdjS_gRq X-Proofpoint-ORIG-GUID: u1ew2RsuXItpJHf9_6JmdetIjdjS_gRq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-28_08,2024-02-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 mlxscore=0 impostorscore=0 adultscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2402120000 definitions=main-2402280155 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792173378912810332 X-GMAIL-MSGID: 1792173378912810332 dpu_kms seems unused while initializing DSI, HDMI and DP through their respective _dpu_kms_initialize_* functions. Hence lets drop the parameter altogether. Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c index 2af62d8fa9a7..ab924ac78c9b 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c @@ -494,8 +494,7 @@ static void dpu_kms_wait_flush(struct msm_kms *kms, unsigned crtc_mask) } static int _dpu_kms_initialize_dsi(struct drm_device *dev, - struct msm_drm_private *priv, - struct dpu_kms *dpu_kms) + struct msm_drm_private *priv) { struct drm_encoder *encoder = NULL; struct msm_display_info info; @@ -558,8 +557,7 @@ static int _dpu_kms_initialize_dsi(struct drm_device *dev, } static int _dpu_kms_initialize_displayport(struct drm_device *dev, - struct msm_drm_private *priv, - struct dpu_kms *dpu_kms) + struct msm_drm_private *priv) { struct drm_encoder *encoder = NULL; struct msm_display_info info; @@ -592,8 +590,7 @@ static int _dpu_kms_initialize_displayport(struct drm_device *dev, } static int _dpu_kms_initialize_hdmi(struct drm_device *dev, - struct msm_drm_private *priv, - struct dpu_kms *dpu_kms) + struct msm_drm_private *priv) { struct drm_encoder *encoder = NULL; struct msm_display_info info; @@ -671,19 +668,19 @@ static int _dpu_kms_setup_displays(struct drm_device *dev, int rc = 0; int i; - rc = _dpu_kms_initialize_dsi(dev, priv, dpu_kms); + rc = _dpu_kms_initialize_dsi(dev, priv); if (rc) { DPU_ERROR("initialize_dsi failed, rc = %d\n", rc); return rc; } - rc = _dpu_kms_initialize_displayport(dev, priv, dpu_kms); + rc = _dpu_kms_initialize_displayport(dev, priv); if (rc) { DPU_ERROR("initialize_DP failed, rc = %d\n", rc); return rc; } - rc = _dpu_kms_initialize_hdmi(dev, priv, dpu_kms); + rc = _dpu_kms_initialize_hdmi(dev, priv); if (rc) { DPU_ERROR("initialize HDMI failed, rc = %d\n", rc); return rc; From patchwork Wed Feb 28 19:47:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhinav Kumar X-Patchwork-Id: 208022 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp3572781dyb; Wed, 28 Feb 2024 11:48:34 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWY2hVs6VMtw821QBHGZ+eaMOHeI0/ueP8dPP0fRMF9mjPRLLzOFlHh3tP8o8tE+3V23WNMGw6mYU7XBCbfmhvABMzDSw== X-Google-Smtp-Source: AGHT+IHvZf8ZZwHLNovVXii+yZDsvlaCtEXU5Efruzt5HAIJaEFSZJww6nFiXz82OGhIpxsqwY5B X-Received: by 2002:ac8:5f53:0:b0:42e:6dc1:baea with SMTP id y19-20020ac85f53000000b0042e6dc1baeamr16043297qta.67.1709149713905; Wed, 28 Feb 2024 11:48:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709149713; cv=pass; d=google.com; s=arc-20160816; b=KETp2s3glFOXhMkX2IN++3WFa92xL762x6flbiLaLEXYDgYY1VHoIZqnbuJ66i6pNW xbm1sH1aj3bOo7WX6TxhiwjDLuBJIg3OM39C3H9Pi8Vt8TvMQl7V85+aFz4fwrvTUJ41 5LlR6PolN/GbImslkWfJRNF5jbipcXUNmVHgc4gL7/MaRy1DG1Ilrb7n44w+b6IoUL16 jwRNP5GQpzP+2q6TN9zp7WqkbASE6RzXwXnvJrDOurMNjcehaSWH/3Rk8+hHfKI7fVYL u9xv7/YpDErGzSSh+H+iAp6uZkg7K4llWo5TCNvh7+pugrVc/QabmzaoY8NJU9+VemYQ xStw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=/GMSX6sWWOsoo4/guSjduizGVhX6C3jE3qMT/B6BT0I=; fh=YVyZ52J11q3dJXPerqbUq6V4YBcPvT30IUa0ZagnGKQ=; b=06AZDeyXIdzB7QtF96ip2B+xJ05Fu1JEe+SEz5m2ETrcw4QgxEzm9SPKz0mt/T2/T1 JioXhxXsJwVtr9FRuU4LQFlq78HxSJzavNlowaNCdQXmqSLRCmt66w9ne8UfgzbWxPeK WNvO4S/GmiH6OzCGbc0phY/pSIoubTgs0Wp/CZMsalTgdhcITlBv2dzOjFvkqF4U2jAR IyUrj+0rjam3IsnHvfmAw9zYixxvtVes4knKCnyLvQRTOgVJTJet0ijhVznokP48mA8U m/EnSgJ2vHTCVNsQhFdbvN3INT2HGNJQ/hrxKrIyHnDve74GtqmAg6noZb2VC26Zudmx 9Ggw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=dnr0I0WC; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-85637-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85637-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id b14-20020ac844ce000000b0042e82388261si127188qto.597.2024.02.28.11.48.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 11:48:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-85637-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=dnr0I0WC; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-85637-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-85637-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id ACAED1C25544 for ; Wed, 28 Feb 2024 19:48:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D0F6179B7A; Wed, 28 Feb 2024 19:48:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="dnr0I0WC" Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EC945E078; Wed, 28 Feb 2024 19:47:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709149679; cv=none; b=CyPCwxr0C2OL2UfVaFF/AcyYg4n4Gy8BR0kTRl4KvhRpNSe6PJpoQy//V+2YIBTSZ3VQhSuitx8nSxoxfHb6DvJlSH3ysMWBw+1UidSut3aVzDcchQKMazw7LoOgKbRmwoL+xdIRe2lwcpXcVnVkkUFhPkNqTwYZbJuI2WX8wg8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709149679; c=relaxed/simple; bh=VQbyziJAP7JAIcKEKd9Vn9Y5B1NnuYr6pANlsjIOyc4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DtZgn0AvUSvlZOUMkDk1NhwVvBq+mVB50jjdI9Aj4+fCvHUQhkF0JNZJXsjGl6pDKf0VVlysoS5Go0T9xhGuCF8et6DlErLC+0vQrWcI2Ja94+4zpXdr1lQqx+pjnXgnsSBQxEE1m89LxoV5mVSH+XOVJ3Om6MGbtI3lpq2SYCI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=dnr0I0WC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 41SIhofu018782; Wed, 28 Feb 2024 19:47:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s= qcppdkim1; bh=/GMSX6sWWOsoo4/guSjduizGVhX6C3jE3qMT/B6BT0I=; b=dn r0I0WCLmpJ7yRgeUxarmRSqJbqgKA0DIbaxz5n531Wdam9NfI+pHS6Ka3Q8xDpD8 NUmJEYWo1+tKl+cNLcC0NDuPW8AujlvYJYNMsS+Bdw0+G9l9bOad8pRDVDJbZUsW lHc2nNT2kJaEDIdPGz+IuFfMIZBj8it4bRRVTnLXgkSgL926y0uGRdtW4q+z/W0j m6JsfrohLIxuISjXCwsGXjpC4uTF+6TzDduDS5OVkkECoF8GgoEELV/uG4G66hS2 RK6udHpvSuvfmtb8lJxnp1xZucj2uc9uKqOkYxDpKaVYw/TLxsfTjNxv0G0eCLCQ 2BfUmSLUkzfFPv5FvjUw== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3wj1d9sqhq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Feb 2024 19:47:49 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 41SJlmjc022155 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Feb 2024 19:47:48 GMT Received: from abhinavk-linux1.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 28 Feb 2024 11:47:48 -0800 From: Abhinav Kumar To: , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , "Daniel Vetter" CC: , , , , Subject: [PATCH 2/2] drm/msm/dpu: drop dpu_kms from _dpu_kms_initialize_writeback Date: Wed, 28 Feb 2024 11:47:30 -0800 Message-ID: <20240228194730.619204-2-quic_abhinavk@quicinc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240228194730.619204-1-quic_abhinavk@quicinc.com> References: <20240228194730.619204-1-quic_abhinavk@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: E7B4iOBq6kJLWRIraPW-OwGfl0u8BEd1 X-Proofpoint-ORIG-GUID: E7B4iOBq6kJLWRIraPW-OwGfl0u8BEd1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-28_08,2024-02-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 impostorscore=0 spamscore=0 priorityscore=1501 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2402120000 definitions=main-2402280156 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792173369991930588 X-GMAIL-MSGID: 1792173369991930588 Following the pattern of other interfaces, lets align writeback as well by dropping the dpu_kms parameter in its _dpu_kms_initialize_* function. Signed-off-by: Abhinav Kumar Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c index ab924ac78c9b..382ef4c8e8eb 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c @@ -620,13 +620,12 @@ static int _dpu_kms_initialize_hdmi(struct drm_device *dev, } static int _dpu_kms_initialize_writeback(struct drm_device *dev, - struct msm_drm_private *priv, struct dpu_kms *dpu_kms, + struct msm_drm_private *priv, u32 maxlinewidth, const u32 *wb_formats, int n_formats) { struct drm_encoder *encoder = NULL; struct msm_display_info info; const enum dpu_wb wb_idx = WB_2; - u32 maxlinewidth; int rc; memset(&info, 0, sizeof(info)); @@ -636,8 +635,6 @@ static int _dpu_kms_initialize_writeback(struct drm_device *dev, info.h_tile_instance[0] = wb_idx; info.intf_type = INTF_WB; - maxlinewidth = dpu_rm_get_wb(&dpu_kms->rm, info.h_tile_instance[0])->caps->maxlinewidth; - encoder = dpu_encoder_init(dev, DRM_MODE_ENCODER_VIRTUAL, &info); if (IS_ERR(encoder)) { DPU_ERROR("encoder init failed for dsi display\n"); @@ -690,9 +687,12 @@ static int _dpu_kms_setup_displays(struct drm_device *dev, if (dpu_kms->catalog->wb_count) { for (i = 0; i < dpu_kms->catalog->wb_count; i++) { if (dpu_kms->catalog->wb[i].id == WB_2) { - rc = _dpu_kms_initialize_writeback(dev, priv, dpu_kms, - dpu_kms->catalog->wb[i].format_list, - dpu_kms->catalog->wb[i].num_formats); + u32 wb_maxlinewidth = dpu_kms->catalog->wb[i].maxlinewidth; + const u32 *wb_formats = dpu_kms->catalog->wb[i].format_list; + u32 n_formats = dpu_kms->catalog->wb[i].num_formats; + + rc = _dpu_kms_initialize_writeback(dev, priv, wb_maxlinewidth, + wb_formats, n_formats); if (rc) { DPU_ERROR("initialize_WB failed, rc = %d\n", rc); return rc;