From patchwork Tue Feb 27 21:00:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Souza, Jose" X-Patchwork-Id: 207426 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp2961543dyb; Tue, 27 Feb 2024 13:00:49 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUa8XOazqFIhIwlSZpvVSV9DKsecLZiTwuOTcQQYto+0v/SDyHyH4hbYwshQCNB6fCsV8mN9UWMwBUEmuTjz1T48Ugqrg== X-Google-Smtp-Source: AGHT+IHbWe0AI/5mUH4+XAC3mJWzbSQE5xe/t3lCFUa3UXOz6OdexV4ahoSKJTWcwaT+2Ci6w8e+ X-Received: by 2002:aa7:df0e:0:b0:565:f51:3b26 with SMTP id c14-20020aa7df0e000000b005650f513b26mr7903653edy.30.1709067649636; Tue, 27 Feb 2024 13:00:49 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709067649; cv=pass; d=google.com; s=arc-20160816; b=UvAKnPL8gU8ZWUnKeAS9/93AbljvJeamHMkRar2X/7qtJqouWArlvpRWEQyjzWszAo Zx6bBNQYgRtHMPWR0fNre1E45EJUFC88wI8x3JBsHsBQ6Vqrpx2vG2wsYg8MRgB3loY8 UhH/470+6tTH2mAV2FlI8T3mY99lB1Pu+rOofXtxcF28pM9CtdZLC23PGMFV14icGf6d gedimclhGrKnxoV0yNeBx0r0eNV4Kdt2hJ8Jh/ACNY90VeUtrn9luJ2GvhRm28T6Mzw0 kN20wqizmvAnt921QpHNfpLuYjagfjLx7UPIZgR35wztfB3HdL1pkcBDLS0H3tbLT9CA qtMg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=HBGsraC8xcfuBlVVXonM0asONE2oxZ0KqbeSqC/uLK4=; fh=/aA3ikCzdHUoND1NkELyjjOlZC31bXhfya5LgPc2Wj8=; b=H1yoV/0JQP+Ugac21BAnIrh5gIN4+Znbc4y/n3ur8Q+JCyb3gnvTASo0SwewYLrAsL vv4bviBBTHChWSCmrkVcCSfOZ39npCo0koCl5EbzNS0A7Bp5QECebSxuZsOwYTDoXVb9 kfPxVgPCaYYzKjRs+v0PNP4Z7XHBaQQx4DbiZ1KAg9xss6d11QBBr0lr2UBTElsCtvHJ Uf+ded4oCh6iib+t2fw2dAypz/SvPFZUxXrKNecc5JH9vOTGvbRrxpJpKQumVpA4Wvj3 mLtBQYub5MAhpbTvnxmPkg9dUxefJIkMId6gMUoztSet9qvjWO/mSNMkOi5XpRzb2/GX H9Qg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=nhxqhSbD; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-84007-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84007-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id p23-20020a056402075700b00565b4b999absi986052edy.428.2024.02.27.13.00.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 13:00:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-84007-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=nhxqhSbD; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-84007-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84007-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 41C6B1F247C3 for ; Tue, 27 Feb 2024 21:00:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D6D1E14F970; Tue, 27 Feb 2024 21:00:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="nhxqhSbD" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBE3513AA36 for ; Tue, 27 Feb 2024 21:00:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709067620; cv=none; b=rQkU8Yj/21RogQ6xWqD9ZjfLMIHYmj7nVMiW4FpvrrYsj7xL+WvWNj+a6J4nKRXnBNqWmnSM1Gbk2OWsWIK6mkgV3B/tmnz8TXLJ4Hfpl1giQJ/STLcMMEJGpF+Njqa2Ekggf/LPQt3Ou+9qbJl7D0EsfunhvMXdYEZDJc9GBgE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709067620; c=relaxed/simple; bh=RE/r0QBlJkpfsDcdAyyvBwd5gHrITMQLec9sLSeOxDo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Ta5SXgPrniOfUXMze+a5DXyQCUB8IhV3Yyzry6AhtO2VmejP0ap2FTfS/QSyvFfpShOsEhlSbVn1JmIBgCjgVi1EBOxkWwUCo0DfAY5e91dbqsD8NOQ9H3lzO9RcXb2ht1dlQBbBuYomDLbaZVooJF1iwHZjL/kCantKbqlKW8g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=nhxqhSbD; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709067618; x=1740603618; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=RE/r0QBlJkpfsDcdAyyvBwd5gHrITMQLec9sLSeOxDo=; b=nhxqhSbDiBp972rNAyv08Ln4t9PLnmkQgDaICHyWe3Tuye5TMSmUjS1o 6Qxr5l0faIRc18FVnVTWur+nxzsBnbXzDoOKjDZzxUvXtqo39WCg9J9GF 7TL8h2Hu5YeXD+gPErhybN/mJIsR25tXhEkz+PHrtT+bDN3JAC7p25LXi vKjXtzq+NIRshzUGUQ5NWzy5rkamGpxId/WOU1p9Vy9lS8KN+jCnE6727 20ziw6YPpQGb6BmA9sE4Dvda466O/rl3RYRe0VeeuQrsiQlpI8t8PJ8gN AUS1ttYSdneEiCeONHDRZvuKnnN8W3cZvDtIhLk8w0so9/u6aMoqCNETc w==; X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="14858440" X-IronPort-AV: E=Sophos;i="6.06,188,1705392000"; d="scan'208";a="14858440" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 13:00:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,188,1705392000"; d="scan'208";a="7150405" Received: from josouza-mobl2.bz.intel.com ([10.87.243.88]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 13:00:14 -0800 From: =?utf-8?q?Jos=C3=A9_Roberto_de_Souza?= To: linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org Cc: Rodrigo Vivi , Mukesh Ojha , Johannes Berg , Jonathan Cavitt , =?utf-8?q?Jos=C3=A9_Roberto_de?= =?utf-8?q?_Souza?= Subject: [PATCH 1/4] devcoredump: Add dev_coredump_put() Date: Tue, 27 Feb 2024 13:00:05 -0800 Message-ID: <20240227210008.182904-1-jose.souza@intel.com> X-Mailer: git-send-email 2.44.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792087319804733261 X-GMAIL-MSGID: 1792087319804733261 This is useful for drivers that don't want to keep a coredump available after unloading. Otherwise, the coredump would only be removed after DEVCD_TIMEOUT seconds. Cc: Rodrigo Vivi Cc: Mukesh Ojha Cc: Johannes Berg Cc: Jonathan Cavitt Signed-off-by: José Roberto de Souza --- drivers/base/devcoredump.c | 22 ++++++++++++++++++++++ include/linux/devcoredump.h | 5 +++++ 2 files changed, 27 insertions(+) diff --git a/drivers/base/devcoredump.c b/drivers/base/devcoredump.c index 7e2d1f0d903a6..e96427411b87c 100644 --- a/drivers/base/devcoredump.c +++ b/drivers/base/devcoredump.c @@ -304,6 +304,28 @@ static ssize_t devcd_read_from_sgtable(char *buffer, loff_t offset, offset); } +/** + * dev_coredump_put - remove device coredump + * @dev: the struct device for the crashed device + * + * If giving device has a coredump this removes it from file system and free + * associated data otherwise does nothing. + * This is useful for drivers that don't want to keep a coredump + * available after unloading. + */ +void dev_coredump_put(struct device *dev) +{ + struct device *existing; + + existing = class_find_device(&devcd_class, NULL, dev, + devcd_match_failing); + if (existing) { + devcd_free(existing, NULL); + put_device(existing); + } +} +EXPORT_SYMBOL_GPL(dev_coredump_put); + /** * dev_coredumpm - create device coredump with read/free methods * @dev: the struct device for the crashed device diff --git a/include/linux/devcoredump.h b/include/linux/devcoredump.h index c008169ed2c6f..c8f7eb6cc1915 100644 --- a/include/linux/devcoredump.h +++ b/include/linux/devcoredump.h @@ -63,6 +63,8 @@ void dev_coredumpm(struct device *dev, struct module *owner, void dev_coredumpsg(struct device *dev, struct scatterlist *table, size_t datalen, gfp_t gfp); + +void dev_coredump_put(struct device *dev); #else static inline void dev_coredumpv(struct device *dev, void *data, size_t datalen, gfp_t gfp) @@ -85,6 +87,9 @@ static inline void dev_coredumpsg(struct device *dev, struct scatterlist *table, { _devcd_free_sgtable(table); } +static inline void dev_coredump_put(struct device *dev) +{ +} #endif /* CONFIG_DEV_COREDUMP */ #endif /* __DEVCOREDUMP_H */ From patchwork Tue Feb 27 21:00:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Souza, Jose" X-Patchwork-Id: 207428 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp2962062dyb; Tue, 27 Feb 2024 13:01:32 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX1o7YIO1Ucw/2kgS6fKIOMZpXYPuXMsJip9HXQxhZk9J+H+A4I68jGJ5i+8sLzbBRrBC+QTMhNVHPZiqW1g/y+sbk/mA== X-Google-Smtp-Source: AGHT+IFSnJg/jhDJ96p2RGComU1yGK9P/8An2/zOALwNEIEoOFrGhst4IdCfZnbir1AMWq/J+N/L X-Received: by 2002:a0c:aada:0:b0:68f:6013:7af7 with SMTP id g26-20020a0caada000000b0068f60137af7mr2819570qvb.57.1709067692405; Tue, 27 Feb 2024 13:01:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709067692; cv=pass; d=google.com; s=arc-20160816; b=qf1G82Iw+BhlVw7SCxyG+dbt2k8ys24iK+wTMTBQAb4g7jBkhv7B2m+2p3R2c1QFtz /opyLjPHOC6E5PmB7KKVrvhOSm0PW2y4lSyOp8n6M9Z4d6b6owuAwSBgbZvZ3US/hQAQ 1QVylYXhAWrY1TisrijjIyhgWgjmTnDyqOCBfTJjaYpDC1ZGJj12FPbxxNBgyrEwr2LV RFVpVwieuoBk9Lzc9fi29bXZEVaZD0msctb2ejg13flYigfEDx48jcLgAWkivB8lfc12 SgzKS0ufk+7REergOSYHRj4wPVYWk+yAsEc7d8sWkVsCljc6G6eN9L/lRvhR9S8UVYNA 3y/w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=OFH0Wtp5DuaTg4RM1LzWzss6ual4/ImD5JXfiun9ReQ=; fh=/aA3ikCzdHUoND1NkELyjjOlZC31bXhfya5LgPc2Wj8=; b=vltCByXwcS/RhYn1yWleuZOyVPGfTsFgTBMpAxiNYMn6VDpMYoL0/5QNYBTJ2Bl1yr nf5GNW4Wg+SJ5Aod1+SyuCGBymWBhV1POTY+2THCkRWRLNFxWrFo+oPeLEU71t5X3RNf QjoH7h1h6Ny5EvBY6TBLjg323oo9K5m23VoJ3Zdu8EnyzT11kDXV6b1Gi6ZqeIcvyOdg R+sNQkZAl2Qbfe1enGdw2alGFCm1qZGehtdE7zMySVsaPBwKctgbrSW5N43k3a2RTFDM kp1vdvrQ5iWvXuqf41Eoy3xKmaDoqChjGMETy/F1Onuip/8hUj0scPuE11BOl3E06QIW kqIw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VEspGJRd; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-84008-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84008-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id o6-20020a0562140e4600b0068f4a9f8150si8336363qvc.376.2024.02.27.13.01.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 13:01:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-84008-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VEspGJRd; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-84008-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84008-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E2DC61C25FC7 for ; Tue, 27 Feb 2024 21:01:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1258814F99C; Tue, 27 Feb 2024 21:00:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="VEspGJRd" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C6F914DFF6 for ; Tue, 27 Feb 2024 21:00:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709067621; cv=none; b=WW70G8QHdgTPDmS7v9HseX5n16SR4fXnLM1RUfmaUIyDC0OMX/kqCir5N+iug9dNUjftpyN/ABKoH359LadVKZ7Osw2KSI+aFZyWojrYcccFDvyZwKwVQEAl0JIlPDO6KMBh/KvzThZLFsLw0K7jDfpZ+bTkPmOyoUW1JVZ6oTY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709067621; c=relaxed/simple; bh=g5hSKz8PPuysfPZ2UMVY6d54ATC/Id6iUngulkNyu8w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=b5qs2QgJZpOY6RVcQDiOx6saHox4vCmfOnoxQXRhmGyTn54IKFC10mHgA3wIToYbcagIaB8MYn3DwYxI63dUuk6E12RMkXPjSfGT+jf+saAxsw4O+JzvhEttwRyMRSfUFKHAUowNWGpbxw7woujaysVo4/qVE3xprzSY3Tpf7tU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=VEspGJRd; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709067620; x=1740603620; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=g5hSKz8PPuysfPZ2UMVY6d54ATC/Id6iUngulkNyu8w=; b=VEspGJRd7t8nQYINgeb6iZGx8NTPivmeK7KBTc6F/BZyA9WWSKrPr8fN F6HH0um1kj6wWlHtBar55BLkno2X7EfV3k3SPQe6nQ0BQh9L2X4DTFGsC T80VdzZTSDyhfPBHhp171ZeI88GZO4twNV5iPdeAiUXKui+rvP/2KJa/s jow8eObI2HmtCWrugfZZ9icnK2UoMMYanhAYgQFqL5Vzf//wVHoakZ/dd tmoQkhICypcpQGqOQuVlXa5/M51IVXubFQ+PyWSMyy/FZQsyEBJHwwV5m wdqxUOgm+M/xUD7rgr/cT89V6D0u/JTiTAIIj+sHPSpT84NPLMu7iCrw+ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="14858445" X-IronPort-AV: E=Sophos;i="6.06,188,1705392000"; d="scan'208";a="14858445" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 13:00:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,188,1705392000"; d="scan'208";a="7150417" Received: from josouza-mobl2.bz.intel.com ([10.87.243.88]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 13:00:17 -0800 From: =?utf-8?q?Jos=C3=A9_Roberto_de_Souza?= To: linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org Cc: Rodrigo Vivi , Mukesh Ojha , Johannes Berg , Jonathan Cavitt , =?utf-8?q?Jos=C3=A9_Roberto_de?= =?utf-8?q?_Souza?= Subject: [PATCH 2/4] devcoredump: Add dev_coredump_timeout_set() Date: Tue, 27 Feb 2024 13:00:06 -0800 Message-ID: <20240227210008.182904-2-jose.souza@intel.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240227210008.182904-1-jose.souza@intel.com> References: <20240227210008.182904-1-jose.souza@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792087364446078309 X-GMAIL-MSGID: 1792087364446078309 Add function to set a custom coredump timeout. Current 5-minute timeout may be too short for users to search and understand what needs to be done to capture coredump to report bugs. Cc: Rodrigo Vivi Cc: Mukesh Ojha Cc: Johannes Berg Cc: Jonathan Cavitt Signed-off-by: José Roberto de Souza --- drivers/base/devcoredump.c | 23 +++++++++++++++++++++++ include/linux/devcoredump.h | 6 ++++++ 2 files changed, 29 insertions(+) diff --git a/drivers/base/devcoredump.c b/drivers/base/devcoredump.c index e96427411b87c..2857ceb3eb3aa 100644 --- a/drivers/base/devcoredump.c +++ b/drivers/base/devcoredump.c @@ -326,6 +326,29 @@ void dev_coredump_put(struct device *dev) } EXPORT_SYMBOL_GPL(dev_coredump_put); +/** + * dev_coredump_timeout_set - set coredump timeout + * @dev: the struct device for the crashed device + * @secs_timeout: new timeout in seconds + * + * If giving device has a coredump this sets a new timeout for coredump. + */ +void dev_coredump_timeout_set(struct device *dev, unsigned long secs_timeout) +{ + struct device *existing; + struct devcd_entry *devcd; + + existing = class_find_device(&devcd_class, NULL, dev, + devcd_match_failing); + if (!existing) + return; + + devcd = dev_to_devcd(existing); + mod_delayed_work(system_wq, &devcd->del_wk, HZ * secs_timeout); + put_device(existing); +} +EXPORT_SYMBOL_GPL(dev_coredump_timeout_set); + /** * dev_coredumpm - create device coredump with read/free methods * @dev: the struct device for the crashed device diff --git a/include/linux/devcoredump.h b/include/linux/devcoredump.h index c8f7eb6cc1915..70fe72a5c6d36 100644 --- a/include/linux/devcoredump.h +++ b/include/linux/devcoredump.h @@ -65,6 +65,7 @@ void dev_coredumpsg(struct device *dev, struct scatterlist *table, size_t datalen, gfp_t gfp); void dev_coredump_put(struct device *dev); +void dev_coredump_timeout_set(struct device *dev, unsigned long secs_timeout); #else static inline void dev_coredumpv(struct device *dev, void *data, size_t datalen, gfp_t gfp) @@ -90,6 +91,11 @@ static inline void dev_coredumpsg(struct device *dev, struct scatterlist *table, static inline void dev_coredump_put(struct device *dev) { } + +static inline void dev_coredump_timeout_set(struct device *dev, + unsigned long secs_timeout) +{ +} #endif /* CONFIG_DEV_COREDUMP */ #endif /* __DEVCOREDUMP_H */ From patchwork Tue Feb 27 21:00:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Souza, Jose" X-Patchwork-Id: 207429 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp2962108dyb; Tue, 27 Feb 2024 13:01:36 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXT9tUvxuGwgm/VndOSgNkz8/GgyCplQfO3x5Zqlss/HYQZTmOdECtB9I20XPMaqtel7I15B52V+4Qo5cMyzE4kq+sGoQ== X-Google-Smtp-Source: AGHT+IGjsK9/DI0s0HwePXRO9lXBemwFi9wggRQytg1LZS2iIz6JMWNYSMHnc03wGey5AufYJxpF X-Received: by 2002:a05:622a:13c7:b0:42e:821b:f23c with SMTP id p7-20020a05622a13c700b0042e821bf23cmr8364989qtk.8.1709067696137; Tue, 27 Feb 2024 13:01:36 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709067696; cv=pass; d=google.com; s=arc-20160816; b=o5DNypSOe74c5cq3YrFdCt0JLCascKKajcwd63jbkWs9zuDfidyguiKEbdU7h9WMBG ItPQR3eGSNpcKbl4crSY512+jaVbxLWDXNSvHxddRcmDBYWK5eLMEuFfKtk4xH+uMnZX kda4rsAN+p6S45i2Dv3WDFCDbIlN0z9FWf8dZPwfstxxfW1qQDzbNrY5l3fAgEvOeEge gNGOVm3/xeXNZmLAv1soq+BwjcJJgR/OBj2G0usI/R6RKCNs80bjYpVY9ptI7uK97DZn PwUdPLjKA1VprjSPa4V6a1nISdYPyX4NRETLpfAnOIqfMCPDpcwGcf2NgGj3OKER0p9Z X31g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=HTZrsEZ92DTeO98d3walMogWqIvXqs2eT6HtyYaQ5PY=; fh=iWkGsoy7TPTmscZDaNwAhCaNzZd4htfetWN3qPRQ3vU=; b=TYIs1NBqHKNbRleHw4OUUuexp+VquIz+ErE7Ak9Y+6dNGHUJFORSd+fFN/Lf7bNECv 2sk6k/G4EuC9TxDqMSLbTjfV8pZbo9l0dbMqHh1A6JNmrFL8AwRwktvf+mdRTEouTIwG G+QiP0ZwUsfuyAsy16OAgK4jARAS0IB8YbwWc9Kx7vucnCr+JfdIaz8ZM0qrk5pC02BA fkL6t84a51Br+S8Uw7qkmX/XwMQ1o9nb5ccLoC5cgPdigTJkYS4Kx9XaMzdDBW84I11C x26fM3SkzmZ7HcIRzuYOTRrHC91YE2K08XBLcv+KW8xMfU/iVvBxYjt0Pv+Vx3373+00 1iiw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FNWniD1z; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-84009-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84009-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id u3-20020ac858c3000000b0042c43fc863esi8884041qta.574.2024.02.27.13.01.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 13:01:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-84009-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=FNWniD1z; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-84009-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84009-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3BE1E1C2410E for ; Tue, 27 Feb 2024 21:01:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D67E714DFF6; Tue, 27 Feb 2024 21:00:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="FNWniD1z" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A93E314E2CB for ; Tue, 27 Feb 2024 21:00:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709067622; cv=none; b=fOVk70fzi3JVp5SAGpnhyafqOvMROd81LkU/TUUTPLplhduPE39UBIqQQn2f/G26x6E0HBAJFDNXsV9ctcT5R/byDL3+E0G7zGNQxiadr2+YATKgMutyMM6QAjp5KadVXnHYpi3DyKT0yjevqcIG+X5cP/3ZXa5i4NdJAU0OSak= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709067622; c=relaxed/simple; bh=AIkMM1NMy91FDgmfFFaJ0HxHDsRelsqEiKUcFIg+iw8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=vEY6m4H5vngLIJAmFIl5YDopt2LxVNAGQ/4ZWCKdnqCFqJODIdtuqAVizHO3SdPggU+mXmf7gQdNmlf0etT8HbzFgr0uYoinKAF0MGTwrXHzkwtIAxrXeXa/0ynWk8GKXpCBpZqT2mCdRtKJfkKIbp78edBkiYvD7yLutk1BTCc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=FNWniD1z; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709067621; x=1740603621; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=AIkMM1NMy91FDgmfFFaJ0HxHDsRelsqEiKUcFIg+iw8=; b=FNWniD1zrr9PoKOCcGiMrAj2+KWZxw26DhT1sCDcBpk1XLKobm7brJhV 3+AryNna8+FNQaKdowZN+ucUXMUPk9ldGBt127k7WLu+0uMi7TPOzVTEM ZZUeZY8+V8LHBl+x94LbvW7aqCrzWx/MKYa6K9LV1dIRbMZWINU5Mr4zY PuMlJs1svdmB7waivjv8BwTlIqSS55WC3Jb0x1UXink0zXcge3Pd6Xrbt fu2AAE8UWrrI3qnUSn/dD/ew+EWfKMQzZ7OefaPeKA9ipSroQ8yFKEIZq 4/13L78axYeqJmZGYlnteq0I4JRE7N3eHIzuDowEWhzsqdKiFPvlBVD9U g==; X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="14858450" X-IronPort-AV: E=Sophos;i="6.06,188,1705392000"; d="scan'208";a="14858450" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 13:00:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,188,1705392000"; d="scan'208";a="7150425" Received: from josouza-mobl2.bz.intel.com ([10.87.243.88]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 13:00:19 -0800 From: =?utf-8?q?Jos=C3=A9_Roberto_de_Souza?= To: linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org Cc: Rodrigo Vivi , Jonathan Cavitt , =?utf-8?q?Jos=C3=A9_Roberto_de?= =?utf-8?q?_Souza?= Subject: [PATCH 3/4] drm/xe: Remove devcoredump during driver release Date: Tue, 27 Feb 2024 13:00:07 -0800 Message-ID: <20240227210008.182904-3-jose.souza@intel.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240227210008.182904-1-jose.souza@intel.com> References: <20240227210008.182904-1-jose.souza@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792087368123901940 X-GMAIL-MSGID: 1792087368123901940 This will remove devcoredump from file system and free its resources during driver unload. This fix the driver unload after gpu hang happened, otherwise this it would report that Xe KMD is still in use and it would leave the kernel in a state that Xe KMD can't be unload without a reboot. Cc: Rodrigo Vivi Cc: Jonathan Cavitt Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/xe/xe_devcoredump.c | 13 ++++++++++++- drivers/gpu/drm/xe/xe_devcoredump.h | 5 +++++ drivers/gpu/drm/xe/xe_device.c | 4 ++++ 3 files changed, 21 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c b/drivers/gpu/drm/xe/xe_devcoredump.c index 68d3d623a05bf..3fef81396fe8a 100644 --- a/drivers/gpu/drm/xe/xe_devcoredump.c +++ b/drivers/gpu/drm/xe/xe_devcoredump.c @@ -9,6 +9,8 @@ #include #include +#include + #include "xe_device.h" #include "xe_exec_queue.h" #include "xe_force_wake.h" @@ -231,5 +233,14 @@ void xe_devcoredump(struct xe_sched_job *job) dev_coredumpm(xe->drm.dev, THIS_MODULE, coredump, 0, GFP_KERNEL, xe_devcoredump_read, xe_devcoredump_free); } -#endif +static void xe_driver_devcoredump_fini(struct drm_device *drm, void *arg) +{ + dev_coredump_put(drm->dev); +} + +int xe_devcoredump_init(struct xe_device *xe) +{ + return drmm_add_action_or_reset(&xe->drm, xe_driver_devcoredump_fini, xe); +} +#endif diff --git a/drivers/gpu/drm/xe/xe_devcoredump.h b/drivers/gpu/drm/xe/xe_devcoredump.h index df8671f0b5eb2..9eba67f37234f 100644 --- a/drivers/gpu/drm/xe/xe_devcoredump.h +++ b/drivers/gpu/drm/xe/xe_devcoredump.h @@ -11,10 +11,15 @@ struct xe_sched_job; #ifdef CONFIG_DEV_COREDUMP void xe_devcoredump(struct xe_sched_job *job); +int xe_devcoredump_init(struct xe_device *xe); #else static inline void xe_devcoredump(struct xe_sched_job *job) { } +static inline int xe_devcoredump_init(struct xe_device *xe) +{ + return 0; +} #endif #endif diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c index 919ad88f0495a..22be76537c7da 100644 --- a/drivers/gpu/drm/xe/xe_device.c +++ b/drivers/gpu/drm/xe/xe_device.c @@ -20,6 +20,7 @@ #include "regs/xe_regs.h" #include "xe_bo.h" #include "xe_debugfs.h" +#include "xe_devcoredump.h" #include "xe_dma_buf.h" #include "xe_drm_client.h" #include "xe_drv.h" @@ -502,6 +503,9 @@ int xe_device_probe(struct xe_device *xe) return err; } + err = xe_devcoredump_init(xe); + if (err) + return err; err = drmm_add_action_or_reset(&xe->drm, xe_driver_flr_fini, xe); if (err) return err; From patchwork Tue Feb 27 21:00:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Souza, Jose" X-Patchwork-Id: 207430 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp2962135dyb; Tue, 27 Feb 2024 13:01:37 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXhJAOrmUVskUw9YMUIXFJ05P+El9kEffEHTlwsTRHYtcmJxrO2WvoZakzE6j+d4UR0bvCMar2zD0MPd8TkWcibAsNyaA== X-Google-Smtp-Source: AGHT+IG/0hW798SPeGwiDqjQJQHTYLw7Oyc7kZ/q2X0f7uSMn/DMK0CEBPAk2puqDx1FETVHRbUo X-Received: by 2002:a05:6602:179a:b0:7c4:831d:32e with SMTP id y26-20020a056602179a00b007c4831d032emr417543iox.0.1709067697468; Tue, 27 Feb 2024 13:01:37 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709067697; cv=pass; d=google.com; s=arc-20160816; b=AlLnikBDuT2fr3oEUZh/rMaTUTcKuzQE50iNjmuPe+8qn1AHrGuRHwTnf/N8oe8mOD 3XcBlrLaTGzsDq+cYnq7lQtQhPXHjVVDSiohs+4r0FNaktry4dqSq90oKD7vMwhzcMC4 CjwosgwUuyYXkC5v1FVA5v1EDYcnlZGFItBLGwpTwZME6Pwc64leVZkii6+O3JiiRWIl AAVDsk8IawzmSBpkJgNQn21DY2vivJQaUj16TQhgN7n3XjqQrS/odUniRbeF3d22sytz cC3+W3QgSlnmQCqYDreS0ZyTQjthMrbIXslpRi6xIPrvCRV1TIKkFpIHx2Jn/IKNtxjl GCkQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=KhJKt7ifMXPaNWtBSb7KOeBwNaWZrhLFEKD+ppm4vNU=; fh=iWkGsoy7TPTmscZDaNwAhCaNzZd4htfetWN3qPRQ3vU=; b=Q0D3OINRhgis+zLoplPc+LdNcVgy3DD0LSp55SSD6POQNrRjioEMeYqW3878Jbh7Zh EnPdvx5U44v9DWc7qEtkOn7Hg6CquHWUkBgAerFn9dQC/uRcRZjWKyft2kFEuAkd9WBW er6vtoV/RytBEANs+G/opzs3P1qBd+SPNTvu7DElpZ2vjJV8FypoUSFK1xqUCP1X5IMM CMZR95a5hSERxqiC8zAcMmthjFp29bY8VK7UuzAHMtJV0y3PPd39ff24a1HGnKysUdy/ nz8AJo1dlr5QqkZ2eR8CmEoPbWE1SstkqOXZo5TVVy58S5JTCeqBdDuMbWCz4IQJNncL rA0Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Nq8Lvhx+; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-84010-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84010-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id o3-20020a5eda43000000b007c7f2c16a3esi298799iop.8.2024.02.27.13.01.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 13:01:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-84010-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Nq8Lvhx+; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-84010-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-84010-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 066BC283427 for ; Tue, 27 Feb 2024 21:01:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AE01F151CD7; Tue, 27 Feb 2024 21:00:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Nq8Lvhx+" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5666B14EFFB for ; Tue, 27 Feb 2024 21:00:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709067624; cv=none; b=bfMOPm6IG74V9FkqgJ/yn8u0bwk+vVWe5uUC+fi0FJ3isZ2mlAOMN2nOg8fl7isfOaG2eN9W+hI4Vw/iAXKy4rZOEX9HJ+0hQipjeDWjrPfUC9pjPaF1yH0ZZS7q0D3HDNykwu8N6g2KJZ5/wy91MnJ2b6JW3TEmq1pq7dftf1Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709067624; c=relaxed/simple; bh=z/MCmD6qL+G1CmdcEq1CJWDPJ27NcmLHmOhrVHtt/R0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=osDvV7a7yU2dzMVMA5IOtmrOrKdssRxI2bQZVySKOglZVCSb+n7fjyRiuno5xkL1iMDPUeHaitpVjnJ0fgGdPgZHMjBAv+rDJNh42m9VxSgdxac5XPEMatRewdZwDvnlTwruMUiKOlRBfHiY3ZtAwpQATX2RQvdgEH3KpVYv3mE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Nq8Lvhx+; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709067622; x=1740603622; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=z/MCmD6qL+G1CmdcEq1CJWDPJ27NcmLHmOhrVHtt/R0=; b=Nq8Lvhx+bV03yDJfDKvjyxktDLpJEYhg1ua3egK21f71ojTnVVsq4tB/ 17hBm1Pu0LLUYlv21lOeAxaDPa51O+15XkhkFq+fblbIGphBN+K130jI4 xAEGCAKC0YDwXhijye3PwJEgot8/Z0JhgbgwyszHYSCBJjJrV4vIv9Gyf C4X7tyWnvK57GjZDfZIk5z99jmxMT1L5ogkotSIF4tXgsr5G0QClEQeSl AYWobGW9w6/DdLasaOxle6encDpqYM85dy3KQlBXlB8sr6+hW1d59nVNG +u5vXjJgyyodMfiiGZzPSgE8qgZcqTxYscqfKnOoRLgJaEwjX8mc6dubJ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="14858452" X-IronPort-AV: E=Sophos;i="6.06,188,1705392000"; d="scan'208";a="14858452" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 13:00:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,188,1705392000"; d="scan'208";a="7150434" Received: from josouza-mobl2.bz.intel.com ([10.87.243.88]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 13:00:20 -0800 From: =?utf-8?q?Jos=C3=A9_Roberto_de_Souza?= To: linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org Cc: Rodrigo Vivi , Jonathan Cavitt , =?utf-8?q?Jos=C3=A9_Roberto_de?= =?utf-8?q?_Souza?= Subject: [PATCH 4/4] drm/xe: Increase devcoredump timeout Date: Tue, 27 Feb 2024 13:00:08 -0800 Message-ID: <20240227210008.182904-4-jose.souza@intel.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240227210008.182904-1-jose.souza@intel.com> References: <20240227210008.182904-1-jose.souza@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792087370005220079 X-GMAIL-MSGID: 1792087370005220079 5 minutes is too short for a regular user to search and understand what he needs to do to report capture devcoredump and report a bug to us, so here increasing this timeout to 1 hour. Cc: Rodrigo Vivi Cc: Jonathan Cavitt Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/xe/xe_devcoredump.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/xe/xe_devcoredump.c b/drivers/gpu/drm/xe/xe_devcoredump.c index 3fef81396fe8a..f1a8ccbed7f13 100644 --- a/drivers/gpu/drm/xe/xe_devcoredump.c +++ b/drivers/gpu/drm/xe/xe_devcoredump.c @@ -52,6 +52,8 @@ #ifdef CONFIG_DEV_COREDUMP +#define XE_COREDUMP_TIMEOUT_SECS (60 * 60) + static struct xe_device *coredump_to_xe(const struct xe_devcoredump *coredump) { return container_of(coredump, struct xe_device, devcoredump); @@ -232,6 +234,7 @@ void xe_devcoredump(struct xe_sched_job *job) dev_coredumpm(xe->drm.dev, THIS_MODULE, coredump, 0, GFP_KERNEL, xe_devcoredump_read, xe_devcoredump_free); + dev_coredump_timeout_set(xe->drm.dev, XE_COREDUMP_TIMEOUT_SECS); } static void xe_driver_devcoredump_fini(struct drm_device *drm, void *arg)