From patchwork Tue Feb 27 17:21:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 207361 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp2861059dyb; Tue, 27 Feb 2024 09:52:26 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCVnXmloQYa+zqBG2LLqjaHrpyVuEBJo6+nSs52/aZMifVxCbvGq44djQovNE8Gzdj8fT3z6bZ7YJMbi3PB5U5L5FukpJA== X-Google-Smtp-Source: AGHT+IH7zbEOIt0p4EeUccq1QAldBLf7iwRJoDtM5WzO65MTitfLHkPppAqQy8bD+te4jA3rm85+ X-Received: by 2002:a05:6a20:d80f:b0:19e:6ea7:dfb with SMTP id iv15-20020a056a20d80f00b0019e6ea70dfbmr66121pzb.28.1709056345884; Tue, 27 Feb 2024 09:52:25 -0800 (PST) Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id g4-20020a632004000000b005dc75bb7b73si5755034pgg.875.2024.02.27.09.52.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 09:52:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-83691-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linutronix.de header.s=2020 header.b="iksg/yK+"; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=9acEZk+u; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-83691-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83691-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 5CB8CB25D50 for ; Tue, 27 Feb 2024 17:22:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0D48C4C63D; Tue, 27 Feb 2024 17:21:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="iksg/yK+"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="9acEZk+u" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA4612836D; Tue, 27 Feb 2024 17:21:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709054510; cv=none; b=UAbRbeYqhgMqrTIcKaLKa/+yTvuyAZhwqBognxOWtz3qkbuKQcAVBmWvLeFTJLXNJT41I9Qvoc3+uxlLPETrZSSgGb5EgnUGOQD2jHC1VcXi7RCCrFjgHKtCiWpU3rb+t7riNVnR50hnoQI6fRxoN1TLH2npiWRmxxz3lj4g8Dg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709054510; c=relaxed/simple; bh=A1cMB+TPPPLwcjr1NhHzuL5MkmL/S48pr898cP86taM=; h=Date:From:To:Subject:Cc:In-Reply-To:References:MIME-Version: Message-ID:Content-Type; b=iQs/mWkcEps5mjBqjbOcKYJ/sFGM0EtQsiP9olwH5yfEJnkPAvVU5dtkSWGQVNGra6AD3BJa9dGZZ3Kyyi5iIRk3xxyh2IQd4gC7FnQAJe64OlMzKlRq3sfzERyip9odvPKgsbpkfDUROrB/bwAy/dTVNJbrOlrFPPcrrC7rk7M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=iksg/yK+; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=9acEZk+u; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Date: Tue, 27 Feb 2024 17:21:46 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1709054507; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vFoal968ggd6tjH8ED7KKl31UD4EYrF7TaI8Zw+iGIM=; b=iksg/yK+FPKFBHiJwwc+jvOOeTGj/CNpEcIowg/BjifeaDA1xhEvk5TNHXbcVhz079tN8I MEUe7hhIENgGlykv+sAoNKJTXTcPu9Iqzka19GCZgQ+a1BS2dfvkTGKB3bhLqjGloL1G0N fskj+OjxSeWQLIeZTtfio5Nhz9gH4xP8Kejc9+r42T7q1i+vIzKJ6332OqsKW64/9niLsF Zieo2ZdFl6er8AYt70/ywD/NCxzSYBK0zKb6RmEpLpHBa8o05UqkalUEFjWSwGI1rRmatZ pp1b4OzWDlhVY47SbAOKQX+161Wy1UIss3MyzfTKK7Cl+hBQiifEbaxZUNWZ+Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1709054507; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vFoal968ggd6tjH8ED7KKl31UD4EYrF7TaI8Zw+iGIM=; b=9acEZk+uIwwG/YMTEQoVutyvklY5TzYUbU0J226I99pSphlBCdn+ca2iL8FEW/GamfKfgT t3GJKswMEGEF+gAg== From: tip-bot2 for Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: irq/core] irqchip/ts4800: Convert to platform_driver::remove_new() callback Cc: u.kleine-koenig@pengutronix.de, Thomas Gleixner , x86@kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org In-Reply-To: =?utf-8?q?=3C0bdce86b50e5aa50cffbc4add332cbfbad87521e=2E1703284?= =?utf-8?q?359=2Egit=2Eu=2Ekleine-koenig=40pengutronix=2Ede=3E?= References: =?utf-8?q?=3C0bdce86b50e5aa50cffbc4add332cbfbad87521e=2E17032843?= =?utf-8?q?59=2Egit=2Eu=2Ekleine-koenig=40pengutronix=2Ede=3E?= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <170905450603.398.11750562948344568900.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792075466950246624 X-GMAIL-MSGID: 1792075466950246624 The following commit has been merged into the irq/core branch of tip: Commit-ID: f7f56d59a3923e95bad2c49615a4d7313ed78314 Gitweb: https://git.kernel.org/tip/f7f56d59a3923e95bad2c49615a4d7313ed78314 Author: Uwe Kleine-König AuthorDate: Fri, 22 Dec 2023 23:50:44 +01:00 Committer: Thomas Gleixner CommitterDate: Tue, 27 Feb 2024 18:12:11 +01:00 irqchip/ts4800: Convert to platform_driver::remove_new() callback The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Signed-off-by: Thomas Gleixner Link: https://lore.kernel.org/r/0bdce86b50e5aa50cffbc4add332cbfbad87521e.1703284359.git.u.kleine-koenig@pengutronix.de --- drivers/irqchip/irq-ts4800.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/irqchip/irq-ts4800.c b/drivers/irqchip/irq-ts4800.c index b2d61d4..57f610d 100644 --- a/drivers/irqchip/irq-ts4800.c +++ b/drivers/irqchip/irq-ts4800.c @@ -139,13 +139,11 @@ static int ts4800_ic_probe(struct platform_device *pdev) return 0; } -static int ts4800_ic_remove(struct platform_device *pdev) +static void ts4800_ic_remove(struct platform_device *pdev) { struct ts4800_irq_data *data = platform_get_drvdata(pdev); irq_domain_remove(data->domain); - - return 0; } static const struct of_device_id ts4800_ic_of_match[] = { @@ -155,11 +153,11 @@ static const struct of_device_id ts4800_ic_of_match[] = { MODULE_DEVICE_TABLE(of, ts4800_ic_of_match); static struct platform_driver ts4800_ic_driver = { - .probe = ts4800_ic_probe, - .remove = ts4800_ic_remove, + .probe = ts4800_ic_probe, + .remove_new = ts4800_ic_remove, .driver = { - .name = "ts4800-irqc", - .of_match_table = ts4800_ic_of_match, + .name = "ts4800-irqc", + .of_match_table = ts4800_ic_of_match, }, }; module_platform_driver(ts4800_ic_driver);