From patchwork Tue Feb 27 17:21:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: tip-bot2 for Thomas Gleixner X-Patchwork-Id: 207333 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp2845607dyb; Tue, 27 Feb 2024 09:24:10 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWsugeMOeabYqdIwaMpxvi44phSUtyoJuSnImtoavuIneIhPmRH1xYpe3krjep31e21kcH/TVz39PKbwZMS/jv7yB4YGg== X-Google-Smtp-Source: AGHT+IFMWQ4+RLsB7y1T+AWYBB9EiDRnH8tIxxWnx0DeGoR0s3uINXPx+Am/sNZF/AIm/0cmqC6P X-Received: by 2002:a17:902:9a43:b0:1dc:4b04:13d4 with SMTP id x3-20020a1709029a4300b001dc4b0413d4mr8425418plv.8.1709054650687; Tue, 27 Feb 2024 09:24:10 -0800 (PST) Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id u3-20020a170902e5c300b001d8a9162f22si1706986plf.60.2024.02.27.09.24.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Feb 2024 09:24:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-83694-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linutronix.de header.s=2020 header.b=tIQ7pkv5; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-83694-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-83694-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 66A1528173E for ; Tue, 27 Feb 2024 17:23:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AA86B4CB20; Tue, 27 Feb 2024 17:21:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="tIQ7pkv5"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="69Zp3hJd" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A01E4DA0C; Tue, 27 Feb 2024 17:21:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709054513; cv=none; b=QuEcwXyfteGxmcg/HNulmel3UgmqJPQ26V4bRC07jVXxzImtMf9eijqLqtivbVOaI1ACSR9cFb+49mgaCCsy99/g+zM1zgnlDxjEMj4DDzUijwUV7T6SXgEQq+VM72oMs6ya2ihPuV50ZhL887UHGSmRjfvEfE/EZP8m7ECy36A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709054513; c=relaxed/simple; bh=ZDMZNMBVmcOnabX2LLDwj241TDa566ufyAI1yq1DIS4=; h=Date:From:To:Subject:Cc:In-Reply-To:References:MIME-Version: Message-ID:Content-Type; b=LuOBFVDoUEHrdXjBCb2lEinNdD5Vo55DdT2NIK5uVU3VHv0l2UySyPeM7bnFfXdmSeADLrhLIIQuNmchzamC+XzolEVbJ3JH9rGWqNZKSZhGzzZxC2JhHVM325OBW/Pi3ozL7+rkwK3RTcz8q36wusGEVIl72kCm2bMsM7RwjJk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=tIQ7pkv5; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=69Zp3hJd; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Date: Tue, 27 Feb 2024 17:21:48 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1709054509; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wm06dIdSkYXtx36LEbu12p51mk8dC/UVyDnkHCaLm7E=; b=tIQ7pkv59P2VZPqj6zz9QtMsWZWpNMnx6qqDcqUlRTLFmiE7wZa54BLwxoIZfTmwK11RnO WamwF8yXldjRIpIED/d7Vk4o2/0fzVN3qvQrqQHY898gtFcXRbq+smk2iK91UG/ZcKnnkO 4IIRf1lPQy5oXxdZUVkPJdvS1np4DZWiXHa/ihaIE5RebDwgV1wuLuvxSYt5nMqky02M8o egcUTrSGx0Mc9fwXvNdHb0fypLeXdk7LaGaTT8VJb1bdIuAWEJE+1ZxvdnQ8UjP97gTBZu +EndX8AKJ6fZxtGG0gDo3gLf+eLEAIiiZSE+kNGX4zC/L/dB7hZu8GOXW0afPw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1709054509; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wm06dIdSkYXtx36LEbu12p51mk8dC/UVyDnkHCaLm7E=; b=69Zp3hJdKgwZ5uObTZzY6d46lBBF3oPsmtpJVX7UILrU1C9rg6W2ytLF3YnfJy8gBp7Dnl DPlozZ3TN0v1ZpBQ== From: tip-bot2 for Uwe =?utf-8?q?Kleine-K=C3=B6nig?= Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: irq/core] irqchip/renesas-irqc: Convert to platform_driver::remove_new() callback Cc: u.kleine-koenig@pengutronix.de, Thomas Gleixner , x86@kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org In-Reply-To: =?utf-8?q?=3C2d367ab738ed2e4cf58cffc10d64b0cbe8a1322c=2E1703284?= =?utf-8?q?359=2Egit=2Eu=2Ekleine-koenig=40pengutronix=2Ede=3E?= References: =?utf-8?q?=3C2d367ab738ed2e4cf58cffc10d64b0cbe8a1322c=2E17032843?= =?utf-8?q?59=2Egit=2Eu=2Ekleine-koenig=40pengutronix=2Ede=3E?= Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <170905450886.398.7426592820378676052.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Precedence: bulk X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792073689397075872 X-GMAIL-MSGID: 1792073689397075872 The following commit has been merged into the irq/core branch of tip: Commit-ID: 127806dc0b2aacd4355a977a6d8ba5cc6d64f55e Gitweb: https://git.kernel.org/tip/127806dc0b2aacd4355a977a6d8ba5cc6d64f55e Author: Uwe Kleine-König AuthorDate: Fri, 22 Dec 2023 23:50:41 +01:00 Committer: Thomas Gleixner CommitterDate: Tue, 27 Feb 2024 18:12:10 +01:00 irqchip/renesas-irqc: Convert to platform_driver::remove_new() callback The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Signed-off-by: Thomas Gleixner Link: https://lore.kernel.org/r/2d367ab738ed2e4cf58cffc10d64b0cbe8a1322c.1703284359.git.u.kleine-koenig@pengutronix.de --- drivers/irqchip/irq-renesas-irqc.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/irqchip/irq-renesas-irqc.c b/drivers/irqchip/irq-renesas-irqc.c index 49b446b..76026e0 100644 --- a/drivers/irqchip/irq-renesas-irqc.c +++ b/drivers/irqchip/irq-renesas-irqc.c @@ -218,14 +218,13 @@ err_runtime_pm_disable: return ret; } -static int irqc_remove(struct platform_device *pdev) +static void irqc_remove(struct platform_device *pdev) { struct irqc_priv *p = platform_get_drvdata(pdev); irq_domain_remove(p->irq_domain); pm_runtime_put(&pdev->dev); pm_runtime_disable(&pdev->dev); - return 0; } static int __maybe_unused irqc_suspend(struct device *dev) @@ -248,11 +247,11 @@ MODULE_DEVICE_TABLE(of, irqc_dt_ids); static struct platform_driver irqc_device_driver = { .probe = irqc_probe, - .remove = irqc_remove, + .remove_new = irqc_remove, .driver = { - .name = "renesas_irqc", + .name = "renesas_irqc", .of_match_table = irqc_dt_ids, - .pm = &irqc_pm_ops, + .pm = &irqc_pm_ops, } };