From patchwork Tue Feb 27 03:00:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengming Zhou X-Patchwork-Id: 207014 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp2460610dyb; Mon, 26 Feb 2024 19:01:19 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUa4ljmzwkzdd3jyXUQaTt71nAnZ/S+lrF9c0zGt5AzgmlAxUW4ciJXxHfQfn4oc8KUxe4pEztErXMzNCdxQCUug5o6yQ== X-Google-Smtp-Source: AGHT+IEE4B929ehRdq1mPqYDRFFbLstDZ3EQNyC9Z27DiWw+STi8VMoCVxkU5JrQJLaGsVFWZhhu X-Received: by 2002:a17:906:bc90:b0:a43:4fd4:fad4 with SMTP id lv16-20020a170906bc9000b00a434fd4fad4mr2900392ejb.19.1709002879130; Mon, 26 Feb 2024 19:01:19 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709002879; cv=pass; d=google.com; s=arc-20160816; b=rLBiw8SDFSozjGRZdE5aoHXF3HMFwZR7LZNYDZzgDzaM9IbkCEUNz9oGgaeIWWLRbZ XKTKj9rDjkuFpO/I2QNCQ4B9sHrQgxEEO4wNXxtZdgLCyaZ7+p+gg+v04a9sjZuQGAy9 Ef6fCPXVIyEFKy6STfvzD+6TkCiw99Cs38WjPCDRspLzrfg3pezcuETbBIJpbelnniCo 0uKCEf3OZhmRPFtgli2S4EMxyTr/ogyBo50IB7j1NWAYivy5nxkXXG5949zhz9iGPL/b H6RDuNY/ER5iNn1UaWqRZJ/T4uOW5tZ5Yq9dMAmLDkIii7EP8a+hIOjeSftEy6HGjfni UNzw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=xeQWaahmZnWCMBq0OUjMZaQ1ukelciifHqNoME1DLpU=; fh=MvnYU86P+iMSyLcmBXx0cDXUnypuovYg9HpRrVsjIRI=; b=TJXo+p+G2XWbgkyMslhMQMIe+hySs63ds8VvaHHuOPZSARXaOxYPa5SCJJf+DJfN3c lBXtZ1fXW3l5vsFwnPSz8xwF+OGUZPl4q7gCodtTkX73quicF0cnnUYnxAXJ0ZG3YGW6 DA4OanFQ0Zx16BSYZ5v1tv8vsBMcqkxHl0FW3CWIwDty0pZhRplpGCqfTk1rOfLrIakP ZMPfsWdJuwyGX0/KXFC3PcLglL8VzI6gdTfhiUpQ2Q4YMLg1IA0b+UWwuWyWe+w0ip57 V1qpuV0wuGenKXiLkspyFpofJsvbav7/qYBqgfmahTJh6R54T1Ns+SYegN99xt4PbYmN 8VYA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=rdcCuWxN; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-82633-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82633-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id gs34-20020a1709072d2200b00a43af6a8b85si135349ejc.428.2024.02.26.19.01.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 19:01:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-82633-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=rdcCuWxN; arc=pass (i=1 spf=pass spfdomain=linux.dev dkim=pass dkdomain=linux.dev dmarc=pass fromdomain=linux.dev); spf=pass (google.com: domain of linux-kernel+bounces-82633-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82633-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B9EF01F23158 for ; Tue, 27 Feb 2024 03:01:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C6FE81CAAE; Tue, 27 Feb 2024 03:01:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="rdcCuWxN" Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B46D17727 for ; Tue, 27 Feb 2024 03:00:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709002862; cv=none; b=J83xQu/Yvh6hE2I7vNRbad3qVpEhCTOpm9W3dOAn8IWzU5EnBn6ZIUZkpUd0lwTg3kQUnZzT6mTVuhMC3tQFysBeGjILRrR3yEbVxnqmLtfqMsiWvSjqimPO9N4Ezbz+jNEK82+YA3uC0J7UPGjSyxP0ycoJAh+IzBBKTfQZLRc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709002862; c=relaxed/simple; bh=yhXcOUr2TJWk/wNNiA1D6Q5q45wFN8idnbdKppdGcsc=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=CzcoT+gHiNGT6evIXTjjbbmKjdjUsN1E4Ol4SywDXcMLRZAn1ieglM7wxTTqTHvQa0i0Wl7GfPqJ9HDS3Q2cR8hSzFz4toL+3RVd9sAad/HyWUvhrOEPatbGc+DR4E6vFwrVNsaPPZEL7K4tiCywAV3Wrh1/32t9ATFjtEbF0Hw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=rdcCuWxN; arc=none smtp.client-ip=91.218.175.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1709002857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=xeQWaahmZnWCMBq0OUjMZaQ1ukelciifHqNoME1DLpU=; b=rdcCuWxN+7eDOuR8InRBPhUFUUrein7N1DNL9bQLa97q2as9+CeTi5nqK462eIHVqlOpUJ DE0f8LQ8fdhx+dI+6x/6UCExMbuVB3JMsKt7mypwkmqm700CvAimAF/yYzvB+IbiOpxKK/ l321fRfhM+btqf5QRTQctXh1OyKoTv0= From: chengming.zhou@linux.dev To: minchan@kernel.org, senozhatsky@chromium.org, akpm@linux-foundation.org Cc: hannes@cmpxchg.org, nphamcs@gmail.com, yosryahmed@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, chengming.zhou@linux.dev, Chengming Zhou Subject: [PATCH] mm/zsmalloc: don't need to save tag bit in handle Date: Tue, 27 Feb 2024 03:00:45 +0000 Message-Id: <20240227030045.3443702-1-chengming.zhou@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1792019403286405125 X-GMAIL-MSGID: 1792019403286405125 From: Chengming Zhou We only need to save the position (pfn + obj_idx) in the handle, don't need to save tag bit in handle. So one more bit can be used as obj_idx. Actually, the tag bit is only useful in zspage's memory space, to tell if an object is allocated or not. Signed-off-by: Chengming Zhou --- mm/zsmalloc.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index 63ec385cd670..7d7cb3eaabe0 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -110,7 +110,7 @@ #define OBJ_TAG_BITS 1 #define OBJ_TAG_MASK OBJ_ALLOCATED_TAG -#define OBJ_INDEX_BITS (BITS_PER_LONG - _PFN_BITS - OBJ_TAG_BITS) +#define OBJ_INDEX_BITS (BITS_PER_LONG - _PFN_BITS) #define OBJ_INDEX_MASK ((_AC(1, UL) << OBJ_INDEX_BITS) - 1) #define HUGE_BITS 1 @@ -737,14 +737,12 @@ static struct page *get_next_page(struct page *page) static void obj_to_location(unsigned long obj, struct page **page, unsigned int *obj_idx) { - obj >>= OBJ_TAG_BITS; *page = pfn_to_page(obj >> OBJ_INDEX_BITS); *obj_idx = (obj & OBJ_INDEX_MASK); } static void obj_to_page(unsigned long obj, struct page **page) { - obj >>= OBJ_TAG_BITS; *page = pfn_to_page(obj >> OBJ_INDEX_BITS); } @@ -759,7 +757,6 @@ static unsigned long location_to_obj(struct page *page, unsigned int obj_idx) obj = page_to_pfn(page) << OBJ_INDEX_BITS; obj |= obj_idx & OBJ_INDEX_MASK; - obj <<= OBJ_TAG_BITS; return obj; }