From patchwork Mon Feb 26 21:37:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe JAILLET X-Patchwork-Id: 206942 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp2347229dyb; Mon, 26 Feb 2024 13:38:13 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV2lP2Zx10yVyYXle+vGyNHM0COesKzDn3ZuhYtfBO47uS+mj2GsdWvTE/UnH8o86gCVV3NCNlF2fHG893Ow9TvMMUYAQ== X-Google-Smtp-Source: AGHT+IHRhceGb1fnnAmMflFv6cY0ONUX9yFdKs3a8OnHKAv3yck1yf5tTgWCxeL6H/yVhVJlBcoy X-Received: by 2002:a05:6a00:8d92:b0:6e4:c481:ca9 with SMTP id im18-20020a056a008d9200b006e4c4810ca9mr8109227pfb.33.1708983493636; Mon, 26 Feb 2024 13:38:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708983493; cv=pass; d=google.com; s=arc-20160816; b=zBUtFI6GTsXwWv4FdGqWEL4qgmPJaz+kN4di65gf/bBaJBa3ptlszMSgaTk/fOivmQ qUWzKZ9+xNvQUJnDbKM+LB67DmMPcVumyv9GSFj5p5N+edZjV6Vu1Z4vhl2JOyZkPj+N lefDxMRn4cryKMN193Fw4fgPEVkm+BJycxgA6mO2aH7X3ZwwlaNHx1aRKOPgdyJPC2B7 pibCV4fIzp4ISFmoh6XkKJ53Vw2IxfcFzCivojXZLUaaNrkdfXXrzXYVXA4QOM3Vg9do xwhBTb3i9/U0VtSY+iMGlRSaeWs+0xxQF/AF6JjlMZHKoz1K5A+rnWophzeokc8VC1ra 7vyQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=tmMG+U7Q36q6vKuwv+d+vvsnLJBFXkQVcXONSgONuqI=; fh=ZAKK1OHsW8qHhQ+D746dUjAX9Hxp5FbVoBoaI6X0w9w=; b=lote5GW/+m8jn7EIIE65K77MdMGi9wBefox/Yc0ORy2JEuDlZkJMKI672lrlhES5c8 yzKUmICru3cGoFbBJNWW9D6UBE61E2XtD/uLATTsy5Zo8wnurGEAjkccqCQx7rw2PCjO NHqSFDAhgfScExwn16uHlJOEKQc4x8jLdedoPQOfLRqhmWg/cuBntWQqH3v+CVmcwQ38 oBpkJr8qbDYnIbm/wA7Fa55lLQvQQ2cosXSY69wAFJVH415YrqlCgkUym3hmE3eIFQp6 vc4VLLPNTeHcyhHSuZLdsmS+Em36GPBmJB7eS+hVZtA19SOJhUZ1SbPfVUmO7CdUiFYi NOsQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@wanadoo.fr header.s=t20230301 header.b=EbHd1cNx; arc=pass (i=1 spf=pass spfdomain=wanadoo.fr dkim=pass dkdomain=wanadoo.fr dmarc=pass fromdomain=wanadoo.fr); spf=pass (google.com: domain of linux-kernel+bounces-82363-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82363-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=wanadoo.fr Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id t2-20020a632242000000b005dcd296e2bcsi4179526pgm.665.2024.02.26.13.38.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 13:38:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-82363-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@wanadoo.fr header.s=t20230301 header.b=EbHd1cNx; arc=pass (i=1 spf=pass spfdomain=wanadoo.fr dkim=pass dkdomain=wanadoo.fr dmarc=pass fromdomain=wanadoo.fr); spf=pass (google.com: domain of linux-kernel+bounces-82363-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82363-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=wanadoo.fr Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4B2F0287F42 for ; Mon, 26 Feb 2024 21:38:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1BBF6131E53; Mon, 26 Feb 2024 21:37:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wanadoo.fr header.i=@wanadoo.fr header.b="EbHd1cNx" Received: from smtp.smtpout.orange.fr (smtp-30.smtpout.orange.fr [80.12.242.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D866B12C7F6 for ; Mon, 26 Feb 2024 21:37:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.12.242.30 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708983476; cv=none; b=ILr7zEu3MRfj8ko8+afRwNSeA2+kK/fQ5YzVw/2wa/yT0tcF70d8PAPJ47wN62IO12Oou6A2W29rBp9qqlfn6AujvCphcPUulJjbszCy2jiQub1o6eGGzpN1Kt1jGMW3BQAt6Od54vdkILSoyICcm9/dybOzcI8IbnT0z/hiXMU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708983476; c=relaxed/simple; bh=ie89sVvbplEsqZ0131OZ4+yw637SSmyv+UFSLp8ibI4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JsUPWhPeVvtBPaM2Do9lBYx8jSehv49quWzBdunPRm6iBWho/hFo/Y92D9ZgXoGn7R0nkMS078YzC5EQvSsf9Y09QEmS9LXVu3/iSXguKR7GmMhvKprmf/m6Vm4FA3MHVDkxHv0uQWrfxNXG7pLYt56xvhh3wwplULEvgj3VjIY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=wanadoo.fr; spf=pass smtp.mailfrom=wanadoo.fr; dkim=pass (2048-bit key) header.d=wanadoo.fr header.i=@wanadoo.fr header.b=EbHd1cNx; arc=none smtp.client-ip=80.12.242.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=wanadoo.fr Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=wanadoo.fr Received: from fedora.home ([92.140.202.140]) by smtp.orange.fr with ESMTPA id eifMrgtXR2yuveifMrNhV5; Mon, 26 Feb 2024 22:37:44 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1708983464; bh=tmMG+U7Q36q6vKuwv+d+vvsnLJBFXkQVcXONSgONuqI=; h=From:To:Cc:Subject:Date; b=EbHd1cNxsqDB/7L7O3dFeESKpvfjpaziXl8cs2mYfQDbXQtoSYlkc22Wfa9TC+qde VDI271L0tQe7rDZyDsTSjP+Ph2VjZW3/KXToNCR9LpfUmzBBqPQRvRoILYspKKuXDU lh5HYbXGmnzqD36rGX30QVRAL9tGr5DjXJcVX0lVJfIjIbVOUJ1wCsbL0oMFiE9VUo y02tan8z+AgeYwvAs7/0k0lKaaNb/YNXvzQJVIp7q9MtxC+0YzCpwkEWt8sia/ereP krz6UXoVbwY5bZBaCYxESI0o4CSzfS1WfB5caVDfrNpGDRE16JnfY6DheVYoTiyPcQ xdiytd6XxcL6g== X-ME-Helo: fedora.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Mon, 26 Feb 2024 22:37:44 +0100 X-ME-IP: 92.140.202.140 From: Christophe JAILLET To: ulf.hansson@linaro.org, cjb@laptop.org Cc: linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] mmc: wmt-sdmmc: remove an incorrect release_mem_region() call in the .remove function Date: Mon, 26 Feb 2024 22:37:39 +0100 Message-ID: X-Mailer: git-send-email 2.43.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791999075380584142 X-GMAIL-MSGID: 1791999075380584142 This looks strange to call release_mem_region() in a remove function without any request_mem_region() in the probe or "struct resource" somewhere. So remove the corresponding code. Fixes: 3a96dff0f828 ("mmc: SD/MMC Host Controller for Wondermedia WM8505/WM8650") Signed-off-by: Christophe JAILLET --- This patch is speculative. Review with care. Compile tested only. --- drivers/mmc/host/wmt-sdmmc.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c index 77d5f1d24489..860380931b6c 100644 --- a/drivers/mmc/host/wmt-sdmmc.c +++ b/drivers/mmc/host/wmt-sdmmc.c @@ -883,7 +883,6 @@ static void wmt_mci_remove(struct platform_device *pdev) { struct mmc_host *mmc; struct wmt_mci_priv *priv; - struct resource *res; u32 reg_tmp; mmc = platform_get_drvdata(pdev); @@ -911,9 +910,6 @@ static void wmt_mci_remove(struct platform_device *pdev) clk_disable_unprepare(priv->clk_sdmmc); clk_put(priv->clk_sdmmc); - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - release_mem_region(res->start, resource_size(res)); - mmc_free_host(mmc); dev_info(&pdev->dev, "WMT MCI device removed\n");