From patchwork Mon Feb 26 19:40:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Bergh X-Patchwork-Id: 206893 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp2294808dyb; Mon, 26 Feb 2024 11:41:49 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWWIqzE4XBCvBT1M6RzKemVBX/kOGEX5I3y6K6F0v2uJvJYf1EVdPYvwSO+QhvWp5wDbssD9/d9RxHqJvHDCx4bkQPgYg== X-Google-Smtp-Source: AGHT+IExFOBzyq03oWXO8ufI8Ih6Wpwui7HZRGzZZL7vc+xTBSJAsz7QDGXxFtVqU2GnfD8YZaxu X-Received: by 2002:a17:90a:4a8f:b0:299:14c6:4fc7 with SMTP id f15-20020a17090a4a8f00b0029914c64fc7mr6073724pjh.13.1708976509705; Mon, 26 Feb 2024 11:41:49 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708976509; cv=pass; d=google.com; s=arc-20160816; b=unn3jy1tPgXiM3rwaAugGb4VB34gObaBKIrl/W9W8qb7TZyeH7r4sWR7cx2x2zHNxj +Fzljrd3+H4c8R+Pn10LZmHXlGUvtZ/BRmpD+8ua4PO2LCBbOJnak10kyJqQHCQ0Gerj YDPBRVKS9S+TuSr0zcIkC9ArqZWtEJw14vIZ7sJm+rUt4Z+xNoCW231Tpsvar23ndyQz ASlh7PjZZxtwnmXHi2i4j6kANzLcs1Q+JIjXNujMPZJ2+FRa6BGuJpxDkWM2cmOiRFZN k3/6O3T7WS5AWnSbGYLXv7qkcS1ZTL9sZQYDIEBqcG5CNN/Sbc/wHPpH7G7/LwCYoREY +H3A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=TFlpEGYCrz+PVIm+1MzHIEYrRDDL2zl3YZa0XiZSGXI=; fh=x3GVDlrIGc5xSNzXC/xwProPmjfRR8lfKVFUq46MaSs=; b=flJPWgN10B8X4xQ/BeJfI8oauXaRul/rOo2fGYKwdNUowLcF+BwgskneUrKCaCnTPA XIxx5FWQq4fMnZVd1IeS8E1v3KjvKxIMyTXb8zR+sazLBDsIJiKdPPSrDmYKAI47YO9B mLjYI0aCn0hMY5V9gkn6XGHyf1KAO6a2jqdYtYMayHf8otofMn5J3ZU5i4AK1/At1jZ4 IbdQCRJAq98ckBDGYq9iNdvAgYWOHGFWiC6iK+YkBBT54O2rqNxULf5da+isiDsowgQN BBpY2CZxx+dx99zbhJHvUMeEyk540TqEtpJa8LRRFR/Hi+R1uuoyWnA4B1xpW9HNz0/+ 3HVw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=lAWxdnN3; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-82253-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82253-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id sj17-20020a17090b2d9100b0029a90ca16d6si4227656pjb.22.2024.02.26.11.41.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 11:41:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-82253-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=lAWxdnN3; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-82253-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82253-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6F02D28CC33 for ; Mon, 26 Feb 2024 19:41:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 118E4130E41; Mon, 26 Feb 2024 19:41:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lAWxdnN3" Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42B8112FB3A; Mon, 26 Feb 2024 19:41:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708976480; cv=none; b=DZ5ube7Z6sPVLY28tyrmNp6sfsC9jGmlCok7ylec3DnD9mFlC2FeMHItZ+R9oYumOPgO+aMH4wEYazkdF6Jt4BdlmGquh5xmTBWVnVno7gApEuRv6Ryo42XwMp7mZ0/qPmQ3hoPZVMcs0eSMB2zhqEjqH31pczaTJWM/V/2cpmI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708976480; c=relaxed/simple; bh=zMwyLGxftEg0zbEk3IpLDvzCnWJjH1ppm5rGkw0rT9o=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=dV88m85Whene/jgpHeLEWPUM7aLQ3FA8WGYwzyP0C5wGfdrDOZ7swaVNRt7DrCVjjMFFAidFwZlCg3EahnnucgAUEbXmhBoTd5ecWxeZHERFnQ8z/OMXevajka5m1kHTS1m1+RRwy/8RZytFnW88cHMgPkQGyL4kRM0h46O9Q98= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lAWxdnN3; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-5101cd91017so5140733e87.2; Mon, 26 Feb 2024 11:41:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708976475; x=1709581275; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TFlpEGYCrz+PVIm+1MzHIEYrRDDL2zl3YZa0XiZSGXI=; b=lAWxdnN3oqyLqF2ms7DbhnGqkdzT7hGnRwvjH9wpJ3he72UoY2AayaAVfSFIo2A2Ih vjs5aRjt0C8oLYbCKmMHnjM4sePG7G2Z1+9C+TzirHeYsoywHv7uudyeJAhcPLJXVINx ia2WWDSdID2RKK4HhYNzclDqc7C8z5Fid3HKDS1ynB5pBQqBGxx96kVp8Taj2d9u82IJ ipZhEd6XZ+9R/QYigcg6VJtFzOfwJZUfuGWzSnowO6H2Fu6H9Ml6JXPSYh6+ZXg1R4Zr gLhwuxtD/Muc0ZyzqlMMqKALITO0lzUUgP/o6cUR6DqPrXiFus43jILWNS0yITTxO5Ef nS5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708976475; x=1709581275; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TFlpEGYCrz+PVIm+1MzHIEYrRDDL2zl3YZa0XiZSGXI=; b=Nh4R8lnBaFyAdq7AjBR9nUbO2H9wMfH8KrBH6Itlvu7YHLK9d0afr4gwjiFWE2uLly E1DX0GehDGYCnRwFgkdSl10/A/gTGx+00Rrx90aKTbPYEMnVvrDZb0DbAMaoL9NE5dDU GhzA8TKmuHLivEyJuQ8ZFkaz46YWhV8uGcz9DbzSHYQTTQDmWou5vfHftWfBvfpnYDAo rVVXmgz4ry2HFD8GkW/5aqaud5/ix8HzUpkYX0rLCBKp672SpZbd2XcZRXdIYFs5VDIe Bjs9BtxphvZTSl/bJtuK0OHOVoU22ss5EbCNWVYTJo4B8tMCZl3VyMX+v5zESgEJ1lQy BEMQ== X-Forwarded-Encrypted: i=1; AJvYcCVbmI4JwfOCMfGTYHV7WpGnhWMEaihqUmxOPIMpSLIyNjRp/wIEaJT+b4ildCg270eC4urfJTuiZ6gTOv5k1hXtvlyZgMcDoC/ZBC2Nj10usW1BW3OYr765xNf3URiclQB4fj4zjEFXnSg= X-Gm-Message-State: AOJu0YzJo+MJWrwW6NnZHTrbtqih/6XghSqlrv1ZqE1W0d0Zncb5hN2P 5Wetg1weWrHx7Jk9E9vOFzTeAiFqXxLpr4rOOJxnGZhawRsEWDNv X-Received: by 2002:a05:6512:69:b0:512:b517:982 with SMTP id i9-20020a056512006900b00512b5170982mr4279240lfo.20.1708976475107; Mon, 26 Feb 2024 11:41:15 -0800 (PST) Received: from localhost.localdomain (c83-255-24-248.bredband.tele2.se. [83.255.24.248]) by smtp.googlemail.com with ESMTPSA id e21-20020a196915000000b00512ffb9bae9sm332328lfc.143.2024.02.26.11.41.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 11:41:14 -0800 (PST) From: Jonathan Bergh To: hdegoede@redhat.com Cc: mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Bergh Subject: [PATCH 1/6] staging: media: atomisp: Remove unnecessary braces from single line conditional statements Date: Mon, 26 Feb 2024 20:40:18 +0100 Message-Id: <20240226194023.69070-2-bergh.jonathan@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240226194023.69070-1-bergh.jonathan@gmail.com> References: <20240226194023.69070-1-bergh.jonathan@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791991752809112904 X-GMAIL-MSGID: 1791991752809112904 This patch does the following things: * Tidies up code in several places where braces were used in conjunction with single line conditional statements Signed-off-by: Jonathan Bergh --- drivers/staging/media/atomisp/pci/sh_css_sp.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/sh_css_sp.c b/drivers/staging/media/atomisp/pci/sh_css_sp.c index cd7f5a3fecaa..23893189ba82 100644 --- a/drivers/staging/media/atomisp/pci/sh_css_sp.c +++ b/drivers/staging/media/atomisp/pci/sh_css_sp.c @@ -420,9 +420,8 @@ sh_css_copy_buffer_attr_to_spbuffer(struct ia_css_buffer_sp *dest_buf, lines below. In order to satisfy KW an additional if has been added. This one will always yield true. */ - if ((queue_id < SH_CSS_MAX_NUM_QUEUES)) { + if ((queue_id < SH_CSS_MAX_NUM_QUEUES)) dest_buf->buf_src.queue_id = queue_id; - } } else { assert(xmem_addr != mmgr_EXCEPTION); dest_buf->buf_src.xmem_addr = xmem_addr; @@ -860,9 +859,8 @@ initialize_isp_states(const struct ia_css_binary *binary) if (!binary->info->mem_offsets.offsets.state) return; - for (i = 0; i < IA_CSS_NUM_STATE_IDS; i++) { + for (i = 0; i < IA_CSS_NUM_STATE_IDS; i++) ia_css_kernel_init_state[i](binary); - } } static void @@ -878,9 +876,8 @@ initialize_stage_frames(struct ia_css_frames_sp *frames) unsigned int i; initialize_frame_buffer_attribute(&frames->in.buf_attr); - for (i = 0; i < IA_CSS_BINARY_MAX_OUTPUT_PORTS; i++) { + for (i = 0; i < IA_CSS_BINARY_MAX_OUTPUT_PORTS; i++) initialize_frame_buffer_attribute(&frames->out[i].buf_attr); - } initialize_frame_buffer_attribute(&frames->out_vf.buf_attr); initialize_frame_buffer_attribute(&frames->s3a_buf); initialize_frame_buffer_attribute(&frames->dvs_buf); @@ -1269,9 +1266,8 @@ sh_css_sp_init_pipeline(struct ia_css_pipeline *me, pipe = find_pipe_by_num(pipe_num); assert(pipe); - if (!pipe) { + if (!pipe) return; - } sh_css_sp_group.pipe[thread_id].scaler_pp_lut = sh_css_pipe_get_pp_gdc_lut(pipe); if (md_info && md_info->size > 0) { From patchwork Mon Feb 26 19:40:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Bergh X-Patchwork-Id: 206894 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp2294849dyb; Mon, 26 Feb 2024 11:41:58 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWs6iFbZOcbZsyUcH8CLp4Duw6pioGZO/xF6CDH5bq760RnWVS520U1PvYA2cNfKgbH770snwT2hQv2fWyarduRXBFz3Q== X-Google-Smtp-Source: AGHT+IFRMeCD0hDikvxizVqs5lwhavw+zY3ehcWqUKce/WeMPOEBGCCqAOHpX5K4H0ZFC+q0guKD X-Received: by 2002:a92:c842:0:b0:365:27e7:4b60 with SMTP id b2-20020a92c842000000b0036527e74b60mr8511213ilq.21.1708976517989; Mon, 26 Feb 2024 11:41:57 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708976517; cv=pass; d=google.com; s=arc-20160816; b=Bq7zBUxCXAicGCS7JNw9mgZqfOkdeshVCFAdwyuG7O1UeuzQbQWq5ZwyquvKzGcVVD NLEZDtk3+m/YJGkEgClgtkXpzmHthG/25O2/9V4npxTfYVmy6pMGbXFXLLCouMZecUYI MVlr/gvWSSjLliObLagAC12zp/er+O8/pUeIjWuxg9D4cGtdQRH4Ht6HEf3CY5Irgdxm PSi++BGtectnRLdEzjdMQLLMANb6+gzfMwQKyP1Df0OIfoPjhC3uTWc2wm/GF3upxr9q mxfa4J6ZrkkiltyRpSlO8pmVZbAUyaTOK0llJ39ispk4+ig3p7Id+Q6NA4Ab/iSE6Wm2 jr3A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=LjiHaDggzrFKsMAmUUXttaUHY0jzI+UD/FYH2klkGCI=; fh=9JIbAufz/pB8llmBgOCQGww9cWc9e3BAvPLpHSzhDXQ=; b=gO95FHRPeCYj2jLE4bzRxLxbiLS5IQ3imVmC+GpAhr8AwkgEkq/MuFuT2tpoLKvs1Y 1tX26pSJT/YPICClv2F9DT1n1RLNbFqQME2GeSdgOigV9LpYXOHPTUThJ5V8BYhOBZZD F2rc6wXsMBb/JaUodg5PU5CD5TYVaJh/PivIkSvVeUTnEHYklqMB0OZzNbLNj5Ij7feO SXMsxGwpweQ2whzPPQv7QKl4fFZO8Q7Ny8EqdM+sh436OARVwLb+7mvdlk9Nwcpk8t+k 2xbr+Dl9L1w+sPmVOyJbVJy87pq5E65jZccFHo5Y1KyWrh7vDkJf+onWUAEK6z17S3EW zHkw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=IOI6cbvZ; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-82254-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82254-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id e14-20020a65648e000000b005dc816e3080si4158668pgv.12.2024.02.26.11.41.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 11:41:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-82254-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=IOI6cbvZ; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-82254-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82254-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C3E0528CD30 for ; Mon, 26 Feb 2024 19:41:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BE43012FB3A; Mon, 26 Feb 2024 19:41:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IOI6cbvZ" Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 580D512FB28; Mon, 26 Feb 2024 19:41:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708976481; cv=none; b=KLCVioI1eHoKgc8KGq6x3z2uYXzD4rIC3I2tTHfYPR5DFBaYOFoQIfPUEoAYkoE9jx/5IA0sy5gmhtl4TY22hhZDwAqEaISp4fAsIcbPrqRkh0ECSxEebgEP10LRuv61GysCbMXzFpB1H7XDDx5N1V778xeqC8t0BBZH3L4Z5K8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708976481; c=relaxed/simple; bh=LZ9TktC3T1afzZRvN0TOC30yL2jLq66ga59kBG/bxIs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BJk3HkpbXVP8zvjfiFGNW86pbXzDdtYsGsQNTz0YN7MEiITyDVUqPvDihmDuFbssprsKicQRgFfYuRqwLE7mcnPYyAKvwltf6ABM53C9d0u9gFqw5SvcmPhJpqItYdD2NtCENOCIZTb5RwHh26a8AkYUlhwvGnD44FD9b88oqIw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IOI6cbvZ; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-512bd533be0so4195920e87.0; Mon, 26 Feb 2024 11:41:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708976477; x=1709581277; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LjiHaDggzrFKsMAmUUXttaUHY0jzI+UD/FYH2klkGCI=; b=IOI6cbvZ2YcjRgChvrpkn0BRJDyEDjO/sFCl6NJi+91NY6fxLD4uNkOsvOWgdtGfAO 6xNK5gLqwFVT8CdUIQ2fEZZXXvXhA8eVfDckxtG8msh+VQowed4G7TiS4zeXdSAM1/CE xrLTvUDTwwQpclRttibOxuATcNHI8q8GUaA236+JXD7WIgeuRovDLvToNrnWtMIcGGs6 jt+UW6m9FDuZsWQaK6B9N1nyy8I9qMo9rhCToLYwdkbSj0ZUnxHiUTGYF1v445Q8gMsu Nq6UWFWLusUvffv5tyuvC9G9AzhwjMehIrvwgm1Bwmp6BIfrcIbAjLEi6bJN36PU3uvM ryfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708976477; x=1709581277; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LjiHaDggzrFKsMAmUUXttaUHY0jzI+UD/FYH2klkGCI=; b=IGIdKEp08vMePlYAYWh3PCdn3Or55VciG9i7p/JTrcMgHDvjGugZ1gHziny0XiMvtp T3kqCxeD1HsL626Ya6qfAwca37j4CZxmHkC+jcIUJxNQEPkTtENlKbE7znEn2oLDdd3l sN5WIKeCdbqJJa719sp4SwF1unC7udXNKpLrw4iUasIKmeiUKD2nFhCz2Dhqc8QQBevz bEjGcH1FISTSv2mELHsZg2satPPTKKmawmyeRoY8zRmYUCrwnveDTl1z9xyUHjuzfyOd 5H6mzXWmtZA422lcXIhvpvAYcKIa39NF+M11uUgNTpZFuNmBtaI9BgbsBLkqldqhKdx8 ZBPA== X-Forwarded-Encrypted: i=1; AJvYcCVLCrT3Jn/i9seshqkYDXqQ0BmN9K0r+9lCAnbTofsi2fcRCvXGpgON5iN7mKkCn/k/SHBza4ucEuGYvneFlLxnJpzl7rkbenkdgj+5iAwg5bwzJnv0ZIbnq7t7ZA1mhTNwdmVS4icTj8k= X-Gm-Message-State: AOJu0YxslWIKOvJlpRW7qlXwAkRyfVoPDt+uDNhfPVPbkvT7zNwqfIe8 IrKvFMWX/4/T8GlyO0UG3QbF1tCmOqEgpsO1O0OtbduPzCNbm6nQ X-Received: by 2002:a05:6512:3a8f:b0:512:fb30:aade with SMTP id q15-20020a0565123a8f00b00512fb30aademr3882586lfu.3.1708976477319; Mon, 26 Feb 2024 11:41:17 -0800 (PST) Received: from localhost.localdomain (c83-255-24-248.bredband.tele2.se. [83.255.24.248]) by smtp.googlemail.com with ESMTPSA id e21-20020a196915000000b00512ffb9bae9sm332328lfc.143.2024.02.26.11.41.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 11:41:16 -0800 (PST) From: Jonathan Bergh To: hdegoede@redhat.com Cc: mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Bergh Subject: [PATCH 2/6] staging: media: atomisp: Fixed "unsigned int *" rather than "unsigned *" declaration in variable declaration Date: Mon, 26 Feb 2024 20:40:19 +0100 Message-Id: <20240226194023.69070-3-bergh.jonathan@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240226194023.69070-1-bergh.jonathan@gmail.com> References: <20240226194023.69070-1-bergh.jonathan@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791991761187148775 X-GMAIL-MSGID: 1791991761187148775 This code fixes a code style issue where: * Checkpatch suggests using "unsigned int *" rather than a bare "unsigned *" declaration in the code Signed-off-by: Jonathan Bergh --- drivers/staging/media/atomisp/pci/sh_css_sp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/sh_css_sp.c b/drivers/staging/media/atomisp/pci/sh_css_sp.c index 23893189ba82..9c15b8a1a93e 100644 --- a/drivers/staging/media/atomisp/pci/sh_css_sp.c +++ b/drivers/staging/media/atomisp/pci/sh_css_sp.c @@ -187,7 +187,7 @@ sh_css_sp_get_debug_state(struct sh_css_sp_debug_state *state) (void)HIVE_ADDR_sp_output; /* To get rid of warning in CRUN */ for (i = 0; i < sizeof(*state) / sizeof(int); i++) - ((unsigned *)state)[i] = load_sp_array_uint(sp_output, i + offset); + ((unsigned int *)state)[i] = load_sp_array_uint(sp_output, i + offset); } #endif From patchwork Mon Feb 26 19:40:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Bergh X-Patchwork-Id: 206896 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp2295166dyb; Mon, 26 Feb 2024 11:42:45 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXmy2N/HdATjFhWdcE/R45GYMqYccS2RFRyekIBc//hnlukUnBvQ/ZsH0PrM4D0aqur5LGaxzbMIaEEqFHmG2zM0E1izA== X-Google-Smtp-Source: AGHT+IEcU+eHbV+TNLjLzvijhGC/GTldXswNYUJFKLAoumAWyjpcGvScOO/eSlEGwUGXnIFSrfMY X-Received: by 2002:a9d:67d8:0:b0:6e4:875e:b5b7 with SMTP id c24-20020a9d67d8000000b006e4875eb5b7mr8197674otn.36.1708976565216; Mon, 26 Feb 2024 11:42:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708976565; cv=pass; d=google.com; s=arc-20160816; b=akwkUXRGg8mYyTsR3LLPHKoTuLsBX4nSwmZJ5cyLaQzYkbA3gyTk9MQmBb4oLE2+LU aC+kXCd0+pdLhfifKCEnLBUpdJNo6a+bDy+yS6FTWrjUQaiFu7CvvshBTiTuVTmb3jz3 KPrpFDc0dVA3nfJQDwioZzNs8baSerOayM+sE6Gv7EF5X4I3Xx6SBlF5ejBjKGPA412p Q/hEyUQICb0Qr4Mnv1+Ni4eOzrBlPkZH5MGBidy/+ICBPSjrXSzbjGo+2g7WFGB/4RS8 zqDzOebdX1axU7KZ3Q4jQ/VhaK7Esoq/vh9zl4jF3GC1QQPybkDYcxYL+iZvfLPuy6AI qJGA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=sdk1R1nAFAYYkP7IQxHcP9QAcpxTnZuCyz69UQAIi0E=; fh=Ddb8mn12aN938I8xXQsoTmuz1BEPmTurPc9a5z7W+mQ=; b=cjXNtligIw3t1kiyLFaDloiYG+lUDt9YiHE0p/0cIHwrsMAUhxijYb4a3F9MNYKe7C zEeMMIqgc4yEf9g+3sF1ZJWioPOdprDvqKnGwyhneResttR9hirYgnLH6D/9r3VfBH6o PdtfxvNUR1tbQOmcx/dgILpzek7SGHrsgTC+0rtr+7C829VqsKP/OQ2ZIDdMpizkGAIn fDa+Kv3hSSiXoKuBiDf6zlVPwPDla08dXixsFft9eENciGaKYeoHNm9VyyVkIv/QJmrE JEL1mPoj7GybQq9kA/fBVUp5hAk+54B2Z9jWQyyovLvD2kLjFL9ex65rC4Ss1i0Wdg+4 8Ohw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=kdQvpaI+; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-82255-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82255-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id v20-20020a05622a131400b0042e8d4f4bdbsi1679976qtk.259.2024.02.26.11.42.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 11:42:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-82255-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=kdQvpaI+; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-82255-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82255-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1DE031C28155 for ; Mon, 26 Feb 2024 19:42:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 75679131750; Mon, 26 Feb 2024 19:41:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kdQvpaI+" Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0ABDD130AC0; Mon, 26 Feb 2024 19:41:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708976482; cv=none; b=UDEcAVqsMEOHrLjE1ak9hxMs5OdOza0X0UQmzYmz+uvyUtnU2SN7RcdhKOjWhvmX9MSQeZv7ONKnbG4YzgACS5P00EXh4Qp9KdCOKx1b8J5pWXQCe0GfBoIpuM5/kCP35opw5BqbRRU+nzy/8TzwGZ/kW5GkGQYh9BmynLViqLE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708976482; c=relaxed/simple; bh=n9VMTsl5EbE3QRKYwB1+/X4b93ZHl/WUQpm56MegPTM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UV+eL1HldhNGYcX9WIFxRf+HilyKvjXPA/OcOGf6pvzBDERBy/BuooimxaSYhUpQXWALZ2JaPMyWwXjcHz1ZkodsjeIOdIiX/0sboi4JXy26xKgSwNCeGAEh2w4FbpeFVLVTae6owfGe6VZZjFHZyrZTvlCUrjVMM/nLZnWjizU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kdQvpaI+; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-513031cff23so221640e87.1; Mon, 26 Feb 2024 11:41:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708976479; x=1709581279; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sdk1R1nAFAYYkP7IQxHcP9QAcpxTnZuCyz69UQAIi0E=; b=kdQvpaI+6arFH4xlH2OS+GDmLG/gwMj0nECe7mSQxWkAzHytEIYgHY1JpL9xfhyffp yJGUiQ/M2paG1zXZzFArQF7fwbghX1sk8P4XBnejYTOMRFwS7vFYgzaDOyYtw1qmGUSL qLs0wBNgPaJ0y26XcjergEFNvlRF4860kz7JOz5LDxeRXgPgSXiEm7UQKxzPn2eTaZuc ueyIk7Hj7n5UzhV9b7eFM8XHs8m/OyJ9pafJEA8LV7NOksbPe4AA1qKxDkwmlm1HYfY2 lxMxyHwNabI7m9RkmUUb/zNwcldjPRZBi0p+2G8xS0OUeyli/W4zNlpB11cwgG2Ql0AS 1X2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708976479; x=1709581279; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sdk1R1nAFAYYkP7IQxHcP9QAcpxTnZuCyz69UQAIi0E=; b=YHdypiRl54a1UUvADRRPeuc+mOiC6MKrVRVT9d+nz8KMpblrlCGB3XIX3epWhKEh4Q D3E6VCZzwAplqpkC9/wn/kXeewsEVoXVnFANxeoFR0/CFdfoTQ1eIWN9K2zP9L2ufVyn 0c43wfZPhM9+lo8PC/zENz3CClh/zqjLMwYw7KDGsUEGZpaBq6Fxj8z6vBeAydUC01Su YiDADIQjbDcaKmYavJs/iws2ionGehEFA3HCxhDY5w6DWbzG/ljNSjWJe4wWhx40FrwB c6wj5J2Db8MFRyKqdBdSU06k2yofqveIdhnBUVxxJnVUZFfT4HWNEenT6xBleit7EyWZ zP0A== X-Forwarded-Encrypted: i=1; AJvYcCWn11atSdKu1Rjjkx9B2bUPGquGwvTkNP1znlJXv7MD5NE974ofR3CCSi0zylwUEzAsi5fIaHtOhSPH/qPBz41sa7J08BLnyWFCNAIJrKWygXlNX90WTEnqGutwON80EfFw9MI0zlDhnPk= X-Gm-Message-State: AOJu0YwHdBjiqzPMdVjjwv9fEuXN3F0KqhPXVvnjzS3wWCzn3PbY25Vb eogRryrd2F3dbn79aCehqNUoHqS/aFuL45Dva5dQINFFIPxkMcTQvBiG3a6s X-Received: by 2002:a05:6512:1317:b0:512:f4f6:9343 with SMTP id x23-20020a056512131700b00512f4f69343mr2786993lfu.26.1708976479116; Mon, 26 Feb 2024 11:41:19 -0800 (PST) Received: from localhost.localdomain (c83-255-24-248.bredband.tele2.se. [83.255.24.248]) by smtp.googlemail.com with ESMTPSA id e21-20020a196915000000b00512ffb9bae9sm332328lfc.143.2024.02.26.11.41.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 11:41:18 -0800 (PST) From: Jonathan Bergh To: hdegoede@redhat.com Cc: mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Bergh Subject: [PATCH 3/6] staging: media: atomisp: Ensure trailing statements are on a newline and remove spurious whitespaces Date: Mon, 26 Feb 2024 20:40:20 +0100 Message-Id: <20240226194023.69070-4-bergh.jonathan@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240226194023.69070-1-bergh.jonathan@gmail.com> References: <20240226194023.69070-1-bergh.jonathan@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791991810415087295 X-GMAIL-MSGID: 1791991810415087295 This patch fixes the following minor code style issues: * Ensure trailing statements are located on a newline * Removes an instance of a spurious whitespace following a conditional statement Signed-off-by: Jonathan Bergh --- drivers/staging/media/atomisp/pci/sh_css_sp.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/sh_css_sp.c b/drivers/staging/media/atomisp/pci/sh_css_sp.c index 9c15b8a1a93e..aad0a40d08cb 100644 --- a/drivers/staging/media/atomisp/pci/sh_css_sp.c +++ b/drivers/staging/media/atomisp/pci/sh_css_sp.c @@ -732,7 +732,8 @@ sh_css_sp_write_frame_pointers(const struct sh_css_binary_args *args) /* we don't pass this error back to the upper layer, so we add a assert here because we actually hit the error here but it still works by accident... */ - if (err) assert(false); + if (err) + assert(false); return err; } @@ -747,7 +748,8 @@ sh_css_sp_init_group(bool two_ppc, sh_css_sp_group.config.no_isp_sync = (uint8_t)no_isp_sync; /* decide whether the frame is processed online or offline */ - if (if_config_index == SH_CSS_IF_CONFIG_NOT_NEEDED) return; + if (if_config_index == SH_CSS_IF_CONFIG_NOT_NEEDED) + return; if (!IS_ISP2401) { assert(if_config_index < SH_CSS_MAX_IF_CONFIGS); @@ -1266,7 +1268,7 @@ sh_css_sp_init_pipeline(struct ia_css_pipeline *me, pipe = find_pipe_by_num(pipe_num); assert(pipe); - if (!pipe) + if (!pipe) return; sh_css_sp_group.pipe[thread_id].scaler_pp_lut = sh_css_pipe_get_pp_gdc_lut(pipe); From patchwork Mon Feb 26 19:40:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Bergh X-Patchwork-Id: 206895 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp2294989dyb; Mon, 26 Feb 2024 11:42:21 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWLkAei1NhO6OpuvOzES1WmaD83gIbcLV5iqoit+FtPekzZeKKP6MHdRxQrPzBQtfNjkQB75pfaCySvSH4F7de/Nh/WGA== X-Google-Smtp-Source: AGHT+IHzIaN9/F2wQHF7YL5WZylSGqFav7NRkA1zeAZf+2aCZuM0pAC0ii/IjTMVMTLGHuc+dOzU X-Received: by 2002:a17:90a:d497:b0:299:11e4:619d with SMTP id s23-20020a17090ad49700b0029911e4619dmr6194165pju.33.1708976541367; Mon, 26 Feb 2024 11:42:21 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708976541; cv=pass; d=google.com; s=arc-20160816; b=RvNOrcw7FEFptKmKKnJCmjiyRU0X6uKUfsNHePEhJJk+Oe5P7fPJAQdUByRlCJuYo2 Iq1M2ENfBDVaV8hqUsY9hCADoevsFYYIHbaEWy0mMaXL6T0JOxhIaRaADxNREXlN/eoX OZL0siWtt5zERhZibq0OH6exV5vhQ673bfcGa99EUrk9VLWgig3y6d6jkQEY6aGpauyQ QDTkXrhUc4OtP2EdUspLsJ0XUGNAfcuqe/F0Ri+lRASK7V8Oe5lgQqgADhN8LG9Ifyc5 iXVvSFQSwvSOad6L8kelkWTrNOI2IikZ3X/Alzy6ldPXE4ljwWiKD64SB0Mfp1LoXVUQ E/cw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=HILq8vE3I7ZzvY3bc/3MfQGbUQ+nQ5ixo1Vu9vm+DGY=; fh=i4ljZOXRRdLKZQvN9GoneVNlExUeY/KR9/s0t9I/MlA=; b=ZkKHvdDXkgrepXIsAI6gWopaMqabbtlwIV4QHXUphfo9PjEJ3zV2pFSmWDf0BHOe2x bkDYKRpqtd2bsPdesmAUu5gy5lbfYmY5tvxsSA6TKommW312R72ddHEtv+6qJ63P7+bG J+HVhXkb8rL9ut+4YgBNBWvnZNvxIA3zZsjqIDoWxodbvInB7UIfkfjLOP5C0q9bQQS5 EWsiL03teQJc8lemb7wOyQWsb77tN5Gw7iLWs0DBOtbXonYTQQGylOQjJTFsAGCeooPa 9U/Sz2SaEiOPyySC5hlNxdJ+apJEVTLZWQqvN8/mohNa7v2e5qLedltNhxTS81fz5Qzz e78w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=GPcaERSz; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-82256-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82256-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id lk13-20020a17090b33cd00b0028cb18e31d5si4286936pjb.160.2024.02.26.11.42.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 11:42:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-82256-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=GPcaERSz; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-82256-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82256-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 2F58928D033 for ; Mon, 26 Feb 2024 19:42:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 413B0131E29; Mon, 26 Feb 2024 19:41:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GPcaERSz" Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC068130E3A; Mon, 26 Feb 2024 19:41:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708976484; cv=none; b=Isabqgj+TZumEYfgkvDh77tTDbzGfJpokWgVDIpAGrDu00OBl/FrdhZ8M9DbDzcZxKWEmuKfjoe0nwwY1KhSJ74NDg5DzIpu9/6v9BXz//9NKvTmxjh6fiwMLADVQ9FTo/Nv4YBsfGoewfIXGaCE68JdjmVhc/gotH23p5REXbU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708976484; c=relaxed/simple; bh=edbpBEkpeIqUywNKnwkwMaghHIEfzwyGMaSGvyVM6s8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fztaiHXI7MHqBsQiJ9PhS0UfVl9/F3wjdfBO5IN6M5bNHtlVErtfuJbu0l/VuIU+nDNqcYyRhQNGtI4pcLRPw8+xeQioX0zXgpaxaqHjqg45s6j8QDzvNWELnZCH88vHL2NUTvnrqVq939Rm/ez9k+zpfYizygHgbhCSAYjflBM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GPcaERSz; arc=none smtp.client-ip=209.85.208.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2d22fa5c822so50601491fa.2; Mon, 26 Feb 2024 11:41:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708976481; x=1709581281; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HILq8vE3I7ZzvY3bc/3MfQGbUQ+nQ5ixo1Vu9vm+DGY=; b=GPcaERSzROj+Z+PfdHDM1ayZErQK+593tNdGCwCz6g1bq2yctGJbhK8ECdXYgSGuih egSWoVQZXimDf1eqv4f0DMvJPpSpr0CukVpuusgiIRyTX28RYsxfU4tjat2gFrWXCjHw wdyNCdk8Z/aUQnzebY06U6VYloAJpEQTKGJC2q7KfmgMfHxDMtQOMfJAEO+/uJtAoMhb iOECU7TFcGKd2yGMaMhH0+vivoe9gUWdVtjb4PWZWuyZOzg3PnXYgtAZzF0mDO+jG/Gp LODrLG7UhJiBQNShDGeNdd8XjurZZUgHUGbxrYE2lxT+5yaFmPlshGce99OLXE+wJI/A BOcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708976481; x=1709581281; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HILq8vE3I7ZzvY3bc/3MfQGbUQ+nQ5ixo1Vu9vm+DGY=; b=DimZMH6UJcX9chxkhEEUd/w3OpumoV4+CO9R+meYozj4y92+mpFzmlVJXJ40mSorik 3Q1MmBUarymoLSIsUvdyyg1Ta4m0lRCpfMJbHIg4fN/5+GYbj1h171Hiqn3CVXAPuA36 JV3oMO5QZyT9y08osNQol393Z1iFNJYBNtxP46Ewnizpe6pnK2YUjK7hB25xATOIIkDV 8yRxXpzM/6bh58xqXIM7vyPP9mF4VPUiKNlstjSWW1sjW0EbDVMhHFxbNcXHWi7UwcLv xr3lDsO3B6QrTUiMzBfmJeBWVAdZbCz2upo2FpyuTf61G7ZJpltX09HwHzDw7rVoawnE n7Hw== X-Forwarded-Encrypted: i=1; AJvYcCWB3+D/O0SIIkw+r24FWUBhJRx51l8cZeRXdq2QKqx6ektL0EFh4vHsCInF0fz4Mbj104HpawjNCwp58xwbxLwrdyloSwiG3psGfmXFpeKhIm+a/5YjclEFZOZ1YR6dWL17EzpmjuUianA= X-Gm-Message-State: AOJu0YxSwOXM7BLUJ9F1i6XnKq2Kk8ZuzeQxcmXFkqSsyQHz/egFY6m+ IkAil/yL6T50e5VsYdqyLrHcyPTf2eamMQzcWTE1KaIgnvHeOYKd X-Received: by 2002:a05:6512:239d:b0:512:f17f:2b30 with SMTP id c29-20020a056512239d00b00512f17f2b30mr6093664lfv.59.1708976480831; Mon, 26 Feb 2024 11:41:20 -0800 (PST) Received: from localhost.localdomain (c83-255-24-248.bredband.tele2.se. [83.255.24.248]) by smtp.googlemail.com with ESMTPSA id e21-20020a196915000000b00512ffb9bae9sm332328lfc.143.2024.02.26.11.41.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 11:41:20 -0800 (PST) From: Jonathan Bergh To: hdegoede@redhat.com Cc: mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Bergh Subject: [PATCH 4/6] staging: media: atomisp: Remove unnecessary parentheses from conditional statement Date: Mon, 26 Feb 2024 20:40:21 +0100 Message-Id: <20240226194023.69070-5-bergh.jonathan@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240226194023.69070-1-bergh.jonathan@gmail.com> References: <20240226194023.69070-1-bergh.jonathan@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791991785726918649 X-GMAIL-MSGID: 1791991785726918649 This patch makes the following changes: * Removes additional, unnecessary parentheses from a conditional "if" statement Signed-off-by: Jonathan Bergh --- drivers/staging/media/atomisp/pci/sh_css_sp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/sh_css_sp.c b/drivers/staging/media/atomisp/pci/sh_css_sp.c index aad0a40d08cb..281cbbb89a14 100644 --- a/drivers/staging/media/atomisp/pci/sh_css_sp.c +++ b/drivers/staging/media/atomisp/pci/sh_css_sp.c @@ -420,7 +420,7 @@ sh_css_copy_buffer_attr_to_spbuffer(struct ia_css_buffer_sp *dest_buf, lines below. In order to satisfy KW an additional if has been added. This one will always yield true. */ - if ((queue_id < SH_CSS_MAX_NUM_QUEUES)) + if (queue_id < SH_CSS_MAX_NUM_QUEUES) dest_buf->buf_src.queue_id = queue_id; } else { assert(xmem_addr != mmgr_EXCEPTION); From patchwork Mon Feb 26 19:40:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Bergh X-Patchwork-Id: 206897 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp2295289dyb; Mon, 26 Feb 2024 11:43:04 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWUjQ8y9iwLz2PJqruuAAIln1vvWdwHxcK8w/9E90ZPGJnxRXRLou/gEfGNFalCVIweRK7fKt70AcROuCDl2LMiLFPW1g== X-Google-Smtp-Source: AGHT+IGJTUYqv+4TVmd3hvdZfkD87WR/OBQom9dVkv54cdgUeasZkv/xA1UUmfVgoAjgvIpduxeC X-Received: by 2002:a05:6214:4118:b0:68f:3c8c:8099 with SMTP id kc24-20020a056214411800b0068f3c8c8099mr125571qvb.58.1708976584655; Mon, 26 Feb 2024 11:43:04 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708976584; cv=pass; d=google.com; s=arc-20160816; b=zId12fiYEl/00wirhSMKfSIsBWpusDvNCTboWtjgUFNHPdXY6pWn0ewq2yK9J2x+TD CSK1qzwi44IzNHw4C5MJV/7ZWeQvpEwEY/K9LEys19EF6c+Lec4tMOj6LVD/waTQUAEP VjIFzzTdiCvaMpXyT+tNQjTfdv6yLOOTLBA7OfZ9lzH8dS2oz8JUVrZ1gugZcUHUMDVS IKIZ27KkSptFf6LQHPaDJN5DyvAeMjxC5JnF9FeLH2jyMXRjQxAwrsEaCgkKSnGj3Wqi xRlom/c1tciRZk2azHJ18qiuzEYAWPNIOt4d4Ugu35g2WkYVuHL5fc5TXhu3FNw1PpCa O2JA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=WGuvBVp+m5k1ETtOCwdqge3NqphlJ/HDGkIyhZQL1/0=; fh=DMVaAVEZZf+M/ufp3MS0N1Zj5LLtaqm61EmPYAk3e5c=; b=r2/uuiO76NIjPxwjVRcZv52ZzOaH+5gxB/BAm7z87WkX9hc4+OdR7SpRCQK15tpCPZ n8rTEh1CLMCLB6RjSClVQ6J8h1NFiegBmWLX3vWcem5Gy3F+TRkYhXzeVb16mWIUB0aU av2rEZpf7naTo4yV/QPN8sZyGgADvh3w9AeS3tW1EjVWTSaQ39UIkBpnB5n8PHJi8zs5 lrvJxDyC8AuLWeONcuEnYvvREQCJithF93vYEasJuFrG9N2oAbzuLD6W32L+nQ2Ygcwc rQNIMeotoGrcZ4jsX/ecJ+to+6bBd795dTnxL4U3PLZLoEn8BkG8rQVD4Bupnl0YxAnX +1UQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=gBq8PWGz; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-82257-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82257-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id g4-20020a0562140ac400b0068f9ce3fbeesi5993746qvi.362.2024.02.26.11.43.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 11:43:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-82257-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=gBq8PWGz; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-82257-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82257-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A8E751C25268 for ; Mon, 26 Feb 2024 19:42:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C188A130ACF; Mon, 26 Feb 2024 19:41:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gBq8PWGz" Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54057131737; Mon, 26 Feb 2024 19:41:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708976486; cv=none; b=WJmeoCsdI9VaB3Fnn85f/qV64VESkDLbRFs270XGDCT3r3iXOhoakSU7CbnGftUztavCU1WH0Pota6kzu+O5sNTvjahCLMQ2XGWhLvvumfnqM+D+XgS+uHwPhbZQv8kO9aQCufXFywqTIdOwiTdtlX3C4QSEclKhf91VOIgNd0k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708976486; c=relaxed/simple; bh=3LXynpJz35uPYPFQErKfp01pNySda26m/V0BEYGIDxg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=mMbyiJLExeRgJmlD5dKrmuOemQY7nwef3Y7vTS98/P0lZL4pTXJwIS88iS8pFjigzSRcsgdn6pkXrg7THU8eVXVOtn3BMkJga3sAfiNbeTNhLvlqRxqUaY6YwZHwlI29QICghiv905kdQP729d6E9UQ8zuJRHexkK7kJpnrcF2M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gBq8PWGz; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-512f7332252so2500948e87.0; Mon, 26 Feb 2024 11:41:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708976482; x=1709581282; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WGuvBVp+m5k1ETtOCwdqge3NqphlJ/HDGkIyhZQL1/0=; b=gBq8PWGzKKxAKY+lTs7glVlVMRCTuEz8188Kmt9TdqbuEPuZlYrg9N+29vikhpjXZg ZBiBEX/oRYLq/X3tIrt610qwQzaJj80U4Fgy03i8e3O774zPKUITfKg1XYQeTTzEvkHY 5uKSCpn2hkWc217yfSSoT6p9P74gRV2elorOJW2Xuc+QYfbInWl/tqk9UZpJ3yT8VgwC Pl7AIrjkG+sAQH9T+FBmc6kpq1ylFeAg2TzOtDmS5i4Yx9GbaFmlIxCuZ628iJca02v0 YS61ucnCXqVjaRUl1qSn5nBIvAXjE/84zSk52HIEivPKekZeDB243gXauywF+pbsHuaw 6uXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708976482; x=1709581282; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WGuvBVp+m5k1ETtOCwdqge3NqphlJ/HDGkIyhZQL1/0=; b=PTjnUFAHa4c1eTqe2vFbhTGk6LEsZaJ1G+aE0ZsjjpnqYCjhSE9IIrEtnMRJu4btFE WLO2kPlwH3oizrvtKUgdSKMWq4GaKRP7P9ysuvyOfZl0tAjx+dhV7pWS1jpIVkH4oSqJ BgaECyXZy69b18de3R5MMgyik1m+yCUHWvGLB9ldPzrPykfK2NsmiRf37elEjKEa7fBQ dasYDlee5Ukfdgf46VO9VUNLOnCxjibVuFZuMBt+2oTFxNItUTkjYfEG08QqPGVc0VbF ekDDkmWVlPwGoBXZJUU3yeAHzF6Ae585QIn7NinV9buuf48M+swvFfHlTAs4bDSLpuLp dqJQ== X-Forwarded-Encrypted: i=1; AJvYcCXSL0VyVqZY9C0EtRvIvRtWBTCSBXIm0GrFTXH+r+PVEmFBduT3lvK1q7Vp5Nrapy3NgRUAiuXUOZdTbwb0BiMCbFuAFnngab0FYj80OJw7TjoKc/v3R6pCC4IVXaDzmc06Y9pHV/PEC4w= X-Gm-Message-State: AOJu0Yy6Tqa2fPwJFJ44frQC8j6GOk5oFCCj6cEHP/rcUTxrAMOrYwW4 CNQdB3x9m+C9Zi9m469dbcvLZrrsYvOD81dRACeTXQfG7hQSOjcqybdYJg2r X-Received: by 2002:ac2:5b0c:0:b0:512:bec4:19ae with SMTP id v12-20020ac25b0c000000b00512bec419aemr4640366lfn.60.1708976482486; Mon, 26 Feb 2024 11:41:22 -0800 (PST) Received: from localhost.localdomain (c83-255-24-248.bredband.tele2.se. [83.255.24.248]) by smtp.googlemail.com with ESMTPSA id e21-20020a196915000000b00512ffb9bae9sm332328lfc.143.2024.02.26.11.41.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 11:41:22 -0800 (PST) From: Jonathan Bergh To: hdegoede@redhat.com Cc: mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Bergh Subject: [PATCH 5/6] staging: media: atomisp: Remove unneeded return statement from void function Date: Mon, 26 Feb 2024 20:40:22 +0100 Message-Id: <20240226194023.69070-6-bergh.jonathan@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240226194023.69070-1-bergh.jonathan@gmail.com> References: <20240226194023.69070-1-bergh.jonathan@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791991830817717643 X-GMAIL-MSGID: 1791991830817717643 This patch makes the following change: * Removes an unnecessary 'return' statement from a void function implementation Signed-off-by: Jonathan Bergh --- drivers/staging/media/atomisp/pci/sh_css_sp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/sh_css_sp.c b/drivers/staging/media/atomisp/pci/sh_css_sp.c index 281cbbb89a14..3ccbfcc553fb 100644 --- a/drivers/staging/media/atomisp/pci/sh_css_sp.c +++ b/drivers/staging/media/atomisp/pci/sh_css_sp.c @@ -642,8 +642,6 @@ void sh_css_sp_set_if_configs( *config_b; sh_css_sp_group.config.input_formatter.b_changed = true; } - - return; } void From patchwork Mon Feb 26 19:40:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Bergh X-Patchwork-Id: 206898 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp2295340dyb; Mon, 26 Feb 2024 11:43:13 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXbqn35RWuZ7td93QYBz61ccAhxOW/rmWDYV7LfwP6P6xxKgf2wk6OfffzMF0ZG7YWL56kM8fOtw/nDvB7AYWsn/VqSxg== X-Google-Smtp-Source: AGHT+IF7B2wb/0dsvuYKCMocotRwpgoWiQ0jWwuipGst5IHmgKgYz0TShQ5/cAcBYPh+rxuBdyHl X-Received: by 2002:a05:6808:342:b0:3c1:333e:683b with SMTP id j2-20020a056808034200b003c1333e683bmr112689oie.20.1708976593619; Mon, 26 Feb 2024 11:43:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708976593; cv=pass; d=google.com; s=arc-20160816; b=Lh6dsgubGFsjqTMB1Sg4ZAH02uhQvuNErMVhBqxiK1gqdG+e8rz9H+4bR9JVmZCLkJ LaU/OalTB/vZafNU+yKPqzqHb9xNcZoxqNgR1Bjl4Gu1yyXRgrqaHi/3+O0luF5u0bNp i/nQ02LULR7DToK5XBVWW01cNCUYZ+vF2JmVAcIYb8l2NDG733eoiFHwYeMRDiG3yQPN /T0VZCsNKrV4jvP02qaB9OQKry/Yl12nrbNnGucL9Sc3mphAse4UuAZYRqY+lBQ0ovOh 2m0WOAxKUOi3LiDwP36O3AiMmXZRyeV5HI7mMuJ2Qt65HcW51WueyZm3Xy7oSHI8J776 k0kA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=IhDLivYLv20Hp6P/4VgFRH+Rwf5bze2xAXsRl5m2rQk=; fh=jVTdIPW5LrkZGK0iX06ZsgjgC4rNHcdhjWblRcsOF40=; b=S+ehnzxfgpm3ArXd6/MtcTII30wstCacdr7OuJXf61RulXlsF7OrK/YMwO1F7AxCe4 5NxZbY2vV6tpfMiQ0zOz5NESb6pSSaXD9hTpR31LH5NRLKbbNgGIZklYZ5DyzRRk5EIO HH7kKVrRVzAABAfMJsLtCFExSsk8nefufHIxEMvj3leFGgpdMOzjr8xdzFi+GumLxp9O VwnzDIrmdjgtWuLUkd+zBV8poGrH6vLtMOEtnAHkmN0KfbuLMtFA99ka3t5bEinKatBs r0cLn/MagLfPv3SxbUuvk85OeU+qI4wZ4Ldv1N7FIrULNcrOllEdblJ4s3yA585kRkDs 0iIw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=fgvLdTHa; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-82258-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82258-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id g4-20020a0562140ac400b0068f9ce3fbeesi5993746qvi.362.2024.02.26.11.43.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 11:43:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-82258-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=fgvLdTHa; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-82258-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-82258-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B2D561C27F67 for ; Mon, 26 Feb 2024 19:42:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 12317132463; Mon, 26 Feb 2024 19:41:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fgvLdTHa" Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A0E7131E26; Mon, 26 Feb 2024 19:41:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708976489; cv=none; b=LL86H9oUzHcjfZF8QZXoWg+s/pW16Fe6ZsL3hhTmmwZXCHaTRrm+TuZouJTV4mOKKzRTPzVI4AhK1Iw6o+UadMRTz3BgLQC1Aa4XuY+shtnY8cXhZEBzNGcRHV2LYHo5BG4i2gRBqc0Glk9fehzvuzj8gm8+O0RO4Uea5RWf/MI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708976489; c=relaxed/simple; bh=3QnEnAIOiL8y00WVgkVmOXEG1hPhqpBEJjwAvRXFpR4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=eNZGwjXmeRSnLFFp79FwG1QFyVlL/+qWmiIvDprkuIZmPG122fT4tWStz1Zilvjz2Ei2K4cffu5gdzPXk4ZpC66nqIK3FJFLYyKSAF3hJWyMerzZYZVFe8jW+H+en795TejWw9uusM3iSxdtaRpYSXyi/mZzQ08/npr+Spz55qY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fgvLdTHa; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-512e568607aso3423861e87.1; Mon, 26 Feb 2024 11:41:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708976484; x=1709581284; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IhDLivYLv20Hp6P/4VgFRH+Rwf5bze2xAXsRl5m2rQk=; b=fgvLdTHaeE0sDMCgQKcZ/7cL1aldO7nnz4tB6QiDVMrr3WCnfhbMhc4FvWzTwO4EIr vYSMpLaZ/bkqyUn1raeXlu32evCz3W9oUTOj/cuABwvtNXamIKor/z85gxsmJPLLL8QY UgKWjMcAPqGnGra5nlcJD4o9ppz4hYKvXpDm2srhPAfw/nVX85oSo7JoDKcfbJhoCdxS XLQ/tGiv71tWTsXmtS8DmVtXrsdVtTnedoRnVBfULt4RGeN+bH3mRtiQNxDcg4TyD+r1 +a4fsyXgcz2xxkimOZKQxScuZXOittoNQifDPFWO5rTI3/2c75oDEy26MqVpiUtYqb/1 aoaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708976484; x=1709581284; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IhDLivYLv20Hp6P/4VgFRH+Rwf5bze2xAXsRl5m2rQk=; b=Ou99HYCBZextA37GMVTl8KD9uTePxgZnyzE/slM7yZBIvMOAMX9+mdTfm1SsVPHSgM qOiYz56babD/74gduKLNon7yCuYsTqpgYH/pjqOfFFfFb3yUuzAs3UBJv1y9sQCihXN3 DM06t1h+pS8q5EohVfC3sP76I7LVu4H7+xKQouJf1sMRoNIePhsQd1XGQ5RHQ4qoxDGt idx+/1l/dm7sc1DfopN8CIPFtSWF0H0xXPUuKum9db6KUpaai7yRx9VmTbEMZ99rC3ii uSfwhk9QtzWQiiTIAZvEa3ekuWy+oD79dsrfzTJDYZJsYaMNOMQ5uyHAz5ZU5ZXnjUch Thmg== X-Forwarded-Encrypted: i=1; AJvYcCUU0fBVSkeiHE7NjvhYeVHZN6Aqc974XhCiZ/OdTunVrEn4gOR+RTaiVNdcu6MWtWAqrpiRJOQ0gbL+i/jDj+KTt9rK/fRGVKPG15PMLO6w70A14oAP9UdtioyKDSo/UyX/7usChpcZoPI= X-Gm-Message-State: AOJu0YzmdifqslmWRkS9kKnDXH63AQw4wHDa0BkAEj86tq/gLrV9zKyA CVQ7uu5Y4ETUrIz+4onHVXM9QdX8VEy7nVmHDEiUuWjFAH2jNbuD X-Received: by 2002:ac2:5584:0:b0:513:349:33fb with SMTP id v4-20020ac25584000000b00513034933fbmr269940lfg.16.1708976484279; Mon, 26 Feb 2024 11:41:24 -0800 (PST) Received: from localhost.localdomain (c83-255-24-248.bredband.tele2.se. [83.255.24.248]) by smtp.googlemail.com with ESMTPSA id e21-20020a196915000000b00512ffb9bae9sm332328lfc.143.2024.02.26.11.41.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 11:41:23 -0800 (PST) From: Jonathan Bergh To: hdegoede@redhat.com Cc: mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Bergh Subject: [PATCH 6/6] staging: media: atomisp: Remove old commented code and fix multiple block comment style Date: Mon, 26 Feb 2024 20:40:23 +0100 Message-Id: <20240226194023.69070-7-bergh.jonathan@gmail.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240226194023.69070-1-bergh.jonathan@gmail.com> References: <20240226194023.69070-1-bergh.jonathan@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791991840661182246 X-GMAIL-MSGID: 1791991840661182246 This patch fixes the following minor code and code style issues: * Removes a block of commented out (unused) code from the src * Reformats various multiline block comments to meet the kernel code style guidelines for block comments Signed-off-by: Jonathan Bergh --- drivers/staging/media/atomisp/pci/sh_css_sp.c | 87 ++++++++++--------- 1 file changed, 48 insertions(+), 39 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/sh_css_sp.c b/drivers/staging/media/atomisp/pci/sh_css_sp.c index 3ccbfcc553fb..2999d44d61d1 100644 --- a/drivers/staging/media/atomisp/pci/sh_css_sp.c +++ b/drivers/staging/media/atomisp/pci/sh_css_sp.c @@ -108,11 +108,6 @@ copy_isp_stage_to_sp_stage(void) sh_css_isp_stage.binary_info.iterator.row_stripes_overlap_lines; sh_css_sp_stage.top_cropping = (uint16_t) sh_css_isp_stage.binary_info.pipeline.top_cropping; - /* moved to sh_css_sp_init_stage - sh_css_sp_stage.enable.vf_output = - sh_css_isp_stage.binary_info.enable.vf_veceven || - sh_css_isp_stage.binary_info.num_output_pins > 1; - */ sh_css_sp_stage.enable.sdis = sh_css_isp_stage.binary_info.enable.dis; sh_css_sp_stage.enable.s3a = sh_css_isp_stage.binary_info.enable.s3a; } @@ -411,14 +406,15 @@ sh_css_copy_buffer_attr_to_spbuffer(struct ia_css_buffer_sp *dest_buf, */ assert(queue_id < SH_CSS_MAX_NUM_QUEUES); - /* Klocwork assumes assert can be disabled; - Since we can get there with any type, and it does not - know that frame_in->dynamic_data_index can only be set - for one of the types in the assert) it has to assume we - can get here for any type. however this could lead to an - out of bounds reference when indexing buf_type about 10 - lines below. In order to satisfy KW an additional if - has been added. This one will always yield true. + /* + * Klocwork assumes assert can be disabled; + * Since we can get there with any type, and it does not + * know that frame_in->dynamic_data_index can only be set + * for one of the types in the assert) it has to assume we + * can get here for any type. however this could lead to an + * out of bounds reference when indexing buf_type about 10 + * lines below. In order to satisfy KW an additional if + * has been added. This one will always yield true. */ if (queue_id < SH_CSS_MAX_NUM_QUEUES) dest_buf->buf_src.queue_id = queue_id; @@ -514,7 +510,8 @@ sh_css_copy_frame_to_spframe(struct ia_css_frame_sp *sp_frame_out, frame_in->planes.binary.data.offset; break; default: - /* This should not happen, but in case it does, + /* + * This should not happen, but in case it does, * nullify the planes */ memset(&sp_frame_out->planes, 0, sizeof(sp_frame_out->planes)); @@ -949,9 +946,10 @@ sh_css_sp_init_stage(struct ia_css_binary *binary, sh_css_sp_stage.isp_copy_output = (uint8_t)args->copy_output; sh_css_sp_stage.enable.vf_output = (args->out_vf_frame != NULL); - /* Copy the frame infos first, to be overwritten by the frames, - if these are present. - */ + /* + * Copy the frame infos first, to be overwritten by the frames, + * if these are present. + */ sh_css_sp_stage.frames.effective_in_res.width = binary->effective_in_frame_res.width; sh_css_sp_stage.frames.effective_in_res.height = binary->effective_in_frame_res.height; @@ -1028,10 +1026,12 @@ sh_css_sp_init_stage(struct ia_css_binary *binary, initialize_isp_states(binary); - /* we do this only for preview pipe because in fill_binary_info function + /* + * We do this only for preview pipe because in fill_binary_info function * we assign vf_out res to out res, but for ISP internal processing, we need * the original out res. for video pipe, it has two output pins --- out and - * vf_out, so it can keep these two resolutions already. */ + * vf_out, so it can keep these two resolutions already. + */ if (binary->info->sp.pipeline.mode == IA_CSS_BINARY_MODE_PREVIEW && (binary->vf_downscale_log2 > 0)) { /* TODO: Remove this after preview output decimation is fixed @@ -1067,20 +1067,22 @@ sp_init_stage(struct ia_css_pipeline_stage *stage, */ const char *binary_name = ""; const struct ia_css_binary_xinfo *info = NULL; - /* note: the var below is made static as it is quite large; - if it is not static it ends up on the stack which could - cause issues for drivers - */ + /* + * Note: the var below is made static as it is quite large; + * if it is not static it ends up on the stack which could + * cause issues for drivers + */ static struct ia_css_binary tmp_binary; const struct ia_css_blob_info *blob_info = NULL; struct ia_css_isp_param_css_segments isp_mem_if; - /* LA: should be ia_css_data, should not contain host pointer. - However, CSS/DDR pointer is not available yet. - Hack is to store it in params->ddr_ptrs and then copy it late in the SP just before vmem init. - TODO: Call this after CSS/DDR allocation and store that pointer. - Best is to allocate it at stage creation time together with host pointer. - Remove vmem from params. - */ + /* + * LA: should be ia_css_data, should not contain host pointer. + * However, CSS/DDR pointer is not available yet. + * Hack is to store it in params->ddr_ptrs and then copy it late in the SP just before vmem init. + * TODO: Call this after CSS/DDR allocation and store that pointer. + * Best is to allocate it at stage creation time together with host pointer. + * Remove vmem from params. + */ struct ia_css_isp_param_css_segments *mem_if = &isp_mem_if; int err = 0; @@ -1120,10 +1122,12 @@ sp_init_stage(struct ia_css_pipeline_stage *stage, } else { /* SP stage */ assert(stage->sp_func != IA_CSS_PIPELINE_NO_FUNC); - /* binary and blob_info are now NULL. - These will be passed to sh_css_sp_init_stage - and dereferenced there, so passing a NULL - pointer is no good. return an error */ + /* + * binary and blob_info are now NULL. + * These will be passed to sh_css_sp_init_stage + * and dereferenced there, so passing a NULL + * pointer is no good. return an error + */ return -EINVAL; } @@ -1257,8 +1261,10 @@ sh_css_sp_init_pipeline(struct ia_css_pipeline *me, SH_CSS_PIPE_CONFIG_SAMPLE_PARAMS << thread_id; } - /* For continuous use-cases, SP copy is responsible for sampling the - * parameters */ + /* + * For continuous use-cases, SP copy is responsible for sampling the + * parameters + */ if (continuous) sh_css_sp_group.pipe[thread_id].pipe_config = 0; @@ -1539,7 +1545,8 @@ ia_css_pipe_set_irq_mask(struct ia_css_pipe *pipe, assert(pipe); assert(IA_CSS_PIPE_ID_NUM == NR_OF_PIPELINES); - /* Linux kernel does not have UINT16_MAX + /* + * Linux kernel does not have UINT16_MAX * Therefore decided to comment out these 2 asserts for Linux * Alternatives that were not chosen: * - add a conditional #define for UINT16_MAX @@ -1638,7 +1645,8 @@ sh_css_sp_start_isp(void) (unsigned int)sp_address_of(sp_sw_state), (uint32_t)(IA_CSS_SP_SW_TERMINATED)); - /* Note 1: The sp_start_isp function contains a wait till + /* + * Note 1: The sp_start_isp function contains a wait till * the input network is configured by the SP. * Note 2: Not all SP binaries supports host2sp_commands. * In case a binary does support it, the host2sp_command @@ -1648,7 +1656,8 @@ sh_css_sp_start_isp(void) * received, the SP starts configuring the input network. */ - /* we need to set sp_running before we call ia_css_mmu_invalidate_cache + /* + * We need to set sp_running before we call ia_css_mmu_invalidate_cache * as ia_css_mmu_invalidate_cache checks on sp_running to * avoid that it accesses dmem while the SP is not powered */