From patchwork Fri Feb 23 23:16:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Torokhov X-Patchwork-Id: 205722 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp894290dyb; Fri, 23 Feb 2024 15:16:44 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXgKmcO+CYsPkEL9MCcHUUMPd5EIjH8RndsGYDfXV2KShSX5wA2pDgO9ww1N7ZwY9Pf4OPkbMsKo1hvF+OJLNcusTWH6Q== X-Google-Smtp-Source: AGHT+IFzrDTYh/MS9mC97P6O8nmLTk2ad3CYO5P6VtGnpADvnaMAHD3/LP59uF2UJq3QS2qIK5wO X-Received: by 2002:a17:90b:1110:b0:299:1cce:f3c3 with SMTP id gi16-20020a17090b111000b002991ccef3c3mr1580769pjb.7.1708730204492; Fri, 23 Feb 2024 15:16:44 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708730204; cv=pass; d=google.com; s=arc-20160816; b=kk+nxogZQE84MyYw7qyQo9bHt++xXW6j0H0y9ESbN+n4tDUbbie7NEAvw0N90QdMa3 Math+AxuP2EdqAeIUoIm8zFYFOh3Ay1OpCuC4sSoiiblhBRX6781ahyohVU1miMXYbpw IxU7BdR5XEotnpL5Ic7aHmY6Kfo7pJsrGCyLKN3CRjZqWZQXydO0LjggfUUbRPXupGTn 68CC6gVT+z8XZfL7lLmpojq5MWHveZAuSa8S0upUETP7uboYUwAVbgFLrg1rdj/8gtX/ D8B56UGixF7380gLH/4qO8ITd417Ed4+oJxywDps3D81hMMjvvoqrTFLRcvVaEvt/DZn Yd/g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-disposition:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:message-id:subject:cc:to:from:date :dkim-signature; bh=ap5jfynKUwvFrOMjr8+smc5ih4W+k0wxlpnBX6ZIbOw=; fh=MR0V0zkiv3bgP+/EoKrd71BIS/6UWjoqtb2O3SZ9Ltk=; b=kgERIqHiewtUncZVjvP+KKE1vZD2zMrSFjt4ohrpgzSYlMjiga/LazDxo32yvt1tmO svDH5tsJnbeFzPAQwh9Nrtm5U7179mVCV5k/qAfEbjMiuslxKr0n09TvbGcltrwuoFke jCjZeVh701eULp2QHuWpAZP8+QrCbgHvtZxNjnCVMKmqPi5O+F0NOSNR/txSMLcQJSsH 6iRXgxsr5n6iNqFbBXMoviXetLETz77mxv3+XsreIoVPm9ByF65d4iXXBC5bhTeBrRYi 8YL15p4SxMwDFAdDSRSrcZJbPIdUXCxNdqK5qNt0lQvxNG9P51Xr0d6Ye0EDjvtE1E4h XC2w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=cBuw6Mj5; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-79303-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79303-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id co16-20020a17090afe9000b0029a8498e2c8si1267834pjb.8.2024.02.23.15.16.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 15:16:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-79303-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=cBuw6Mj5; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-79303-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79303-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4AAE1283BF8 for ; Fri, 23 Feb 2024 23:16:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6161514E2C6; Fri, 23 Feb 2024 23:16:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cBuw6Mj5" Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6252C14CAD1; Fri, 23 Feb 2024 23:16:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708730177; cv=none; b=kKlinBcXTf6x3Dfj7FjVR3SRUZZm5iXlKfqr/8lpfan5Y7J1gwyCmyVC1s0BBPBT+ZnvQT9bT8HVr2HutI473dK3WjJTetqLfpswdO+Lxn/lVuUic6BqDw6JZ2/GUiYNFQr+0FKJw95BfsgzVCAPEH4+0Fs4jeDJVIaGVaDAYOE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708730177; c=relaxed/simple; bh=dK1BjyOXGfLwN5ILE7hkJADDu3le/Lw6z1zJA5AtyVk=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=tP+gCul+tlK684WpH19abQshR7Zalsh3NNxfc3fhCppCFPdoVljt89/OgnzZa+KXdNBoxr9Rf+DccGUel1lzxr3e/m3VLdbm1WMVTqTZUMjPsC/azngmbJe8a6P/2QNle+b9m8omDHWE87mFzHrZIs1JWajco4E7CS/WMzvyU2o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cBuw6Mj5; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1dc3b4b9b62so12169735ad.1; Fri, 23 Feb 2024 15:16:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708730175; x=1709334975; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=ap5jfynKUwvFrOMjr8+smc5ih4W+k0wxlpnBX6ZIbOw=; b=cBuw6Mj5RlWHzQ1K4BrIsqytuOq/nV9w44hac/GsD4ak8dOFhr0CyUWYB+2s0Epsnt iNj04XR4ecoZ7IWJRexbRYV9GI1FXRXACa7W2JnQHlJ3BXOHBmeUXG/ad2kD/bWInd4q sgagdHAH5mfZ8YPU5YtJgFwLxEqkejkV6BJDR2/iJEQrP3rzJUv/g3S4sZcUX1FuVMSW o4m07EYYkR0VrD/W3kyaCYEJuZD++5JYawGAt/BN6aI5V4ALZtPKiI4nsIvsUHEk3gBJ NQUwRSDTyrTGsNS3mNFSinAfCzKQvPeTZ/3M0MZpUGrl2v+I7fDz4chXFjuVNh5mQlrd Mi5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708730175; x=1709334975; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ap5jfynKUwvFrOMjr8+smc5ih4W+k0wxlpnBX6ZIbOw=; b=IYD33roeWkx5jnZF2r6jQ+B5IJ8LIgP4NS7JQ6NqLbDXDCa0HegkD7nImr0CctpkA6 YbaUo85fkb1plmYDIj/TdlPc7KFcaXMVMg8q37swCIixyXLMlKC7cIsA7E6L8Z/rktEt xK9iSg20R/sdwuyDAa5f10wmq3cBYW3MskGyq3TdMBxl97cp7UMhJzK4wB4WVUo0Af3N rnxbtcWVTNPKoYfoD+iJOmdo62jsUvbJcDqor097IuzxN4KyujI87Ed3SAYTOHfgUu5J y4QL6GID1omS2QP9kvVlAPmzvxPg+w3uecEbowgHYZpXGKdqtnNgnyXNS9AaHKAXkDc3 ZGqA== X-Forwarded-Encrypted: i=1; AJvYcCVV64CS7RMeoSbXUTE2c0AN0w97jMH0fEYI2vjJEcrp/nOljbjVtH6icghsyVYVJXWtmZYrtojBZyuk9AE6zZzKhPU5FK/xsvmsRqOH12ee3UYcmro593cfD/U1KDK7uPDmvTxS2lXwSCU= X-Gm-Message-State: AOJu0YzYUf9PJHKSIxU7YdroMdgqIl0W2P+v/4+tN9CqIeCWTXeiQECJ H0vP0a0MkhBiliOkDrldO48Fua63mxVUoZpYfHnmJdweFR7C+FwB X-Received: by 2002:a17:902:db0a:b0:1db:c113:29bb with SMTP id m10-20020a170902db0a00b001dbc11329bbmr1480811plx.34.1708730175455; Fri, 23 Feb 2024 15:16:15 -0800 (PST) Received: from google.com ([2620:15c:9d:2:f0c6:1cdc:5abd:78b8]) by smtp.gmail.com with ESMTPSA id je5-20020a170903264500b001d8f82f90ccsm12119196plb.199.2024.02.23.15.16.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 15:16:15 -0800 (PST) Date: Fri, 23 Feb 2024 15:16:12 -0800 From: Dmitry Torokhov To: Jiri Kosina , Benjamin Tissoires Cc: kenalba@google.com, dianders@chromium.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] HID: input: avoid polling stylus battery on Chromebook Pompom Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791733482877727089 X-GMAIL-MSGID: 1791733482877727089 Internal touchscreen on Trogdor Pompom (AKA Dynabook Chromebook C1) supports USI stylus. Unfortunately the HID descriptor for the stylus interface does not contain "Stylus" physical collection, which makes the kernel to try and pull battery information, resulting in errors. Apply HID_BATTERY_QUIRK_AVOID_QUERY to the device. Signed-off-by: Dmitry Torokhov --- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-input.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index e4d2dfd5d253..05f451390a3b 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -426,6 +426,7 @@ #define I2C_DEVICE_ID_HP_SPECTRE_X360_14T_EA100_V1 0x2BED #define I2C_DEVICE_ID_HP_SPECTRE_X360_14T_EA100_V2 0x2BEE #define I2C_DEVICE_ID_HP_ENVY_X360_15_EU0556NG 0x2D02 +#define I2C_DEVICE_ID_CHROMEBOOK_TROGDOR_POMPOM 0x2F81 #define USB_VENDOR_ID_ELECOM 0x056e #define USB_DEVICE_ID_ELECOM_BM084 0x0061 diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c index c8b20d44b147..e03d300d2bac 100644 --- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-input.c @@ -411,6 +411,8 @@ static const struct hid_device_id hid_battery_quirks[] = { HID_BATTERY_QUIRK_IGNORE }, { HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, I2C_DEVICE_ID_HP_ENVY_X360_15_EU0556NG), HID_BATTERY_QUIRK_IGNORE }, + { HID_I2C_DEVICE(USB_VENDOR_ID_ELAN, I2C_DEVICE_ID_CHROMEBOOK_TROGDOR_POMPOM), + HID_BATTERY_QUIRK_AVOID_QUERY }, {} };