From patchwork Fri Feb 23 19:49:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 205692 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp846757dyb; Fri, 23 Feb 2024 13:10:32 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWf6hDOEMPwg7SU+Snu0fniqZQxBx7bWfdMQIOoIW/5ng2836rLUUfuRjrGjEzI59+BspmHWwYHfEy8GwsC4gTs13Mp6Q== X-Google-Smtp-Source: AGHT+IGK3MOXWVN1N1+6ImcQ2SsBzcpdTb30lR1FO8rw73QzR/YhcQH+JOLua4DNxWJ35L/E15MW X-Received: by 2002:a05:622a:1753:b0:42e:616e:e15f with SMTP id l19-20020a05622a175300b0042e616ee15fmr393672qtk.0.1708722631967; Fri, 23 Feb 2024 13:10:31 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708722631; cv=pass; d=google.com; s=arc-20160816; b=pTl9j2D1OgQI9jT68Q9Kq/yO8l7Y2Vt33VhtkZVqoFeRW3b/PiPEWKtAKHrQa73IYw IEWUt9RJ73bE6WQXUsaX9rnLrH8wSFMRO5IWOrjIdvlt6lX1SPpCSg+ozxTL4zzHlz7O rJ/ofAFP/ObgYCdQG2WeNeR32THVeAEwzg52w4la4uqtsIgKzVvrLoLtXWJQlPuvBxJ3 x40TgQqQE/U8E4RlwCh5XGCixN0K8uPYvij5PMUgVkLc/FixDiHoSV1VOWOQdj05WKO9 HwsWjQ7e4AVjVAn7QD9y0LHdf+Ujv/IudKJ5xfNF8NzjlS92k5DlLHoaWwmk3OgnWAA2 LvPg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=8OIwTJrVltC3Ef9A3y2aYXgTLh66b7IgUt2PBfwRyBI=; fh=NrWLvEVUW8ufGou/ZOuWZl9yKC+ByU+oxgRUdXMV2yI=; b=U/xuLV0T5NliX+G5vCBSsxlOIFftvXvKZEF1YCs7YUHfYaKcNIhcZUnIohIk1CmQ9x YWOCbdfrux+NvZ3d8MWloY0wr6ss18/kXrQOeoWWlwZi2l4C1xkDkcT9pGbc4MjY1aFB QpaXsYUA1uSudBeNyQzObLhOwCImq8Nc9RLNSJyaqivtzLnMlClmN6dwmtPh1vstnBLc VO5ABap1y7ss/1XaM+fm5hx9NOxrvx4ZJHYTod+LuYx3H6eqDAAcs64azwozPngtfMbC Q6TDZSAXtOd7XOn98jAHgOma96zfT8MBdiSaEV73e3hfQb7qptfEOaL9GqfReWy6W+xk n5Fw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=h0wh6rG4; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-79061-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79061-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id o13-20020ac841cd000000b0042e2a84ec96si8052451qtm.99.2024.02.23.13.10.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 13:10:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-79061-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=h0wh6rG4; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-79061-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79061-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 18E9E1C24772 for ; Fri, 23 Feb 2024 19:53:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 15D9D14CAC0; Fri, 23 Feb 2024 19:51:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="h0wh6rG4" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B29AD149393 for ; Fri, 23 Feb 2024 19:51:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717881; cv=none; b=axnxPaQPsceBfhJAccecNWUg0aOgc3T5l7PwkzrLUDnza3zifMER16DEKHP7tSFY9mjThFXjh0cqpISvVAe/zEH86cx7PPvv0U+Hhtop7YZXL6abXlrncuOa95/oefCxc7p73r26OrmXQhlxfzMRDm96UmmRy2Bpc65jAtL7X5I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717881; c=relaxed/simple; bh=Wj2D0oBH1J9oTB67/0tbEOo9q7DzAHlzlDkwpbhKu14=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GZzirf40fbOu8kM4u0oK52RLZQxbDa4Tjpe2V2kI/s9FVwYPPkHqS0ux6/1xVxexS7y1DJZdB0j5XzXXRCu4TE+wLef9JBsW1kmAWyMtjaawGcmd0jF2aQgcrHgs6ybpuEvq5TxPFjSdb4qlL/ImZt2r2j324smwdU+X1ulvm8o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=h0wh6rG4; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708717880; x=1740253880; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Wj2D0oBH1J9oTB67/0tbEOo9q7DzAHlzlDkwpbhKu14=; b=h0wh6rG4xI7UdJN6Yq86nPJN+fhEvIoJ7IpAY531V97qvdwdYmccJER5 +2h313nLl3jR1DN8E85cYS9fdeRvOaVWCliArOQObZicEF5J9jL7KQyZl 3mbouiNhjMAM7yPDl/nRND2BBtmHHrUAwAhxssnJuuUMnKdjyiJd9ByeA lLhM1GXjlPji3n33ENctX7RJJ+nx8Uw+ke84CyUVMSuYuuwLmx/Gyfe3i rC7oSHX6mJv3S9d7swQlb1zlS0qij7nzKvA2reJ5LmTZzUYj2AeYOpQPs PYwCjBnDcL3h0m+UNsa8YvDDTn4b4MyMtKv3PIq61QAeJMZIThUGjUDKD A==; X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="6837326" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="6837326" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2024 11:51:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="937025652" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="937025652" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 23 Feb 2024 11:51:15 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 96B134A5; Fri, 23 Feb 2024 21:51:14 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Lee Jones Subject: [PATCH v1 1/6] mfd: kempld: Replace ACPI code with agnostic one Date: Fri, 23 Feb 2024 21:49:50 +0200 Message-ID: <20240223195113.880121-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> References: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791725542560974319 X-GMAIL-MSGID: 1791725542560974319 There is no need to include and use entire ACPI stack in the driver. Replace respective pieces by agnostic code. No functional change indented. Signed-off-by: Andy Shevchenko --- drivers/mfd/kempld-core.c | 38 +++++++++++--------------------------- 1 file changed, 11 insertions(+), 27 deletions(-) diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c index 5557f023a173..99c8656e723c 100644 --- a/drivers/mfd/kempld-core.c +++ b/drivers/mfd/kempld-core.c @@ -9,11 +9,12 @@ #include #include #include +#include #include +#include #include #include #include -#include #define MAX_ID_LEN 4 static char force_device_id[MAX_ID_LEN + 1] = ""; @@ -425,26 +426,6 @@ static int kempld_detect_device(struct kempld_device_data *pld) return ret; } -#ifdef CONFIG_ACPI -static int kempld_get_acpi_data(struct platform_device *pdev) -{ - struct device *dev = &pdev->dev; - const struct kempld_platform_data *pdata; - int ret; - - pdata = acpi_device_get_match_data(dev); - ret = platform_device_add_data(pdev, pdata, - sizeof(struct kempld_platform_data)); - - return ret; -} -#else -static int kempld_get_acpi_data(struct platform_device *pdev) -{ - return -ENODEV; -} -#endif /* CONFIG_ACPI */ - static int kempld_probe(struct platform_device *pdev) { const struct kempld_platform_data *pdata; @@ -458,10 +439,16 @@ static int kempld_probe(struct platform_device *pdev) * No kempld_pdev device has been registered in kempld_init, * so we seem to be probing an ACPI platform device. */ - ret = kempld_get_acpi_data(pdev); + pdata = device_get_match_data(dev); + if (!pdata) + return -ENODEV; + + ret = platform_device_add_data(pdev, pdata, sizeof(*pdata)); if (ret) return ret; - } else if (kempld_pdev != pdev) { + } else if (kempld_pdev == pdev) { + pdata = dev_get_platdata(dev); + } else { /* * The platform device we are probing is not the one we * registered in kempld_init using the DMI table, so this one @@ -472,7 +459,6 @@ static int kempld_probe(struct platform_device *pdev) dev_notice(dev, "platform device exists - not using ACPI\n"); return -ENODEV; } - pdata = dev_get_platdata(dev); pld = devm_kzalloc(dev, sizeof(*pld), GFP_KERNEL); if (!pld) @@ -509,19 +495,17 @@ static void kempld_remove(struct platform_device *pdev) pdata->release_hardware_mutex(pld); } -#ifdef CONFIG_ACPI static const struct acpi_device_id kempld_acpi_table[] = { { "KEM0000", (kernel_ulong_t)&kempld_platform_data_generic }, { "KEM0001", (kernel_ulong_t)&kempld_platform_data_generic }, {} }; MODULE_DEVICE_TABLE(acpi, kempld_acpi_table); -#endif static struct platform_driver kempld_driver = { .driver = { .name = "kempld", - .acpi_match_table = ACPI_PTR(kempld_acpi_table), + .acpi_match_table = kempld_acpi_table, }, .probe = kempld_probe, .remove_new = kempld_remove, From patchwork Fri Feb 23 19:49:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 205715 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp873701dyb; Fri, 23 Feb 2024 14:21:32 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXofRw0q59iMSv5JJJkHZiNTn5qf1SBP4SvGfmmL/IsD/8URy7c0V4mbTZNQT229NE+tPDdUk0aPG+nqHIER9qa1t5JQQ== X-Google-Smtp-Source: AGHT+IHAIR4ImT/8L5sGHRabzhJJ9pgBzXxAz884hLnrbHUhCxxbsFMygjO1kTvimzYodHSEkAyw X-Received: by 2002:a17:906:140c:b0:a3e:57ed:8b93 with SMTP id p12-20020a170906140c00b00a3e57ed8b93mr1076497ejc.19.1708726891908; Fri, 23 Feb 2024 14:21:31 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708726891; cv=pass; d=google.com; s=arc-20160816; b=R1el4xklfBKh90KxwbteM65vM99WMVMhdAOIXqaZgvxYo176U6dQoJE/i4Gx+kRk+X BivWp1wRK6qFgEYKSmcmlz4JU+9qlmCxM0vR5LixyqMYxXBAyZdU/zFMZ/HY024A/qKS kGojW0SHnYhbbg3jHfTSH7SAvSoyIKwJgKIJmpBgl6fQnem+/HlOTDPwFi7rleNz9fAH /RQT5djGyBUGDJnflYG8prERj41vhIlTQr4b4CIWIWtI/h9/whyl2h92QZ1w1s+AvXxp L4wIx098JmiqCcvLBm6pSOdMofu5S6Hz8qjXPE+ya/KS0gJ1UkflRn8T++ymuWLCxRTQ ocFQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=mVR5uFk964TFXAj2jJnCmgwt9pp1Te1G3UopkeU+Mqs=; fh=NrWLvEVUW8ufGou/ZOuWZl9yKC+ByU+oxgRUdXMV2yI=; b=N2/5968LAKMeCcnNqGeXqesEg5hT5oCOk+vrSMvb0Z8jJyw1fcQYO5kaQB8coa0z+y s+rQVdmWX7dTeN0Q9/NtbeZCT1n4gz1BXAVb2+y15/2j0PpcuatqaGdEECR+VnAPk4+l 6K3KBVzfWVx+dmoywbmSiwYmjnxDfbOgUux9TmqMX3W4904UpmkIHJcaPtzWip9v8VJp HsGI/v+yqXN1w4gYQz0fmL/+oxu/0KxIeZirtTR5eoiVzBx4v6a8tr65rPh+TQtGwt6O ONSt02ILAeByAu9FK8bKwbemFFOvCIUbolSJFdOyG02MF3wgJ6xoLQkMKlNFA2oCGwnp e0jw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HlMsneYa; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-79060-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79060-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id ha16-20020a170906a89000b00a3e90882d0fsi171ejb.554.2024.02.23.14.21.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 14:21:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-79060-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=HlMsneYa; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-79060-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79060-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id DD9781F261A2 for ; Fri, 23 Feb 2024 19:52:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B0CAA14CAB3; Fri, 23 Feb 2024 19:51:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HlMsneYa" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70034149390 for ; Fri, 23 Feb 2024 19:51:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717881; cv=none; b=cpoqsg3ItDSkr0ESHiiz51IZnMVevGWiXT6g/CjX5Gn69rEj6AaXZUjw5Mv+pFH+PXvP/f3ZU5bEBMFQ6j0yBUALbnAekx6owhv1kHCVBeYVN9lF3vfTTj3cJlH510QXA7x9gYCBzpySN/lntqftdbz+a+Z2gEUVGBrbqvkCdgg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717881; c=relaxed/simple; bh=dXoPLDQhxVnWDcsR1gAg8K6LjURfRWuoMXcIAZ0xYSk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ila4LGUklJM6DEazNFs5mnb2c8uPecC2Nx5Ghi3phDBA9PT77pcoffapfgQlYs9M5wJ6dG5ZeGPQ5uhygYr2RvEaawepnXttAVXTcCAAm0hfxsNNJWGmb1i5YY9wt7upc3IWs2TtpR+1rRBN/5wK2jmSpFF+/hYHAthKV8u/LSg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HlMsneYa; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708717879; x=1740253879; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dXoPLDQhxVnWDcsR1gAg8K6LjURfRWuoMXcIAZ0xYSk=; b=HlMsneYaxN1uF0SVb85m9QJ3eyD6xBP0ZEksgzhWd1ir409VXWPWAJto OIIlagwd2KDbLLpTOKA8mgOP31Fi8utyRtIvTuktKOJf9rcR8j+yAgQ8y D0V0E1MVidqaXtnirFL4PFyfmE3UMhx0xlAJta6tcx/NiKyhImTLdatjr gjhW/Vhqq/iEulBQYtJ2lmL0usX9arMz4XYk3QgqjCntL+V+O/eK+5+7z 6/43IRLGjbyN+Ity5NAGBj0xkfj15b4qpdG/3RHAt4YSTjwTmKcKC+BZe HQ+LJ2HvdPD8+DkHpdzmQV5tSeBRys0rszR0T1LkJhJG7xHBswB8rHdOJ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="6837324" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="6837324" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2024 11:51:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="937025651" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="937025651" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 23 Feb 2024 11:51:15 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id A2BFE4F1; Fri, 23 Feb 2024 21:51:14 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Lee Jones Subject: [PATCH v1 2/6] mfd: kempld: Use device core to create driver-specific device attributes Date: Fri, 23 Feb 2024 21:49:51 +0200 Message-ID: <20240223195113.880121-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> References: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791730009189754114 X-GMAIL-MSGID: 1791730009189754114 Instead of creating driver-specific device attributes with sysfs_create_group() have device core do this by setting up dev_groups pointer in the driver structure. Signed-off-by: Andy Shevchenko --- drivers/mfd/kempld-core.c | 21 +++++---------------- 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c index 99c8656e723c..e8ac30528085 100644 --- a/drivers/mfd/kempld-core.c +++ b/drivers/mfd/kempld-core.c @@ -15,6 +15,7 @@ #include #include #include +#include #define MAX_ID_LEN 4 static char force_device_id[MAX_ID_LEN + 1] = ""; @@ -373,16 +374,13 @@ static DEVICE_ATTR_RO(pld_version); static DEVICE_ATTR_RO(pld_specification); static DEVICE_ATTR_RO(pld_type); -static struct attribute *pld_attributes[] = { +static struct attribute *pld_attrs[] = { &dev_attr_pld_version.attr, &dev_attr_pld_specification.attr, &dev_attr_pld_type.attr, NULL }; - -static const struct attribute_group pld_attr_group = { - .attrs = pld_attributes, -}; +ATTRIBUTE_GROUPS(pld); static int kempld_detect_device(struct kempld_device_data *pld) { @@ -415,15 +413,7 @@ static int kempld_detect_device(struct kempld_device_data *pld) pld->info.version, kempld_get_type_string(pld), pld->info.spec_major, pld->info.spec_minor); - ret = sysfs_create_group(&pld->dev->kobj, &pld_attr_group); - if (ret) - return ret; - - ret = kempld_register_cells(pld); - if (ret) - sysfs_remove_group(&pld->dev->kobj, &pld_attr_group); - - return ret; + return kempld_register_cells(pld); } static int kempld_probe(struct platform_device *pdev) @@ -489,8 +479,6 @@ static void kempld_remove(struct platform_device *pdev) struct kempld_device_data *pld = platform_get_drvdata(pdev); const struct kempld_platform_data *pdata = dev_get_platdata(pld->dev); - sysfs_remove_group(&pld->dev->kobj, &pld_attr_group); - mfd_remove_devices(&pdev->dev); pdata->release_hardware_mutex(pld); } @@ -506,6 +494,7 @@ static struct platform_driver kempld_driver = { .driver = { .name = "kempld", .acpi_match_table = kempld_acpi_table, + .dev_groups = pld_groups, }, .probe = kempld_probe, .remove_new = kempld_remove, From patchwork Fri Feb 23 19:49:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 205714 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp873242dyb; Fri, 23 Feb 2024 14:20:18 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW/A2Z4WqjDQIj2h2rbq/qYOfMFd1jUvByUwqIvOQimDZLwxAE3IEfUbbaN2czoUxCMvAUI+q5C7ZvDNJResCvqZrEJcg== X-Google-Smtp-Source: AGHT+IEgch4aAwTu84ewPLy+psB5z2n7+m4HItIIEwqkpAieaHeYn+5qacWT7ILjKdaS+0IQm1kG X-Received: by 2002:a17:902:6e10:b0:1dc:212d:a9f8 with SMTP id u16-20020a1709026e1000b001dc212da9f8mr978123plk.64.1708726817945; Fri, 23 Feb 2024 14:20:17 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708726817; cv=pass; d=google.com; s=arc-20160816; b=c3j7IOK46drTOk7qtVzBnQT1k/BuoXqJYY4YQMLoO+0ZXSC4g+FJA7du/oP1CTFJuc EbJMoM4lgf1rc1GasYJ8nN8F6AEbvEACd+UuzpRVTvyNdS6Y3lq5PisH5S9+mcQrT8MT 2KVSTR7o4ZVU+KZ7ORX5qjQvA0zYRtuo3SEMl/UEStl/xLLly7LjaIbcyobjG+214YAv uEhgpNRBMwGiGgbQGQlfKN8p5v9D5le7pfcmseZBMVn8z+KwxOqxK8Cy/ZZ3ZYdsanG5 g5ZrWx9W4b4BST9kbMgPHOH1tVyM4FJlJ+gUml7pFLFv0+4t9F2nf4AuD13WRYxHM46/ YRAQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=2n7bXGhf8LSHpeYMWjyjxT74Q5SKgslx2/rx8thjvrM=; fh=NrWLvEVUW8ufGou/ZOuWZl9yKC+ByU+oxgRUdXMV2yI=; b=RulE5PeRo2NeswOiaUN8CnGmjwllMKuAcxQlg6Ua8U7hrKQWodhf7C1r/4/4JdwyhB uPk0XV2sHV2bMQRVJkaips1lfLStmf/ya/M5uSaAC30ap97UgYyBylXRi+h+ylqEKcuK nKb5l4u/CkN6B78KlHKkwbbtJwbhPozA3UStjVR+M2y5K7rV1foCqoIzvSLuzwZzq547 Caa6idUa3/MsPx9D/1eSLaDMI8b3ImaSXLV5/AzdBBcPIGqQuuyxcGnvFwZ58B60jiz3 s7SP1hPNzxg0pxEyalm8daIAPMeS2h1iKK1WkQ4Gb1MtZ6rmIFurxhrbJ9VieH08IwS7 velg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hAb3t4HU; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-79063-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79063-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id p23-20020a1709027ed700b001dbf5a95ef3si9907058plb.417.2024.02.23.14.20.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 14:20:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-79063-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hAb3t4HU; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-79063-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79063-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BC113289945 for ; Fri, 23 Feb 2024 19:53:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E2BE714DFD8; Fri, 23 Feb 2024 19:51:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="hAb3t4HU" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B02391493B4 for ; Fri, 23 Feb 2024 19:51:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717883; cv=none; b=AVs3wfUisDXS2lVc7IhvIYd2HV0CHh7I/5qu/9pewDreE11wLKyRkJW9DwhhefSnQhN9j2oJI7UQdpDmiGS53SWf9XRjf0/Ll0TAQ6e0RwyGFVoEgtXCWnuArbJxXyLZxatwN1XNdln8ZMMX9/eymr5bHmw0YMLFvVsXrnZLaAk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717883; c=relaxed/simple; bh=0PKdh4pEIrqDSQO7ZRWs0TVdP0lCYrCSx8iDEn/lkVs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=maaweI5YbJDzr8Tiipzdrz0X98zWYyAEe6oQeYXbmA7rVnxYuo1dHc5CCXQTSCDt1kUEXZ10Ax8EF14+mES3rc2W4vofZ/g7a9HXg10GA0Utb69BltyXHao+WzCLAv6NAMW1XQ0KibhKVrONhL7mY+3CRM47Ul9MEgFsg3ZfUB0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=hAb3t4HU; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708717882; x=1740253882; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0PKdh4pEIrqDSQO7ZRWs0TVdP0lCYrCSx8iDEn/lkVs=; b=hAb3t4HUBUl3zBlB/a7OjwUDRIEVS57tTUQSTyoyUYkHicJiD5sW+QMJ vlqoYr6aMmoAkClKqd0jVSUxwTgoCgJTEApLJuA0ApZyyvHj4IgjagnLI ou3ZpndePmqRA0/boK4gJcFPK/JYhVFPtHnvYHhwve3QmVg8tl2rZzNf7 ruIXNF5Ty5XD2cpK7KfrKA0ctK0kXf52U3q5Q0qg45k60NsZuwWk1W4z3 tJ1TjA0jsLk6otoCsmtNcH+Sed28VTdera68ZIVquohZ8K190hkv24fkZ yu8++u9VXTVX6ygYir6dbO+Fz0Rq+di5tOepU3LtXaDyJtbwVoKborM3G Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="6837328" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="6837328" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2024 11:51:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="937025653" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="937025653" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 23 Feb 2024 11:51:15 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id AF78479A; Fri, 23 Feb 2024 21:51:14 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Lee Jones Subject: [PATCH v1 3/6] mfd: kempld: Simplify device registration Date: Fri, 23 Feb 2024 21:49:52 +0200 Message-ID: <20240223195113.880121-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> References: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791729931776909330 X-GMAIL-MSGID: 1791729931776909330 Use platform_device_register_full() instead of open coding this function. Signed-off-by: Andy Shevchenko --- drivers/mfd/kempld-core.c | 33 +++++++++++++-------------------- 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c index e8ac30528085..e207a62d6577 100644 --- a/drivers/mfd/kempld-core.c +++ b/drivers/mfd/kempld-core.c @@ -6,6 +6,7 @@ * Author: Michael Brunner */ +#include #include #include #include @@ -131,28 +132,20 @@ static struct platform_device *kempld_pdev; static int kempld_create_platform_device(const struct dmi_system_id *id) { const struct kempld_platform_data *pdata = id->driver_data; - int ret; + const struct platform_device_info pdevinfo = { + .name = "kempld", + .id = PLATFORM_DEVID_NONE, + .res = pdata->ioresource, + .num_res = 1, + .data = pdata, + .size_data = sizeof(*pdata), + }; - kempld_pdev = platform_device_alloc("kempld", -1); - if (!kempld_pdev) - return -ENOMEM; - - ret = platform_device_add_data(kempld_pdev, pdata, sizeof(*pdata)); - if (ret) - goto err; - - ret = platform_device_add_resources(kempld_pdev, pdata->ioresource, 1); - if (ret) - goto err; - - ret = platform_device_add(kempld_pdev); - if (ret) - goto err; + kempld_pdev = platform_device_register_full(&pdevinfo); + if (IS_ERR(kempld_pdev)) + return PTR_ERR(kempld_pdev); return 0; -err: - platform_device_put(kempld_pdev); - return ret; } /** @@ -424,7 +417,7 @@ static int kempld_probe(struct platform_device *pdev) struct resource *ioport; int ret; - if (kempld_pdev == NULL) { + if (IS_ERR_OR_NULL(kempld_pdev)) { /* * No kempld_pdev device has been registered in kempld_init, * so we seem to be probing an ACPI platform device. From patchwork Fri Feb 23 19:49:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 205667 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp837818dyb; Fri, 23 Feb 2024 12:52:08 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVYJFNycCNmADxuQ0utFjBd+kXaKeOoY9Pikkf9LygduVq58PxG3WnObyE5m5apj3YMomSV5d2n77b/h3HZIkCVaEFoNQ== X-Google-Smtp-Source: AGHT+IF5yV6KjI53TNMSCZgsJB9C4jGXoVLNRghlU2TG3cfdnMpoFBcOyKqN0Tsio91he0kqjLOr X-Received: by 2002:a05:6a21:2d8e:b0:19e:bf18:61fe with SMTP id ty14-20020a056a212d8e00b0019ebf1861femr1495509pzb.11.1708721528167; Fri, 23 Feb 2024 12:52:08 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708721528; cv=pass; d=google.com; s=arc-20160816; b=Q6bmyq4RugIIgIsaE3Rz2zpkBPAluy69+yoFqPcdDWzkQi639PBEJEmskaJ7+4cSoY x9cBx7Z38Q6nnFcAnui3mDde4GLTwNQ82h0+P2/sSAmJzSb3DTqKDoRoOfeD93P9teNd PTNKHXYEimaXz5wKm0FB3c260j/bx3xGELDnYJyNRcQ54wSQirEa8ceU8EprsOU5nN8Y urRu3VyBekzQFCc6eudGFIXmC0lwUPQX7dnKQ/nunGDZT3QjSUb0nsqYnY2RDXMVFmt6 D8jJIMxMrMq+NIhQG1dLxmvZd06lgBd71ff0brWjMOdSGSwTdC/w3Tu2usBa+5/zbi1d 1GDA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=BZyCrd1WdAkzpz2OWgJ4Tt/gAKwuk6NtzpajDlgRU9o=; fh=NrWLvEVUW8ufGou/ZOuWZl9yKC+ByU+oxgRUdXMV2yI=; b=VEFPay5ZtJJOalKRDe9Puk9RLJoCSPxwLp6wghe6BPL6MmSxkQVLksNQ5QhvrnXx9C eUv4SWmBbGSXQ/KJ3mnT9N3Md/RztoywFNuVboWbyAJuagVT924aICPDiDRWx7DODquE MXw8Ahxg0C9D9os3oaYpZ20gbedqrDEsy+W0QTjBRdaI3+aCwbXzeYw7AHFv7zMKApA9 u62nMbNuaOpmeBMvkCI5GtF5wgYaE4YNv1p+NK49Om6BmkTAc7CKJ3qn9+aGTm3DpmXC 4zSEjtX/QoFDBCr5I0V/RfJy0uwH62rtTq8x6SjNWf01caVKbVqSD6K1kZw6VD5BWY/y tyOQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Jsv4uSfg; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-79062-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79062-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id j65-20020a638b44000000b005d66232593dsi12688634pge.868.2024.02.23.12.52.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 12:52:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-79062-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Jsv4uSfg; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-79062-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79062-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 72602B25E95 for ; Fri, 23 Feb 2024 19:53:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A86C114DFCD; Fri, 23 Feb 2024 19:51:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Jsv4uSfg" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B01ED1493B3 for ; Fri, 23 Feb 2024 19:51:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717883; cv=none; b=ljz8wt/K+erjjyZxxGupzOHPWT9WOQFp62jNezLbn8sD6umaHOFVp1p6vPWro68+yPvMRtcOipV8mAJaxO6mCIc/pAwkrUNxzKJ1eJHRx0y2ZoUPyO7qhTP1v51fJ34aWGNKNALSZ6nmmurLrO9W1R1HD8rzkqUwjLpQGxZjX7c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717883; c=relaxed/simple; bh=JOR5ZbgquS01wBvWAK1H9MXS0YUwJRqWZazvt54flDI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aP2KyOY+YljhT9FnzR6heLqieJfNb6RJ7yR8sguebs0RAz2i/R7mAhBLKGaTocx/A2SJl1Y2/o5G59QYeIBD8kW+kDA8FRu5aftmdLmyc0uRoA1HirUaGyCfn2cFnZ7bqempPod/fWe9R5x52XVk7Ox7tiDQABknWVzu1gho1go= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Jsv4uSfg; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708717882; x=1740253882; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=JOR5ZbgquS01wBvWAK1H9MXS0YUwJRqWZazvt54flDI=; b=Jsv4uSfgUXwdTHJXrzzPaojcnTBHgIohnNZi91BBIuylQQxlp+ujUCtd h1SKm60m/uANQAu1s20lTNbX8nW917s/ZGqskA0tRK/z/6Snn0X8ztGKL wEnJphsdFLoSXNCbHazRLJsstMY+ko46KuQckBpJCTZIJSUZDpq++xyTc ZcImKuig2mkEGAiyVOPD6U87VvwWGCNCKciicQev7H2RMHC9csXKzQ3HT lI8ikJb7FIYD9AQHkhhCJnEhohqVl+CpG0v/rZcz4vsHFdK3Vrrq5Tx1l fpPy8SXrH48zcEgXY4TImvNB8jDJR7pcbyJ+5RUG4D0ApBwuQgBGuhWJz A==; X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="6837330" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="6837330" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2024 11:51:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="937025654" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="937025654" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 23 Feb 2024 11:51:15 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id BF63B80C; Fri, 23 Feb 2024 21:51:14 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Lee Jones Subject: [PATCH v1 4/6] mfd: kempld: Use PLATFORM_DEVID_NONE instead of -1 Date: Fri, 23 Feb 2024 21:49:53 +0200 Message-ID: <20240223195113.880121-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> References: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791724385216885312 X-GMAIL-MSGID: 1791724385216885312 Use the `PLATFORM_DEVID_NONE` constant instead of hard-coding -1 when creating a platform device. No functional changes are intended. Signed-off-by: Andy Shevchenko --- drivers/mfd/kempld-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c index e207a62d6577..c3bc61dcd098 100644 --- a/drivers/mfd/kempld-core.c +++ b/drivers/mfd/kempld-core.c @@ -109,7 +109,7 @@ static int kempld_register_cells_generic(struct kempld_device_data *pld) if (pld->feature_mask & KEMPLD_FEATURE_MASK_UART) devs[i++].name = kempld_dev_names[KEMPLD_UART]; - return mfd_add_devices(pld->dev, -1, devs, i, NULL, 0, NULL); + return mfd_add_devices(pld->dev, PLATFORM_DEVID_NONE, devs, i, NULL, 0, NULL); } static struct resource kempld_ioresource = { From patchwork Fri Feb 23 19:49:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 205713 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp873211dyb; Fri, 23 Feb 2024 14:20:13 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXMxbPsuK8Pq7GYGIgze1Ni/zUthVvu8vTAWIRqukTzfHmqnwKTj6kV6YBrijVEqm6u3qL/AYymBNUhDKsgJzHIpn79/w== X-Google-Smtp-Source: AGHT+IFpbuUxYYJBPBbDYXRHwTm5tuhZmuZU70KFWBiM8n6OBqV27TZuoY7NrAlbBp07vRtPTOrR X-Received: by 2002:a05:6808:7d1:b0:3c1:333e:683b with SMTP id f17-20020a05680807d100b003c1333e683bmr1082924oij.20.1708726813072; Fri, 23 Feb 2024 14:20:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708726813; cv=pass; d=google.com; s=arc-20160816; b=L+ffHya45JWCpTAlTt4hDeUqkPZ/WBcTGD8iuXDIOkFCyFzPt2kRFWmByJ0YMO3HWY XmCpyA+0xOjlzqsIMoaF1b/1qyvZ7aVxopmgrlY0vzpVmTU53o8qFjVxBbrK0ibNEkct OKmqLGItjX9H9toKIzXVl9tq8QPHw3s1ffQOz7ifLkvDGGjNad0r3VRirGZUqrZu6oon ymTiS5U5TgprwYaMDXZ13GYaLBmcVY6mD8HWpCyBoVTcuiBPkd7EptN2tWTebBG1VzQE F9FpxwCiEMJgflax/Y1EvUbq2yHVpNsG714JvBXensmvB2qlXKHMM9z0PHg3gqauyfdK xc/w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=xs4DPqOsc9+azMllpOXEorAGBCeNZM8TxqMCW4v36RI=; fh=NrWLvEVUW8ufGou/ZOuWZl9yKC+ByU+oxgRUdXMV2yI=; b=Fj+gOGa/QduvXRUJpRLOApLxLffFgLFEwpV7CdtA0DgjK1AsTABOHonfpGP8HH4EI2 bDeD2c+XOQ3qRskke0e18HHr9F2pKpS41/MFvMNIrqF6HTJsOPkcInNb42Ht0FR8oaz1 +QuPFgFZdNHszzMTEj4z/Xc+Fzo35wn+GdK3LBJoQ6duEagrGtlDaJ9aFDr+yHtbc6oM yJuzGIaiDutpn3LMOLocpUDqG2X1nGLrJJLGtqjwDYnNosT7t603j709eBq9ndRCcCG/ kfdJ9jF2rI/IMzT2bBnuQe0UqcassYoIq+hk6gpCp/NQHyq9pRHo7b2aLeQGfKjO8kPU +XmQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=DdTrt5gM; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-79065-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79065-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id j5-20020ac86645000000b0042e67816152si1490530qtp.87.2024.02.23.14.20.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 14:20:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-79065-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=DdTrt5gM; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-79065-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79065-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 4D7401C24C3B for ; Fri, 23 Feb 2024 19:53:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3AA4913DBA8; Fri, 23 Feb 2024 19:51:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DdTrt5gM" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B9B114CAA5 for ; Fri, 23 Feb 2024 19:51:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717884; cv=none; b=FGl4hk7nPBkJq0dTkXte0D3E1B9abpjOhS8clo2dJgt+eG72hn3AXazLtZScNDzQ8AfWGyh/iQF8N2swVHn7sEvGABjMaYwUydJ4YUl/mcT2SgqsDr1JI9nihxYhY6d9ilgq86I4of6QQqylkaweQTp+kPcNE9Oaw7pkyvReDuc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717884; c=relaxed/simple; bh=a9fjCoKlNy7EqqwDnIhus04TAUmuVLHwGiBZ5ufchNE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jN+oLCjiGpKxYQsW/TPGb0X0o2uXBIgkbhaiAznubnXURm5r/Cq6u2kP8t7sopAVFHGKORkrnJBZI0OlPmQ48LWnDxTprlUZZSUtWLD5lU9/69apgNrCSG3i/Qe5jN3Cf+d8KDcQE9lHsV+f6VlRKdV+DjfmVnILLyvWR5GEZBU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DdTrt5gM; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708717883; x=1740253883; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=a9fjCoKlNy7EqqwDnIhus04TAUmuVLHwGiBZ5ufchNE=; b=DdTrt5gM5sUZoK6aLgExcHZIltaDXOTr4XYtJpAEvggWx1bkTOplL1e+ oFRzVjj0y8Hu2EdRRrEGieFe4RpC3oq+WkMkA1O4MOLGgY8nd1Qu3AlCZ 3mKMm0+1j5YPJfgBEp/LilaRaqffaqiFWI0kYbRFK3D75boxieJUBtytu rWizjc7iSyba5JX83Hxw5vC9gGFVIQEudd7NBWdY1cqywPCKa84uHV9da cReRjV3wEZGy6OLIiUCvtSBJTdXMMuUAhyHsBrzNAwwwbILQ+B/Hyz8zp Hrppo9OLgLYuWWWCxXKsJ1p86NAKO+kSLxhH1fOWsXH81mN5BNB33o2nn A==; X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="6837340" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="6837340" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2024 11:51:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="937025656" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="937025656" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 23 Feb 2024 11:51:17 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id C7BAB8D2; Fri, 23 Feb 2024 21:51:14 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Lee Jones Subject: [PATCH v1 5/6] mfd: kempld: Drop duplicate NULL check in ->exit() Date: Fri, 23 Feb 2024 21:49:54 +0200 Message-ID: <20240223195113.880121-6-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> References: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791729926719782228 X-GMAIL-MSGID: 1791729926719782228 Since platform_device_unregister() is NULL-aware, we don't need to duplicate this check. Remove it and fold the rest of the code. Signed-off-by: Andy Shevchenko --- drivers/mfd/kempld-core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c index c3bc61dcd098..30b8408c094e 100644 --- a/drivers/mfd/kempld-core.c +++ b/drivers/mfd/kempld-core.c @@ -895,9 +895,7 @@ static int __init kempld_init(void) static void __exit kempld_exit(void) { - if (kempld_pdev) - platform_device_unregister(kempld_pdev); - + platform_device_unregister(kempld_pdev); platform_driver_unregister(&kempld_driver); } From patchwork Fri Feb 23 19:49:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 205668 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp838761dyb; Fri, 23 Feb 2024 12:54:35 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWvGULw7AfMQjwrDy3hy7Uv/I1EOZ9rmRrpl35B5LlVUP5KboU2k28gkZuE55Xzk4IwljQ0BD5TYhJckJkHsK/bdqJyxg== X-Google-Smtp-Source: AGHT+IFrG5gcq9xt1JCJIaPpizpGU6olPyOnZ2odwZ2kVI5ziTkjns5ZEh/JLlBXnslL3eJCGEjO X-Received: by 2002:a05:6a00:c85:b0:6e4:6dcd:8d28 with SMTP id a5-20020a056a000c8500b006e46dcd8d28mr1331618pfv.0.1708721675400; Fri, 23 Feb 2024 12:54:35 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708721675; cv=pass; d=google.com; s=arc-20160816; b=l6FhSpxp61RYBN9R7iGxhDbbQIJfELKebYeFpGScd6fOkkTBN1RYYZr9Ru/AOiikr0 bMQUbYHFlur22Jq3Z9FWt/zmJ9ixlntSewhelU3px6vYzX5lE2gJTG+fI5EHwoW+ntXe jZoCG3pj44fcQlyizkv3Rt7IxhWcLt+OzjMqoa0bL21KXUV0d8XLzSsDkI2PmkKymXaO BNUddoArzJTvwhIR8rU7UJKl11Y9m/gEjnOi6ZvH9DMpA8RzHejk8O3jczPiD5np2lle 0QXf7eR4gBC+89PKk9PN++TBUSMOOBDTB3PgXob4TSKXBPsSfQxuNkJxai4zQIb/FT97 HsrA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=kI6s8nx79qW3VG0i1y6ZW12fHC8euHV1JIhMABjwbB0=; fh=NrWLvEVUW8ufGou/ZOuWZl9yKC+ByU+oxgRUdXMV2yI=; b=gAb199KLScMOXJeTm0vGTq0e5qPSeJ+ZBgkPqwGv2b6yxYk+QlISKbu6qGUllrqp3G xDgNjzm2IZAee/GOJenGYVkmtRlnyZHJgLF+7Yaxr9VVFskAbhGx8qXYGx7zKhnvrREw 2/gicEPocO/ZsepB+1RTKe4rM+UQdXPCcMPtXjUkReURv3pUI1BW9tjLSo5cIawEaooU GcTazVEms+MiRBOZ5PvPqpJeBe3UuFR51K09b1q76sYZgM6EM+tSZJNfyDg+3QmWxpB7 D4hWZRHZ9yQgg01DfEUBRfvKylHH/SRUIK9Yzlxibf3mf1PHkU/v2lHXK+GasWY7p0UA qdAQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=DZjlJvMp; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-79064-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79064-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id y6-20020a056a00180600b006e4e05b9a5dsi1843365pfa.37.2024.02.23.12.54.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 12:54:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-79064-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=DZjlJvMp; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-79064-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79064-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 4FF38B2603E for ; Fri, 23 Feb 2024 19:53:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 423D114DFE1; Fri, 23 Feb 2024 19:51:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DZjlJvMp" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 555451F600 for ; Fri, 23 Feb 2024 19:51:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717883; cv=none; b=M2pfkTJS/ts66wSZyRdGeH7Dsk0QmMLzyS7enlxLMR3UJ5bOeJg62pJcva6K9q43BJV7CRMKOpibTTaFWSW5FsbIr+DIcXWpBh6P3AsthOrHU2znrCpX+0gGj5Qx4mR7wAbynw29cmTCbwQJU1IcE/j+CgBCYXVGHOkdBoAvyxk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708717883; c=relaxed/simple; bh=3FltV39b/2p9W6TJ/uXFx7JU9OLaxSUoPbI0iGl341g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DAq5pcJ/Aah0VmWKRLW6uDCkHiCeWleKehH6q++W2NY3BxXufZgzWzI6HoieKMHWErFkhePoOJPyZSJq1a0ClL8lBHLOir/ZaTbXALwj6cSBO7JzThAqHEa1Xp0QzM4kbzWNzLR/s06mmnmydn8uOPgcQ5U6Drn8Qhb89+ocSMg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DZjlJvMp; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708717882; x=1740253882; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3FltV39b/2p9W6TJ/uXFx7JU9OLaxSUoPbI0iGl341g=; b=DZjlJvMp25obSDOoJZJZY3CYp098UyPBOO1L7h73++JUD3ss5R0aircT sLO86HyqBBP+A80DnvCK63ymkU9WZM9gPE6J8/Z7hJWxeNg0PkI/94YCR SchXPhRBj3GgtMWzhxpL1grnUnrEe6SNcaM07GduOuLgOykvIBGAjeJ+H wEHDgFr6DOmD5KR94mGTygDWC78Qr/g/jI2evDdbZQH91xgwOAJMFXSN/ f+Ha/WFHjDjoMJtvYxo5zL7UqG54Ooo0dL5ZUbQOPLfDLBmbopfEbwcSD ty/fUO89MjAehT4L2lRRGtXsuLMNqFzx22ZWp5qqYsHz/CuyqXC6omYUb w==; X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="6837338" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="6837338" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2024 11:51:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10993"; a="937025655" X-IronPort-AV: E=Sophos;i="6.06,180,1705392000"; d="scan'208";a="937025655" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 23 Feb 2024 11:51:17 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id D42DD8E7; Fri, 23 Feb 2024 21:51:14 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-kernel@vger.kernel.org Cc: Lee Jones Subject: [PATCH v1 6/6] mfd: kempld: Remove dead code Date: Fri, 23 Feb 2024 21:49:55 +0200 Message-ID: <20240223195113.880121-7-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> References: <20240223195113.880121-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791724539371323487 X-GMAIL-MSGID: 1791724539371323487 scnprintf() never returns negative value, drop the respective dead code. Signed-off-by: Andy Shevchenko --- drivers/mfd/kempld-core.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c index 30b8408c094e..ce7d52a62e51 100644 --- a/drivers/mfd/kempld-core.c +++ b/drivers/mfd/kempld-core.c @@ -294,11 +294,8 @@ static int kempld_get_info(struct kempld_device_data *pld) else minor = (pld->info.minor - 10) + 'A'; - ret = scnprintf(pld->info.version, sizeof(pld->info.version), - "P%X%c%c.%04X", pld->info.number, major, minor, - pld->info.buildnr); - if (ret < 0) - return ret; + scnprintf(pld->info.version, sizeof(pld->info.version), "P%X%c%c.%04X", + pld->info.number, major, minor, pld->info.buildnr); return 0; }