From patchwork Wed Nov 16 19:24:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brent Pappas X-Patchwork-Id: 21235 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp23159wrr; Wed, 16 Nov 2022 11:28:24 -0800 (PST) X-Google-Smtp-Source: AA0mqf50XO56YcRxx9MV1mDHL0JKTSXfavd0PGb8OfUNm0loslI/AkwxFHv3/RQgUdv31ZaRD9t4 X-Received: by 2002:a63:417:0:b0:470:8e8a:e7fe with SMTP id 23-20020a630417000000b004708e8ae7femr22688370pge.215.1668626904412; Wed, 16 Nov 2022 11:28:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668626904; cv=none; d=google.com; s=arc-20160816; b=fChIvwbAeYrkREaKPZ0fX0fK0RLEQ/XPbaA70ZYvC9kWSEohC57KWv5uNSTNRBpcnE mnz+2MhQAPtC3qmGdkbHZpnxQoK0q5JlQxuF8wfX6Abrqg+T3FolgU0YvgEs3YHqQjfC 4UwFrfOpWH6hawH/Ba4omEYMIxkHGJ4oRTFQMwnCwFw+SNqKtKYJjOT2rlUg21sxYgbA sOUnF6jjIjFbKkEH/+VomCQ9vvdTaop+KKsve+KLXhkSbwmKCNRP2GkDNWWyR2zrqPFy ZPOvZyR1eMCyYwwRJ6krqvugffdTDFYyMqy5ZsqOOFZAMoBJNC5LmSjuy8UEzIw3XmOX V3KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Xi9Mv8cjXNyXbOkCaah9Bx4ZM9WO7+biCPJ9yku3maA=; b=i4M+ipBoroEJ6QWMhbcfOjGufvv+Ljla3CpnGrR13Irt3zh8uAn8lHnkXyCSZU/H/q ADRWKEP2+Nglb1h+vop8JsJnsHHXkwINraBzJs/kIF3k7XwP9IhxeV/owfltBIzBW8Ud MV+AIVNSK8ryiCJZrSiL/SmMLUg79HGs9I1TRQA+9FFUvnZdPtxOp5ASwQQ8I1W2dlv5 ZFOxj3X7ogTEw4X7MbcC5vPNYFFyJTHkpM8qX51wFS3I0+lQSj/RauW4unoK+4PZXP9f yAMkTSgjIFrwkW+0DnZNqo1upGBUbikxTAfjkFl10Fw/a6zX8X9yeM1K4x1/PijSmADC rW+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@pappasbrent.com header.s=default header.b=hmYwvYxY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r17-20020a632051000000b00412607fea43si15917750pgm.617.2022.11.16.11.28.10; Wed, 16 Nov 2022 11:28:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@pappasbrent.com header.s=default header.b=hmYwvYxY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234119AbiKPTZE (ORCPT + 99 others); Wed, 16 Nov 2022 14:25:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233358AbiKPTY7 (ORCPT ); Wed, 16 Nov 2022 14:24:59 -0500 Received: from mailout-pe-b.jellyfish.systems (mailout-pe-b.jellyfish.systems [198.54.127.79]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35F7A644F for ; Wed, 16 Nov 2022 11:24:57 -0800 (PST) Received: from output-router-58994b6955-smsdz (unknown [10.35.5.64]) by mailout-pe-b.jellyfish.systems (Postfix) with ESMTPA id 4NCCfr4M6mzDqMs; Wed, 16 Nov 2022 19:24:52 +0000 (UTC) Received: from MTA-05.privateemail.com (unknown [10.50.14.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by NEW-01.privateemail.com (Postfix) with ESMTPS id 81C3A18000CF; Wed, 16 Nov 2022 14:24:52 -0500 (EST) Received: from mta-05.privateemail.com (localhost [127.0.0.1]) by mta-05.privateemail.com (Postfix) with ESMTP id 6029318000AA; Wed, 16 Nov 2022 14:24:52 -0500 (EST) Received: from bpappas-XPS-13-9310.wppl.org (unknown [131.226.25.151]) by mta-05.privateemail.com (Postfix) with ESMTPA id 8868818000A0; Wed, 16 Nov 2022 14:24:47 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=pappasbrent.com; s=default; t=1668626692; bh=QvsVh75+ZnsL2z/rlywbbUnkur9BTukvZDfLnRxV6Ec=; h=From:To:Cc:Subject:Date:From; b=hmYwvYxYsbDtTCOHnMvYOWnHgShkzRVDTMA+8hSnyvsxDebsO0fNuapZpVcl33LNP VvH+RMjjLmkJYFSWd8rosSpKG0uo3gBVjHb1aPdkKxGB6KZi5pK2MRFFs7c09lcLGP mfiWHmSE9IdD9H9xQ2LK+KL0nuzw3OJrp0JYeRBHES1HMv4KEIfGFyZ97Voysrxk3i 2XdS/yfQqSsKKFxH2Wtroh/53N/BELT8/WfRF9W4rzLgJxgXEQDYasWFSmBvSTA1AH bkqM1HUhO+3bnBGTRhCoDjt791k8nXlZXgUn0F3uPq5uPUiev7JFdZ9LW8rUOxKWIP Wq/Q4LXoiRWvQ== From: Brent Pappas To: gregkh@linuxfoundation.org Cc: johan@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Brent Pappas Subject: [PATCH 1/1] staging: gdm724x: Replace macro GDM_TTY_READY with static inline function Date: Wed, 16 Nov 2022 14:24:13 -0500 Message-Id: <20221116192412.22446-1-bpappas@pappasbrent.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Virus-Scanned: ClamAV using ClamSMTP X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749682124601080037?= X-GMAIL-MSGID: =?utf-8?q?1749682124601080037?= Replace the macro GDM_TTY_READY with a static inline function to follow the Linux kernel coding style. Signed-off-by: Brent Pappas --- drivers/staging/gdm724x/gdm_tty.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c index cc6d80554c98..93d50d42a367 100644 --- a/drivers/staging/gdm724x/gdm_tty.c +++ b/drivers/staging/gdm724x/gdm_tty.c @@ -21,7 +21,10 @@ #define MUX_TX_MAX_SIZE 2048 -#define GDM_TTY_READY(gdm) (gdm && gdm->tty_dev && gdm->port.count) +static inline int gdm_tty_ready(struct gdm *gdm) +{ + return gdm && gdm->tty_dev && gdm->port.count; +} static struct tty_driver *gdm_driver[TTY_MAX_COUNT]; static struct gdm *gdm_table[TTY_MAX_COUNT][GDM_TTY_MINOR]; @@ -113,7 +116,7 @@ static int gdm_tty_recv_complete(void *data, { struct gdm *gdm = tty_dev->gdm[index]; - if (!GDM_TTY_READY(gdm)) { + if (!gdm_tty_ready(gdm)) { if (complete == RECV_PACKET_PROCESS_COMPLETE) gdm->tty_dev->recv_func(gdm->tty_dev->priv_dev, gdm_tty_recv_complete); @@ -140,7 +143,7 @@ static void gdm_tty_send_complete(void *arg) { struct gdm *gdm = arg; - if (!GDM_TTY_READY(gdm)) + if (!gdm_tty_ready(gdm)) return; tty_port_tty_wakeup(&gdm->port); @@ -154,7 +157,7 @@ static int gdm_tty_write(struct tty_struct *tty, const unsigned char *buf, int sent_len = 0; int sending_len = 0; - if (!GDM_TTY_READY(gdm)) + if (!gdm_tty_ready(gdm)) return -ENODEV; if (!len) @@ -181,7 +184,7 @@ static unsigned int gdm_tty_write_room(struct tty_struct *tty) { struct gdm *gdm = tty->driver_data; - if (!GDM_TTY_READY(gdm)) + if (!gdm_tty_ready(gdm)) return 0; return WRITE_SIZE;