From patchwork Fri Feb 23 15:21:13 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 205468 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp657986dyb; Fri, 23 Feb 2024 07:30:33 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUtZqn2ug/5WnbEeJXcCWgsFfAZ15tu/0edf0708ZfEFsT7TcBaJMH8cXDuTXdW1+vTnozemM4ygPAxPYTbcVujyPYKqg== X-Google-Smtp-Source: AGHT+IE3hkI6AsXzT1qcfiqWHu1mUm8RGX/fTvcbsPV+LQZrsi08uU4p8gsu4YP6OLIYq9DhYJTN X-Received: by 2002:a05:6a00:929f:b0:6e4:d518:8663 with SMTP id jw31-20020a056a00929f00b006e4d5188663mr220734pfb.3.1708702233753; Fri, 23 Feb 2024 07:30:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708702233; cv=pass; d=google.com; s=arc-20160816; b=JVi4ukKTqgtUjwgHG3QYdSgeG4ipsdv7Fqpgj/mrkUWjSsVbxb7V4doxqc3zX1QjCU UNr/KTaRJCcMmpdETXdp4j5nIvuNNCgbJp78vVZYVDjxP6PIMGvY4KLBkkrE+x57m6Zs XjSHi4DedatGn9AU57/oy+NT02hJFoPk8lpO7jb/YI8jNLDgHtOOtdsuXzprWa4X9Tsw OMPF3GW3oYdu1mMYXieFbA8hEwB6SlGrahVrikiRowrYhUVlVVDNWYnecTWo052wkUAv yBfomp0VDbmaZ85KVNFLeFRqeZIDvtI0dS4haD2Wm4ZJjBm5dZVjkmnr18Ap46qQFYFf g2Tg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=PKjgK+FidZBFmVeJOuf+/15Dt0CyD+6mNbdOxD2xRtQ=; fh=VwdsaM5bQzG+0N9ZrKrSe1eUV1Ypza0gQp56idJYslM=; b=LRbPmFldYhcbQo12QDnOptjhc8oNZwNe72HyXB2s09E8zTy8LxSNzGo5vmuldZ8rRs 9ZchLgNODxZqc9ef58y18lsW8mbNRWByczNQ/YLbZBNYcEwTeiECFwdxDRRFjbWyKSNf lJ6ubpv9LyiLjyL4izjGBlrqhWVuOig8Y6lMw/ZWb6MM4NQnvgVQqMWXAgLE9QYn016W mJsBBEIoMzuy2MUPjePLQrMnA4OKRWNgDM477nYfgIJ7tkD6tqD7q/VxxVedzdmaoYvf 84LNn0fdyZLBWTuDDR48oFSzvFOgX438gsATPN7CfW2UDup4N8vJ+VmZ1cXdAdYJyQ66 PYew==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fl5esR1J; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78594-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78594-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id w19-20020a056a0014d300b006e45b910aa0si10179828pfu.234.2024.02.23.07.30.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 07:30:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78594-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fl5esR1J; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78594-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78594-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C5DFAB24026 for ; Fri, 23 Feb 2024 15:25:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 34BFA12839E; Fri, 23 Feb 2024 15:23:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fl5esR1J" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 618FA82866; Fri, 23 Feb 2024 15:23:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701787; cv=none; b=EAUklM5PjLcor+YQbrByo9lzk3C7/Qy9xr3TNpLzUENTiBAQgfAPaXJXGZQ0lihny3ui8bt453rDPdh6PdHzEUZeT9NQIQXH3ZRaSgb3aUtJ1jzXF5vRbLYkN+oGM6YGLLijg/s3RUgMpSuhOXAB9rDRUICK1mbc5hNbG7R1L/o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701787; c=relaxed/simple; bh=jSrJkfIN1qAWzxJsRTl7DfvhSeqHU9HH07knGCfmKHk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CCX1pagZ6LRVUooGatlg23JfgiyukTz2TpBS7PF1aVAR41Fdsf4TAnB49Nth/x5ha84Q0NHdPYb2/0wWhRJpj/dcPVmPVkXpI126TwysJTnjbDmeyDFtfRgA/LalnOz0kuJlNdzQWqrrY1riJGilstzUdSX/yFtS31kxycV+3BU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fl5esR1J; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CFA2C433C7; Fri, 23 Feb 2024 15:23:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708701786; bh=jSrJkfIN1qAWzxJsRTl7DfvhSeqHU9HH07knGCfmKHk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fl5esR1JlBLC32MubsqkqReluCkKzF9p1XmsrALW6QYtrbSfz5f9Hj1QH9VeFNG1F twC8+mwwaJvx7f/2+7aP0HKsPgQcxOxFLYeDOscVDvWY5PvhrcI+LQd+iPY0xph2xm mNCB638j/w9XfNGwFSWQH+CWcU4hqPWXuYIORv7upi29Oux8islrzdgPr8ABy6lunC qbb7+p8S6EGanN14Y4dBrz/V0OfkQr0b4eo1uKV58ngOXjmkw2+SXSyZ1yxCL6DL5V ZzItuyb6YQMpLJpvFZRbde4q/Lydkxptilv7M7xmpR+S7jbmEb0Uhu1AlRln0mnGWs f0pIsILf0MEfQ== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rdXOI-000000005FV-3iz9; Fri, 23 Feb 2024 16:23:10 +0100 From: Johan Hovold To: Bjorn Helgaas , Bjorn Andersson Cc: Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , Krzysztof Kozlowski Subject: [PATCH v2 01/12] dt-bindings: PCI: qcom: Allow 'required-opps' Date: Fri, 23 Feb 2024 16:21:13 +0100 Message-ID: <20240223152124.20042-2-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240223152124.20042-1-johan+linaro@kernel.org> References: <20240223152124.20042-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791704153686604145 X-GMAIL-MSGID: 1791704153686604145 Some Qualcomm SoCs require a minimum performance level for the power domain so add 'required-opps' to the binding. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Johan Hovold --- Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml index a93ab3b54066..5eda4e72f681 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml @@ -123,6 +123,9 @@ properties: description: GPIO controlled connection to PERST# signal maxItems: 1 + required-opps: + maxItems: 1 + wake-gpios: description: GPIO controlled connection to WAKE# signal maxItems: 1 From patchwork Fri Feb 23 15:21:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 205458 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp654864dyb; Fri, 23 Feb 2024 07:25:04 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWxA6Q8BbzyEkrsLcGjOfY14FNfP/R/gUFA4YrJbQwPsEQ1QEMCa6i3ni2OgOJQtUk3BkXHeW1J3L+SdqgRAZRqfB4GNQ== X-Google-Smtp-Source: AGHT+IEc6Q7pMYY1Un6aWzCA7r/2Fph1+533VNrXgwJqWrcS7380pYYPjycxZRaixi2jNQ36Sc5A X-Received: by 2002:a17:906:3789:b0:a3f:a468:9635 with SMTP id n9-20020a170906378900b00a3fa4689635mr111500ejc.1.1708701903936; Fri, 23 Feb 2024 07:25:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708701903; cv=pass; d=google.com; s=arc-20160816; b=iDP5NFuPGJ+SvdIYllZzhOl8id44l3qaeCe0/BcB3j7XHI0UiB128X1Dcmq3fC+tTA qUprVO5xVm/Us46JNcrRpbOYf68N9tOmeTZzQX+WTqDOcjMVMHZ7niAdoX0QcwhYfSJY pJOiOh6gPZkxNZsBCkSTRrc9gWzXaLNYvCFv9QD2eGx4yswWB/lQdyErbVQ92t5GZa1a 61abM++RGW3wMr0qaTX/+Ksbl8I2CQBTwWtRjN7NDpbntT4N8u2NT6hj2ceqsrUgfbS1 pSbu63SPOqpTWe9NNW93izZ5Eex53My+76cfFQ3gGHySM0d8hlj2QZcYc6jUeDuIvlWo dj9w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=VKhyYm7cNI189D2BZavE/F14F2JzKUjGqDFWIU/7QUQ=; fh=VwdsaM5bQzG+0N9ZrKrSe1eUV1Ypza0gQp56idJYslM=; b=IcLXALzngB5wb8kjBoWi0ho0718/OfBzvsF2yfVX9qfoEPkyIitgQNsQIMxA1hFd0c Ni0+A+I0t7r+2lfEoR+ciSKmRbMqd9/ZF9Ox3RWzV5BawGNLRBamzkiFFL9vYP+zfxNo FIxAoE/strDjhFtdGtODH9chitsGGceDYTv9Lh4sVmbfDyaSrrCqJPojb5hPFs53cd7G S4JPCXn6MTM0t98OiGQrzAd6J3mi+1H3sM5oFcv15DxUJxoT59kqGm65GXIwBIWGR682 KP5G4IqCXtxi9KdxVoWtHF0HksxcXL2GQK94X5fqWgfV1Y7QxnT52OIHxdRSDI9joiWh A6Mw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=p8JqInj4; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78590-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78590-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id o14-20020a17090637ce00b00a3e6387408fsi5447974ejc.56.2024.02.23.07.25.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 07:25:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78590-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=p8JqInj4; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78590-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78590-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 890241F25745 for ; Fri, 23 Feb 2024 15:25:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B031682D81; Fri, 23 Feb 2024 15:23:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p8JqInj4" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CA008289E; Fri, 23 Feb 2024 15:23:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701787; cv=none; b=AkSWTj+KvtUW0xStKq6N4dNs1gBHEoeRu/YgAhUp0tW2ck/RNzmWg3FyEoUgZ/AuNYmywO2sxH1itloyFuH6cyomK6hTDmSac4wjbF4GR/IJKRuIenq7p8bGeEmB8fZcAgKa1bQCfJaMe3Lgm9UsJcucyJQyZ5ELnW0SYxk8QzY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701787; c=relaxed/simple; bh=PoDeEFZKMM5sUBAoDnRImQrfjwOwvKT2JU4hjPgvF6s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iXbRhXS2ZyJw7PKmFGTYBpauq4u1ShhDD2NU8yGMkKMZmEJYevHqUBNhPp3ENqkEObfUQNay3cN5BupYDX4wmZ2CddjWdj929EjNwaHvIZ805KUQkZnh3Qv/ygaiz7cl8M570YQGfTYg6NoMDvc+BEfeAc09k1QJe1Ho8AeHOJY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p8JqInj4; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A66CC43394; Fri, 23 Feb 2024 15:23:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708701786; bh=PoDeEFZKMM5sUBAoDnRImQrfjwOwvKT2JU4hjPgvF6s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p8JqInj4eWTc/Dq15O3aGReyVmV6LLV31cevUgbT6ufHuz2WGfmFb0RwlpTwLnxeC KMcT7DP4e4qaenE9WqOLZZT34xy7nz0TMi82sbfd7cJciUKOmtFBSODPSgDcYa7ZQj Y63dYc+Z00T3qRVNxbSJdIaybiPwa+7tG6nWpBYLcFP+SzgBLYiQh3V/nwdb47sOuL BGypnfRLmtkH+4uK7864yeo1Bn8XSs+OMJuy4J5zNmxl2aLdpApQYBACsMbHtgi+cr wk51VOMMf1liYZqQZNUIC0sh1q9q57r2y5TUhYubCSkRwYL0/td4orj+YZbc9x4bI6 V2I8QFtpmoHqw== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rdXOI-000000005FX-435q; Fri, 23 Feb 2024 16:23:10 +0100 From: Johan Hovold To: Bjorn Helgaas , Bjorn Andersson Cc: Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , Krzysztof Kozlowski Subject: [PATCH v2 02/12] dt-bindings: PCI: qcom: Do not require 'msi-map-mask' Date: Fri, 23 Feb 2024 16:21:14 +0100 Message-ID: <20240223152124.20042-3-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240223152124.20042-1-johan+linaro@kernel.org> References: <20240223152124.20042-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791703807700361295 X-GMAIL-MSGID: 1791703807700361295 Whether the 'msi-map-mask' property is needed or not depends on how the MSI interrupts are mapped and it should therefore not be described as required. Note that the current schema fails to detect omissions of the mask property if the internal MSI controller properties are also present. Acked-by: Krzysztof Kozlowski Signed-off-by: Johan Hovold --- Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml index 5eda4e72f681..b28517047db2 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml @@ -146,7 +146,6 @@ anyOf: - "#interrupt-cells" - required: - msi-map - - msi-map-mask allOf: - $ref: /schemas/pci/pci-bus.yaml# From patchwork Fri Feb 23 15:21:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 205457 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp654849dyb; Fri, 23 Feb 2024 07:25:02 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXN+6fcK9ufOgDgd1e00C3kZew4X7ouNgG5Yl2dxkhZXQMRTjv2L51JbMVogUEYS5Ct+qC4uI+otxT2uc3RPGQ4J2yPCw== X-Google-Smtp-Source: AGHT+IF2MttDiAIrczCxmk4ZGhM0YipR08Z6M3BjW24qUuLT/+7VeVILJtrwEu3g7JrOgtU4ilIj X-Received: by 2002:a05:6830:440c:b0:6e2:f0c1:d728 with SMTP id q12-20020a056830440c00b006e2f0c1d728mr139441otv.1.1708701902555; Fri, 23 Feb 2024 07:25:02 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708701902; cv=pass; d=google.com; s=arc-20160816; b=Bp2cCYoXL4CHQu2Jza8QdQybo/2858Tx8ZDIUHZZLItHiUCsTHcUC4CrUFq8eIp2Gy B8ZNoWDvPRUw4sAEaoBotEwaLC2cImGDkk3HsbqIFGWoHEAKOUUoHoqyNa55Ge38tBa2 WYPTIRyDvJ5xLHheaEBD44wnWK1AzGY4+dFDTAXuxtsabfTSu06amhLRz5DMWjb75zkp S8nKUzB8wIEMP2+uwwJsG7k9FDUoL7HzhiHBQuDKPSxoMoCAQzoW/b4gCfs3tjo1SaCV Q/s1lMc4sECQY+K9w0EtMHsx44LjwjNyEU8D8Pd/5ySYF0km0sF5edAyaxA6uqbh8jAK dt3A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=HnDLTk9jlUAH8B2h1c9zk43d7sUvp0s1q6pQ4V4KWS0=; fh=ksFR342kkulMuv+0q94BrHeEzFBbdZfbM5STU9uX3MA=; b=nh8QhEvti2E8cR9BEJlzl/iRRl1/JrMjxuTx2Kn7qGCpQTHI6jhtl47n1TxcYgpn+E 1cGACoz1N9XPh0FVMW3Gli/Mm40cfpHaiQc0/jkCVecT8ypQplEhsLYAs35t1SzHRR+W 4yGMIy8wbkgvZ9Ngc75GiH7MW9hz9+2wVd+re9paEP3yCbXwMr9x/TB0RgLUHuEVwupZ nDThEa3N2uNu5D2DQZrY7yJ86KogIMS2Sp7oZmqzJHePmAGm8VKcNz5yNumA7xbkivdD yGjTJ+msDCOAMMguW3Yi3an5fRKM8DMpwkaZSaoHKZ+n0DS0QZVwWPVbd29Of1QDi2HH 390A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ydyu1SR8; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78591-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78591-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id t22-20020a05620a0b1600b0078738465c99si1219884qkg.495.2024.02.23.07.25.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 07:25:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78591-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ydyu1SR8; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78591-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78591-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 554501C23F11 for ; Fri, 23 Feb 2024 15:25:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BD41B84A2A; Fri, 23 Feb 2024 15:23:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ydyu1SR8" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C376839E8; Fri, 23 Feb 2024 15:23:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701787; cv=none; b=Ub73KDJ21QZLFBwYOaRGjQvHk/jz+GvlqaTtGucMJH6LlHn3+lTOIFeIgUYaloDak8CcWmZerIAlxcSAUk3YVoo01S/bye9Lz7NPSLj1duEqe3EhrxH1i9mlIXCKUqabmvhKgOb2f9n8X9fW861Njf+RkH/ZMbDHq8L11iuk27g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701787; c=relaxed/simple; bh=nc4MqV6YaWXP4nv2pZ90dCQqT4i4GYj2D270C7X4X5g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a4CzU0GsxcXmxm/2NZ+4R4KHJFnSL2cwVdcYPvC/DdkjsTTCwpgovrOz6QLq8/kcxUESCtwpbQjyMw+2bwsyrCVpm3nijhg3dws6baxuHS3pU13V1lasHBQsXr52UErcYzZzWhxPHn4RdizpDlI3s/QteuoOOAVLdsGfZ0GPQeU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ydyu1SR8; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 908B0C433A6; Fri, 23 Feb 2024 15:23:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708701786; bh=nc4MqV6YaWXP4nv2pZ90dCQqT4i4GYj2D270C7X4X5g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ydyu1SR8lpLQzpzB3X2h06K49YWtAISIGICtzLov1pVdvuuemjHzdi9XuRSexfKQX pkbziFhPoPSLqSSNiwrauPsgZEdLgfCdE2e6YilkGMttkMFmVl2Q9ODhe9whw1TGoj Nn9JmQP3RuhduIjAYJ5qs9F9kRZ+SCc3hdRPRHUa1Pxl5kJWSAqi7KyG9+ZMjYRpCu Y+4DVIeAAdX0kIE2m9dejvSbZnzMjRd/Z4lXUF8Ce9Bd8+BLeOUyxEkhuMvDUNealQ 0K2Ijlnp02ifK9PXNXURp+Epo3KWY/AI4lkS1Gv5XklYEToE258SMsdtWnM20Cc1ov iwRAu1VX9xIvQ== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rdXOJ-000000005FZ-0BSl; Fri, 23 Feb 2024 16:23:11 +0100 From: Johan Hovold To: Bjorn Helgaas , Bjorn Andersson Cc: Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 03/12] dt-bindings: PCI: qcom: Allow 'aspm-no-l0s' Date: Fri, 23 Feb 2024 16:21:15 +0100 Message-ID: <20240223152124.20042-4-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240223152124.20042-1-johan+linaro@kernel.org> References: <20240223152124.20042-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791703806061188112 X-GMAIL-MSGID: 1791703806061188112 Add 'aspm-no-l0s', which can be used to indicate that ASPM L0s is not supported, to the binding. Signed-off-by: Johan Hovold Acked-by: Rob Herring --- Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml index b28517047db2..4d1060b52592 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml @@ -130,6 +130,8 @@ properties: description: GPIO controlled connection to WAKE# signal maxItems: 1 + aspm-no-l0s: true + required: - compatible - reg From patchwork Fri Feb 23 15:21:16 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 205463 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp656086dyb; Fri, 23 Feb 2024 07:27:11 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW9ofl7CvPwwmnfz+0nI8ylyJGDODpn0zW1hqNEhoRH/eUNQuQTAxvUua2oh3WF+iuoAehxMqP7gRVmOZz7V813QBgTWQ== X-Google-Smtp-Source: AGHT+IHUcnm8CYR9j1zgGm+1KuxQgfA+kXaV1Cmnmgypz0L1slw/O6gLEeL5JS99trh2nYCgqfPE X-Received: by 2002:a05:6a20:9594:b0:1a0:e180:8c5 with SMTP id iu20-20020a056a20959400b001a0e18008c5mr225156pzb.9.1708702031432; Fri, 23 Feb 2024 07:27:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708702031; cv=pass; d=google.com; s=arc-20160816; b=crvoQV0FXMsP3Rbtw31RdXhP96u1dgLJJlzPXIg45UPK41HKvH8VVXK2yA0oOJ4qoM FuFyGzhZLheFAtNdWSMHvQ2vqQX8JfU2HjDOMmE96hZtyo+eewAZqCwNDQQfbZJQsG0V GLVZCuyYrTstEIzSo+xagui1tfg3L5sBHyaDKvjBO42SjNFbh/s36UGobe9LBTI09nGt drjhLdyU9X+Zh3x/e9GdSyE4onhfr28BjsdR9W8lxNZoa82Vw9OBPZJrxayaUwuaa4YI NJL5h1rod4+2x0tuoNhEMb7HPADvamSuFNDo1/PRCJ2Y3QMeSbLxQAzIq3f50BP2t2yW W1gQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=8c6M6MliMw/e/VSwbYrk2+fgXiVrbnFvfE3g5rkfwpY=; fh=ZRW1OjL+vw4nR3zHw03SqmaugmDx4dJgwazkhUMUovE=; b=0qN5dUJjelV3JXv+mtNS1AQNXPW+L7o2laJ0SaglqooxcRjj1We4dRBxT7jo4SoA3Z fgqEq9rB4QfraGiyE3d7tuY466BGt8tzhFwvoC2CO42e0tEQ2H2JjRDu5a1dnH+epYOH YIsNuLLXY6gP/KtKupJRsTSosk+qcGe83wnvAsUPsRRn3YCycF6ADGBJ3v/dNHn6D4tY L7pRx2RMoq3NFHWqntwjAIzEDY1nRYF1IXUGc+Ty7oeTUUJebaGXsW7AVzUWh+YW9b/v vmFlRa2vTvN6eg8KArKb4kavG9M8sYCHfdFjZ15zcbPMRsza9LppFQlpx7lwm84ToCnY y6Yg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fOTuRidG; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78596-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78596-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id f5-20020a63f105000000b005e430f63a76si5486472pgi.449.2024.02.23.07.27.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 07:27:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78596-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fOTuRidG; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78596-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78596-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 9AF02284587 for ; Fri, 23 Feb 2024 15:26:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 35BAC12E1FC; Fri, 23 Feb 2024 15:23:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fOTuRidG" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AE2583A03; Fri, 23 Feb 2024 15:23:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701788; cv=none; b=hbec8dflC5S7s91RBP6pVaAgDhMczjQ7wEyy5Yo9ZrJVGcfFchxQWiTTQKq1z2Zz4IqMIHmJnXiNB2vcLevcdsIrjBSuXWhrGF5xjPX6GjmKkomLRgByRkJFR8vQjS2zWQTsfCNmYvgnXbcw/WOTDK2cmURmfcXVqv4NTWYkkps= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701788; c=relaxed/simple; bh=+MZNQen3wcYHTNycJniWNvbay9tcVWDXKsVdslC0djE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IBtIAcMEr1r2cRjLnROtygymYwemCt1EbYte3qNRWSONDkGq4D0j7ivfV3cvZyzdirUfdnnLjDdg3GJB7soglysIxE7hUU3e22+jKrCH1OpVWK8oc+59VcLCD+hJA6Nq8HL6JZ5231nBHgn2YXp8JYts7bJ4rTsGK7TERsfoHG4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fOTuRidG; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98205C433B1; Fri, 23 Feb 2024 15:23:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708701786; bh=+MZNQen3wcYHTNycJniWNvbay9tcVWDXKsVdslC0djE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fOTuRidGnMQVuYfe+pILwzBb1KejZ6SdNH5TybZzzp0ZE51C+sdgTDdjy3KDp19HJ zmvwwGLN7Z/gL9Kd2jBapVUZ/AN9825OlvtsFegQ+AWLMPq9uML2LKUj+sYKgMAgqf M7O+Qm0MHlzYf9FiHAZFV48eJEE3VGan9R9QP09tapmCPAiOU5WqeLwP5GFd4gV+6C +3PWB/iSV/+mEhlUoOts/CCQI584PNxJCPq4+T7zyE6GEePehLNTKfZAkNtzp9yHZG Dq53LJql+qwxam9g4WJU3cHTjIMqdtiODX+x4leBpT2cYWjsZBvQ6DXNlANPeCcgk/ fjkNuQfBDW8GA== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rdXOJ-000000005Fb-0VmY; Fri, 23 Feb 2024 16:23:11 +0100 From: Johan Hovold To: Bjorn Helgaas , Bjorn Andersson Cc: Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH v2 04/12] PCI: qcom: Add support for disabling ASPM L0s in devicetree Date: Fri, 23 Feb 2024 16:21:16 +0100 Message-ID: <20240223152124.20042-5-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240223152124.20042-1-johan+linaro@kernel.org> References: <20240223152124.20042-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791703941370825464 X-GMAIL-MSGID: 1791703941370825464 Commit 9f4f3dfad8cf ("PCI: qcom: Enable ASPM for platforms supporting 1.9.0 ops") started enabling ASPM unconditionally when the hardware claims to support it. This triggers Correctable Errors for some PCIe devices on machines like the Lenovo ThinkPad X13s, which could indicate an incomplete driver ASPM implementation or that the hardware does in fact not support L0s. Add support for disabling ASPM L0s in the devicetree when it is not supported on a particular machine and controller. Note that only the 1.9.0 ops enable ASPM currently. Fixes: 9f4f3dfad8cf ("PCI: qcom: Enable ASPM for platforms supporting 1.9.0 ops") Cc: stable@vger.kernel.org # 6.7 Signed-off-by: Johan Hovold --- drivers/pci/controller/dwc/pcie-qcom.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index 09d485df34b9..0fb5dc06d2ef 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -273,6 +273,25 @@ static int qcom_pcie_start_link(struct dw_pcie *pci) return 0; } +static void qcom_pcie_clear_aspm_l0s(struct dw_pcie *pci) +{ + u16 offset; + u32 val; + + if (!of_property_read_bool(pci->dev->of_node, "aspm-no-l0s")) + return; + + offset = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP); + + dw_pcie_dbi_ro_wr_en(pci); + + val = readl(pci->dbi_base + offset + PCI_EXP_LNKCAP); + val &= ~PCI_EXP_LNKCAP_ASPM_L0S; + writel(val, pci->dbi_base + offset + PCI_EXP_LNKCAP); + + dw_pcie_dbi_ro_wr_dis(pci); +} + static void qcom_pcie_clear_hpc(struct dw_pcie *pci) { u16 offset = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP); @@ -962,6 +981,7 @@ static int qcom_pcie_init_2_7_0(struct qcom_pcie *pcie) static int qcom_pcie_post_init_2_7_0(struct qcom_pcie *pcie) { + qcom_pcie_clear_aspm_l0s(pcie->pci); qcom_pcie_clear_hpc(pcie->pci); return 0; From patchwork Fri Feb 23 15:21:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 205462 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp656075dyb; Fri, 23 Feb 2024 07:27:10 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVoCyvHiOEErzCpH3pVngNCu6SGSk2QhifR4zWpeiSjnw1n7ocUWpy2RKpSpWIUYy31xaPuinibzMo4SacaFJoCwaLwQg== X-Google-Smtp-Source: AGHT+IGPQgigCHFD4tWYmQs9fRXkeQ3/sYBqyTwfyC8Nsxt7PgdBOnkXTOvCRx+pyYN6Sy3hld5g X-Received: by 2002:a05:6a00:9285:b0:6e4:8d20:66ed with SMTP id jw5-20020a056a00928500b006e48d2066edmr153434pfb.3.1708702030004; Fri, 23 Feb 2024 07:27:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708702029; cv=pass; d=google.com; s=arc-20160816; b=bT5Zwe5vF0DxHNsMs01FVnussmEqlgQD3o+CKK0Lyqsp56FZrIchI4jchRM1eg1zMK j5aM4UuCrJ3mt5uhgKHmwlrUXFTo/VikbdKDGbz6/znXc5rEwnluQDxGe+hitH7C7ZUf kpZZ6IKtrDrpLxyvd98tIPgxdlDqor7G1p3pXNZ6E4Pc9OAWiXMPz4mYxSYbm5PlvnVP EQN9lSPuK0i17yaqGechVGZanthVQA33sFrH/9UNvipn9QGJDD2VGgIBy+WVgJTjXCAK X4lJJl3pGX2kUkqHHqWez+kqD8rTbnRuTVgiL4706qaIm56rO8wDJbUjVd9vvh4jqTY7 95zg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=YLcX6fylKmdj3Sw4nCdj89OnYwk+QjNeewPc/JpgQ5g=; fh=ZRW1OjL+vw4nR3zHw03SqmaugmDx4dJgwazkhUMUovE=; b=dXGWcZIqxmAkeBrdXuNGVSFFedkps6mK0cZCthVa795La/zFopZsDR7tj1K+vPl1J+ jKpuaPcBvxmdDEy9P4daRPskufIEykz6O7fnV16iF11eDXvqd1r43fNN08dlvEfpJYoW 4uf7BoK1TseEnoLZzbT/Y8tSRurVYokI64u8GO2zPlobHNe9sQQB4UmadGeOFVQ7fMmN ppkUxUf6RO4Y0xFgV/O32sNuGljrghWfTffwVLuYTlB3O8vH8ZzkPtF3Y9czGYQLTkVU VCNCnLRhccoHdPnR+6s75nKg4YnlxuemaX+tZ2M3I55mxmjZ+jZ8q4B/CKZG9T8s5lAz H85g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RiMkzcS5; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78598-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78598-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id lb12-20020a056a004f0c00b006e376b9203esi11087043pfb.213.2024.02.23.07.27.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 07:27:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78598-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RiMkzcS5; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78598-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78598-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4B49E283A9F for ; Fri, 23 Feb 2024 15:26:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 45BDE82898; Fri, 23 Feb 2024 15:23:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RiMkzcS5" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 710F882897; Fri, 23 Feb 2024 15:23:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701788; cv=none; b=i+v1w9TE4n32L/Vns6i+Pfb9R6aNjEw3ttjbeUvy96Cw4dlu4Slc/rBEmYzc0NGb8AhuEMA/C+xZM9UWAsd/GxfmCx9lmuOB7s8+hVUC7GLJMZr3BAVCnpnJKEXynWEhoVsJv0dw0umUd+XS5XghEN9GMNOSly9Yiy2s4HSjwMg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701788; c=relaxed/simple; bh=gJZHjSh3y+j7s4q6gU9xs2cqQ5VjywqHBbKDaqt8bfM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AjL9OCuZLrvwXPKJBDUnoS5igpjZYuA91F4zumxkbn5vX3j5CKXGZc1VqrhrRrCew68rW7FCtayy33AsVyP0kX/YkvvKdEfLd0B+AEHb6pZ51lSuFlo/E28z2Ce84B2C7WqDtOH4Mg6g6eTJXMXOrCDPuEpUlg1kJsOZwjrK1tw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RiMkzcS5; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9BC6BC43330; Fri, 23 Feb 2024 15:23:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708701786; bh=gJZHjSh3y+j7s4q6gU9xs2cqQ5VjywqHBbKDaqt8bfM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RiMkzcS5oV2wh7PEl8kSNanLJNv9U7lFD6i8q8LVXxXNHLUXjNvxiuc0rYsong6Wc ssaUlKFv2vUQxAvUh5ohXotOVix5xcW6mw0RzrerVcMqjFetoIlEERDmqr5mce6Qcc XwnYtEkq/uLvlQRpceVaADrgfs9Imbm+dGSZqIgHIwtBcxkdEhBRt0N2VYIrLO/Vt0 sp8ZyJ78zBABDxRmwmdR2VcxdeiT5HdliQYerU4Hz/Jv+sqYfnLXkbCs/sq2yCSsQL bzIviGKvXSsQ3QW8HIMa+y5YX0YE+ktaMj0f6cCVBqChoIby88UN58LnYLyJeNguVV LGkJxduKxYYHQ== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rdXOJ-000000005Fd-0t1U; Fri, 23 Feb 2024 16:23:11 +0100 From: Johan Hovold To: Bjorn Helgaas , Bjorn Andersson Cc: Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH v2 05/12] arm64: dts: qcom: sc8280xp: add missing PCIe minimum OPP Date: Fri, 23 Feb 2024 16:21:17 +0100 Message-ID: <20240223152124.20042-6-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240223152124.20042-1-johan+linaro@kernel.org> References: <20240223152124.20042-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791703939884946618 X-GMAIL-MSGID: 1791703939884946618 Add the missing PCIe CX performance level votes to avoid relying on other drivers (e.g. USB or UFS) to maintain the nominal performance level required for Gen3 speeds. Fixes: 813e83157001 ("arm64: dts: qcom: sc8280xp/sa8540p: add PCIe2-4 nodes") Cc: stable@vger.kernel.org # 6.2 Signed-off-by: Johan Hovold Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index 0a40b8dec14e..95c7b746407f 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -1780,6 +1780,7 @@ pcie4: pcie@1c00000 { reset-names = "pci"; power-domains = <&gcc PCIE_4_GDSC>; + required-opps = <&rpmhpd_opp_nom>; phys = <&pcie4_phy>; phy-names = "pciephy"; @@ -1878,6 +1879,7 @@ pcie3b: pcie@1c08000 { reset-names = "pci"; power-domains = <&gcc PCIE_3B_GDSC>; + required-opps = <&rpmhpd_opp_nom>; phys = <&pcie3b_phy>; phy-names = "pciephy"; @@ -1976,6 +1978,7 @@ pcie3a: pcie@1c10000 { reset-names = "pci"; power-domains = <&gcc PCIE_3A_GDSC>; + required-opps = <&rpmhpd_opp_nom>; phys = <&pcie3a_phy>; phy-names = "pciephy"; @@ -2077,6 +2080,7 @@ pcie2b: pcie@1c18000 { reset-names = "pci"; power-domains = <&gcc PCIE_2B_GDSC>; + required-opps = <&rpmhpd_opp_nom>; phys = <&pcie2b_phy>; phy-names = "pciephy"; @@ -2175,6 +2179,7 @@ pcie2a: pcie@1c20000 { reset-names = "pci"; power-domains = <&gcc PCIE_2A_GDSC>; + required-opps = <&rpmhpd_opp_nom>; phys = <&pcie2a_phy>; phy-names = "pciephy"; From patchwork Fri Feb 23 15:21:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 205460 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp655434dyb; Fri, 23 Feb 2024 07:26:04 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUHVRy3M9+bNEj3GvwgFiKRwH25XxEAVtnVIcB/Sw6QdnhHbE9v/i3W4dhMFRIzU+g6AROE+bD/zXRN0OlJbZDYjIkeVQ== X-Google-Smtp-Source: AGHT+IHaUwqVKRA6UAK5QR8Tll8JhgQkyXUJGzrrPlgnv1Wzce85bvXZflak2yF9NbJEzt0LojDy X-Received: by 2002:a17:902:d2c5:b0:1db:be69:d02d with SMTP id n5-20020a170902d2c500b001dbbe69d02dmr130400plc.32.1708701964720; Fri, 23 Feb 2024 07:26:04 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708701964; cv=pass; d=google.com; s=arc-20160816; b=JwrLP3r+KIvsWpFypgwg2H3KFDm4W4WZj5/t16u0uo4G0RLaw8CEzPzg6uFL2zGzsN q+3REtWAj/RjmuirMMfLUPpRpiMG235hkZosZ6+STigjSdAXhYVdzgyLTjevuZQHv+F4 JSNYHoB3GzVIy6giLo+7HpSGEi5oSY4Y+pf4G21UqTvobNN6NC20kCo95AFZgV5+k73P b3+iBBOYc4yD8Q1PTb8Z4DA6lUi7mboWTPRLIHqV2JybpxIGRDvE75yrUPnFmt4nWciT NHWNVOReDAtytCa1mYxXmQSJYwqkgn8T07icMLdgF0MMElqRSJIQ2NPmyBQxwyf2QGqq Q8BQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=uFlBA9AFOoNC8lpp1Bj1l0UsHfLtjI6lYrwRF0BEtqc=; fh=ksFR342kkulMuv+0q94BrHeEzFBbdZfbM5STU9uX3MA=; b=XYufDBR7log07/LwPCpCymFiw+OSZ7IdHsaOa1NtEAxlKf65G1UpgwylWJKil9InoC Bz18HuRyyZlNmP6scRA/q8qW9Qyv5xV6dVo0Q3hsCADUjnjWKr7hn1HywoxY7cjCAZXN KGmNcdiCNCrkP3dnQMYNgpCZo/n1grhwEDMkhKvZFo28+pX7jN/SoB9mLw+aF1xeVb7h M17DHHnfHlA+/AuMfXBAXlUJRVa0fq2hz085pIp/4t+c7rW/LwV9hl8iBlxNg50vM4aI CUcyEL2DSKJYTJ815VBFc4R1rGazpqcdyJYAZg0RFWnVm8go9ONcs8mnuckoR/vSWTrX O8MA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cXTUmzaX; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78592-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78592-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id lv4-20020a1709032a8400b001da0fb6a655si12677972plb.92.2024.02.23.07.26.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 07:26:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78592-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cXTUmzaX; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78592-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78592-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 32728282B4D for ; Fri, 23 Feb 2024 15:25:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E125D128397; Fri, 23 Feb 2024 15:23:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="cXTUmzaX" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C7A0839EC; Fri, 23 Feb 2024 15:23:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701787; cv=none; b=nK2b6Duu4Jier3vGZRlkgCSP0cOVEn/1Ia3xkMT0Zt0/pMKg7/z7rHZV2DyoHmFy//4endgYJ3LDgQJN6ckQ9V1NsEoJovXXOnXzQtlXymXW2oilOyoKDLWZDtrrxdQeYQ+pFLXpMNtD/T7RkrdR3rSl0YLF/IUSqMD2GVht074= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701787; c=relaxed/simple; bh=hKdAU8xGeWoBEDF62SIFZ8ycEZqo56n2cRdtQJsOYWI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BGdwhzOJJ/YuvjpGuQvOGzzkOjUatnLZjGMnr55zWUnhG908YdOyd1WO1pja3CbSw98DIOvSKGrZ5Yv0kDQM0owyCWIxp8O+r3KW8zqTXRlAXFzCvQVLcLZKQuWavGCz8eaQKqG0WPaMV7IixcQI/+shaNeoOHV4BZMZDCHOpOQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=cXTUmzaX; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 852CBC43390; Fri, 23 Feb 2024 15:23:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708701786; bh=hKdAU8xGeWoBEDF62SIFZ8ycEZqo56n2cRdtQJsOYWI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cXTUmzaXMkILnO7RQP11RNpxQxwSqANnovUfeLsNj/+qwgrEIDdtEsiEC3SBLJa7D zCN57TEjBeF7KkzYGum7kYT5t2cEST8NtvRFz3IdjwHCb1jbmhNgPEVhn32aZCYdq1 kq56BfhR7wynQ1vQpmCypa7P3SnCbmH+t3PEFPH0YVnMEhBmEKM+NG0OKKXDpfRyoB 7o4YCezeFA6Un2PCF99Yuw3zoq6IT5SS2rEwrAm/06o/BOAXpgj6D2f+Sy0bofGHGP adGEbKQnBfZjcXtf7GhjbB4Vwjz1N4KBAYkUbuXEiNZF3uM2U4V/zfvhjgF6WfwAHB oIxUTvAjG3SFw== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rdXOJ-000000005Ff-1Da7; Fri, 23 Feb 2024 16:23:11 +0100 From: Johan Hovold To: Bjorn Helgaas , Bjorn Andersson Cc: Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 06/12] arm64: dts: qcom: sc8280xp-crd: limit pcie4 link speed Date: Fri, 23 Feb 2024 16:21:18 +0100 Message-ID: <20240223152124.20042-7-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240223152124.20042-1-johan+linaro@kernel.org> References: <20240223152124.20042-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791703870996616239 X-GMAIL-MSGID: 1791703870996616239 Limit the WiFi PCIe link speed to Gen2 speed (500 MB/s), which is the speed that Windows uses. Signed-off-by: Johan Hovold Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts index ffc4406422ae..41215567b3ae 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts @@ -563,6 +563,8 @@ &pcie3a_phy { }; &pcie4 { + max-link-speed = <2>; + perst-gpios = <&tlmm 141 GPIO_ACTIVE_LOW>; wake-gpios = <&tlmm 139 GPIO_ACTIVE_LOW>; From patchwork Fri Feb 23 15:21:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 205470 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp659442dyb; Fri, 23 Feb 2024 07:32:42 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWU57SZr52Hpf4LoS9MCuT10NWCmu5r8PIVadtlKgXtXaiWuWh36hTL4jxmWYGGQO70yydituw5nRmt5Ic/ETOln6oyHw== X-Google-Smtp-Source: AGHT+IGUL2uL9i/p9s25IvCTcVb3HUMFx61PPDqlJybWGNUJc9rNNC/bi52BWGjcz1jP7w3gpgPj X-Received: by 2002:a17:90a:f40e:b0:299:29a5:d575 with SMTP id ch14-20020a17090af40e00b0029929a5d575mr143738pjb.12.1708702362669; Fri, 23 Feb 2024 07:32:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708702362; cv=pass; d=google.com; s=arc-20160816; b=UrFR4IECMauOKf8LiU6XddoHNgeOnMpGOpzVl9wPDaN71btlbrOhtPwCBIdxTAeau/ lalWk6JAoKxCwVwy0jYloXQeMF49YyRJINNH//QT0oGWTY8KaHShy9V7M0eYYhQ6SFcZ B/uLRmLylUuKDYZ52EiyGVK4t2szrovO4u0zG+rX089MIkt0F31YgkOTpmfy8HmFBmn/ 0VB6x6savpHPngby0fWp1Qd4RBDFhAkKbWMNysxdmYVCGTfwEnSnp4u5WJ/RmbEKx/+Q ijr1WH8eeZi2Q/7Q9T9jyL5A68VNlftB7c1J6I6IhZospQ/eY5Qm4iBr/3U2qX4yBU0e lYjg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=/okRQ4Hzvp5Pq4graNICin0vznqA/QXcLCDpAQpwkeI=; fh=ZRW1OjL+vw4nR3zHw03SqmaugmDx4dJgwazkhUMUovE=; b=Zr2TMY9c+CBZmmlq+yhEz7Gkf+vEKCJ82iUb1PePqLaAg+JMDWmno6TcOxeUTNT6bB qvV59eSFF9FcN0kqCK/2dzqlxDNHRStzaOEavTcDstzu2jrbCB/YIp077PSJOktzJh40 aVtkMKf5TOUUE8JfTV8kr3zLMn0lDa1EWcbPrbV8+374tqGIE0aBjEXBuIR2+qJkBsN2 mJmsPxppBODs2IiPtIWKmGo7eXSNTbsANSdzSKe/lQXB19BA9s1TQ2xyOaqSWxMLeKse ec2Bxu9DKrT4JGMRcYcJYsLjS6ad/TUoozJUbNdppua7//pzO/sKwI3r9ycdDFMNAU77 3P1Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QMrhpPkq; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78602-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78602-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id ds13-20020a17090b08cd00b0028e63fbc789si1348187pjb.107.2024.02.23.07.32.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 07:32:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78602-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=QMrhpPkq; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78602-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78602-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id EF2E8B2564D for ; Fri, 23 Feb 2024 15:26:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3725012EBC6; Fri, 23 Feb 2024 15:23:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QMrhpPkq" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6893D83CC3; Fri, 23 Feb 2024 15:23:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701789; cv=none; b=mOO5sZKYspBS4ZC2AnFU07tqw9iUmNpLOl20fV6NCmPnn/svHz+iquyfANXYii5Kae1TNO2d1nTM+sjLWxxbVcqdxmnUY7UIwuYpl+RZEgBj0slKFxbedo3S93sFIFYUfF/AyH40xOMtwtcSPbbdCvP5EEBjFmumnUj9WZY2OrU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701789; c=relaxed/simple; bh=OWj2b5i7fpfFVzm3D5FLX7tedf5qUfedcLWseSq8y7Q=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gWNseEvwfg3CVg4Em64aHMzUurlDNDliN3nP47UXO+dKaa64gmOlhfegf+TCu7Uih6EzF0ipPjAHnB7B/cizeXr7HEucRsbCWlv9uNdoygKUX+xGYu7DX/C6Y48aGznF1UGje/2ObutmyAywTofHb3WWAq5ltLIZfBF+p0EEf98= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QMrhpPkq; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3C76C43609; Fri, 23 Feb 2024 15:23:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708701786; bh=OWj2b5i7fpfFVzm3D5FLX7tedf5qUfedcLWseSq8y7Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QMrhpPkqFG9r00mtXMNDXeW0UgnlRmsYPdHbyg/9/4Z0HEmdvntpW5CGszqUtomla B+EPNYxM2lTEWEirudMCLMviRTm9sQPqwXZrL9zYTIjn2gsYMJCX9q+BxKrGDpc4cx YyKPwjDbXwaqfZoxeHZG9GjXD/UfKyCkK8Uf4oy1NFCfeuuCcUbMHwDRGpbfRw1lzs nRBKklaoM1guPH/h4JCPEggS4Ton0f8E9jMSlkRXpriINSLhY/5xKbLBoPS1HgJqWs 8NumliXEAp6iJN/qM2FrnRQejdl0UECHN7VoaSTjEJaK792mlHVYoUjvEOnBQ0pD3D WfuUvasNTOkBQ== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rdXOJ-000000005Fh-1XsO; Fri, 23 Feb 2024 16:23:11 +0100 From: Johan Hovold To: Bjorn Helgaas , Bjorn Andersson Cc: Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH v2 07/12] arm64: dts: qcom: sc8280xp-x13s: limit pcie4 link speed Date: Fri, 23 Feb 2024 16:21:19 +0100 Message-ID: <20240223152124.20042-8-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240223152124.20042-1-johan+linaro@kernel.org> References: <20240223152124.20042-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791704288700016750 X-GMAIL-MSGID: 1791704288700016750 Limit the WiFi PCIe link speed to Gen2 speed (500 MB/s), which is the speed that the boot firmware has brought up the link at (and that Windows uses). This is specifically needed to avoid a large amount of link errors when restarting the link during boot (but which are currently not reported). This also appears to fix intermittent failures to download the ath11k firmware during boot which can be seen when there is a longer delay between restarting the link and loading the WiFi driver (e.g. when using full disk encryption). Fixes: 123b30a75623 ("arm64: dts: qcom: sc8280xp-x13s: enable WiFi controller") Cc: stable@vger.kernel.org # 6.2 Signed-off-by: Johan Hovold Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts index 2c17e137563a..a67756ada990 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts @@ -768,6 +768,8 @@ &pcie3a_phy { }; &pcie4 { + max-link-speed = <2>; + perst-gpios = <&tlmm 141 GPIO_ACTIVE_LOW>; wake-gpios = <&tlmm 139 GPIO_ACTIVE_LOW>; From patchwork Fri Feb 23 15:21:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 205465 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp656159dyb; Fri, 23 Feb 2024 07:27:17 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU34MVJUR6V7aQAKg7eUui9uy0L92Df457VPCopNM2ZnH8VtVScF4Zv2LyklMTyy057CdlWW2hQdfoTjFQDl+L+LV+OlA== X-Google-Smtp-Source: AGHT+IEr6jKX5GPakF2y+vwDEZSNRTA9sRRcpTEvo5EILtl/yTaW+tIF6GA7LRpdFlIoCDpV5vsw X-Received: by 2002:a1f:e602:0:b0:4d0:36e3:40c3 with SMTP id d2-20020a1fe602000000b004d036e340c3mr221279vkh.13.1708702037037; Fri, 23 Feb 2024 07:27:17 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708702037; cv=pass; d=google.com; s=arc-20160816; b=NRDdT8QL/KfQc7KLROHGH9+2sYmwwixHxk9vSBiuoEoyXzTJrrzd1x32vJDzEEDYI5 qoQ2xnuzJMkOSn9IbN5uPzEPSP0NjthXiIFC+EF77f96P5Uft4YyjEJW1Yq20y8HdTB2 y8s+kg/fYZcYj9f0TOH6WWweVBV5U2fM3thPGHXY4wJpurm6fpPGEthY2318iKeBNP9I NLLhMm/W0/i3mL07vtbsqIW4rQp+pN8CfXNeYzMQTEw3s3XO71G43NqLq+xGUJGSk3kP NmnNhA5r37FvnmSyihkfv8oso41ptnYLhDdEFoLjkYh8eRZ6IFYTVSKuONbqkSH/g9dP e0ZA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=49WVUkHv4vCD4hshetBWMm1XuEeBsg8ErgWCpyNt4lo=; fh=ZRW1OjL+vw4nR3zHw03SqmaugmDx4dJgwazkhUMUovE=; b=ncHN/UptlvIqTXyTivfTE2V8dqy8Yw8meNUzZWzZoOVuG0ybPn2csC/oeB+sTRtGue FbAz3E/zcwjC1flgy3wAPSduxMsolpRBhovzUfzSbAti7BUaWICvSTiR+wxm28a190dq dsgBgDdW2MuP+A9HzcCDTgjSVirrf5ZQmIJCu05H5jg6QB+J06c1W2ro8B3NkiHaooHQ b159gvv63M0IBcBRHcueNn6QHbm0dkYy6z0nMTN24CaIA0cr8BgFtG/60uQ4OmMoQpXG RXyNiHbYj936BvsWdnwY8YtUswz/XA4DQsFXqVblImtdoaW88EQVdVVJfys4uC/LysRP 2BOA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=A8zvAImA; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78599-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78599-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id f14-20020a056102150e00b00471b3382471si1072253vsv.273.2024.02.23.07.27.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 07:27:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78599-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=A8zvAImA; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78599-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78599-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 295B11C24A07 for ; Fri, 23 Feb 2024 15:26:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6422712F379; Fri, 23 Feb 2024 15:23:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="A8zvAImA" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 280E383A0F; Fri, 23 Feb 2024 15:23:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701789; cv=none; b=FOa4kPp5vAFuv/P6ne9fQg4FOtO8rzx6+ZTK/ie7RFy00HdGFq4G71GXG3T4TJpD4HngbTyo0/rkJCpZa2ESqapDWNKImWLQhexFz0ETCP42boMnU4mhbmGXc0trjlrwVDA5HFTn2Wwcvg4TbzjApiLQzg8BwtGEpBLF1oshDaE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701789; c=relaxed/simple; bh=N1lJfJsT0X5pb0MCpBJjAnSC5f6053KInsrfpjOCKaY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NP4ozAEEf+kPksVc3r4H9SiGC/q5ydI3U9Z7nwfog8WMk6VpCuR3oZyeSfaPOFwjlbA5DG0UxwMcit5MlAyRx/1V3ABaVMU5kCbJusmUGmuG+mm00qK7KLiBH760O1fGfN+AmUQo3VOx96tRb0YFMq8QXd4Z0P8fl8ECx71Aymo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=A8zvAImA; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A130BC43601; Fri, 23 Feb 2024 15:23:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708701786; bh=N1lJfJsT0X5pb0MCpBJjAnSC5f6053KInsrfpjOCKaY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A8zvAImAr1MqUBYI5vxImRdSOuHk2sxTSfrG62ZHC16ADhX8y+4DNiagcklJbqwre O2IoWidiH5rqUjXaoTZ+BbSRhl03S8xJLDBu0fvUTAGmsNGZC7UU/5Zh9UmpBezh+c ZeKH5L8y3HsWb0sYv3MghGApcXdMRxhmpvUtepst2VTr9WddM9BFj4DUSUkFXIlpfm fjQMlxLaZeidHtvXCaLrjyF3zf3lIX23Q12qMAKPa0KAs7JxpdVuoqkmGE8Zm9xUCW CACDdJhazbYCG6sCFbI4v7VIYf5c+bSEWs1TYldrtmKJjTXeshPAaxUSjA2UgkUojw ypuqfG1Vc7uZg== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rdXOJ-000000005Fj-1s8o; Fri, 23 Feb 2024 16:23:11 +0100 From: Johan Hovold To: Bjorn Helgaas , Bjorn Andersson Cc: Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH v2 08/12] arm64: dts: qcom: sc8280xp-crd: disable ASPM L0s for NVMe Date: Fri, 23 Feb 2024 16:21:20 +0100 Message-ID: <20240223152124.20042-9-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240223152124.20042-1-johan+linaro@kernel.org> References: <20240223152124.20042-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791703947580221132 X-GMAIL-MSGID: 1791703947580221132 Enabling ASPM L0s on the CRD results in a large amount of Correctable Errors (Timeout) when accessing the NVMe controller so disable it for now. Fixes: 9f4f3dfad8cf ("PCI: qcom: Enable ASPM for platforms supporting 1.9.0 ops") Cc: stable@vger.kernel.org # 6.7 Signed-off-by: Johan Hovold Reviewed-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts index 41215567b3ae..7e94a68d5d9f 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts @@ -525,6 +525,8 @@ keyboard@68 { }; &pcie2a { + aspm-no-l0s; + perst-gpios = <&tlmm 143 GPIO_ACTIVE_LOW>; wake-gpios = <&tlmm 145 GPIO_ACTIVE_LOW>; From patchwork Fri Feb 23 15:21:21 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 205464 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp656095dyb; Fri, 23 Feb 2024 07:27:12 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVsiOGc/NLzIjpL7nxZf5dT3zR0urPE1nTmEqI7bIPrTb1+T7aEGIseER1GeFeG9q3A7wYw6xvhk4jm+Hcqb2RcZv+T/A== X-Google-Smtp-Source: AGHT+IGfV2beiAiWRaCDc/GtTt6si6wu/KcuyxwOqBm9Gg57nU2pc9lMuPIRf+71WGNgK20kJV1U X-Received: by 2002:a17:902:8495:b0:1dc:d12:e21b with SMTP id c21-20020a170902849500b001dc0d12e21bmr130702plo.7.1708702032037; Fri, 23 Feb 2024 07:27:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708702032; cv=pass; d=google.com; s=arc-20160816; b=JWdQ61qjx/rXjJTqOOvvJfOrz94iuLkD3B1F/AKShNj1QPKhCnUTQY8Yfu0geRxFU/ VKqro2RG99V+gkHrIaR6VeW+Irvcnc4ydLCB4jIsT+LPiPM5W8ZkD2GUpAOGsyM2IiyV hir5rCAc2G6duMP3vKuYtO27p0IZXv7S3k+hBvQNGwtbOdzuoYuPxhuc0zvO51kXpPU4 zfMA2Cf26D2HK4v4g7NIIoMMp9Oy4YFXiLPHwx1FszqhkM9l7FEfEyy4PUYgwKMNGoHf To6tz1rO24xi6mJfUa9MaAwsVoDOfn4vmoA3i7BEul4sZ429HkSW9vH9ke4HvcQGb34L hODw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=29Itx7Ra7wIjlmG86RpangRSLn5Qh754cPCeJ0/9imU=; fh=ZRW1OjL+vw4nR3zHw03SqmaugmDx4dJgwazkhUMUovE=; b=0+SFBBqnpI6200KhPmIUGQoR0eoqdSOfZvYkU4Tt4+GPn1di/e4mzpfgdAxXgFQZpS nL57sAz3xxF95DODJYKhOnC8gpy5Zj9f6zFzPoakGv83+RvgsKQjwHIX4n7HcPaQ+9Sj NswGUQrZ/Uv0QhPpNGmFvO0GujysdCDFnCyExHvNAp9hj7JRQLoUYWSFsYhRik6W++GJ uvDqBskuilPqHb1wFn5k7s2eqL9MekXETpopudXHoIQCojOYdlD2+JU7A0Ko/G2PztPO cLjTLi5feWvKmuh4SAL0ZGL3sOKSO1aBS0coV5xFGNq8Ktb6YVlNCR/2SAT6Tvu5EF1E qawg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gOvQbWkD; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78600-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78600-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id l4-20020a170902f68400b001db3592bb36si11055456plg.279.2024.02.23.07.27.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 07:27:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78600-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=gOvQbWkD; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78600-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78600-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BC162283272 for ; Fri, 23 Feb 2024 15:26:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6D1A684A3A; Fri, 23 Feb 2024 15:23:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gOvQbWkD" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 271788288A; Fri, 23 Feb 2024 15:23:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701789; cv=none; b=fLt0eeRFhyWL6okvqf+x8tEEPxALMJl833mYOFR03MpwRjVuvH2XUqt5F3/fm2asleScPQ0+Yy0fAK7tHw+BBDYi5G7/fXPXME5JCJtPfUH/f46AcWdUJ2Chj0GeeKrsN00LBzrqUwA/emGJL8+3tPeIhyxd2MbbUq11bejFt5w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701789; c=relaxed/simple; bh=CrZ5ilwQu4dqM9fOfVslL0lVToxLm2aDUIvFF2TgBD0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o4NuPQ19IIF8P/Cr6s8B09hDVkMqrDoDhJJk2ZrgqByh5vD0jde5uYsXor4bBxGks0UARS/Dwz2LvIBpHfdVH69d6iYFVdLTHZ6YkSl2ld3sBnlo2EDTNIq5E+z6Ptqoq234OLTyXJqt92iKMFAiQDm2aERnWsyldNmWgm0nLOw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gOvQbWkD; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A192DC43141; Fri, 23 Feb 2024 15:23:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708701786; bh=CrZ5ilwQu4dqM9fOfVslL0lVToxLm2aDUIvFF2TgBD0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gOvQbWkDRnfkrzZuP2H2k7hnyQfaBAfjbnY8Kc6FcUaAA+StKmWwvUHaCKr5LoRzy EVmK6oz5NpmMom+vxhAhKxmFE1P23Z2zvWndfXUuGWrq3uwibD0igZDeqBUZO33w75 4ais53pwKx+xXyT4gc8mcKwIf4tjym4sv0E0Dkv2ufGjup2thhi4HwBWE241Vif/4N LgdEhOTWlLxAH3atanshZYLIUCinr9KN6PDpsRvAez0HHjmxAYFemvRWkZJkSMt4xA l9ucolIypeabofmj8tspxb+Da+dGW5dockGI7mIeS5uYdTWAGjI0KZVKkUfZqUd5YQ LyyfMQBlLr8cA== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rdXOJ-000000005Fl-29ue; Fri, 23 Feb 2024 16:23:11 +0100 From: Johan Hovold To: Bjorn Helgaas , Bjorn Andersson Cc: Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH v2 09/12] arm64: dts: qcom: sc8280xp-crd: disable ASPM L0s for modem and Wi-Fi Date: Fri, 23 Feb 2024 16:21:21 +0100 Message-ID: <20240223152124.20042-10-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240223152124.20042-1-johan+linaro@kernel.org> References: <20240223152124.20042-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791703941969137009 X-GMAIL-MSGID: 1791703941969137009 There are indications that ASPM L0s is not working very well on this machine so disable it also for the modem and Wi-Fi controllers for now. This specifically avoids having the modem and Wi-Fi controllers bounce in an out of L0s when not used (the modem still bounces in and out of L1) as well as intermittent Correctable errors on the Wi-Fi link when not used. Fixes: 9f4f3dfad8cf ("PCI: qcom: Enable ASPM for platforms supporting 1.9.0 ops") Cc: stable@vger.kernel.org # 6.7 Signed-off-by: Johan Hovold --- arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts index 7e94a68d5d9f..8fc0380f65a0 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts @@ -546,6 +546,8 @@ &pcie2a_phy { }; &pcie3a { + aspm-no-l0s; + perst-gpios = <&tlmm 151 GPIO_ACTIVE_LOW>; wake-gpios = <&tlmm 148 GPIO_ACTIVE_LOW>; @@ -566,6 +568,7 @@ &pcie3a_phy { &pcie4 { max-link-speed = <2>; + aspm-no-l0s; perst-gpios = <&tlmm 141 GPIO_ACTIVE_LOW>; wake-gpios = <&tlmm 139 GPIO_ACTIVE_LOW>; From patchwork Fri Feb 23 15:21:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 205461 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp656054dyb; Fri, 23 Feb 2024 07:27:07 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVtQkAST2AtW3an1lbcybOJvRd9jb4PJ6qvn2T5hbKoPfZLxsapBcDTsWuq0OenWm4sfTCdYOXDNIIPBBbZ0n+VoFU78Q== X-Google-Smtp-Source: AGHT+IERQcuETTG8k8QHw5MB63NVifF6nbwWuDjs9ShqzoAZeogqOpv7ncRi3ZnekKsm3YVWNW1C X-Received: by 2002:a17:906:338b:b0:a3f:c0bd:6693 with SMTP id v11-20020a170906338b00b00a3fc0bd6693mr54392eja.52.1708702026783; Fri, 23 Feb 2024 07:27:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708702026; cv=pass; d=google.com; s=arc-20160816; b=CVtzpEZiknP5scPpw6my8xoUDvYBIZ6aIoo65Bs+WdTFpqNEuwV9jAA4gw6b8dj7rR okdUVlwrCgaIEQt3GdQJpC1Y/mGmQABYFelGvdygEMkcVlH+vSULJKs4khviNHDH+c6r E+YEDMwDDGEcWtnzFEMIxrYhIGHT0jyb8bs3y1cO8u1T4GiXHfJOPvIrpFfexIEALQH/ 3Ai/kDvQgv6V/S4mzWlDtjj3V0z6Qkg1uBE0VBaeeiXG7646ePwfOyGs+tGR1ixwXMsA JOlHJkqs2NOJ6pex8sCpgLTNUkdXEFZhz5Mnh4Q6RkR0d/kQa00sa88+fa8ymSwWWKQ3 B97Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=+HeBUEGnJFn1JJAJmXomvc8or3f2oHEJAoCuVG1Da8E=; fh=ZRW1OjL+vw4nR3zHw03SqmaugmDx4dJgwazkhUMUovE=; b=vQMXm9V6gWWhotDFwqL7crlMvPV099U5CMXIax0UhWmzn1I4HcTzL1owmyxSNcyoti MxDwUR595G2gHblgeb+3NgdX+gPdIN1OvB0ChnmcQT5TESSHtgiy1yeBmKCZIJY2fFH3 33QYzmjwV3/y5/pEQrVZ7jhr5neWt6WUiIQoUQfiTW0w4zZqZ8e+DFJnGgzCIr6TF0TW 4qdV4IqWC3W15J3THsUcPDHiBzn+HfShBtAR4qHHd9q3wrin+EfYTTMSLCE1tB5wFBRv Pru8R7YmFPJa5gRmwVEsCt8R80RnupXFNgpzBzffU4ER0K+bPl4C1UA9to4YdMB0JXhI TsjQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uRY9ySyF; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78597-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78597-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id n4-20020a1709061d0400b00a3d95693200si6272311ejh.591.2024.02.23.07.27.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 07:27:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78597-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uRY9ySyF; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78597-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78597-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id AE0481F259F2 for ; Fri, 23 Feb 2024 15:26:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6057B12EBFD; Fri, 23 Feb 2024 15:23:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uRY9ySyF" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BF9483A0E; Fri, 23 Feb 2024 15:23:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701788; cv=none; b=PfhPz7E+32a4rYOWwbD3hzUG+W6bOVqxJKjLUdTcq0zWxw2Q73IA3MIv+GFaQq9LshZ87sR/i3uq5UulrVd7zemSZ9txVEuhiWPoqXIR4m8YVLKAmuUaxm3rgbFXqSK6x0+OjMpIxWbeX78c2r/CJykWms1ePGVxyVTOFDvzFYg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701788; c=relaxed/simple; bh=jVZUt4YG+wPeP4sDqHFS9RcmoM+nVy3+c7gqaqdvxNc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X0IccknntARvR2NskJz4pUGpDEBkLptEIyVUS5FwoiXncdd6lsrv9SaD4Z/QL96G6QhTnh2Cm9FW2vwGXBeIQLLW334aIsi8auZUIAvjlERAjpYftkdOOKEje3fqer8x187tWJU4j+wvU7IlYXS0L/0JTzhSNOZEaWqvAQaBVDE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uRY9ySyF; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95172C43399; Fri, 23 Feb 2024 15:23:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708701786; bh=jVZUt4YG+wPeP4sDqHFS9RcmoM+nVy3+c7gqaqdvxNc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uRY9ySyF+q/Bqrj1OVKddGDpv1hliLUQkBbjGwzajppkTt/imWCpi3zjflQf5Gnf0 jZupC3jRkOpAyb74BHUzODkJClItg77QjE/bwy31Q1p3OfkutaE5ftbGDd9BdDuHO7 ls4Ildmwurs13GNyzDlMfhIZnM5YDw33oA3h8Lg820WcVCKMntpKVeBJJFGxqhkBSZ GwiQBFT5YVqf9JAPh7lzBJB25tqAhDPAuyLy6uTQR5Tamcv+4p577efVtzmIEatBsp 5uRTGdC36/XLYtH3AW2h7LWj4ItppftXlzMzMNoiFDQ7QJwqmTn1VR1Kj/KrrjD/Jj ho/4D6azXpg0Q== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rdXOJ-000000005Fn-2a69; Fri, 23 Feb 2024 16:23:11 +0100 From: Johan Hovold To: Bjorn Helgaas , Bjorn Andersson Cc: Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH v2 10/12] arm64: dts: qcom: sc8280xp-x13s: disable ASPM L0s for Wi-Fi Date: Fri, 23 Feb 2024 16:21:22 +0100 Message-ID: <20240223152124.20042-11-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240223152124.20042-1-johan+linaro@kernel.org> References: <20240223152124.20042-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791703936592236799 X-GMAIL-MSGID: 1791703936592236799 Enabling ASPM L0s on the Lenovo Thinkpad X13s results in Correctable Errors (BadTLP, Timeout) when accessing the Wi-Fi controller so disable it for now. Fixes: 9f4f3dfad8cf ("PCI: qcom: Enable ASPM for platforms supporting 1.9.0 ops") Cc: stable@vger.kernel.org # 6.7 Signed-off-by: Johan Hovold --- arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts index a67756ada990..70824294108e 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts @@ -769,6 +769,7 @@ &pcie3a_phy { &pcie4 { max-link-speed = <2>; + aspm-no-l0s; perst-gpios = <&tlmm 141 GPIO_ACTIVE_LOW>; wake-gpios = <&tlmm 139 GPIO_ACTIVE_LOW>; From patchwork Fri Feb 23 15:21:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 205459 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp654949dyb; Fri, 23 Feb 2024 07:25:14 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW35lb9fduw0l0M50zFborVUMhOW8RziNyiyisxB55xMTcEeGFB3LXrYM6FBTaHZ77Wr2LX5ynsrAqx9UL4c+4MSU6kvQ== X-Google-Smtp-Source: AGHT+IE09/1mgOZW2oruoS504eol40ajm1/gt5qZ25WDskKMFRKJ+b/oD+852rr7/24etuuGD+dm X-Received: by 2002:a17:906:68d4:b0:a3f:1afa:115f with SMTP id y20-20020a17090668d400b00a3f1afa115fmr70512ejr.31.1708701913927; Fri, 23 Feb 2024 07:25:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708701913; cv=pass; d=google.com; s=arc-20160816; b=mjnexw6T9hhsyppMhDQjj8/VB4GNIKptJkZE9qjxlKi6R62ICxyt75aFvATjqNddRO IHEZZSrrlDSlDd45QuKZyF2XPhAeo0gO6dbcA9mD+xEQj4UA9/Iz0O0Puy4xIMJRIoZi UeWqIx+Pjqv+GHgKpO3Y8pisSuicHuJyGnXzgWl8ykpGDCygcKhIJ1CvYsdUAkm3sILY ZNRl1yuq8tdtKkFRa0heQbji8euamlEaZN/iNvf31tHU5D1Zv9yKK1PBFvKhJRqQ9Ugn fCIo45PM+R0lnY7QQtP+pZO5Pc1FYTyfu/i/y2qmBJIgTJ0PsQblK4q2Dxzi7xINMUFd 9Rhw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=VTODv96DGxLCBTci5NXD7VvTm4hxUJQndl80az0ab74=; fh=ZRW1OjL+vw4nR3zHw03SqmaugmDx4dJgwazkhUMUovE=; b=M4dO5cChpFnnpkRqo1AEe/4MUQ6/4J533hZVmEQohf0+5s1JCwoh2FXKRjU4ndddRA 2Pmq0STlmOv6xsb5HBRXQBwfPBixqPWa3sfzjGA7U05oBUHxjIEIEMl6Jtzus4zu2Np2 r6rTk16kx83j8+A+g9dwcOsGwk2pUINl+BPRluuQuKzhz+UFMGrzCXFhhBQkUFPcTLJC Tc9+NzI4sD6mQzAVWuYPyDmPhwAP/pk0BYCwRDtPU+69XpG8MVyvQGadb3Nny0hdaRgx Yz3zWdK6oQMxsyKUE8BZ0PWdo3vvphOm1rtdhayRqXVCvx71bgejRJlJoO9pEeYUbYME gH+Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Pq1iHvpQ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78593-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78593-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id i23-20020a170906091700b00a3ed86dc13bsi3710058ejd.265.2024.02.23.07.25.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 07:25:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78593-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Pq1iHvpQ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78593-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78593-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 887561F258B5 for ; Fri, 23 Feb 2024 15:25:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 71DF384A3F; Fri, 23 Feb 2024 15:23:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Pq1iHvpQ" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C74B839E9; Fri, 23 Feb 2024 15:23:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701787; cv=none; b=YdGkCuFaZra5ZMJzCCTvbQuWkfuvs18TZzYdaqUkuDpUs0ADA7N4fNuK3EDGyRnfJiWGCy1WPKOz4Gg1Uv+lBMeNRR8DQPZWn/bRbe1m+olsLEV1ob0R6LpB7tAldbMnuRnsc64UxP+QCesVx6EX0sNdbjNGCbpFbpG5z73KwaI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701787; c=relaxed/simple; bh=z+xNJkOnkPu4NA9y+sepSglA9ZK8sFGfzstRMLlnHqg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VTwki4s50OhCAup6esaRyE15X/5fVKUsji5Q5eivZDhJcTKLtUnG2GaPUtXMrEPV9vU+7djJl7GhOO28FbNGv3Qo7wKr0qBX0/P07p1Az9tb+H7muDFj8agrocakebzmVhwIOR1VLb+YO5DVnna3xpb1hetQRWjam3OChW2f15E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Pq1iHvpQ; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 817F6C433F1; Fri, 23 Feb 2024 15:23:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708701786; bh=z+xNJkOnkPu4NA9y+sepSglA9ZK8sFGfzstRMLlnHqg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Pq1iHvpQPJc25pdkX9izR9+w19YL7duFOwQjdtKPK6T/7leudryEtHQTE18kUOt2u YgVZ0BLfP0vp5uYqyf/4j7iQ5ojoXzfBJF+W5v+hTZ5GoLJG1m1GIkpbVFVzdadG7f MtJEgh/MU+HhMudb9puj6DK6tpx2KlLYVvEZdpa1KM3WqshTckQs/SCePQtPIxc1v9 Q3UrDhyPz7F78EseRUNulsY2artyR9UdCedcqrKS19eyGWBsDN1J56YVLCRaYcdRas cMHRX3TlYssE4a9jsovqSrHGVzNIQZ6rS5R65dh30LDWhnCpHmGUY9OnHhZ7h8akKm KVbL4NqELE2RQ== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rdXOJ-000000005Ft-2wsE; Fri, 23 Feb 2024 16:23:11 +0100 From: Johan Hovold To: Bjorn Helgaas , Bjorn Andersson Cc: Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH v2 11/12] arm64: dts: qcom: sc8280xp-x13s: disable ASPM L0s for NVMe and modem Date: Fri, 23 Feb 2024 16:21:23 +0100 Message-ID: <20240223152124.20042-12-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240223152124.20042-1-johan+linaro@kernel.org> References: <20240223152124.20042-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791703817940934463 X-GMAIL-MSGID: 1791703817940934463 There are indications that ASPM L0s is not working very well on this machine so disable it also for the NVMe and modem controllers for now. Note that this is done as a precaution based on problems with the Wi-Fi on the X13s as well as the NVMe, modem and Wi-Fi on the sc8280xp-crd reference design (the NVMe controller on my X13s does not support L0 and the machine lacks a modem). Fixes: 9f4f3dfad8cf ("PCI: qcom: Enable ASPM for platforms supporting 1.9.0 ops") Cc: stable@vger.kernel.org # 6.7 Signed-off-by: Johan Hovold --- arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts index 70824294108e..06fc88d5d025 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts @@ -730,6 +730,8 @@ keyboard@68 { }; &pcie2a { + aspm-no-l0s; + perst-gpios = <&tlmm 143 GPIO_ACTIVE_LOW>; wake-gpios = <&tlmm 145 GPIO_ACTIVE_LOW>; @@ -749,6 +751,8 @@ &pcie2a_phy { }; &pcie3a { + aspm-no-l0s; + perst-gpios = <&tlmm 151 GPIO_ACTIVE_LOW>; wake-gpios = <&tlmm 148 GPIO_ACTIVE_LOW>; From patchwork Fri Feb 23 15:21:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 205466 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp656169dyb; Fri, 23 Feb 2024 07:27:18 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV0ON0HmcUKJfu7tRP7IbuehMHNUVWXo7lXMqhvmiRp8aUmHR+01JaoVi++arQyhSpLQBS0ztk24GC4NX6N9/6r7pUU8A== X-Google-Smtp-Source: AGHT+IGxSTMIqV7rXXkrUCMdFX1K4Wr9RpeuMofBgGm8C0rKCtJC/lwQ5ZGKvAWTsK0LEGa6ISGy X-Received: by 2002:a17:903:1250:b0:1da:eed:f25b with SMTP id u16-20020a170903125000b001da0eedf25bmr147253plh.46.1708702038172; Fri, 23 Feb 2024 07:27:18 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708702038; cv=pass; d=google.com; s=arc-20160816; b=MZnXSTwUvJX/X8dWYEma2trh/yd1RXwf23f+1nnpBvZg6ZBqqYNR+cg/sbJEzKnsrw R2yeSRtps1IGpDWv+N0SEjEa+9MgWmJU49RT7IUwaw+3mWQlRDVNwUEnNMPBx45Pf2vz irw3aIMWdvB9gRje1QU5CxgCS7G0ylLOINGWMRWkqO+JywJC7Jjz5FDiZX29I2VAxkTq FJ4CU8To0Co8AbLQerJ1lstZPbYQQVA+vaHwCHkA7lspsk+/6sU9HpN9XJ/ssYCt4PKy Sb/QcUKJ1/lyz2UMKYw1qs0SDh76uwz9/bo6bEdiukhJug0cTsDXwDDhXI+8ZxnTLh0p ZIgQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=U3GMmNd65smKPRltGy/lOI2BSpZtK0q7Cx6QiwfBLy4=; fh=ksFR342kkulMuv+0q94BrHeEzFBbdZfbM5STU9uX3MA=; b=nkKoJ14xjVpCJVOwhC/E6MpDhhtLo3r9TgUmCmQy8+VYIj5ZMocAs+XJ2+bOjtIDZu P6+wjfysAGgbqUlWSeiopZ2cXusuHld4qz7FtHeyuHbhcAyKzB+HyzO/n9MzN4F5yy7u P43kf4uWHI9xPb+S1PVHBnErzmt30/XmxvyAgU7xQHV4m8/WgT/gaf44IdQRX5Ad4T79 QsRDID5Rx9ixrl1o4PIRB0XfB/PEvlyyDUReNtpPz/+npShC8mSEixMH7fesyrhEvsQ9 EKuR3I4NwcQM9KNEpmliOzopdJQDBunk99SHMQUKTNmhkPOAJFAxmSYg1658gHC92aXS DUfQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Hg+OdIcd; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78601-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78601-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id u7-20020a170902e80700b001dbde62e1c6si11295721plg.30.2024.02.23.07.27.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 07:27:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78601-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Hg+OdIcd; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78601-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78601-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id AF8A2286A9C for ; Fri, 23 Feb 2024 15:26:56 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0308E127B4F; Fri, 23 Feb 2024 15:23:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Hg+OdIcd" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6876783CBD; Fri, 23 Feb 2024 15:23:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701789; cv=none; b=oRYmBLctHLhXSU1501YhtkBfyIBBrNgcd4uQDH/JQmHno5hS8JHzJj1xXwt2QG3qDIU1B+Y9Z1VbOkmtEoqshA7GjGIxWytgeoQUBZcwWfgZ+GJcFu4LTaBVSamoAvLPq/RmxexprMTpKVzm9jY9ZQ+5Q9JmQGWacLXwiDW9vQ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708701789; c=relaxed/simple; bh=m8pSgG+tILjksUnIEn47rNQsq3jlzF02sVC9//IqHf8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=foS2W48zS8LHp8GoGiLrI0vWq8oTKYTXAEYPC/6Uovxh+V4DpIT45NQ8ZCIfMMWG4+WvS1Qca65AVzHtspSk+sD4wYSBGjkSxLQz3iIzfWb4FJ2KX1Wt0KkjkUzPfpOccCYYx4Si3HZnBkZ8vw+7DFLWg56PlgoFtJkt7NS+epo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Hg+OdIcd; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA93EC43142; Fri, 23 Feb 2024 15:23:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708701786; bh=m8pSgG+tILjksUnIEn47rNQsq3jlzF02sVC9//IqHf8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Hg+OdIcd6RZ2ZAkx29PIE2bh37UR/Tzmf8W53YxXYFJJixQYlOJTc4rHr6N8mVi/6 x93Mk6D1NPk92Lyy1e2zZe4c+c9Nvp2rmykNVJ2GP0vszUrvQwjiRPDoQhEBynY7Zw zjHnOkkuKoNeNJdyfkcJ/nTGwbYOubN21KrU2Sf98WHjDkAzjixiLph/+6J7ketfGE WwArB7M9YIVGSRuQg4d06tCzohE+Sh/H8N6bcXQd+GFOopFA8XzbRIMO2Ov+y6tcgk WJe7oMh2Wg7sGiEg2ziCRehwPcwTQZc69Yw/K5EXxRQlHfev8NmJ6MnERgjK9/thm5 SmBGXbEh8RHtQ== Received: from johan by xi.lan with local (Exim 4.97.1) (envelope-from ) id 1rdXOJ-000000005Fy-3KpN; Fri, 23 Feb 2024 16:23:11 +0100 From: Johan Hovold To: Bjorn Helgaas , Bjorn Andersson Cc: Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 12/12] arm64: dts: qcom: sc8280xp: enable GICv3 ITS for PCIe Date: Fri, 23 Feb 2024 16:21:24 +0100 Message-ID: <20240223152124.20042-13-johan+linaro@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240223152124.20042-1-johan+linaro@kernel.org> References: <20240223152124.20042-1-johan+linaro@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791703948458444511 X-GMAIL-MSGID: 1791703948458444511 The DWC PCIe controller can be used with its internal MSI controller or with an external one such as the GICv3 Interrupt Translation Service (ITS). Add the msi-map properties needed to use the GIC ITS. This will also make Linux switch to the ITS implementation, which allows for assigning affinity to individual MSIs. Note that using the GIC ITS on SC8280XP will cause Advanced Error Reporting (AER) interrupts to be received on errors unlike when using the internal MSI controller. This will specifically lead to notifications about Correctable Errors being logged for the Wi-Fi controller on the Lenovo ThinkPad X13s when ASPM L0s is enabled. Suggested-by: Manivannan Sadhasivam Reviewed-by: Konrad Dybcio Signed-off-by: Johan Hovold --- arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi index 95c7b746407f..3e5063f67fc6 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi @@ -1737,6 +1737,8 @@ pcie4: pcie@1c00000 { linux,pci-domain = <6>; num-lanes = <1>; + msi-map = <0x0 &its 0xe0000 0x10000>; + interrupts = , , , @@ -1838,6 +1840,8 @@ pcie3b: pcie@1c08000 { linux,pci-domain = <5>; num-lanes = <2>; + msi-map = <0x0 &its 0xd0000 0x10000>; + interrupts = , , , @@ -1937,6 +1941,8 @@ pcie3a: pcie@1c10000 { linux,pci-domain = <4>; num-lanes = <4>; + msi-map = <0x0 &its 0xc0000 0x10000>; + interrupts = , , , @@ -2039,6 +2045,8 @@ pcie2b: pcie@1c18000 { linux,pci-domain = <3>; num-lanes = <2>; + msi-map = <0x0 &its 0xb0000 0x10000>; + interrupts = , , , @@ -2138,6 +2146,8 @@ pcie2a: pcie@1c20000 { linux,pci-domain = <2>; num-lanes = <4>; + msi-map = <0x0 &its 0xa0000 0x10000>; + interrupts = , , , @@ -4426,7 +4436,7 @@ intc: interrupt-controller@17a00000 { #size-cells = <2>; ranges; - msi-controller@17a40000 { + its: msi-controller@17a40000 { compatible = "arm,gic-v3-its"; reg = <0 0x17a40000 0 0x20000>; msi-controller;