From patchwork Wed Nov 16 17:17:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: August Wikerfors X-Patchwork-Id: 21207 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp271368wru; Wed, 16 Nov 2022 09:45:58 -0800 (PST) X-Google-Smtp-Source: AA0mqf4Ng3WMSXoGwIFWBcmoiUpplcry3mby43ef+sG8OCKXesctec55vweHBw+DFUdkJmZ9Ox/a X-Received: by 2002:a17:906:cb85:b0:7ad:beb3:91b6 with SMTP id mf5-20020a170906cb8500b007adbeb391b6mr18377910ejb.159.1668620758006; Wed, 16 Nov 2022 09:45:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668620757; cv=none; d=google.com; s=arc-20160816; b=cB8SsQ9RW2mFjZBYx/1DTR35wsQ6QPiuP2hhFAb/xN858XFlrCu4QQMWIMYaZVhC80 h5e9mhLfn4+FJgmgggrriSjn22E4aFRmkZGeBmKtCVV0M876AtFqedNDowkScP7JNAMI Micf4jJYnRbV0PrHXc28v4/+5amLsLpZMwu34AhdsLWboG1It4oJR7mSkkHFm8j8gtK4 XPGPZ9L4hGAv+GQIEQSwVMFciRKxD2s5bfDjyd3hWBmwHxyVBR8Ga0+psH0xeISW7Tx7 dwaMH5kKmJKYgANB3nIzNjti9vaar6C80xJMS+W4v7QYv9IAo0EMiKV9GAH99wRRoSlG nwSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:reporting-meta:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature :dkim-signature; bh=LpcpAH4zxrcMxDLOPMA5F656Hw2TrxzTLadot3yE8cA=; b=ch3mHO/6/iaMHCAbQ14GCqawxYLIaL0Q3I6Otf5HXXPieGfgqa13yY6OdjTysFsS46 y1GEqaZbXq/1eonRBDTC9Kbjd5W2eQ9QHdW+V0XE9R0/2XAX/vdMfyJSjGPjjY9u5I4c oaQwJLcpI7lfeaWzvWQh/IHm0xmOQOnFZeXRQE8DKBFQeODNVVzFVjdwn5vqIrTpwuk6 ps1mpWxUhw8lcsmmY2DvY6e4REFIY1KzsDxQHRK2Dzdq3UF2ue0IE8D/4ueGVuwf1n0z QyFMeCYf6M6OP1FXQkpN1+ZAsPCl5PJX6uCq/IzTcrGVUnmzc9y6OjDf31AISYcRcr+i QHBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@augustwikerfors.se header.s=oci-arn1-20220924 header.b=vbCP7qhK; dkim=pass header.i=@arn1.rp.oracleemaildelivery.com header.s=prod-arn-20211201 header.b="QDdPe5/a"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=augustwikerfors.se Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f8-20020a056402354800b004612220a97fsi15119606edd.100.2022.11.16.09.45.35; Wed, 16 Nov 2022 09:45:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@augustwikerfors.se header.s=oci-arn1-20220924 header.b=vbCP7qhK; dkim=pass header.i=@arn1.rp.oracleemaildelivery.com header.s=prod-arn-20211201 header.b="QDdPe5/a"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=augustwikerfors.se Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237845AbiKPRXQ (ORCPT + 99 others); Wed, 16 Nov 2022 12:23:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233262AbiKPRXC (ORCPT ); Wed, 16 Nov 2022 12:23:02 -0500 X-Greylist: delayed 301 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 16 Nov 2022 09:22:56 PST Received: from abi149hd127.arn1.oracleemaildelivery.com (abi149hd127.arn1.oracleemaildelivery.com [129.149.84.127]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7575559871 for ; Wed, 16 Nov 2022 09:22:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=oci-arn1-20220924; d=augustwikerfors.se; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender; bh=LpcpAH4zxrcMxDLOPMA5F656Hw2TrxzTLadot3yE8cA=; b=vbCP7qhK75aPjwVaVVnjK9avPEKVW8DQTky20IKg23NM1BRDoEtaSMbscBQj/zKwoOPm3WbDLt1A LE1tT4s4sbnbe49Ak5JhgjfZ84JLs19DdSmL5CpyzoglRYPvbQjOqNIPZZ9ZTBb/yyEZsEsxZIZq kqNGxth1PEL9V1wde1yYZOccazC550JgZ9s9xvC4z8y6qVdJR7XV2VtEWuRNCxs1u29MbpjAOR3t LwVzwuzWU9dQFyZzhZ2xwmyJpPqt7Yj8LuCBh04pclR77SSq3umYvF6qWAfwD6lujF2QLtfAGPlC RSeLNIQw6xxA/6E9xt3I5MZTMZDxfsiTKYyh+A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=prod-arn-20211201; d=arn1.rp.oracleemaildelivery.com; h=Date:To:From:Subject:Message-Id:MIME-Version:Sender; bh=LpcpAH4zxrcMxDLOPMA5F656Hw2TrxzTLadot3yE8cA=; b=QDdPe5/aq6cOV5ywHAns7uvVq8CuwohXDRB5cyV3d1jP5FDz4/n9sqU9Vqh57CtCNNzmnzflOJIt Y9DDByKpiot8WfJzBW4Rf2EotLCdkcnYfgog2DlPoRZ1tlO6cGdqMDrXW26lP/kDvom3Gqm02ntr /kFQcBAsRP4eq6sJXykQ2tOivncCLeTpxouAc0wPFjvuIKQF9VH9EpIagcNoul+ZLeON5D+cUJwL si3ZGrB9rbnbeQ+Dl1btQ7VttXN4XF5p+K/vOMAAGK4BzpLJedV40hGiXrQlezK5HPEnU6W43XCp AlJiFLjou5ORUtoP0Iat8JHcgWY2Y3ozlr4m1Q== Received: by omta-ad1-fd2-101-eu-stockholm-1.omtaad1.vcndparn.oraclevcn.com (Oracle Communications Messaging Server 8.1.0.1.20221104 64bit (built Nov 4 2022)) with ESMTPS id <0RLG0063MAPTE900@omta-ad1-fd2-101-eu-stockholm-1.omtaad1.vcndparn.oraclevcn.com> for linux-kernel@vger.kernel.org; Wed, 16 Nov 2022 17:17:53 +0000 (GMT) From: August Wikerfors To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, August Wikerfors Subject: [PATCH] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM9B1 256G and 512G Date: Wed, 16 Nov 2022 18:17:27 +0100 Message-id: <20221116171727.4083-1-git@augustwikerfors.se> MIME-version: 1.0 Content-transfer-encoding: 8bit Reporting-Meta: AAEu+0BrTkHBsWLOK63HjpEKIIURzBrIK56dK+jBm3s0DHlxjT4P2/MBeqUBNrmp VCVIkws4O2zsNXnjRWGkS5823k/tfg+rw6l4Necjg9kJztS2KXqUh3Xg4rRuERuF y59v90MLW5ID7raGwICLysCyEOWQFMjDZS+hM9eFde+qXMfhxSbKKfe8wIYyRSR3 rou9S/44Ely2QnM4WpJzVcsC5zLhHEXBOWIjc8cJ8O5OOoeiHXB18/OjMw6c3JMb j9M1ky8eXkYB7Bl4XksHK/T/GaJCCwYpjnVY3REKJc2mqcoJ0FAU22aJbAZ8hlxG BVYpiSO02rAebKgxWgoAVYXOHg22qaejwn6h+htz/Jkbn/DJSNCQMOkNj8q3PBtI y8n2CqiJnEzOSq+2GCP7fqYcZhBPFMfqS2DKAWvqRlFpU3IslFJw3VPLL8Zw4P/a aBEiRg== X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749674774866741243?= X-GMAIL-MSGID: =?utf-8?q?1749675679934386220?= The Samsung PM9B1 512G SSD found in some Lenovo Yoga 7 14ARB7 laptop units reports eui as 0001000200030004 when resuming from s2idle, causing the device to be removed with this error in dmesg: nvme nvme0: identifiers changed for nsid 1 To fix this, add a quirk to ignore namespace identifiers for this device. Signed-off-by: August Wikerfors Acked-by: Kanchan Joshi --- drivers/nvme/host/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index f4335519399d..0af51b85c323 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -3500,7 +3500,8 @@ static const struct pci_device_id nvme_id_table[] = { { PCI_DEVICE(0x1d97, 0x2263), /* SPCC */ .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, }, { PCI_DEVICE(0x144d, 0xa80b), /* Samsung PM9B1 256G and 512G */ - .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, }, + .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES | + NVME_QUIRK_BOGUS_NID, }, { PCI_DEVICE(0x144d, 0xa809), /* Samsung MZALQ256HBJD 256G */ .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, }, { PCI_DEVICE(0x1cc4, 0x6303), /* UMIS RPJTJ512MGE1QDY 512G */