From patchwork Wed Feb 21 21:41:33 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 204459 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp1313042dyc; Wed, 21 Feb 2024 13:41:51 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXbeu2pOtzA53ItTthdCLaTIcyxmcPoxo1UjosDUG85vWP+c9HZifLm7SMOaCMsyOap2YmGpki2Nlng4eqi1y9DfRpzNg== X-Google-Smtp-Source: AGHT+IHxxOgRUK0Pz1adbtG8jtRJRam0UZbnohCCiCA7WcC21N1wJU0EobTNozCCIjYdLIJS71Jb X-Received: by 2002:a25:b009:0:b0:dc7:4725:56df with SMTP id q9-20020a25b009000000b00dc7472556dfmr618939ybf.23.1708551710593; Wed, 21 Feb 2024 13:41:50 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708551710; cv=pass; d=google.com; s=arc-20160816; b=t/nmqnrXIUVG8zNBmeHGZSfHbkSGOcUJycUL2re8Z9Ir7CRH0ciTV67m7vXVYXYndr rtwyRUvVKFewA4q0Te4GZ/FeTu5EhPRTGKFL1SgPRlrMQgkIMTS5SV55d8XHRq6t7Y7E LoHqvDkiuGBGgmZhxmGwFBx2ZNJnH5UrcDELIsnV3Iwu1za868FdPkJuifsN6D1rUiR9 w+jJRAOBI4k2inPIzKT8vm2ZeDKdvxZn9+zgNvkq3/EiROfdPd3JkhHsFKlUkFORlDlF 9cmYNdrYp9k1RfvAQbD7okV8V+NHHW5HovZfpV8qEPoymqsNEI3QwMcXkj7tzFneXokB aNug== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-disposition :mime-version:message-id:subject:to:from:date:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=wfL3Pi7+xhkK6bq8nle7HWWPZsxOKcQfZKbo1QFW+dk=; fh=NLxAvL/bDfPg4AGOtxqvQlND8vazkZrNzKLY8+LAbBY=; b=LQmPDZFq+1nNhyqqkQAnKYWS5rTXSUs/s2dyb4+4K5hr+nbgyv+RY6jLHSjDGYwAzp dZqQ0RrcbppCtXG0TA6nlnsRqNYlCKObdtzpuYpSHNjm+DmwiJrcM0kKYTGPJBqd2X4P E+wO8YETix3Q6J7b/yM01ac4lhcD3EPi+G8gam4r9Ih3q/BaTjHupuH1QTfMab1V46kB dNCJNd6xa3t8XW2ItUR3E1wbfvQ96BYM3OW0nbkJK9F9T7L5Pi1bjPv1c9QFNuR5h6hI QKidg9hF//fStdApnqk1q3mJwIvQYKjeeQ7MyjypbOUNpDuIuXK6j+GWxka5u045TA5l zplw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="ZvZfcE/A"; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id p14-20020a05620a22ae00b00785d7f24cb9si11432505qkh.640.2024.02.21.13.41.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 13:41:50 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="ZvZfcE/A"; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4A3E03858C52 for ; Wed, 21 Feb 2024 21:41:50 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id EB2B13858D1E for ; Wed, 21 Feb 2024 21:41:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EB2B13858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EB2B13858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::436 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708551700; cv=none; b=qSm/Cb+bGZM0QrO83D+n2bR/sriWh1KU+PzR7nc7oZJWS5X+PQrH0e3EKZIXo5TGcaXNPTxx1LkogUAraSL+acULoEdMsBRIDSoiQuWMdEDEi3XAvPW3oK9ohwnr9Y7JBHTLlIazu1vm1AdQ5M9A9tdkwlcLWkstGm7gYS00VF0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708551700; c=relaxed/simple; bh=KYPjzVfaqZRSU3jkfyQwHxbJUViJql+nVb7oc8udNjA=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=ohjZM5n9nRMm9ktANNQxKpoUqd3hI/KbXS2Va+QZ32m7t/jZWQ2Zk8ptoG1iPiHI41vH2BGSjOar/1naK9nb6bAbs8oXIaDkMR+Zzv4WmSNd3qXailcGvFr0l3kwOy2iBw4g8jCSafh8kUix/LXPCyjvZJESMlRxmytPOOy7v4Q= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-6e43ee3f6fbso4196646b3a.3 for ; Wed, 21 Feb 2024 13:41:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708551697; x=1709156497; darn=sourceware.org; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=wfL3Pi7+xhkK6bq8nle7HWWPZsxOKcQfZKbo1QFW+dk=; b=ZvZfcE/A5YpL8m/9DC3ob4M3h0phHx8rA9eX+hGI6JHSDuWW/M9TLKfKhwMHl0f7gh cvIox8M2/ekJofR9DQY6y8tgMNJja6LzwgAzJAnGysB6RLkOV4DR2p70tb8GazIVFb03 j80hjzMfFbcZdRsRyF6SGNOnvNbK27n/9GPLihnuoRDCQAcjZTvFShn/PtGVAF76PKKr zjlmrPDvJspqaw0/OyeB5qcBN6iQErYWgC3jUODNCXZwLpxVuwUhCl5hESbJGw/z+xMg K9Bq92Ec4X27JJsd54fjOmJ9bv/N9sLIPFHPUvyZkoYzVE2eWLh0eLeAknxXgKb6WYy7 5ZLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708551697; x=1709156497; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wfL3Pi7+xhkK6bq8nle7HWWPZsxOKcQfZKbo1QFW+dk=; b=usXU7N3YxPryoJhFAz4aIqBtXKXH5tsqO2MPM06HT0nrpBOGd+2BXO8/nwnMOw2p57 qBOHNrf3B2smudYvQoQH05U6XWcLl0Z0NguQoFTI6qFEt4J4i/D2U7e0+cpdxGBYiF/1 oxyuXgjtGSZeN3dUuj8kOfQS8YjxQ7owVidBll6VXYX3LnZ8IaneUmJVmOXrq+uBDuph 2hcudbiVOTLyrHSw9s2u6FTGbyiW1CVYSfZUAGPnGkBrCNjsad30v5znqrT7w9fzk0RQ dUwW4FERaM/85vtN4IkeUvZDke6BP7OK2zXxtA6rgZQZiZ+Pp5xdcltYd1cb2IYGt1rm YWdA== X-Gm-Message-State: AOJu0Yxx847UHkgbl/ztaDHdrMOVVOwnH1/LIHZ3sqrQ/sxZsFft/Go+ Ngv3vH+8VJJWi0Dw5if73kMlEHAkf14gPTo+Zei4pSAb+otvApg5lrsBzM2S X-Received: by 2002:a05:6a21:1014:b0:1a0:c46f:62be with SMTP id nk20-20020a056a21101400b001a0c46f62bemr3022532pzb.38.1708551696896; Wed, 21 Feb 2024 13:41:36 -0800 (PST) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id k9-20020aa79d09000000b006e45c5d7720sm7393256pfp.93.2024.02.21.13.41.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 13:41:36 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 906E21140496; Thu, 22 Feb 2024 08:11:33 +1030 (ACDT) Date: Thu, 22 Feb 2024 08:11:33 +1030 From: Alan Modra To: binutils@sourceware.org Subject: Leak in i386_elf_section_change_hook Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3033.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791546318368431270 X-GMAIL-MSGID: 1791546318368431270 notes_alloc is perfect for assorted memory you can't free easily and/or would rather leave freeing until just before exit. * config/tc-i386.c (i386_elf_section_change_hook): Use notes_alloc. diff --git a/gas/config/tc-i386.c b/gas/config/tc-i386.c index ed7c4a5ea03..c56ca4a2b4b 100644 --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -17627,7 +17627,7 @@ i386_elf_section_change_hook (void) break; if (!curr) { - curr = XNEW (struct i386_segment_info); + curr = notes_alloc (sizeof (*curr)); curr->subseg = info->subseg; curr->next = NULL; prev->next = curr;