From patchwork Wed Nov 16 13:01:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lin Ma X-Patchwork-Id: 21049 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp126112wru; Wed, 16 Nov 2022 05:02:53 -0800 (PST) X-Google-Smtp-Source: AA0mqf4Gd8Z101Pc77G7EZNBY7U/B8MgcKmKu+1eKoMrRUVZaoqzkVFftTf3pqwAsi7rCV6PXpB2 X-Received: by 2002:a50:d657:0:b0:461:17e9:4ea3 with SMTP id c23-20020a50d657000000b0046117e94ea3mr19002179edj.49.1668603772851; Wed, 16 Nov 2022 05:02:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668603772; cv=none; d=google.com; s=arc-20160816; b=tKD8Xi1kuOd65ttinYf4wtgoDhw31w7aAe+NFkjlmjxmPhaUdN5kUg8t7ROjGqCRyQ ALHCsBxuyaWHlK/vb4nhfva+9lnB6lknv8iTrRafKE2FOsMFU+FVb74hKJElp3sbC3K1 bs/ZmVRXFKZT3qiJnSPvig3I1EvFEQdEH+41tAPSnKrQApA3O6B49l8Wx/kBaHBskDxp N//PsmJu5U5iWjvCN74x+BSS1J2u1w6pTEXQaWV/ciZPXY2bQTSHXO1CVz4gu+n99dSg 2D+dB0KCBaTeT7kpx09ui1j3slGMIp7RdHesJ4/Gde/5XV3HJScX8SOp/MI48j9ShFxw ITrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=RFQS+Op/bnbNmVz9FtQTaSz9bc6usXFK4p2zBFpMPFE=; b=gsjIHH2ZBadNQFmZ2jEefRlEe4cJ33apZOsBIUkJHdj8JU3HGV4fEnEI/PwvWSJLlU RpDEre7b5XsRIfUh+EMI3plnPjDUcpweUMOKenUI1z4Mbjc/MhQz/ixEOcHaXXkFW+pC Ktdmzj0/47xb5c/P+yrMOWwAka2Ma9IO9RkR0sn5Hn0M/9gQ0il58CepCPr6vwFm39K6 FrcOQaZDoiJadJK6NFZpMQdI4an9YV/9jYcwGA4IxNHebUZK36pJ0vb+9GVVeRPjnvgA 0S8dJte4G7nivf5bUi8oPhx8jPamVpfPhDGoN3UArW91zCg4Z7uNRRvU4LGTBIAQtAAe 7UoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dz10-20020a0564021d4a00b00458b71488bdsi16287219edb.388.2022.11.16.05.01.45; Wed, 16 Nov 2022 05:02:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231437AbiKPNBa (ORCPT + 99 others); Wed, 16 Nov 2022 08:01:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49644 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229907AbiKPNB3 (ORCPT ); Wed, 16 Nov 2022 08:01:29 -0500 Received: from zju.edu.cn (spam.zju.edu.cn [61.164.42.155]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7EA7995A6; Wed, 16 Nov 2022 05:01:25 -0800 (PST) Received: from zju.edu.cn (unknown [10.12.77.33]) by mail-app2 (Coremail) with SMTP id by_KCgC3v_cW33RjmJ22Bw--.48243S4; Wed, 16 Nov 2022 21:01:10 +0800 (CST) From: Lin Ma To: krzk@kernel.org, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mudongliangabcd@gmail.com Cc: Lin Ma , syzbot+43475bf3cfbd6e41f5b7@syzkaller.appspotmail.com Subject: [PATCH v1] nfc/nci: fix race with opening and closing Date: Wed, 16 Nov 2022 21:01:06 +0800 Message-Id: <20221116130106.10202-1-linma@zju.edu.cn> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-CM-TRANSID: by_KCgC3v_cW33RjmJ22Bw--.48243S4 X-Coremail-Antispam: 1UD129KBjvdXoWrKF4DZw45XrWDCFykGF4fGrg_yoWDWFcE93 97AF4DXws3Aw1xGwsxJF4qyryayayIgayIvryrWF4qv345Zr15JFZ7WrnxJr43ua43uFyD XFn2qF48C345GjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb2xFc2x0x2IEx4CE42xK8VAvwI8IcIk0rVWrJVCq3wAFIxvE14AK wVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20x vE14v26w1j6s0DM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E 87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c 8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_ Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwI xGrwACjI8F5VA0II8E6IAqYI8I648v4I1l42xK82IYc2Ij64vIr41l42xK82IY6x8ErcxF aVAv8VW8uw4UJr1UMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr 4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxG rwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8Jw CI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2 z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjfUoOJ5UUUUU X-CM-SenderInfo: qtrwiiyqvtljo62m3hxhgxhubq/ X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749657869767320716?= X-GMAIL-MSGID: =?utf-8?q?1749657869767320716?= Previously we leverage NCI_UNREG and the lock inside nci_close_device to prevent the race condition between opening a device and closing a device. However, it still has problem because a failed opening command will erase the NCI_UNREG flag and allow another opening command to bypass the status checking. This fix corrects that by making sure the NCI_UNREG is held. Reported-by: syzbot+43475bf3cfbd6e41f5b7@syzkaller.appspotmail.com Fixes: 48b71a9e66c2 ("NFC: add NCI_UNREG flag to eliminate the race") Signed-off-by: Lin Ma --- net/nfc/nci/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/nfc/nci/core.c b/net/nfc/nci/core.c index 6a193cce2a75..76ade5d4f55a 100644 --- a/net/nfc/nci/core.c +++ b/net/nfc/nci/core.c @@ -542,7 +542,7 @@ static int nci_open_device(struct nci_dev *ndev) skb_queue_purge(&ndev->tx_q); ndev->ops->close(ndev); - ndev->flags = 0; + ndev->flags = BIT(NCI_UNREG); } done: