From patchwork Tue Feb 20 11:50:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 203575 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp344090dyc; Tue, 20 Feb 2024 03:57:05 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXs4VkjhRLkvKNkNnvzLtR5D4CIPRE/Jv1kBblUDZufz/o3mgmiGcGMDXsmmu/RL4P3HzhXfogo8gF/LFGP3j60DDCLeQ== X-Google-Smtp-Source: AGHT+IFHrejRYzcjoM7U8Mr/ZwubunuIzgR0Q6W+XwTo8qRluxggBAN+mtYoclmqs3FQZ/MizD0s X-Received: by 2002:aa7:c309:0:b0:564:4029:33dc with SMTP id l9-20020aa7c309000000b00564402933dcmr4361650edq.33.1708430225186; Tue, 20 Feb 2024 03:57:05 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708430225; cv=pass; d=google.com; s=arc-20160816; b=dXbYJzXelwIv8n1PGVBrtPSpxFHg5i7AGg/RlEGhZEhtOp9I5fOvrzpQvbys7JHLKY TVP0eZblRh1w7LZEL7X55OrlKSjsNmR9kvUxn504R/HBI+VjPHV2LZyWtXMllyDgSYvq r4XsjWcIZZXrLSDQnifPf7/HMDOjcEHri96N35o6VVwqoR6iqQu98eOTFr/EDTv+NbWc SrdLaQjk+Coy03eEEHHLR1y8Ef0fWD6tElLfRhJ1UGQUuQTM7T+Gpony3rPGVT5cQmqk 9tk8/nHU5TpmWmdO0/ZSg43E+dBib50dP/V6SWMk+AYGbGQ9x4u4JM3a523k6cY8F6vv zGZw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=NC5xe2uxCxCjh2/t9Ad3AWpCcmsygcw6ycwZ3qcHHbA=; fh=oM9VGGCV6Vfk9qdAAGxloqx5c49e7XKZHeB0EBHVoYo=; b=KG+CZu4LIODAfPgUrOvhYosxi9nBnq08os185U671SKQQqxBjigKHLoZ3b31aJI7Ot RM2lbmjkpiCKZFFEXIgFoDhCjJlkWnHrU+KvHy6UuJV0DAa7PxlsIoXG1c+IRlU7Oygg i9gj4fzuzYSUmeWA6GSCfLOryy0s2ltZtwif7DLSjh2XBksBvGZpNqgmZbiL5dAfr72i oqt9HTOVoz/09irpLxj2s3hup76i2r0qllsLZkzOBU6LuN3s2yBgEVtebVy3LVnKCOY2 fC8aSDVYefUONGdYejjGaqiq7feL1x7Kx1m2K1dj7kim/15iVhfkMGRzg4/fx9U0p25o dwjQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ulcMRjcU; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-72941-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72941-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id u23-20020a50c057000000b005647becf0basi1662305edd.27.2024.02.20.03.57.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 03:57:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-72941-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ulcMRjcU; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-72941-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72941-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 4BB581F26900 for ; Tue, 20 Feb 2024 11:50:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 59CB967E61; Tue, 20 Feb 2024 11:50:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ulcMRjcU" Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A3636773B for ; Tue, 20 Feb 2024 11:50:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708429820; cv=none; b=bmeRG6Gffdegf4bVrcAzbdnR5mXIXTxdrNnPoNgikw94sGQdTIPszRnuS5p48jDWXa+RpgeGKxFSS3Rybupi+twQB9kmZiI0/Ug9j6ClFpRYX7/76lj3KbYHN329+8RkRqGWrO9Ek2GwMDzkaksvIPhDrMAfeiqiBqE5IvbC1qM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708429820; c=relaxed/simple; bh=cYDoCiKTRi+gPhjiLH2ZPtZdUHcsgOWojEx7bGvUiok=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BYarOOU778uH9rkqqw9lS9SscdWT92AV/iSx8b3AV5Dzh46DHtqxzfjVFNO08+x4bOKAN76RDtmFjOZunWv05VvyWgJ8anDGU77XyxNchZWtvpjo5/b75lBthz5w2RbsZ+3Igb98b+8qO5ym+3mBB6q8knICcRm32xwMWEIJX+8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ulcMRjcU; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-564d332bd73so535209a12.3 for ; Tue, 20 Feb 2024 03:50:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708429817; x=1709034617; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NC5xe2uxCxCjh2/t9Ad3AWpCcmsygcw6ycwZ3qcHHbA=; b=ulcMRjcU61jrEuhPPhEdH5Y0kmkSXroKFHsYxtK4GgDJoEpgogWcItl7YpUPUYsfdf 9nIaMzubXM3NQUXHtZ0q5X/RFbskJt/tBZEPhUpUFL8MxOS+1p4OWs8dVc1o3oDlpyRC IpoJalaQtFJVzr82MFKqnDL+JIlEKiECPn+RyFPKm816zQM/OpQbgKmlRDS/5hSViytN 71ZztEqcYzE9ZQ4MTSQN/zMXu+3717qBigiFfn8nEzhr6lrptxbBZxaIqfoBQe/CT1c4 IMWBZqHjoHL4e3v8bZxBRPCN1ELFKF6oR3r6Okp1BHnD7jNT7bxXaIo5tAH1ZBYC4jGb gF2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708429817; x=1709034617; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NC5xe2uxCxCjh2/t9Ad3AWpCcmsygcw6ycwZ3qcHHbA=; b=JmNiTTfOqYfDUIDWQN9pgoNE5o827tY+3l7zG6325XDTeX+QwprrQNsVm+dfTen/Zr 5jmB2p9r7+Fn8BZxU/qdPDxFnbYCEGVUKT5P0BpVTErGKXToyZc2z6GJDtAsAh2Dl+AS wlG6ndGZOgkaqUzhGpj1Pq6f7jz2SMSQOHl34umVLOqE07JcIEzW/L5qsPpU2ou2j0On nH8n2kDUMygEO6F5hMqZ6NExm1s/hKUOPJFq4FbuyCCE45E6lAGxJ9Ocd787G4Y+ck9Y 6KjJt1e9NDetL2PMTNDSbUzCDGVmck6aTXeNgHJwMBY8wMTx00JEtpYSW473KMyul6O8 GDaA== X-Forwarded-Encrypted: i=1; AJvYcCXg62TBBNi7zlfremoY+75YLHf1gOff8fbWuu7HrbgVDSRHHvyecprJXaktYsrpjyz+r2bvsmnYgyz8fgM3MoGm9R32/Ivy40JMzLET X-Gm-Message-State: AOJu0YyD8gx/yxU9IcFEQlASPyOTKC1H1/cOZAh1PO9tgUC4LQt7NikQ d5xCrN4T1j8BxLxTneuP35G7nLvBCuaaHZkOwsJzqUDHxLHY4fxCSGZMCmD7sTw= X-Received: by 2002:a05:6402:693:b0:564:56e0:5643 with SMTP id f19-20020a056402069300b0056456e05643mr3817369edy.27.1708429817344; Tue, 20 Feb 2024 03:50:17 -0800 (PST) Received: from gpeter-l.lan (host-92-18-74-232.as13285.net. [92.18.74.232]) by smtp.gmail.com with ESMTPSA id u16-20020aa7db90000000b005645c4af6c7sm2317832edt.13.2024.02.20.03.50.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 03:50:16 -0800 (PST) From: Peter Griffin To: arnd@arndb.de, lee@kernel.org, thor.thayer@linux.intel.com Cc: kernel-team@android.com, krzysztof.kozlowski@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, pankaj.dubey@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com, Peter Griffin Subject: [PATCH 1/3] mfd: syscon: call of_node_put() only when of_parse_phandle() takes a ref Date: Tue, 20 Feb 2024 11:50:10 +0000 Message-ID: <20240220115012.471689-2-peter.griffin@linaro.org> X-Mailer: git-send-email 2.44.0.rc0.258.g7320e95886-goog In-Reply-To: <20240220115012.471689-1-peter.griffin@linaro.org> References: <20240220115012.471689-1-peter.griffin@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791418931618633900 X-GMAIL-MSGID: 1791418931618633900 of_parse_phandle() returns a device_node with refcount incremented, which the callee needs to call of_node_put() on when done. We should only call of_node_put() when the property argument is provided though as otherwise nothing has taken a reference on the node. Fixes: 45330bb43421 ("mfd: syscon: Allow property as NULL in syscon_regmap_lookup_by_phandle") Signed-off-by: Peter Griffin --- drivers/mfd/syscon.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c index c9550368d9ea..7d0e91164cba 100644 --- a/drivers/mfd/syscon.c +++ b/drivers/mfd/syscon.c @@ -238,7 +238,9 @@ struct regmap *syscon_regmap_lookup_by_phandle(struct device_node *np, return ERR_PTR(-ENODEV); regmap = syscon_node_to_regmap(syscon_np); - of_node_put(syscon_np); + + if (property) + of_node_put(syscon_np); return regmap; } From patchwork Tue Feb 20 11:50:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 203571 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp341841dyc; Tue, 20 Feb 2024 03:51:30 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVR++XUYayexRYo2v5ZD0lAhNpUqoDfo3fk6wPdhLiK1nKp6JLNISpYg26TNi/8b7EPcY0nFsAxV3z7zzm0vF7Sjrsa9g== X-Google-Smtp-Source: AGHT+IFSFCb6QcZqslp2M+6UTUnNywCusyF+GEMcXbwzeuW9hPnxcihpzdyr/hhqnjlGyBnTPOY+ X-Received: by 2002:a05:6358:b082:b0:178:c302:b799 with SMTP id b2-20020a056358b08200b00178c302b799mr12616126rwo.12.1708429890404; Tue, 20 Feb 2024 03:51:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708429890; cv=pass; d=google.com; s=arc-20160816; b=S/xirK3beUMgD2tL7haM/3nGz4biduu+562v5YLs/b2e/nchIvCRkLqHYMwUGpUiKb BaSJv3fmrpKL9PBIzjxUT6pU15s9uqXnOZTyGPQVPGDpvMRrCoK+0wcY3tNhYpcTMppW l177Vkvs52B9dRYrRSazpztouTK1afhEcf1wESxywIEI0zGC8bJE/Qowy3wqPUOATmwu Hg3Lh0bK0Oayf2w++Ie3hyvSlrI88tyriAj+SJ+nkbfpSF7oh43YCCk6RBywCk6gGP6J QfQjLi8oW9z8u000CbEEve+QuOZNF0JHse1k7R7zzcVNiKf6zyGcfoumgEdfhEOT8Wrv gqxA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=jIz2a8ZPV5qqMCqIcgKN9srCLfbQdXRH6UOg+1LhDuc=; fh=zr07RbvEWNaOfJepprhsLusq8B/tYMegb6DhXxmtzXg=; b=rg6Iln4NRRMEZFRYD0/bSslR1yUuPe6UjVHGLKd7uYa8ae7PKDg3IQJ/WS5KZuQCEq xvFHxoielbfCiWN+9lCedEkzZwK6XkybzsXLkpXbS5bpyacIZ02rDYU3ccw/uyO0QSt+ riSpn03+8k6OKEyBNhf38/PdXoVqHCS+jE4v2/Xut9t+4R2DwYKyYEO/UVikDo+qmnKE zUc2keEqf5Y0qFGqk4/kOHQg38/dwnYZx4qeB/xU4D5HlAV9CSqZ0Fy3peZB8ZVnKKxE FhCiW0zHaDyPqRQGey0AzfX0wcW19xuraXO/l343YCa9535W1D6lObmmv5tjbnn7SUly 6fCg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Y51Zl8h2; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-72942-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72942-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id h16-20020a633850000000b005dc4b387909si6007651pgn.714.2024.02.20.03.51.30 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 03:51:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-72942-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Y51Zl8h2; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-72942-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72942-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E5CC62880DD for ; Tue, 20 Feb 2024 11:51:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E557C67E86; Tue, 20 Feb 2024 11:50:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Y51Zl8h2" Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BF9367A1B for ; Tue, 20 Feb 2024 11:50:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708429822; cv=none; b=ia44C+zrx1eQNNMriuiv25LSwcIM79+rPDoPxFzMp4NVhXPpqXcLzV96sRzb1A2fhlCR1FEZtctRS3tOvZR96zOVtPFuR0fNPbPBjhdiB0uffH7bLuhg3eno7+GMHHb/iRJSqGQ7gANUmVPhqzPjST9c9H8+aaAv/Gh/se1EVmE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708429822; c=relaxed/simple; bh=0IfLHgBVTD7LiVd984EuRr7LjiiQeTvGFFpyHCXVJ0I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=meZakw8J9Go5nBc4v18uBeb8C8LPBeQQezhwK8iOxM5Lxm5JJBZI/YRHpThizlhPSp/y0JvmTrZTMFNn/HWR2B/HJJ80Bd0LGXbtsQD+OyeF7zWSHI9zw9ZHnC2MQKDf+7RHK6+legV1bIpMQjOz5poUKt2fVX7kPdSEKAzglWw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Y51Zl8h2; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-564a05ab3efso2262001a12.0 for ; Tue, 20 Feb 2024 03:50:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708429819; x=1709034619; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jIz2a8ZPV5qqMCqIcgKN9srCLfbQdXRH6UOg+1LhDuc=; b=Y51Zl8h290zAoc+AJKCum6zgmMT46ecvYz27Xo2O8wFkPZiKsdGIe9ZPxtCqpxgZc1 tep0JRoQm2xPzymcEQrKGR+fJAjrAj/g+5ketj1deNRa01XbA1GDM1aQZLwTtjKke6kM ldXl2Dl8wYtq8VdmmmCpnl9csHBPS7INc5BrxvXWCt1aQP/20uWZqz3Lcx9B/gffPe0b BgIlDYBM6sRvhS1RamaerLyFlSsJvI39IsRiIpv6qe5iyt6hz933HfRce0kHO/7UOquI NX9vGX6Dxv77scJw3JHvIj97f0hv5epqxK8if8JtO2TZC4UZRKphLEVJPoXm5PPQ71pT UNDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708429819; x=1709034619; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jIz2a8ZPV5qqMCqIcgKN9srCLfbQdXRH6UOg+1LhDuc=; b=ohma4jmFFCwPbGpNZ1Pq/cbO8qdTRhVU4y6r/XMlR07x3LD9v9qMnIi4XjN7ywHyLj N7Zsa5+QD8PY57V2lnqOGVh3Wp2TjuAwN7lhJeJAeyFaado51/P4fKhGKAHQl+CRx+og 3ayr7cbxt+HNVAlZYm3RBwL+11CYQlSmNWi31GVAPbNI1nRQA6oxh6QCryNgJHhZ4tdP ZOGQUjyftgRscW5+s5jlErF/a1EK89sWOAmAZRWCVsK1Yj0VXxauuNA0XOzP9FgPinDz KjQFWIHv3Rhl1+c8VeGtuzzlsZT0J04wuAwcSSsiwIBUveFekVKunAuiiErOtSuGB5ap 0K5Q== X-Forwarded-Encrypted: i=1; AJvYcCVVuwREri1k0LeDMdOJ8m8Ga0yEfaIqntiPpMqSsFpWLYI7ttD8gOAx7IUelrJgs7nU7IiocsMFHPPFDsamfh93DrhWydMx0aST5wby X-Gm-Message-State: AOJu0YwlD/jCxMB1ne5Xfv5iWdYItgaTW+OAeH+/+x24V+NlV3B6YHr3 eYL0S9j/JDirkcBXgmEsuyx/uscHHlc43cTcXEbSo3zZaT6aa8s7iMD6cTwN6PQ= X-Received: by 2002:aa7:d4d9:0:b0:564:4f6f:a7ff with SMTP id t25-20020aa7d4d9000000b005644f6fa7ffmr4449767edr.20.1708429818757; Tue, 20 Feb 2024 03:50:18 -0800 (PST) Received: from gpeter-l.lan (host-92-18-74-232.as13285.net. [92.18.74.232]) by smtp.gmail.com with ESMTPSA id u16-20020aa7db90000000b005645c4af6c7sm2317832edt.13.2024.02.20.03.50.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 03:50:17 -0800 (PST) From: Peter Griffin To: arnd@arndb.de, lee@kernel.org, thor.thayer@linux.intel.com Cc: kernel-team@android.com, krzysztof.kozlowski@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, pankaj.dubey@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com, Peter Griffin Subject: [PATCH 2/3] mfd: syscon: remove extern from function prototypes Date: Tue, 20 Feb 2024 11:50:11 +0000 Message-ID: <20240220115012.471689-3-peter.griffin@linaro.org> X-Mailer: git-send-email 2.44.0.rc0.258.g7320e95886-goog In-Reply-To: <20240220115012.471689-1-peter.griffin@linaro.org> References: <20240220115012.471689-1-peter.griffin@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791418580697847588 X-GMAIL-MSGID: 1791418580697847588 The kernel coding style does not require 'extern' in function prototypes in .h files, so remove them as they are not needed. To avoid checkpatch warnings such as CHECK: Lines should not end with a '(' +struct regmap *syscon_regmap_lookup_by_phandle( The indentation is also updated. No functional changes in this patch. Signed-off-by: Peter Griffin --- include/linux/mfd/syscon.h | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/include/linux/mfd/syscon.h b/include/linux/mfd/syscon.h index fecc2fa2a364..c315903f6dab 100644 --- a/include/linux/mfd/syscon.h +++ b/include/linux/mfd/syscon.h @@ -17,20 +17,17 @@ struct device_node; #ifdef CONFIG_MFD_SYSCON -extern struct regmap *device_node_to_regmap(struct device_node *np); -extern struct regmap *syscon_node_to_regmap(struct device_node *np); -extern struct regmap *syscon_regmap_lookup_by_compatible(const char *s); -extern struct regmap *syscon_regmap_lookup_by_phandle( - struct device_node *np, - const char *property); -extern struct regmap *syscon_regmap_lookup_by_phandle_args( - struct device_node *np, - const char *property, - int arg_count, - unsigned int *out_args); -extern struct regmap *syscon_regmap_lookup_by_phandle_optional( - struct device_node *np, - const char *property); +struct regmap *device_node_to_regmap(struct device_node *np); +struct regmap *syscon_node_to_regmap(struct device_node *np); +struct regmap *syscon_regmap_lookup_by_compatible(const char *s); +struct regmap *syscon_regmap_lookup_by_phandle(struct device_node *np, + const char *property); +struct regmap *syscon_regmap_lookup_by_phandle_args(struct device_node *np, + const char *property, + int arg_count, + unsigned int *out_args); +struct regmap *syscon_regmap_lookup_by_phandle_optional(struct device_node *np, + const char *property); #else static inline struct regmap *device_node_to_regmap(struct device_node *np) { From patchwork Tue Feb 20 11:50:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 203570 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp341699dyc; Tue, 20 Feb 2024 03:51:10 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUFa+nEKQoKLuPo3QiZGEC0A4hE01wlFTz9gx2+8zkfd1eKlXMtIU12UKo/u96b69aI+4vur7maD5rwtLF2zLP0PlsmLw== X-Google-Smtp-Source: AGHT+IEgcWS51VcQcKR4fcrqrdloYahM+RJmaCy//si5QDgQwv42KwUTmlfME1QoJK3NLGip+cec X-Received: by 2002:a05:620a:12c8:b0:787:25c7:1be6 with SMTP id e8-20020a05620a12c800b0078725c71be6mr17033992qkl.30.1708429870239; Tue, 20 Feb 2024 03:51:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708429870; cv=pass; d=google.com; s=arc-20160816; b=xaEyjSsUoAuC7oEtAkSVam10j3OW+gmIWrAAab+ZLsVFkoYH2yjA94Ud7U2gX4ilKw RV0xpr15PMlcc3uQtqwGzV7IPkmgFGARenm5KUtTgeJWaXoC9V14tyqRh2H24PxTnE+k E36FCsKC+PejAqQaNyESAWFpgUsOQpj1OV2RkhD/Y6zZFrba1Rh7Lp/CwdbeLSJ6i+Hd JworepqWYXftBsyXYqwuG+tZx4EOFJlWWrY6tAlvJoUzZLiVQWByC6tt5NcKT/hEekhy xIeLUtLgKkYXUlXgVXeIQutTwAfJ8GGsiMethcDQy0duOrNyiEE6YAR6SPV/46AGRctP frMA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=NLPhn5F1IILXAvLH2tiC+iCBpGghWpYxEC9f2Dxu3S0=; fh=dobH+JFADl2ZoikJl17XG8zPQJztKAUVZZCKjpoFX60=; b=f1Ox+VxNvblo6juxMFhDsvKqcBBCVZra8WRCa5v+FzAMCaZBiUrOadHkJ33j8ZAcut 4cwbrsi83nDs9i3rBUIYJaqFHLlz49v4nYhInikKS+H6wO1BVZ4hLhyxK5Dxq+CoTKVp OoPwGXoQF3TSLNIzCtbfVmmW3NtwGpkKEfp+Ix8PNkZYX9ADvO+i+3acbo959TXsGQ7w P1ihQHjdHVIegaNZ8mdLVPBpLxthT2jrlFYOPWfGcSSJCLSfBiRoPdMK+SFSKiMhhd1Z ryNPKuKBEqzfS6bx0Wi0dPQdsFvTHsFrbv0mSjcZ63YH8zb6d6CdRlyR9JQWhn6gzWVb 21FA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vVuSZKCs; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-72943-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72943-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id a13-20020a05620a438d00b007877bc92296si689388qkp.768.2024.02.20.03.51.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 03:51:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-72943-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=vVuSZKCs; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-72943-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-72943-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E3BDC1C248C1 for ; Tue, 20 Feb 2024 11:51:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 11FEB67E97; Tue, 20 Feb 2024 11:50:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vVuSZKCs" Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C98A167C5B for ; Tue, 20 Feb 2024 11:50:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708429823; cv=none; b=FpdmymEOVyGHSZCTdqICQ+kWLFOtRDP5ACOrN33KTxeoXNlYTbhxh5Jz1UruGMj9+DbCEsOgbsGWZqs5B6p4qnpBEK6rfXGM6GbRnR6nT0X3jQEZRShLxRz5oRfbBn3PlKBXdgVgaUMx2NojpsYU816Z+cHbL6+4BOqTQM29YsQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708429823; c=relaxed/simple; bh=CxiR74akScPcxbYf23Me48D1EuqZdg7o+HrvY4MWK4w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ra3wYUCdM0U3HI9zkQZpmn3CF0tCzzOqCYNOv9tx5s0EWuy/WVzCHX4KFHLth/icSZhVsE0KfDmwML+YZOp9yHvbwdgovLJzHl2KckDZVXjhOzuU3Qd3cuGdvixmsX4/+qAmiV1dLsz/wMi1VnBX1ICwyN9rb5RCvkAlD0hIf9Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vVuSZKCs; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-55a179f5fa1so7200152a12.0 for ; Tue, 20 Feb 2024 03:50:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708429820; x=1709034620; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NLPhn5F1IILXAvLH2tiC+iCBpGghWpYxEC9f2Dxu3S0=; b=vVuSZKCsFFD3H17QgEjCqnLEu2PsLLvL3BDelHaGaTFozw45nxVf05ON/ZtVXG/ilE gtCrL+3aun/NlSdFPZrlYPnFBa1Zuo427Jmo7nG8PWsotDWJJAKQA22pLtVXRyf5G2Ac cTZwNF9X5mD+9ZNezjrJK8Jy2FeijIPn3kovulhvQvLdiXTiIpr00bUT9xB/4iegTOch iPlOBnzsdot1b8AdPDHZGuujj0pcz5fha2GwenhBR0gCBBltwvh9xcW4G3fwPNcLfMQW oG3rhlBdjQW2l3B8SUQmISpcL6PbONCYpibSR7q7fn5jSuYTs9n091GsUGdrn5vbhZS+ qbBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708429820; x=1709034620; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NLPhn5F1IILXAvLH2tiC+iCBpGghWpYxEC9f2Dxu3S0=; b=SbTPQL7tjgC7QyrKC44mFw3lmTF2slrRA/O0RCKmkKOtz9056LQOwlf0dcixukRnZD BcBCsJrby5Kes3t3yiULicc+rOH9bRTR6VE6vI3i+DhFur+o6tU+UKWUEFgyb+NbYjdB W65L5OuOmHYYTH2XHz9iqSaOmzC3UDpLNTJXqCmhGsOEQycDUcrnEBjD8CSXqn0y3AeU ClHiZQj0KFUwBRG/9wpMKJNF8ZtNTloXZv3CA4v+B2tVwgc4NyBnQuC3YmbZhkTY5YxB yssD63+zKKYoGzbIp8Klzpavju6XZDBiQf/L90XYBXcK7dBr0pZpPbGA+e08eGTu9ihf sVuQ== X-Forwarded-Encrypted: i=1; AJvYcCWmkoCvOAmTgmIbuMAoGBbUkbxcSiTDmBdZRlXKUPjxJspXNY46CSdi7KFSXKwiE2Z+kjdOEG740aixH8H46+WNazeB1RKG6i+J3gQJ X-Gm-Message-State: AOJu0Yw9PRhchJ5FnutvJAe2ZfsfArOdItDwXsMDMjFXdwkPodF89g8O f8k5YZtPv1QWSmCk9Qyq+0BkZ53gWYHD8KKlQrgjGhe4dNCkrf8PdxP5Myg9Bqg= X-Received: by 2002:a05:6402:1b1a:b0:55f:6a87:8033 with SMTP id by26-20020a0564021b1a00b0055f6a878033mr12182959edb.31.1708429820121; Tue, 20 Feb 2024 03:50:20 -0800 (PST) Received: from gpeter-l.lan (host-92-18-74-232.as13285.net. [92.18.74.232]) by smtp.gmail.com with ESMTPSA id u16-20020aa7db90000000b005645c4af6c7sm2317832edt.13.2024.02.20.03.50.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 03:50:19 -0800 (PST) From: Peter Griffin To: arnd@arndb.de, lee@kernel.org, thor.thayer@linux.intel.com Cc: kernel-team@android.com, krzysztof.kozlowski@linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, pankaj.dubey@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com, Peter Griffin Subject: [PATCH 3/3] mfd: altera-sysmgr: call of_node_put() only when of_parse_phandle() takes a ref Date: Tue, 20 Feb 2024 11:50:12 +0000 Message-ID: <20240220115012.471689-4-peter.griffin@linaro.org> X-Mailer: git-send-email 2.44.0.rc0.258.g7320e95886-goog In-Reply-To: <20240220115012.471689-1-peter.griffin@linaro.org> References: <20240220115012.471689-1-peter.griffin@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791418559551006466 X-GMAIL-MSGID: 1791418559551006466 of_parse_phandle() returns a device_node with refcount incremented, which the callee needs to call of_node_put() on when done. We should only call of_node_put() when the property argument is provided though as otherwise nothing has taken a reference on the node. Fixes: f36e789a1f8d ("mfd: altera-sysmgr: Add SOCFPGA System Manager") Signed-off-by: Peter Griffin --- drivers/mfd/altera-sysmgr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/altera-sysmgr.c b/drivers/mfd/altera-sysmgr.c index 0e52bd2ebd74..fb5f988e61f3 100644 --- a/drivers/mfd/altera-sysmgr.c +++ b/drivers/mfd/altera-sysmgr.c @@ -109,7 +109,9 @@ struct regmap *altr_sysmgr_regmap_lookup_by_phandle(struct device_node *np, dev = driver_find_device_by_of_node(&altr_sysmgr_driver.driver, (void *)sysmgr_np); - of_node_put(sysmgr_np); + if (property) + of_node_put(sysmgr_np); + if (!dev) return ERR_PTR(-EPROBE_DEFER);