From patchwork Mon Feb 19 15:04:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 203186 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp1432331dyc; Mon, 19 Feb 2024 09:35:15 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXmKox0hV56Nmd517dbr7WKJ9KIoJjD5r0fjqb900IHYoopFG0r+JNauzyoGXm+sErO6IEFsDQkP6ooFE+8mzj0EJPiaw== X-Google-Smtp-Source: AGHT+IEk/GCMXcyh8pa4+nUbNVfZbMiNOkw4iU0825aYbrUGs/2A9ZqN2obNL8y/JQKYVb8zjtWi X-Received: by 2002:ac8:7ec8:0:b0:42d:d3d1:6524 with SMTP id x8-20020ac87ec8000000b0042dd3d16524mr11633908qtj.8.1708364115167; Mon, 19 Feb 2024 09:35:15 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708364115; cv=pass; d=google.com; s=arc-20160816; b=wjCWtgSMDRpew+xKUlYDuK8ml7T/dXp/6hmmDGdmtKAV/pirEvoMJs8gGmOD5uM5GX BJYKKelbz6aL0czRXBUEp3ZmmhrB+vbiGELTQTDEowFBPetUwtqCp+m6Bo624EkZJbKe R15sDW/Dj9P+57Se/eIjbZTwoP4PyWwUpHubm2Q0JjoGT71V30Ei2rkbTnCgiH43XX+8 Y7WIt5dpl84452pvhLkhLXP4i/w3k07itSHIqTnt5weHHIU+NmHZkEWbeZ51Xq7U3Ay3 9J0TZbnMQjlBeHibl5CpdL3BJM9s23hA1zjF4QXX/GMMtxvNZzvlHJGkvtyAj3FldUvr dVDQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=9NY0nZEyn6RPpWGNMt2FLg79vm9aHv6KmnwXUQb/Vi0=; fh=PNvaLswGJ26klsPfkGGhf9Ppr/vjNw8LDr3eh6+RQKA=; b=lz+v9kXDleMSMkX2o9UoWmvJLWqt9nAEa1LoC8lfuWa5sW2qIrO+cXEt75jxU+6HIP MCftDNlv18lt72bcyAdhbB5CajZL90Y7ID71UAY0BnluR4egh0iNFp6B3YM1r/cP1YI1 AvqB5nffxiFRpR9FhSpSLYLhgSU79w+3ImJIn9PZUMEZogVV/tbGv9tl/WCtLrw/9f2s frCTvN5TKorWCpwtFtTyPLyHNmM+C8IVrwiKEOz52nGUttNyO2QJYli4ri/MaVErR5Xy v2n7xshlr9hlARh+cSi5hAnTB04uGoP2gWqL48ZMO2t1uxNkHiqruhr59ZS19O6SnjLW ifWw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XrYqS8b+; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-71544-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71544-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id z11-20020ac8710b000000b0042c6cd08430si6381015qto.284.2024.02.19.09.35.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 09:35:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71544-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XrYqS8b+; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-71544-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71544-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 27F121C21FB9 for ; Mon, 19 Feb 2024 15:08:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E05AB3D98F; Mon, 19 Feb 2024 15:06:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="XrYqS8b+" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C94F38F80; Mon, 19 Feb 2024 15:06:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355198; cv=none; b=J5fzb3ToWcyQCgdhj9Ob24z1hqiuW19eDY7lLbKyAzqcuWTfnzgUsRLIsO4mCNw2F+DwPHAQNUTRDepwh7MifeniYWE73UlaO+zRi85n/LmLPUuPMi3fyUEfM7mVtded2yfP4YW9WqLtd+wI5yeCi5l2dRL6pfkFnf9qJW3iN/A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355198; c=relaxed/simple; bh=82ATjiA+fWRlO+HzDk15/yNSFBbE2hQxY9S14sFvXLs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jrb7oexmK5SNPmsxOzPctSyJvUml+OQionLuGNrtrlX9tpStD0WZEFrIRoAOlOirkYWyzURuuZzSONFtrpbS2+bFRpZxqY59JfJBGL8/CTfHgUXEE4Tj6DN3Ir8r0WLjR1tb4O5s/39r6hDwJ2Q4JhFEjOJn34s9dCHzvHhh5RY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=XrYqS8b+; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708355197; x=1739891197; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=82ATjiA+fWRlO+HzDk15/yNSFBbE2hQxY9S14sFvXLs=; b=XrYqS8b+fs09PdbIJVRt/UAeBsS+WTU9bcGeI3pO01nLcd5xOAtSM+DO 1lCUOtU5bxDAs94VQcrIAIGsQ+3aiuBJjvGGjxAhNhFY29JH/1z+aJZBB gnsIScVX7oeVVINbQCnUtHkSC74HuhnnuwnjwtEV1CT+Esg8JORkvmrbN fIVDKq1n/izAJZHkdIFY06kJa/S9yDYKYgltdZLMXt89zCWaw2EGMvFvd fMEyMBABCBLehuFD3lFhNbwveq2vAf1IWY2W+z1TY2pbwo/C70fnvPmxI gnWYYBQegS1Ix7SDlyl4STplvJty2LohK7CYzHCEBDnDhPFBLBRsoefEh Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="2543777" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="2543777" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 07:06:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="936302991" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="936302991" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 19 Feb 2024 07:06:30 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id DA9152BE; Mon, 19 Feb 2024 17:06:28 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Jiri Slaby Subject: [PATCH v2 1/7] serial: 8250_exar: Don't remove GPIO device on suspend Date: Mon, 19 Feb 2024 17:04:57 +0200 Message-ID: <20240219150627.2101198-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> References: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791349610665522800 X-GMAIL-MSGID: 1791349610665522800 It seems a copy&paste mistake that suspend callback removes the GPIO device. There is no counterpart of this action, means once suspended there is no more GPIO device available untile full unbind-bind cycle is performed. Remove suspicious GPIO device removal in suspend. Fixes: d0aeaa83f0b0 ("serial: exar: split out the exar code from 8250_pci") Signed-off-by: Andy Shevchenko --- drivers/tty/serial/8250/8250_exar.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c index 1be838122bca..6580265e1763 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -741,6 +741,7 @@ static void exar_pci_remove(struct pci_dev *pcidev) for (i = 0; i < priv->nr; i++) serial8250_unregister_port(priv->line[i]); + /* Ensure that every init quirk is properly torn down */ if (priv->board->exit) priv->board->exit(pcidev); } @@ -755,10 +756,6 @@ static int __maybe_unused exar_suspend(struct device *dev) if (priv->line[i] >= 0) serial8250_suspend_port(priv->line[i]); - /* Ensure that every init quirk is properly torn down */ - if (priv->board->exit) - priv->board->exit(pcidev); - return 0; } From patchwork Mon Feb 19 15:04:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 203282 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp47436dyc; Mon, 19 Feb 2024 13:25:16 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWVVbsldeLoI0KIoPV1XaPNmYqnNtOOwp28owjTcyarWGwO4shmSGc8R/VqkVASAZkNLoBiTt0H/wNFUv3kf3FjbdGQDg== X-Google-Smtp-Source: AGHT+IEWAv2E964DDx+xPL1KqTXDMYHCv0KyBfFmO35FpWtefUKQbWeT57O4dQmgaRmGguFe8MGw X-Received: by 2002:a17:902:b289:b0:1db:f1ff:2de8 with SMTP id u9-20020a170902b28900b001dbf1ff2de8mr3642635plr.16.1708377916637; Mon, 19 Feb 2024 13:25:16 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708377916; cv=pass; d=google.com; s=arc-20160816; b=bqmKN4tSHHWrcJ800cN3od/GsoJJxQGbQex1rMFf0FPNkR/aiqtHiYmLuX0QGPQVBa gCHt0IkM9C3qBc5iDLHxM89OUCW8uBflOw65wiYOsLxJKQt5SHSQsgz8f3AQUvq39/rZ CNUuHjUVHUsw1dS2Yv5tyXeQ3Jv1JtJiEcx/WF9gV3EJ59lQi8Ge55WIjhi7BcLbX64H l8Uox6W73ITU6VXdR87L4AInhvNjVmX4g9tdjGr0yeHq7QiPxhpxeZanyXBhQkpduuOK v+/87ZnjT++B235hqfRZLlZV4KTaN/1T1mFDKPFdulSRCndYDn6Y0YUbJ+VZMarwJTFo Hcfg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=lYhr+ATzC8mE/AoCaUBMIG6Hy7if/P8GbM1c0+pYTsM=; fh=PNvaLswGJ26klsPfkGGhf9Ppr/vjNw8LDr3eh6+RQKA=; b=eV1fH41cwpeKufSi99Jn1Dst1gM4b9axjXgpyjj6u4abjbkSwbIzmVCDlac8wBnYGX Xid2LfF5jFliqXmEz/3+DQ86gutZgpK+QKgpllgb0/OefCHs4jCjvcG1d9xBIkydqc/F rYJ1UAkwkZTj4tqbq1PihlQdz8h6mYA2YDDqZc2LBrSF0CnF5CviWFlFZYom24IiFEuG H6DoG5/Io0MRm2YeXU9ED9z6uZrJvlqX1BrnGoflt1CPLnFHoMB1I0gB+qc3rz+2wmct tc1+kLBuhEW/ZF2G6pXE1Jx0gm3gQ2VouifPT3lnE6d+qJJdYFvs57fVtT5P77eloTZa AIgg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=nvytw4WL; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-71543-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71543-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id t3-20020a17090340c300b001db5a8f9316si4910651pld.152.2024.02.19.13.25.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 13:25:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71543-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=nvytw4WL; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-71543-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71543-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1D776284BFE for ; Mon, 19 Feb 2024 15:07:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8EF9D381CB; Mon, 19 Feb 2024 15:06:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="nvytw4WL" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00A18383A6; Mon, 19 Feb 2024 15:06:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355196; cv=none; b=mjQltGgd77T0FIrsWqtrBThDTm3gVNmXvelju2bh5/NrWMwpKsTul5UvbDVNrun0MpoXrQumz5ZNgu+ud1R+h0Sf4UUEEdkHIPQ32bT+r/TusRzZdSudvACQILKeVv8twmcrX2lNHOBIdmQiuDMNuFTZJD0+l8Otj5xuPqS5Pfg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355196; c=relaxed/simple; bh=07e8tH5p33pOlIv3860uVekz8GN+sz+b+6ZdzYF0wWw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FOoJNTHPsGOA8slEidraBtOLMWK6ol/N/E8sFmBE4UCAZDyMsExsQAdr6bEK/e/nK3wBhsI19SxeiNGzzjzpDz8WQ06pAGYHUO1x2rYXPD7o91swZOdfU3dZhaLDdlXF5mc6LcpSSbfH2TesOeJt0Ljx75AKDAaWxlStaUFFUDU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=nvytw4WL; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708355195; x=1739891195; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=07e8tH5p33pOlIv3860uVekz8GN+sz+b+6ZdzYF0wWw=; b=nvytw4WL8gECXRr8O1YGPJrOu97xNLFHzPW7yxTQW5pObK8lgm1d7BXv /hWgyFmakgvrClNbVVUVrNJzcmDj9B0dXh2spCJIYvtdstgfVi4tGGjtm XXBSl8xzKphgA2er8+ltE8TG1ayopFYk0dLzAGFhS4gfgsKWgkC8Sg0x5 c4kPKWXuCfahNE1gg6BuZlsDhlOAiFc+B+p6WweyamRoHv52RMfq9H6bA QJqy/alrB9p/GFiPGnvwEGYpQOS3HVqtHptRmn9cffpj8PKdUe63/vSii b2RNkk3vVLYrxpqlt451sl7CaG8d8tf/2Ig2TJ0MTDBLeM3fIDb/YRPTI Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="2543775" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="2543775" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 07:06:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="936302990" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="936302990" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 19 Feb 2024 07:06:30 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id EA87A3E5; Mon, 19 Feb 2024 17:06:28 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Jiri Slaby Subject: [PATCH v2 2/7] serial: 8250_exar: Use dev_get_drvdata() directly in PM callbacks Date: Mon, 19 Feb 2024 17:04:58 +0200 Message-ID: <20240219150627.2101198-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> References: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791364082547629927 X-GMAIL-MSGID: 1791364082547629927 PM callbacks take struct device pointer as a parameter, use dev_get_drvdata() to retrieve it instead of unneeded double loop of referencing via pci_get_drvdata(to_pci_dev(dev)). Signed-off-by: Andy Shevchenko --- drivers/tty/serial/8250/8250_exar.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c index 6580265e1763..28478b9c537b 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -748,8 +748,7 @@ static void exar_pci_remove(struct pci_dev *pcidev) static int __maybe_unused exar_suspend(struct device *dev) { - struct pci_dev *pcidev = to_pci_dev(dev); - struct exar8250 *priv = pci_get_drvdata(pcidev); + struct exar8250 *priv = dev_get_drvdata(dev); unsigned int i; for (i = 0; i < priv->nr; i++) From patchwork Mon Feb 19 15:04:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 203187 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp1432577dyc; Mon, 19 Feb 2024 09:35:44 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWhwvqhmI0zQzPtUlbjVrZsUS+N+6T4P6apnF5ki5/0xkaa62DT/TksU6BKp8skcBEpq1il22CJrsEDHopHkzzpIBjJ0Q== X-Google-Smtp-Source: AGHT+IFjiF6M8i02EhLk/var8YnsNSI05JIVhZ6qTcNag0Cgciua/Pdi4t3MiHIzyaUzEvuaOJRT X-Received: by 2002:a05:6358:5719:b0:176:5c75:b348 with SMTP id a25-20020a056358571900b001765c75b348mr15717350rwf.4.1708364143826; Mon, 19 Feb 2024 09:35:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708364143; cv=pass; d=google.com; s=arc-20160816; b=Qjs9o2kAcaGKCIUL7f9ktARHpPqTp8c1CUjJtECPuwJVhcmxbEXoYTT4R8+NogIqwy 12ch1K+0t0+LE2/cFXJNrkBPu9cbb1fcL6dccYmtkNpUm84JUqU67Fehcde4EJlLfDTa k2nBE01xK5jQMwO4eKIMuQRyv1cefGSVoaxexq4BHntoxGDZ2LlzARsewAr7Qhmrn+QA xBxPf+L2DbelNFVFPralaqOkFhFII5Ghoa30pap+ahhPfv4vN67SuI0M7rmJRr/Ewljn UGy4buZQrzkY6Hfe1+Le8gzyqRdmHoO4KRX1RiVLchKeyzSY7ncjqNpqTrRzAZVgO0LH BBiA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=ddWw44au47gZXPahfOGvqUuVOx5I52pHLy73u15onQI=; fh=PNvaLswGJ26klsPfkGGhf9Ppr/vjNw8LDr3eh6+RQKA=; b=JAbfjWv1Lg5T3yf7G1VTzqY08ON89ZI7dVsVktEaMQbyjjg7L5kL/HYko4mHWj5n5Y kqLFBjrTAhyPxbinJz1oQusrCo/QzLQp8eoSKBtWTSGAUakCD1j9Px8MQ2RGT2fwSb+k oiHrlkdaJrO2y/aiLBNwSSZI082WVBqv8R2U6Mm4fj4VnSDSkYrr5AvsKK9LGEnGJMkX 2w0WapOm7hTFW5GMsxV8+eHgF5CF8bw62DC+rNxDpLQ/Via0pV43ctY1ng6WmM/6Dm8W e6PB4OcqtHk65AxTuhfKpBwLw4DM3FG4U96w1rtyhFNx92ZNWiH1oRyGzYJ/bdE9FMxa 8VYQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Jei8VxlL; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-71546-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71546-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id e26-20020a63745a000000b005d6787271aesi4725285pgn.237.2024.02.19.09.35.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 09:35:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71546-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Jei8VxlL; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-71546-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71546-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 2418F28597E for ; Mon, 19 Feb 2024 15:08:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D4F963F9FF; Mon, 19 Feb 2024 15:06:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Jei8VxlL" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 505FE381C8; Mon, 19 Feb 2024 15:06:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355199; cv=none; b=STGwZXrD//bBtknf+Ltba1WbbxXdffhbhidnm/ASmf/AZhS5OBoOm0Owrl6u3lma52PhU85QHYpG0KRY8AhYp5oCnHbEkJWjo/LzBeGM1lwHMvENsmZ+1UsMW7PiNvz2CCnhf4PVZtS1QRU/MVBID17iJktkpknujeWbq3iusPQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355199; c=relaxed/simple; bh=Oubb+Ppgmcr6fsN+mjfb+NkY8mywNOxbf3wmKOoo4jE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GYq+3YYpMiFJIxXYUx3OvCs9eAEoY6SVHlc3PxnoFo/kLNbF9wGtucLSEE27aA42l9GeoA44+3N6Wjzl7sn3D86AjDn5dzS2+fAbLIbpSMbwUzvhnINh7OqzID3zsE8TatXdrM+KOoSUs00CMmiSuxcAP5oLCBi8uno7rGn9KlM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Jei8VxlL; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708355197; x=1739891197; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Oubb+Ppgmcr6fsN+mjfb+NkY8mywNOxbf3wmKOoo4jE=; b=Jei8VxlLwYtgZ/aITZAG2uRUN4A3WPXlMdgKnSMN6iHAH17CkNuvil04 YiRHib6DtthcXrA8M4zP+a2j74gwZTsgrYZ37r0rshyU3y7L1UhFaIXBk QIBy9MZ20uoovh4CVe97TjU9kJsJjcbLBVpoD5rZAxrUJIhWmrXNxbAoh qUPBdcmojryhu29UzeOz6lVOianqoT7CciL2wfL2aOiaZ53EturQGGMHV 7mjEeC4Pfy3MS/T1xSA8dSMEa941JbFuHQE2N0GeomNVzP4Zw1FfidHvB yVC+4855ui6o/pcQmWtBBogOzOlFtmEy2ob6Zg9FbOqZprFJJ9rfA2+gA Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="2543779" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="2543779" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 07:06:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="936302992" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="936302992" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 19 Feb 2024 07:06:30 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 00BCA403; Mon, 19 Feb 2024 17:06:28 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Jiri Slaby Subject: [PATCH v2 3/7] serial: 8250_exar: Clear interrupts before registering handler Date: Mon, 19 Feb 2024 17:04:59 +0200 Message-ID: <20240219150627.2101198-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> References: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791349640700103864 X-GMAIL-MSGID: 1791349640700103864 While now there is no issue if IRQ is fired before we clearing the interrupts as the handler does the same, but strictly speaking it might be problematic if IRQ handler wants to do something more. Move clearing interrupt code to be called before registering the IRQ handler. Signed-off-by: Andy Shevchenko --- drivers/tty/serial/8250/8250_exar.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c index 28478b9c537b..c7afa06a420e 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -701,14 +701,14 @@ exar_pci_probe(struct pci_dev *pcidev, const struct pci_device_id *ent) uart.port.irq = pci_irq_vector(pcidev, 0); uart.port.dev = &pcidev->dev; + /* Clear interrupts */ + exar_misc_clear(priv); + rc = devm_request_irq(&pcidev->dev, uart.port.irq, exar_misc_handler, IRQF_SHARED, "exar_uart", priv); if (rc) return rc; - /* Clear interrupts */ - exar_misc_clear(priv); - for (i = 0; i < nr_ports && i < maxnr; i++) { rc = board->setup(priv, pcidev, &uart, i); if (rc) { From patchwork Mon Feb 19 15:05:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 203216 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp1470406dyc; Mon, 19 Feb 2024 10:46:33 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVEuSJM9ndehkrCXny4rAhWOt5O7Or2ibMIBPjod5kjZCONJ4S0DIqHbJiQczMGyrZLXpaFFLvuHKeFk/J1Z80Ldoo8/g== X-Google-Smtp-Source: AGHT+IFXoSPO8Bp7a7zEyd1BWK4dSrFfU0Mgh5X//IRPNj3MyTf8yG6AfXUAZSUS+K6kEwosE9Ru X-Received: by 2002:a05:6402:643:b0:564:65c5:f048 with SMTP id u3-20020a056402064300b0056465c5f048mr3025767edx.28.1708368393547; Mon, 19 Feb 2024 10:46:33 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708368393; cv=pass; d=google.com; s=arc-20160816; b=l+n6dObEN+i5ADLeUSDdWdOWQXS/lzUJe17H3rNm7A5itHI8FhrAqNlvTq7Nu3x53N fYqxHTQ7qkaucpXhn1r3ZqgGmLU3Y6CZyh9YEso9Q0d6I94P1u4dVz6mZmmofvzdGDCB Twgmuf2K1Tv89PlS2Xdm2NZOTvPjXBDpmHZaAm5ZtmTwa7bP3qi/NmOsJDZnJ1cMtOnv mR4xQ8PbfsHr1oXBZd+LgeA8vGauvCopR6mMxqRdNePpSCFv4uLJeXYexyITCMCAdva0 Dt1vheYJvEaSUrwHCGuOcEKyBH3khalMFUCl3t54xqqKO5uZ61sYJ7DYQukbMND4wmc0 SK0w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=+wFVo4RU9/o+B53ydFnmbc3vvI/fwxlOvgF/+M3emz8=; fh=PNvaLswGJ26klsPfkGGhf9Ppr/vjNw8LDr3eh6+RQKA=; b=V1jYYqotaPeYlfI9qaCUuPA/VwOXQkSdNRDfQHoNTnezmcsmjRltI+YiArErH9ofHx gC948MEU9A+o8Gfhkp2odEQOGzgUPUgnpaQ59hMH5CNgUCXO7rvir9V8NiArMi7RjI+K RRCj38Agr0mSoF8I9u+/ZiAzfdN4D92If5dbv86Ory3Gwawis77e+mzSmz74V7rRBszZ wMyMkubP7bLDBIqptP2ldxVqZOzWSWBC4ujwSY+dK5DE7XBUpYD6K9hFv3nbx4hyVFyd gvvMnRUE+xSm85390rBYALhiQqM3ixBEGf7N0P+c3ECJXtWZrf/xGYS6l1N/L0/vzhbL ccgA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=OckLUJsP; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-71542-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71542-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id y7-20020a056402358700b00563e74ef3edsi2621965edc.576.2024.02.19.10.46.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 10:46:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71542-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=OckLUJsP; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-71542-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71542-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 8E18A1F22FA6 for ; Mon, 19 Feb 2024 15:07:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E269B3BB48; Mon, 19 Feb 2024 15:06:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="OckLUJsP" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 541DB3770C; Mon, 19 Feb 2024 15:06:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355196; cv=none; b=u5BKMC2evDkBaH0AKfCFLPSL3CCVWl5XhZsLqJhiW1nxXdEs7kzGv1PxH9h36cFPYWig3VASPFxgyJw3/zG4oah4OntVkJC+29KJxj9E3fCuldWZawGj4pVQ0FIYHL3mNgVMLhTqqqphnruiJKziAGGyef5xs1B2NN85pln6AVo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355196; c=relaxed/simple; bh=1O2LCsHcutszivKQ7ugn2zdlp1ZqgFp0cxdBQ8mkIts=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sm5rOqyFly8fFFqkMEREVmpgyuDNwPX1QfZgL4jzZ1wbcq5YxtOVrwhqMnFQQDP3SduZe9V2ni3fMtKVsSdAQdFWkan8EXNlnPYoMKbZrmHi9O+om4Azo4FPYEe+DVkkhc4WmaVyw3CRDey2h3vfeladAaNQ1EnbMZ+CErzw/ts= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=OckLUJsP; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708355194; x=1739891194; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1O2LCsHcutszivKQ7ugn2zdlp1ZqgFp0cxdBQ8mkIts=; b=OckLUJsPov4WkVhIXveZTO9AzLvZ2gX7wYVwI3seJyEvJTcRtTAyHyEA DI0E5UnC4AYMhSximBisuKKf1bTy2UGROhcvf2N/LmFL/TDB3IcwfPn4+ G65pMuHY0dBWg0BICbfluO4Qw20y8mQBv0eKLPidC/zLa4s5E/Weu1gQc AqUxCtV1vlAH/pN5QCoBwGIhy5nA71GK5QEKBRssvseX8RQPVZdXMgwPX P+WCKTmHor++UC6DifXPg9vhWuijvEu8U6k6vTlMUWiK5sSrhHPkYk8mr amaGZu0b+mptl6byAmp1+9wCsRlZk9eroieQeuEpH73Yw0Pho7TO9+QZx w==; X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="2543773" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="2543773" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 07:06:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="936302989" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="936302989" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 19 Feb 2024 07:06:30 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 09D433C7; Mon, 19 Feb 2024 17:06:29 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Jiri Slaby Subject: [PATCH v2 4/7] serial: 8250_exar: Use generic function to set firmware node Date: Mon, 19 Feb 2024 17:05:00 +0200 Message-ID: <20240219150627.2101198-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> References: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791354096375607120 X-GMAIL-MSGID: 1791354096375607120 Use generic function to set firmware node instead of ACPI specific one. Signed-off-by: Andy Shevchenko --- drivers/tty/serial/8250/8250_exar.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c index c7afa06a420e..2a0c1f7e87f5 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -6,12 +6,12 @@ * * Copyright (C) 2017 Sudip Mukherjee, All Rights Reserved. */ -#include #include #include #include #include #include +#include #include #include #include @@ -363,7 +363,7 @@ static struct platform_device *__xr17v35x_register_gpio(struct pci_dev *pcidev, return NULL; pdev->dev.parent = &pcidev->dev; - ACPI_COMPANION_SET(&pdev->dev, ACPI_COMPANION(&pcidev->dev)); + device_set_node(&pdev->dev, dev_fwnode(&pcidev->dev)); if (device_add_software_node(&pdev->dev, node) < 0 || platform_device_add(pdev) < 0) { From patchwork Mon Feb 19 15:05:01 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 203271 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp24480dyc; Mon, 19 Feb 2024 12:29:45 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXXVVADFzeVKYA2u9rk/MIYera+iGQvLGJTX99Zi4MgD4rFTk8rfmoc0xtlmVmixc+nc+dE6CUJqNmt0/PdJi3fyvYSgQ== X-Google-Smtp-Source: AGHT+IHGDHRtTDLyK8OuD6xorfumMCzyuMsa36fqR3SUVbPtWf5be5cAPp8WdysUNSqQVs4llFyN X-Received: by 2002:a05:6a20:e605:b0:1a0:584e:fda9 with SMTP id my5-20020a056a20e60500b001a0584efda9mr13790173pzb.28.1708374585154; Mon, 19 Feb 2024 12:29:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708374585; cv=pass; d=google.com; s=arc-20160816; b=rEZr9N11aTqcTLAEDlUVAscQo+Yn9GbmCwEytkkW9aeaXc2T47aR5kAFaEAYTit98M Z5malFQbeVNc7xw8e4aGzmL55X/MPmAx1403pCnc5NcQ0pSa7lYsjX4kcbPXUwUfz0wu ejflyBWM2vok03Es8pStJyeLEfjMigFFnJHHKHBNAud1h2XaaQp77Yq9v+pv7eeXEeKC v5jkK1Zn2lTOnyjwKBJJIky7VY5y5akdEXpFokg6BxrS96W8bp3uJo7VtGmLKrMiedBS JZiC0kzgFQazGg8Whcg2L3h/hap5VbnD+nmdx3OqpemX3iBQh8sYedZ+chbgzuctlerq zJAw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Pt8Isr2HG44a61v/I+6GwVmkq/73CMjlMF2wBD73MzE=; fh=PNvaLswGJ26klsPfkGGhf9Ppr/vjNw8LDr3eh6+RQKA=; b=SNhoLunYdeGFrAOpBfMPt4XWXkbzyvT4aqRe/Hwb4UeS7u6HdCC9jMSHJjpIx33kCq kXevj8ns9YIncCrXVXdVKVeN4p6hG3g9EtTQOJ6dRQm9QEs544hxmiUuTzT4sdNQ87x/ MjhJqY50T8+XmzXiC0HyyD+3p9l/n2y5rhRlgJy5RaEVMZuDdLI6jrndiqs/Z7aTu+uA rpolItWhh/8nvfeay34AM/ssSoe2mHnoEPF5ZP05HGSs1E3VFseY0I9G+O91xRcAlVTj 4K+mshVEMhwG+k1K8YIsm324Wk+sp4b4E3Jkb2+3eceLKKH/+VH2iBAN3JbOgmTKhXpW R/jQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="WE/GeHz/"; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-71547-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71547-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id fa32-20020a056a002d2000b006e46dc9e8c5si1217338pfb.73.2024.02.19.12.29.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 12:29:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71547-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="WE/GeHz/"; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-71547-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71547-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 26C53B234F4 for ; Mon, 19 Feb 2024 15:08:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B9D093FE4C; Mon, 19 Feb 2024 15:06:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WE/GeHz/" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 675343A8FB; Mon, 19 Feb 2024 15:06:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355200; cv=none; b=MxFdzfZd/7hMYgWWP+YVc2QC7SWZ7NLZRdCy+j2jp0drlgLu5BjAVoJ4cWaX4W2MHZzKiml/zwDncLy3pY7mBf9NwlBjHK/jbSH0cMZWywvRa61B9GP+ffINx5DFYsM9S1DtThhdXtc+X7cJ0EPzdIZhPC0Bb2LB6NGi3poArJg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355200; c=relaxed/simple; bh=z+Ws30rfAliHI0b46QssEAM2g90mM8I8G/D4OgscpxM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Z8BxXs9qt8O2Z2XJRBoRPkPXT9ogKWLsf0brkXtZiNiWP/2vsQ7+cBe1WUd9Ec012exT4JLS8HQOZg0NlnF0Tx+Ubja6eB2Ov6y7hdCGMKXZod6/qQPTejz9D4K398o6ubplp6V2CLWgum3srgAUzbVOvqwtGHIkDOrWJ88AT9o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=WE/GeHz/; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708355198; x=1739891198; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=z+Ws30rfAliHI0b46QssEAM2g90mM8I8G/D4OgscpxM=; b=WE/GeHz/V/u0/+UoSyfjEerK74UNtM5leEoYjsOOCSEQ74eMr68titx+ dTY+h8SAhUzk/h44QlwsFvDWJ8YgTNJXOxe13BQb6zJWf1gclowvtLMC/ FbNB6QQ7fFwedbfRYByriSMj7YY3dahhBRltui4W4kiB2lbhVRZKTz1II XRIobB1OpfCL79aiDWSmANuAMb0xI2TAe66qL8GYG1LC+sHN+XP/d6Fkv uR4TFexIT+Lwl9KsSVP4lshH6063ChkFnAUyeAMg9Di7Z3RPxDsn/6ezc fqtgBPxuC7GX/dpIJ9oMlBh+yJbwXN/y90qaOrq+VjAtToeanjUVcQlL4 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="2543809" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="2543809" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 07:06:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="936302995" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="936302995" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 19 Feb 2024 07:06:32 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 2130445B; Mon, 19 Feb 2024 17:06:29 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Jiri Slaby Subject: [PATCH v2 5/7] serial: 8250_exar: switch to DEFINE_SIMPLE_DEV_PM_OPS() Date: Mon, 19 Feb 2024 17:05:01 +0200 Message-ID: <20240219150627.2101198-6-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> References: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791360589062175237 X-GMAIL-MSGID: 1791360589062175237 SIMPLE_DEV_PM_OPS() is deprecated, replace it with DEFINE_SIMPLE_DEV_PM_OPS() and use pm_sleep_ptr() for setting the driver's PM routines. We can now remove the __maybe_unused qualifier in the suspend and resume functions. Signed-off-by: Andy Shevchenko --- drivers/tty/serial/8250/8250_exar.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c index 2a0c1f7e87f5..53c5ff49e83c 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -746,7 +747,7 @@ static void exar_pci_remove(struct pci_dev *pcidev) priv->board->exit(pcidev); } -static int __maybe_unused exar_suspend(struct device *dev) +static int exar_suspend(struct device *dev) { struct exar8250 *priv = dev_get_drvdata(dev); unsigned int i; @@ -758,7 +759,7 @@ static int __maybe_unused exar_suspend(struct device *dev) return 0; } -static int __maybe_unused exar_resume(struct device *dev) +static int exar_resume(struct device *dev) { struct exar8250 *priv = dev_get_drvdata(dev); unsigned int i; @@ -772,7 +773,7 @@ static int __maybe_unused exar_resume(struct device *dev) return 0; } -static SIMPLE_DEV_PM_OPS(exar_pci_pm, exar_suspend, exar_resume); +static DEFINE_SIMPLE_DEV_PM_OPS(exar_pci_pm, exar_suspend, exar_resume); static const struct exar8250_board pbn_fastcom335_2 = { .num_ports = 2, @@ -922,7 +923,7 @@ static struct pci_driver exar_pci_driver = { .probe = exar_pci_probe, .remove = exar_pci_remove, .driver = { - .pm = &exar_pci_pm, + .pm = pm_sleep_ptr(&exar_pci_pm), }, .id_table = exar_pci_tbl, }; From patchwork Mon Feb 19 15:05:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 203170 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp1390793dyc; Mon, 19 Feb 2024 08:24:35 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX+rIuxU++e7xK0amFXLvJp4gYE14PtcV00PPpoJnEywrApBfHQbRbdTLQV2Shd9q0gEPqdjq+4nvu5V+l2XKnXteL/eA== X-Google-Smtp-Source: AGHT+IGcNRybI9gNCA25GWcPB9zJgIO4E7AzvR6Gk0a46M7h/2jMsY4l7FTVyA2/lCKR5hkxs4Ts X-Received: by 2002:a17:90b:112:b0:299:36d5:ce42 with SMTP id p18-20020a17090b011200b0029936d5ce42mr5728300pjz.30.1708359875438; Mon, 19 Feb 2024 08:24:35 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708359875; cv=pass; d=google.com; s=arc-20160816; b=zNIH75kbMjPzvXh5bz0ZJgJitE9zjVXMZel6zvclRWvMVDoTgkHsyFT3qSU4GDHkTM f+y3VDf2EOXLycilNzci5DzS9QFLLFuSQKC/4HyJrkvOBbtLT2GOHrHOfRwyhRgGG0aC qeD0yleLBvxVnwTkScBXvHxK1ZQxaJn0/a6z0A26NkQ6z60ZUb/KquC1iWHZlSgmZ6Jq Vq9hnYqOH6HdFehu8OKSSyoRa8nzuQ40G6hKPiOIvLjm263cUXj0kUbhst0Hpw67aCFR xFuwnXXSzd4/frj/5u25xMcOlZiXJ6hUAlZqivAZh472hHk+wlQH6AROi318uc9JHYWl /Kog== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=C2GVbdxyybxA+KIlTvp6KEKvVbbMrpaB9xVpeTYuAVg=; fh=PNvaLswGJ26klsPfkGGhf9Ppr/vjNw8LDr3eh6+RQKA=; b=eYNcLmPtui0CqZdp5oke5LNsqSdIPGuV72DJ7hmbQJWQ8qeZWk06DBnGLz319MH/he QW37wH5UNslUVxjTTWb/0pk7C8qkLdhnwlPftWR1YvTDPbkFjwG5oFRQACFhj44eFnIc t4/p0gH8C14g9I0lbRjR8c/RDrMheWlli+Fj090kyfAmwVlRFyMB5GLjvlmukVj8fMdj nqIr60iyfT/zri7END8L1o2LGIGZ3MDAiVfWJwTcriNtARsOvz60i1ExBkn3OKqT0HFD HFj8h+S6NuSFcKQgyQ5ckWRd4WTbMqWe36lfq88DPJO+YMPB2hkItDMUqOEzYWAeUVdD kyzQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VBFgojoN; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-71545-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71545-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id bv12-20020a17090af18c00b0029930700dd8si4679568pjb.94.2024.02.19.08.24.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 08:24:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71545-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=VBFgojoN; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-71545-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71545-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id DB78AB2352E for ; Mon, 19 Feb 2024 15:08:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6371F3EA82; Mon, 19 Feb 2024 15:06:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="VBFgojoN" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09BE439AEB; Mon, 19 Feb 2024 15:06:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355198; cv=none; b=eGSwEG/9zOigdwygqg2gXv3SQBLHebPTnhpuui33PIW1ZCG1JFPAVGeSMvKydvc7f/SMvh6EIs0jgUAMCoTgjAjlscf5LJFHFYmmAz4vHHoLAMElMj4eGq4d/3ysnVau+Ta+rfKMuhiI1d31PopOh3vzK98gbjew4AUjChOaguU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355198; c=relaxed/simple; bh=XhwsDorFFCDFsHo4F14gBApk9LhtQz1RvNmzKOWEAn8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lBBV+riIx1NOz/4VlvY0lk1aA+upB8KtwEb+s3cUUYnukJeaRrh2PL8cM3880kshlQ9fNfViYKcdchfOI6NLleeh4tO4ixBJ6xjk5mZQllhIx8V3KDr1PTFCvQUNLI4RuBjsT3a9w/W4qfXdQdt1h3dByUNKrV25l2AVKKMp1Z4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=VBFgojoN; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708355197; x=1739891197; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=XhwsDorFFCDFsHo4F14gBApk9LhtQz1RvNmzKOWEAn8=; b=VBFgojoNeCZtFyl9GsHBi9ZivZcGZbUDzFwwaPHc1S8x+5qHisxxeMLb FV+I94GHi/hQUphR/DvYJY1mwhRClIzvZoay8EfSiBhOZ4iNV7GFW6Rk5 tRgzCBztj2rDDXx6KAqKa+n2isj+JmGJvQVgPJGopeofz67vSKBnD8AWh qS313h+9AzBrQaLwxrsE89h7Lm01zTrPNkl6qW71p8E8wnOMJnLgIEZNZ HYp6D4NgZr8N9p4INkfDe6SLx3T7jJGVhg0qly5xCRHNiIwwip9YbbRMU yXiYTEq09uDZPO9JpobqS4XV64EQg3m/aJGcg3bUGRbwcLgGYR7s1cs5z g==; X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="2543791" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="2543791" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 07:06:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="936302994" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="936302994" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 19 Feb 2024 07:06:32 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 2A45E456; Mon, 19 Feb 2024 17:06:29 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Jiri Slaby Subject: [PATCH v2 6/7] serial: 8250_exar: Use 8250 PCI library to map and assign resources Date: Mon, 19 Feb 2024 17:05:02 +0200 Message-ID: <20240219150627.2101198-7-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> References: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791345164861161940 X-GMAIL-MSGID: 1791345164861161940 8250 PCI library provides a common code to map and assign resources. Use it in order to deduplicate existing code and support IO port variants. Signed-off-by: Andy Shevchenko --- drivers/tty/serial/8250/8250_exar.c | 11 ++++++----- drivers/tty/serial/8250/Kconfig | 1 + 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c index 53c5ff49e83c..cf1abe2fc28a 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -24,6 +24,7 @@ #include #include "8250.h" +#include "8250_pcilib.h" #define PCI_DEVICE_ID_ACCESSIO_COM_2S 0x1052 #define PCI_DEVICE_ID_ACCESSIO_COM_4S 0x105d @@ -219,13 +220,12 @@ static int default_setup(struct exar8250 *priv, struct pci_dev *pcidev, struct uart_8250_port *port) { const struct exar8250_board *board = priv->board; - unsigned int bar = 0; unsigned char status; + int err; - port->port.iotype = UPIO_MEM; - port->port.mapbase = pci_resource_start(pcidev, bar) + offset; - port->port.membase = priv->virt + offset; - port->port.regshift = board->reg_shift; + err = serial8250_pci_setup_port(pcidev, port, 0, offset, board->reg_shift); + if (err) + return err; /* * XR17V35x UARTs have an extra divisor register, DLD that gets enabled @@ -929,6 +929,7 @@ static struct pci_driver exar_pci_driver = { }; module_pci_driver(exar_pci_driver); +MODULE_IMPORT_NS(SERIAL_8250_PCI); MODULE_LICENSE("GPL"); MODULE_DESCRIPTION("Exar Serial Driver"); MODULE_AUTHOR("Sudip Mukherjee "); diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig index 8b9a2c4902e2..47ff50763c04 100644 --- a/drivers/tty/serial/8250/Kconfig +++ b/drivers/tty/serial/8250/Kconfig @@ -149,6 +149,7 @@ config SERIAL_8250_PCI config SERIAL_8250_EXAR tristate "8250/16550 Exar/Commtech PCI/PCIe device support" depends on SERIAL_8250 && PCI + select SERIAL_8250_PCILIB default SERIAL_8250 help This builds support for XR17C1xx, XR17V3xx and some Commtech From patchwork Mon Feb 19 15:05:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 203169 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp1390513dyc; Mon, 19 Feb 2024 08:24:02 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUCW0+dcQb2ggJoOrwflEAJtXJG4mEw6Lq4hYXYUsfZ4r9uTF4cbN5EVlW+zgiKRXkgFhJFu5IwFm1uSPtvYRARuz1rLw== X-Google-Smtp-Source: AGHT+IEpGz//mbhou2NoH6yJRLVfHAeYEmyIaPH13xk/JN+OrG++DFaWcaYRBYLljz40EBNUF9/H X-Received: by 2002:a17:902:e80c:b0:1db:f811:66f7 with SMTP id u12-20020a170902e80c00b001dbf81166f7mr2821262plg.60.1708359842288; Mon, 19 Feb 2024 08:24:02 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708359842; cv=pass; d=google.com; s=arc-20160816; b=FI3Q86eWYd+l1JpH6Q0JhuGHxA/hU40v1BGRaYZdHM0pfACPN4NJkNC4W7At5+VW+j JwFy2MRToTDBQ1JU0C9MjwSe2xVhPmYz7x+fJ4vKQsVVYDLDworbLywsAzH8F7ycKmHI 7TQcaG0fa4mKgxILHY8t1ymGSGURaOiFHAKVtRSpRicxvGRl8/vQqpTse3xlIxAr8lT1 8/gTHFEy7z++chXeB9cPryWFrS99w+Pq+Zm8LF8MU8kWNZaXf+M1C98/rF5u8xWepKFn dBVhVJaxJIAg5THcEekJTq4lfJpTF8gcGDk/M3+aroFPzDFJT/HnjKC60huS0R19nbA7 Wy5g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=aeGBTqcl7/By3LxrNA2LmUUeQshny8LKo561V2Qvb2k=; fh=PNvaLswGJ26klsPfkGGhf9Ppr/vjNw8LDr3eh6+RQKA=; b=mWzovXu+I2dkr6Gqwfb1JNO9QH+/RoSn+XUKwqdgKEyZBuhrs9Fnc6jINhRU54qzo7 Vl/WJ+O+CQut0sLpa3dQdFNgJDXfH6S8LScSz4V3tNtg79vcaPFtkyzulHyFXr+HLr0V NoLT7VfON2g9cZvY3zjz/8DeUx+PFJpP6k1xG6VbqHg//GzvgD5Db6IsCtlowqjreSE4 BDBFxRP4kWig7udPJhmeF7XXYMOWEnyECd0Ha6Mz8WIu/LJeE7/OURdR6nS8TWp9TBJS WAjDtj5cwn/lNOwkzIouKvDni+UBzGk5nftSQbCBTHVVcqNuEijrrKhhzTDEEBZoDsXg kpaA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NbelpyT0; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-71548-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71548-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id lk16-20020a17090308d000b001db9f6cc5edsi4759281plb.455.2024.02.19.08.24.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 08:24:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71548-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=NbelpyT0; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-71548-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71548-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id ACEF4B2398A for ; Mon, 19 Feb 2024 15:08:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F1BB0405C6; Mon, 19 Feb 2024 15:06:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="NbelpyT0" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D77503BB38; Mon, 19 Feb 2024 15:06:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355200; cv=none; b=XJmc/4+EcFeE7SPrc2AoQOVeP2Ft/3OGoqEjo5I8xSk+YR2Mc2qWpZaJ2Whpfu3TkL3GVH89pkIJkxscbRnINS++FPdn5WyqZ4RHVrJIep/TqSyDWd3xOUCq16ifWXZw/zMyyeJfNVFfaGKZuqQfR6fT3J5CQYgjMM1okL7NLik= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708355200; c=relaxed/simple; bh=DCAxzfXqTax5T11aXU0gJP0t0VjNv7GMA3otlVXbuV0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Er4f8b6cazcqhxqk5l/qQUODQe3M9gkMf60MF1Aa6PKRa/F4gEzAprKOqhThwKobgPDchZlFz6az/WrdxlZEBAJv6gaLF+GlNLzY9PrK2ymkQGajaPAk6XuAKGqj5/zIYaBHrzLKmvtMY9b8wJzGMZwUxtvZGdjy2QU782IuAZs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=NbelpyT0; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708355199; x=1739891199; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=DCAxzfXqTax5T11aXU0gJP0t0VjNv7GMA3otlVXbuV0=; b=NbelpyT08Fn9zO5T7boXSV3UD+RCUzalRxnq00otNEaIzmBIpoOHi3wR qMBZ4nWjeeA4xJGjHXqTQM6TczDOfU0c1dWJ/zvqYkXt7WxKJZQyLsnPk 7UqJAe336U8yIqASBGaUkc3RBIKMyoLhBStqC7aCNrrI5ih4jk93QD6Cd 0RJXIKe6XwGavlodwip8JEHtJNdXPbbuEbFbogwyyBT0lQJs1h9Wg0ymZ TcXdjqo15xb86cxQUfqHW2oR2KehnLiwDRoQfMhcShK7FgiY1N8Rp4QGF Hclp+LfxulRIyeYYeAO9N/AvAiPOK7o4F6Yno6XiCmwb/W6VV3HGhnx3p A==; X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="2543808" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="2543808" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2024 07:06:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10989"; a="936302996" X-IronPort-AV: E=Sophos;i="6.06,170,1705392000"; d="scan'208";a="936302996" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 19 Feb 2024 07:06:32 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 3BB8F499; Mon, 19 Feb 2024 17:06:29 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Cc: Jiri Slaby Subject: [PATCH v2 7/7] serial: 8250_exar: Don't use "proxy" headers Date: Mon, 19 Feb 2024 17:05:03 +0200 Message-ID: <20240219150627.2101198-8-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.43.0.rc1.1.gbec44491f096 In-Reply-To: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> References: <20240219150627.2101198-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791345129660215526 X-GMAIL-MSGID: 1791345129660215526 Update header inclusions to follow IWYU (Include What You Use) principle. Signed-off-by: Andy Shevchenko --- drivers/tty/serial/8250/8250_exar.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c index cf1abe2fc28a..2df2c9ea7b34 100644 --- a/drivers/tty/serial/8250/8250_exar.c +++ b/drivers/tty/serial/8250/8250_exar.c @@ -6,20 +6,24 @@ * * Copyright (C) 2017 Sudip Mukherjee, All Rights Reserved. */ +#include +#include +#include #include +#include #include -#include +#include #include #include #include #include #include +#include +#include + +#include #include #include -#include -#include -#include -#include #include