From patchwork Mon Feb 19 15:50:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Biju Das X-Patchwork-Id: 203158 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp1369057dyc; Mon, 19 Feb 2024 07:51:02 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXasws1k2mfjlt8QrSAeSe+oZiL7eYZmJo8+HF563HkMQ0t3/VbLE+II7zGIJSWd1Fn4OEv/bK9LyidiKlbg1ZEADLXcw== X-Google-Smtp-Source: AGHT+IFjoGj9ucZywpQfV9seZuh5vk0btdJpAQZsxKAoRRV1hIQayo/PzMGG8v+JYGrf4ArUCuuU X-Received: by 2002:a62:b417:0:b0:6e4:6650:dcb0 with SMTP id h23-20020a62b417000000b006e46650dcb0mr1885347pfn.6.1708357862482; Mon, 19 Feb 2024 07:51:02 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708357862; cv=pass; d=google.com; s=arc-20160816; b=MiHoZJbBy4YRQHKc97DzETvc1ZMnqFrjL/16VnFR5hDcfzLEydOL6m+em6n5MiyEbq Cc8xmkT1HQKWzYgpfb7OhK7w+4xvLF512lAO0FyIJoPX79ooKcbKVk7lEIOUqUFP3kob F11m2uEdI4iFCMTQrb+J5X2ZyYQTL+OTGcz6zwwFsbxqk6tdX1F5J5zwCvWendQtG6uh p/nxpsNIfVsjWNmkZ3ZFxX3y65C/1xZWJyeE8pw+Uz/KVWHahfia61PRz6QzOZMKksCu M9IPKDI11Ix/UOy9zcf2+NYeRbWoZNQcL95sXQtRYCIDvILQ8afo/qWZ4h8+nGgQm4IC 0GMA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:date :subject:cc:to:from:message-id; bh=7u8BKoZPmqehfI5zYiyhoGg7FLRYDnWozYDo5oR0kmc=; fh=g5Fy58+5SRAYhLwhNwGdUPxGvtryXsoLHZjmND6ksWs=; b=aDQkRz2ULaylcezrI+ji39/U9c64HHKqqTQjrtItHei0jvPyeiSQ4vj5m72ucIAp9n WTuAIbTZ/qcOInE4dlH7vgo6AgnthlOu1zejpShT04j7WMhVSLOwQID0v8k1lvevoIei yfh69rFEt8IUeirMf+wUX1QVJl3XWOOEj7UHbuqXhBZFo9FEtp/IhOsn8RbLlDeUfS2c M2PHUdPGtQlV5gohZxZ/UeA1tJRgPsb8+9iC//xVUu+uycsx1hRypXP06McMXx66IC0h /wdPaN4UQax9uPC3XX28nzR3JBK8QM/3AYTYxiNhH5VjX5c8K49+El1R6DLhqRZ4fYL0 1n/Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=bp.renesas.com dmarc=pass fromdomain=bp.renesas.com); spf=pass (google.com: domain of linux-kernel+bounces-71616-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71616-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id m22-20020a637d56000000b005c65d0dd9a0si4597147pgn.503.2024.02.19.07.51.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 07:51:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71616-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=bp.renesas.com dmarc=pass fromdomain=bp.renesas.com); spf=pass (google.com: domain of linux-kernel+bounces-71616-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71616-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=renesas.com Message-ID: <65d378e6.630a0220.3c09b.5f8aSMTPIN_ADDED_BROKEN@mx.google.com> X-Google-Original-Message-ID: <170802702416.398.14922976721740218856.tip-bot2@tip-bot2> (raw) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4B5482847B8 for ; Mon, 19 Feb 2024 15:51:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 297D13BB38; Mon, 19 Feb 2024 15:50:47 +0000 (UTC) Received: from relmlie5.idc.renesas.com (relmlor1.renesas.com [210.160.252.171]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C819638DEA; Mon, 19 Feb 2024 15:50:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.160.252.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708357845; cv=none; b=oi2qbWzYRSMbga4vj7Vb0EQFocUz2sd9/25GZNLSA7+VVCr5N2oPFl+szH55CsziXlwM8DuMygr4oX0YXQzuiv38M1ZLZhkTXuKtlEWkY4wXubsYPEyUG9WBMXvM5jdK8pjOBRCjJaI/uXbflllU1/MqgqNiQShUwQAOI3MGkMQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708357845; c=relaxed/simple; bh=3gljEuQh4fhhlvTwEdHbLdMg7pIM+AmlQfvPws8ZqqY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Dc+aqwZnq0OnyJejVnUar3oX+sn52g0NdZ+F8l7jKtVWO0Mnc4YuP4WVatzUjOP9pZNuMmFIx2VoKwE408f4iJiQPcjmy6WxdbPV6dTyKlWcwgSehOYe32j7qNm9Vi0PyvVm56o5W+C+xwp8yMo+fineqqC5kCiFkSvAIlCY2CU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com; spf=pass smtp.mailfrom=bp.renesas.com; arc=none smtp.client-ip=210.160.252.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=bp.renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bp.renesas.com X-IronPort-AV: E=Sophos;i="6.06,170,1705330800"; d="scan'208";a="194447432" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie5.idc.renesas.com with ESMTP; 20 Feb 2024 00:50:41 +0900 Received: from localhost.localdomain (unknown [10.226.92.217]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id 56E95400FFE9; Tue, 20 Feb 2024 00:50:38 +0900 (JST) From: Biju Das To: tip-bot2@linutronix.de Cc: apatel@ventanamicro.com, linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org, tglx@linutronix.de, geert@linux-m68k.org, maz@kernel.org, linux-renesas-soc@vger.kernel.org, x86@kernel.org Subject: [tip: irq/msi] genirq/irqdomain: Remove the param count restriction from select() Date: Mon, 19 Feb 2024 15:50:36 +0000 X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240127161753.114685-3-apatel@ventanamicro.com> References: <170802702416.398.14922976721740218856.tip-bot2@tip-bot2> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789261270358928439 X-GMAIL-MSGID: 1791343054398128587 > Now that the GIC-v3 callback can handle invocation with a fwspec parameter > count of 0 lift the restriction in the core code and invoke select() > unconditionally when the domain provides it. This patch breaks on RZ/G2L SMARC EVK as of_phandle_args_to_fwspec count() is called after irq_find_matching_fwspec() is causing fwspec->param_count=0 and this results in boot failure as the patch removes the check. Maybe we need to revert this patch or fix the fundamental issue. Cheers, Biju --- kernel/irq/irqdomain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c index 0bdef4f..8fee379 100644 --- a/kernel/irq/irqdomain.c +++ b/kernel/irq/irqdomain.c @@ -448,7 +448,7 @@ struct irq_domain *irq_find_matching_fwspec(struct irq_fwspec *fwspec, */ mutex_lock(&irq_domain_mutex); list_for_each_entry(h, &irq_domain_list, link) { - if (h->ops->select && fwspec->param_count) + if (h->ops->select) rc = h->ops->select(h, fwspec, bus_token); else if (h->ops->match) rc = h->ops->match(h, to_of_node(fwnode), bus_token);