From patchwork Mon Feb 19 20:28:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 203273 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp29759dyc; Mon, 19 Feb 2024 12:43:37 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUyA9ErReNJ5ru219PS/DcNp/714zR0PVsXPEE9kLXMcAtZD52gEFzTse8b0y7YKAnQgfYcBStaB0Dydal9WAY3vdCOog== X-Google-Smtp-Source: AGHT+IER7QYrdi4Zj0wMkfsxJXL1en9OWK6bH/JlAaCwLpqIr2XBd8TkmYL/kC4AH42H73d8F2D0 X-Received: by 2002:a17:902:8209:b0:1d9:d341:b150 with SMTP id x9-20020a170902820900b001d9d341b150mr11834081pln.40.1708375417680; Mon, 19 Feb 2024 12:43:37 -0800 (PST) Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id x10-20020a170902ec8a00b001db40e91bf8si4976640plg.249.2024.02.19.12.43.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 12:43:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71967-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-71967-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71967-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id D6F7BB20DF1 for ; Mon, 19 Feb 2024 20:29:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4646A535D1; Mon, 19 Feb 2024 20:29:17 +0000 (UTC) Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2720A51037 for ; Mon, 19 Feb 2024 20:29:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708374555; cv=none; b=nnkf9q94PIzpwbRIeIVYyxO2bHpKaiOFLM8Al438jd1E8emehiZiiUgRh113uXTI7VrC5qHH81/23PxjGkjGdBV+6SO43SMT7cybtGu11BD92dGsjxFtJPTnR3bihS5YZ0ZuxZ3VB3BeeSMkEiQmNtxw4g8pqiofCTchVcP1tos= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708374555; c=relaxed/simple; bh=ZP/nBJDy/7TZiOH+/d+Y9CHtVeb5MnzHiWAONgPk/vM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=R0fdSvrCRB8oHDN2CV5STluqp5itqokCum8kUqgZisXyS+fT8p+mxVtSBbjYw2aNCrJonTSomi4gkj+TVyFBdn81mBFJwy+yrWqiBhfcOzWhOzK6qTxj217lSEx+A/aaR0L+RsK6oAnxO2loZVORHGLpd/y51e4mHYlV8bXDjPU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rcAGG-0007Jk-5i; Mon, 19 Feb 2024 21:29:12 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rcAGF-001iQB-D8; Mon, 19 Feb 2024 21:29:11 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rcAGF-0084Bl-13; Mon, 19 Feb 2024 21:29:11 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] w1: mxc_w1: Convert to platform remove callback returning void Date: Mon, 19 Feb 2024 21:28:35 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1770; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=ZP/nBJDy/7TZiOH+/d+Y9CHtVeb5MnzHiWAONgPk/vM=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl07n0d/ApK5c9A+8JWLF4qO1B375vgyNbiw9yI zfgzjo2ZiiJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZdO59AAKCRCPgPtYfRL+ TpDQB/9Kn0NBnSIwi/LA+oTPYqp8tenw2jQFT9nNgzt6CAlKoRoumPGk6lZ8cYTQxX/KNhb2pr9 ZXZf50Y+f7bhr8mvZRK3RYoxHR8lLTbLOTNb8SgVuG4UI7mjZthBa6eKJwFFmtEOi7Nwn/slKpw Y7dPir39d+wrbU0SXxmph31jszgBizOgvb/dL0hTJsugaZd3SnYCS1jslxF+eQLxWqAEEQexap8 0TiQV69xUxF/+s3y7WyOmoyVOel69iz6vjo3IB6U4Xpd6RIfuVEv5CIKEUbCcMmTGVmz/wyG/B6 kU/ZmriAKKPCkPG8urS+cHGy2eFfsLwb5/oOLAg4gKY2ipUd X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791361461866248241 X-GMAIL-MSGID: 1791361461866248241 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/w1/masters/mxc_w1.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/w1/masters/mxc_w1.c b/drivers/w1/masters/mxc_w1.c index 090cbbf9e1e2..ba1d0866d1c4 100644 --- a/drivers/w1/masters/mxc_w1.c +++ b/drivers/w1/masters/mxc_w1.c @@ -151,15 +151,13 @@ static int mxc_w1_probe(struct platform_device *pdev) /* * disassociate the w1 device from the driver */ -static int mxc_w1_remove(struct platform_device *pdev) +static void mxc_w1_remove(struct platform_device *pdev) { struct mxc_w1_device *mdev = platform_get_drvdata(pdev); w1_remove_master_device(&mdev->bus_master); clk_disable_unprepare(mdev->clk); - - return 0; } static const struct of_device_id mxc_w1_dt_ids[] = { @@ -174,7 +172,7 @@ static struct platform_driver mxc_w1_driver = { .of_match_table = mxc_w1_dt_ids, }, .probe = mxc_w1_probe, - .remove = mxc_w1_remove, + .remove_new = mxc_w1_remove, }; module_platform_driver(mxc_w1_driver); From patchwork Mon Feb 19 10:59:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 203008 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp1206436dyc; Mon, 19 Feb 2024 03:00:28 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUP8EW8e3i72EFmFenA+ldCjvAqid3nf1l1gQMJ+yEfaK99hsUKeqJ49yaNuMLtDLigqKT0k+9ezswcm/VB5noisoS+IQ== X-Google-Smtp-Source: AGHT+IGtizgApYph0NeYAObjsjiArXlnb+6VB8sLVPeiogZmkHEDvUUxZ/obxMq1gCLJHJt9ghfH X-Received: by 2002:a05:6870:9725:b0:21e:8e42:846e with SMTP id n37-20020a056870972500b0021e8e42846emr7628913oaq.26.1708340428191; Mon, 19 Feb 2024 03:00:28 -0800 (PST) Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id s25-20020a656919000000b005c688ef7549si4304037pgq.98.2024.02.19.03.00.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 03:00:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71163-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-71163-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71163-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BDC11281BC3 for ; Mon, 19 Feb 2024 11:00:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5F9352C6B0; Mon, 19 Feb 2024 10:59:43 +0000 (UTC) Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D892328DD0 for ; Mon, 19 Feb 2024 10:59:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708340381; cv=none; b=FiHl4OR7lXmI4tv5R9Wv6lsqnJVqNwYhhW5RHwJfxQZwGznfx61Apaw0A2+ytZdzqnyj7npPDBJyVQszqxYfLPv6uMpeJlz3hqOSqDZX6eiVVeiP2dS9uzqnuTUBxfBzcSUL4KbojvTRIVhZ6NkXNPWfre761zsW5ia/zd+3HGg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708340381; c=relaxed/simple; bh=LeFkUhF7INlM3yuDLb1Rsn627568Wm2uaSf9+/UNkoc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TaCZ/xJUD9HfQDdq+IoV3jLov2ANUESL3m2DwOgeeh0FQyf37ReFRSiSZZXZu3CconoAkbi4KRgD6OsOwCFer0Vw5jpmwJBKK1TPWSBN+HJQN7FukhjjU6YYJUTqzevJvkXLVJTUBhc6MhMtDGb5cxDgLwIWMJ5mlS8lFNBWdV0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rc1N2-0007t1-8l; Mon, 19 Feb 2024 11:59:36 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rc1N1-001dBA-S9; Mon, 19 Feb 2024 11:59:35 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rc1N1-007lm1-2Y; Mon, 19 Feb 2024 11:59:35 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: kernel@pengutronix.de, Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: [PATCH 2/4] w1: omap_hdq: Convert to platform remove callback returning void Date: Mon, 19 Feb 2024 11:59:28 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1828; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=LeFkUhF7INlM3yuDLb1Rsn627568Wm2uaSf9+/UNkoc=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl0zSQzv197BQttr+MmgiSNlxIVPdKy8hHHTXuy aHDevX/JKmJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZdM0kAAKCRCPgPtYfRL+ To/gCACEbqrpt26gtKcuJmYLXGd59FyHz2ICXd2bZHcLu4NwXNrd1CzunUdeXdpB1umeHcoXNRS 7rHWwIAVDNvsnNrKQ/p6Rna1xrIqk6St/6roDK903rwCogvgHqk/FhcEy9bzJQQjNt0yI8ERym7 sZ/vxWvTf97kJE/l+BdQrXYyBx8cbTKBufMl5BSbmwuAuRPGDGNkfF1ostHHmAmT/oKHMf534i5 ncWyeu4MtuJ+KFMGmif788caBXtjZNiWzlZRgKUzpLDrNvq2W40/22lbuAar666xUcSnVWo2l2+ piKSoWh2aveY8xTbVMxkXO25RIGpwfyh4IymKp2W4Sv3Vb1l X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791324772402609458 X-GMAIL-MSGID: 1791324772402609458 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/w1/masters/omap_hdq.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c index 6a39b71eb718..d1cb5190445a 100644 --- a/drivers/w1/masters/omap_hdq.c +++ b/drivers/w1/masters/omap_hdq.c @@ -647,7 +647,7 @@ static int omap_hdq_probe(struct platform_device *pdev) return ret; } -static int omap_hdq_remove(struct platform_device *pdev) +static void omap_hdq_remove(struct platform_device *pdev) { int active; @@ -661,8 +661,6 @@ static int omap_hdq_remove(struct platform_device *pdev) if (active >= 0) pm_runtime_put_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); - - return 0; } static const struct of_device_id omap_hdq_dt_ids[] = { @@ -674,7 +672,7 @@ MODULE_DEVICE_TABLE(of, omap_hdq_dt_ids); static struct platform_driver omap_hdq_driver = { .probe = omap_hdq_probe, - .remove = omap_hdq_remove, + .remove_new = omap_hdq_remove, .driver = { .name = "omap_hdq", .of_match_table = omap_hdq_dt_ids, From patchwork Mon Feb 19 20:28:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 203270 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp24449dyc; Mon, 19 Feb 2024 12:29:39 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCUGNQfrv5XzOTXToDIL4DyjaFVObl0JxwElZIBpkf8mUKRiO/8NVSh/DffS8bUDTIYv8YpRYKAkWmjYY6hRvsjhYEQPDQ== X-Google-Smtp-Source: AGHT+IHhLeNMtybbo3XGbkmIwVwt2bLMtWdGOd/v7+bWobWLZf8J/YIUh86zSfb8CzrsedoLtvTp X-Received: by 2002:a19:f811:0:b0:512:adef:f35a with SMTP id a17-20020a19f811000000b00512adeff35amr3188674lff.56.1708374579631; Mon, 19 Feb 2024 12:29:39 -0800 (PST) Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id fx24-20020a170906b75800b00a3e9df2a431si1075831ejb.536.2024.02.19.12.29.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 12:29:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71968-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-71968-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71968-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 1DC6B1F2414E for ; Mon, 19 Feb 2024 20:29:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 55D7253819; Mon, 19 Feb 2024 20:29:21 +0000 (UTC) Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D644D51037 for ; Mon, 19 Feb 2024 20:29:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708374559; cv=none; b=h0jeQHJe1pHZP809H4qZO7PrK/Hksd3HwDoXUmYNmz03qSDINszHyStXyh79ZTtXfYnwbC1uj1g0hzxyqSIYgf7G1/eK4skSpJmRuorN6wy0nDcgaStgFiSVIo+31BVAaSdlLjheoEhfsx/gXaPr+tqyVp2NqxwQX8kUB6DCoeg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708374559; c=relaxed/simple; bh=r+zd/WCnRKZ1ONNCYG3jHdIcJHBF1vRFZXywT0FOEl8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YmguTpoMvEfchMSnUgA1YxqfWFtGYMdqqNfeBp0uda66ufzYxTN+2euWT3afCiHM0m1n9fjjjKfpnD3mIVn146mbdhPHEgaoRTb9jkzqi0VcuFVw8omSMiIEszhlVKO+bI+iHgNDF4HMs7dW4gXOcsmYZqxfFzML0RU9io3hBEE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rcAGK-0007M9-3F; Mon, 19 Feb 2024 21:29:16 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rcAGJ-001iQT-Mi; Mon, 19 Feb 2024 21:29:15 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rcAGJ-0084Bu-20; Mon, 19 Feb 2024 21:29:15 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org Subject: [PATCH 3/4] w1: sgi_w1: Convert to platform remove callback returning void Date: Mon, 19 Feb 2024 21:28:36 +0100 Message-ID: <68632fffa01f69eeaddfc0ad9de8f067b164e4fb.1708340114.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1710; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=r+zd/WCnRKZ1ONNCYG3jHdIcJHBF1vRFZXywT0FOEl8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl07n1a5bnLeQQUvLb7aYKJVGTC5kvi7axNWf7o DBld7ZvJF+JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZdO59QAKCRCPgPtYfRL+ TrvOB/9MbNwxgiXhhyVH1fI+1ItOQu9GdpyL20nbCPk/yVCfJglCdW52nnr2MLrzer5RDxBB6Hn hcrKt9LSEa5ZmlmAfE8Ucxs2nedsNtQ0MwA7YQYA4dWBFioFdIGkhLh5hikAC6zYJfMBziXhpvI hTc05rVo5xjoGi/JN1agSehutA8PbPFbtyc23God70nUF3sUpCtSgFGYJzgKXcCLL0lC6y2vCmy Sm7oISEAxcvlz2qbEI66K0wQiH3EWrKa2t6zfSQskRcZAW9VTI3CKMC8znOyLDVlt7Wxsa/G8Cn 5FFLNhHlIaqYwKvq0k470aoVP0V+hhDOjVXEGkzrbLwePb0u X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791360583029205972 X-GMAIL-MSGID: 1791360583029205972 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/w1/masters/sgi_w1.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/w1/masters/sgi_w1.c b/drivers/w1/masters/sgi_w1.c index d7fbc3c146e1..7bb7876aa70e 100644 --- a/drivers/w1/masters/sgi_w1.c +++ b/drivers/w1/masters/sgi_w1.c @@ -105,13 +105,11 @@ static int sgi_w1_probe(struct platform_device *pdev) /* * disassociate the w1 device from the driver */ -static int sgi_w1_remove(struct platform_device *pdev) +static void sgi_w1_remove(struct platform_device *pdev) { struct sgi_w1_device *sdev = platform_get_drvdata(pdev); w1_remove_master_device(&sdev->bus_master); - - return 0; } static struct platform_driver sgi_w1_driver = { @@ -119,7 +117,7 @@ static struct platform_driver sgi_w1_driver = { .name = "sgi_w1", }, .probe = sgi_w1_probe, - .remove = sgi_w1_remove, + .remove_new = sgi_w1_remove, }; module_platform_driver(sgi_w1_driver); From patchwork Mon Feb 19 10:59:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 203006 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp1206355dyc; Mon, 19 Feb 2024 03:00:21 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCWWUukKcbzMCvWkSxHPgCrI4YAdCx/hp2yZ8cqS83bc2eNGKRUwfs/uT6UpM/Jns1fMSiGaShmqGyHaDkCGBxoN+o/gRg== X-Google-Smtp-Source: AGHT+IFwwn26Sew6Up1c13VUkfGt1xJq3h8Jp3a81/zyx/3UwDuJro5/+Cu0qRa0ezN951fCu+jy X-Received: by 2002:a17:902:654c:b0:1db:cbff:d6bf with SMTP id d12-20020a170902654c00b001dbcbffd6bfmr6201405pln.29.1708340421400; Mon, 19 Feb 2024 03:00:21 -0800 (PST) Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id bn22-20020a056a02031600b005d8be4f9ef2si4400196pgb.105.2024.02.19.03.00.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 03:00:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-71162-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-71162-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-71162-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4EB232804DE for ; Mon, 19 Feb 2024 11:00:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E1E7C2C690; Mon, 19 Feb 2024 10:59:42 +0000 (UTC) Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F20F28DD1 for ; Mon, 19 Feb 2024 10:59:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708340381; cv=none; b=afFaqVSEHUYr0CzYdT7f+fEbLxzRxEjBqrTbSB1I3rCZTrfRz4ShQL9sn8k2q3Ma1xSfkDlhjiXEwhiZM5AJ7DuOJYNnD5uaPE3KAWdNWTpS7HiJ9/eEluGnZjW5WWPluU0k3X2C9f+qkNuR0ATQdhRMZecGkofjQEXK2ni6+7o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708340381; c=relaxed/simple; bh=00egCWTf/Xz90viScRQeUZaKnDU/N7KFipBuJnl8Wp8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=e187HLA7PJ5tNfvNJ5vsbbgNBvskQBzj9mT34F/f/Vm6xZzRU1UUYuWFpAfdAW5+/gOmjCUFV5lXnDXe+zOsUvKV/E4xo6WD4qsKvSXjF+PSC3fW6CA4yrHH2CxltclPj1grqnTtGXPG+Yj8EL1nbuJuGbCFC4kr59LzJo8lGRs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rc1N2-0007tT-JA; Mon, 19 Feb 2024 11:59:36 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rc1N2-001dBG-6F; Mon, 19 Feb 2024 11:59:36 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rc1N2-007lm9-0N; Mon, 19 Feb 2024 11:59:36 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Krzysztof Kozlowski Cc: kernel@pengutronix.de, Rob Herring , Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: [PATCH 4/4] w1: w1-gpio: Convert to platform remove callback returning void Date: Mon, 19 Feb 2024 11:59:30 +0100 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1873; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=00egCWTf/Xz90viScRQeUZaKnDU/N7KFipBuJnl8Wp8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl0zSTrq456IYWTjU+KXkxkmXQkNFMCKWgFxPeF 73xd2/n6FKJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZdM0kwAKCRCPgPtYfRL+ TkKdB/9Nux88D/xvqCPsFwszanxBm2bILV18T4Ub+x9ms/hcYEGQUHyWyiPA1+6ByDeIKJaoR9T Uf63vNWNwVoKavgzTS6VssxsHw9EN41Xg9ftCbvwNTMgPtkUbop0uyuRQTAbNIrRQ0TKKyLUeMV ZXWahZ+BVxAEATso9pWa4sDt5DzzoohY+q1UKYXP2bxA4/3K+l1FNVUDcBWsexPl2RtpyibuBTj Ds6qsQHc0ngNXgbBwMR8zMS6xe5XbVdl9x5IoR5NOCdzasu5wVmFdo429TFwGyE7KFx5RC2Hgsl SbzekQjXrg7aXDor58e4YNb45qbQWxrQXMrFKlBaDeTcZiIC X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791324765897691944 X-GMAIL-MSGID: 1791324765897691944 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/w1/masters/w1-gpio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/w1/masters/w1-gpio.c b/drivers/w1/masters/w1-gpio.c index 05c67038ed20..34128e6bbbfa 100644 --- a/drivers/w1/masters/w1-gpio.c +++ b/drivers/w1/masters/w1-gpio.c @@ -141,7 +141,7 @@ static int w1_gpio_probe(struct platform_device *pdev) return 0; } -static int w1_gpio_remove(struct platform_device *pdev) +static void w1_gpio_remove(struct platform_device *pdev) { struct w1_bus_master *master = platform_get_drvdata(pdev); struct w1_gpio_ddata *ddata = master->data; @@ -150,8 +150,6 @@ static int w1_gpio_remove(struct platform_device *pdev) gpiod_set_value(ddata->pullup_gpiod, 0); w1_remove_master_device(master); - - return 0; } static struct platform_driver w1_gpio_driver = { @@ -160,7 +158,7 @@ static struct platform_driver w1_gpio_driver = { .of_match_table = of_match_ptr(w1_gpio_dt_ids), }, .probe = w1_gpio_probe, - .remove = w1_gpio_remove, + .remove_new = w1_gpio_remove, }; module_platform_driver(w1_gpio_driver);