From patchwork Sat Feb 17 18:49:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Ond=C5=99ej_Jirman?= X-Patchwork-Id: 202675 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp462868dyc; Sat, 17 Feb 2024 10:50:07 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXOqE2ts6BcWzKDS896EGhLzHC30ynub+n6yLkEdqO6P7RyySIyA1D3pa5hCLOUtiMXk3an5uT3EPuqymGxuJaIsNyIZw== X-Google-Smtp-Source: AGHT+IFk7s0bW39eqv1xdA4HFZRYb6cF/7eqgU0i/lSLZ+TNEFxYTAH2Les40Sp0Enq3kXqzaW8M X-Received: by 2002:ac2:546c:0:b0:511:88cc:4f00 with SMTP id e12-20020ac2546c000000b0051188cc4f00mr4982026lfn.56.1708195807533; Sat, 17 Feb 2024 10:50:07 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708195807; cv=pass; d=google.com; s=arc-20160816; b=POST5reAZb5i42rR6i0Eqxr+YvDShQtvqpsbwH+Awa6U+kZMy0xDTouaTMEPWWby2G Wwyo1ET+qJtK0mWyQtuAL6szhjlmf/Pl0BboB0Aoh/PQB94GygPEyeAgg+JuQ088wnED C7bvmSwJTMtPTXBMQ+xQb7dm3onyCzMvvcY3pCbWPBHZW73BIjDRAEwpH0I+RAb+AWKe Pmrkukq5WzZU4Cbg5dBiVPlLEq5vZkCUNMc9w2eQ5MOJO5CdiEJKEIMDFBUX9rBpVmc+ eNClSkNfEt2dpri3xTE81e9W4KAlpPrXFSyYEZP7JySTwdoU9jHfETOCDFy7TCKxp7za tvlA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=PRXFYnP9bqBoO+cJ/HGdnYyZsgtyIdGQWvm9L/dO4p0=; fh=w5ok93khmGV7v1K7EqO4o2hifXsr4lI7ZIlmA3JDzEM=; b=mdn8ua/6zOkJoXo+leAJ2M1GlfLyx+uNUqraqqpj3SVGxPHSouM9Kj77Uz4iOEKz1S +eq6Fs0G7L03+kVb+KBeOHVNeusnFHI5OP5wE4+beK1Ijkc6UYDp/bfjffM0GB24rvWn M525J5/u7w8vuxdgsIz2t0hV2RG/y2N826LfkBLYIqcWgy/8cmJiKrOlWJTiRvEBnVwg mEbTWnQrG/7wbdMGYyMapJc1HalocLcojMMk+0e52EGq82jnxcI2cv4E+J0bigrQQAPq 4uJ6Z1UwfJR8CX6RdSRbXSBuzj+dcb8om8QIj/5gnDCYEhXJVGIHTDkqQL3kkWE/yfjU m1wQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@xff.cz header.s=mail header.b=p0kanJWR; arc=pass (i=1 spf=pass spfdomain=xff.cz dkim=pass dkdomain=xff.cz dmarc=pass fromdomain=xff.cz); spf=pass (google.com: domain of linux-kernel+bounces-70020-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70020-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=xff.cz Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id kx24-20020a170907775800b00a3d9a27e29fsi1071350ejc.279.2024.02.17.10.50.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Feb 2024 10:50:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-70020-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@xff.cz header.s=mail header.b=p0kanJWR; arc=pass (i=1 spf=pass spfdomain=xff.cz dkim=pass dkdomain=xff.cz dmarc=pass fromdomain=xff.cz); spf=pass (google.com: domain of linux-kernel+bounces-70020-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70020-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=xff.cz Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 253B51F2242D for ; Sat, 17 Feb 2024 18:50:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 358B17E575; Sat, 17 Feb 2024 18:49:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=xff.cz header.i=@xff.cz header.b="p0kanJWR" Received: from vps.xff.cz (vps.xff.cz [195.181.215.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1A3341A91; Sat, 17 Feb 2024 18:49:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.181.215.36 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708195790; cv=none; b=cEzZ3uvTlx905hAhzHyc9yJXkNOfQiNUksYwld/LsvjW3TP530tqMLujJH+x/LEtIVy4j7VNUny5vpkSfXNNnbKk0jlPS++i71rWYG2tcWXeZZYv2yppQMojcoLEVnyG0ZMSd914nMgmOebPq++rpF8VmEDrLhCuwSVc/OlsWQo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708195790; c=relaxed/simple; bh=P6v2JvS1OzYzht9jsA5pBiVpyCWfx3yjVjiid49u5/w=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JTNpqS3+ro6XkZD+EHmu+S2iokblpYxJwW8U8cRk2Xs9KLOCevjiiNIwn0jLtXyaR5ccHLH27eBDlDoQ+16d40C6YO1vXPnsJYJYO8jnG36XX4tY42xiWfijPl/Up2/2qTa8gJ6CFS3BtsnRn7l2znPgsQQQ7/s+hihUi5YFf2k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xff.cz; spf=pass smtp.mailfrom=xff.cz; dkim=pass (1024-bit key) header.d=xff.cz header.i=@xff.cz header.b=p0kanJWR; arc=none smtp.client-ip=195.181.215.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xff.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xff.cz DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1708195786; bh=P6v2JvS1OzYzht9jsA5pBiVpyCWfx3yjVjiid49u5/w=; h=From:To:Cc:Subject:Date:From; b=p0kanJWRFlJOStFcRZd6OHuJj8qJIcMfZFEEegxQq5DwKlImYdrK+uyJIBAOKgqXr 03UvSjh3i3+1kZSwf3EDN4AEQFQxOPsfC1Ybw8wh34Bhxj83nAaSwO78S58+OSZRWQ tZRVXXOf5Dc7WiKU8u6JwRQG1rJtTgw4DynssOP4= From: =?utf-8?q?Ond=C5=99ej_Jirman?= To: linux-kernel@vger.kernel.org Cc: Ondrej Jirman , Sakari Ailus , Mauro Carvalho Chehab , linux-media@vger.kernel.org (open list:V4L2 LENS DRIVERS) Subject: [PATCH] media: i2c: dw9714: Fix occasional probe errors Date: Sat, 17 Feb 2024 19:49:11 +0100 Message-ID: <20240217184926.1754245-1-megi@xff.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791173126802236897 X-GMAIL-MSGID: 1791173126802236897 From: Ondrej Jirman The powerup delay was not observed during probe, leading to occasional I2C communication failures in RPM suspend callback. Power delay is properly observed in resume callback already. Signed-off-by: Ondrej Jirman --- drivers/media/i2c/dw9714.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/i2c/dw9714.c b/drivers/media/i2c/dw9714.c index cc09b32ede60..84d29bcf0ccd 100644 --- a/drivers/media/i2c/dw9714.c +++ b/drivers/media/i2c/dw9714.c @@ -157,6 +157,8 @@ static int dw9714_probe(struct i2c_client *client) return rval; } + usleep_range(1000, 2000); + v4l2_i2c_subdev_init(&dw9714_dev->sd, client, &dw9714_ops); dw9714_dev->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE | V4L2_SUBDEV_FL_HAS_EVENTS;