From patchwork Thu Feb 15 09:10:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 201294 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:b825:b0:106:860b:bbdd with SMTP id da37csp266699dyb; Thu, 15 Feb 2024 01:12:06 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUQCNJ44ap9bIYAcv/P4138c0FuTAzD00iZC3p/iWBTOr8O8vUpuPk4JZAkJkHq6F8vHGy8AaoQ9F5vSO/Qll1XyqbNIg== X-Google-Smtp-Source: AGHT+IHSG1WkI8Kfo3Uoa7gkSyUpn09pArpsFE8yeavbcfgLGeqKEc5ChJX9kuFzt6qRZxgOzAWz X-Received: by 2002:a05:6808:de3:b0:3c0:3733:c250 with SMTP id g35-20020a0568080de300b003c03733c250mr1128794oic.20.1707988326061; Thu, 15 Feb 2024 01:12:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707988326; cv=pass; d=google.com; s=arc-20160816; b=DmD7YIsOBVs7lcPeccuzhH/p1dGiI6TXNcqjF5VeZa2gJNLyv830U8mGrnVDbLJlU3 wcrd0+qQNJ39nmEkfUfSHwYZBSNx6cE1NqDwjyBJXvGH3fNzX7vV0P3TgPPbFRmiwhjw u0ixbx5qcjuWs0lJRpwtZFYe3Hj6RXCNsJ0cvsckjwJHWkLMu5EpHUj/YCewz4dtaE2+ 5+b76+vvIFKi27MNO5sOlOk07MDqnMnnAcPoC9PI8pTjISF0UnayrMGIA5SRDG1PwWuA b5DVsHIA53q8zDPsanzCf4tHJXvbYSpE7jqmaxZ4nT43EgzFORasFq4yIEcUOhUd4SKh ufIA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:reply-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-disposition:in-reply-to :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature:arc-filter:dmarc-filter:delivered-to; bh=XCWz+IsLs/NbEUjMpm3f3QNfGrS3JaNng+VEZH2EMBw=; fh=6g5iAbC+XidtEF8DuLv6mBhnB4r8EPazdQZCDjG7quo=; b=WI/kstRY+RDV4/lGk3UE58jHjAIOF8jQu6OsXORXcWYd7F/8zAHiK2greNqjbh3qsM CLemxlxOm1kgT585Zy2BYSl90DTH4R52VJIPjw1+3PRcLyZbmoHtlm7dk8s8pH7sXk2D DqG1UgCyUat/EqtgKFWPLPhgvDZ6YGHIMkvMwBGGWzze2DpKubpg+bpl/JO00AleSFly R/EqRpo0jfDekcd7eRGWJuqS0h1OKmfvYefqELxgw6rL2kw6uFEajsARDJ2fGRX1cisU v4UXYGa2clvYYoSHdmcZa51CKATsBvrMUR4t+O8HF7myDwx0IHHUhXPi0nmBP/tqVzm6 zRog==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WrfQuta4; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from server2.sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id 4-20020ac85644000000b0042c3986d756si930160qtt.129.2024.02.15.01.12.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 01:12:06 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WrfQuta4; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BCBA1386186C for ; Thu, 15 Feb 2024 09:12:05 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 88CE4386183D for ; Thu, 15 Feb 2024 09:11:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 88CE4386183D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 88CE4386183D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707988273; cv=none; b=g3ByyUefgwWmvKMr2VdaCQzs4dcZMwWXCbgIt5j643QB740e1pZjU8+wbU2pQQ0rpBS+uMYYC+r8DJempfcYwb8StV67kJ5Cr8SALQVrGYJ4oTULkdfOiyzr93xdVqE7dFZ3MO17tveeYcTWDLDuVqlnBBd9wCV4NczCqVt+HG4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707988273; c=relaxed/simple; bh=a3Q2uE7nY7ervRSGEhasu7Ep0d7wZ1i2aGxFN6zIIug=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=FmKTgGGpOGgSkpsBirKOmWZ2rQhqdokEg/rlTmSmDIHbdaRVZMFf/v6p06W4n14Tg0/bFFSEGZZztgJlBL3YPiZ8nzr2KrtLjA6+8eh7mo4jSqgTpy8mqrXg13jZ2kiUOkiGTtYw1Fj6Xfo0/FJDc7sky/RZSF6tJn0DSK6saa8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707988267; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=XCWz+IsLs/NbEUjMpm3f3QNfGrS3JaNng+VEZH2EMBw=; b=WrfQuta45MLCAtKmdYT9BjC9vdZJDNlPihgr9NVrIaxSUoPsQZYrGV32GFhYVrLphsdMAh /u9RwHU70vHSiqV27gqh2g5YvG3VoXeOOPw0fakX/LxcW2EA+RjztpUx+dOtW/Z4bF+uEa vIRNpXT2UPPyj/chOiGYaEJeGsaXd3s= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-418-bghn5I2qOl236zQGaXyzkA-1; Thu, 15 Feb 2024 04:11:03 -0500 X-MC-Unique: bghn5I2qOl236zQGaXyzkA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 95196870824; Thu, 15 Feb 2024 09:11:03 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.8]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 576E02156702; Thu, 15 Feb 2024 09:11:03 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 41F9B06J1209311 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 15 Feb 2024 10:11:00 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 41F9Axme1209310; Thu, 15 Feb 2024 10:10:59 +0100 Date: Thu, 15 Feb 2024 10:10:59 +0100 From: Jakub Jelinek To: Arthur Cohen , Philip Herron Cc: gcc-patches@gcc.gnu.org, gcc-rust@gcc.gnu.org Subject: [PATCH] gccrs: Avoid *.bak suffixed tests - use dg-skip-if instead Message-ID: References: <20240207114419.1100894-2-arthur.cohen@embecosm.com> <20240207114419.1100894-14-arthur.cohen@embecosm.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Jakub Jelinek Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790955567144155394 X-GMAIL-MSGID: 1790955567144155394 On Fri, Feb 09, 2024 at 11:03:38AM +0100, Jakub Jelinek wrote: > On Wed, Feb 07, 2024 at 12:43:59PM +0100, arthur.cohen@embecosm.com wrote: > > From: Philip Herron > > > > This patch introduces one regression because generics are getting better > > understood over time. The code here used to apply generics with the same > > symbol from previous segments which was a bit of a hack with out limited > > inference variable support. The regression looks like it will be related > > to another issue which needs to default integer inference variables much > > more aggresivly to default integer. > > > > Fixes #2723 > > > > gcc/rust/ChangeLog: > > > > * typecheck/rust-hir-type-check-path.cc (TypeCheckExpr::resolve_segments): remove hack > > > > gcc/testsuite/ChangeLog: > > > > * rust/compile/issue-1773.rs: Moved to... > > * rust/compile/issue-1773.rs.bak: ...here. > > Please don't use such suffixes in the testsuite. > Either delete the testcase, or xfail it somehow until the bug is fixed. To be precise, I have scripts to look for backup files in the tree (*~, *.bak, *.orig, *.rej etc.) and this stands in the way several times a day. Here is a fix for that in patch form, tested on x86_64-linux with make check-rust RUNTESTFLAGS='compile.exp=issue-1773.rs' Ok for trunk? 2024-02-15 Jakub Jelinek * rust/compile/issue-1773.rs.bak: Rename to ... * rust/compile/issue-1773.rs: ... this. Add dg-skip-if directive. Jakub diff --git a/gcc/testsuite/rust/compile/issue-1773.rs.bak b/gcc/testsuite/rust/compile/issue-1773.rs similarity index 89% rename from gcc/testsuite/rust/compile/issue-1773.rs.bak rename to gcc/testsuite/rust/compile/issue-1773.rs index a4542aea00b..468497a4792 100644 --- a/gcc/testsuite/rust/compile/issue-1773.rs.bak +++ b/gcc/testsuite/rust/compile/issue-1773.rs @@ -1,4 +1,5 @@ #[lang = "sized"] +// { dg-skip-if "" { *-*-* } } pub trait Sized {} trait Foo {