From patchwork Thu Feb 15 08:44:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 201262 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:b825:b0:106:860b:bbdd with SMTP id da37csp255210dyb; Thu, 15 Feb 2024 00:45:13 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW5b6DY8xH0x3Z4Pv854y99SngTRahwsH2ynm0HNiZbBN5RoLowsvH8v/Egjz/j09U4soXtH9G33atvZx1nUPuJTX3TaA== X-Google-Smtp-Source: AGHT+IHZb9Ao9t77FjkMDWqB3p3eN4i/wc661W8BT2MdU4lYDxWNpZxNfd9TP7x8pkwDhBF7VCcJ X-Received: by 2002:a37:c408:0:b0:785:b88a:1437 with SMTP id d8-20020a37c408000000b00785b88a1437mr1148597qki.37.1707986713593; Thu, 15 Feb 2024 00:45:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707986713; cv=pass; d=google.com; s=arc-20160816; b=Emvg9bX1kAbBTS1zHDpLVGvtclcRiyY/hsidkUdXETlRlMlbPQB5QJ8EhRNZpw6bx+ VcIAqlw8PTOSmYW5ryQG6y8U39qGQuL6Ev4oPp/eTO3h1IRSI4ZFeAuVBbvV7E7bynvk J3U/PtV3cRYPVZggKYgPtNz5v6dyOCLX0eSGiYIqr8tJwVFwdgh48AcmZW13n+l3qtjv z0jEDv5e41TUtLVWoeziEVd2ziQtbywrCHHrD8RILhmKc1wxAc5i53KFFH5mHUEB3qaW AeBJbH2HhIh/g2wcjcW5bfEBu1wXOrhcgTsKbf4OALwzxdNLyAOb0od9h+2Svay8BMjQ xpMQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-disposition :mime-version:message-id:subject:to:from:date:dkim-signature :arc-filter:dmarc-filter:delivered-to; bh=/4bSaCXhjqHjVNOUsGK+Zu5S9i6NnY6fYkTRusqdZ5A=; fh=NLxAvL/bDfPg4AGOtxqvQlND8vazkZrNzKLY8+LAbBY=; b=zN8fsrWxxs61umhrNAphqtYxDSB0YfWvZrUG+8N8GK8s+gWntNxwSDjC2Uy7hKHvkw t2EbPQDXOLBCutRgISUYTCZRTu9G/6vxFDeBzvRswiHdA/DfpldIl89AOXF5XwvfJGPG zGH5I9rdIf7EvrFv40sscKi6ISuCV1H6mHKGc3X/S9rNnYSjqddfw+4JaJlsLgfzoNxy E3mYM9mDfdTB/0B7dgo/9ANAZoDMMb3FIZuzJUn9l7b/TbbqjnQteDJ308hreqe59pNw tOM54vWmLnofwRh9WkhKMs0wt5nm4K77S5VMfqavHLgKqlB/RcJuKAb9yaVtbziNauE0 PcxA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ad9qHZjb; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id h24-20020a05620a21d800b007853c0bc590si982945qka.271.2024.02.15.00.45.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 00:45:13 -0800 (PST) Received-SPF: pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ad9qHZjb; arc=pass (i=1); spf=pass (google.com: domain of binutils-bounces+ouuuleilei=gmail.com@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="binutils-bounces+ouuuleilei=gmail.com@sourceware.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1EDA03861855 for ; Thu, 15 Feb 2024 08:45:13 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id E37963861855 for ; Thu, 15 Feb 2024 08:44:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E37963861855 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E37963861855 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707986701; cv=none; b=DThdoMFKCLLo9ueTIDpICgzRiUkC0h/nUZGLX15ExJLaYWkL1jqyl+Rhl5Ns2LWYDI5+p/7nbZqyGoMuFt+FHHR4OC3EPCt+fmB8QW75e6Yukt6wTaM4LP6u8CKg85Y30F42rS+SmnRLKCItU+PEKAOegCkagZpH7WLpDqP3iDs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707986701; c=relaxed/simple; bh=hs42ckbSD7sn4RRiGuqu6rY71UoCIehPVcgTS2FcedI=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=EyMC3yUef0kUYDL2Y5XP/P7pUJxbyOZfIlXCpzouOqSzDaRc4mqTrLOmcYIECF6qxllh2emrs1Cw0bcCkPTFB7lbnS1jKeFYtSNGv8T7o8bppd1YYgihKbwwRJgqIs+LhMXwaolsc83OyJ+gCqGst3sq6LicdV8D86giWy3fLdE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1d746ce7d13so5824285ad.0 for ; Thu, 15 Feb 2024 00:44:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707986697; x=1708591497; darn=sourceware.org; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=/4bSaCXhjqHjVNOUsGK+Zu5S9i6NnY6fYkTRusqdZ5A=; b=ad9qHZjbTovNG39CDdxXHigH9pLgyxpcZ0O/zbkRlaqN5kVZESk7YODdzGGQYBicra gGP3NC92q+Px6SuwCbm9Z63bmu6DAJiE2HaVC4ZzU1wGf0wd3AC9qC5IL1Gm+VKQ8laq YLH1jXf5G+uXCii5XFExYKIVDE5eq41dOhdA+tq+may7Lgodw0Sw2H8Pu2DKI80G2Aef UyiO9l8jO359uc7ZyNtzedodd0cz1QBON5feTk5fegVjrtjSKoT8sV472GtOjZ/6bM45 GZcLyMpPB3p/BzDCbbBYnp9G4uiW5Jbs9VOXwRDFWuLomVHKL3kZltkZqn32pyuaBPy0 Z/YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707986697; x=1708591497; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/4bSaCXhjqHjVNOUsGK+Zu5S9i6NnY6fYkTRusqdZ5A=; b=qELmNOx737tEUCXQPDDATXgJGkhRfqBqoh7S4X3/U7csAb0C09yfJfzYZ5DVJmeG6W PtDhsePoGTwypl8jOBQCMpI2f5virDQb76KYG8uKniM9phGniUcKtiPGp4bJP9UKQPFg N/9lWyJLPNzleYqGNORsyaTPjuUHT0JIzxmtIXvFrQB54eZmFRXPUm6lxEjDwTLUi2Xx hadrsV4MWC41su7UaeIfA96NcndSDg9ro9RJeKElGhrYqlhXObFytZuV/NK+LsO2twsp O1EI5AsTp9a8ARlq90snAzcwHDcsJYk3XXTXWGpMAaLKIihINAMuAoeK/eKnloO8QxEA Kzcg== X-Gm-Message-State: AOJu0YxQITqM61Yy9Jc+nOC2Yco1vxZR+jZ9GWnO8z/ymyNWwqxKJPj/ b056lX8tq2zQAnhwF58mFJs8jZrAZxQlyKwEIm6WA2lILduyHfc+77wTK6Yi X-Received: by 2002:a17:903:2291:b0:1db:4f20:3ada with SMTP id b17-20020a170903229100b001db4f203adamr1510690plh.49.1707986696942; Thu, 15 Feb 2024 00:44:56 -0800 (PST) Received: from squeak.grove.modra.org ([2406:3400:51d:8cc0:dec2:7d97:e7f:4c60]) by smtp.gmail.com with ESMTPSA id q16-20020a170902b11000b001da27cbcf5dsm747213plr.228.2024.02.15.00.44.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Feb 2024 00:44:56 -0800 (PST) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 0F74B11423AD; Thu, 15 Feb 2024 19:14:54 +1030 (ACDT) Date: Thu, 15 Feb 2024 19:14:54 +1030 From: Alan Modra To: binutils@sourceware.org Subject: PR28448, Memory leak in function add_symbols(plugin.c) Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3033.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+ouuuleilei=gmail.com@sourceware.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790951812133737671 X-GMAIL-MSGID: 1790953876016618895 PR 28448 * plugin.c (add_symbols): bfd_alloc memory for symptrs. Check bfd_make_empty_symbol return. diff --git a/ld/plugin.c b/ld/plugin.c index e982869072b..f81ab02b3a6 100644 --- a/ld/plugin.c +++ b/ld/plugin.c @@ -506,7 +506,9 @@ add_symbols (void *handle, int nsyms, const struct ld_plugin_symbol *syms) int n; ASSERT (called_plugin); - symptrs = xmalloc (nsyms * sizeof *symptrs); + symptrs = bfd_alloc (abfd, nsyms * sizeof *symptrs); + if (symptrs == NULL) + return LDPS_ERR; for (n = 0; n < nsyms; n++) { enum ld_plugin_status rv; @@ -514,6 +516,8 @@ add_symbols (void *handle, int nsyms, const struct ld_plugin_symbol *syms) bfdsym = bfd_make_empty_symbol (abfd); symptrs[n] = bfdsym; + if (bfdsym == NULL) + return LDPS_ERR; rv = asymbol_from_plugin_symbol (abfd, bfdsym, syms + n); if (rv != LDPS_OK) return rv;