From patchwork Wed Feb 14 22:04:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zi Yan X-Patchwork-Id: 201144 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:b825:b0:106:860b:bbdd with SMTP id da37csp11954dyb; Wed, 14 Feb 2024 14:05:55 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWHFSb+QgCAvOVa2BaYyG5uE31hVDLEroeYuJr55BE5X+4+8JiviXO19lhGexCQuThFW9LPddamkj6qlCreprREEEsr3A== X-Google-Smtp-Source: AGHT+IGmUE3v3UZFHw9fIbD40DLUwW75VtoIHMmzFerIfsMFmKwvhseQDqkxk++F5b3V9ZUS0HnP X-Received: by 2002:a05:620a:831b:b0:785:ce02:4f82 with SMTP id pa27-20020a05620a831b00b00785ce024f82mr50183qkn.17.1707948354978; Wed, 14 Feb 2024 14:05:54 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707948354; cv=pass; d=google.com; s=arc-20160816; b=wyieiqEUOV10/+nb6+XqZo4cr/sxvxnXcVcN2ea+eoKBmEbzNmfN2V3/p5NfideZTO 41KC4MlW+evZyrj9/w59GbBxyrAALr/l3SvDhwhO5n8Yz43sMNIzK1Tj/4kC+uWlSRkQ brl+4jHXsDhPlITKI5yKxc7c5Ivmgae7vqTPBsJXrX3wxqwpEnoJaC/HeC2NzkTMVE76 6cG17EthVHS0/+H2wJcYVuDxVYFio/ZZxfcb7AIgTY/7yFZoKWDwB+9vOsa0weSKIfsW QPKhljn3TlR1yH/0fztIKRmNVI627exnE9sxA2Jfc35w6amWr+ZdQp6G66dSJHXB0Jkl 0SfA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:reply-to:references:in-reply-to :message-id:date:subject:cc:to:from:feedback-id:dkim-signature :dkim-signature; bh=iXB4hFIGUr+5qlTT7GwOhxHq+2xnf+LZ7P4ZJxJN83A=; fh=vJ0CYzlC3FzFcxY+JvdHzizIe8XjzG5USPt1Sa6qsGI=; b=cxjU0641HU9Ea9Pj5hb5DRziAAo2PIKn1rhfTXxSQR7FyH5XvERDgwVdpxAc1vWhUv iPljYEi3qeNmYfm/OuaYnmbqHlATAYqGUsqf7/k8tVc2KWXdCxl+nXXouf0i9UQsZFHj +UgYS7VxFl0Vlbd5Tq6RCx8CKcgJRtlJpiKx/6h06azhhP1NqZaVpBi2ap489NUVEKOK gfro3+CemkvZlbre4w357HQbThIPpEL9s6ecaFQwW+/yAwDSqvzL5BBgQ8aI7KIJUA1Y F1z08JW1ye9dL/En2KOjFpiTniTWNOk/R+HXDKAXsK0wAj4fBXR0vHto7qJZ4UjQDjYQ WBjg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sent.com header.s=fm3 header.b=Sd+c9faY; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=Xkqa1QfF; arc=pass (i=1 spf=pass spfdomain=sent.com dkim=pass dkdomain=sent.com dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=sent.com); spf=pass (google.com: domain of linux-kernel+bounces-66021-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66021-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sent.com Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id l8-20020a05620a28c800b00783fa16e057si29060qkp.709.2024.02.14.14.05.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 14:05:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-66021-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@sent.com header.s=fm3 header.b=Sd+c9faY; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=Xkqa1QfF; arc=pass (i=1 spf=pass spfdomain=sent.com dkim=pass dkdomain=sent.com dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=sent.com); spf=pass (google.com: domain of linux-kernel+bounces-66021-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66021-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sent.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 300CB1C21DF4 for ; Wed, 14 Feb 2024 22:05:12 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3AFA61420B8; Wed, 14 Feb 2024 22:04:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sent.com header.i=@sent.com header.b="Sd+c9faY"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Xkqa1QfF" Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A81C713F01D for ; Wed, 14 Feb 2024 22:04:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=66.111.4.28 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707948279; cv=none; b=jnpjw7IaeDUMSpJM5aQIasKGkGFVJThG34YHCmx6YrexZAFTwdkQchmNgzw6Q6GNnw8Yk7h+qChB8qyCRM0OyaYpc79CWXRLdZDirXsXXBRabOy7AQGWflm5y7ho2HP+Cbvm0Q+OlFWV0EIbv+mOm/QIuQ0nkJJmE3FDQaIUc/Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707948279; c=relaxed/simple; bh=yUf65XhFg19drgHy7Tb4+9uoq0ZDXxUWdKwSfrAbetc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UChuQls1Qc/I8pRERC2m3KdwebiHjRLUe5Hiif1EIhCCb/GNPAo/gzYpZee7sDqlNKMEncex1jLCwhD918GAwk+VLyEHefdhu5CwCzgtNAriD3JorXzpf+Yd1coDmMKOCe5P9O6Xzu7zs9NIiLj8K/X0TcOTbLRjrZvd4BSF3yc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sent.com; spf=pass smtp.mailfrom=sent.com; dkim=pass (2048-bit key) header.d=sent.com header.i=@sent.com header.b=Sd+c9faY; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Xkqa1QfF; arc=none smtp.client-ip=66.111.4.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sent.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sent.com Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 6DB7C5C0085; Wed, 14 Feb 2024 17:04:36 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 14 Feb 2024 17:04:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sent.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to; s=fm3; t= 1707948276; x=1708034676; bh=iXB4hFIGUr+5qlTT7GwOhxHq+2xnf+LZ7P4 ZJxJN83A=; b=Sd+c9faYu7Kd229fSoKw0355HFCsVOXAmbPELIaKX/YxD+WxFDY vcGu+NgtgbpHDMFUrsbUSZUxVxKA8uI0/9CNsL0iziGpjnnv2gxQ7DXjjQN4ya4V 34KuyW0R91ZbLMbqMXQ0scp6jhEGZoha+V5eJkqGcjWOHmEXB3qtrgPl5Sb6BKzn Oqif52IBUC9w/4mZxLPB512uluRfD95IFp4J/Db8JJKKSEHbzuf8Jbo60T1kW2T9 TuQXp+qtRaWVixfnb1fRQYifBirC8HUdBkOF7NLqhN+2Nb/mY3ha6ovbk1oFJlSL GdOObLz0w9rXa3thQec+12QdRyBIAheVe2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1707948276; x=1708034676; bh=iXB4hFIGUr+5qlTT7GwOhxHq+2xnf+LZ7P4 ZJxJN83A=; b=Xkqa1QfFUJAP2Oc2PqL9OOQdKTWF4TU8hECtytbueECS/aK02jW xQVPmuwXdxW4dQ8F5llHdSDxXHuTXjeG/UTWq0BOX66FyAc/DDPmuox7konafdnm 7U4YRpsJCBHKz567H7o514UxXn7E8ZCQtEx8p/QdWRnGK8zf5BLrU9zw4HLL+dkF qMuqV/fEm+gii2q0jN+utvOcl7cfBx83lwg99A6Ss7O8GO2Qy1PSozvGolw7Z5+n viw2oV8U/nMSuKkCHI7kYTiRpPKKaVURc819sW3+gb/kSIQAQonRnamZgUWpE6TY Ql7EgqEWwIvn9kDvQLB/jmeZz7a1BaiFgDg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudejgdduheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhhrgggtgfesthekredtredtjeenucfhrhhomhepkghi ucgjrghnuceoiihirdihrghnsehsvghnthdrtghomheqnecuggftrfgrthhtvghrnhepje ekteekffelleekudfftdefvddtjeejuedtuedtteegjefgvedtfedujeekieevnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepiihirdihrghnse hsvghnthdrtghomh X-ME-Proxy: Feedback-ID: iccd040f4:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Feb 2024 17:04:35 -0500 (EST) From: Zi Yan To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Zi Yan , "Huang, Ying" , Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , Vlastimil Babka , "Kirill A . Shutemov" , Johannes Weiner , Baolin Wang , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" Subject: [PATCH v5 1/3] mm/compaction: enable compacting >0 order folios. Date: Wed, 14 Feb 2024 17:04:18 -0500 Message-ID: <20240214220420.1229173-2-zi.yan@sent.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240214220420.1229173-1-zi.yan@sent.com> References: <20240214220420.1229173-1-zi.yan@sent.com> Reply-To: Zi Yan Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790913654164351702 X-GMAIL-MSGID: 1790913654164351702 From: Zi Yan migrate_pages() supports >0 order folio migration and during compaction, even if compaction_alloc() cannot provide >0 order free pages, migrate_pages() can split the source page and try to migrate the base pages from the split. It can be a baseline and start point for adding support for compacting >0 order folios. Signed-off-by: Zi Yan Suggested-by: Huang Ying Reviewed-by: Baolin Wang Tested-by: Baolin Wang Tested-by: Yu Zhao Cc: Adam Manzanares Cc: David Hildenbrand Cc: Johannes Weiner Cc: Kemeng Shi Cc: Kirill A. Shutemov Cc: Luis Chamberlain Cc: Matthew Wilcox (Oracle) Cc: Mel Gorman Cc: Ryan Roberts Cc: Vishal Moola (Oracle) Cc: Vlastimil Babka Cc: Yin Fengwei Reviewed-by: Vlastimil Babka --- mm/compaction.c | 66 ++++++++++++++++++++++++++++++++++++++----------- 1 file changed, 52 insertions(+), 14 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index cc801ce099b4..aa6aad805c4d 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -816,6 +816,21 @@ static bool too_many_isolated(struct compact_control *cc) return too_many; } +/* + * 1. if the page order is larger than or equal to target_order (i.e., + * cc->order and when it is not -1 for global compaction), skip it since + * target_order already indicates no free page with larger than target_order + * exists and later migrating it will most likely fail; + * + * 2. compacting > pageblock_order pages does not improve memory fragmentation, + * skip them; + */ +static bool skip_isolation_on_order(int order, int target_order) +{ + return (target_order != -1 && order >= target_order) || + order >= pageblock_order; +} + /** * isolate_migratepages_block() - isolate all migrate-able pages within * a single pageblock @@ -947,7 +962,22 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, valid_page = page; } - if (PageHuge(page) && cc->alloc_contig) { + if (PageHuge(page)) { + /* + * skip hugetlbfs if we are not compacting for pages + * bigger than its order. THPs and other compound pages + * are handled below. + */ + if (!cc->alloc_contig) { + const unsigned int order = compound_order(page); + + if (order <= MAX_PAGE_ORDER) { + low_pfn += (1UL << order) - 1; + nr_scanned += (1UL << order) - 1; + } + goto isolate_fail; + } + /* for alloc_contig case */ if (locked) { unlock_page_lruvec_irqrestore(locked, flags); locked = NULL; @@ -1008,21 +1038,24 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, } /* - * Regardless of being on LRU, compound pages such as THP and - * hugetlbfs are not to be compacted unless we are attempting - * an allocation much larger than the huge page size (eg CMA). - * We can potentially save a lot of iterations if we skip them - * at once. The check is racy, but we can consider only valid - * values and the only danger is skipping too much. + * Regardless of being on LRU, compound pages such as THP + * (hugetlbfs is handled above) are not to be compacted unless + * we are attempting an allocation larger than the compound + * page size. We can potentially save a lot of iterations if we + * skip them at once. The check is racy, but we can consider + * only valid values and the only danger is skipping too much. */ if (PageCompound(page) && !cc->alloc_contig) { const unsigned int order = compound_order(page); - if (likely(order <= MAX_PAGE_ORDER)) { - low_pfn += (1UL << order) - 1; - nr_scanned += (1UL << order) - 1; + /* Skip based on page order and compaction target order. */ + if (skip_isolation_on_order(order, cc->order)) { + if (order <= MAX_PAGE_ORDER) { + low_pfn += (1UL << order) - 1; + nr_scanned += (1UL << order) - 1; + } + goto isolate_fail; } - goto isolate_fail; } /* @@ -1165,10 +1198,11 @@ isolate_migratepages_block(struct compact_control *cc, unsigned long low_pfn, } /* - * folio become large since the non-locked check, - * and it's on LRU. + * Check LRU folio order under the lock */ - if (unlikely(folio_test_large(folio) && !cc->alloc_contig)) { + if (unlikely(skip_isolation_on_order(folio_order(folio), + cc->order) && + !cc->alloc_contig)) { low_pfn += folio_nr_pages(folio) - 1; nr_scanned += folio_nr_pages(folio) - 1; folio_set_lru(folio); @@ -1788,6 +1822,10 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) struct compact_control *cc = (struct compact_control *)data; struct folio *dst; + /* this makes migrate_pages() split the source page and retry */ + if (folio_test_large(src) > 0) + return NULL; + if (list_empty(&cc->freepages)) { isolate_freepages(cc); From patchwork Wed Feb 14 22:04:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zi Yan X-Patchwork-Id: 201150 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:b825:b0:106:860b:bbdd with SMTP id da37csp18963dyb; Wed, 14 Feb 2024 14:22:11 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWiJesLX9F+IvGaPT5vz5h2OSg7ZNAvXI/Siy8WAv7MGxGhWNDaPkJepjq31WyyX8OqWNxsc5O3TLwEuuUHfdw6PnwcjA== X-Google-Smtp-Source: AGHT+IELvJiTV8ulSvMYOFdwNic6V8VcW2S4vzcFPpCUOthhFSBZ5IPZikzF4eEsOw5LEdPTbxQa X-Received: by 2002:a05:6a00:181c:b0:6da:14f3:53e8 with SMTP id y28-20020a056a00181c00b006da14f353e8mr164011pfa.24.1707949331265; Wed, 14 Feb 2024 14:22:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707949331; cv=pass; d=google.com; s=arc-20160816; b=lLfGuhuYczznLR5nEkkH3p3KOPWgG3UkV8AMt1vGslL8GKSpcB/8OImmmv0AYG1Kis SOBBHh5DP4Tp75LulBL76AGh+2jK+T2Zu/rD1n9vwMobh6S5tK/ePsFibNbAIaIsLEZy ZeuiOPZliEiZ+Xzy7864cStB/nbMBG85UA85YNXh5kXTF0S3EPP2S1Jw/ACb8hUFrPDw qCHedP8goXzsFvx6i6MGI8gEb26FibTRrY/C+obAQ9Nv3LzM8ZvTdAwXvzstzr6Mwwzm KFQnqgdHzjmmJFV0cQbbgzIudtEZJuyCy7PwPOhyGIxY4qiF1wLljmnuAULaMR9DInA1 3w5g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:reply-to:references:in-reply-to :message-id:date:subject:cc:to:from:feedback-id:dkim-signature :dkim-signature; bh=Pw8iFzi+4Wlq8GCwOctfvzaOJplSj1uRK0yZlCI1Ab0=; fh=Uq4mFU+8O5A576kdQFNPDDpSlKSVnHA+mM79sd4udec=; b=aHiLRr2rdyA6P8HTou2h8ue51T0vTFPBFyIxQmOWRBo6sfUxlRsOLUHO/pHgxPqRS9 xYALXaZB8BgIqBJLrHKRpiJBkcnIK6TU4sdAE3zO/uTnZ/Z7QYeNaNSfaRrcCGLH9BX8 ReM13VTIeDLHtU07R5KfaggIx/CIbtf8GbETIMrYC3GW/kfZaQI0f0QYOZpIo5jmlUk1 8Ghy5krCBUT89g2ryNvKCK79NXU77AGCBE0wIhZju6jW9a0G+gdY4lKtpJab2Qekbkq5 Z8GdaG9cCkQrTfOfMTuPep1ATbaJzu8nwUwZZxn6xFBazRFxIQUgQq0ATT6mkDU+AaY8 CT3A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sent.com header.s=fm3 header.b=JBDJWFY7; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=Syr7Aizs; arc=pass (i=1 spf=pass spfdomain=sent.com dkim=pass dkdomain=sent.com dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=sent.com); spf=pass (google.com: domain of linux-kernel+bounces-66022-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66022-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sent.com X-Forwarded-Encrypted: i=2; AJvYcCUWcKpzFp0MFsLjGXpd6aSNxIhvDOZ7sNNg074YKRRQzzzdXM0+yQjvGFyAgOn2+gdemVr4OJhYcgMROWM9gH+NLH9viA== Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id bz5-20020a056a02060500b005dc9617013bsi1526165pgb.33.2024.02.14.14.22.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 14:22:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-66022-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@sent.com header.s=fm3 header.b=JBDJWFY7; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=Syr7Aizs; arc=pass (i=1 spf=pass spfdomain=sent.com dkim=pass dkdomain=sent.com dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=sent.com); spf=pass (google.com: domain of linux-kernel+bounces-66022-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66022-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sent.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id B9264B2879F for ; Wed, 14 Feb 2024 22:05:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7AE91141988; Wed, 14 Feb 2024 22:04:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sent.com header.i=@sent.com header.b="JBDJWFY7"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Syr7Aizs" Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6173613F01E for ; Wed, 14 Feb 2024 22:04:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=66.111.4.28 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707948280; cv=none; b=mI5xYLwBXbowRtEMwkCTGzAttK/IDc/aPsj8ownufLvDl8lD3/7YcciK53DHBJLtYRnnPBiGqpasoybbPlFS10De6MkJqo7m4JzaG81dSSH7OMPEAiZ6ThyOa5YaTVCN00rYxIlnVCzvE2ZKyI3HoEnoafZD09bJuM/BQ2SmvSM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707948280; c=relaxed/simple; bh=yZAqTNQ+UoepZXq/WP23DfdkRkoDpKUHBpexSjX+tOo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hoT3JnP4boT8Uti68wnO6saEEDupcVSVUrBDyfbSbdSBif57rlNn3T7ZiA0WlaF65fv9PmadS0MLZZGri249wJJFWsUWRUDJAf0cBoErz+YOfSnw9wLDvPoWEPIoMVwYViP3Ulp2BXtdo8/NRdBMJAqJtVYcdhU89hNndjjZlmw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sent.com; spf=pass smtp.mailfrom=sent.com; dkim=pass (2048-bit key) header.d=sent.com header.i=@sent.com header.b=JBDJWFY7; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Syr7Aizs; arc=none smtp.client-ip=66.111.4.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sent.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sent.com Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 66C8C5C0087; Wed, 14 Feb 2024 17:04:37 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 14 Feb 2024 17:04:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sent.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to; s=fm3; t= 1707948277; x=1708034677; bh=Pw8iFzi+4Wlq8GCwOctfvzaOJplSj1uRK0y ZlCI1Ab0=; b=JBDJWFY7p7n/L8+ggyhC1OFPrK0sll4mus15uuuCFxLyN4x1dfS wT9D2uAhpYZkNA1h7pE7qSShC1dnX4ZXyANvl40VK6um7a2dItNOHdEo2sprHZje O6TbRba0xai5Ce/1rtfHLbCtN5XupC8OgpJiakkbyTqObcv8Jic/rIJUzkKP7mrN Ob19YIpwQ2pljVF7fjhYBBPPubTa2BuuMb8fD9rAoBDzgSjPhru2yhrJw9Bm+/m3 Z7wueGRCNrGWflCNlHlUMbvzpCY+Jig/4df8VYHIn4OPWtSMWDLp5Q3BcmqocXhE ObtoA27LX586bXn272J1HOhzAkzzT/yZVnQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1707948277; x=1708034677; bh=Pw8iFzi+4Wlq8GCwOctfvzaOJplSj1uRK0y ZlCI1Ab0=; b=Syr7AizsUQV8PlY0WaGklQNr48lOFnqElp1+dGba+UdIZvkXyYM 88NYt9kW0hRJb99t9LEuzhmY6ZeqxsiQp+CcOIlB9YgNOjxLYBmrJPfQPpj11HC4 +QmwtOuk2DOXRN+vegbCXpGUwwWFW9e7gNJu+ITTUoL11lfg4y780K1RzytuTZ/o k2H3GEKFC6/rtJ44RlGz+lQ0n7dVcMkV93GA2RG7alTr3QWyjdkeZ3+Hvrf7mJ3u 0P5Dut466Ks75wIuVhQv/eRIN06Tv+l5mdCrZe4RLa9zPnz2AlZZ9NMdN+56Mu0l g+8PA5W9vYgiVFV1WaX+1IUMfWM/4vGAUUA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudejgdduheekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhhrgggtgfesthekredtredtjeenucfhrhhomhepkghi ucgjrghnuceoiihirdihrghnsehsvghnthdrtghomheqnecuggftrfgrthhtvghrnhepje ekteekffelleekudfftdefvddtjeejuedtuedtteegjefgvedtfedujeekieevnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepiihirdihrghnse hsvghnthdrtghomh X-ME-Proxy: Feedback-ID: iccd040f4:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Feb 2024 17:04:36 -0500 (EST) From: Zi Yan To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Zi Yan , "Huang, Ying" , Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , Vlastimil Babka , "Kirill A . Shutemov" , Johannes Weiner , Baolin Wang , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" Subject: [PATCH v5 2/3] mm/compaction: add support for >0 order folio memory compaction. Date: Wed, 14 Feb 2024 17:04:19 -0500 Message-ID: <20240214220420.1229173-3-zi.yan@sent.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240214220420.1229173-1-zi.yan@sent.com> References: <20240214220420.1229173-1-zi.yan@sent.com> Reply-To: Zi Yan Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790914677668552316 X-GMAIL-MSGID: 1790914677668552316 From: Zi Yan Before last commit, memory compaction only migrates order-0 folios and skips >0 order folios. Last commit splits all >0 order folios during compaction. This commit migrates >0 order folios during compaction by keeping isolated free pages at their original size without splitting them into order-0 pages and using them directly during migration process. What is different from the prior implementation: 1. All isolated free pages are kept in a NR_PAGE_ORDERS array of page lists, where each page list stores free pages in the same order. 2. All free pages are not post_alloc_hook() processed nor buddy pages, although their orders are stored in first page's private like buddy pages. 3. During migration, in new page allocation time (i.e., in compaction_alloc()), free pages are then processed by post_alloc_hook(). When migration fails and a new page is returned (i.e., in compaction_free()), free pages are restored by reversing the post_alloc_hook() operations using newly added free_pages_prepare_fpi_none(). Step 3 is done for a latter optimization that splitting and/or merging free pages during compaction becomes easier. Note: without splitting free pages, compaction can end prematurely due to migration will return -ENOMEM even if there is free pages. This happens when no order-0 free page exist and compaction_alloc() return NULL. Signed-off-by: Zi Yan Reviewed-by: Baolin Wang Tested-by: Baolin Wang Tested-by: Yu Zhao Cc: Adam Manzanares Cc: David Hildenbrand Cc: Huang Ying Cc: Johannes Weiner Cc: Kemeng Shi Cc: Kirill A. Shutemov Cc: Luis Chamberlain Cc: Matthew Wilcox (Oracle) Cc: Mel Gorman Cc: Ryan Roberts Cc: Vishal Moola (Oracle) Cc: Vlastimil Babka Cc: Yin Fengwei Reviewed-by: Vlastimil Babka --- mm/compaction.c | 143 +++++++++++++++++++++++++++--------------------- mm/internal.h | 4 +- mm/page_alloc.c | 6 ++ 3 files changed, 91 insertions(+), 62 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index aa6aad805c4d..d0a05a621b67 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -66,45 +66,56 @@ static inline void count_compact_events(enum vm_event_item item, long delta) #define COMPACTION_HPAGE_ORDER (PMD_SHIFT - PAGE_SHIFT) #endif -static unsigned long release_freepages(struct list_head *freelist) +static void split_map_pages(struct list_head *freepages) { + unsigned int i, order; struct page *page, *next; - unsigned long high_pfn = 0; + LIST_HEAD(tmp_list); - list_for_each_entry_safe(page, next, freelist, lru) { - unsigned long pfn = page_to_pfn(page); - list_del(&page->lru); - __free_page(page); - if (pfn > high_pfn) - high_pfn = pfn; - } + for (order = 0; order < NR_PAGE_ORDERS; order++) { + list_for_each_entry_safe(page, next, &freepages[order], lru) { + unsigned int nr_pages; - return high_pfn; + list_del(&page->lru); + + nr_pages = 1 << order; + + post_alloc_hook(page, order, __GFP_MOVABLE); + if (order) + split_page(page, order); + + for (i = 0; i < nr_pages; i++) { + list_add(&page->lru, &tmp_list); + page++; + } + } + list_splice_init(&tmp_list, &freepages[0]); + } } -static void split_map_pages(struct list_head *list) +static unsigned long release_free_list(struct list_head *freepages) { - unsigned int i, order, nr_pages; - struct page *page, *next; - LIST_HEAD(tmp_list); - - list_for_each_entry_safe(page, next, list, lru) { - list_del(&page->lru); + int order; + unsigned long high_pfn = 0; - order = page_private(page); - nr_pages = 1 << order; + for (order = 0; order < NR_PAGE_ORDERS; order++) { + struct page *page, *next; - post_alloc_hook(page, order, __GFP_MOVABLE); - if (order) - split_page(page, order); + list_for_each_entry_safe(page, next, &freepages[order], lru) { + unsigned long pfn = page_to_pfn(page); - for (i = 0; i < nr_pages; i++) { - list_add(&page->lru, &tmp_list); - page++; + list_del(&page->lru); + /* + * Convert free pages into post allocation pages, so + * that we can free them via __free_page. + */ + post_alloc_hook(page, order, __GFP_MOVABLE); + __free_pages(page, order); + if (pfn > high_pfn) + high_pfn = pfn; } } - - list_splice(&tmp_list, list); + return high_pfn; } #ifdef CONFIG_COMPACTION @@ -657,7 +668,7 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, nr_scanned += isolated - 1; total_isolated += isolated; cc->nr_freepages += isolated; - list_add_tail(&page->lru, freelist); + list_add_tail(&page->lru, &freelist[order]); if (!strict && cc->nr_migratepages <= cc->nr_freepages) { blockpfn += isolated; @@ -722,7 +733,11 @@ isolate_freepages_range(struct compact_control *cc, unsigned long start_pfn, unsigned long end_pfn) { unsigned long isolated, pfn, block_start_pfn, block_end_pfn; - LIST_HEAD(freelist); + int order; + struct list_head tmp_freepages[NR_PAGE_ORDERS]; + + for (order = 0; order < NR_PAGE_ORDERS; order++) + INIT_LIST_HEAD(&tmp_freepages[order]); pfn = start_pfn; block_start_pfn = pageblock_start_pfn(pfn); @@ -753,7 +768,7 @@ isolate_freepages_range(struct compact_control *cc, break; isolated = isolate_freepages_block(cc, &isolate_start_pfn, - block_end_pfn, &freelist, 0, true); + block_end_pfn, tmp_freepages, 0, true); /* * In strict mode, isolate_freepages_block() returns 0 if @@ -770,15 +785,15 @@ isolate_freepages_range(struct compact_control *cc, */ } - /* __isolate_free_page() does not map the pages */ - split_map_pages(&freelist); - if (pfn < end_pfn) { /* Loop terminated early, cleanup. */ - release_freepages(&freelist); + release_free_list(tmp_freepages); return 0; } + /* __isolate_free_page() does not map the pages */ + split_map_pages(tmp_freepages); + /* We don't use freelists for anything. */ return pfn; } @@ -1494,7 +1509,7 @@ fast_isolate_around(struct compact_control *cc, unsigned long pfn) if (!page) return; - isolate_freepages_block(cc, &start_pfn, end_pfn, &cc->freepages, 1, false); + isolate_freepages_block(cc, &start_pfn, end_pfn, cc->freepages, 1, false); /* Skip this pageblock in the future as it's full or nearly full */ if (start_pfn == end_pfn && !cc->no_set_skip_hint) @@ -1623,7 +1638,7 @@ static void fast_isolate_freepages(struct compact_control *cc) nr_scanned += nr_isolated - 1; total_isolated += nr_isolated; cc->nr_freepages += nr_isolated; - list_add_tail(&page->lru, &cc->freepages); + list_add_tail(&page->lru, &cc->freepages[order]); count_compact_events(COMPACTISOLATED, nr_isolated); } else { /* If isolation fails, abort the search */ @@ -1700,13 +1715,12 @@ static void isolate_freepages(struct compact_control *cc) unsigned long isolate_start_pfn; /* exact pfn we start at */ unsigned long block_end_pfn; /* end of current pageblock */ unsigned long low_pfn; /* lowest pfn scanner is able to scan */ - struct list_head *freelist = &cc->freepages; unsigned int stride; /* Try a small search of the free lists for a candidate */ fast_isolate_freepages(cc); if (cc->nr_freepages) - goto splitmap; + return; /* * Initialise the free scanner. The starting point is where we last @@ -1766,7 +1780,7 @@ static void isolate_freepages(struct compact_control *cc) /* Found a block suitable for isolating free pages from. */ nr_isolated = isolate_freepages_block(cc, &isolate_start_pfn, - block_end_pfn, freelist, stride, false); + block_end_pfn, cc->freepages, stride, false); /* Update the skip hint if the full pageblock was scanned */ if (isolate_start_pfn == block_end_pfn) @@ -1807,10 +1821,6 @@ static void isolate_freepages(struct compact_control *cc) * and the loop terminated due to isolate_start_pfn < low_pfn */ cc->free_pfn = isolate_start_pfn; - -splitmap: - /* __isolate_free_page() does not map the pages */ - split_map_pages(freelist); } /* @@ -1821,24 +1831,22 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) { struct compact_control *cc = (struct compact_control *)data; struct folio *dst; + int order = folio_order(src); - /* this makes migrate_pages() split the source page and retry */ - if (folio_test_large(src) > 0) - return NULL; - - if (list_empty(&cc->freepages)) { + if (list_empty(&cc->freepages[order])) { isolate_freepages(cc); - - if (list_empty(&cc->freepages)) + if (list_empty(&cc->freepages[order])) return NULL; } - dst = list_entry(cc->freepages.next, struct folio, lru); + dst = list_first_entry(&cc->freepages[order], struct folio, lru); list_del(&dst->lru); - cc->nr_freepages--; - cc->nr_migratepages -= 1 << folio_order(src); - - return dst; + post_alloc_hook(&dst->page, order, __GFP_MOVABLE); + if (order) + prep_compound_page(&dst->page, order); + cc->nr_freepages -= 1 << order; + cc->nr_migratepages -= 1 << order; + return page_rmappable_folio(&dst->page); } /* @@ -1849,10 +1857,22 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) static void compaction_free(struct folio *dst, unsigned long data) { struct compact_control *cc = (struct compact_control *)data; + int order = folio_order(dst); + struct page *page = &dst->page; + + if (folio_put_testzero(dst)) { + free_pages_prepare_fpi_none(page, order); + + INIT_LIST_HEAD(&dst->lru); - list_add(&dst->lru, &cc->freepages); - cc->nr_freepages++; - cc->nr_migratepages += 1 << folio_order(dst); + list_add(&dst->lru, &cc->freepages[order]); + cc->nr_freepages += 1 << order; + cc->nr_migratepages += 1 << order; + } + /* + * someone else has referenced the page, we cannot take it back to our + * free list. + */ } /* possible outcome of isolate_migratepages */ @@ -2476,6 +2496,7 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) const bool sync = cc->mode != MIGRATE_ASYNC; bool update_cached; unsigned int nr_succeeded = 0; + int order; /* * These counters track activities during zone compaction. Initialize @@ -2485,7 +2506,8 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) cc->total_free_scanned = 0; cc->nr_migratepages = 0; cc->nr_freepages = 0; - INIT_LIST_HEAD(&cc->freepages); + for (order = 0; order < NR_PAGE_ORDERS; order++) + INIT_LIST_HEAD(&cc->freepages[order]); INIT_LIST_HEAD(&cc->migratepages); cc->migratetype = gfp_migratetype(cc->gfp_mask); @@ -2671,7 +2693,7 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) * so we don't leave any returned pages behind in the next attempt. */ if (cc->nr_freepages > 0) { - unsigned long free_pfn = release_freepages(&cc->freepages); + unsigned long free_pfn = release_free_list(cc->freepages); cc->nr_freepages = 0; VM_BUG_ON(free_pfn == 0); @@ -2690,7 +2712,6 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) trace_mm_compaction_end(cc, start_pfn, end_pfn, sync, ret); - VM_BUG_ON(!list_empty(&cc->freepages)); VM_BUG_ON(!list_empty(&cc->migratepages)); return ret; diff --git a/mm/internal.h b/mm/internal.h index 1e29c5821a1d..9925291e7704 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -447,6 +447,8 @@ extern void prep_compound_page(struct page *page, unsigned int order); extern void post_alloc_hook(struct page *page, unsigned int order, gfp_t gfp_flags); +extern bool free_pages_prepare_fpi_none(struct page *page, unsigned int order); + extern int user_min_free_kbytes; extern void free_unref_page(struct page *page, unsigned int order); @@ -481,7 +483,7 @@ int split_free_page(struct page *free_page, * completes when free_pfn <= migrate_pfn */ struct compact_control { - struct list_head freepages; /* List of free pages to migrate to */ + struct list_head freepages[NR_PAGE_ORDERS]; /* List of free pages to migrate to */ struct list_head migratepages; /* List of pages being migrated */ unsigned int nr_freepages; /* Number of isolated free pages */ unsigned int nr_migratepages; /* Number of pages to migrate */ diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 7ae4b74c9e5c..e6e2ac722a82 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -1179,6 +1179,12 @@ static __always_inline bool free_pages_prepare(struct page *page, return true; } +__always_inline bool free_pages_prepare_fpi_none(struct page *page, + unsigned int order) +{ + return free_pages_prepare(page, order, FPI_NONE); +} + /* * Frees a number of pages from the PCP lists * Assumes all pages on list are in same zone. From patchwork Wed Feb 14 22:04:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zi Yan X-Patchwork-Id: 201143 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:b825:b0:106:860b:bbdd with SMTP id da37csp11652dyb; Wed, 14 Feb 2024 14:05:21 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCW274mradEOJZ17aD4WWG0uqyHf1AqJOebwlsD/Put6wx78u/ZNKu7BUg0VRY4YwQd+jDCBQz//13QrJVUJxWrZJCSS3A== X-Google-Smtp-Source: AGHT+IGNy647j8vvvdiCBXnPvUtUX91Vh0BnROpLZJjgszuOZOcGN47AnNLixEo4b6I+6i9aFs0e X-Received: by 2002:a05:6512:3e18:b0:511:5237:a357 with SMTP id i24-20020a0565123e1800b005115237a357mr60432lfv.48.1707948321332; Wed, 14 Feb 2024 14:05:21 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707948321; cv=pass; d=google.com; s=arc-20160816; b=VItue5zQRxhPkfFv0MIas0GpBnSli7Rv3XW4syxcZm0DAqe+lQfAgK7dA4zKg8lywK Ba65t2fLPYbVe02Xk4DmjiRP4kssDTyGuFDVs17R3rY6ApsCwqaiCJUG5zc2+U2fNeN0 NNWwNJI4F4z2GjpEL2KkIdCjk6lUqs0jXM4pesZ24cdPtiGVZ4zOh0BwyE2a9bZWwHcf h6xUKuZN44DXthiy1F1ROGQJv8Mov/7ppAOC4d9SDEMAut4mBcDdW4Tc0KQ94/EOFFpj ChWLN4NC01cBxTfOD30VzEcNl44Wy/4K7eHeKV1acKtf8mXDMlACxsXgqSyGa1b0L+RS 67kw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:reply-to:references:in-reply-to :message-id:date:subject:cc:to:from:feedback-id:dkim-signature :dkim-signature; bh=wQXk9BjzfNbSk+TtQUdIPTBzuKrc4Uz9jkx3jsjH0ns=; fh=+0lFy7AqKkDJkpmC61B1ja+jyfIGdQrF6Q//nE+epyA=; b=Mg1NMRurr8J3flH2xgoP83ARO3RoRR/3QNqrwAOKStekhB8cFySV85bTFhyVfIE2/O W28PbVvC+8ENBZe/4/8QF9g2Xobv4xtvcaoBGEG8fYgwx6a4wi5U7WLC9M/D+K4qwSBJ Saa9zeyiOHsI1e+IhCk3bHlVwmW9fn7Y8untmotk614cjh4cysLrMvqWS1Y96k0+CmY6 MRmWjdTnlUySD2eedjmul72AhdaAN0DqlRNXNVbtWvNsJlkwJOeCjLzb9rwPZRhP6xt3 izWdirgkux3LqK4egB/c2X2rsipdfgsDtRNsRAetkM5b7WDzo14jymcKHikdI5qT2JdN NhJA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sent.com header.s=fm3 header.b=TYVPJiuB; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=HqHud2bg; arc=pass (i=1 spf=pass spfdomain=sent.com dkim=pass dkdomain=sent.com dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=sent.com); spf=pass (google.com: domain of linux-kernel+bounces-66023-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66023-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sent.com X-Forwarded-Encrypted: i=2; AJvYcCVDBMsycZX6YDIFQnOHDb4qqbuVBWNDXpoyjbVW+OXs0gr2n3+daIXmZBkPQQh6P3dM33sY5TyFLr2aQHSTrcKBZZ3CjA== Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id r15-20020a05640251cf00b00561eff0b0cesi2308180edd.397.2024.02.14.14.05.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 14:05:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-66023-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@sent.com header.s=fm3 header.b=TYVPJiuB; dkim=pass header.i=@messagingengine.com header.s=fm3 header.b=HqHud2bg; arc=pass (i=1 spf=pass spfdomain=sent.com dkim=pass dkdomain=sent.com dkim=pass dkdomain=messagingengine.com dmarc=pass fromdomain=sent.com); spf=pass (google.com: domain of linux-kernel+bounces-66023-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-66023-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sent.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id BE47D1F2674B for ; Wed, 14 Feb 2024 22:05:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4B20B1420D0; Wed, 14 Feb 2024 22:04:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sent.com header.i=@sent.com header.b="TYVPJiuB"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="HqHud2bg" Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C7A2141988 for ; Wed, 14 Feb 2024 22:04:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=66.111.4.28 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707948281; cv=none; b=qK9H2H7YiRBEzRe1lTpMfGDZgbTQ+ae1njgv3icR5zVEzETHpMv1mbFN3Gg1LzlianIRm6trABmkRa1WIeI844ydsg320tXHgOaiDRrZaHh+5EQnxJ6OIBDjIPhW6Dt97HTXhFEDkWwtoRvH/Oyyy0M1bQOfzmca4PLwvUHN/II= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707948281; c=relaxed/simple; bh=g9C2eZyu0HruNfOf1LAuN/17P6rNfDs6CE3m85il8Yc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YP6xn+dB2+69EtovrUzPiU3K6+grDT/typ9A0keu3n96ps1RFd+ji/TO78C45dZWAgO3yIbpx/iXFo46lZIBT8+jUyCvxv00PepUD69NjlYXJKf3bkSRqYe9b9saYsjgGDLSxV3qivsVZY+2hEexOHCzS4issrGmM0f6qHgnxXo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sent.com; spf=pass smtp.mailfrom=sent.com; dkim=pass (2048-bit key) header.d=sent.com header.i=@sent.com header.b=TYVPJiuB; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=HqHud2bg; arc=none smtp.client-ip=66.111.4.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sent.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sent.com Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id A39FC5C0086; Wed, 14 Feb 2024 17:04:38 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 14 Feb 2024 17:04:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sent.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to; s=fm3; t= 1707948278; x=1708034678; bh=wQXk9BjzfNbSk+TtQUdIPTBzuKrc4Uz9jkx 3jsjH0ns=; b=TYVPJiuB1JXeQIw8A86L+E6UEI1u4J6XAa1bTxbdRDxlLKK6T9f 1SKgzazMOLcJAFUvzSSe18CwB8JAk2lGIinVMXUswOyaPYyU9MKcZ/0gUG64DlE+ iotkdloZi8W6SU2CDx3DdY7EyzM4xvyJVxZZXLb5ff1heJw+9iG2AHeNEz3Vm3lj KYJcFrSuBUbv53jyQs8E7fCmqs9LxBVjqDdldFm5CkZF1muz32jl8CoUn1UbTF70 Hpfr5MD9QtU/YpuKYeeNKkTfxw9sVc1pVyr+UFOYioNEyEBUrSfbC7kgo2FHy2eA O++9ITQ1VvlZC0PuQw3c7pKO3pQV4eCgbeg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:reply-to:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1707948278; x=1708034678; bh=wQXk9BjzfNbSk+TtQUdIPTBzuKrc4Uz9jkx 3jsjH0ns=; b=HqHud2bgtxbuleg7JIQcX/6DijCsT84RWDVT6WNJueqIH8OoZz5 QHc0wZ5e0+c0P8e1gDZj/PLns77lLJU3OurXalw7lsCU4Ozff3kzIBlFICbROKz5 Wr63YF3Tp0rb5FvwOHBYA3QDMQpVhypJkSEx/uO5DTSDYRpsgdmNIP3pslQiQaDX R7ja2MceSRwLgMR0gMRqB/E973AYvLWD9U7gB4OECl3nI5kGjlQtFHMREofZCpAt fMzWhn4bnRDdT0k6lOwItkdiP264YIQXALVJgNDiwRHlAiyu1Ka+tknWutKzxjcG aEzhxaMbrq/v1MZr5B2/dFn5qCJbKuW35jg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudejgdduheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhhrgggtgfesthekredtredtjeenucfhrhhomhepkghi ucgjrghnuceoiihirdihrghnsehsvghnthdrtghomheqnecuggftrfgrthhtvghrnhepje ekteekffelleekudfftdefvddtjeejuedtuedtteegjefgvedtfedujeekieevnecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepiihirdihrghnse hsvghnthdrtghomh X-ME-Proxy: Feedback-ID: iccd040f4:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Feb 2024 17:04:37 -0500 (EST) From: Zi Yan To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Zi Yan , "Huang, Ying" , Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , David Hildenbrand , "Yin, Fengwei" , Yu Zhao , Vlastimil Babka , "Kirill A . Shutemov" , Johannes Weiner , Baolin Wang , Kemeng Shi , Mel Gorman , Rohan Puri , Mcgrof Chamberlain , Adam Manzanares , "Vishal Moola (Oracle)" Subject: [PATCH v5 3/3] mm/compaction: optimize >0 order folio compaction with free page split. Date: Wed, 14 Feb 2024 17:04:20 -0500 Message-ID: <20240214220420.1229173-4-zi.yan@sent.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240214220420.1229173-1-zi.yan@sent.com> References: <20240214220420.1229173-1-zi.yan@sent.com> Reply-To: Zi Yan Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790913619038015105 X-GMAIL-MSGID: 1790913619038015105 From: Zi Yan During migration in a memory compaction, free pages are placed in an array of page lists based on their order. But the desired free page order (i.e., the order of a source page) might not be always present, thus leading to migration failures and premature compaction termination. Split a high order free pages when source migration page has a lower order to increase migration successful rate. Note: merging free pages when a migration fails and a lower order free page is returned via compaction_free() is possible, but there is too much work. Since the free pages are not buddy pages, it is hard to identify these free pages using existing PFN-based page merging algorithm. Signed-off-by: Zi Yan Reviewed-by: Baolin Wang Tested-by: Baolin Wang Tested-by: Yu Zhao Cc: Adam Manzanares Cc: David Hildenbrand Cc: Huang Ying Cc: Johannes Weiner Cc: Kemeng Shi Cc: Kirill A. Shutemov Cc: Luis Chamberlain Cc: Matthew Wilcox (Oracle) Cc: Mel Gorman Cc: Ryan Roberts Cc: Vishal Moola (Oracle) Cc: Vlastimil Babka Cc: Yin Fengwei Reviewed-by: Vlastimil Babka --- mm/compaction.c | 35 ++++++++++++++++++++++++++++++----- 1 file changed, 30 insertions(+), 5 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index d0a05a621b67..b261c5f13bef 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1832,15 +1832,40 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) struct compact_control *cc = (struct compact_control *)data; struct folio *dst; int order = folio_order(src); + bool has_isolated_pages = false; + int start_order; + struct page *freepage; + unsigned long size; + +again: + for (start_order = order; start_order < NR_PAGE_ORDERS; start_order++) + if (!list_empty(&cc->freepages[start_order])) + break; - if (list_empty(&cc->freepages[order])) { - isolate_freepages(cc); - if (list_empty(&cc->freepages[order])) + /* no free pages in the list */ + if (start_order == NR_PAGE_ORDERS) { + if (has_isolated_pages) return NULL; + isolate_freepages(cc); + has_isolated_pages = true; + goto again; + } + + freepage = list_first_entry(&cc->freepages[start_order], struct page, + lru); + size = 1 << start_order; + + list_del(&freepage->lru); + + while (start_order > order) { + start_order--; + size >>= 1; + + list_add(&freepage[size].lru, &cc->freepages[start_order]); + set_page_private(&freepage[size], start_order); } + dst = (struct folio *)freepage; - dst = list_first_entry(&cc->freepages[order], struct folio, lru); - list_del(&dst->lru); post_alloc_hook(&dst->page, order, __GFP_MOVABLE); if (order) prep_compound_page(&dst->page, order);