From patchwork Wed Feb 14 07:22:54 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hsin-Yi Wang X-Patchwork-Id: 200842 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp1042657dyb; Tue, 13 Feb 2024 23:25:04 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX0Ck6X9NCLpbY44Ugz36fcjXFX52k2LfenWKyIjCxk/VdRyl5ZVterv45yAt/YJ1FT9f/WRPsaYy/S231WyxLzbR5+Ag== X-Google-Smtp-Source: AGHT+IEw6SxygHr8vWmuo8r4+RLpTqnwT95XlNP+8YqbQaUu8FOUtiwmPWgbFsU6f0cJ/QwztpAu X-Received: by 2002:ac8:5d4e:0:b0:42c:67f9:4cff with SMTP id g14-20020ac85d4e000000b0042c67f94cffmr2426043qtx.48.1707895503897; Tue, 13 Feb 2024 23:25:03 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707895503; cv=pass; d=google.com; s=arc-20160816; b=PajIQNDX+yb8806KSRmydWNSybA6LKajeHDOtTnL8HBrFvq3V6JGKadt2gsBJWz81N 7ujNBf9IEsg9lt1oINM/4Bxryl0vcC81s+y3dwIaWhzF19vXV+ctm0jiQUPzL/9wY7lF /RYxD72+rw20GstfQgXOgOUfVvb1rv8nPSSi5Z7ydQX5OyQScWcw0kd1zTbs5px/w2VL iQ2bZ80H5Up8JMVPM2iBytitMfMiVier2wb5qFCxv5C/iiRMeF8147LNunKmy85NUNzg mFhidXnAwt6lTxsbz2VBH8ikjhogvGiovoAy35V1jfR0KdLdRZzIi51xuLrYXza68X6T Elow== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=sg/3QYKNiqClt5O0Rsi2fxy3eaHE++NDSM8zl4s0ReY=; fh=/7+/ZQK0OqlxSVuIN2xw2z58dupZQUNWpMTKy642cPc=; b=e8FckRwdFssV/dxQTjaAd9/xXbnMYZTqYUrd+VOU59x00W4yOB9JUP0hrGvibIoda6 AW5ujPojj97eyn4WM4PmdYWkslNEBQ40RSiUirfpoMp8lzk4epqWhApxmCiFjnkZMMAX SIrxKSNlyhBK1ge7sj63gYgcgG9wnt5aLV5fi+JHnHcSRVy6+HD8SlKtUzCVYCc4J6tE 4kORh00oN+RSNc+KPX8yzh+KpGvfy2ooT5eqSQWj1V6owclOD1bk9xvvHQZssLR7DMXh 9sq4h0T7ApnvuUrqMaoIj9kXKVr+IcqeKXJQyLs69NGGj3IKBneLm+b+1ZXVTV1ChQZh bAeA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=UCWbp50Y; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-64831-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-64831-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org X-Forwarded-Encrypted: i=2; AJvYcCUQVDGIGbMIMGC+v3T3xHl6L8Li2sRDGwqxLAUT2wX3CZx0HlgvUL/6P2DQOqd5Tirz/fkv2Xv4BjcA3MvBrJ/87JdDEw== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id w9-20020ac857c9000000b0042c7c95becbsi5003787qta.265.2024.02.13.23.25.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 23:25:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-64831-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=UCWbp50Y; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-64831-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-64831-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A0DA91C23358 for ; Wed, 14 Feb 2024 07:25:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 72D4411C84; Wed, 14 Feb 2024 07:24:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="UCWbp50Y" Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 570A010A2C for ; Wed, 14 Feb 2024 07:24:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707895488; cv=none; b=di6e7zzqZsaRMnP5cqVbdvn5HJplq5V8n6i0TX0QNqvxEnzVlyc0LlQOu0dwu3dWH6MUj8rarbtE/3F9k1jw5rDglmplXrAEFX4D/TsqY+FcZRISjg11c5D0+ngd5Sxl4BLKsgnGYIRQnSEiNofzHVFzaXuCC14HoYGo4AR8xTM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707895488; c=relaxed/simple; bh=XMsYQSn4+iYQiua8f57NL1Mz4S82ZkbiMxdXhjqPYio=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Nn9BllDxO94rAhKSYpGAPDK+6g0C88P5K8WBtHTNn6VEUhsj9Ixwi7t2bLr9DVnOPvvGgfGaZQ9LjWu2m0tuo8qfs2omLEUIaDAavnBYIRX123eD7IJXAAeKlJbZ0lrP3DvL4cJtMTpEsMn1jP92bqocjcrUnhD3QKBdBiGVnTU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=UCWbp50Y; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6e10e50179bso107083b3a.1 for ; Tue, 13 Feb 2024 23:24:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1707895486; x=1708500286; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=sg/3QYKNiqClt5O0Rsi2fxy3eaHE++NDSM8zl4s0ReY=; b=UCWbp50YFwEzKIK86LI/gXG1qbtiLDN9aMGQUEZX+OWEJEveaz1FJkeFDnucBWbW5d CUnmCNR+LRR1eGQctjTyUQJddI+/n+w/hOH1gmVvYcWmI5PZ5swB76buUIBR5ODls9Fw xnwyy97/WUTT02v+QRZIDJWrYmIi+/kA1Syxw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707895486; x=1708500286; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sg/3QYKNiqClt5O0Rsi2fxy3eaHE++NDSM8zl4s0ReY=; b=lEv8vhf4a1EcjSr8KEcB+So1fizM1uol9B3eHYiN/HdwhOg8yM0xfsvIqZrfxvG91W w8tWbKB9BH660Ypqe7PPSV8g0vr7Rcx/+I0K/jWGGV2cfIYItM4jzFlPTv/GRYeNR8jQ VPKDnjGGPamPRj4ueaTdV7obziUxACzvSEunrdYdMbcw8mvDpJs7QYQByR+FFrE7xV6i GbA3Hz9rCVNDLG/QStTNgbyN6s2WPGeW+DP6RtYGBLDt0cjx6s/Kh+NAxDj3s6A5+BRu tO6wG7KphVUAhy4PjACJeDLtJZsSaewg5xX0Pfw8/nmO250b8KwP9J86mxmqhdjOtrVj 2rVA== X-Forwarded-Encrypted: i=1; AJvYcCXQDXZ+U5hm5fa6z4wcVOnfsB4iGsWnuURfmsqdbVQ8zMPcXfbTDFcG8EM8zp1FCNMyeZqiyhmeQ4Kn9Ls1JJPGRvfcpBPXfITY4Qa0 X-Gm-Message-State: AOJu0Yzq24Ojq4m8q+atY+2+DMFOL1FdDv/acbYhA1B37CX4uhxSO7fR ZXKgCWGa/qIrGIWJiyRyeHLxO7PiKVFulzqgqRJwGOGirh59kaNcuRuMwHeung== X-Received: by 2002:a05:6a00:80ce:b0:6de:3b41:2845 with SMTP id ei14-20020a056a0080ce00b006de3b412845mr1267315pfb.32.1707895486644; Tue, 13 Feb 2024 23:24:46 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCX4/g6RttGYyHt4IsNRLuOZdesxIRm+ez9N3te0y7PNHNxkbAq/gfLjGQNAA8z6y+2HAxio50rLlkidsgRuThahQI8gXckBUsWdA7WZSzQiAcxb9SpIVyMkSsKgMzrtEAlr3TgSM7nIUhWLvxGINc8amjEYn+9pFOzlyVoI4HYAKPM4UERGfxjzs7RVfiojfETdZdXgnKWA3WDuMfCwjahbDVCNano0PFs6wUC99uaefO1NT3sek53MrBW3QXKnSJfKtt1NcCV77IleVY0RoP5BaLqylO0kcdhmOzn8T6x6/F+JSQ8hVsMM6v3fakLTpryWxM6hDn+4NZdHBuQklWp/1ewEIyZWPif76A== Received: from hsinyi.sjc.corp.google.com ([2620:15c:9d:2:3a01:e2cd:4e75:f52d]) by smtp.gmail.com with ESMTPSA id n8-20020aa78a48000000b006e03bc76711sm8548314pfa.165.2024.02.13.23.24.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 23:24:46 -0800 (PST) From: Hsin-Yi Wang To: Douglas Anderson , dri-devel@lists.freedesktop.org Cc: Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org Subject: [PATCH] Revert "drm/panel-edp: Add auo_b116xa3_mode" Date: Tue, 13 Feb 2024 23:22:54 -0800 Message-ID: <20240214072435.1496536-2-hsinyi@chromium.org> X-Mailer: git-send-email 2.43.0.687.g38aa6559b0-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790858235946953349 X-GMAIL-MSGID: 1790858235946953349 This reverts commit 70e0d5550f5cec301ad116703b840a539fe985dc. The overridden mode fixes the panel glitching issue on mt8186 chromebook. However, it causes the internal display not working on mt8173 chromebook. Revert the overridden mode for now to let mt8173 have a functional display. Signed-off-by: Hsin-Yi Wang Reviewed-by: Douglas Anderson --- drivers/gpu/drm/panel/panel-edp.c | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index 7d556b1bfa82..bd71d239272a 100644 --- a/drivers/gpu/drm/panel/panel-edp.c +++ b/drivers/gpu/drm/panel/panel-edp.c @@ -1002,19 +1002,6 @@ static const struct panel_desc auo_b101ean01 = { }, }; -static const struct drm_display_mode auo_b116xa3_mode = { - .clock = 70589, - .hdisplay = 1366, - .hsync_start = 1366 + 40, - .hsync_end = 1366 + 40 + 40, - .htotal = 1366 + 40 + 40 + 32, - .vdisplay = 768, - .vsync_start = 768 + 10, - .vsync_end = 768 + 10 + 12, - .vtotal = 768 + 10 + 12 + 6, - .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, -}; - static const struct drm_display_mode auo_b116xak01_mode = { .clock = 69300, .hdisplay = 1366, @@ -1963,12 +1950,10 @@ static const struct edp_panel_entry edp_panels[] = { EDP_PANEL_ENTRY('A', 'U', 'O', 0x239b, &delay_200_500_e50, "B116XAN06.1"), EDP_PANEL_ENTRY('A', 'U', 'O', 0x255c, &delay_200_500_e50, "B116XTN02.5"), EDP_PANEL_ENTRY('A', 'U', 'O', 0x403d, &delay_200_500_e50, "B140HAN04.0"), - EDP_PANEL_ENTRY2('A', 'U', 'O', 0x405c, &auo_b116xak01.delay, "B116XAK01.0", - &auo_b116xa3_mode), + EDP_PANEL_ENTRY('A', 'U', 'O', 0x405c, &auo_b116xak01.delay, "B116XAK01.0"), EDP_PANEL_ENTRY('A', 'U', 'O', 0x435c, &delay_200_500_e50, "Unknown"), EDP_PANEL_ENTRY('A', 'U', 'O', 0x582d, &delay_200_500_e50, "B133UAN01.0"), - EDP_PANEL_ENTRY2('A', 'U', 'O', 0x615c, &delay_200_500_e50, "B116XAN06.1", - &auo_b116xa3_mode), + EDP_PANEL_ENTRY('A', 'U', 'O', 0x615c, &delay_200_500_e50, "B116XAN06.1"), EDP_PANEL_ENTRY('A', 'U', 'O', 0x635c, &delay_200_500_e50, "B116XAN06.3"), EDP_PANEL_ENTRY('A', 'U', 'O', 0x639c, &delay_200_500_e50, "B140HAK02.7"), EDP_PANEL_ENTRY('A', 'U', 'O', 0x723c, &delay_200_500_e50, "B140XTN07.2"),